Completed
Pull Request — master (#4890)
by Blizzz
17:27
created
settings/Controller/CommonSettingsTrait.php 1 patch
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -51,6 +51,9 @@  discard block
 block discarded – undo
51 51
 		];
52 52
 	}
53 53
 
54
+	/**
55
+	 * @param string $type
56
+	 */
54 57
 	protected function formatSections($sections, $currentSection, $type) {
55 58
 		$templateParameters = [];
56 59
 		/** @var \OCP\Settings\ISection[] $prioritizedSections */
@@ -81,6 +84,9 @@  discard block
 block discarded – undo
81 84
 		return $templateParameters;
82 85
 	}
83 86
 
87
+	/**
88
+	 * @param string $currentSections
89
+	 */
84 90
 	protected function formatPersonalSections($currentSections) {
85 91
 		$sections = $this->settingsManager->getPersonalSections();
86 92
 		$templateParameters = $this->formatSections($sections, $currentSections, 'personal');
@@ -88,6 +94,9 @@  discard block
 block discarded – undo
88 94
 		return $templateParameters;
89 95
 	}
90 96
 
97
+	/**
98
+	 * @param string $currentSections
99
+	 */
91 100
 	protected function formatAdminSections($currentSections) {
92 101
 		$sections = $this->settingsManager->getAdminSections();
93 102
 		$templateParameters = $this->formatSections($sections, $currentSections, 'admin');
@@ -111,6 +120,9 @@  discard block
 block discarded – undo
111 120
 		return ['content' => $html];
112 121
 	}
113 122
 
123
+	/**
124
+	 * @param string $section
125
+	 */
114 126
 	private function getIndexResponse($section) {
115 127
 		$templateParams = [];
116 128
 		$templateParams = array_merge($templateParams, $this->getNavigationParameters($section));
Please login to merge, or discard this patch.
lib/private/Settings/Manager.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -265,6 +265,9 @@  discard block
 block discarded – undo
265 265
 		return $this->mapper->has($table, $className);
266 266
 	}
267 267
 
268
+	/**
269
+	 * @param string $type
270
+	 */
268 271
 	private function setupSettingsEntry($settingsClassName, $type) {
269 272
 		if (!class_exists($settingsClassName)) {
270 273
 			$this->log->debug('Could not find ' . $type . ' section class ' . $settingsClassName);
@@ -294,6 +297,9 @@  discard block
 block discarded – undo
294 297
 		}
295 298
 	}
296 299
 
300
+	/**
301
+	 * @param string $type
302
+	 */
297 303
 	private function getSectionTableForType($type) {
298 304
 		if($type === 'admin') {
299 305
 			return Mapper::TABLE_ADMIN_SECTIONS;
Please login to merge, or discard this patch.