Passed
Push — master ( 27fb46...dad31c )
by rakekniven
15:02 queued 12s
created
core/Command/Integrity/SignCore.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
 			$this->checker->writeCoreSignature($x509, $rsa, $path);
100 100
 			$output->writeln('Successfully signed "core"');
101 101
 		} catch (\Exception $e) {
102
-			$output->writeln('Error: ' . $e->getMessage());
102
+			$output->writeln('Error: '.$e->getMessage());
103 103
 			return 1;
104 104
 		}
105 105
 		return 0;
Please login to merge, or discard this patch.
Indentation   +57 added lines, -57 removed lines patch added patch discarded remove patch
@@ -39,69 +39,69 @@
 block discarded – undo
39 39
  * @package OC\Core\Command\Integrity
40 40
  */
41 41
 class SignCore extends Command {
42
-	/** @var Checker */
43
-	private $checker;
44
-	/** @var FileAccessHelper */
45
-	private $fileAccessHelper;
42
+    /** @var Checker */
43
+    private $checker;
44
+    /** @var FileAccessHelper */
45
+    private $fileAccessHelper;
46 46
 
47
-	/**
48
-	 * @param Checker $checker
49
-	 * @param FileAccessHelper $fileAccessHelper
50
-	 */
51
-	public function __construct(Checker $checker,
52
-								FileAccessHelper $fileAccessHelper) {
53
-		parent::__construct(null);
54
-		$this->checker = $checker;
55
-		$this->fileAccessHelper = $fileAccessHelper;
56
-	}
47
+    /**
48
+     * @param Checker $checker
49
+     * @param FileAccessHelper $fileAccessHelper
50
+     */
51
+    public function __construct(Checker $checker,
52
+                                FileAccessHelper $fileAccessHelper) {
53
+        parent::__construct(null);
54
+        $this->checker = $checker;
55
+        $this->fileAccessHelper = $fileAccessHelper;
56
+    }
57 57
 
58
-	protected function configure() {
59
-		$this
60
-			->setName('integrity:sign-core')
61
-			->setDescription('Sign core using a private key.')
62
-			->addOption('privateKey', null, InputOption::VALUE_REQUIRED, 'Path to private key to use for signing')
63
-			->addOption('certificate', null, InputOption::VALUE_REQUIRED, 'Path to certificate to use for signing')
64
-			->addOption('path', null, InputOption::VALUE_REQUIRED, 'Path of core to sign');
65
-	}
58
+    protected function configure() {
59
+        $this
60
+            ->setName('integrity:sign-core')
61
+            ->setDescription('Sign core using a private key.')
62
+            ->addOption('privateKey', null, InputOption::VALUE_REQUIRED, 'Path to private key to use for signing')
63
+            ->addOption('certificate', null, InputOption::VALUE_REQUIRED, 'Path to certificate to use for signing')
64
+            ->addOption('path', null, InputOption::VALUE_REQUIRED, 'Path of core to sign');
65
+    }
66 66
 
67
-	/**
68
-	 * {@inheritdoc }
69
-	 */
70
-	protected function execute(InputInterface $input, OutputInterface $output): int {
71
-		$privateKeyPath = $input->getOption('privateKey');
72
-		$keyBundlePath = $input->getOption('certificate');
73
-		$path = $input->getOption('path');
74
-		if (is_null($privateKeyPath) || is_null($keyBundlePath) || is_null($path)) {
75
-			$output->writeln('--privateKey, --certificate and --path are required.');
76
-			return 1;
77
-		}
67
+    /**
68
+     * {@inheritdoc }
69
+     */
70
+    protected function execute(InputInterface $input, OutputInterface $output): int {
71
+        $privateKeyPath = $input->getOption('privateKey');
72
+        $keyBundlePath = $input->getOption('certificate');
73
+        $path = $input->getOption('path');
74
+        if (is_null($privateKeyPath) || is_null($keyBundlePath) || is_null($path)) {
75
+            $output->writeln('--privateKey, --certificate and --path are required.');
76
+            return 1;
77
+        }
78 78
 
79
-		$privateKey = $this->fileAccessHelper->file_get_contents($privateKeyPath);
80
-		$keyBundle = $this->fileAccessHelper->file_get_contents($keyBundlePath);
79
+        $privateKey = $this->fileAccessHelper->file_get_contents($privateKeyPath);
80
+        $keyBundle = $this->fileAccessHelper->file_get_contents($keyBundlePath);
81 81
 
82
-		if ($privateKey === false) {
83
-			$output->writeln(sprintf('Private key "%s" does not exists.', $privateKeyPath));
84
-			return 1;
85
-		}
82
+        if ($privateKey === false) {
83
+            $output->writeln(sprintf('Private key "%s" does not exists.', $privateKeyPath));
84
+            return 1;
85
+        }
86 86
 
87
-		if ($keyBundle === false) {
88
-			$output->writeln(sprintf('Certificate "%s" does not exists.', $keyBundlePath));
89
-			return 1;
90
-		}
87
+        if ($keyBundle === false) {
88
+            $output->writeln(sprintf('Certificate "%s" does not exists.', $keyBundlePath));
89
+            return 1;
90
+        }
91 91
 
92
-		$rsa = new RSA();
93
-		$rsa->loadKey($privateKey);
94
-		$x509 = new X509();
95
-		$x509->loadX509($keyBundle);
96
-		$x509->setPrivateKey($rsa);
92
+        $rsa = new RSA();
93
+        $rsa->loadKey($privateKey);
94
+        $x509 = new X509();
95
+        $x509->loadX509($keyBundle);
96
+        $x509->setPrivateKey($rsa);
97 97
 
98
-		try {
99
-			$this->checker->writeCoreSignature($x509, $rsa, $path);
100
-			$output->writeln('Successfully signed "core"');
101
-		} catch (\Exception $e) {
102
-			$output->writeln('Error: ' . $e->getMessage());
103
-			return 1;
104
-		}
105
-		return 0;
106
-	}
98
+        try {
99
+            $this->checker->writeCoreSignature($x509, $rsa, $path);
100
+            $output->writeln('Successfully signed "core"');
101
+        } catch (\Exception $e) {
102
+            $output->writeln('Error: ' . $e->getMessage());
103
+            return 1;
104
+        }
105
+        return 0;
106
+    }
107 107
 }
Please login to merge, or discard this patch.
core/Command/TwoFactorAuth/Base.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
 	 */
52 52
 	public function completeArgumentValues($argumentName, CompletionContext $context) {
53 53
 		if ($argumentName === 'uid') {
54
-			return array_map(function (IUser $user) {
54
+			return array_map(function(IUser $user) {
55 55
 				return $user->getUID();
56 56
 			}, $this->userManager->search($context->getCurrentWord(), 100));
57 57
 		}
Please login to merge, or discard this patch.
Indentation   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -31,33 +31,33 @@
 block discarded – undo
31 31
 
32 32
 class Base extends \OC\Core\Command\Base {
33 33
 
34
-	/** @var IUserManager */
35
-	protected $userManager;
34
+    /** @var IUserManager */
35
+    protected $userManager;
36 36
 
37
-	/**
38
-	 * Return possible values for the named option
39
-	 *
40
-	 * @param string $optionName
41
-	 * @param CompletionContext $context
42
-	 * @return string[]
43
-	 */
44
-	public function completeOptionValues($optionName, CompletionContext $context) {
45
-		return [];
46
-	}
37
+    /**
38
+     * Return possible values for the named option
39
+     *
40
+     * @param string $optionName
41
+     * @param CompletionContext $context
42
+     * @return string[]
43
+     */
44
+    public function completeOptionValues($optionName, CompletionContext $context) {
45
+        return [];
46
+    }
47 47
 
48
-	/**
49
-	 * Return possible values for the named argument
50
-	 *
51
-	 * @param string $argumentName
52
-	 * @param CompletionContext $context
53
-	 * @return string[]
54
-	 */
55
-	public function completeArgumentValues($argumentName, CompletionContext $context) {
56
-		if ($argumentName === 'uid') {
57
-			return array_map(function (IUser $user) {
58
-				return $user->getUID();
59
-			}, $this->userManager->search($context->getCurrentWord(), 100));
60
-		}
61
-		return [];
62
-	}
48
+    /**
49
+     * Return possible values for the named argument
50
+     *
51
+     * @param string $argumentName
52
+     * @param CompletionContext $context
53
+     * @return string[]
54
+     */
55
+    public function completeArgumentValues($argumentName, CompletionContext $context) {
56
+        if ($argumentName === 'uid') {
57
+            return array_map(function (IUser $user) {
58
+                return $user->getUID();
59
+            }, $this->userManager->search($context->getCurrentWord(), 100));
60
+        }
61
+        return [];
62
+    }
63 63
 }
Please login to merge, or discard this patch.
core/Command/Background/Ajax.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 namespace OC\Core\Command\Background;
27 27
 
28 28
 class Ajax extends Base {
29
-	protected function getMode() {
30
-		return 'ajax';
31
-	}
29
+    protected function getMode() {
30
+        return 'ajax';
31
+    }
32 32
 }
Please login to merge, or discard this patch.
core/Command/Background/Cron.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 namespace OC\Core\Command\Background;
27 27
 
28 28
 class Cron extends Base {
29
-	protected function getMode() {
30
-		return 'cron';
31
-	}
29
+    protected function getMode() {
30
+        return 'cron';
31
+    }
32 32
 }
Please login to merge, or discard this patch.
core/Command/Background/WebCron.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 namespace OC\Core\Command\Background;
27 27
 
28 28
 class WebCron extends Base {
29
-	protected function getMode() {
30
-		return 'webcron';
31
-	}
29
+    protected function getMode() {
30
+        return 'webcron';
31
+    }
32 32
 }
Please login to merge, or discard this patch.
core/Command/Encryption/ListModules.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -67,11 +67,11 @@
 block discarded – undo
67 67
 	 */
68 68
 	protected function writeModuleList(InputInterface $input, OutputInterface $output, $items) {
69 69
 		if ($input->getOption('output') === self::OUTPUT_FORMAT_PLAIN) {
70
-			array_walk($items, function (&$item) {
70
+			array_walk($items, function(&$item) {
71 71
 				if (!$item['default']) {
72 72
 					$item = $item['displayName'];
73 73
 				} else {
74
-					$item = $item['displayName'] . ' [default*]';
74
+					$item = $item['displayName'].' [default*]';
75 75
 				}
76 76
 			});
77 77
 		}
Please login to merge, or discard this patch.
Indentation   +57 added lines, -57 removed lines patch added patch discarded remove patch
@@ -31,70 +31,70 @@
 block discarded – undo
31 31
 use Symfony\Component\Console\Output\OutputInterface;
32 32
 
33 33
 class ListModules extends Base {
34
-	/** @var IManager */
35
-	protected $encryptionManager;
34
+    /** @var IManager */
35
+    protected $encryptionManager;
36 36
 
37
-	/** @var IConfig */
38
-	protected $config;
37
+    /** @var IConfig */
38
+    protected $config;
39 39
 
40
-	/**
41
-	 * @param IManager $encryptionManager
42
-	 * @param IConfig $config
43
-	 */
44
-	public function __construct(
45
-		IManager $encryptionManager,
46
-		IConfig $config
47
-	) {
48
-		parent::__construct();
49
-		$this->encryptionManager = $encryptionManager;
50
-		$this->config = $config;
51
-	}
40
+    /**
41
+     * @param IManager $encryptionManager
42
+     * @param IConfig $config
43
+     */
44
+    public function __construct(
45
+        IManager $encryptionManager,
46
+        IConfig $config
47
+    ) {
48
+        parent::__construct();
49
+        $this->encryptionManager = $encryptionManager;
50
+        $this->config = $config;
51
+    }
52 52
 
53
-	protected function configure() {
54
-		parent::configure();
53
+    protected function configure() {
54
+        parent::configure();
55 55
 
56
-		$this
57
-			->setName('encryption:list-modules')
58
-			->setDescription('List all available encryption modules')
59
-		;
60
-	}
56
+        $this
57
+            ->setName('encryption:list-modules')
58
+            ->setDescription('List all available encryption modules')
59
+        ;
60
+    }
61 61
 
62
-	protected function execute(InputInterface $input, OutputInterface $output): int {
63
-		$isMaintenanceModeEnabled = $this->config->getSystemValue('maintenance', false);
64
-		if ($isMaintenanceModeEnabled) {
65
-			$output->writeln("Maintenance mode must be disabled when listing modules");
66
-			$output->writeln("in order to list the relevant encryption modules correctly.");
67
-			return 1;
68
-		}
62
+    protected function execute(InputInterface $input, OutputInterface $output): int {
63
+        $isMaintenanceModeEnabled = $this->config->getSystemValue('maintenance', false);
64
+        if ($isMaintenanceModeEnabled) {
65
+            $output->writeln("Maintenance mode must be disabled when listing modules");
66
+            $output->writeln("in order to list the relevant encryption modules correctly.");
67
+            return 1;
68
+        }
69 69
 
70
-		$encryptionModules = $this->encryptionManager->getEncryptionModules();
71
-		$defaultEncryptionModuleId = $this->encryptionManager->getDefaultEncryptionModuleId();
70
+        $encryptionModules = $this->encryptionManager->getEncryptionModules();
71
+        $defaultEncryptionModuleId = $this->encryptionManager->getDefaultEncryptionModuleId();
72 72
 
73
-		$encModules = [];
74
-		foreach ($encryptionModules as $module) {
75
-			$encModules[$module['id']]['displayName'] = $module['displayName'];
76
-			$encModules[$module['id']]['default'] = $module['id'] === $defaultEncryptionModuleId;
77
-		}
78
-		$this->writeModuleList($input, $output, $encModules);
79
-		return 0;
80
-	}
73
+        $encModules = [];
74
+        foreach ($encryptionModules as $module) {
75
+            $encModules[$module['id']]['displayName'] = $module['displayName'];
76
+            $encModules[$module['id']]['default'] = $module['id'] === $defaultEncryptionModuleId;
77
+        }
78
+        $this->writeModuleList($input, $output, $encModules);
79
+        return 0;
80
+    }
81 81
 
82
-	/**
83
-	 * @param InputInterface $input
84
-	 * @param OutputInterface $output
85
-	 * @param array $items
86
-	 */
87
-	protected function writeModuleList(InputInterface $input, OutputInterface $output, $items) {
88
-		if ($input->getOption('output') === self::OUTPUT_FORMAT_PLAIN) {
89
-			array_walk($items, function (&$item) {
90
-				if (!$item['default']) {
91
-					$item = $item['displayName'];
92
-				} else {
93
-					$item = $item['displayName'] . ' [default*]';
94
-				}
95
-			});
96
-		}
82
+    /**
83
+     * @param InputInterface $input
84
+     * @param OutputInterface $output
85
+     * @param array $items
86
+     */
87
+    protected function writeModuleList(InputInterface $input, OutputInterface $output, $items) {
88
+        if ($input->getOption('output') === self::OUTPUT_FORMAT_PLAIN) {
89
+            array_walk($items, function (&$item) {
90
+                if (!$item['default']) {
91
+                    $item = $item['displayName'];
92
+                } else {
93
+                    $item = $item['displayName'] . ' [default*]';
94
+                }
95
+            });
96
+        }
97 97
 
98
-		$this->writeArrayInOutputFormat($input, $output, $items);
99
-	}
98
+        $this->writeArrayInOutputFormat($input, $output, $items);
99
+    }
100 100
 }
Please login to merge, or discard this patch.
core/templates/twofactorshowchallenge.php 2 patches
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,8 +16,11 @@
 block discarded – undo
16 16
 	<?php if ($error): ?>
17 17
 			<?php if ($error_message): ?>
18 18
 				<p><strong><?php p($error_message); ?></strong></p>
19
-			<?php else: ?>
20
-				<p><strong><?php p($l->t('Error while validating your second factor')); ?></strong></p>
19
+			<?php else {
20
+    : ?>
21
+				<p><strong><?php p($l->t('Error while validating your second factor'));
22
+}
23
+?></strong></p>
21 24
 			<?php endif; ?>
22 25
 	<?php endif; ?>
23 26
 	<?php print_unescaped($template); ?>
Please login to merge, or discard this patch.
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -24,11 +24,11 @@
 block discarded – undo
24 24
 	<?php if (!is_null($_['backupProvider'])): ?>
25 25
 	<p>
26 26
 		<a class="two-factor-secondary" href="<?php p(\OC::$server->getURLGenerator()->linkToRoute('core.TwoFactorChallenge.showChallenge',
27
-			[
28
-				'challengeProviderId' => $_['backupProvider']->getId(),
29
-				'redirect_url' => $_['redirect_url'],
30
-			]
31
-		)) ?>">
27
+            [
28
+                'challengeProviderId' => $_['backupProvider']->getId(),
29
+                'redirect_url' => $_['redirect_url'],
30
+            ]
31
+        )) ?>">
32 32
 			<?php p($l->t('Use backup code')) ?>
33 33
 		</a>
34 34
 	</p>
Please login to merge, or discard this patch.
core/templates/layout.guest.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
 									<?php p($theme->getName()); ?>
30 30
 								</h1>
31 31
 								<?php if (\OC::$server->getConfig()->getSystemValue('installed', false)
32
-									&& \OC::$server->getConfig()->getAppValue('theming', 'logoMime', false)): ?>
32
+                                    && \OC::$server->getConfig()->getAppValue('theming', 'logoMime', false)): ?>
33 33
 									<img src="<?php p($theme->getLogo()); ?>"/>
34 34
 								<?php endif; ?>
35 35
 							</div>
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
 		<?php emit_script_loading_tags($_); ?>
24 24
 		<?php print_unescaped($_['headers']); ?>
25 25
 	</head>
26
-	<body id="<?php p($_['bodyid']);?>">
26
+	<body id="<?php p($_['bodyid']); ?>">
27 27
 		<?php include 'layout.noscript.warning.php'; ?>
28 28
 		<?php foreach ($_['initialStates'] as $app => $initialState) { ?>
29 29
 			<input type="hidden" id="initial-state-<?php p($app); ?>" value="<?php p(base64_encode($initialState)); ?>">
Please login to merge, or discard this patch.
lib/private/Files/ObjectStore/S3.php 1 patch
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -24,18 +24,18 @@
 block discarded – undo
24 24
 use OCP\Files\ObjectStore\IObjectStore;
25 25
 
26 26
 class S3 implements IObjectStore {
27
-	use S3ConnectionTrait;
28
-	use S3ObjectTrait;
27
+    use S3ConnectionTrait;
28
+    use S3ObjectTrait;
29 29
 
30
-	public function __construct($parameters) {
31
-		$this->parseParams($parameters);
32
-	}
30
+    public function __construct($parameters) {
31
+        $this->parseParams($parameters);
32
+    }
33 33
 
34
-	/**
35
-	 * @return string the container or bucket name where objects are stored
36
-	 * @since 7.0.0
37
-	 */
38
-	public function getStorageId() {
39
-		return $this->id;
40
-	}
34
+    /**
35
+     * @return string the container or bucket name where objects are stored
36
+     * @since 7.0.0
37
+     */
38
+    public function getStorageId() {
39
+        return $this->id;
40
+    }
41 41
 }
Please login to merge, or discard this patch.