nextcloud / server

lib/private/IntegrityCheck/Helpers/FileAccessHelper.php

Doc Comments +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
 	 * Wrapper around file_put_contents($filename, $data)
 	 *
 	 * @param string $filename
-	 * @param $data
+	 * @param string $data
 	 * @return int|false
 	 */
 	public function file_put_contents($filename, $data) {

lib/private/legacy/db.php

Doc Comments -1 removed lines

@@ -151,7 +151,6 @@
 	/**
 	 * saves database schema to xml file
 	 * @param string $file name of file
-	 * @param int $mode
 	 * @return bool
 	 *
 	 * TODO: write more documentation

lib/private/User/User.php

Doc Comments +4 added lines

@@ -413,6 +413,10 @@
 		return $url;
 	}
 
+	/**
+	 * @param string $feature
+	 * @param string $value
+	 */
 	public function triggerChange($feature, $value = null) {
 		if ($this->emitter) {
 			$this->emitter->emit('\OC\User', 'changeUser', array($this, $feature, $value));

lib/private/AllConfig.php

Doc Comments +2 added lines, -2 removed lines

@@ -116,8 +116,8 @@
 	 * Looks up a system wide defined value
 	 *
 	 * @param string $key the key of the value, under which it was saved
-	 * @param mixed $default the default value to be returned if the value isn't set
-	 * @return mixed the value or $default
+	 * @param string|false $default the default value to be returned if the value isn't set
+	 * @return string the value or $default
 	 */
 	public function getSystemValue($key, $default = '') {
 		return $this->systemConfig->getValue($key, $default);

lib/public/AppFramework/Http/OCSResponse.php

Doc Comments +2 added lines, -2 removed lines

@@ -50,8 +50,8 @@
 	 * @param int $statuscode
 	 * @param string $message
 	 * @param array $data
-	 * @param int|string $itemscount
-	 * @param int|string $itemsperpage
+	 * @param string $itemscount
+	 * @param string $itemsperpage
 	 * @since 8.1.0
 	 */
 	public function __construct($format, $statuscode, $message,

lib/private/legacy/files.php

Doc Comments +1 added lines, -1 removed lines

@@ -334,7 +334,7 @@
 	 *
 	 * @param int $size file size in bytes
 	 * @param array $files override '.htaccess' and '.user.ini' locations
-	 * @return bool false on failure, size on success
+	 * @return integer false on failure, size on success
 	 */
 	public static function setUploadLimit($size, $files = []) {
 		//don't allow user to break his config

lib/private/Settings/Manager.php

Doc Comments +13 added lines, -2 removed lines

@@ -129,7 +129,7 @@ 
 	/**
 	 * returns the registerd classes in the given table
 	 *
-	 * @param $table
+	 * @param string $table
 	 * @return string[]
 	 */
 	private function getClasses($table) {
@@ -225,6 +225,11 @@ 
 		);
 	}
 
+	/**
+	 * @param string $table
+	 * @param string $idCol
+	 * @param string $id
+	 */
 	private function update($table, $idCol, $id, $values) {
 		$query = $this->dbc->getQueryBuilder();
 		$query->update($table);
@@ -275,7 +280,7 @@ 
 	/**
 	 * deletes an settings or admin entry from the given table
 	 *
-	 * @param $table
+	 * @param string $table
 	 * @param $className
 	 */
 	private function remove($table, $className) {
@@ -358,6 +363,9 @@ 
 		return $sections;
 	}
 
+	/**
+	 * @param string $section
+	 */
 	private function getBuiltInAdminSettings($section) {
 		$forms = [];
 		try {
@@ -397,6 +405,9 @@ 
 		return $forms;
 	}
 
+	/**
+	 * @param string $section
+	 */
 	private function getAdminSettingsFromDB($section, &$settings) {
 		$query = $this->dbc->getQueryBuilder();
 		$query->select(['class', 'priority'])

settings/Controller/CertificateController.php

Doc Comments +2 added lines, -2 removed lines

@@ -72,7 +72,7 @@ 
 	 *
 	 * @NoAdminRequired
 	 * @NoSubadminRequired
-	 * @return array
+	 * @return DataResponse
 	 */
 	public function addPersonalRootCertificate() {
 		return $this->addCertificate($this->userCertificateManager);
@@ -160,7 +160,7 @@ 
 	/**
 	 * Add a new personal root certificate to the system's trust store
 	 *
-	 * @return array
+	 * @return DataResponse
 	 */
 	public function addSystemRootCertificate() {
 		return $this->addCertificate($this->systemCertificateManager);

apps/files_sharing/lib/sharedstorage.php

Unused Use Statements -1 removed lines

@@ -36,7 +36,6 @@
 use OCA\Files_Sharing\ISharedStorage;
 use OCP\Constants;
 use OCP\Files\Cache\ICacheEntry;
-use OCP\Files\Storage\IStorage;
 use OCP\Lock\ILockingProvider;
 
 /**