nextcloud / server

lib/private/User/Session.php

Doc Comments +4 added lines, -1 removed lines

@@ -300,7 +300,7 @@ 
 	 * @param IRequest $request
 	 * @throws LoginException
 	 * @throws PasswordLoginForbiddenException
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public function logClientIn($user, $password, IRequest $request) {
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -340,6 +340,9 @@ 
 		return $this->config->getSystemValue('token_auth_enforced', false);
 	}
 
+	/**
+	 * @param string $username
+	 */
 	protected function isTwoFactorEnforced($username) {
 		Util::emitHook(
 			'\OCA\Files_Sharing\API\Server2Server',

apps/files_external/lib/Command/Backends.php

Unused Use Statements -5 removed lines

@@ -27,13 +27,8 @@
 use OCA\Files_External\Lib\DefinitionParameter;
 use OCA\Files_External\Service\BackendService;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Helper\Table;
-use Symfony\Component\Console\Helper\TableHelper;
-use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Input\InputOption;
-use Symfony\Component\Console\Input\Input;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Backends extends Base {

settings/Controller/CheckSetupController.php

Doc Comments +2 added lines, -1 removed lines

@@ -103,6 +103,7 @@ 
 
 	/**
 	* Chceks if the ownCloud server can connect to a specific URL using both HTTPS and HTTP
+	* @param string $sitename
 	* @return bool
 	*/
 	private function isSiteReachable($sitename) {
@@ -285,7 +286,7 @@ 
 
 	/**
 	 * @NoCSRFRequired
-	 * @return DataResponse
+	 * @return DataDisplayResponse
 	 */
 	public function getFailedIntegrityCheckFiles() {
 		if(!$this->checker->isCodeCheckEnforced()) {

lib/private/Console/Application.php

Unused Use Statements -1 removed lines

@@ -29,7 +29,6 @@
  */
 
 namespace OC;
-use OCP\Defaults;
 use OCP\ICacheFactory;
 use OCP\IConfig;
 use OCP\IURLGenerator;

lib/private/TemplateLayout.php

Unused Use Statements -9 removed lines

@@ -35,15 +35,6 @@
  */
 namespace OC;
 
-use Assetic\Asset\AssetCollection;
-use Assetic\Asset\FileAsset;
-use Assetic\AssetWriter;
-use Assetic\Filter\CssImportFilter;
-use Assetic\Filter\CssMinFilter;
-use Assetic\Filter\CssRewriteFilter;
-use Assetic\Filter\JSqueezeFilter;
-use Assetic\Filter\SeparatorFilter;
-
 class TemplateLayout extends \OC_Template {
 
 	private static $versionHash = '';

lib/private/Repair/RepairUnmergedShares.php

Doc Comments +1 added lines, -1 removed lines

@@ -219,7 +219,7 @@
 	 * @param array $groupSharesById
 	 * @param array $subShares
 	 *
-	 * @return true if the share is valid, false if it needs repair
+	 * @return boolean if the share is valid, false if it needs repair
 	 */
 	private function isThisShareValid($groupSharesById, $subShares) {
 		$foundTargets = [];

apps/user_ldap/lib/LDAPProvider.php

Unused Use Statements -2 removed lines

@@ -21,12 +21,10 @@
 
 namespace OCA\User_LDAP;
 
-use OCP\IUserBackend;
 use OCP\LDAP\ILDAPProvider;
 use OCP\LDAP\IDeletionFlagSupport;
 use OCP\IServerContainer;
 use OCA\User_LDAP\User\DeletedUsersIndex;
-use OCA\User_LDAP\Mapping\UserMapping;
 
 /**
  * LDAP provider for pulic access to the LDAP backend.

apps/user_ldap/lib/Access.php

Doc Comments +9 added lines, -7 removed lines

@@ -397,7 +397,7 @@ 
 
 	/**
 	 * returns the internal ownCloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @return string|false with with the name to use in ownCloud
 	 */
@@ -414,7 +414,7 @@ 
 
 	/**
 	 * returns an internal ownCloud name for the given LDAP DN, false on DN outside of search DN
-	 * @param string $dn the dn of the user object
+	 * @param string $fdn the dn of the user object
 	 * @param string $ldapName optional, the display name of the object
 	 * @param bool $isUser optional, whether it is a user object (otherwise group assumed)
 	 * @return string|false with with the name to use in ownCloud
@@ -674,7 +674,7 @@ 
 	 * the login filter.
 	 *
 	 * @param string $loginName
-	 * @param array $attributes optional, list of attributes to read
+	 * @param string[] $attributes optional, list of attributes to read
 	 * @return array
 	 */
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -747,7 +747,7 @@ 
 
 	/**
 	 * @param string $filter
-	 * @param string|string[] $attr
+	 * @param string[] $attr
 	 * @param int $limit
 	 * @param int $offset
 	 * @return array
@@ -795,7 +795,7 @@ 
 
 	/**
 	 * @param string $filter
-	 * @param string|string[] $attr
+	 * @param string[] $attr
 	 * @param int $limit
 	 * @param int $offset
 	 * @return false|int
@@ -845,6 +845,7 @@ 
 	 * retrieved. Results will according to the order in the array.
 	 * @param int $limit optional, maximum results to be counted
 	 * @param int $offset optional, a starting point
+	 * @param string $filter
 	 * @return array|false array with the search result as first value and pagedSearchOK as
 	 * second | false if not successful
 	 */
@@ -891,7 +892,7 @@ 
 	 * @param bool $pagedSearchOK whether a paged search has been executed
 	 * @param bool $skipHandling required for paged search when cookies to
 	 * prior results need to be gained
-	 * @return bool cookie validity, true if we have more pages, false otherwise.
+	 * @return null|boolean cookie validity, true if we have more pages, false otherwise.
 	 */
 	private function processPagedSearchStatus($sr, $filter, $base, $iFoundItems, $limit, $offset, $pagedSearchOK, $skipHandling) {
 		$cookie = null;
@@ -1100,7 +1101,7 @@ 
 
 	/**
 	 * @param string $name
-	 * @return bool|mixed|string
+	 * @return string
 	 */
 	public function sanitizeUsername($name) {
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1124,6 +1125,7 @@ 
 	* escapes (user provided) parts for LDAP filter
 	* @param string $input, the provided value
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
+	* @param string $input
 	* @return string the escaped string
 	*/
 	public function escapeFilterPart($input, $allowAsterisk = false) {

apps/user_ldap/lib/Wizard.php

Doc Comments +1 added lines, -1 removed lines

@@ -1104,7 +1104,7 @@
 	}
 
 	/**
-	 * @param array $reqs
+	 * @param string[] $reqs
 	 * @return bool
 	 */
 	private function checkRequirements($reqs) {