Passed
Push — master ( fb64fd...b68680 )
by Roeland
29:15 queued 18:52
created
apps/files_sharing/lib/ISharedStorage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,6 +23,6 @@
 block discarded – undo
23 23
 
24 24
 namespace OCA\Files_Sharing;
25 25
 
26
-interface ISharedStorage{
26
+interface ISharedStorage {
27 27
 
28 28
 }
Please login to merge, or discard this patch.
apps/files_sharing/lib/External/Scanner.php 2 patches
Indentation   +87 added lines, -87 removed lines patch added patch discarded remove patch
@@ -32,97 +32,97 @@
 block discarded – undo
32 32
 use OCP\Files\StorageNotAvailableException;
33 33
 
34 34
 class Scanner extends \OC\Files\Cache\Scanner {
35
-	/** @var \OCA\Files_Sharing\External\Storage */
36
-	protected $storage;
35
+    /** @var \OCA\Files_Sharing\External\Storage */
36
+    protected $storage;
37 37
 
38
-	/** {@inheritDoc} */
39
-	public function scan($path, $recursive = self::SCAN_RECURSIVE, $reuse = -1, $lock = true) {
40
-		if(!$this->storage->remoteIsOwnCloud()) {
41
-			return parent::scan($path, $recursive, $recursive, $lock);
42
-		}
38
+    /** {@inheritDoc} */
39
+    public function scan($path, $recursive = self::SCAN_RECURSIVE, $reuse = -1, $lock = true) {
40
+        if(!$this->storage->remoteIsOwnCloud()) {
41
+            return parent::scan($path, $recursive, $recursive, $lock);
42
+        }
43 43
 
44
-		$this->scanAll();
45
-	}
44
+        $this->scanAll();
45
+    }
46 46
 
47
-	/**
48
-	 * Scan a single file and store it in the cache.
49
-	 * If an exception happened while accessing the external storage,
50
-	 * the storage will be checked for availability and removed
51
-	 * if it is not available any more.
52
-	 *
53
-	 * @param string $file file to scan
54
-	 * @param int $reuseExisting
55
-	 * @param int $parentId
56
-	 * @param array | null $cacheData existing data in the cache for the file to be scanned
57
-	 * @param bool $lock set to false to disable getting an additional read lock during scanning
58
-	 * @return array an array of metadata of the scanned file
59
-	 */
60
-	public function scanFile($file, $reuseExisting = 0, $parentId = -1, $cacheData = null, $lock = true) {
61
-		try {
62
-			return parent::scanFile($file, $reuseExisting);
63
-		} catch (ForbiddenException $e) {
64
-			$this->storage->checkStorageAvailability();
65
-		} catch (NotFoundException $e) {
66
-			// if the storage isn't found, the call to
67
-			// checkStorageAvailable() will verify it and remove it
68
-			// if appropriate
69
-			$this->storage->checkStorageAvailability();
70
-		} catch (StorageInvalidException $e) {
71
-			$this->storage->checkStorageAvailability();
72
-		} catch (StorageNotAvailableException $e) {
73
-			$this->storage->checkStorageAvailability();
74
-		}
75
-	}
47
+    /**
48
+     * Scan a single file and store it in the cache.
49
+     * If an exception happened while accessing the external storage,
50
+     * the storage will be checked for availability and removed
51
+     * if it is not available any more.
52
+     *
53
+     * @param string $file file to scan
54
+     * @param int $reuseExisting
55
+     * @param int $parentId
56
+     * @param array | null $cacheData existing data in the cache for the file to be scanned
57
+     * @param bool $lock set to false to disable getting an additional read lock during scanning
58
+     * @return array an array of metadata of the scanned file
59
+     */
60
+    public function scanFile($file, $reuseExisting = 0, $parentId = -1, $cacheData = null, $lock = true) {
61
+        try {
62
+            return parent::scanFile($file, $reuseExisting);
63
+        } catch (ForbiddenException $e) {
64
+            $this->storage->checkStorageAvailability();
65
+        } catch (NotFoundException $e) {
66
+            // if the storage isn't found, the call to
67
+            // checkStorageAvailable() will verify it and remove it
68
+            // if appropriate
69
+            $this->storage->checkStorageAvailability();
70
+        } catch (StorageInvalidException $e) {
71
+            $this->storage->checkStorageAvailability();
72
+        } catch (StorageNotAvailableException $e) {
73
+            $this->storage->checkStorageAvailability();
74
+        }
75
+    }
76 76
 
77
-	/**
78
-	 * Checks the remote share for changes.
79
-	 * If changes are available, scan them and update
80
-	 * the cache.
81
-	 * @throws NotFoundException
82
-	 * @throws StorageInvalidException
83
-	 * @throws \Exception
84
-	 */
85
-	public function scanAll() {
86
-		try {
87
-			$data = $this->storage->getShareInfo();
88
-		} catch (\Exception $e) {
89
-			$this->storage->checkStorageAvailability();
90
-			throw new \Exception(
91
-				'Error while scanning remote share: "' .
92
-				$this->storage->getRemote() . '" ' .
93
-				$e->getMessage()
94
-			);
95
-		}
96
-		if ($data['status'] === 'success') {
97
-			$this->addResult($data['data'], '');
98
-		} else {
99
-			throw new \Exception(
100
-				'Error while scanning remote share: "' .
101
-				$this->storage->getRemote() . '"'
102
-			);
103
-		}
104
-	}
77
+    /**
78
+     * Checks the remote share for changes.
79
+     * If changes are available, scan them and update
80
+     * the cache.
81
+     * @throws NotFoundException
82
+     * @throws StorageInvalidException
83
+     * @throws \Exception
84
+     */
85
+    public function scanAll() {
86
+        try {
87
+            $data = $this->storage->getShareInfo();
88
+        } catch (\Exception $e) {
89
+            $this->storage->checkStorageAvailability();
90
+            throw new \Exception(
91
+                'Error while scanning remote share: "' .
92
+                $this->storage->getRemote() . '" ' .
93
+                $e->getMessage()
94
+            );
95
+        }
96
+        if ($data['status'] === 'success') {
97
+            $this->addResult($data['data'], '');
98
+        } else {
99
+            throw new \Exception(
100
+                'Error while scanning remote share: "' .
101
+                $this->storage->getRemote() . '"'
102
+            );
103
+        }
104
+    }
105 105
 
106
-	/**
107
-	 * @param array $data
108
-	 * @param string $path
109
-	 */
110
-	private function addResult($data, $path) {
111
-		$id = $this->cache->put($path, $data);
112
-		if (isset($data['children'])) {
113
-			$children = [];
114
-			foreach ($data['children'] as $child) {
115
-				$children[$child['name']] = true;
116
-				$this->addResult($child, ltrim($path . '/' . $child['name'], '/'));
117
-			}
106
+    /**
107
+     * @param array $data
108
+     * @param string $path
109
+     */
110
+    private function addResult($data, $path) {
111
+        $id = $this->cache->put($path, $data);
112
+        if (isset($data['children'])) {
113
+            $children = [];
114
+            foreach ($data['children'] as $child) {
115
+                $children[$child['name']] = true;
116
+                $this->addResult($child, ltrim($path . '/' . $child['name'], '/'));
117
+            }
118 118
 
119
-			$existingCache = $this->cache->getFolderContentsById($id);
120
-			foreach ($existingCache as $existingChild) {
121
-				// if an existing child is not in the new data, remove it
122
-				if (!isset($children[$existingChild['name']])) {
123
-					$this->cache->remove(ltrim($path . '/' . $existingChild['name'], '/'));
124
-				}
125
-			}
126
-		}
127
-	}
119
+            $existingCache = $this->cache->getFolderContentsById($id);
120
+            foreach ($existingCache as $existingChild) {
121
+                // if an existing child is not in the new data, remove it
122
+                if (!isset($children[$existingChild['name']])) {
123
+                    $this->cache->remove(ltrim($path . '/' . $existingChild['name'], '/'));
124
+                }
125
+            }
126
+        }
127
+    }
128 128
 }
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 
38 38
 	/** {@inheritDoc} */
39 39
 	public function scan($path, $recursive = self::SCAN_RECURSIVE, $reuse = -1, $lock = true) {
40
-		if(!$this->storage->remoteIsOwnCloud()) {
40
+		if (!$this->storage->remoteIsOwnCloud()) {
41 41
 			return parent::scan($path, $recursive, $recursive, $lock);
42 42
 		}
43 43
 
@@ -88,8 +88,8 @@  discard block
 block discarded – undo
88 88
 		} catch (\Exception $e) {
89 89
 			$this->storage->checkStorageAvailability();
90 90
 			throw new \Exception(
91
-				'Error while scanning remote share: "' .
92
-				$this->storage->getRemote() . '" ' .
91
+				'Error while scanning remote share: "'.
92
+				$this->storage->getRemote().'" '.
93 93
 				$e->getMessage()
94 94
 			);
95 95
 		}
@@ -97,8 +97,8 @@  discard block
 block discarded – undo
97 97
 			$this->addResult($data['data'], '');
98 98
 		} else {
99 99
 			throw new \Exception(
100
-				'Error while scanning remote share: "' .
101
-				$this->storage->getRemote() . '"'
100
+				'Error while scanning remote share: "'.
101
+				$this->storage->getRemote().'"'
102 102
 			);
103 103
 		}
104 104
 	}
@@ -113,14 +113,14 @@  discard block
 block discarded – undo
113 113
 			$children = [];
114 114
 			foreach ($data['children'] as $child) {
115 115
 				$children[$child['name']] = true;
116
-				$this->addResult($child, ltrim($path . '/' . $child['name'], '/'));
116
+				$this->addResult($child, ltrim($path.'/'.$child['name'], '/'));
117 117
 			}
118 118
 
119 119
 			$existingCache = $this->cache->getFolderContentsById($id);
120 120
 			foreach ($existingCache as $existingChild) {
121 121
 				// if an existing child is not in the new data, remove it
122 122
 				if (!isset($children[$existingChild['name']])) {
123
-					$this->cache->remove(ltrim($path . '/' . $existingChild['name'], '/'));
123
+					$this->cache->remove(ltrim($path.'/'.$existingChild['name'], '/'));
124 124
 				}
125 125
 			}
126 126
 		}
Please login to merge, or discard this patch.
apps/files_sharing/lib/External/Cache.php 1 patch
Indentation   +37 added lines, -37 removed lines patch added patch discarded remove patch
@@ -27,44 +27,44 @@
 block discarded – undo
27 27
 use OCP\Federation\ICloudId;
28 28
 
29 29
 class Cache extends \OC\Files\Cache\Cache {
30
-	/** @var ICloudId */
31
-	private $cloudId;
32
-	private $remote;
33
-	private $remoteUser;
34
-	private $storage;
30
+    /** @var ICloudId */
31
+    private $cloudId;
32
+    private $remote;
33
+    private $remoteUser;
34
+    private $storage;
35 35
 
36
-	/**
37
-	 * @param \OCA\Files_Sharing\External\Storage $storage
38
-	 * @param ICloudId $cloudId
39
-	 */
40
-	public function __construct($storage, ICloudId $cloudId) {
41
-		$this->cloudId = $cloudId;
42
-		$this->storage = $storage;
43
-		list(, $remote) = explode('://', $cloudId->getRemote(), 2);
44
-		$this->remote = $remote;
45
-		$this->remoteUser = $cloudId->getUser();
46
-		parent::__construct($storage);
47
-	}
36
+    /**
37
+     * @param \OCA\Files_Sharing\External\Storage $storage
38
+     * @param ICloudId $cloudId
39
+     */
40
+    public function __construct($storage, ICloudId $cloudId) {
41
+        $this->cloudId = $cloudId;
42
+        $this->storage = $storage;
43
+        list(, $remote) = explode('://', $cloudId->getRemote(), 2);
44
+        $this->remote = $remote;
45
+        $this->remoteUser = $cloudId->getUser();
46
+        parent::__construct($storage);
47
+    }
48 48
 
49
-	public function get($file) {
50
-		$result = parent::get($file);
51
-		if (!$result) {
52
-			return false;
53
-		}
54
-		$result['displayname_owner'] = $this->cloudId->getDisplayId();
55
-		if (!$file || $file === '') {
56
-			$result['is_share_mount_point'] = true;
57
-			$mountPoint = rtrim($this->storage->getMountPoint());
58
-			$result['name'] = basename($mountPoint);
59
-		}
60
-		return $result;
61
-	}
49
+    public function get($file) {
50
+        $result = parent::get($file);
51
+        if (!$result) {
52
+            return false;
53
+        }
54
+        $result['displayname_owner'] = $this->cloudId->getDisplayId();
55
+        if (!$file || $file === '') {
56
+            $result['is_share_mount_point'] = true;
57
+            $mountPoint = rtrim($this->storage->getMountPoint());
58
+            $result['name'] = basename($mountPoint);
59
+        }
60
+        return $result;
61
+    }
62 62
 
63
-	public function getFolderContentsById($id) {
64
-		$results = parent::getFolderContentsById($id);
65
-		foreach ($results as &$file) {
66
-			$file['displayname_owner'] = $this->cloudId->getDisplayId();
67
-		}
68
-		return $results;
69
-	}
63
+    public function getFolderContentsById($id) {
64
+        $results = parent::getFolderContentsById($id);
65
+        foreach ($results as &$file) {
66
+            $file['displayname_owner'] = $this->cloudId->getDisplayId();
67
+        }
68
+        return $results;
69
+    }
70 70
 }
Please login to merge, or discard this patch.
apps/files_sharing/lib/External/MountProvider.php 2 patches
Indentation   +45 added lines, -45 removed lines patch added patch discarded remove patch
@@ -29,59 +29,59 @@
 block discarded – undo
29 29
 use OCP\IUser;
30 30
 
31 31
 class MountProvider implements IMountProvider {
32
-	const STORAGE = '\OCA\Files_Sharing\External\Storage';
32
+    const STORAGE = '\OCA\Files_Sharing\External\Storage';
33 33
 
34
-	/**
35
-	 * @var \OCP\IDBConnection
36
-	 */
37
-	private $connection;
34
+    /**
35
+     * @var \OCP\IDBConnection
36
+     */
37
+    private $connection;
38 38
 
39
-	/**
40
-	 * @var callable
41
-	 */
42
-	private $managerProvider;
39
+    /**
40
+     * @var callable
41
+     */
42
+    private $managerProvider;
43 43
 
44
-	/**
45
-	 * @var ICloudIdManager
46
-	 */
47
-	private $cloudIdManager;
44
+    /**
45
+     * @var ICloudIdManager
46
+     */
47
+    private $cloudIdManager;
48 48
 
49
-	/**
50
-	 * @param \OCP\IDBConnection $connection
51
-	 * @param callable $managerProvider due to setup order we need a callable that return the manager instead of the manager itself
52
-	 * @param ICloudIdManager $cloudIdManager
53
-	 */
54
-	public function __construct(IDBConnection $connection, callable $managerProvider, ICloudIdManager $cloudIdManager) {
55
-		$this->connection = $connection;
56
-		$this->managerProvider = $managerProvider;
57
-		$this->cloudIdManager = $cloudIdManager;
58
-	}
49
+    /**
50
+     * @param \OCP\IDBConnection $connection
51
+     * @param callable $managerProvider due to setup order we need a callable that return the manager instead of the manager itself
52
+     * @param ICloudIdManager $cloudIdManager
53
+     */
54
+    public function __construct(IDBConnection $connection, callable $managerProvider, ICloudIdManager $cloudIdManager) {
55
+        $this->connection = $connection;
56
+        $this->managerProvider = $managerProvider;
57
+        $this->cloudIdManager = $cloudIdManager;
58
+    }
59 59
 
60
-	public function getMount(IUser $user, $data, IStorageFactory $storageFactory) {
61
-		$managerProvider = $this->managerProvider;
62
-		$manager = $managerProvider();
63
-		$data['manager'] = $manager;
64
-		$mountPoint = '/' . $user->getUID() . '/files/' . ltrim($data['mountpoint'], '/');
65
-		$data['mountpoint'] = $mountPoint;
66
-		$data['cloudId'] = $this->cloudIdManager->getCloudId($data['owner'], $data['remote']);
67
-		$data['certificateManager'] = \OC::$server->getCertificateManager($user->getUID());
68
-		$data['HttpClientService'] = \OC::$server->getHTTPClientService();
69
-		return new Mount(self::STORAGE, $mountPoint, $data, $manager, $storageFactory);
70
-	}
60
+    public function getMount(IUser $user, $data, IStorageFactory $storageFactory) {
61
+        $managerProvider = $this->managerProvider;
62
+        $manager = $managerProvider();
63
+        $data['manager'] = $manager;
64
+        $mountPoint = '/' . $user->getUID() . '/files/' . ltrim($data['mountpoint'], '/');
65
+        $data['mountpoint'] = $mountPoint;
66
+        $data['cloudId'] = $this->cloudIdManager->getCloudId($data['owner'], $data['remote']);
67
+        $data['certificateManager'] = \OC::$server->getCertificateManager($user->getUID());
68
+        $data['HttpClientService'] = \OC::$server->getHTTPClientService();
69
+        return new Mount(self::STORAGE, $mountPoint, $data, $manager, $storageFactory);
70
+    }
71 71
 
72
-	public function getMountsForUser(IUser $user, IStorageFactory $loader) {
73
-		$query = $this->connection->prepare('
72
+    public function getMountsForUser(IUser $user, IStorageFactory $loader) {
73
+        $query = $this->connection->prepare('
74 74
 				SELECT `remote`, `share_token`, `password`, `mountpoint`, `owner`
75 75
 				FROM `*PREFIX*share_external`
76 76
 				WHERE `user` = ? AND `accepted` = ?
77 77
 			');
78
-		$query->execute([$user->getUID(), 1]);
79
-		$mounts = [];
80
-		while ($row = $query->fetch()) {
81
-			$row['manager'] = $this;
82
-			$row['token'] = $row['share_token'];
83
-			$mounts[] = $this->getMount($user, $row, $loader);
84
-		}
85
-		return $mounts;
86
-	}
78
+        $query->execute([$user->getUID(), 1]);
79
+        $mounts = [];
80
+        while ($row = $query->fetch()) {
81
+            $row['manager'] = $this;
82
+            $row['token'] = $row['share_token'];
83
+            $mounts[] = $this->getMount($user, $row, $loader);
84
+        }
85
+        return $mounts;
86
+    }
87 87
 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
 		$managerProvider = $this->managerProvider;
62 62
 		$manager = $managerProvider();
63 63
 		$data['manager'] = $manager;
64
-		$mountPoint = '/' . $user->getUID() . '/files/' . ltrim($data['mountpoint'], '/');
64
+		$mountPoint = '/'.$user->getUID().'/files/'.ltrim($data['mountpoint'], '/');
65 65
 		$data['mountpoint'] = $mountPoint;
66 66
 		$data['cloudId'] = $this->cloudIdManager->getCloudId($data['owner'], $data['remote']);
67 67
 		$data['certificateManager'] = \OC::$server->getCertificateManager($user->getUID());
Please login to merge, or discard this patch.
apps/files_sharing/lib/External/Watcher.php 1 patch
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -23,12 +23,12 @@
 block discarded – undo
23 23
 namespace OCA\Files_Sharing\External;
24 24
 
25 25
 class Watcher extends \OC\Files\Cache\Watcher {
26
-	/**
27
-	 * remove deleted files in $path from the cache
28
-	 *
29
-	 * @param string $path
30
-	 */
31
-	public function cleanFolder($path) {
32
-		// not needed, the scanner takes care of this
33
-	}
26
+    /**
27
+     * remove deleted files in $path from the cache
28
+     *
29
+     * @param string $path
30
+     */
31
+    public function cleanFolder($path) {
32
+        // not needed, the scanner takes care of this
33
+    }
34 34
 }
Please login to merge, or discard this patch.
apps/files_sharing/lib/ShareBackend/File.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 	 */
97 97
 	public function generateTarget($filePath, $shareWith, $exclude = null) {
98 98
 		$shareFolder = \OCA\Files_Sharing\Helper::getShareFolder();
99
-		$target = \OC\Files\Filesystem::normalizePath($shareFolder . '/' . basename($filePath));
99
+		$target = \OC\Files\Filesystem::normalizePath($shareFolder.'/'.basename($filePath));
100 100
 
101 101
 		// for group shares we return the target right away
102 102
 		if ($shareWith === false) {
@@ -104,13 +104,13 @@  discard block
 block discarded – undo
104 104
 		}
105 105
 
106 106
 		\OC\Files\Filesystem::initMountPoints($shareWith);
107
-		$view = new \OC\Files\View('/' . $shareWith . '/files');
107
+		$view = new \OC\Files\View('/'.$shareWith.'/files');
108 108
 
109 109
 		if (!$view->is_dir($shareFolder)) {
110 110
 			$dir = '';
111 111
 			$subdirs = explode('/', $shareFolder);
112 112
 			foreach ($subdirs as $subdir) {
113
-				$dir = $dir . '/' . $subdir;
113
+				$dir = $dir.'/'.$subdir;
114 114
 				if (!$view->is_dir($dir)) {
115 115
 					$view->mkdir($dir);
116 116
 				}
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
237 237
 		if ($share['item_type'] === 'folder' && $target !== '') {
238 238
 			// note: in case of ext storage mount points the path might be empty
239 239
 			// which would cause a leading slash to appear
240
-			$share['path'] = ltrim($share['path'] . '/' . $target, '/');
240
+			$share['path'] = ltrim($share['path'].'/'.$target, '/');
241 241
 		}
242 242
 		return self::resolveReshares($share);
243 243
 	}
Please login to merge, or discard this patch.
Indentation   +196 added lines, -196 removed lines patch added patch discarded remove patch
@@ -38,219 +38,219 @@
 block discarded – undo
38 38
 
39 39
 class File implements \OCP\Share_Backend_File_Dependent {
40 40
 
41
-	const FORMAT_SHARED_STORAGE = 0;
42
-	const FORMAT_GET_FOLDER_CONTENTS = 1;
43
-	const FORMAT_FILE_APP_ROOT = 2;
44
-	const FORMAT_OPENDIR = 3;
45
-	const FORMAT_GET_ALL = 4;
46
-	const FORMAT_PERMISSIONS = 5;
47
-	const FORMAT_TARGET_NAMES = 6;
41
+    const FORMAT_SHARED_STORAGE = 0;
42
+    const FORMAT_GET_FOLDER_CONTENTS = 1;
43
+    const FORMAT_FILE_APP_ROOT = 2;
44
+    const FORMAT_OPENDIR = 3;
45
+    const FORMAT_GET_ALL = 4;
46
+    const FORMAT_PERMISSIONS = 5;
47
+    const FORMAT_TARGET_NAMES = 6;
48 48
 
49
-	private $path;
49
+    private $path;
50 50
 
51
-	/** @var FederatedShareProvider */
52
-	private $federatedShareProvider;
51
+    /** @var FederatedShareProvider */
52
+    private $federatedShareProvider;
53 53
 
54
-	public function __construct(FederatedShareProvider $federatedShareProvider = null) {
55
-		if ($federatedShareProvider) {
56
-			$this->federatedShareProvider = $federatedShareProvider;
57
-		} else {
58
-			$federatedSharingApp = new \OCA\FederatedFileSharing\AppInfo\Application();
59
-			$this->federatedShareProvider = $federatedSharingApp->getFederatedShareProvider();
60
-		}
61
-	}
54
+    public function __construct(FederatedShareProvider $federatedShareProvider = null) {
55
+        if ($federatedShareProvider) {
56
+            $this->federatedShareProvider = $federatedShareProvider;
57
+        } else {
58
+            $federatedSharingApp = new \OCA\FederatedFileSharing\AppInfo\Application();
59
+            $this->federatedShareProvider = $federatedSharingApp->getFederatedShareProvider();
60
+        }
61
+    }
62 62
 
63
-	public function isValidSource($itemSource, $uidOwner) {
64
-		try {
65
-			$path = \OC\Files\Filesystem::getPath($itemSource);
66
-			// FIXME: attributes should not be set here,
67
-			// keeping this pattern for now to avoid unexpected
68
-			// regressions
69
-			$this->path = \OC\Files\Filesystem::normalizePath(basename($path));
70
-			return true;
71
-		} catch (\OCP\Files\NotFoundException $e) {
72
-			return false;
73
-		}
74
-	}
63
+    public function isValidSource($itemSource, $uidOwner) {
64
+        try {
65
+            $path = \OC\Files\Filesystem::getPath($itemSource);
66
+            // FIXME: attributes should not be set here,
67
+            // keeping this pattern for now to avoid unexpected
68
+            // regressions
69
+            $this->path = \OC\Files\Filesystem::normalizePath(basename($path));
70
+            return true;
71
+        } catch (\OCP\Files\NotFoundException $e) {
72
+            return false;
73
+        }
74
+    }
75 75
 
76
-	public function getFilePath($itemSource, $uidOwner) {
77
-		if (isset($this->path)) {
78
-			$path = $this->path;
79
-			$this->path = null;
80
-			return $path;
81
-		} else {
82
-			try {
83
-				$path = \OC\Files\Filesystem::getPath($itemSource);
84
-				return $path;
85
-			} catch (\OCP\Files\NotFoundException $e) {
86
-				return false;
87
-			}
88
-		}
89
-	}
76
+    public function getFilePath($itemSource, $uidOwner) {
77
+        if (isset($this->path)) {
78
+            $path = $this->path;
79
+            $this->path = null;
80
+            return $path;
81
+        } else {
82
+            try {
83
+                $path = \OC\Files\Filesystem::getPath($itemSource);
84
+                return $path;
85
+            } catch (\OCP\Files\NotFoundException $e) {
86
+                return false;
87
+            }
88
+        }
89
+    }
90 90
 
91
-	/**
92
-	 * create unique target
93
-	 * @param string $filePath
94
-	 * @param string $shareWith
95
-	 * @param array $exclude (optional)
96
-	 * @return string
97
-	 */
98
-	public function generateTarget($filePath, $shareWith, $exclude = null) {
99
-		$shareFolder = \OCA\Files_Sharing\Helper::getShareFolder();
100
-		$target = \OC\Files\Filesystem::normalizePath($shareFolder . '/' . basename($filePath));
91
+    /**
92
+     * create unique target
93
+     * @param string $filePath
94
+     * @param string $shareWith
95
+     * @param array $exclude (optional)
96
+     * @return string
97
+     */
98
+    public function generateTarget($filePath, $shareWith, $exclude = null) {
99
+        $shareFolder = \OCA\Files_Sharing\Helper::getShareFolder();
100
+        $target = \OC\Files\Filesystem::normalizePath($shareFolder . '/' . basename($filePath));
101 101
 
102
-		// for group shares we return the target right away
103
-		if ($shareWith === false) {
104
-			return $target;
105
-		}
102
+        // for group shares we return the target right away
103
+        if ($shareWith === false) {
104
+            return $target;
105
+        }
106 106
 
107
-		\OC\Files\Filesystem::initMountPoints($shareWith);
108
-		$view = new \OC\Files\View('/' . $shareWith . '/files');
107
+        \OC\Files\Filesystem::initMountPoints($shareWith);
108
+        $view = new \OC\Files\View('/' . $shareWith . '/files');
109 109
 
110
-		if (!$view->is_dir($shareFolder)) {
111
-			$dir = '';
112
-			$subdirs = explode('/', $shareFolder);
113
-			foreach ($subdirs as $subdir) {
114
-				$dir = $dir . '/' . $subdir;
115
-				if (!$view->is_dir($dir)) {
116
-					$view->mkdir($dir);
117
-				}
118
-			}
119
-		}
110
+        if (!$view->is_dir($shareFolder)) {
111
+            $dir = '';
112
+            $subdirs = explode('/', $shareFolder);
113
+            foreach ($subdirs as $subdir) {
114
+                $dir = $dir . '/' . $subdir;
115
+                if (!$view->is_dir($dir)) {
116
+                    $view->mkdir($dir);
117
+                }
118
+            }
119
+        }
120 120
 
121
-		$excludeList = is_array($exclude) ? $exclude : [];
121
+        $excludeList = is_array($exclude) ? $exclude : [];
122 122
 
123
-		return \OCA\Files_Sharing\Helper::generateUniqueTarget($target, $excludeList, $view);
124
-	}
123
+        return \OCA\Files_Sharing\Helper::generateUniqueTarget($target, $excludeList, $view);
124
+    }
125 125
 
126
-	public function formatItems($items, $format, $parameters = null) {
127
-		if ($format === self::FORMAT_SHARED_STORAGE) {
128
-			// Only 1 item should come through for this format call
129
-			$item = array_shift($items);
130
-			return [
131
-				'parent' => $item['parent'],
132
-				'path' => $item['path'],
133
-				'storage' => $item['storage'],
134
-				'permissions' => $item['permissions'],
135
-				'uid_owner' => $item['uid_owner'],
136
-			];
137
-		} else if ($format === self::FORMAT_GET_FOLDER_CONTENTS) {
138
-			$files = [];
139
-			foreach ($items as $item) {
140
-				$file = [];
141
-				$file['fileid'] = $item['file_source'];
142
-				$file['storage'] = $item['storage'];
143
-				$file['path'] = $item['file_target'];
144
-				$file['parent'] = $item['file_parent'];
145
-				$file['name'] = basename($item['file_target']);
146
-				$file['mimetype'] = $item['mimetype'];
147
-				$file['mimepart'] = $item['mimepart'];
148
-				$file['mtime'] = $item['mtime'];
149
-				$file['encrypted'] = $item['encrypted'];
150
-				$file['etag'] = $item['etag'];
151
-				$file['uid_owner'] = $item['uid_owner'];
152
-				$file['displayname_owner'] = $item['displayname_owner'];
126
+    public function formatItems($items, $format, $parameters = null) {
127
+        if ($format === self::FORMAT_SHARED_STORAGE) {
128
+            // Only 1 item should come through for this format call
129
+            $item = array_shift($items);
130
+            return [
131
+                'parent' => $item['parent'],
132
+                'path' => $item['path'],
133
+                'storage' => $item['storage'],
134
+                'permissions' => $item['permissions'],
135
+                'uid_owner' => $item['uid_owner'],
136
+            ];
137
+        } else if ($format === self::FORMAT_GET_FOLDER_CONTENTS) {
138
+            $files = [];
139
+            foreach ($items as $item) {
140
+                $file = [];
141
+                $file['fileid'] = $item['file_source'];
142
+                $file['storage'] = $item['storage'];
143
+                $file['path'] = $item['file_target'];
144
+                $file['parent'] = $item['file_parent'];
145
+                $file['name'] = basename($item['file_target']);
146
+                $file['mimetype'] = $item['mimetype'];
147
+                $file['mimepart'] = $item['mimepart'];
148
+                $file['mtime'] = $item['mtime'];
149
+                $file['encrypted'] = $item['encrypted'];
150
+                $file['etag'] = $item['etag'];
151
+                $file['uid_owner'] = $item['uid_owner'];
152
+                $file['displayname_owner'] = $item['displayname_owner'];
153 153
 
154
-				$storage = \OC\Files\Filesystem::getStorage('/');
155
-				$cache = $storage->getCache();
156
-				$file['size'] = $item['size'];
157
-				$files[] = $file;
158
-			}
159
-			return $files;
160
-		} else if ($format === self::FORMAT_OPENDIR) {
161
-			$files = [];
162
-			foreach ($items as $item) {
163
-				$files[] = basename($item['file_target']);
164
-			}
165
-			return $files;
166
-		} else if ($format === self::FORMAT_GET_ALL) {
167
-			$ids = [];
168
-			foreach ($items as $item) {
169
-				$ids[] = $item['file_source'];
170
-			}
171
-			return $ids;
172
-		} else if ($format === self::FORMAT_PERMISSIONS) {
173
-			$filePermissions = [];
174
-			foreach ($items as $item) {
175
-				$filePermissions[$item['file_source']] = $item['permissions'];
176
-			}
177
-			return $filePermissions;
178
-		} else if ($format === self::FORMAT_TARGET_NAMES) {
179
-			$targets = [];
180
-			foreach ($items as $item) {
181
-				$targets[] = $item['file_target'];
182
-			}
183
-			return $targets;
184
-		}
185
-		return [];
186
-	}
154
+                $storage = \OC\Files\Filesystem::getStorage('/');
155
+                $cache = $storage->getCache();
156
+                $file['size'] = $item['size'];
157
+                $files[] = $file;
158
+            }
159
+            return $files;
160
+        } else if ($format === self::FORMAT_OPENDIR) {
161
+            $files = [];
162
+            foreach ($items as $item) {
163
+                $files[] = basename($item['file_target']);
164
+            }
165
+            return $files;
166
+        } else if ($format === self::FORMAT_GET_ALL) {
167
+            $ids = [];
168
+            foreach ($items as $item) {
169
+                $ids[] = $item['file_source'];
170
+            }
171
+            return $ids;
172
+        } else if ($format === self::FORMAT_PERMISSIONS) {
173
+            $filePermissions = [];
174
+            foreach ($items as $item) {
175
+                $filePermissions[$item['file_source']] = $item['permissions'];
176
+            }
177
+            return $filePermissions;
178
+        } else if ($format === self::FORMAT_TARGET_NAMES) {
179
+            $targets = [];
180
+            foreach ($items as $item) {
181
+                $targets[] = $item['file_target'];
182
+            }
183
+            return $targets;
184
+        }
185
+        return [];
186
+    }
187 187
 
188
-	/**
189
-	 * check if server2server share is enabled
190
-	 *
191
-	 * @param int $shareType
192
-	 * @return boolean
193
-	 */
194
-	public function isShareTypeAllowed($shareType) {
195
-		if ($shareType === \OCP\Share::SHARE_TYPE_REMOTE) {
196
-			return $this->federatedShareProvider->isOutgoingServer2serverShareEnabled();
197
-		}
188
+    /**
189
+     * check if server2server share is enabled
190
+     *
191
+     * @param int $shareType
192
+     * @return boolean
193
+     */
194
+    public function isShareTypeAllowed($shareType) {
195
+        if ($shareType === \OCP\Share::SHARE_TYPE_REMOTE) {
196
+            return $this->federatedShareProvider->isOutgoingServer2serverShareEnabled();
197
+        }
198 198
 
199
-		if ($shareType === \OCP\Share::SHARE_TYPE_REMOTE_GROUP) {
200
-			return $this->federatedShareProvider->isOutgoingServer2serverGroupShareEnabled();
201
-		}
199
+        if ($shareType === \OCP\Share::SHARE_TYPE_REMOTE_GROUP) {
200
+            return $this->federatedShareProvider->isOutgoingServer2serverGroupShareEnabled();
201
+        }
202 202
 
203
-		return true;
204
-	}
203
+        return true;
204
+    }
205 205
 
206
-	/**
207
-	 * resolve reshares to return the correct source item
208
-	 * @param array $source
209
-	 * @return array source item
210
-	 */
211
-	protected static function resolveReshares($source) {
212
-		if (isset($source['parent'])) {
213
-			$parent = $source['parent'];
214
-			while (isset($parent)) {
215
-				$qb = \OC::$server->getDatabaseConnection()->getQueryBuilder();
216
-				$qb->select('parent', 'uid_owner')
217
-					->from('share')
218
-					->where(
219
-						$qb->expr()->eq('id', $qb->createNamedParameter($parent))
220
-					);
221
-				$result = $qb->execute();
222
-				$item = $result->fetch();
223
-				$result->closeCursor();
224
-				if (isset($item['parent'])) {
225
-					$parent = $item['parent'];
226
-				} else {
227
-					$fileOwner = $item['uid_owner'];
228
-					break;
229
-				}
230
-			}
231
-		} else {
232
-			$fileOwner = $source['uid_owner'];
233
-		}
234
-		if (isset($fileOwner)) {
235
-			$source['fileOwner'] = $fileOwner;
236
-		} else {
237
-			\OC::$server->getLogger()->error('No owner found for reshare', ['app' => 'files_sharing']);
238
-		}
206
+    /**
207
+     * resolve reshares to return the correct source item
208
+     * @param array $source
209
+     * @return array source item
210
+     */
211
+    protected static function resolveReshares($source) {
212
+        if (isset($source['parent'])) {
213
+            $parent = $source['parent'];
214
+            while (isset($parent)) {
215
+                $qb = \OC::$server->getDatabaseConnection()->getQueryBuilder();
216
+                $qb->select('parent', 'uid_owner')
217
+                    ->from('share')
218
+                    ->where(
219
+                        $qb->expr()->eq('id', $qb->createNamedParameter($parent))
220
+                    );
221
+                $result = $qb->execute();
222
+                $item = $result->fetch();
223
+                $result->closeCursor();
224
+                if (isset($item['parent'])) {
225
+                    $parent = $item['parent'];
226
+                } else {
227
+                    $fileOwner = $item['uid_owner'];
228
+                    break;
229
+                }
230
+            }
231
+        } else {
232
+            $fileOwner = $source['uid_owner'];
233
+        }
234
+        if (isset($fileOwner)) {
235
+            $source['fileOwner'] = $fileOwner;
236
+        } else {
237
+            \OC::$server->getLogger()->error('No owner found for reshare', ['app' => 'files_sharing']);
238
+        }
239 239
 
240
-		return $source;
241
-	}
240
+        return $source;
241
+    }
242 242
 
243
-	/**
244
-	 * @param string $target
245
-	 * @param array $share
246
-	 * @return array|false source item
247
-	 */
248
-	public static function getSource($target, $share) {
249
-		if ($share['item_type'] === 'folder' && $target !== '') {
250
-			// note: in case of ext storage mount points the path might be empty
251
-			// which would cause a leading slash to appear
252
-			$share['path'] = ltrim($share['path'] . '/' . $target, '/');
253
-		}
254
-		return self::resolveReshares($share);
255
-	}
243
+    /**
244
+     * @param string $target
245
+     * @param array $share
246
+     * @return array|false source item
247
+     */
248
+    public static function getSource($target, $share) {
249
+        if ($share['item_type'] === 'folder' && $target !== '') {
250
+            // note: in case of ext storage mount points the path might be empty
251
+            // which would cause a leading slash to appear
252
+            $share['path'] = ltrim($share['path'] . '/' . $target, '/');
253
+        }
254
+        return self::resolveReshares($share);
255
+    }
256 256
 }
Please login to merge, or discard this patch.
apps/updatenotification/lib/ResetTokenBackgroundJob.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
 	 */
70 70
 	protected function run($argument) {
71 71
 		// Delete old tokens after 2 days
72
-		if($this->timeFactory->getTime() - $this->config->getAppValue('core', 'updater.secret.created', $this->timeFactory->getTime()) >= 172800) {
72
+		if ($this->timeFactory->getTime() - $this->config->getAppValue('core', 'updater.secret.created', $this->timeFactory->getTime()) >= 172800) {
73 73
 			$this->config->deleteSystemValue('updater.secret');
74 74
 		}
75 75
 	}
Please login to merge, or discard this patch.
Indentation   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -33,31 +33,31 @@
 block discarded – undo
33 33
  * @package OCA\UpdateNotification
34 34
  */
35 35
 class ResetTokenBackgroundJob extends TimedJob {
36
-	/** @var IConfig */
37
-	private $config;
38
-	/** @var ITimeFactory */
39
-	private $timeFactory;
36
+    /** @var IConfig */
37
+    private $config;
38
+    /** @var ITimeFactory */
39
+    private $timeFactory;
40 40
 
41
-	/**
42
-	 * @param IConfig $config
43
-	 * @param ITimeFactory $timeFactory
44
-	 */
45
-	public function __construct(IConfig $config,
46
-								ITimeFactory $timeFactory) {
47
-		// Run all 10 minutes
48
-		$this->setInterval(60 * 10);
49
-		$this->config = $config;
50
-		$this->timeFactory = $timeFactory;
51
-	}
41
+    /**
42
+     * @param IConfig $config
43
+     * @param ITimeFactory $timeFactory
44
+     */
45
+    public function __construct(IConfig $config,
46
+                                ITimeFactory $timeFactory) {
47
+        // Run all 10 minutes
48
+        $this->setInterval(60 * 10);
49
+        $this->config = $config;
50
+        $this->timeFactory = $timeFactory;
51
+    }
52 52
 
53
-	/**
54
-	 * @param $argument
55
-	 */
56
-	protected function run($argument) {
57
-		// Delete old tokens after 2 days
58
-		if($this->timeFactory->getTime() - $this->config->getAppValue('core', 'updater.secret.created', $this->timeFactory->getTime()) >= 172800) {
59
-			$this->config->deleteSystemValue('updater.secret');
60
-		}
61
-	}
53
+    /**
54
+     * @param $argument
55
+     */
56
+    protected function run($argument) {
57
+        // Delete old tokens after 2 days
58
+        if($this->timeFactory->getTime() - $this->config->getAppValue('core', 'updater.secret.created', $this->timeFactory->getTime()) >= 172800) {
59
+            $this->config->deleteSystemValue('updater.secret');
60
+        }
61
+    }
62 62
 
63 63
 }
Please login to merge, or discard this patch.
apps/theming/lib/Settings/Section.php 1 patch
Indentation   +46 added lines, -46 removed lines patch added patch discarded remove patch
@@ -28,55 +28,55 @@
 block discarded – undo
28 28
 use OCP\Settings\IIconSection;
29 29
 
30 30
 class Section implements IIconSection {
31
-	/** @var IL10N */
32
-	private $l;
33
-	/** @var IURLGenerator */
34
-	private $url;
31
+    /** @var IL10N */
32
+    private $l;
33
+    /** @var IURLGenerator */
34
+    private $url;
35 35
 
36
-	/**
37
-	 * @param IURLGenerator $url
38
-	 * @param IL10N $l
39
-	 */
40
-	public function __construct(IURLGenerator $url, IL10N $l) {
41
-		$this->url = $url;
42
-		$this->l = $l;
43
-	}
36
+    /**
37
+     * @param IURLGenerator $url
38
+     * @param IL10N $l
39
+     */
40
+    public function __construct(IURLGenerator $url, IL10N $l) {
41
+        $this->url = $url;
42
+        $this->l = $l;
43
+    }
44 44
 
45
-	/**
46
-	 * returns the ID of the section. It is supposed to be a lower case string,
47
-	 * e.g. 'ldap'
48
-	 *
49
-	 * @returns string
50
-	 */
51
-	public function getID() {
52
-		return 'theming';
53
-	}
45
+    /**
46
+     * returns the ID of the section. It is supposed to be a lower case string,
47
+     * e.g. 'ldap'
48
+     *
49
+     * @returns string
50
+     */
51
+    public function getID() {
52
+        return 'theming';
53
+    }
54 54
 
55
-	/**
56
-	 * returns the translated name as it should be displayed, e.g. 'LDAP / AD
57
-	 * integration'. Use the L10N service to translate it.
58
-	 *
59
-	 * @return string
60
-	 */
61
-	public function getName() {
62
-		return $this->l->t('Theming');
63
-	}
55
+    /**
56
+     * returns the translated name as it should be displayed, e.g. 'LDAP / AD
57
+     * integration'. Use the L10N service to translate it.
58
+     *
59
+     * @return string
60
+     */
61
+    public function getName() {
62
+        return $this->l->t('Theming');
63
+    }
64 64
 
65
-	/**
66
-	 * @return int whether the form should be rather on the top or bottom of
67
-	 * the settings navigation. The sections are arranged in ascending order of
68
-	 * the priority values. It is required to return a value between 0 and 99.
69
-	 *
70
-	 * E.g.: 70
71
-	 */
72
-	public function getPriority() {
73
-		return 30;
74
-	}
65
+    /**
66
+     * @return int whether the form should be rather on the top or bottom of
67
+     * the settings navigation. The sections are arranged in ascending order of
68
+     * the priority values. It is required to return a value between 0 and 99.
69
+     *
70
+     * E.g.: 70
71
+     */
72
+    public function getPriority() {
73
+        return 30;
74
+    }
75 75
 
76
-	/**
77
-	 * {@inheritdoc}
78
-	 */
79
-	public function getIcon() {
80
-		return $this->url->imagePath('theming', 'app-dark.svg');
81
-	}
76
+    /**
77
+     * {@inheritdoc}
78
+     */
79
+    public function getIcon() {
80
+        return $this->url->imagePath('theming', 'app-dark.svg');
81
+    }
82 82
 }
Please login to merge, or discard this patch.
apps/twofactor_backupcodes/lib/Db/BackupCode.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -34,13 +34,13 @@
 block discarded – undo
34 34
  */
35 35
 class BackupCode extends Entity {
36 36
 
37
-	/** @var string */
38
-	protected $userId;
37
+    /** @var string */
38
+    protected $userId;
39 39
 
40
-	/** @var string */
41
-	protected $code;
40
+    /** @var string */
41
+    protected $code;
42 42
 
43
-	/** @var int */
44
-	protected $used;
43
+    /** @var int */
44
+    protected $used;
45 45
 
46 46
 }
Please login to merge, or discard this patch.