Passed
Push — master ( 820e13...09d56e )
by Joas
12:51 queued 14s
created
apps/dav/lib/Connector/Sabre/DavAclPlugin.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -45,11 +45,11 @@  discard block
 block discarded – undo
45 45
 
46 46
 	function checkPrivileges($uri, $privileges, $recursion = self::R_PARENT, $throwExceptions = true) {
47 47
 		$access = parent::checkPrivileges($uri, $privileges, $recursion, false);
48
-		if($access === false && $throwExceptions) {
48
+		if ($access === false && $throwExceptions) {
49 49
 			/** @var INode $node */
50 50
 			$node = $this->server->tree->getNodeForPath($uri);
51 51
 
52
-			switch(get_class($node)) {
52
+			switch (get_class($node)) {
53 53
 				case AddressBook::class:
54 54
 					$type = 'Addressbook';
55 55
 					break;
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 	public function propFind(PropFind $propFind, INode $node) {
73 73
 		// If the node is neither readable nor writable then fail unless its of
74 74
 		// the standard user-principal
75
-		if(!($node instanceof User)) {
75
+		if (!($node instanceof User)) {
76 76
 			$path = $propFind->getPath();
77 77
 			$readPermissions = $this->checkPrivileges($path, '{DAV:}read', self::R_PARENT, false);
78 78
 			$writePermissions = $this->checkPrivileges($path, '{DAV:}write', self::R_PARENT, false);
Please login to merge, or discard this patch.
lib/private/legacy/db.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 	 *
55 55
 	 * SQL query via Doctrine prepare(), needs to be execute()'d!
56 56
 	 */
57
-	static public function prepare( $query , $limit = null, $offset = null, $isManipulation = null) {
57
+	static public function prepare($query, $limit = null, $offset = null, $isManipulation = null) {
58 58
 		$connection = \OC::$server->getDatabaseConnection();
59 59
 
60 60
 		if ($isManipulation === null) {
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 
65 65
 		// return the result
66 66
 		try {
67
-			$result =$connection->prepare($query, $limit, $offset);
67
+			$result = $connection->prepare($query, $limit, $offset);
68 68
 		} catch (\Doctrine\DBAL\DBALException $e) {
69 69
 			throw new \OC\DatabaseException($e->getMessage());
70 70
 		}
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 	 * @param string $sql
81 81
 	 * @return bool
82 82
 	 */
83
-	static public function isManipulation( $sql ) {
83
+	static public function isManipulation($sql) {
84 84
 		$selectOccurrence = stripos($sql, 'SELECT');
85 85
 		if ($selectOccurrence !== false && $selectOccurrence < 10) {
86 86
 			return false;
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 	 * @return OC_DB_StatementWrapper
110 110
 	 * @throws \OC\DatabaseException
111 111
 	 */
112
-	static public function executeAudited( $stmt, array $parameters = []) {
112
+	static public function executeAudited($stmt, array $parameters = []) {
113 113
 		if (is_string($stmt)) {
114 114
 			// convert to an array with 'sql'
115 115
 			if (stripos($stmt, 'LIMIT') !== false) { //OFFSET requires LIMIT, so we only need to check for LIMIT
@@ -122,14 +122,14 @@  discard block
 block discarded – undo
122 122
 		}
123 123
 		if (is_array($stmt)) {
124 124
 			// convert to prepared statement
125
-			if ( ! array_key_exists('sql', $stmt) ) {
125
+			if (!array_key_exists('sql', $stmt)) {
126 126
 				$message = 'statement array must at least contain key \'sql\'';
127 127
 				throw new \OC\DatabaseException($message);
128 128
 			}
129
-			if ( ! array_key_exists('limit', $stmt) ) {
129
+			if (!array_key_exists('limit', $stmt)) {
130 130
 				$stmt['limit'] = null;
131 131
 			}
132
-			if ( ! array_key_exists('limit', $stmt) ) {
132
+			if (!array_key_exists('limit', $stmt)) {
133 133
 				$stmt['offset'] = null;
134 134
 			}
135 135
 			$stmt = self::prepare($stmt['sql'], $stmt['limit'], $stmt['offset']);
@@ -140,9 +140,9 @@  discard block
 block discarded – undo
140 140
 			self::raiseExceptionOnError($result, 'Could not execute statement');
141 141
 		} else {
142 142
 			if (is_object($stmt)) {
143
-				$message = 'Expected a prepared statement or array got ' . get_class($stmt);
143
+				$message = 'Expected a prepared statement or array got '.get_class($stmt);
144 144
 			} else {
145
-				$message = 'Expected a prepared statement or array got ' . gettype($stmt);
145
+				$message = 'Expected a prepared statement or array got '.gettype($stmt);
146 146
 			}
147 147
 			throw new \OC\DatabaseException($message);
148 148
 		}
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
 	 *
169 169
 	 * TODO: write more documentation
170 170
 	 */
171
-	public static function createDbFromStructure( $file ) {
171
+	public static function createDbFromStructure($file) {
172 172
 		$schemaManager = self::getMDB2SchemaManager();
173 173
 		return $schemaManager->createDbFromStructure($file);
174 174
 	}
@@ -208,11 +208,11 @@  discard block
 block discarded – undo
208 208
 	 * @throws \OC\DatabaseException
209 209
 	 */
210 210
 	public static function raiseExceptionOnError($result, $message = null) {
211
-		if($result === false) {
211
+		if ($result === false) {
212 212
 			if ($message === null) {
213 213
 				$message = self::getErrorMessage();
214 214
 			} else {
215
-				$message .= ', Root cause:' . self::getErrorMessage();
215
+				$message .= ', Root cause:'.self::getErrorMessage();
216 216
 			}
217 217
 			throw new \OC\DatabaseException($message);
218 218
 		}
Please login to merge, or discard this patch.
lib/private/App/AppStore/Version/VersionParser.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 	 * @return bool
35 35
 	 */
36 36
 	private function isValidVersionString($versionString) {
37
-		return (bool)preg_match('/^[0-9.]+$/', $versionString);
37
+		return (bool) preg_match('/^[0-9.]+$/', $versionString);
38 38
 	}
39 39
 
40 40
 	/**
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 	 */
47 47
 	public function getVersion($versionSpec) {
48 48
 		// * indicates that the version is compatible with all versions
49
-		if($versionSpec === '*') {
49
+		if ($versionSpec === '*') {
50 50
 			return new Version('', '');
51 51
 		}
52 52
 
@@ -58,17 +58,17 @@  discard block
 block discarded – undo
58 58
 		$secondVersion = isset($versionElements[1]) ? $versionElements[1] : '';
59 59
 		$secondVersionNumber = substr($secondVersion, 2);
60 60
 
61
-		switch(count($versionElements)) {
61
+		switch (count($versionElements)) {
62 62
 			case 1:
63
-				if(!$this->isValidVersionString($firstVersionNumber)) {
63
+				if (!$this->isValidVersionString($firstVersionNumber)) {
64 64
 					break;
65 65
 				}
66
-				if(strpos($firstVersion, '>') === 0) {
66
+				if (strpos($firstVersion, '>') === 0) {
67 67
 					return new Version($firstVersionNumber, '');
68 68
 				}
69 69
 				return new Version('', $firstVersionNumber);
70 70
 			case 2:
71
-				if(!$this->isValidVersionString($firstVersionNumber) || !$this->isValidVersionString($secondVersionNumber)) {
71
+				if (!$this->isValidVersionString($firstVersionNumber) || !$this->isValidVersionString($secondVersionNumber)) {
72 72
 					break;
73 73
 				}
74 74
 				return new Version($firstVersionNumber, $secondVersionNumber);
Please login to merge, or discard this patch.
apps/dav/lib/DAV/Sharing/Plugin.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -101,11 +101,11 @@  discard block
 block discarded – undo
101 101
 	 */
102 102
 	function initialize(Server $server) {
103 103
 		$this->server = $server;
104
-		$this->server->xml->elementMap['{' . Plugin::NS_OWNCLOUD . '}share'] = ShareRequest::class;
105
-		$this->server->xml->elementMap['{' . Plugin::NS_OWNCLOUD . '}invite'] = Invite::class;
104
+		$this->server->xml->elementMap['{'.Plugin::NS_OWNCLOUD.'}share'] = ShareRequest::class;
105
+		$this->server->xml->elementMap['{'.Plugin::NS_OWNCLOUD.'}invite'] = Invite::class;
106 106
 
107 107
 		$this->server->on('method:POST', [$this, 'httpPost']);
108
-		$this->server->on('propFind',    [$this, 'propFind']);
108
+		$this->server->on('propFind', [$this, 'propFind']);
109 109
 	}
110 110
 
111 111
 	/**
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
 
149 149
 			// Dealing with the 'share' document, which modified invitees on a
150 150
 			// calendar.
151
-			case '{' . self::NS_OWNCLOUD . '}share' :
151
+			case '{'.self::NS_OWNCLOUD.'}share' :
152 152
 
153 153
 				// We can only deal with IShareableCalendar objects
154 154
 				if (!$node instanceof IShareable) {
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
 	function propFind(PropFind $propFind, INode $node) {
192 192
 		if ($node instanceof IShareable) {
193 193
 
194
-			$propFind->handle('{' . Plugin::NS_OWNCLOUD . '}invite', function() use ($node) {
194
+			$propFind->handle('{'.Plugin::NS_OWNCLOUD.'}invite', function() use ($node) {
195 195
 				return new Invite(
196 196
 					$node->getShares()
197 197
 				);
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Search/SearchPlugin.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 
79 79
 		$server->on('report', [$this, 'report']);
80 80
 
81
-		$server->xml->elementMap['{' . self::NS_Nextcloud . '}calendar-search'] =
81
+		$server->xml->elementMap['{'.self::NS_Nextcloud.'}calendar-search'] =
82 82
 			CalendarSearchReport::class;
83 83
 	}
84 84
 
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 	 */
93 93
 	public function report($reportName, $report, $path) {
94 94
 		switch ($reportName) {
95
-			case '{' . self::NS_Nextcloud . '}calendar-search':
95
+			case '{'.self::NS_Nextcloud.'}calendar-search':
96 96
 				$this->server->transactionType = 'report-nc-calendar-search';
97 97
 				$this->calendarSearch($report);
98 98
 				return false;
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 
115 115
 		$reports = [];
116 116
 		if ($node instanceof CalendarHome) {
117
-			$reports[] = '{' . self::NS_Nextcloud . '}calendar-search';
117
+			$reports[] = '{'.self::NS_Nextcloud.'}calendar-search';
118 118
 		}
119 119
 
120 120
 		return $reports;
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 
145 145
 			foreach ($nodePaths as $path) {
146 146
 				list($properties) = $this->server->getPropertiesForPath(
147
-					$this->server->getRequestUri() . '/' . $path,
147
+					$this->server->getRequestUri().'/'.$path,
148 148
 					$report->properties);
149 149
 				$result[] = $properties;
150 150
 			}
Please login to merge, or discard this patch.
lib/private/Memcache/Redis.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -51,8 +51,8 @@  discard block
 block discarded – undo
51 51
 	}
52 52
 
53 53
 	public function get($key) {
54
-		$result = self::$cache->get($this->getNameSpace() . $key);
55
-		if ($result === false && !self::$cache->exists($this->getNameSpace() . $key)) {
54
+		$result = self::$cache->get($this->getNameSpace().$key);
55
+		if ($result === false && !self::$cache->exists($this->getNameSpace().$key)) {
56 56
 			return null;
57 57
 		} else {
58 58
 			return json_decode($result, true);
@@ -61,18 +61,18 @@  discard block
 block discarded – undo
61 61
 
62 62
 	public function set($key, $value, $ttl = 0) {
63 63
 		if ($ttl > 0) {
64
-			return self::$cache->setex($this->getNameSpace() . $key, $ttl, json_encode($value));
64
+			return self::$cache->setex($this->getNameSpace().$key, $ttl, json_encode($value));
65 65
 		} else {
66
-			return self::$cache->set($this->getNameSpace() . $key, json_encode($value));
66
+			return self::$cache->set($this->getNameSpace().$key, json_encode($value));
67 67
 		}
68 68
 	}
69 69
 
70 70
 	public function hasKey($key) {
71
-		return self::$cache->exists($this->getNameSpace() . $key);
71
+		return self::$cache->exists($this->getNameSpace().$key);
72 72
 	}
73 73
 
74 74
 	public function remove($key) {
75
-		if (self::$cache->del($this->getNameSpace() . $key)) {
75
+		if (self::$cache->del($this->getNameSpace().$key)) {
76 76
 			return true;
77 77
 		} else {
78 78
 			return false;
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 	}
81 81
 
82 82
 	public function clear($prefix = '') {
83
-		$prefix = $this->getNameSpace() . $prefix . '*';
83
+		$prefix = $this->getNameSpace().$prefix.'*';
84 84
 		$keys = self::$cache->keys($prefix);
85 85
 		$deleted = self::$cache->del($keys);
86 86
 
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 		if (!is_int($value)) {
101 101
 			$value = json_encode($value);
102 102
 		}
103
-		return self::$cache->setnx($this->getPrefix() . $key, $value);
103
+		return self::$cache->setnx($this->getPrefix().$key, $value);
104 104
 	}
105 105
 
106 106
 	/**
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 	 * @return int | bool
112 112
 	 */
113 113
 	public function inc($key, $step = 1) {
114
-		return self::$cache->incrBy($this->getNameSpace() . $key, $step);
114
+		return self::$cache->incrBy($this->getNameSpace().$key, $step);
115 115
 	}
116 116
 
117 117
 	/**
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 		if (!$this->hasKey($key)) {
126 126
 			return false;
127 127
 		}
128
-		return self::$cache->decrBy($this->getNameSpace() . $key, $step);
128
+		return self::$cache->decrBy($this->getNameSpace().$key, $step);
129 129
 	}
130 130
 
131 131
 	/**
@@ -140,10 +140,10 @@  discard block
 block discarded – undo
140 140
 		if (!is_int($new)) {
141 141
 			$new = json_encode($new);
142 142
 		}
143
-		self::$cache->watch($this->getNameSpace() . $key);
143
+		self::$cache->watch($this->getNameSpace().$key);
144 144
 		if ($this->get($key) === $old) {
145 145
 			$result = self::$cache->multi()
146
-				->set($this->getNameSpace() . $key, $new)
146
+				->set($this->getNameSpace().$key, $new)
147 147
 				->exec();
148 148
 			return $result !== false;
149 149
 		}
@@ -159,10 +159,10 @@  discard block
 block discarded – undo
159 159
 	 * @return bool
160 160
 	 */
161 161
 	public function cad($key, $old) {
162
-		self::$cache->watch($this->getNameSpace() . $key);
162
+		self::$cache->watch($this->getNameSpace().$key);
163 163
 		if ($this->get($key) === $old) {
164 164
 			$result = self::$cache->multi()
165
-				->del($this->getNameSpace() . $key)
165
+				->del($this->getNameSpace().$key)
166 166
 				->exec();
167 167
 			return $result !== false;
168 168
 		}
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 	}
172 172
 
173 173
 	public function setTTL($key, $ttl) {
174
-		self::$cache->expire($this->getNameSpace() . $key, $ttl);
174
+		self::$cache->expire($this->getNameSpace().$key, $ttl);
175 175
 	}
176 176
 
177 177
 	static public function isAvailable() {
Please login to merge, or discard this patch.
apps/files/lib/App.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
 	public static function extendJsConfig($settings) {
58 58
 		$appConfig = json_decode($settings['array']['oc_appconfig'], true);
59 59
 
60
-		$maxChunkSize = (int)\OC::$server->getConfig()->getAppValue('files', 'max_chunk_size', 10 * 1024 * 1024);
60
+		$maxChunkSize = (int) \OC::$server->getConfig()->getAppValue('files', 'max_chunk_size', 10 * 1024 * 1024);
61 61
 		$appConfig['files'] = [
62 62
 			'max_chunk_size' => $maxChunkSize
63 63
 		];
Please login to merge, or discard this patch.
lib/private/DB/SQLiteSessionInit.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,8 +56,8 @@
 block discarded – undo
56 56
 	 */
57 57
 	public function postConnect(ConnectionEventArgs $args) {
58 58
 		$sensitive = $this->caseSensitiveLike ? 'true' : 'false';
59
-		$args->getConnection()->executeUpdate('PRAGMA case_sensitive_like = ' . $sensitive);
60
-		$args->getConnection()->executeUpdate('PRAGMA journal_mode = ' . $this->journalMode);
59
+		$args->getConnection()->executeUpdate('PRAGMA case_sensitive_like = '.$sensitive);
60
+		$args->getConnection()->executeUpdate('PRAGMA journal_mode = '.$this->journalMode);
61 61
 		/** @var \PDO $pdo */
62 62
 		$pdo = $args->getConnection()->getWrappedConnection();
63 63
 		$pdo->sqliteCreateFunction('md5', 'md5', 1);
Please login to merge, or discard this patch.
lib/public/Settings/IManager.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 	/**
37 37
 	 * @since 9.1.0
38 38
 	 */
39
-	const KEY_ADMIN_SECTION  = 'admin-section';
39
+	const KEY_ADMIN_SECTION = 'admin-section';
40 40
 
41 41
 	/**
42 42
 	 * @since 13.0.0
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 	/**
47 47
 	 * @since 13.0.0
48 48
 	 */
49
-	const KEY_PERSONAL_SECTION  = 'personal-section';
49
+	const KEY_PERSONAL_SECTION = 'personal-section';
50 50
 
51 51
 	/**
52 52
 	 * @param string $type 'admin' or 'personal'
Please login to merge, or discard this patch.