Passed
Push — master ( d52ee8...0e6e80 )
by Joas
52:59 queued 30:23
created
lib/private/Files/ObjectStore/S3Signature.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 		$request = $this->prepareRequest($request, $credentials);
65 65
 		$stringToSign = $this->createCanonicalizedString($request);
66 66
 		$auth = 'AWS '
67
-			. $credentials->getAccessKeyId() . ':'
67
+			. $credentials->getAccessKeyId().':'
68 68
 			. $this->signString($stringToSign, $credentials);
69 69
 
70 70
 		return $request->withHeader('Authorization', $auth);
@@ -148,11 +148,11 @@  discard block
 block discarded – undo
148 148
 		RequestInterface $request,
149 149
 		$expires = null
150 150
 	) {
151
-		$buffer = $request->getMethod() . "\n";
151
+		$buffer = $request->getMethod()."\n";
152 152
 
153 153
 		// Add the interesting headers
154 154
 		foreach ($this->signableHeaders as $header) {
155
-			$buffer .= $request->getHeaderLine($header) . "\n";
155
+			$buffer .= $request->getHeaderLine($header)."\n";
156 156
 		}
157 157
 
158 158
 		$date = $expires ?: $request->getHeaderLine('date');
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 			if (strpos($name, 'x-amz-') === 0) {
171 171
 				$value = implode(',', $header);
172 172
 				if (strlen($value) > 0) {
173
-					$headers[$name] = $name . ':' . $value;
173
+					$headers[$name] = $name.':'.$value;
174 174
 				}
175 175
 			}
176 176
 		}
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 
182 182
 		ksort($headers);
183 183
 
184
-		return implode("\n", $headers) . "\n";
184
+		return implode("\n", $headers)."\n";
185 185
 	}
186 186
 
187 187
 	private function createCanonicalizedResource(RequestInterface $request) {
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
 		if ($data['bucket']) {
192 192
 			$buffer .= $data['bucket'];
193 193
 			if (!empty($data['key']) || !$data['path_style']) {
194
-				$buffer .= '/' . $data['key'];
194
+				$buffer .= '/'.$data['key'];
195 195
 			}
196 196
 		}
197 197
 
Please login to merge, or discard this patch.
lib/private/Group/Group.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
 			return;
174 174
 		}
175 175
 
176
-		$this->dispatcher->dispatch(IGroup::class . '::preAddUser', new GenericEvent($this, [
176
+		$this->dispatcher->dispatch(IGroup::class.'::preAddUser', new GenericEvent($this, [
177 177
 			'user' => $user,
178 178
 		]));
179 179
 
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
 					$this->users[$user->getUID()] = $user;
188 188
 				}
189 189
 
190
-				$this->dispatcher->dispatch(IGroup::class . '::postAddUser', new GenericEvent($this, [
190
+				$this->dispatcher->dispatch(IGroup::class.'::postAddUser', new GenericEvent($this, [
191 191
 					'user' => $user,
192 192
 				]));
193 193
 
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 	 */
207 207
 	public function removeUser($user) {
208 208
 		$result = false;
209
-		$this->dispatcher->dispatch(IGroup::class . '::preRemoveUser', new GenericEvent($this, [
209
+		$this->dispatcher->dispatch(IGroup::class.'::preRemoveUser', new GenericEvent($this, [
210 210
 			'user' => $user,
211 211
 		]));
212 212
 		if ($this->emitter) {
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
 			}
220 220
 		}
221 221
 		if ($result) {
222
-			$this->dispatcher->dispatch(IGroup::class . '::postRemoveUser', new GenericEvent($this, [
222
+			$this->dispatcher->dispatch(IGroup::class.'::postRemoveUser', new GenericEvent($this, [
223 223
 				'user' => $user,
224 224
 			]));
225 225
 			if ($this->emitter) {
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
 		}
330 330
 
331 331
 		$result = false;
332
-		$this->dispatcher->dispatch(IGroup::class . '::preDelete', new GenericEvent($this));
332
+		$this->dispatcher->dispatch(IGroup::class.'::preDelete', new GenericEvent($this));
333 333
 		if ($this->emitter) {
334 334
 			$this->emitter->emit('\OC\Group', 'preDelete', [$this]);
335 335
 		}
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
 			}
341 341
 		}
342 342
 		if ($result) {
343
-			$this->dispatcher->dispatch(IGroup::class . '::postDelete', new GenericEvent($this));
343
+			$this->dispatcher->dispatch(IGroup::class.'::postDelete', new GenericEvent($this));
344 344
 			if ($this->emitter) {
345 345
 				$this->emitter->emit('\OC\Group', 'postDelete', [$this]);
346 346
 			}
@@ -398,7 +398,7 @@  discard block
 block discarded – undo
398 398
 	 * @since 16.0.0
399 399
 	 */
400 400
 	public function hideFromCollaboration(): bool {
401
-		return array_reduce($this->backends, function (bool $hide, GroupInterface $backend) {
401
+		return array_reduce($this->backends, function(bool $hide, GroupInterface $backend) {
402 402
 			return $hide | ($backend instanceof IHideFromCollaborationBackend && $backend->hideGroup($this->gid));
403 403
 		}, false);
404 404
 	}
Please login to merge, or discard this patch.
lib/private/Updater/ChangesCheck.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -142,12 +142,12 @@
 block discarded – undo
142 142
 			$xml = @simplexml_load_string($body);
143 143
 			libxml_disable_entity_loader($loadEntities);
144 144
 			if ($xml !== false) {
145
-				$data['changelogURL'] = (string)$xml->changelog['href'];
145
+				$data['changelogURL'] = (string) $xml->changelog['href'];
146 146
 				$data['whatsNew'] = [];
147 147
 				foreach ($xml->whatsNew as $infoSet) {
148
-					$data['whatsNew'][(string)$infoSet['lang']] = [
149
-						'regular' => (array)$infoSet->regular->item,
150
-						'admin' => (array)$infoSet->admin->item,
148
+					$data['whatsNew'][(string) $infoSet['lang']] = [
149
+						'regular' => (array) $infoSet->regular->item,
150
+						'admin' => (array) $infoSet->admin->item,
151 151
 					];
152 152
 				}
153 153
 			} else {
Please login to merge, or discard this patch.
lib/private/Repair/RemoveLinkShares.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 
113 113
 		$subQuery = $this->connection->getQueryBuilder();
114 114
 		$subQuery->select('s1.id')
115
-			->from($subQuery->createFunction('(' . $subSubQuery->getSQL() . ')'), 's1')
115
+			->from($subQuery->createFunction('('.$subSubQuery->getSQL().')'), 's1')
116 116
 			->join(
117 117
 				's1', 'share', 's2',
118 118
 				$subQuery->expr()->eq('s1.parent', 's2.id')
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 		$query = $this->connection->getQueryBuilder();
127 127
 		$query->select($query->func()->count('*', 'total'))
128 128
 			->from('share')
129
-			->where($query->expr()->in('id', $query->createFunction('(' . $subQuery->getSQL() . ')')));
129
+			->where($query->expr()->in('id', $query->createFunction('('.$subQuery->getSQL().')')));
130 130
 
131 131
 		$result = $query->execute();
132 132
 		$data = $result->fetch();
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 
150 150
 		$query = $this->connection->getQueryBuilder();
151 151
 		$query->select('s1.id', 's1.uid_owner', 's1.uid_initiator')
152
-			->from($query->createFunction('(' . $subQuery->getSQL() . ')'), 's1')
152
+			->from($query->createFunction('('.$subQuery->getSQL().')'), 's1')
153 153
 			->join(
154 154
 				's1', 'share', 's2',
155 155
 				$query->expr()->eq('s1.parent', 's2.id')
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
 		$this->addToNotify($data['uid_owner']);
174 174
 		$this->addToNotify($data['uid_initiator']);
175 175
 
176
-		$this->deleteShare((int)$id);
176
+		$this->deleteShare((int) $id);
177 177
 	}
178 178
 
179 179
 	/**
Please login to merge, or discard this patch.
lib/private/Streamer.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 
40 40
 class Streamer {
41 41
 	// array of regexp. Matching user agents will get tar instead of zip
42
-	private $preferTarFor = [ '/macintosh|mac os x/i' ];
42
+	private $preferTarFor = ['/macintosh|mac os x/i'];
43 43
 
44 44
 	// streamer instance
45 45
 	private $streamerInstance;
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 	 */
92 92
 	public function sendHeaders($name) {
93 93
 		$extension = $this->streamerInstance instanceof ZipStreamer ? '.zip' : '.tar';
94
-		$fullName = $name . $extension;
94
+		$fullName = $name.$extension;
95 95
 		$this->streamerInstance->sendHeaders($fullName);
96 96
 	}
97 97
 
@@ -104,11 +104,11 @@  discard block
 block discarded – undo
104 104
 	 */
105 105
 	public function addDirRecursive(string $dir, string $internalDir = ''): void {
106 106
 		$dirname = basename($dir);
107
-		$rootDir = $internalDir . $dirname;
107
+		$rootDir = $internalDir.$dirname;
108 108
 		if (!empty($rootDir)) {
109 109
 			$this->streamerInstance->addEmptyDir($rootDir);
110 110
 		}
111
-		$internalDir .= $dirname . '/';
111
+		$internalDir .= $dirname.'/';
112 112
 		// prevent absolute dirs
113 113
 		$internalDir = ltrim($internalDir, '/');
114 114
 
@@ -126,14 +126,14 @@  discard block
 block discarded – undo
126 126
 				}
127 127
 				$this->addFileFromStream(
128 128
 					$fh,
129
-					$internalDir . $file->getName(),
129
+					$internalDir.$file->getName(),
130 130
 					$file->getSize(),
131 131
 					$file->getMTime()
132 132
 				);
133 133
 				fclose($fh);
134 134
 			} elseif ($file instanceof Folder) {
135 135
 				if ($file->isReadable()) {
136
-					$this->addDirRecursive($dir . '/' . $file->getName(), $internalDir);
136
+					$this->addDirRecursive($dir.'/'.$file->getName(), $internalDir);
137 137
 				}
138 138
 			}
139 139
 		}
Please login to merge, or discard this patch.
lib/private/legacy/OC_Response.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -40,10 +40,10 @@  discard block
 block discarded – undo
40 40
 				\OC\AppFramework\Http\Request::USER_AGENT_ANDROID_MOBILE_CHROME,
41 41
 				\OC\AppFramework\Http\Request::USER_AGENT_FREEBOX,
42 42
 			])) {
43
-			header('Content-Disposition: ' . rawurlencode($type) . '; filename="' . rawurlencode($filename) . '"');
43
+			header('Content-Disposition: '.rawurlencode($type).'; filename="'.rawurlencode($filename).'"');
44 44
 		} else {
45
-			header('Content-Disposition: ' . rawurlencode($type) . '; filename*=UTF-8\'\'' . rawurlencode($filename)
46
-												 . '; filename="' . rawurlencode($filename) . '"');
45
+			header('Content-Disposition: '.rawurlencode($type).'; filename*=UTF-8\'\''.rawurlencode($filename)
46
+												 . '; filename="'.rawurlencode($filename).'"');
47 47
 		}
48 48
 	}
49 49
 
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 			. 'connect-src *; '
91 91
 			. 'object-src \'none\'; '
92 92
 			. 'base-uri \'self\'; ';
93
-		header('Content-Security-Policy:' . $policy);
93
+		header('Content-Security-Policy:'.$policy);
94 94
 
95 95
 		// Send fallback headers for installations that don't have the possibility to send
96 96
 		// custom headers on the webserver side
Please login to merge, or discard this patch.
lib/private/legacy/OC_EventSource.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 		header('X-Accel-Buffering: no');
61 61
 		$this->fallback = isset($_GET['fallback']) and $_GET['fallback'] == 'true';
62 62
 		if ($this->fallback) {
63
-			$this->fallBackId = (int)$_GET['fallback_id'];
63
+			$this->fallBackId = (int) $_GET['fallback_id'];
64 64
 			/**
65 65
 			 * FIXME: The default content-security-policy of ownCloud forbids inline
66 66
 			 * JavaScript for security reasons. IE starting on Windows 10 will
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 			 */
74 74
 			header("Content-Security-Policy: default-src 'none'; script-src 'unsafe-inline'");
75 75
 			header("Content-Type: text/html");
76
-			echo str_repeat('<span></span>' . PHP_EOL, 10); //dummy data to keep IE happy
76
+			echo str_repeat('<span></span>'.PHP_EOL, 10); //dummy data to keep IE happy
77 77
 		} else {
78 78
 			header("Content-Type: text/event-stream");
79 79
 		}
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 	 */
102 102
 	public function send($type, $data = null) {
103 103
 		if ($data and !preg_match('/^[A-Za-z0-9_]+$/', $type)) {
104
-			throw new BadMethodCallException('Type needs to be alphanumeric ('. $type .')');
104
+			throw new BadMethodCallException('Type needs to be alphanumeric ('.$type.')');
105 105
 		}
106 106
 		$this->init();
107 107
 		if (is_null($data)) {
@@ -110,13 +110,13 @@  discard block
 block discarded – undo
110 110
 		}
111 111
 		if ($this->fallback) {
112 112
 			$response = '<script type="text/javascript">window.parent.OC.EventSource.fallBackCallBack('
113
-				. $this->fallBackId . ',"' . $type . '",' . OC_JSON::encode($data) . ')</script>' . PHP_EOL;
113
+				. $this->fallBackId.',"'.$type.'",'.OC_JSON::encode($data).')</script>'.PHP_EOL;
114 114
 			echo $response;
115 115
 		} else {
116 116
 			if ($type) {
117
-				echo 'event: ' . $type . PHP_EOL;
117
+				echo 'event: '.$type.PHP_EOL;
118 118
 			}
119
-			echo 'data: ' . OC_JSON::encode($data) . PHP_EOL;
119
+			echo 'data: '.OC_JSON::encode($data).PHP_EOL;
120 120
 		}
121 121
 		echo PHP_EOL;
122 122
 		flush();
Please login to merge, or discard this patch.
lib/private/legacy/OC_Defaults.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 		$this->defaultColorPrimary = '#0082c9';
69 69
 		$this->defaultTextColorPrimary = '#ffffff';
70 70
 
71
-		$themePath = OC::$SERVERROOT . '/themes/' . OC_Util::getTheme() . '/defaults.php';
71
+		$themePath = OC::$SERVERROOT.'/themes/'.OC_Util::getTheme().'/defaults.php';
72 72
 		if (file_exists($themePath)) {
73 73
 			// prevent defaults.php from printing output
74 74
 			ob_start();
@@ -243,9 +243,9 @@  discard block
 block discarded – undo
243 243
 		if ($this->themeExist('getShortFooter')) {
244 244
 			$footer = $this->theme->getShortFooter();
245 245
 		} else {
246
-			$footer = '<a href="'. $this->getBaseUrl() . '" target="_blank"' .
247
-				' rel="noreferrer noopener">' .$this->getEntity() . '</a>'.
248
-				' – ' . $this->getSlogan();
246
+			$footer = '<a href="'.$this->getBaseUrl().'" target="_blank"'.
247
+				' rel="noreferrer noopener">'.$this->getEntity().'</a>'.
248
+				' – '.$this->getSlogan();
249 249
 		}
250 250
 
251 251
 		return $footer;
@@ -273,7 +273,7 @@  discard block
 block discarded – undo
273 273
 		if ($this->themeExist('buildDocLinkToKey')) {
274 274
 			return $this->theme->buildDocLinkToKey($key);
275 275
 		}
276
-		return $this->getDocBaseUrl() . '/server/' . $this->defaultDocVersion . '/go.php?to=' . $key;
276
+		return $this->getDocBaseUrl().'/server/'.$this->defaultDocVersion.'/go.php?to='.$key;
277 277
 	}
278 278
 
279 279
 	/**
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
 		} else {
321 321
 			$logo = \OC::$server->getURLGenerator()->imagePath('core', 'logo/logo.png');
322 322
 		}
323
-		return $logo . '?v=' . hash('sha1', implode('.', \OCP\Util::getVersion()));
323
+		return $logo.'?v='.hash('sha1', implode('.', \OCP\Util::getVersion()));
324 324
 	}
325 325
 
326 326
 	public function getTextColorPrimary() {
Please login to merge, or discard this patch.
lib/private/legacy/OC_JSON.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 	public static function checkAppEnabled($app) {
45 45
 		if (!\OC::$server->getAppManager()->isEnabledForUser($app)) {
46 46
 			$l = \OC::$server->getL10N('lib');
47
-			self::error([ 'data' => [ 'message' => $l->t('Application is not enabled'), 'error' => 'application_not_enabled' ]]);
47
+			self::error(['data' => ['message' => $l->t('Application is not enabled'), 'error' => 'application_not_enabled']]);
48 48
 			exit();
49 49
 		}
50 50
 	}
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 			|| $twoFactorAuthManger->needsSecondFactor(\OC::$server->getUserSession()->getUser())) {
61 61
 			$l = \OC::$server->getL10N('lib');
62 62
 			http_response_code(\OCP\AppFramework\Http::STATUS_UNAUTHORIZED);
63
-			self::error([ 'data' => [ 'message' => $l->t('Authentication error'), 'error' => 'authentication_error' ]]);
63
+			self::error(['data' => ['message' => $l->t('Authentication error'), 'error' => 'authentication_error']]);
64 64
 			exit();
65 65
 		}
66 66
 	}
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 
79 79
 		if (!\OC::$server->getRequest()->passesCSRFCheck()) {
80 80
 			$l = \OC::$server->getL10N('lib');
81
-			self::error([ 'data' => [ 'message' => $l->t('Token expired. Please reload page.'), 'error' => 'token_expired' ]]);
81
+			self::error(['data' => ['message' => $l->t('Token expired. Please reload page.'), 'error' => 'token_expired']]);
82 82
 			exit();
83 83
 		}
84 84
 	}
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 	public static function checkAdminUser() {
92 92
 		if (!OC_User::isAdminUser(OC_User::getUser())) {
93 93
 			$l = \OC::$server->getL10N('lib');
94
-			self::error([ 'data' => [ 'message' => $l->t('Authentication error'), 'error' => 'authentication_error' ]]);
94
+			self::error(['data' => ['message' => $l->t('Authentication error'), 'error' => 'authentication_error']]);
95 95
 			exit();
96 96
 		}
97 97
 	}
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 	 */
124 124
 	protected static function to_string(&$value) {
125 125
 		if ($value instanceof \OC\L10N\L10NString) {
126
-			$value = (string)$value;
126
+			$value = (string) $value;
127 127
 		}
128 128
 	}
129 129
 
Please login to merge, or discard this patch.