Completed
Pull Request — master (#8314)
by Robin
15:50
created
lib/private/AppConfig.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -160,7 +160,7 @@
 block discarded – undo
160 160
 	 *
161 161
 	 * @param string $app app
162 162
 	 * @param string $key key
163
-	 * @param string|float|int $value value
163
+	 * @param string $value value
164 164
 	 * @return bool True if the value was inserted or updated, false if the value was the same
165 165
 	 */
166 166
 	public function setValue($app, $key, $value) {
Please login to merge, or discard this patch.
lib/private/User/Manager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -193,7 +193,7 @@
 block discarded – undo
193 193
 	 * @internal
194 194
 	 * @param string $loginName
195 195
 	 * @param string $password
196
-	 * @return mixed the User object on success, false otherwise
196
+	 * @return IUser the User object on success, false otherwise
197 197
 	 */
198 198
 	public function checkPasswordNoLogging($loginName, $password) {
199 199
 		$loginName = str_replace("\0", '', $loginName);
Please login to merge, or discard this patch.
lib/private/User/Session.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -339,7 +339,7 @@  discard block
 block discarded – undo
339 339
 	 * @param IUser $user
340 340
 	 * @param array $loginDetails
341 341
 	 * @param bool $regenerateSessionId
342
-	 * @return true returns true if login successful or an exception otherwise
342
+	 * @return boolean returns true if login successful or an exception otherwise
343 343
 	 * @throws LoginException
344 344
 	 */
345 345
 	public function completeLogin(IUser $user, array $loginDetails, $regenerateSessionId = true) {
@@ -446,6 +446,9 @@  discard block
 block discarded – undo
446 446
 		return $this->config->getSystemValue('token_auth_enforced', false);
447 447
 	}
448 448
 
449
+	/**
450
+	 * @param string $username
451
+	 */
449 452
 	protected function isTwoFactorEnforced($username) {
450 453
 		Util::emitHook(
451 454
 			'\OCA\Files_Sharing\API\Server2Server',
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Storage/AmazonS3.php 1 patch
Doc Comments   +10 added lines, -1 removed lines patch added patch discarded remove patch
@@ -85,6 +85,9 @@  discard block
 block discarded – undo
85 85
 		return $path === '.';
86 86
 	}
87 87
 
88
+	/**
89
+	 * @param string $path
90
+	 */
88 91
 	private function cleanKey($path) {
89 92
 		if ($this->isRoot($path)) {
90 93
 			return '/';
@@ -108,7 +111,7 @@  discard block
 block discarded – undo
108 111
 	}
109 112
 
110 113
 	/**
111
-	 * @param $key
114
+	 * @param string $key
112 115
 	 * @return Result|boolean
113 116
 	 */
114 117
 	private function headObject($key) {
@@ -234,6 +237,9 @@  discard block
 block discarded – undo
234 237
 		}
235 238
 	}
236 239
 
240
+	/**
241
+	 * @param string $path
242
+	 */
237 243
 	private function batchDelete($path = null) {
238 244
 		$params = array(
239 245
 			'Bucket' => $this->bucket
@@ -579,6 +585,9 @@  discard block
 block discarded – undo
579 585
 		return $this->id;
580 586
 	}
581 587
 
588
+	/**
589
+	 * @param string $path
590
+	 */
582 591
 	public function writeBack($tmpFile, $path) {
583 592
 		try {
584 593
 			$source = fopen($tmpFile, 'r');
Please login to merge, or discard this patch.
lib/private/Comments/Manager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -213,7 +213,7 @@
 block discarded – undo
213 213
 	/**
214 214
 	 * removes an entry from the comments run time cache
215 215
 	 *
216
-	 * @param mixed $id the comment's id
216
+	 * @param string $id the comment's id
217 217
 	 */
218 218
 	protected function uncache($id) {
219 219
 		$id = (string)$id;
Please login to merge, or discard this patch.
lib/private/Share20/Manager.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -575,7 +575,7 @@  discard block
 block discarded – undo
575 575
 	 * Share a path
576 576
 	 *
577 577
 	 * @param \OCP\Share\IShare $share
578
-	 * @return Share The share object
578
+	 * @return Share\IShare The share object
579 579
 	 * @throws \Exception
580 580
 	 *
581 581
 	 * TODO: handle link share permissions or check them
@@ -1161,7 +1161,7 @@  discard block
 block discarded – undo
1161 1161
 	 * Get the share by token possible with password
1162 1162
 	 *
1163 1163
 	 * @param string $token
1164
-	 * @return Share
1164
+	 * @return Share\IShare
1165 1165
 	 *
1166 1166
 	 * @throws ShareNotFound
1167 1167
 	 */
@@ -1223,6 +1223,9 @@  discard block
 block discarded – undo
1223 1223
 		return $share;
1224 1224
 	}
1225 1225
 
1226
+	/**
1227
+	 * @param Share\IShare $share
1228
+	 */
1226 1229
 	protected function checkExpireDate($share) {
1227 1230
 		if ($share->getExpirationDate() !== null &&
1228 1231
 			$share->getExpirationDate() <= new \DateTime()) {
Please login to merge, or discard this patch.
apps/user_ldap/lib/Helper.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -126,6 +126,9 @@
 block discarded – undo
126 126
 		return 's' . str_pad($lastNumber + 1, 2, '0', STR_PAD_LEFT);
127 127
 	}
128 128
 
129
+	/**
130
+	 * @param string $value
131
+	 */
129 132
 	private function getServersConfig($value) {
130 133
 		$regex = '/' . $value . '$/S';
131 134
 
Please login to merge, or discard this patch.
lib/private/legacy/app.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -1047,6 +1047,11 @@
 block discarded – undo
1047 1047
 		}
1048 1048
 	}
1049 1049
 
1050
+	/**
1051
+	 * @param string $lang
1052
+	 *
1053
+	 * @return string
1054
+	 */
1050 1055
 	protected static function findBestL10NOption($options, $lang) {
1051 1056
 		$fallback = $similarLangFallback = $englishFallback = false;
1052 1057
 
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Storage/Swift.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 
84 84
 	/**
85 85
 	 * @param string $path
86
-	 * @return mixed|string
86
+	 * @return string
87 87
 	 */
88 88
 	private function normalizePath(string $path) {
89 89
 		$path = trim($path, '/');
@@ -570,6 +570,9 @@  discard block
 block discarded – undo
570 570
 		return $this->container;
571 571
 	}
572 572
 
573
+	/**
574
+	 * @param string $path
575
+	 */
573 576
 	public function writeBack($tmpFile, $path) {
574 577
 		$fileData = fopen($tmpFile, 'r');
575 578
 		$this->objectStore->writeObject($path, $fileData);
Please login to merge, or discard this patch.