Completed
Pull Request — master (#1229)
by Raghu
10:39
created
lib/private/AppFramework/Http/Output.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
 	private $webRoot;
35 35
 
36 36
 	/**
37
-	 * @param $webRoot
37
+	 * @param string $webRoot
38 38
 	 */
39 39
 	public function __construct($webRoot) {
40 40
 		$this->webRoot = $webRoot;
Please login to merge, or discard this patch.
apps/files_external/lib/Service/DBConfigService.php 1 patch
Doc Comments   +16 added lines patch added patch discarded remove patch
@@ -89,6 +89,9 @@  discard block
 block discarded – undo
89 89
 		return $this->getMountsFromQuery($query);
90 90
 	}
91 91
 
92
+	/**
93
+	 * @param string $userId
94
+	 */
92 95
 	public function getMountsForUser($userId, $groupIds) {
93 96
 		$builder = $this->connection->getQueryBuilder();
94 97
 		$query = $builder->select(['m.mount_id', 'mount_point', 'storage_backend', 'auth_backend', 'priority', 'm.type'])
@@ -125,6 +128,10 @@  discard block
 block discarded – undo
125 128
 		return $this->getMountsFromQuery($query);
126 129
 	}
127 130
 
131
+	/**
132
+	 * @param integer $type
133
+	 * @param string|null $value
134
+	 */
128 135
 	protected function getForQuery(IQueryBuilder $builder, $type, $value) {
129 136
 		$query = $builder->select(['m.mount_id', 'mount_point', 'storage_backend', 'auth_backend', 'priority', 'm.type'])
130 137
 			->from('external_mounts', 'm')
@@ -332,6 +339,9 @@  discard block
 block discarded – undo
332 339
 		}
333 340
 	}
334 341
 
342
+	/**
343
+	 * @param integer $mountId
344
+	 */
335 345
 	public function addApplicable($mountId, $type, $value) {
336 346
 		$this->connection->insertIfNotExist('*PREFIX*external_applicable', [
337 347
 			'mount_id' => $mountId,
@@ -340,6 +350,9 @@  discard block
 block discarded – undo
340 350
 		], ['mount_id', 'type', 'value']);
341 351
 	}
342 352
 
353
+	/**
354
+	 * @param integer $mountId
355
+	 */
343 356
 	public function removeApplicable($mountId, $type, $value) {
344 357
 		$builder = $this->connection->getQueryBuilder();
345 358
 		$query = $builder->delete('external_applicable')
@@ -473,6 +486,9 @@  discard block
 block discarded – undo
473 486
 		return array_combine($keys, $values);
474 487
 	}
475 488
 
489
+	/**
490
+	 * @param string $value
491
+	 */
476 492
 	private function encryptValue($value) {
477 493
 		return $this->crypto->encrypt($value);
478 494
 	}
Please login to merge, or discard this patch.
lib/private/AppFramework/OCS/BaseResponse.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 	/**
25 25
 	 * BaseResponse constructor.
26 26
 	 *
27
-	 * @param DataResponse|null $dataResponse
27
+	 * @param DataResponse $dataResponse
28 28
 	 * @param string $format
29 29
 	 * @param string|null $statusMessage
30 30
 	 * @param int|null $itemsCount
Please login to merge, or discard this patch.
lib/private/Settings/Manager.php 1 patch
Doc Comments   +14 added lines, -3 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 	/**
130 130
 	 * returns the registerd classes in the given table
131 131
 	 *
132
-	 * @param $table
132
+	 * @param string $table
133 133
 	 * @return string[]
134 134
 	 */
135 135
 	private function getClasses($table) {
@@ -225,6 +225,11 @@  discard block
 block discarded – undo
225 225
 		);
226 226
 	}
227 227
 
228
+	/**
229
+	 * @param string $table
230
+	 * @param string $idCol
231
+	 * @param string $id
232
+	 */
228 233
 	private function update($table, $idCol, $id, $values) {
229 234
 		$query = $this->dbc->getQueryBuilder();
230 235
 		$query->update($table);
@@ -275,8 +280,8 @@  discard block
 block discarded – undo
275 280
 	/**
276 281
 	 * deletes an settings or admin entry from the given table
277 282
 	 *
278
-	 * @param $table
279
-	 * @param $className
283
+	 * @param string $table
284
+	 * @param string $className
280 285
 	 */
281 286
 	private function remove($table, $className) {
282 287
 		$query = $this->dbc->getQueryBuilder();
@@ -362,6 +367,9 @@  discard block
 block discarded – undo
362 367
 		return $sections;
363 368
 	}
364 369
 
370
+	/**
371
+	 * @param string $section
372
+	 */
365 373
 	private function getBuiltInAdminSettings($section) {
366 374
 		$forms = [];
367 375
 		try {
@@ -401,6 +409,9 @@  discard block
 block discarded – undo
401 409
 		return $forms;
402 410
 	}
403 411
 
412
+	/**
413
+	 * @param string $section
414
+	 */
404 415
 	private function getAdminSettingsFromDB($section, &$settings) {
405 416
 		$query = $this->dbc->getQueryBuilder();
406 417
 		$query->select(['class', 'priority'])
Please login to merge, or discard this patch.