Completed
Pull Request — master (#3233)
by Christoph
57:05 queued 37:22
created
lib/private/Activity/Event.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -162,7 +162,7 @@
 block discarded – undo
162 162
 	 */
163 163
 	public function setAuthor($author) {
164 164
 		if (!is_string($author) || isset($author[64])) {
165
-			throw new \InvalidArgumentException('The given author user is invalid'. serialize($author));
165
+			throw new \InvalidArgumentException('The given author user is invalid'.serialize($author));
166 166
 		}
167 167
 		$this->author = (string) $author;
168 168
 		return $this;
Please login to merge, or discard this patch.
lib/private/Activity/Manager.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 		}
113 113
 
114 114
 		$this->consumers = [];
115
-		foreach($this->consumersClosures as $consumer) {
115
+		foreach ($this->consumersClosures as $consumer) {
116 116
 			$c = $consumer();
117 117
 			if ($c instanceof IConsumer) {
118 118
 				$this->consumers[] = $c;
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 		}
134 134
 
135 135
 		$this->extensions = [];
136
-		foreach($this->extensionsClosures as $extension) {
136
+		foreach ($this->extensionsClosures as $extension) {
137 137
 			$e = $extension();
138 138
 			if ($e instanceof IExtension) {
139 139
 				$this->extensions[] = $e;
@@ -669,7 +669,7 @@  discard block
 block discarded – undo
669 669
 			return array(null, null);
670 670
 		}
671 671
 
672
-		return array(' and ((' . implode(') or (', $conditions) . '))', $parameters);
672
+		return array(' and (('.implode(') or (', $conditions).'))', $parameters);
673 673
 	}
674 674
 
675 675
 	/**
Please login to merge, or discard this patch.
lib/private/Security/CSP/ContentSecurityPolicyNonceManager.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 	 * @return string
53 53
 	 */
54 54
 	public function getNonce() {
55
-		if($this->nonce === '') {
55
+		if ($this->nonce === '') {
56 56
 			$this->nonce = base64_encode($this->csrfTokenManager->getToken()->getEncryptedValue());
57 57
 		}
58 58
 
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 			'/^Mozilla\/5\.0 \([^)]+\) Gecko\/[0-9.]+ Firefox\/(4[5-9]|[5-9][0-9])\.[0-9.]+$/',
72 72
 		];
73 73
 
74
-		if($this->request->isUserAgent($browserWhitelist)) {
74
+		if ($this->request->isUserAgent($browserWhitelist)) {
75 75
 			return true;
76 76
 		}
77 77
 
Please login to merge, or discard this patch.
lib/private/Security/CSP/ContentSecurityPolicyManager.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 	 */
44 44
 	public function getDefaultPolicy() {
45 45
 		$defaultPolicy = new \OC\Security\CSP\ContentSecurityPolicy();
46
-		foreach($this->policies as $policy) {
46
+		foreach ($this->policies as $policy) {
47 47
 			$defaultPolicy = $this->mergePolicies($defaultPolicy, $policy);
48 48
 		}
49 49
 		return $defaultPolicy;
@@ -58,9 +58,9 @@  discard block
 block discarded – undo
58 58
 	 */
59 59
 	public function mergePolicies(ContentSecurityPolicy $defaultPolicy,
60 60
 								  EmptyContentSecurityPolicy $originalPolicy) {
61
-		foreach((object)(array)$originalPolicy as $name => $value) {
61
+		foreach ((object) (array) $originalPolicy as $name => $value) {
62 62
 			$setter = 'set'.ucfirst($name);
63
-			if(is_array($value)) {
63
+			if (is_array($value)) {
64 64
 				$getter = 'get'.ucfirst($name);
65 65
 				$currentValues = is_array($defaultPolicy->$getter()) ? $defaultPolicy->$getter() : [];
66 66
 				$defaultPolicy->$setter(array_values(array_unique(array_merge($currentValues, $value))));
Please login to merge, or discard this patch.
lib/private/Security/TrustedDomainHelper.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 			return true;
82 82
 		}
83 83
 		// Reject misformed domains in any case
84
-		if (strpos($domain,'-') === 0 || strpos($domain,'..') !== false) {
84
+		if (strpos($domain, '-') === 0 || strpos($domain, '..') !== false) {
85 85
 			return false;
86 86
 		}
87 87
 		// Match, allowing for * wildcards
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 			if (gettype($trusted) !== 'string') {
90 90
 				break;
91 91
 			}
92
-			$regex = '/^' . join('[-\.a-zA-Z0-9]*', array_map(function($v) { return preg_quote($v, '/'); }, explode('*', $trusted))) . '$/';
92
+			$regex = '/^'.join('[-\.a-zA-Z0-9]*', array_map(function($v) { return preg_quote($v, '/'); }, explode('*', $trusted))).'$/';
93 93
 			if (preg_match($regex, $domain) || preg_match($regex, $domainWithPort)) {
94 94
  				return true;
95 95
  			}
Please login to merge, or discard this patch.
lib/private/Security/Hasher.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 		$this->config = $config;
63 63
 
64 64
 		$hashingCost = $this->config->getSystemValue('hashingCost', null);
65
-		if(!is_null($hashingCost)) {
65
+		if (!is_null($hashingCost)) {
66 66
 			$this->options['cost'] = $hashingCost;
67 67
 		}
68 68
 	}
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 	 * @return string Hash of the message with appended version parameter
77 77
 	 */
78 78
 	public function hash($message) {
79
-		return $this->currentVersion . '|' . password_hash($message, PASSWORD_DEFAULT, $this->options);
79
+		return $this->currentVersion.'|'.password_hash($message, PASSWORD_DEFAULT, $this->options);
80 80
 	}
81 81
 
82 82
 	/**
@@ -86,9 +86,9 @@  discard block
 block discarded – undo
86 86
 	 */
87 87
 	protected function splitHash($prefixedHash) {
88 88
 		$explodedString = explode('|', $prefixedHash, 2);
89
-		if(sizeof($explodedString) === 2) {
90
-			if((int)$explodedString[0] > 0) {
91
-				return array('version' => (int)$explodedString[0], 'hash' => $explodedString[1]);
89
+		if (sizeof($explodedString) === 2) {
90
+			if ((int) $explodedString[0] > 0) {
91
+				return array('version' => (int) $explodedString[0], 'hash' => $explodedString[1]);
92 92
 			}
93 93
 		}
94 94
 
@@ -103,13 +103,13 @@  discard block
 block discarded – undo
103 103
 	 * @return bool Whether $hash is a valid hash of $message
104 104
 	 */
105 105
 	protected function legacyHashVerify($message, $hash, &$newHash = null) {
106
-		if(empty($this->legacySalt)) {
106
+		if (empty($this->legacySalt)) {
107 107
 			$this->legacySalt = $this->config->getSystemValue('passwordsalt', '');
108 108
 		}
109 109
 
110 110
 		// Verify whether it matches a legacy PHPass or SHA1 string
111 111
 		$hashLength = strlen($hash);
112
-		if($hashLength === 60 && password_verify($message.$this->legacySalt, $hash) ||
112
+		if ($hashLength === 60 && password_verify($message.$this->legacySalt, $hash) ||
113 113
 			$hashLength === 40 && hash_equals($hash, sha1($message))) {
114 114
 			$newHash = $this->hash($message);
115 115
 			return true;
@@ -126,8 +126,8 @@  discard block
 block discarded – undo
126 126
 	 * @return bool Whether $hash is a valid hash of $message
127 127
 	 */
128 128
 	protected function verifyHashV1($message, $hash, &$newHash = null) {
129
-		if(password_verify($message, $hash)) {
130
-			if(password_needs_rehash($hash, PASSWORD_DEFAULT, $this->options)) {
129
+		if (password_verify($message, $hash)) {
130
+			if (password_needs_rehash($hash, PASSWORD_DEFAULT, $this->options)) {
131 131
 				$newHash = $this->hash($message);
132 132
 			}
133 133
 			return true;
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 	public function verify($message, $hash, &$newHash = null) {
146 146
 		$splittedHash = $this->splitHash($hash);
147 147
 
148
-		if(isset($splittedHash['version'])) {
148
+		if (isset($splittedHash['version'])) {
149 149
 			switch ($splittedHash['version']) {
150 150
 				case 1:
151 151
 					return $this->verifyHashV1($message, $splittedHash['hash'], $newHash);
Please login to merge, or discard this patch.
lib/private/Security/CSRF/CsrfToken.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -50,9 +50,9 @@
 block discarded – undo
50 50
 	 * @return string
51 51
 	 */
52 52
 	public function getEncryptedValue() {
53
-		if($this->encryptedValue === '') {
53
+		if ($this->encryptedValue === '') {
54 54
 			$sharedSecret = random_bytes(strlen($this->value));
55
-			$this->encryptedValue = base64_encode($this->value ^ $sharedSecret) . ':' . base64_encode($sharedSecret);
55
+			$this->encryptedValue = base64_encode($this->value ^ $sharedSecret).':'.base64_encode($sharedSecret);
56 56
 		}
57 57
 
58 58
 		return $this->encryptedValue;
Please login to merge, or discard this patch.
lib/private/Security/CSRF/TokenStorage/SessionStorage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
 	 */
56 56
 	public function getToken() {
57 57
 		$token = $this->session->get('requesttoken');
58
-		if(empty($token)) {
58
+		if (empty($token)) {
59 59
 			throw new \Exception('Session does not contain a requesttoken');
60 60
 		}
61 61
 
Please login to merge, or discard this patch.
lib/private/Security/CSRF/CsrfTokenManager.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -53,11 +53,11 @@  discard block
 block discarded – undo
53 53
 	 * @return CsrfToken
54 54
 	 */
55 55
 	public function getToken() {
56
-		if(!is_null($this->csrfToken)) {
56
+		if (!is_null($this->csrfToken)) {
57 57
 			return $this->csrfToken;
58 58
 		}
59 59
 
60
-		if($this->sessionStorage->hasToken()) {
60
+		if ($this->sessionStorage->hasToken()) {
61 61
 			$value = $this->sessionStorage->getToken();
62 62
 		} else {
63 63
 			$value = $this->tokenGenerator->generateToken();
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 	 * @return bool
96 96
 	 */
97 97
 	public function isTokenValid(CsrfToken $token) {
98
-		if(!$this->sessionStorage->hasToken()) {
98
+		if (!$this->sessionStorage->hasToken()) {
99 99
 			return false;
100 100
 		}
101 101
 
Please login to merge, or discard this patch.