Completed
Pull Request — master (#4136)
by Jan-Christoph
11:29
created
apps/sharebymail/lib/ShareByMailProvider.php 1 patch
Doc Comments   +13 added lines, -4 removed lines patch added patch discarded remove patch
@@ -193,10 +193,10 @@  discard block
 block discarded – undo
193 193
 	 * publish activity if a file/folder was shared by mail
194 194
 	 *
195 195
 	 * @param $subject
196
-	 * @param $parameters
197
-	 * @param $affectedUser
196
+	 * @param string[] $parameters
197
+	 * @param string $affectedUser
198 198
 	 * @param $fileId
199
-	 * @param $filePath
199
+	 * @param string $filePath
200 200
 	 */
201 201
 	protected function publishActivity($subject, $parameters, $affectedUser, $fileId, $filePath) {
202 202
 		$event = $this->activityManager->generateEvent();
@@ -248,6 +248,12 @@  discard block
 block discarded – undo
248 248
 
249 249
 	}
250 250
 
251
+	/**
252
+	 * @param string $link
253
+	 * @param string $owner
254
+	 * @param string $initiator
255
+	 * @param string $shareWith
256
+	 */
251 257
 	protected function sendMailNotification($filename, $link, $owner, $initiator, $shareWith) {
252 258
 		$ownerUser = $this->userManager->get($owner);
253 259
 		$initiatorUser = $this->userManager->get($initiator);
@@ -277,6 +283,7 @@  discard block
 block discarded – undo
277 283
 	 * @param $link
278 284
 	 * @param $owner
279 285
 	 * @param $initiator
286
+	 * @param string $template
280 287
 	 * @return string plain text mail
281 288
 	 * @throws HintException
282 289
 	 */
@@ -304,6 +311,7 @@  discard block
 block discarded – undo
304 311
 	 * @param string $filename
305 312
 	 * @param string $initiator
306 313
 	 * @param string $shareWith
314
+	 * @param string $password
307 315
 	 */
308 316
 	protected function sendPassword($filename, $initiator, $shareWith, $password) {
309 317
 
@@ -332,6 +340,7 @@  discard block
 block discarded – undo
332 340
 	 * @param string $filename
333 341
 	 * @param string $initiator
334 342
 	 * @param string $password
343
+	 * @param string $template
335 344
 	 * @return string plain text mail
336 345
 	 * @throws HintException
337 346
 	 */
@@ -790,7 +799,7 @@  discard block
 block discarded – undo
790 799
 	/**
791 800
 	 * get database row of a give share
792 801
 	 *
793
-	 * @param $id
802
+	 * @param integer $id
794 803
 	 * @return array
795 804
 	 * @throws ShareNotFound
796 805
 	 */
Please login to merge, or discard this patch.
lib/private/Share20/Manager.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -1100,6 +1100,9 @@
 block discarded – undo
1100 1100
 		return $share;
1101 1101
 	}
1102 1102
 
1103
+	/**
1104
+	 * @param \OCP\Share\IShare $share
1105
+	 */
1103 1106
 	protected function checkExpireDate($share) {
1104 1107
 		if ($share->getExpirationDate() !== null &&
1105 1108
 			$share->getExpirationDate() <= new \DateTime()) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,6 @@
 block discarded – undo
36 36
 use OCP\Files\IRootFolder;
37 37
 use OCP\Files\Mount\IMountManager;
38 38
 use OCP\Files\Node;
39
-use OCP\Files\NotFoundException;
40 39
 use OCP\IConfig;
41 40
 use OCP\IGroupManager;
42 41
 use OCP\IL10N;
Please login to merge, or discard this patch.