Inspection of "Merge pull request #53029 from nextcloud/fix/calda..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 64ba0f...5b554f )

by Daniel

created 2025-05-21 14:16 UTC

Status

Spacing +38 added lines, -38 removed lines patch added patch discarded remove patch

@@ -151,10 +151,10 @@  discard block
 block discarded – undo
 			'DTSTART' => new \DateTime('2016-01-01 00:00:00')
 		], []));
 		$message->message->VEVENT->add('ORGANIZER', 'mailto:[email protected]');
-		$message->message->VEVENT->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE']);
+		$message->message->VEVENT->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE']);
 		$message->sender = 'mailto:[email protected]';
 		$message->senderName = 'Mr. Wizard';
-		$message->recipient = 'mailto:' . '[email protected]';
+		$message->recipient = 'mailto:'.'[email protected]';
 		$message->significantChange = false;
 		$this->plugin->schedule($message);
 		$this->assertEquals('1.0', $message->getScheduleStatus());
@@ -171,11 +171,11 @@  discard block
 block discarded – undo
 			'DTSTART' => new \DateTime('2016-01-01 00:00:00')
 		], []));
 		$newVevent->add('ORGANIZER', 'mailto:[email protected]');
-		$newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE',  'CN' => 'Frodo']);
+		$newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
 		$message->message = $newVCalendar;
 		$message->sender = 'mailto:[email protected]';
 		$message->senderName = 'Mr. Wizard';
-		$message->recipient = 'mailto:' . '[email protected]';
+		$message->recipient = 'mailto:'.'[email protected]';
 		// save the old copy in the plugin
 		$oldVCalendar = new VCalendar();
 		$oldVEvent = new VEvent($oldVCalendar, 'one', [
@@ -185,8 +185,8 @@  discard block
 block discarded – undo
 			'DTSTART' => new \DateTime('2016-01-01 00:00:00')
 		]);
 		$oldVEvent->add('ORGANIZER', 'mailto:[email protected]');
-		$oldVEvent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
-		$oldVEvent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE']);
+		$oldVEvent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
+		$oldVEvent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE']);
 		$oldVCalendar->add($oldVEvent);
 		$data = ['invitee_name' => 'Mr. Wizard',
 			'meeting_title' => 'Fellowship meeting without (!) Boromir',
@@ -278,11 +278,11 @@  discard block
 block discarded – undo
 			'DTSTART' => new \DateTime('2016-01-01 00:00:00')
 		], []));
 		$newVevent->add('ORGANIZER', 'mailto:[email protected]');
-		$newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE',  'CN' => 'The Shire', 'CUTYPE' => 'ROOM']);
+		$newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'The Shire', 'CUTYPE' => 'ROOM']);
 		$message->message = $newVCalendar;
 		$message->sender = 'mailto:[email protected]';
 		$message->senderName = 'Mr. Wizard';
-		$message->recipient = 'mailto:' . '[email protected]';
+		$message->recipient = 'mailto:'.'[email protected]';
 		// save the old copy in the plugin
 		$oldVCalendar = new VCalendar();
 		$oldVEvent = new VEvent($oldVCalendar, 'one', [
@@ -292,8 +292,8 @@  discard block
 block discarded – undo
 			'DTSTART' => new \DateTime('2016-01-01 00:00:00')
 		]);
 		$oldVEvent->add('ORGANIZER', 'mailto:[email protected]');
-		$oldVEvent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'The Shire', 'CUTYPE' => 'ROOM']);
-		$oldVEvent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE']);
+		$oldVEvent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'The Shire', 'CUTYPE' => 'ROOM']);
+		$oldVEvent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE']);
 		$oldVCalendar->add($oldVEvent);
 		$data = ['invitee_name' => 'Mr. Wizard',
 			'meeting_title' => 'Fellowship meeting without (!) Boromir',
@@ -371,12 +371,12 @@  discard block
 block discarded – undo
 			'DTSTART' => new \DateTime('2016-01-01 00:00:00')
 		], []));
 		$newVevent->add('ORGANIZER', 'mailto:[email protected]');
-		$newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'The Fellowship', 'CUTYPE' => 'GROUP']);
-		$newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'MEMBER' => '[email protected]']);
+		$newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'The Fellowship', 'CUTYPE' => 'GROUP']);
+		$newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'MEMBER' => '[email protected]']);
 		$message->message = $newVCalendar;
 		$message->sender = 'mailto:[email protected]';
 		$message->senderName = 'Mr. Wizard';
-		$message->recipient = 'mailto:' . '[email protected]';
+		$message->recipient = 'mailto:'.'[email protected]';
 		$attendees = $newVevent->select('ATTENDEE');
 		$circle = '';
 		foreach ($attendees as $attendee) {
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
 			'RRULE' => 'FREQ=DAILY;INTERVAL=1;UNTIL=20160201T000000Z'
 		]);
 		$newVevent->add('ORGANIZER', 'mailto:[email protected]');
-		$newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE',  'CN' => 'Frodo']);
+		$newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
 		$newvEvent2 = new VEvent($newVCalendar, 'two', [
 			'UID' => 'uid-1234',
 			'SEQUENCE' => 1,
@@ -462,10 +462,10 @@  discard block
 block discarded – undo
 			'RECURRENCE-ID' => new \DateTime('2016-01-01 00:00:00')
 		]);
 		$newvEvent2->add('ORGANIZER', 'mailto:[email protected]');
-		$newvEvent2->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
+		$newvEvent2->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
 		$message->message = $newVCalendar;
 		$message->sender = 'mailto:[email protected]';
-		$message->recipient = 'mailto:' . '[email protected]';
+		$message->recipient = 'mailto:'.'[email protected]';
 		// save the old copy in the plugin
 		$oldVCalendar = new VCalendar();
 		$oldVEvent = new VEvent($oldVCalendar, 'one', [
@@ -477,7 +477,7 @@  discard block
 block discarded – undo
 			'RRULE' => 'FREQ=DAILY;INTERVAL=1;UNTIL=20160201T000000Z'
 		]);
 		$oldVEvent->add('ORGANIZER', 'mailto:[email protected]');
-		$oldVEvent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
+		$oldVEvent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
 		$data = ['invitee_name' => 'Mr. Wizard',
 			'meeting_title' => 'Elevenses',
 			'attendee_name' => '[email protected]'
@@ -499,7 +499,7 @@  discard block
 block discarded – undo
 			->willReturn(true);
 		$this->eventComparisonService->expects(self::once())
 			->method('findModified')
-			->willReturn(['old' => [] ,'new' => [$newVevent]]);
+			->willReturn(['old' => [], 'new' => [$newVevent]]);
 		$this->service->expects(self::once())
 			->method('getCurrentAttendee')
 			->with($message)
@@ -568,10 +568,10 @@  discard block
 block discarded – undo
 			'DTSTART' => new \DateTime('2016-01-01 00:00:00')
 		], []));
 		$message->message->VEVENT->add('ORGANIZER', 'mailto:[email protected]');
-		$message->message->VEVENT->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE']);
+		$message->message->VEVENT->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE']);
 		$message->sender = 'mailto:[email protected]';
 		$message->senderName = 'Mr. Wizard';
-		$message->recipient = 'mailto:' . '[email protected]';
+		$message->recipient = 'mailto:'.'[email protected]';
 
 		$this->service->expects(self::once())
 			->method('getLastOccurrence')
@@ -596,11 +596,11 @@  discard block
 block discarded – undo
 			'DTSTART' => new \DateTime('2016-01-01 00:00:00')
 		], []));
 		$newVevent->add('ORGANIZER', 'mailto:[email protected]');
-		$newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE',  'CN' => 'Frodo']);
+		$newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
 		$message->message = $newVcalendar;
 		$message->sender = 'mailto:[email protected]';
 		$message->senderName = 'Mr. Wizard';
-		$message->recipient = 'mailto:' . '[email protected]';
+		$message->recipient = 'mailto:'.'[email protected]';
 		// save the old copy in the plugin
 		$oldVcalendar = new VCalendar();
 		$oldVevent = new VEvent($oldVcalendar, 'one', [
@@ -610,8 +610,8 @@  discard block
 block discarded – undo
 			'DTSTART' => new \DateTime('2016-01-01 00:00:00')
 		]);
 		$oldVevent->add('ORGANIZER', 'mailto:[email protected]');
-		$oldVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
-		$oldVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE']);
+		$oldVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
+		$oldVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE']);
 		$oldVcalendar->add($oldVevent);
 		$data = ['invitee_name' => 'Mr. Wizard',
 			'meeting_title' => 'Fellowship meeting without (!) Boromir',
@@ -634,7 +634,7 @@  discard block
 block discarded – undo
 			->willReturn(true);
 		$this->eventComparisonService->expects(self::once())
 			->method('findModified')
-			->willReturn(['old' => [] ,'new' => [$newVevent]]);
+			->willReturn(['old' => [], 'new' => [$newVevent]]);
 		$this->service->expects(self::once())
 			->method('getCurrentAttendee')
 			->with($message)
@@ -709,11 +709,11 @@  discard block
 block discarded – undo
 			'DTSTART' => new \DateTime('2016-01-01 00:00:00')
 		], []));
 		$event->add('ORGANIZER', 'mailto:[email protected]');
-		$event->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE',  'CN' => 'Frodo']);
+		$event->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
 		$message->message = $calendar;
 		$message->sender = 'mailto:[email protected]';
 		$message->senderName = 'Mr. Wizard';
-		$message->recipient = 'mailto:' . '[email protected]';
+		$message->recipient = 'mailto:'.'[email protected]';
 		// construct
 		foreach ($event->select('ATTENDEE') as $entry) {
 			if (strcasecmp($entry->getValue(), $message->recipient) === 0) {
@@ -784,7 +784,7 @@  discard block
 block discarded – undo
 			->with($this->emailTemplate, 'token');
 		$this->eventComparisonService->expects(self::once())
 			->method('findModified')
-			->willReturn(['old' => [] ,'new' => [$event]]);
+			->willReturn(['old' => [], 'new' => [$event]]);
 		// construct mail mock returns
 		$this->mailer->expects(self::once())
 			->method('validateMailAddress')
@@ -817,11 +817,11 @@  discard block
 block discarded – undo
 			'DTSTART' => new \DateTime('2016-01-01 00:00:00')
 		], []));
 		$newVevent->add('ORGANIZER', 'mailto:[email protected]');
-		$newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE',  'CN' => 'Frodo']);
+		$newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
 		$message->message = $newVCalendar;
 		$message->sender = 'mailto:[email protected]';
 		$message->senderName = 'Mr. Wizard';
-		$message->recipient = 'mailto:' . '[email protected]';
+		$message->recipient = 'mailto:'.'[email protected]';
 		// save the old copy in the plugin
 		$oldVCalendar = new VCalendar();
 		$oldVEvent = new VEvent($oldVCalendar, 'one', [
@@ -831,8 +831,8 @@  discard block
 block discarded – undo
 			'DTSTART' => new \DateTime('2016-01-01 00:00:00')
 		]);
 		$oldVEvent->add('ORGANIZER', 'mailto:[email protected]');
-		$oldVEvent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
-		$oldVEvent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE']);
+		$oldVEvent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
+		$oldVEvent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE']);
 		$oldVCalendar->add($oldVEvent);
 		$data = ['invitee_name' => 'Mr. Wizard',
 			'meeting_title' => 'Fellowship meeting without (!) Boromir',
@@ -928,11 +928,11 @@  discard block
 block discarded – undo
 			'DTSTART' => new \DateTime('2016-01-01 00:00:00')
 		], []));
 		$newVevent->add('ORGANIZER', 'mailto:[email protected]');
-		$newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
+		$newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
 		$message->message = $newVCalendar;
 		$message->sender = 'mailto:[email protected]';
 		$message->senderName = 'Mr. Wizard';
-		$message->recipient = 'mailto:' . '[email protected]';
+		$message->recipient = 'mailto:'.'[email protected]';
 		$data = ['invitee_name' => 'Mr. Wizard',
 			'meeting_title' => 'Fellowship meeting',
 			'attendee_name' => '[email protected]'
@@ -954,7 +954,7 @@  discard block
 block discarded – undo
 		$this->eventComparisonService->expects(self::once())
 			->method('findModified')
 			->with($newVCalendar, null)
-			->willReturn(['old' => [] ,'new' => [$newVevent]]);
+			->willReturn(['old' => [], 'new' => [$newVevent]]);
 		$this->service->expects(self::once())
 			->method('getCurrentAttendee')
 			->with($message)
@@ -1026,10 +1026,10 @@  discard block
 block discarded – undo
 			'DTSTART' => new \DateTime('2016-01-01 00:00:00')
 		], []));
 		$newVevent->add('ORGANIZER', 'mailto:[email protected]');
-		$newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
+		$newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
 		$message->message = $newVCalendar;
 		$message->sender = 'mailto:[email protected]';
-		$message->recipient = 'mailto:' . '[email protected]';
+		$message->recipient = 'mailto:'.'[email protected]';
 		$data = ['invitee_name' => 'Mr. Wizard',
 			'meeting_title' => 'Fellowship meeting',
 			'attendee_name' => '[email protected]'
@@ -1051,7 +1051,7 @@  discard block
 block discarded – undo
 		$this->eventComparisonService->expects(self::once())
 			->method('findModified')
 			->with($newVCalendar, null)
-			->willReturn(['old' => [] ,'new' => [$newVevent]]);
+			->willReturn(['old' => [], 'new' => [$newVevent]]);
 		$this->service->expects(self::once())
 			->method('getCurrentAttendee')
 			->with($message)

Please login to merge, or discard this patch.

		@@ -151,10 +151,10 @@ discard block
		block discarded – undo
151	151	'DTSTART' => new \DateTime('2016-01-01 00:00:00')
152	152	], []));
153	153	$message->message->VEVENT->add('ORGANIZER', 'mailto:[email protected]');
154		- $message->message->VEVENT->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE']);
	154	+ $message->message->VEVENT->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE']);
155	155	$message->sender = 'mailto:[email protected]';
156	156	$message->senderName = 'Mr. Wizard';
157		- $message->recipient = 'mailto:' . '[email protected]';
	157	+ $message->recipient = 'mailto:'.'[email protected]';
158	158	$message->significantChange = false;
159	159	$this->plugin->schedule($message);
160	160	$this->assertEquals('1.0', $message->getScheduleStatus());
		@@ -171,11 +171,11 @@ discard block
		block discarded – undo
171	171	'DTSTART' => new \DateTime('2016-01-01 00:00:00')
172	172	], []));
173	173	$newVevent->add('ORGANIZER', 'mailto:[email protected]');
174		- $newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
	174	+ $newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
175	175	$message->message = $newVCalendar;
176	176	$message->sender = 'mailto:[email protected]';
177	177	$message->senderName = 'Mr. Wizard';
178		- $message->recipient = 'mailto:' . '[email protected]';
	178	+ $message->recipient = 'mailto:'.'[email protected]';
179	179	// save the old copy in the plugin
180	180	$oldVCalendar = new VCalendar();
181	181	$oldVEvent = new VEvent($oldVCalendar, 'one', [
		@@ -185,8 +185,8 @@ discard block
		block discarded – undo
185	185	'DTSTART' => new \DateTime('2016-01-01 00:00:00')
186	186	]);
187	187	$oldVEvent->add('ORGANIZER', 'mailto:[email protected]');
188		- $oldVEvent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
189		- $oldVEvent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE']);
	188	+ $oldVEvent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
	189	+ $oldVEvent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE']);
190	190	$oldVCalendar->add($oldVEvent);
191	191	$data = ['invitee_name' => 'Mr. Wizard',
192	192	'meeting_title' => 'Fellowship meeting without (!) Boromir',
		@@ -278,11 +278,11 @@ discard block
		block discarded – undo
278	278	'DTSTART' => new \DateTime('2016-01-01 00:00:00')
279	279	], []));
280	280	$newVevent->add('ORGANIZER', 'mailto:[email protected]');
281		- $newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'The Shire', 'CUTYPE' => 'ROOM']);
	281	+ $newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'The Shire', 'CUTYPE' => 'ROOM']);
282	282	$message->message = $newVCalendar;
283	283	$message->sender = 'mailto:[email protected]';
284	284	$message->senderName = 'Mr. Wizard';
285		- $message->recipient = 'mailto:' . '[email protected]';
	285	+ $message->recipient = 'mailto:'.'[email protected]';
286	286	// save the old copy in the plugin
287	287	$oldVCalendar = new VCalendar();
288	288	$oldVEvent = new VEvent($oldVCalendar, 'one', [
		@@ -292,8 +292,8 @@ discard block
		block discarded – undo
292	292	'DTSTART' => new \DateTime('2016-01-01 00:00:00')
293	293	]);
294	294	$oldVEvent->add('ORGANIZER', 'mailto:[email protected]');
295		- $oldVEvent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'The Shire', 'CUTYPE' => 'ROOM']);
296		- $oldVEvent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE']);
	295	+ $oldVEvent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'The Shire', 'CUTYPE' => 'ROOM']);
	296	+ $oldVEvent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE']);
297	297	$oldVCalendar->add($oldVEvent);
298	298	$data = ['invitee_name' => 'Mr. Wizard',
299	299	'meeting_title' => 'Fellowship meeting without (!) Boromir',
		@@ -371,12 +371,12 @@ discard block
		block discarded – undo
371	371	'DTSTART' => new \DateTime('2016-01-01 00:00:00')
372	372	], []));
373	373	$newVevent->add('ORGANIZER', 'mailto:[email protected]');
374		- $newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'The Fellowship', 'CUTYPE' => 'GROUP']);
375		- $newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'MEMBER' => '[email protected]']);
	374	+ $newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'The Fellowship', 'CUTYPE' => 'GROUP']);
	375	+ $newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'MEMBER' => '[email protected]']);
376	376	$message->message = $newVCalendar;
377	377	$message->sender = 'mailto:[email protected]';
378	378	$message->senderName = 'Mr. Wizard';
379		- $message->recipient = 'mailto:' . '[email protected]';
	379	+ $message->recipient = 'mailto:'.'[email protected]';
380	380	$attendees = $newVevent->select('ATTENDEE');
381	381	$circle = '';
382	382	foreach ($attendees as $attendee) {
		@@ -453,7 +453,7 @@ discard block
		block discarded – undo
453	453	'RRULE' => 'FREQ=DAILY;INTERVAL=1;UNTIL=20160201T000000Z'
454	454	]);
455	455	$newVevent->add('ORGANIZER', 'mailto:[email protected]');
456		- $newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
	456	+ $newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
457	457	$newvEvent2 = new VEvent($newVCalendar, 'two', [
458	458	'UID' => 'uid-1234',
459	459	'SEQUENCE' => 1,
		@@ -462,10 +462,10 @@ discard block
		block discarded – undo
462	462	'RECURRENCE-ID' => new \DateTime('2016-01-01 00:00:00')
463	463	]);
464	464	$newvEvent2->add('ORGANIZER', 'mailto:[email protected]');
465		- $newvEvent2->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
	465	+ $newvEvent2->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
466	466	$message->message = $newVCalendar;
467	467	$message->sender = 'mailto:[email protected]';
468		- $message->recipient = 'mailto:' . '[email protected]';
	468	+ $message->recipient = 'mailto:'.'[email protected]';
469	469	// save the old copy in the plugin
470	470	$oldVCalendar = new VCalendar();
471	471	$oldVEvent = new VEvent($oldVCalendar, 'one', [
		@@ -477,7 +477,7 @@ discard block
		block discarded – undo
477	477	'RRULE' => 'FREQ=DAILY;INTERVAL=1;UNTIL=20160201T000000Z'
478	478	]);
479	479	$oldVEvent->add('ORGANIZER', 'mailto:[email protected]');
480		- $oldVEvent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
	480	+ $oldVEvent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
481	481	$data = ['invitee_name' => 'Mr. Wizard',
482	482	'meeting_title' => 'Elevenses',
483	483	'attendee_name' => '[email protected]'
		@@ -499,7 +499,7 @@ discard block
		block discarded – undo
499	499	->willReturn(true);
500	500	$this->eventComparisonService->expects(self::once())
501	501	->method('findModified')
502		- ->willReturn(['old' => [] ,'new' => [$newVevent]]);
	502	+ ->willReturn(['old' => [], 'new' => [$newVevent]]);
503	503	$this->service->expects(self::once())
504	504	->method('getCurrentAttendee')
505	505	->with($message)
		@@ -568,10 +568,10 @@ discard block
		block discarded – undo
568	568	'DTSTART' => new \DateTime('2016-01-01 00:00:00')
569	569	], []));
570	570	$message->message->VEVENT->add('ORGANIZER', 'mailto:[email protected]');
571		- $message->message->VEVENT->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE']);
	571	+ $message->message->VEVENT->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE']);
572	572	$message->sender = 'mailto:[email protected]';
573	573	$message->senderName = 'Mr. Wizard';
574		- $message->recipient = 'mailto:' . '[email protected]';
	574	+ $message->recipient = 'mailto:'.'[email protected]';
575	575
576	576	$this->service->expects(self::once())
577	577	->method('getLastOccurrence')
		@@ -596,11 +596,11 @@ discard block
		block discarded – undo
596	596	'DTSTART' => new \DateTime('2016-01-01 00:00:00')
597	597	], []));
598	598	$newVevent->add('ORGANIZER', 'mailto:[email protected]');
599		- $newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
	599	+ $newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
600	600	$message->message = $newVcalendar;
601	601	$message->sender = 'mailto:[email protected]';
602	602	$message->senderName = 'Mr. Wizard';
603		- $message->recipient = 'mailto:' . '[email protected]';
	603	+ $message->recipient = 'mailto:'.'[email protected]';
604	604	// save the old copy in the plugin
605	605	$oldVcalendar = new VCalendar();
606	606	$oldVevent = new VEvent($oldVcalendar, 'one', [
		@@ -610,8 +610,8 @@ discard block
		block discarded – undo
610	610	'DTSTART' => new \DateTime('2016-01-01 00:00:00')
611	611	]);
612	612	$oldVevent->add('ORGANIZER', 'mailto:[email protected]');
613		- $oldVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
614		- $oldVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE']);
	613	+ $oldVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
	614	+ $oldVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE']);
615	615	$oldVcalendar->add($oldVevent);
616	616	$data = ['invitee_name' => 'Mr. Wizard',
617	617	'meeting_title' => 'Fellowship meeting without (!) Boromir',
		@@ -634,7 +634,7 @@ discard block
		block discarded – undo
634	634	->willReturn(true);
635	635	$this->eventComparisonService->expects(self::once())
636	636	->method('findModified')
637		- ->willReturn(['old' => [] ,'new' => [$newVevent]]);
	637	+ ->willReturn(['old' => [], 'new' => [$newVevent]]);
638	638	$this->service->expects(self::once())
639	639	->method('getCurrentAttendee')
640	640	->with($message)
		@@ -709,11 +709,11 @@ discard block
		block discarded – undo
709	709	'DTSTART' => new \DateTime('2016-01-01 00:00:00')
710	710	], []));
711	711	$event->add('ORGANIZER', 'mailto:[email protected]');
712		- $event->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
	712	+ $event->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
713	713	$message->message = $calendar;
714	714	$message->sender = 'mailto:[email protected]';
715	715	$message->senderName = 'Mr. Wizard';
716		- $message->recipient = 'mailto:' . '[email protected]';
	716	+ $message->recipient = 'mailto:'.'[email protected]';
717	717	// construct
718	718	foreach ($event->select('ATTENDEE') as $entry) {
719	719	if (strcasecmp($entry->getValue(), $message->recipient) === 0) {
		@@ -784,7 +784,7 @@ discard block
		block discarded – undo
784	784	->with($this->emailTemplate, 'token');
785	785	$this->eventComparisonService->expects(self::once())
786	786	->method('findModified')
787		- ->willReturn(['old' => [] ,'new' => [$event]]);
	787	+ ->willReturn(['old' => [], 'new' => [$event]]);
788	788	// construct mail mock returns
789	789	$this->mailer->expects(self::once())
790	790	->method('validateMailAddress')
		@@ -817,11 +817,11 @@ discard block
		block discarded – undo
817	817	'DTSTART' => new \DateTime('2016-01-01 00:00:00')
818	818	], []));
819	819	$newVevent->add('ORGANIZER', 'mailto:[email protected]');
820		- $newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
	820	+ $newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
821	821	$message->message = $newVCalendar;
822	822	$message->sender = 'mailto:[email protected]';
823	823	$message->senderName = 'Mr. Wizard';
824		- $message->recipient = 'mailto:' . '[email protected]';
	824	+ $message->recipient = 'mailto:'.'[email protected]';
825	825	// save the old copy in the plugin
826	826	$oldVCalendar = new VCalendar();
827	827	$oldVEvent = new VEvent($oldVCalendar, 'one', [
		@@ -831,8 +831,8 @@ discard block
		block discarded – undo
831	831	'DTSTART' => new \DateTime('2016-01-01 00:00:00')
832	832	]);
833	833	$oldVEvent->add('ORGANIZER', 'mailto:[email protected]');
834		- $oldVEvent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
835		- $oldVEvent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE']);
	834	+ $oldVEvent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
	835	+ $oldVEvent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE']);
836	836	$oldVCalendar->add($oldVEvent);
837	837	$data = ['invitee_name' => 'Mr. Wizard',
838	838	'meeting_title' => 'Fellowship meeting without (!) Boromir',
		@@ -928,11 +928,11 @@ discard block
		block discarded – undo
928	928	'DTSTART' => new \DateTime('2016-01-01 00:00:00')
929	929	], []));
930	930	$newVevent->add('ORGANIZER', 'mailto:[email protected]');
931		- $newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
	931	+ $newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
932	932	$message->message = $newVCalendar;
933	933	$message->sender = 'mailto:[email protected]';
934	934	$message->senderName = 'Mr. Wizard';
935		- $message->recipient = 'mailto:' . '[email protected]';
	935	+ $message->recipient = 'mailto:'.'[email protected]';
936	936	$data = ['invitee_name' => 'Mr. Wizard',
937	937	'meeting_title' => 'Fellowship meeting',
938	938	'attendee_name' => '[email protected]'
		@@ -954,7 +954,7 @@ discard block
		block discarded – undo
954	954	$this->eventComparisonService->expects(self::once())
955	955	->method('findModified')
956	956	->with($newVCalendar, null)
957		- ->willReturn(['old' => [] ,'new' => [$newVevent]]);
	957	+ ->willReturn(['old' => [], 'new' => [$newVevent]]);
958	958	$this->service->expects(self::once())
959	959	->method('getCurrentAttendee')
960	960	->with($message)
		@@ -1026,10 +1026,10 @@ discard block
		block discarded – undo
1026	1026	'DTSTART' => new \DateTime('2016-01-01 00:00:00')
1027	1027	], []));
1028	1028	$newVevent->add('ORGANIZER', 'mailto:[email protected]');
1029		- $newVevent->add('ATTENDEE', 'mailto:' . '[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
	1029	+ $newVevent->add('ATTENDEE', 'mailto:'.'[email protected]', ['RSVP' => 'TRUE', 'CN' => 'Frodo']);
1030	1030	$message->message = $newVCalendar;
1031	1031	$message->sender = 'mailto:[email protected]';
1032		- $message->recipient = 'mailto:' . '[email protected]';
	1032	+ $message->recipient = 'mailto:'.'[email protected]';
1033	1033	$data = ['invitee_name' => 'Mr. Wizard',
1034	1034	'meeting_title' => 'Fellowship meeting',
1035	1035	'attendee_name' => '[email protected]'
		@@ -1051,7 +1051,7 @@ discard block
		block discarded – undo
1051	1051	$this->eventComparisonService->expects(self::once())
1052	1052	->method('findModified')
1053	1053	->with($newVCalendar, null)
1054		- ->willReturn(['old' => [] ,'new' => [$newVevent]]);
	1054	+ ->willReturn(['old' => [], 'new' => [$newVevent]]);
1055	1055	$this->service->expects(self::once())
1056	1056	->method('getCurrentAttendee')
1057	1057	->with($message)

nextcloud / server

Push — master ( 64ba0f...5b554f )

Status

Category

Spacing +38 added lines, -38 removed lines patch added patch discarded remove patch