nextcloud / server

tests/Core/Command/User/AuthTokens/DeleteTest.php

Indentation +148 added lines, -148 removed lines

@@ -14,152 +14,152 @@
 use Test\TestCase;
 
 class DeleteTest extends TestCase {
-	/** @var \PHPUnit\Framework\MockObject\MockObject */
-	protected $tokenProvider;
-	/** @var \PHPUnit\Framework\MockObject\MockObject */
-	protected $consoleInput;
-	/** @var \PHPUnit\Framework\MockObject\MockObject */
-	protected $consoleOutput;
-
-	/** @var \Symfony\Component\Console\Command\Command */
-	protected $command;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$tokenProvider = $this->tokenProvider = $this->getMockBuilder(IProvider::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$this->consoleInput = $this->getMockBuilder(InputInterface::class)->getMock();
-		$this->consoleOutput = $this->getMockBuilder(OutputInterface::class)->getMock();
-
-		/** @var \OC\Authentication\Token\IProvider $tokenProvider */
-		$this->command = new Delete($tokenProvider);
-	}
-
-	public function testDeleteTokenById(): void {
-		$this->consoleInput->expects($this->exactly(2))
-			->method('getArgument')
-			->willReturnMap([
-				['uid', 'user'],
-				['id', '42']
-			]);
-
-		$this->consoleInput->expects($this->once())
-			->method('getOption')
-			->with('last-used-before')
-			->willReturn(null);
-
-		$this->tokenProvider->expects($this->once())
-			->method('invalidateTokenById')
-			->with('user', 42);
-
-		$result = self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
-		$this->assertSame(Command::SUCCESS, $result);
-	}
-
-	public function testDeleteTokenByIdRequiresTokenId(): void {
-		$this->consoleInput->expects($this->exactly(2))
-			->method('getArgument')
-			->willReturnMap([
-				['uid', 'user'],
-				['id', null]
-			]);
-
-		$this->consoleInput->expects($this->once())
-			->method('getOption')
-			->with('last-used-before')
-			->willReturn(null);
-
-		$this->expectException(RuntimeException::class);
-
-		$this->tokenProvider->expects($this->never())->method('invalidateTokenById');
-
-		$result = self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
-		$this->assertSame(Command::FAILURE, $result);
-	}
-
-	public function testDeleteTokensLastUsedBefore(): void {
-		$this->consoleInput->expects($this->exactly(2))
-			->method('getArgument')
-			->willReturnMap([
-				['uid', 'user'],
-				['id', null]
-			]);
-
-		$this->consoleInput->expects($this->once())
-			->method('getOption')
-			->with('last-used-before')
-			->willReturn('946684800');
-
-		$this->tokenProvider->expects($this->once())
-			->method('invalidateLastUsedBefore')
-			->with('user', 946684800);
-
-		$result = self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
-		$this->assertSame(Command::SUCCESS, $result);
-	}
-
-	public function testLastUsedBeforeAcceptsIso8601Expanded(): void {
-		$this->consoleInput->expects($this->exactly(2))
-			->method('getArgument')
-			->willReturnMap([
-				['uid', 'user'],
-				['id', null]
-			]);
-
-		$this->consoleInput->expects($this->once())
-			->method('getOption')
-			->with('last-used-before')
-			->willReturn('2000-01-01T00:00:00Z');
-
-		$this->tokenProvider->expects($this->once())
-			->method('invalidateLastUsedBefore')
-			->with('user', 946684800);
-
-		$result = self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
-		$this->assertSame(Command::SUCCESS, $result);
-	}
-
-	public function testLastUsedBeforeAcceptsYmd(): void {
-		$this->consoleInput->expects($this->exactly(2))
-			->method('getArgument')
-			->willReturnMap([
-				['uid', 'user'],
-				['id', null]
-			]);
-
-		$this->consoleInput->expects($this->once())
-			->method('getOption')
-			->with('last-used-before')
-			->willReturn('2000-01-01');
-
-		$this->tokenProvider->expects($this->once())
-			->method('invalidateLastUsedBefore')
-			->with('user', 946684800);
-
-		$result = self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
-		$this->assertSame(Command::SUCCESS, $result);
-	}
-
-	public function testIdAndLastUsedBeforeAreMutuallyExclusive(): void {
-		$this->consoleInput->expects($this->exactly(2))
-			->method('getArgument')
-			->willReturnMap([
-				['uid', 'user'],
-				['id', '42']
-			]);
-
-		$this->consoleInput->expects($this->once())
-			->method('getOption')
-			->with('last-used-before')
-			->willReturn('946684800');
-
-		$this->expectException(RuntimeException::class);
-
-		$this->tokenProvider->expects($this->never())->method('invalidateLastUsedBefore');
-
-		$result = self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
-		$this->assertSame(Command::SUCCESS, $result);
-	}
+    /** @var \PHPUnit\Framework\MockObject\MockObject */
+    protected $tokenProvider;
+    /** @var \PHPUnit\Framework\MockObject\MockObject */
+    protected $consoleInput;
+    /** @var \PHPUnit\Framework\MockObject\MockObject */
+    protected $consoleOutput;
+
+    /** @var \Symfony\Component\Console\Command\Command */
+    protected $command;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $tokenProvider = $this->tokenProvider = $this->getMockBuilder(IProvider::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->consoleInput = $this->getMockBuilder(InputInterface::class)->getMock();
+        $this->consoleOutput = $this->getMockBuilder(OutputInterface::class)->getMock();
+
+        /** @var \OC\Authentication\Token\IProvider $tokenProvider */
+        $this->command = new Delete($tokenProvider);
+    }
+
+    public function testDeleteTokenById(): void {
+        $this->consoleInput->expects($this->exactly(2))
+            ->method('getArgument')
+            ->willReturnMap([
+                ['uid', 'user'],
+                ['id', '42']
+            ]);
+
+        $this->consoleInput->expects($this->once())
+            ->method('getOption')
+            ->with('last-used-before')
+            ->willReturn(null);
+
+        $this->tokenProvider->expects($this->once())
+            ->method('invalidateTokenById')
+            ->with('user', 42);
+
+        $result = self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
+        $this->assertSame(Command::SUCCESS, $result);
+    }
+
+    public function testDeleteTokenByIdRequiresTokenId(): void {
+        $this->consoleInput->expects($this->exactly(2))
+            ->method('getArgument')
+            ->willReturnMap([
+                ['uid', 'user'],
+                ['id', null]
+            ]);
+
+        $this->consoleInput->expects($this->once())
+            ->method('getOption')
+            ->with('last-used-before')
+            ->willReturn(null);
+
+        $this->expectException(RuntimeException::class);
+
+        $this->tokenProvider->expects($this->never())->method('invalidateTokenById');
+
+        $result = self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
+        $this->assertSame(Command::FAILURE, $result);
+    }
+
+    public function testDeleteTokensLastUsedBefore(): void {
+        $this->consoleInput->expects($this->exactly(2))
+            ->method('getArgument')
+            ->willReturnMap([
+                ['uid', 'user'],
+                ['id', null]
+            ]);
+
+        $this->consoleInput->expects($this->once())
+            ->method('getOption')
+            ->with('last-used-before')
+            ->willReturn('946684800');
+
+        $this->tokenProvider->expects($this->once())
+            ->method('invalidateLastUsedBefore')
+            ->with('user', 946684800);
+
+        $result = self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
+        $this->assertSame(Command::SUCCESS, $result);
+    }
+
+    public function testLastUsedBeforeAcceptsIso8601Expanded(): void {
+        $this->consoleInput->expects($this->exactly(2))
+            ->method('getArgument')
+            ->willReturnMap([
+                ['uid', 'user'],
+                ['id', null]
+            ]);
+
+        $this->consoleInput->expects($this->once())
+            ->method('getOption')
+            ->with('last-used-before')
+            ->willReturn('2000-01-01T00:00:00Z');
+
+        $this->tokenProvider->expects($this->once())
+            ->method('invalidateLastUsedBefore')
+            ->with('user', 946684800);
+
+        $result = self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
+        $this->assertSame(Command::SUCCESS, $result);
+    }
+
+    public function testLastUsedBeforeAcceptsYmd(): void {
+        $this->consoleInput->expects($this->exactly(2))
+            ->method('getArgument')
+            ->willReturnMap([
+                ['uid', 'user'],
+                ['id', null]
+            ]);
+
+        $this->consoleInput->expects($this->once())
+            ->method('getOption')
+            ->with('last-used-before')
+            ->willReturn('2000-01-01');
+
+        $this->tokenProvider->expects($this->once())
+            ->method('invalidateLastUsedBefore')
+            ->with('user', 946684800);
+
+        $result = self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
+        $this->assertSame(Command::SUCCESS, $result);
+    }
+
+    public function testIdAndLastUsedBeforeAreMutuallyExclusive(): void {
+        $this->consoleInput->expects($this->exactly(2))
+            ->method('getArgument')
+            ->willReturnMap([
+                ['uid', 'user'],
+                ['id', '42']
+            ]);
+
+        $this->consoleInput->expects($this->once())
+            ->method('getOption')
+            ->with('last-used-before')
+            ->willReturn('946684800');
+
+        $this->expectException(RuntimeException::class);
+
+        $this->tokenProvider->expects($this->never())->method('invalidateLastUsedBefore');
+
+        $result = self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
+        $this->assertSame(Command::SUCCESS, $result);
+    }
 }

tests/Core/Command/User/DisableTest.php

Indentation +60 added lines, -60 removed lines

@@ -14,64 +14,64 @@
 use Test\TestCase;
 
 class DisableTest extends TestCase {
-	/** @var IUserManager|\PHPUnit\Framework\MockObject\MockObject */
-	protected $userManager;
-	/** @var InputInterface|\PHPUnit\Framework\MockObject\MockObject */
-	protected $consoleInput;
-	/** @var OutputInterface|\PHPUnit\Framework\MockObject\MockObject */
-	protected $consoleOutput;
-
-	/** @var Disable */
-	protected $command;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->consoleInput = $this->createMock(InputInterface::class);
-		$this->consoleOutput = $this->createMock(OutputInterface::class);
-
-		$this->command = new Disable($this->userManager);
-	}
-
-	public function testValidUser(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())
-			->method('setEnabled')
-			->with(false);
-
-		$this->userManager
-			->method('get')
-			->with('user')
-			->willReturn($user);
-
-		$this->consoleInput
-			->method('getArgument')
-			->with('uid')
-			->willReturn('user');
-
-		$this->consoleOutput->expects($this->once())
-			->method('writeln')
-			->with($this->stringContains('The specified user is disabled'));
-
-		self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
-	}
-
-	public function testInvalidUser(): void {
-		$this->userManager->expects($this->once())
-			->method('get')
-			->with('user')
-			->willReturn(null);
-
-		$this->consoleInput
-			->method('getArgument')
-			->with('uid')
-			->willReturn('user');
-
-		$this->consoleOutput->expects($this->once())
-			->method('writeln')
-			->with($this->stringContains('User does not exist'));
-
-		self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
-	}
+    /** @var IUserManager|\PHPUnit\Framework\MockObject\MockObject */
+    protected $userManager;
+    /** @var InputInterface|\PHPUnit\Framework\MockObject\MockObject */
+    protected $consoleInput;
+    /** @var OutputInterface|\PHPUnit\Framework\MockObject\MockObject */
+    protected $consoleOutput;
+
+    /** @var Disable */
+    protected $command;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->consoleInput = $this->createMock(InputInterface::class);
+        $this->consoleOutput = $this->createMock(OutputInterface::class);
+
+        $this->command = new Disable($this->userManager);
+    }
+
+    public function testValidUser(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->once())
+            ->method('setEnabled')
+            ->with(false);
+
+        $this->userManager
+            ->method('get')
+            ->with('user')
+            ->willReturn($user);
+
+        $this->consoleInput
+            ->method('getArgument')
+            ->with('uid')
+            ->willReturn('user');
+
+        $this->consoleOutput->expects($this->once())
+            ->method('writeln')
+            ->with($this->stringContains('The specified user is disabled'));
+
+        self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
+    }
+
+    public function testInvalidUser(): void {
+        $this->userManager->expects($this->once())
+            ->method('get')
+            ->with('user')
+            ->willReturn(null);
+
+        $this->consoleInput
+            ->method('getArgument')
+            ->with('uid')
+            ->willReturn('user');
+
+        $this->consoleOutput->expects($this->once())
+            ->method('writeln')
+            ->with($this->stringContains('User does not exist'));
+
+        self::invokePrivate($this->command, 'execute', [$this->consoleInput, $this->consoleOutput]);
+    }
 }

tests/Core/Command/Group/AddUserTest.php

Indentation +81 added lines, -81 removed lines

@@ -16,85 +16,85 @@
 use Test\TestCase;
 
 class AddUserTest extends TestCase {
-	/** @var IGroupManager|\PHPUnit\Framework\MockObject\MockObject */
-	private $groupManager;
-
-	/** @var IUserManager|\PHPUnit\Framework\MockObject\MockObject */
-	private $userManager;
-
-	/** @var AddUser */
-	private $command;
-
-	/** @var InputInterface|\PHPUnit\Framework\MockObject\MockObject */
-	private $input;
-
-	/** @var OutputInterface|\PHPUnit\Framework\MockObject\MockObject */
-	private $output;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->command = new AddUser($this->userManager, $this->groupManager);
-
-		$this->input = $this->createMock(InputInterface::class);
-		$this->input->method('getArgument')
-			->willReturnCallback(function ($arg) {
-				if ($arg === 'group') {
-					return 'myGroup';
-				} elseif ($arg === 'user') {
-					return 'myUser';
-				}
-				throw new \Exception();
-			});
-		$this->output = $this->createMock(OutputInterface::class);
-	}
-
-	public function testNoGroup(): void {
-		$this->groupManager->method('get')
-			->with('myGroup')
-			->willReturn(null);
-
-		$this->output->expects($this->once())
-			->method('writeln')
-			->with('<error>group not found</error>');
-
-		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
-	}
-
-	public function testNoUser(): void {
-		$group = $this->createMock(IGroup::class);
-		$this->groupManager->method('get')
-			->with('myGroup')
-			->willReturn($group);
-
-		$this->userManager->method('get')
-			->with('myUser')
-			->willReturn(null);
-
-		$this->output->expects($this->once())
-			->method('writeln')
-			->with('<error>user not found</error>');
-
-		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
-	}
-
-	public function testAdd(): void {
-		$group = $this->createMock(IGroup::class);
-		$this->groupManager->method('get')
-			->with('myGroup')
-			->willReturn($group);
-
-		$user = $this->createMock(IUser::class);
-		$this->userManager->method('get')
-			->with('myUser')
-			->willReturn($user);
-
-		$group->expects($this->once())
-			->method('addUser')
-			->with($user);
-
-		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
-	}
+    /** @var IGroupManager|\PHPUnit\Framework\MockObject\MockObject */
+    private $groupManager;
+
+    /** @var IUserManager|\PHPUnit\Framework\MockObject\MockObject */
+    private $userManager;
+
+    /** @var AddUser */
+    private $command;
+
+    /** @var InputInterface|\PHPUnit\Framework\MockObject\MockObject */
+    private $input;
+
+    /** @var OutputInterface|\PHPUnit\Framework\MockObject\MockObject */
+    private $output;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->command = new AddUser($this->userManager, $this->groupManager);
+
+        $this->input = $this->createMock(InputInterface::class);
+        $this->input->method('getArgument')
+            ->willReturnCallback(function ($arg) {
+                if ($arg === 'group') {
+                    return 'myGroup';
+                } elseif ($arg === 'user') {
+                    return 'myUser';
+                }
+                throw new \Exception();
+            });
+        $this->output = $this->createMock(OutputInterface::class);
+    }
+
+    public function testNoGroup(): void {
+        $this->groupManager->method('get')
+            ->with('myGroup')
+            ->willReturn(null);
+
+        $this->output->expects($this->once())
+            ->method('writeln')
+            ->with('<error>group not found</error>');
+
+        $this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
+    }
+
+    public function testNoUser(): void {
+        $group = $this->createMock(IGroup::class);
+        $this->groupManager->method('get')
+            ->with('myGroup')
+            ->willReturn($group);
+
+        $this->userManager->method('get')
+            ->with('myUser')
+            ->willReturn(null);
+
+        $this->output->expects($this->once())
+            ->method('writeln')
+            ->with('<error>user not found</error>');
+
+        $this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
+    }
+
+    public function testAdd(): void {
+        $group = $this->createMock(IGroup::class);
+        $this->groupManager->method('get')
+            ->with('myGroup')
+            ->willReturn($group);
+
+        $user = $this->createMock(IUser::class);
+        $this->userManager->method('get')
+            ->with('myUser')
+            ->willReturn($user);
+
+        $group->expects($this->once())
+            ->method('addUser')
+            ->with($user);
+
+        $this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
+    }
 }

tests/Core/Command/Group/RemoveUserTest.php

Indentation +81 added lines, -81 removed lines

@@ -16,85 +16,85 @@
 use Test\TestCase;
 
 class RemoveUserTest extends TestCase {
-	/** @var IGroupManager|\PHPUnit\Framework\MockObject\MockObject */
-	private $groupManager;
-
-	/** @var IUserManager|\PHPUnit\Framework\MockObject\MockObject */
-	private $userManager;
-
-	/** @var RemoveUser */
-	private $command;
-
-	/** @var InputInterface|\PHPUnit\Framework\MockObject\MockObject */
-	private $input;
-
-	/** @var OutputInterface|\PHPUnit\Framework\MockObject\MockObject */
-	private $output;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->command = new RemoveUser($this->userManager, $this->groupManager);
-
-		$this->input = $this->createMock(InputInterface::class);
-		$this->input->method('getArgument')
-			->willReturnCallback(function ($arg) {
-				if ($arg === 'group') {
-					return 'myGroup';
-				} elseif ($arg === 'user') {
-					return 'myUser';
-				}
-				throw new \Exception();
-			});
-		$this->output = $this->createMock(OutputInterface::class);
-	}
-
-	public function testNoGroup(): void {
-		$this->groupManager->method('get')
-			->with('myGroup')
-			->willReturn(null);
-
-		$this->output->expects($this->once())
-			->method('writeln')
-			->with('<error>group not found</error>');
-
-		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
-	}
-
-	public function testNoUser(): void {
-		$group = $this->createMock(IGroup::class);
-		$this->groupManager->method('get')
-			->with('myGroup')
-			->willReturn($group);
-
-		$this->userManager->method('get')
-			->with('myUser')
-			->willReturn(null);
-
-		$this->output->expects($this->once())
-			->method('writeln')
-			->with('<error>user not found</error>');
-
-		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
-	}
-
-	public function testAdd(): void {
-		$group = $this->createMock(IGroup::class);
-		$this->groupManager->method('get')
-			->with('myGroup')
-			->willReturn($group);
-
-		$user = $this->createMock(IUser::class);
-		$this->userManager->method('get')
-			->with('myUser')
-			->willReturn($user);
-
-		$group->expects($this->once())
-			->method('removeUser')
-			->with($user);
-
-		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
-	}
+    /** @var IGroupManager|\PHPUnit\Framework\MockObject\MockObject */
+    private $groupManager;
+
+    /** @var IUserManager|\PHPUnit\Framework\MockObject\MockObject */
+    private $userManager;
+
+    /** @var RemoveUser */
+    private $command;
+
+    /** @var InputInterface|\PHPUnit\Framework\MockObject\MockObject */
+    private $input;
+
+    /** @var OutputInterface|\PHPUnit\Framework\MockObject\MockObject */
+    private $output;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->command = new RemoveUser($this->userManager, $this->groupManager);
+
+        $this->input = $this->createMock(InputInterface::class);
+        $this->input->method('getArgument')
+            ->willReturnCallback(function ($arg) {
+                if ($arg === 'group') {
+                    return 'myGroup';
+                } elseif ($arg === 'user') {
+                    return 'myUser';
+                }
+                throw new \Exception();
+            });
+        $this->output = $this->createMock(OutputInterface::class);
+    }
+
+    public function testNoGroup(): void {
+        $this->groupManager->method('get')
+            ->with('myGroup')
+            ->willReturn(null);
+
+        $this->output->expects($this->once())
+            ->method('writeln')
+            ->with('<error>group not found</error>');
+
+        $this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
+    }
+
+    public function testNoUser(): void {
+        $group = $this->createMock(IGroup::class);
+        $this->groupManager->method('get')
+            ->with('myGroup')
+            ->willReturn($group);
+
+        $this->userManager->method('get')
+            ->with('myUser')
+            ->willReturn(null);
+
+        $this->output->expects($this->once())
+            ->method('writeln')
+            ->with('<error>user not found</error>');
+
+        $this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
+    }
+
+    public function testAdd(): void {
+        $group = $this->createMock(IGroup::class);
+        $this->groupManager->method('get')
+            ->with('myGroup')
+            ->willReturn($group);
+
+        $user = $this->createMock(IUser::class);
+        $this->userManager->method('get')
+            ->with('myUser')
+            ->willReturn($user);
+
+        $group->expects($this->once())
+            ->method('removeUser')
+            ->with($user);
+
+        $this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
+    }
 }

tests/Core/Command/Group/DeleteTest.php

Indentation +114 added lines, -114 removed lines

@@ -14,118 +14,118 @@
 use Test\TestCase;
 
 class DeleteTest extends TestCase {
-	/** @var IGroupManager|\PHPUnit\Framework\MockObject\MockObject */
-	private $groupManager;
-
-	/** @var Delete */
-	private $command;
-
-	/** @var InputInterface|\PHPUnit\Framework\MockObject\MockObject */
-	private $input;
-
-	/** @var OutputInterface|\PHPUnit\Framework\MockObject\MockObject */
-	private $output;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->command = new Delete($this->groupManager);
-
-		$this->input = $this->createMock(InputInterface::class);
-		$this->output = $this->createMock(OutputInterface::class);
-	}
-
-	public function testDoesNotExists(): void {
-		$gid = 'myGroup';
-		$this->input->method('getArgument')
-			->willReturnCallback(function ($arg) use ($gid) {
-				if ($arg === 'groupid') {
-					return $gid;
-				}
-				throw new \Exception();
-			});
-		$this->groupManager->method('groupExists')
-			->with($gid)
-			->willReturn(false);
-
-		$this->groupManager->expects($this->never())
-			->method('get');
-		$this->output->expects($this->once())
-			->method('writeln')
-			->with($this->equalTo('<error>Group "' . $gid . '" does not exist.</error>'));
-
-		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
-	}
-
-	public function testDeleteAdmin(): void {
-		$gid = 'admin';
-		$this->input->method('getArgument')
-			->willReturnCallback(function ($arg) use ($gid) {
-				if ($arg === 'groupid') {
-					return $gid;
-				}
-				throw new \Exception();
-			});
-
-		$this->groupManager->expects($this->never())
-			->method($this->anything());
-		$this->output->expects($this->once())
-			->method('writeln')
-			->with($this->equalTo('<error>Group "' . $gid . '" could not be deleted.</error>'));
-
-		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
-	}
-
-	public function testDeleteFailed(): void {
-		$gid = 'myGroup';
-		$this->input->method('getArgument')
-			->willReturnCallback(function ($arg) use ($gid) {
-				if ($arg === 'groupid') {
-					return $gid;
-				}
-				throw new \Exception();
-			});
-		$group = $this->createMock(IGroup::class);
-		$group->method('delete')
-			->willReturn(false);
-		$this->groupManager->method('groupExists')
-			->with($gid)
-			->willReturn(true);
-		$this->groupManager->method('get')
-			->with($gid)
-			->willReturn($group);
-
-		$this->output->expects($this->once())
-			->method('writeln')
-			->with($this->equalTo('<error>Group "' . $gid . '" could not be deleted. Please check the logs.</error>'));
-
-		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
-	}
-
-	public function testDelete(): void {
-		$gid = 'myGroup';
-		$this->input->method('getArgument')
-			->willReturnCallback(function ($arg) use ($gid) {
-				if ($arg === 'groupid') {
-					return $gid;
-				}
-				throw new \Exception();
-			});
-		$group = $this->createMock(IGroup::class);
-		$group->method('delete')
-			->willReturn(true);
-		$this->groupManager->method('groupExists')
-			->with($gid)
-			->willReturn(true);
-		$this->groupManager->method('get')
-			->with($gid)
-			->willReturn($group);
-
-		$this->output->expects($this->once())
-			->method('writeln')
-			->with($this->equalTo('Group "' . $gid . '" was removed'));
-
-		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
-	}
+    /** @var IGroupManager|\PHPUnit\Framework\MockObject\MockObject */
+    private $groupManager;
+
+    /** @var Delete */
+    private $command;
+
+    /** @var InputInterface|\PHPUnit\Framework\MockObject\MockObject */
+    private $input;
+
+    /** @var OutputInterface|\PHPUnit\Framework\MockObject\MockObject */
+    private $output;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->command = new Delete($this->groupManager);
+
+        $this->input = $this->createMock(InputInterface::class);
+        $this->output = $this->createMock(OutputInterface::class);
+    }
+
+    public function testDoesNotExists(): void {
+        $gid = 'myGroup';
+        $this->input->method('getArgument')
+            ->willReturnCallback(function ($arg) use ($gid) {
+                if ($arg === 'groupid') {
+                    return $gid;
+                }
+                throw new \Exception();
+            });
+        $this->groupManager->method('groupExists')
+            ->with($gid)
+            ->willReturn(false);
+
+        $this->groupManager->expects($this->never())
+            ->method('get');
+        $this->output->expects($this->once())
+            ->method('writeln')
+            ->with($this->equalTo('<error>Group "' . $gid . '" does not exist.</error>'));
+
+        $this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
+    }
+
+    public function testDeleteAdmin(): void {
+        $gid = 'admin';
+        $this->input->method('getArgument')
+            ->willReturnCallback(function ($arg) use ($gid) {
+                if ($arg === 'groupid') {
+                    return $gid;
+                }
+                throw new \Exception();
+            });
+
+        $this->groupManager->expects($this->never())
+            ->method($this->anything());
+        $this->output->expects($this->once())
+            ->method('writeln')
+            ->with($this->equalTo('<error>Group "' . $gid . '" could not be deleted.</error>'));
+
+        $this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
+    }
+
+    public function testDeleteFailed(): void {
+        $gid = 'myGroup';
+        $this->input->method('getArgument')
+            ->willReturnCallback(function ($arg) use ($gid) {
+                if ($arg === 'groupid') {
+                    return $gid;
+                }
+                throw new \Exception();
+            });
+        $group = $this->createMock(IGroup::class);
+        $group->method('delete')
+            ->willReturn(false);
+        $this->groupManager->method('groupExists')
+            ->with($gid)
+            ->willReturn(true);
+        $this->groupManager->method('get')
+            ->with($gid)
+            ->willReturn($group);
+
+        $this->output->expects($this->once())
+            ->method('writeln')
+            ->with($this->equalTo('<error>Group "' . $gid . '" could not be deleted. Please check the logs.</error>'));
+
+        $this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
+    }
+
+    public function testDelete(): void {
+        $gid = 'myGroup';
+        $this->input->method('getArgument')
+            ->willReturnCallback(function ($arg) use ($gid) {
+                if ($arg === 'groupid') {
+                    return $gid;
+                }
+                throw new \Exception();
+            });
+        $group = $this->createMock(IGroup::class);
+        $group->method('delete')
+            ->willReturn(true);
+        $this->groupManager->method('groupExists')
+            ->with($gid)
+            ->willReturn(true);
+        $this->groupManager->method('get')
+            ->with($gid)
+            ->willReturn($group);
+
+        $this->output->expects($this->once())
+            ->method('writeln')
+            ->with($this->equalTo('Group "' . $gid . '" was removed'));
+
+        $this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
+    }
 }

tests/redis-cluster.config.php

Indentation +16 added lines, -16 removed lines

@@ -4,20 +4,20 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 $CONFIG = [
-	'memcache.local' => '\\OC\\Memcache\\Redis',
-	'memcache.distributed' => '\\OC\\Memcache\\Redis',
-	'memcache.locking' => '\\OC\\Memcache\\Redis',
-	'redis.cluster' => [
-		'seeds' => [ // provide some/all of the cluster servers to bootstrap discovery, port required
-			'cache-cluster:7000',
-			'cache-cluster:7001',
-			'cache-cluster:7002',
-			'cache-cluster:7003',
-			'cache-cluster:7004',
-			'cache-cluster:7005'
-		],
-		'timeout' => 0.0,
-		'read_timeout' => 0.0,
-		'failover_mode' => \RedisCluster::FAILOVER_ERROR
-	],
+    'memcache.local' => '\\OC\\Memcache\\Redis',
+    'memcache.distributed' => '\\OC\\Memcache\\Redis',
+    'memcache.locking' => '\\OC\\Memcache\\Redis',
+    'redis.cluster' => [
+        'seeds' => [ // provide some/all of the cluster servers to bootstrap discovery, port required
+            'cache-cluster:7000',
+            'cache-cluster:7001',
+            'cache-cluster:7002',
+            'cache-cluster:7003',
+            'cache-cluster:7004',
+            'cache-cluster:7005'
+        ],
+        'timeout' => 0.0,
+        'read_timeout' => 0.0,
+        'failover_mode' => \RedisCluster::FAILOVER_ERROR
+    ],
 ];

tests/preseed-config.php

Indentation +95 added lines, -95 removed lines

@@ -5,112 +5,112 @@
  * SPDX-License-Identifier: AGPL-3.0-only
  */
 $CONFIG = [
-	'appstoreenabled' => false,
-	'apps_paths' => [
-		[
-			'path' => OC::$SERVERROOT . '/apps',
-			'url' => '/apps',
-			'writable' => true,
-		],
-	],
+    'appstoreenabled' => false,
+    'apps_paths' => [
+        [
+            'path' => OC::$SERVERROOT . '/apps',
+            'url' => '/apps',
+            'writable' => true,
+        ],
+    ],
 ];
 
 if (is_dir(OC::$SERVERROOT . '/apps2')) {
-	$CONFIG['apps_paths'][] = [
-		'path' => OC::$SERVERROOT . '/apps2',
-		'url' => '/apps2',
-		'writable' => false,
-	];
+    $CONFIG['apps_paths'][] = [
+        'path' => OC::$SERVERROOT . '/apps2',
+        'url' => '/apps2',
+        'writable' => false,
+    ];
 }
 
 if (getenv('OBJECT_STORE') === 's3') {
-	$CONFIG['objectstore'] = [
-		'class' => 'OC\\Files\\ObjectStore\\S3',
-		'arguments' => [
-			'bucket' => 'nextcloud',
-			'autocreate' => true,
-			'key' => getenv('OBJECT_STORE_KEY') ?: 'nextcloud',
-			'secret' => getenv('OBJECT_STORE_SECRET') ?: 'nextcloud',
-			'hostname' => getenv('OBJECT_STORE_HOST') ?: 'localhost',
-			'port' => 9000,
-			'use_ssl' => false,
-			// required for some non amazon s3 implementations
-			'use_path_style' => true
-		]
-	];
+    $CONFIG['objectstore'] = [
+        'class' => 'OC\\Files\\ObjectStore\\S3',
+        'arguments' => [
+            'bucket' => 'nextcloud',
+            'autocreate' => true,
+            'key' => getenv('OBJECT_STORE_KEY') ?: 'nextcloud',
+            'secret' => getenv('OBJECT_STORE_SECRET') ?: 'nextcloud',
+            'hostname' => getenv('OBJECT_STORE_HOST') ?: 'localhost',
+            'port' => 9000,
+            'use_ssl' => false,
+            // required for some non amazon s3 implementations
+            'use_path_style' => true
+        ]
+    ];
 } elseif (getenv('OBJECT_STORE') === 's3-multibucket') {
-	$CONFIG['objectstore_multibucket'] = [
-		'class' => 'OC\\Files\\ObjectStore\\S3',
-		'arguments' => [
-			'bucket' => 'nextcloud',
-			'autocreate' => true,
-			'key' => getenv('OBJECT_STORE_KEY') ?: 'nextcloud',
-			'secret' => getenv('OBJECT_STORE_SECRET') ?: 'nextcloud',
-			'hostname' => getenv('OBJECT_STORE_HOST') ?: 'localhost',
-			'port' => 9000,
-			'use_ssl' => false,
-			// required for some non amazon s3 implementations
-			'use_path_style' => true
-		]
-	];
+    $CONFIG['objectstore_multibucket'] = [
+        'class' => 'OC\\Files\\ObjectStore\\S3',
+        'arguments' => [
+            'bucket' => 'nextcloud',
+            'autocreate' => true,
+            'key' => getenv('OBJECT_STORE_KEY') ?: 'nextcloud',
+            'secret' => getenv('OBJECT_STORE_SECRET') ?: 'nextcloud',
+            'hostname' => getenv('OBJECT_STORE_HOST') ?: 'localhost',
+            'port' => 9000,
+            'use_ssl' => false,
+            // required for some non amazon s3 implementations
+            'use_path_style' => true
+        ]
+    ];
 } elseif (getenv('OBJECT_STORE') === 'azure') {
-	$CONFIG['objectstore'] = [
-		'class' => 'OC\\Files\\ObjectStore\\Azure',
-		'arguments' => [
-			'container' => 'test',
-			'account_name' => getenv('OBJECT_STORE_KEY') ?: 'devstoreaccount1',
-			'account_key' => getenv('OBJECT_STORE_SECRET') ?: 'Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==',
-			'endpoint' => 'http://' . (getenv('OBJECT_STORE_HOST') ?: 'localhost') . ':10000/' . (getenv('OBJECT_STORE_KEY') ?: 'devstoreaccount1'),
-			'autocreate' => true
-		]
-	];
+    $CONFIG['objectstore'] = [
+        'class' => 'OC\\Files\\ObjectStore\\Azure',
+        'arguments' => [
+            'container' => 'test',
+            'account_name' => getenv('OBJECT_STORE_KEY') ?: 'devstoreaccount1',
+            'account_key' => getenv('OBJECT_STORE_SECRET') ?: 'Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==',
+            'endpoint' => 'http://' . (getenv('OBJECT_STORE_HOST') ?: 'localhost') . ':10000/' . (getenv('OBJECT_STORE_KEY') ?: 'devstoreaccount1'),
+            'autocreate' => true
+        ]
+    ];
 } elseif (getenv('OBJECT_STORE') === 'swift') {
-	$swiftHost = getenv('OBJECT_STORE_HOST') ?: 'localhost:5000';
+    $swiftHost = getenv('OBJECT_STORE_HOST') ?: 'localhost:5000';
 
-	$CONFIG['objectstore'] = [
-		'class' => 'OC\\Files\\ObjectStore\\Swift',
-		'arguments' => [
-			'autocreate' => true,
-			'user' => [
-				'name' => getenv('OBJECT_STORE_KEY') ?: 'swift',
-				'password' => getenv('OBJECT_STORE_SECRET') ?: 'swift',
-				'domain' => [
-					'name' => 'Default',
-				],
-			],
-			'scope' => [
-				'project' => [
-					'name' => 'service',
-					'domain' => [
-						'name' => 'Default',
-					],
-				],
-			],
-			'serviceName' => 'service',
-			'region' => 'RegionOne',
-			'url' => "http://$swiftHost/v3",
-			'bucket' => 'nextcloud',
-		]
-	];
+    $CONFIG['objectstore'] = [
+        'class' => 'OC\\Files\\ObjectStore\\Swift',
+        'arguments' => [
+            'autocreate' => true,
+            'user' => [
+                'name' => getenv('OBJECT_STORE_KEY') ?: 'swift',
+                'password' => getenv('OBJECT_STORE_SECRET') ?: 'swift',
+                'domain' => [
+                    'name' => 'Default',
+                ],
+            ],
+            'scope' => [
+                'project' => [
+                    'name' => 'service',
+                    'domain' => [
+                        'name' => 'Default',
+                    ],
+                ],
+            ],
+            'serviceName' => 'service',
+            'region' => 'RegionOne',
+            'url' => "http://$swiftHost/v3",
+            'bucket' => 'nextcloud',
+        ]
+    ];
 }
 
 if (getenv('SHARDING') == '1') {
-	$CONFIG['dbsharding'] = [
-		'filecache' => [
-			'shards' => [
-				[
-					'port' => 5001,
-				],
-				[
-					'port' => 5002,
-				],
-				[
-					'port' => 5003,
-				],
-				[
-					'port' => 5004,
-				],
-			]
-		]
-	];
+    $CONFIG['dbsharding'] = [
+        'filecache' => [
+            'shards' => [
+                [
+                    'port' => 5001,
+                ],
+                [
+                    'port' => 5002,
+                ],
+                [
+                    'port' => 5003,
+                ],
+                [
+                    'port' => 5004,
+                ],
+            ]
+        ]
+    ];
 }

tests/lib/Accounts/AccountPropertyCollectionTest.php

Indentation +172 added lines, -172 removed lines

@@ -17,176 +17,176 @@
 use Test\TestCase;
 
 class AccountPropertyCollectionTest extends TestCase {
-	/** @var IAccountPropertyCollection */
-	protected $collection;
-
-	protected const COLLECTION_NAME = 'my_multivalue_property';
-
-	public function setUp(): void {
-		parent::setUp();
-
-		$this->collection = new AccountPropertyCollection(self::COLLECTION_NAME);
-	}
-
-	/**
-	 * @return IAccountProperty|MockObject
-	 */
-	protected function makePropertyMock(string $propertyName): MockObject {
-		$mock = $this->createMock(IAccountProperty::class);
-		$mock->expects($this->any())
-			->method('getName')
-			->willReturn($propertyName);
-
-		return $mock;
-	}
-
-	public function testSetAndGetProperties(): void {
-		$propsBefore = $this->collection->getProperties();
-		$this->assertIsArray($propsBefore);
-		$this->assertEmpty($propsBefore);
-
-		$props = [
-			$this->makePropertyMock(self::COLLECTION_NAME),
-			$this->makePropertyMock(self::COLLECTION_NAME),
-			$this->makePropertyMock(self::COLLECTION_NAME),
-		];
-
-		$this->collection->setProperties($props);
-		$propsAfter = $this->collection->getProperties();
-		$this->assertIsArray($propsAfter);
-		$this->assertCount(count($props), $propsAfter);
-	}
-
-	public function testSetPropertiesMixedInvalid(): void {
-		$props = [
-			$this->makePropertyMock(self::COLLECTION_NAME),
-			$this->makePropertyMock('sneaky_property'),
-			$this->makePropertyMock(self::COLLECTION_NAME),
-		];
-
-		$this->expectException(InvalidArgumentException::class);
-		$this->collection->setProperties($props);
-	}
-
-	public function testAddProperty(): void {
-		$props = [
-			$this->makePropertyMock(self::COLLECTION_NAME),
-			$this->makePropertyMock(self::COLLECTION_NAME),
-			$this->makePropertyMock(self::COLLECTION_NAME),
-		];
-		$this->collection->setProperties($props);
-
-		$additionalProperty = $this->makePropertyMock(self::COLLECTION_NAME);
-		$this->collection->addProperty($additionalProperty);
-
-		$propsAfter = $this->collection->getProperties();
-		$this->assertCount(count($props) + 1, $propsAfter);
-		$this->assertNotFalse(array_search($additionalProperty, $propsAfter, true));
-	}
-
-	public function testAddPropertyInvalid(): void {
-		$props = [
-			$this->makePropertyMock(self::COLLECTION_NAME),
-			$this->makePropertyMock(self::COLLECTION_NAME),
-			$this->makePropertyMock(self::COLLECTION_NAME),
-		];
-		$this->collection->setProperties($props);
-
-		$additionalProperty = $this->makePropertyMock('sneaky_property');
-		$exceptionThrown = false;
-		try {
-			$this->collection->addProperty($additionalProperty);
-		} catch (\InvalidArgumentException $e) {
-			$exceptionThrown = true;
-		} finally {
-			$propsAfter = $this->collection->getProperties();
-			$this->assertCount(count($props), $propsAfter);
-			$this->assertFalse(array_search($additionalProperty, $propsAfter, true));
-			$this->assertTrue($exceptionThrown);
-		}
-	}
-
-	public function testRemoveProperty(): void {
-		$additionalProperty = $this->makePropertyMock(self::COLLECTION_NAME);
-		$props = [
-			$this->makePropertyMock(self::COLLECTION_NAME),
-			$this->makePropertyMock(self::COLLECTION_NAME),
-			$additionalProperty,
-			$this->makePropertyMock(self::COLLECTION_NAME),
-		];
-		$this->collection->setProperties($props);
-
-		$propsBefore = $this->collection->getProperties();
-		$this->collection->removeProperty($additionalProperty);
-		$propsAfter = $this->collection->getProperties();
-
-		$this->assertTrue(count($propsBefore) > count($propsAfter));
-		$this->assertCount(count($propsBefore) - 1, $propsAfter);
-		$this->assertFalse(array_search($additionalProperty, $propsAfter, true));
-	}
-
-	public function testRemovePropertyNotFound(): void {
-		$additionalProperty = $this->makePropertyMock(self::COLLECTION_NAME);
-		$props = [
-			$this->makePropertyMock(self::COLLECTION_NAME),
-			$this->makePropertyMock(self::COLLECTION_NAME),
-			$this->makePropertyMock(self::COLLECTION_NAME),
-		];
-		$this->collection->setProperties($props);
-
-		$propsBefore = $this->collection->getProperties();
-		$this->collection->removeProperty($additionalProperty);
-		$propsAfter = $this->collection->getProperties();
-
-		// no errors, gently
-		$this->assertCount(count($propsBefore), $propsAfter);
-	}
-
-	public function testRemovePropertyByValue(): void {
-		$additionalProperty = $this->makePropertyMock(self::COLLECTION_NAME);
-		$additionalProperty->expects($this->any())
-			->method('getValue')
-			->willReturn('Lorem ipsum');
-
-		$additionalPropertyTwo = clone $additionalProperty;
-
-		$props = [
-			$this->makePropertyMock(self::COLLECTION_NAME),
-			$this->makePropertyMock(self::COLLECTION_NAME),
-			$additionalProperty,
-			$this->makePropertyMock(self::COLLECTION_NAME),
-			$additionalPropertyTwo
-		];
-		$this->collection->setProperties($props);
-
-		$propsBefore = $this->collection->getProperties();
-		$this->collection->removePropertyByValue('Lorem ipsum');
-		$propsAfter = $this->collection->getProperties();
-
-		$this->assertTrue(count($propsBefore) > count($propsAfter));
-		$this->assertCount(count($propsBefore) - 2, $propsAfter);
-		$this->assertFalse(array_search($additionalProperty, $propsAfter, true));
-		$this->assertFalse(array_search($additionalPropertyTwo, $propsAfter, true));
-	}
-
-	public function testRemovePropertyByValueNotFound(): void {
-		$additionalProperty = $this->makePropertyMock(self::COLLECTION_NAME);
-		$additionalProperty->expects($this->any())
-			->method('getValue')
-			->willReturn('Lorem ipsum');
-
-		$props = [
-			$this->makePropertyMock(self::COLLECTION_NAME),
-			$this->makePropertyMock(self::COLLECTION_NAME),
-			$this->makePropertyMock(self::COLLECTION_NAME),
-		];
-		$this->collection->setProperties($props);
-
-		$propsBefore = $this->collection->getProperties();
-		$this->collection->removePropertyByValue('Lorem ipsum');
-		$propsAfter = $this->collection->getProperties();
-
-		// no errors, gently
-		$this->assertCount(count($propsBefore), $propsAfter);
-	}
+    /** @var IAccountPropertyCollection */
+    protected $collection;
+
+    protected const COLLECTION_NAME = 'my_multivalue_property';
+
+    public function setUp(): void {
+        parent::setUp();
+
+        $this->collection = new AccountPropertyCollection(self::COLLECTION_NAME);
+    }
+
+    /**
+     * @return IAccountProperty|MockObject
+     */
+    protected function makePropertyMock(string $propertyName): MockObject {
+        $mock = $this->createMock(IAccountProperty::class);
+        $mock->expects($this->any())
+            ->method('getName')
+            ->willReturn($propertyName);
+
+        return $mock;
+    }
+
+    public function testSetAndGetProperties(): void {
+        $propsBefore = $this->collection->getProperties();
+        $this->assertIsArray($propsBefore);
+        $this->assertEmpty($propsBefore);
+
+        $props = [
+            $this->makePropertyMock(self::COLLECTION_NAME),
+            $this->makePropertyMock(self::COLLECTION_NAME),
+            $this->makePropertyMock(self::COLLECTION_NAME),
+        ];
+
+        $this->collection->setProperties($props);
+        $propsAfter = $this->collection->getProperties();
+        $this->assertIsArray($propsAfter);
+        $this->assertCount(count($props), $propsAfter);
+    }
+
+    public function testSetPropertiesMixedInvalid(): void {
+        $props = [
+            $this->makePropertyMock(self::COLLECTION_NAME),
+            $this->makePropertyMock('sneaky_property'),
+            $this->makePropertyMock(self::COLLECTION_NAME),
+        ];
+
+        $this->expectException(InvalidArgumentException::class);
+        $this->collection->setProperties($props);
+    }
+
+    public function testAddProperty(): void {
+        $props = [
+            $this->makePropertyMock(self::COLLECTION_NAME),
+            $this->makePropertyMock(self::COLLECTION_NAME),
+            $this->makePropertyMock(self::COLLECTION_NAME),
+        ];
+        $this->collection->setProperties($props);
+
+        $additionalProperty = $this->makePropertyMock(self::COLLECTION_NAME);
+        $this->collection->addProperty($additionalProperty);
+
+        $propsAfter = $this->collection->getProperties();
+        $this->assertCount(count($props) + 1, $propsAfter);
+        $this->assertNotFalse(array_search($additionalProperty, $propsAfter, true));
+    }
+
+    public function testAddPropertyInvalid(): void {
+        $props = [
+            $this->makePropertyMock(self::COLLECTION_NAME),
+            $this->makePropertyMock(self::COLLECTION_NAME),
+            $this->makePropertyMock(self::COLLECTION_NAME),
+        ];
+        $this->collection->setProperties($props);
+
+        $additionalProperty = $this->makePropertyMock('sneaky_property');
+        $exceptionThrown = false;
+        try {
+            $this->collection->addProperty($additionalProperty);
+        } catch (\InvalidArgumentException $e) {
+            $exceptionThrown = true;
+        } finally {
+            $propsAfter = $this->collection->getProperties();
+            $this->assertCount(count($props), $propsAfter);
+            $this->assertFalse(array_search($additionalProperty, $propsAfter, true));
+            $this->assertTrue($exceptionThrown);
+        }
+    }
+
+    public function testRemoveProperty(): void {
+        $additionalProperty = $this->makePropertyMock(self::COLLECTION_NAME);
+        $props = [
+            $this->makePropertyMock(self::COLLECTION_NAME),
+            $this->makePropertyMock(self::COLLECTION_NAME),
+            $additionalProperty,
+            $this->makePropertyMock(self::COLLECTION_NAME),
+        ];
+        $this->collection->setProperties($props);
+
+        $propsBefore = $this->collection->getProperties();
+        $this->collection->removeProperty($additionalProperty);
+        $propsAfter = $this->collection->getProperties();
+
+        $this->assertTrue(count($propsBefore) > count($propsAfter));
+        $this->assertCount(count($propsBefore) - 1, $propsAfter);
+        $this->assertFalse(array_search($additionalProperty, $propsAfter, true));
+    }
+
+    public function testRemovePropertyNotFound(): void {
+        $additionalProperty = $this->makePropertyMock(self::COLLECTION_NAME);
+        $props = [
+            $this->makePropertyMock(self::COLLECTION_NAME),
+            $this->makePropertyMock(self::COLLECTION_NAME),
+            $this->makePropertyMock(self::COLLECTION_NAME),
+        ];
+        $this->collection->setProperties($props);
+
+        $propsBefore = $this->collection->getProperties();
+        $this->collection->removeProperty($additionalProperty);
+        $propsAfter = $this->collection->getProperties();
+
+        // no errors, gently
+        $this->assertCount(count($propsBefore), $propsAfter);
+    }
+
+    public function testRemovePropertyByValue(): void {
+        $additionalProperty = $this->makePropertyMock(self::COLLECTION_NAME);
+        $additionalProperty->expects($this->any())
+            ->method('getValue')
+            ->willReturn('Lorem ipsum');
+
+        $additionalPropertyTwo = clone $additionalProperty;
+
+        $props = [
+            $this->makePropertyMock(self::COLLECTION_NAME),
+            $this->makePropertyMock(self::COLLECTION_NAME),
+            $additionalProperty,
+            $this->makePropertyMock(self::COLLECTION_NAME),
+            $additionalPropertyTwo
+        ];
+        $this->collection->setProperties($props);
+
+        $propsBefore = $this->collection->getProperties();
+        $this->collection->removePropertyByValue('Lorem ipsum');
+        $propsAfter = $this->collection->getProperties();
+
+        $this->assertTrue(count($propsBefore) > count($propsAfter));
+        $this->assertCount(count($propsBefore) - 2, $propsAfter);
+        $this->assertFalse(array_search($additionalProperty, $propsAfter, true));
+        $this->assertFalse(array_search($additionalPropertyTwo, $propsAfter, true));
+    }
+
+    public function testRemovePropertyByValueNotFound(): void {
+        $additionalProperty = $this->makePropertyMock(self::COLLECTION_NAME);
+        $additionalProperty->expects($this->any())
+            ->method('getValue')
+            ->willReturn('Lorem ipsum');
+
+        $props = [
+            $this->makePropertyMock(self::COLLECTION_NAME),
+            $this->makePropertyMock(self::COLLECTION_NAME),
+            $this->makePropertyMock(self::COLLECTION_NAME),
+        ];
+        $this->collection->setProperties($props);
+
+        $propsBefore = $this->collection->getProperties();
+        $this->collection->removePropertyByValue('Lorem ipsum');
+        $propsAfter = $this->collection->getProperties();
+
+        // no errors, gently
+        $this->assertCount(count($propsBefore), $propsAfter);
+    }
 }

tests/lib/Notification/DummyApp.php

Indentation +23 added lines, -23 removed lines

@@ -12,29 +12,29 @@
 use OCP\Notification\INotification;
 
 class DummyApp implements IApp {
-	/**
-	 * @param INotification $notification
-	 * @throws \InvalidArgumentException When the notification is not valid
-	 * @since 9.0.0
-	 */
-	public function notify(INotification $notification): void {
-		// TODO: Implement notify() method.
-	}
+    /**
+     * @param INotification $notification
+     * @throws \InvalidArgumentException When the notification is not valid
+     * @since 9.0.0
+     */
+    public function notify(INotification $notification): void {
+        // TODO: Implement notify() method.
+    }
 
-	/**
-	 * @param INotification $notification
-	 * @since 9.0.0
-	 */
-	public function markProcessed(INotification $notification): void {
-		// TODO: Implement markProcessed() method.
-	}
+    /**
+     * @param INotification $notification
+     * @since 9.0.0
+     */
+    public function markProcessed(INotification $notification): void {
+        // TODO: Implement markProcessed() method.
+    }
 
-	/**
-	 * @param INotification $notification
-	 * @return int
-	 * @since 9.0.0
-	 */
-	public function getCount(INotification $notification): int {
-		// TODO: Implement getCount() method.
-	}
+    /**
+     * @param INotification $notification
+     * @return int
+     * @since 9.0.0
+     */
+    public function getCount(INotification $notification): int {
+        // TODO: Implement getCount() method.
+    }
 }