Passed
Push — master ( 645109...008e6d )
by Christoph
12:14 queued 12s
created
lib/private/Files/Mount/MoveableMount.php 1 patch
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -27,19 +27,19 @@
 block discarded – undo
27 27
  * Defines the mount point to be (re)moved by the user
28 28
  */
29 29
 interface MoveableMount {
30
-	/**
31
-	 * Move the mount point to $target
32
-	 *
33
-	 * @param string $target the target mount point
34
-	 * @return bool
35
-	 */
36
-	public function moveMount($target);
30
+    /**
31
+     * Move the mount point to $target
32
+     *
33
+     * @param string $target the target mount point
34
+     * @return bool
35
+     */
36
+    public function moveMount($target);
37 37
 
38
-	/**
39
-	 * Remove the mount points
40
-	 *
41
-	 * @return mixed
42
-	 * @return bool
43
-	 */
44
-	public function removeMount();
38
+    /**
39
+     * Remove the mount points
40
+     *
41
+     * @return mixed
42
+     * @return bool
43
+     */
44
+    public function removeMount();
45 45
 }
Please login to merge, or discard this patch.
lib/private/Files/Stream/Quota.php 3 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -66,10 +66,10 @@
 block discarded – undo
66 66
 	}
67 67
 
68 68
 	public function stream_seek($offset, $whence = SEEK_SET) {
69
-		if ($whence === SEEK_END){
69
+		if ($whence === SEEK_END) {
70 70
 			// go to the end to find out last position's offset
71 71
 			$oldOffset = $this->stream_tell();
72
-			if (fseek($this->source, 0, $whence) !== 0){
72
+			if (fseek($this->source, 0, $whence) !== 0) {
73 73
 				return false;
74 74
 			}
75 75
 			$whence = SEEK_SET;
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,8 +75,7 @@
 block discarded – undo
75 75
 			$whence = SEEK_SET;
76 76
 			$offset = $this->stream_tell() + $offset;
77 77
 			$this->limit += $oldOffset - $offset;
78
-		}
79
-		else if ($whence === SEEK_SET) {
78
+		} else if ($whence === SEEK_SET) {
80 79
 			$this->limit += $this->stream_tell() - $offset;
81 80
 		} else {
82 81
 			$this->limit -= $offset;
Please login to merge, or discard this patch.
Indentation   +60 added lines, -60 removed lines patch added patch discarded remove patch
@@ -33,71 +33,71 @@
 block discarded – undo
33 33
  * usage: resource \OC\Files\Stream\Quota::wrap($stream, $limit)
34 34
  */
35 35
 class Quota extends Wrapper {
36
-	/**
37
-	 * @var int $limit
38
-	 */
39
-	private $limit;
36
+    /**
37
+     * @var int $limit
38
+     */
39
+    private $limit;
40 40
 
41
-	/**
42
-	 * @param resource $stream
43
-	 * @param int $limit
44
-	 * @return resource
45
-	 */
46
-	static public function wrap($stream, $limit) {
47
-		$context = stream_context_create([
48
-			'quota' => [
49
-				'source' => $stream,
50
-				'limit' => $limit
51
-			]
52
-		]);
53
-		return Wrapper::wrapSource($stream, $context, 'quota', self::class);
54
-	}
41
+    /**
42
+     * @param resource $stream
43
+     * @param int $limit
44
+     * @return resource
45
+     */
46
+    static public function wrap($stream, $limit) {
47
+        $context = stream_context_create([
48
+            'quota' => [
49
+                'source' => $stream,
50
+                'limit' => $limit
51
+            ]
52
+        ]);
53
+        return Wrapper::wrapSource($stream, $context, 'quota', self::class);
54
+    }
55 55
 
56
-	public function stream_open($path, $mode, $options, &$opened_path) {
57
-		$context = $this->loadContext('quota');
58
-		$this->source = $context['source'];
59
-		$this->limit = $context['limit'];
56
+    public function stream_open($path, $mode, $options, &$opened_path) {
57
+        $context = $this->loadContext('quota');
58
+        $this->source = $context['source'];
59
+        $this->limit = $context['limit'];
60 60
 
61
-		return true;
62
-	}
61
+        return true;
62
+    }
63 63
 
64
-	public function dir_opendir($path, $options) {
65
-		return false;
66
-	}
64
+    public function dir_opendir($path, $options) {
65
+        return false;
66
+    }
67 67
 
68
-	public function stream_seek($offset, $whence = SEEK_SET) {
69
-		if ($whence === SEEK_END){
70
-			// go to the end to find out last position's offset
71
-			$oldOffset = $this->stream_tell();
72
-			if (fseek($this->source, 0, $whence) !== 0){
73
-				return false;
74
-			}
75
-			$whence = SEEK_SET;
76
-			$offset = $this->stream_tell() + $offset;
77
-			$this->limit += $oldOffset - $offset;
78
-		}
79
-		else if ($whence === SEEK_SET) {
80
-			$this->limit += $this->stream_tell() - $offset;
81
-		} else {
82
-			$this->limit -= $offset;
83
-		}
84
-		// this wrapper needs to return "true" for success.
85
-		// the fseek call itself returns 0 on succeess
86
-		return fseek($this->source, $offset, $whence) === 0;
87
-	}
68
+    public function stream_seek($offset, $whence = SEEK_SET) {
69
+        if ($whence === SEEK_END){
70
+            // go to the end to find out last position's offset
71
+            $oldOffset = $this->stream_tell();
72
+            if (fseek($this->source, 0, $whence) !== 0){
73
+                return false;
74
+            }
75
+            $whence = SEEK_SET;
76
+            $offset = $this->stream_tell() + $offset;
77
+            $this->limit += $oldOffset - $offset;
78
+        }
79
+        else if ($whence === SEEK_SET) {
80
+            $this->limit += $this->stream_tell() - $offset;
81
+        } else {
82
+            $this->limit -= $offset;
83
+        }
84
+        // this wrapper needs to return "true" for success.
85
+        // the fseek call itself returns 0 on succeess
86
+        return fseek($this->source, $offset, $whence) === 0;
87
+    }
88 88
 
89
-	public function stream_read($count) {
90
-		$this->limit -= $count;
91
-		return fread($this->source, $count);
92
-	}
89
+    public function stream_read($count) {
90
+        $this->limit -= $count;
91
+        return fread($this->source, $count);
92
+    }
93 93
 
94
-	public function stream_write($data) {
95
-		$size = strlen($data);
96
-		if ($size > $this->limit) {
97
-			$data = substr($data, 0, $this->limit);
98
-			$size = $this->limit;
99
-		}
100
-		$this->limit -= $size;
101
-		return fwrite($this->source, $data);
102
-	}
94
+    public function stream_write($data) {
95
+        $size = strlen($data);
96
+        if ($size > $this->limit) {
97
+            $data = substr($data, 0, $this->limit);
98
+            $size = $this->limit;
99
+        }
100
+        $this->limit -= $size;
101
+        return fwrite($this->source, $data);
102
+    }
103 103
 }
Please login to merge, or discard this patch.
lib/private/Files/Config/LazyStorageMountInfo.php 1 patch
Indentation   +50 added lines, -50 removed lines patch added patch discarded remove patch
@@ -29,60 +29,60 @@
 block discarded – undo
29 29
 use OCP\IUser;
30 30
 
31 31
 class LazyStorageMountInfo extends CachedMountInfo {
32
-	/** @var IMountPoint */
33
-	private $mount;
32
+    /** @var IMountPoint */
33
+    private $mount;
34 34
 
35
-	/**
36
-	 * CachedMountInfo constructor.
37
-	 *
38
-	 * @param IUser $user
39
-	 * @param IMountPoint $mount
40
-	 */
41
-	public function __construct(IUser $user, IMountPoint $mount) {
42
-		$this->user = $user;
43
-		$this->mount = $mount;
44
-	}
35
+    /**
36
+     * CachedMountInfo constructor.
37
+     *
38
+     * @param IUser $user
39
+     * @param IMountPoint $mount
40
+     */
41
+    public function __construct(IUser $user, IMountPoint $mount) {
42
+        $this->user = $user;
43
+        $this->mount = $mount;
44
+    }
45 45
 
46
-	/**
47
-	 * @return int the numeric storage id of the mount
48
-	 */
49
-	public function getStorageId() {
50
-		if (!$this->storageId) {
51
-			$this->storageId = $this->mount->getNumericStorageId();
52
-		}
53
-		return parent::getStorageId();
54
-	}
46
+    /**
47
+     * @return int the numeric storage id of the mount
48
+     */
49
+    public function getStorageId() {
50
+        if (!$this->storageId) {
51
+            $this->storageId = $this->mount->getNumericStorageId();
52
+        }
53
+        return parent::getStorageId();
54
+    }
55 55
 
56
-	/**
57
-	 * @return int the fileid of the root of the mount
58
-	 */
59
-	public function getRootId() {
60
-		if (!$this->rootId) {
61
-			$this->rootId = $this->mount->getStorageRootId();
62
-		}
63
-		return parent::getRootId();
64
-	}
56
+    /**
57
+     * @return int the fileid of the root of the mount
58
+     */
59
+    public function getRootId() {
60
+        if (!$this->rootId) {
61
+            $this->rootId = $this->mount->getStorageRootId();
62
+        }
63
+        return parent::getRootId();
64
+    }
65 65
 
66
-	/**
67
-	 * @return string the mount point of the mount for the user
68
-	 */
69
-	public function getMountPoint() {
70
-		if (!$this->mountPoint) {
71
-			$this->mountPoint = $this->mount->getMountPoint();
72
-		}
73
-		return parent::getMountPoint();
74
-	}
66
+    /**
67
+     * @return string the mount point of the mount for the user
68
+     */
69
+    public function getMountPoint() {
70
+        if (!$this->mountPoint) {
71
+            $this->mountPoint = $this->mount->getMountPoint();
72
+        }
73
+        return parent::getMountPoint();
74
+    }
75 75
 
76
-	public function getMountId() {
77
-		return $this->mount->getMountId();
78
-	}
76
+    public function getMountId() {
77
+        return $this->mount->getMountId();
78
+    }
79 79
 
80
-	/**
81
-	 * Get the internal path (within the storage) of the root of the mount
82
-	 *
83
-	 * @return string
84
-	 */
85
-	public function getRootInternalPath() {
86
-		return $this->mount->getInternalPath($this->mount->getMountPoint());
87
-	}
80
+    /**
81
+     * Get the internal path (within the storage) of the root of the mount
82
+     *
83
+     * @return string
84
+     */
85
+    public function getRootInternalPath() {
86
+        return $this->mount->getInternalPath($this->mount->getMountPoint());
87
+    }
88 88
 }
Please login to merge, or discard this patch.
lib/private/Files/Config/UserMountCacheListener.php 1 patch
Indentation   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -29,21 +29,21 @@
 block discarded – undo
29 29
  * Listen to hooks and update the mount cache as needed
30 30
  */
31 31
 class UserMountCacheListener {
32
-	/**
33
-	 * @var IUserMountCache
34
-	 */
35
-	private $userMountCache;
32
+    /**
33
+     * @var IUserMountCache
34
+     */
35
+    private $userMountCache;
36 36
 
37
-	/**
38
-	 * UserMountCacheListener constructor.
39
-	 *
40
-	 * @param IUserMountCache $userMountCache
41
-	 */
42
-	public function __construct(IUserMountCache $userMountCache) {
43
-		$this->userMountCache = $userMountCache;
44
-	}
37
+    /**
38
+     * UserMountCacheListener constructor.
39
+     *
40
+     * @param IUserMountCache $userMountCache
41
+     */
42
+    public function __construct(IUserMountCache $userMountCache) {
43
+        $this->userMountCache = $userMountCache;
44
+    }
45 45
 
46
-	public function listen(Manager $manager) {
47
-		$manager->listen('\OC\User', 'postDelete', [$this->userMountCache, 'removeUserMounts']);
48
-	}
46
+    public function listen(Manager $manager) {
47
+        $manager->listen('\OC\User', 'postDelete', [$this->userMountCache, 'removeUserMounts']);
48
+    }
49 49
 }
Please login to merge, or discard this patch.
lib/private/Files/Config/CachedMountInfo.php 1 patch
Indentation   +110 added lines, -110 removed lines patch added patch discarded remove patch
@@ -28,114 +28,114 @@
 block discarded – undo
28 28
 use OCP\IUser;
29 29
 
30 30
 class CachedMountInfo implements ICachedMountInfo {
31
-	/**
32
-	 * @var IUser
33
-	 */
34
-	protected $user;
35
-
36
-	/**
37
-	 * @var int
38
-	 */
39
-	protected $storageId;
40
-
41
-	/**
42
-	 * @var int
43
-	 */
44
-	protected $rootId;
45
-
46
-	/**
47
-	 * @var string
48
-	 */
49
-	protected $mountPoint;
50
-
51
-	/**
52
-	 * @var int|null
53
-	 */
54
-	protected $mountId;
55
-
56
-	/**
57
-	 * @var string
58
-	 */
59
-	protected $rootInternalPath;
60
-
61
-	/**
62
-	 * CachedMountInfo constructor.
63
-	 *
64
-	 * @param IUser $user
65
-	 * @param int $storageId
66
-	 * @param int $rootId
67
-	 * @param string $mountPoint
68
-	 * @param int|null $mountId
69
-	 * @param string $rootInternalPath
70
-	 */
71
-	public function __construct(IUser $user, $storageId, $rootId, $mountPoint, $mountId = null, $rootInternalPath = '') {
72
-		$this->user = $user;
73
-		$this->storageId = $storageId;
74
-		$this->rootId = $rootId;
75
-		$this->mountPoint = $mountPoint;
76
-		$this->mountId = $mountId;
77
-		$this->rootInternalPath = $rootInternalPath;
78
-	}
79
-
80
-	/**
81
-	 * @return IUser
82
-	 */
83
-	public function getUser() {
84
-		return $this->user;
85
-	}
86
-
87
-	/**
88
-	 * @return int the numeric storage id of the mount
89
-	 */
90
-	public function getStorageId() {
91
-		return $this->storageId;
92
-	}
93
-
94
-	/**
95
-	 * @return int the fileid of the root of the mount
96
-	 */
97
-	public function getRootId() {
98
-		return $this->rootId;
99
-	}
100
-
101
-	/**
102
-	 * @return Node the root node of the mount
103
-	 */
104
-	public function getMountPointNode() {
105
-		// TODO injection etc
106
-		Filesystem::initMountPoints($this->getUser()->getUID());
107
-		$userNode = \OC::$server->getUserFolder($this->getUser()->getUID());
108
-		$nodes = $userNode->getParent()->getById($this->getRootId());
109
-		if (count($nodes) > 0) {
110
-			return $nodes[0];
111
-		} else {
112
-			return null;
113
-		}
114
-	}
115
-
116
-	/**
117
-	 * @return string the mount point of the mount for the user
118
-	 */
119
-	public function getMountPoint() {
120
-		return $this->mountPoint;
121
-	}
122
-
123
-	/**
124
-	 * Get the id of the configured mount
125
-	 *
126
-	 * @return int|null mount id or null if not applicable
127
-	 * @since 9.1.0
128
-	 */
129
-	public function getMountId() {
130
-		return $this->mountId;
131
-	}
132
-
133
-	/**
134
-	 * Get the internal path (within the storage) of the root of the mount
135
-	 *
136
-	 * @return string
137
-	 */
138
-	public function getRootInternalPath() {
139
-		return $this->rootInternalPath;
140
-	}
31
+    /**
32
+     * @var IUser
33
+     */
34
+    protected $user;
35
+
36
+    /**
37
+     * @var int
38
+     */
39
+    protected $storageId;
40
+
41
+    /**
42
+     * @var int
43
+     */
44
+    protected $rootId;
45
+
46
+    /**
47
+     * @var string
48
+     */
49
+    protected $mountPoint;
50
+
51
+    /**
52
+     * @var int|null
53
+     */
54
+    protected $mountId;
55
+
56
+    /**
57
+     * @var string
58
+     */
59
+    protected $rootInternalPath;
60
+
61
+    /**
62
+     * CachedMountInfo constructor.
63
+     *
64
+     * @param IUser $user
65
+     * @param int $storageId
66
+     * @param int $rootId
67
+     * @param string $mountPoint
68
+     * @param int|null $mountId
69
+     * @param string $rootInternalPath
70
+     */
71
+    public function __construct(IUser $user, $storageId, $rootId, $mountPoint, $mountId = null, $rootInternalPath = '') {
72
+        $this->user = $user;
73
+        $this->storageId = $storageId;
74
+        $this->rootId = $rootId;
75
+        $this->mountPoint = $mountPoint;
76
+        $this->mountId = $mountId;
77
+        $this->rootInternalPath = $rootInternalPath;
78
+    }
79
+
80
+    /**
81
+     * @return IUser
82
+     */
83
+    public function getUser() {
84
+        return $this->user;
85
+    }
86
+
87
+    /**
88
+     * @return int the numeric storage id of the mount
89
+     */
90
+    public function getStorageId() {
91
+        return $this->storageId;
92
+    }
93
+
94
+    /**
95
+     * @return int the fileid of the root of the mount
96
+     */
97
+    public function getRootId() {
98
+        return $this->rootId;
99
+    }
100
+
101
+    /**
102
+     * @return Node the root node of the mount
103
+     */
104
+    public function getMountPointNode() {
105
+        // TODO injection etc
106
+        Filesystem::initMountPoints($this->getUser()->getUID());
107
+        $userNode = \OC::$server->getUserFolder($this->getUser()->getUID());
108
+        $nodes = $userNode->getParent()->getById($this->getRootId());
109
+        if (count($nodes) > 0) {
110
+            return $nodes[0];
111
+        } else {
112
+            return null;
113
+        }
114
+    }
115
+
116
+    /**
117
+     * @return string the mount point of the mount for the user
118
+     */
119
+    public function getMountPoint() {
120
+        return $this->mountPoint;
121
+    }
122
+
123
+    /**
124
+     * Get the id of the configured mount
125
+     *
126
+     * @return int|null mount id or null if not applicable
127
+     * @since 9.1.0
128
+     */
129
+    public function getMountId() {
130
+        return $this->mountId;
131
+    }
132
+
133
+    /**
134
+     * Get the internal path (within the storage) of the root of the mount
135
+     *
136
+     * @return string
137
+     */
138
+    public function getRootInternalPath() {
139
+        return $this->rootInternalPath;
140
+    }
141 141
 }
Please login to merge, or discard this patch.
lib/private/Files/ObjectStore/Mapper.php 2 patches
Indentation   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -31,25 +31,25 @@
 block discarded – undo
31 31
  * Map a user to a bucket.
32 32
  */
33 33
 class Mapper {
34
-	/** @var IUser */
35
-	private $user;
34
+    /** @var IUser */
35
+    private $user;
36 36
 
37
-	/**
38
-	 * Mapper constructor.
39
-	 *
40
-	 * @param IUser $user
41
-	 */
42
-	public function __construct(IUser $user) {
43
-		$this->user = $user;
44
-	}
37
+    /**
38
+     * Mapper constructor.
39
+     *
40
+     * @param IUser $user
41
+     */
42
+    public function __construct(IUser $user) {
43
+        $this->user = $user;
44
+    }
45 45
 
46
-	/**
47
-	 * @param int $numBuckets
48
-	 * @return string
49
-	 */
50
-	public function getBucket($numBuckets = 64) {
51
-		$hash = md5($this->user->getUID());
52
-		$num = hexdec(substr($hash, 0, 4));
53
-		return (string)($num % $numBuckets);
54
-	}
46
+    /**
47
+     * @param int $numBuckets
48
+     * @return string
49
+     */
50
+    public function getBucket($numBuckets = 64) {
51
+        $hash = md5($this->user->getUID());
52
+        $num = hexdec(substr($hash, 0, 4));
53
+        return (string)($num % $numBuckets);
54
+    }
55 55
 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,6 +50,6 @@
 block discarded – undo
50 50
 	public function getBucket($numBuckets = 64) {
51 51
 		$hash = md5($this->user->getUID());
52 52
 		$num = hexdec(substr($hash, 0, 4));
53
-		return (string)($num % $numBuckets);
53
+		return (string) ($num % $numBuckets);
54 54
 	}
55 55
 }
Please login to merge, or discard this patch.
lib/private/Files/SimpleFS/SimpleFile.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 use OCP\Files\NotPermittedException;
27 27
 use OCP\Files\SimpleFS\ISimpleFile;
28 28
 
29
-class SimpleFile implements ISimpleFile  {
29
+class SimpleFile implements ISimpleFile {
30 30
 
31 31
 	/** @var File $file */
32 32
 	private $file;
Please login to merge, or discard this patch.
Indentation   +148 added lines, -148 removed lines patch added patch discarded remove patch
@@ -29,153 +29,153 @@
 block discarded – undo
29 29
 
30 30
 class SimpleFile implements ISimpleFile  {
31 31
 
32
-	/** @var File $file */
33
-	private $file;
34
-
35
-	/**
36
-	 * File constructor.
37
-	 *
38
-	 * @param File $file
39
-	 */
40
-	public function __construct(File $file) {
41
-		$this->file = $file;
42
-	}
43
-
44
-	/**
45
-	 * Get the name
46
-	 *
47
-	 * @return string
48
-	 */
49
-	public function getName() {
50
-		return $this->file->getName();
51
-	}
52
-
53
-	/**
54
-	 * Get the size in bytes
55
-	 *
56
-	 * @return int
57
-	 */
58
-	public function getSize() {
59
-		return $this->file->getSize();
60
-	}
61
-
62
-	/**
63
-	 * Get the ETag
64
-	 *
65
-	 * @return string
66
-	 */
67
-	public function getETag() {
68
-		return $this->file->getEtag();
69
-	}
70
-
71
-	/**
72
-	 * Get the last modification time
73
-	 *
74
-	 * @return int
75
-	 */
76
-	public function getMTime() {
77
-		return $this->file->getMTime();
78
-	}
79
-
80
-	/**
81
-	 * Get the content
82
-	 *
83
-	 * @throws NotPermittedException
84
-	 * @throws NotFoundException
85
-	 * @return string
86
-	 */
87
-	public function getContent() {
88
-		$result = $this->file->getContent();
89
-
90
-		if ($result === false) {
91
-			$this->checkFile();
92
-		}
93
-
94
-		return $result;
95
-	}
96
-
97
-	/**
98
-	 * Overwrite the file
99
-	 *
100
-	 * @param string|resource $data
101
-	 * @throws NotPermittedException
102
-	 * @throws NotFoundException
103
-	 */
104
-	public function putContent($data) {
105
-		try {
106
-			return $this->file->putContent($data);
107
-		} catch (NotFoundException $e) {
108
-			$this->checkFile();
109
-		}
110
-	}
111
-
112
-	/**
113
-	 * Sometimes there are some issues with the AppData. Most of them are from
114
-	 * user error. But we should handle them gracefull anyway.
115
-	 *
116
-	 * If for some reason the current file can't be found. We remove it.
117
-	 * Then traverse up and check all folders if they exists. This so that the
118
-	 * next request will have a valid appdata structure again.
119
-	 *
120
-	 * @throws NotFoundException
121
-	 */
122
-	private function checkFile() {
123
-		$cur = $this->file;
124
-
125
-		while ($cur->stat() === false) {
126
-			$parent = $cur->getParent();
127
-			try {
128
-				$cur->delete();
129
-			} catch (NotFoundException $e) {
130
-				// Just continue then
131
-			}
132
-			$cur = $parent;
133
-		}
134
-
135
-		if ($cur !== $this->file) {
136
-			throw new NotFoundException('File does not exist');
137
-		}
138
-	}
139
-
140
-
141
-	/**
142
-	 * Delete the file
143
-	 *
144
-	 * @throws NotPermittedException
145
-	 */
146
-	public function delete() {
147
-		$this->file->delete();
148
-	}
149
-
150
-	/**
151
-	 * Get the MimeType
152
-	 *
153
-	 * @return string
154
-	 */
155
-	public function getMimeType() {
156
-		return $this->file->getMimeType();
157
-	}
158
-
159
-	/**
160
-	 * Open the file as stream for reading, resulting resource can be operated as stream like the result from php's own fopen
161
-	 *
162
-	 * @return resource
163
-	 * @throws \OCP\Files\NotPermittedException
164
-	 * @since 14.0.0
165
-	 */
166
-	public function read() {
167
-		return $this->file->fopen('r');
168
-	}
169
-
170
-	/**
171
-	 * Open the file as stream for writing, resulting resource can be operated as stream like the result from php's own fopen
172
-	 *
173
-	 * @return resource
174
-	 * @throws \OCP\Files\NotPermittedException
175
-	 * @since 14.0.0
176
-	 */
177
-	public function write() {
178
-		return $this->file->fopen('w');
179
-	}
32
+    /** @var File $file */
33
+    private $file;
34
+
35
+    /**
36
+     * File constructor.
37
+     *
38
+     * @param File $file
39
+     */
40
+    public function __construct(File $file) {
41
+        $this->file = $file;
42
+    }
43
+
44
+    /**
45
+     * Get the name
46
+     *
47
+     * @return string
48
+     */
49
+    public function getName() {
50
+        return $this->file->getName();
51
+    }
52
+
53
+    /**
54
+     * Get the size in bytes
55
+     *
56
+     * @return int
57
+     */
58
+    public function getSize() {
59
+        return $this->file->getSize();
60
+    }
61
+
62
+    /**
63
+     * Get the ETag
64
+     *
65
+     * @return string
66
+     */
67
+    public function getETag() {
68
+        return $this->file->getEtag();
69
+    }
70
+
71
+    /**
72
+     * Get the last modification time
73
+     *
74
+     * @return int
75
+     */
76
+    public function getMTime() {
77
+        return $this->file->getMTime();
78
+    }
79
+
80
+    /**
81
+     * Get the content
82
+     *
83
+     * @throws NotPermittedException
84
+     * @throws NotFoundException
85
+     * @return string
86
+     */
87
+    public function getContent() {
88
+        $result = $this->file->getContent();
89
+
90
+        if ($result === false) {
91
+            $this->checkFile();
92
+        }
93
+
94
+        return $result;
95
+    }
96
+
97
+    /**
98
+     * Overwrite the file
99
+     *
100
+     * @param string|resource $data
101
+     * @throws NotPermittedException
102
+     * @throws NotFoundException
103
+     */
104
+    public function putContent($data) {
105
+        try {
106
+            return $this->file->putContent($data);
107
+        } catch (NotFoundException $e) {
108
+            $this->checkFile();
109
+        }
110
+    }
111
+
112
+    /**
113
+     * Sometimes there are some issues with the AppData. Most of them are from
114
+     * user error. But we should handle them gracefull anyway.
115
+     *
116
+     * If for some reason the current file can't be found. We remove it.
117
+     * Then traverse up and check all folders if they exists. This so that the
118
+     * next request will have a valid appdata structure again.
119
+     *
120
+     * @throws NotFoundException
121
+     */
122
+    private function checkFile() {
123
+        $cur = $this->file;
124
+
125
+        while ($cur->stat() === false) {
126
+            $parent = $cur->getParent();
127
+            try {
128
+                $cur->delete();
129
+            } catch (NotFoundException $e) {
130
+                // Just continue then
131
+            }
132
+            $cur = $parent;
133
+        }
134
+
135
+        if ($cur !== $this->file) {
136
+            throw new NotFoundException('File does not exist');
137
+        }
138
+    }
139
+
140
+
141
+    /**
142
+     * Delete the file
143
+     *
144
+     * @throws NotPermittedException
145
+     */
146
+    public function delete() {
147
+        $this->file->delete();
148
+    }
149
+
150
+    /**
151
+     * Get the MimeType
152
+     *
153
+     * @return string
154
+     */
155
+    public function getMimeType() {
156
+        return $this->file->getMimeType();
157
+    }
158
+
159
+    /**
160
+     * Open the file as stream for reading, resulting resource can be operated as stream like the result from php's own fopen
161
+     *
162
+     * @return resource
163
+     * @throws \OCP\Files\NotPermittedException
164
+     * @since 14.0.0
165
+     */
166
+    public function read() {
167
+        return $this->file->fopen('r');
168
+    }
169
+
170
+    /**
171
+     * Open the file as stream for writing, resulting resource can be operated as stream like the result from php's own fopen
172
+     *
173
+     * @return resource
174
+     * @throws \OCP\Files\NotPermittedException
175
+     * @since 14.0.0
176
+     */
177
+    public function write() {
178
+        return $this->file->fopen('w');
179
+    }
180 180
 
181 181
 }
Please login to merge, or discard this patch.
lib/private/Files/Storage/Wrapper/Encoding.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 				// no point in continuing if the section was not found, use original path
81 81
 				return $fullPath;
82 82
 			}
83
-			$path = $convertedPath . '/';
83
+			$path = $convertedPath.'/';
84 84
 		}
85 85
 		$path = rtrim($path, '/');
86 86
 		return $path;
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 	 * @return string|null original or converted path, or null if none of the forms was found
97 97
 	 */
98 98
 	private function findPathToUseLastSection($basePath, $lastSection) {
99
-		$fullPath = $basePath . $lastSection;
99
+		$fullPath = $basePath.$lastSection;
100 100
 		if ($lastSection === '' || $this->isAscii($lastSection) || $this->storage->file_exists($fullPath)) {
101 101
 			$this->namesCache[$fullPath] = $fullPath;
102 102
 			return $fullPath;
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 		} else {
109 109
 			$otherFormPath = \Normalizer::normalize($lastSection, \Normalizer::FORM_C);
110 110
 		}
111
-		$otherFullPath = $basePath . $otherFormPath;
111
+		$otherFullPath = $basePath.$otherFormPath;
112 112
 		if ($this->storage->file_exists($otherFullPath)) {
113 113
 			$this->namesCache[$fullPath] = $otherFullPath;
114 114
 			return $otherFullPath;
Please login to merge, or discard this patch.
Indentation   +498 added lines, -498 removed lines patch added patch discarded remove patch
@@ -34,502 +34,502 @@
 block discarded – undo
34 34
  */
35 35
 class Encoding extends Wrapper {
36 36
 
37
-	/**
38
-	 * @var ICache
39
-	 */
40
-	private $namesCache;
41
-
42
-	/**
43
-	 * @param array $parameters
44
-	 */
45
-	public function __construct($parameters) {
46
-		$this->storage = $parameters['storage'];
47
-		$this->namesCache = new CappedMemoryCache();
48
-	}
49
-
50
-	/**
51
-	 * Returns whether the given string is only made of ASCII characters
52
-	 *
53
-	 * @param string $str string
54
-	 *
55
-	 * @return bool true if the string is all ASCII, false otherwise
56
-	 */
57
-	private function isAscii($str) {
58
-		return (bool) !preg_match('/[\\x80-\\xff]+/', $str);
59
-	}
60
-
61
-	/**
62
-	 * Checks whether the given path exists in NFC or NFD form after checking
63
-	 * each form for each path section and returns the correct form.
64
-	 * If no existing path found, returns the path as it was given.
65
-	 *
66
-	 * @param string $fullPath path to check
67
-	 *
68
-	 * @return string original or converted path
69
-	 */
70
-	private function findPathToUse($fullPath) {
71
-		$cachedPath = $this->namesCache[$fullPath];
72
-		if ($cachedPath !== null) {
73
-			return $cachedPath;
74
-		}
75
-
76
-		$sections = explode('/', $fullPath);
77
-		$path = '';
78
-		foreach ($sections as $section) {
79
-			$convertedPath = $this->findPathToUseLastSection($path, $section);
80
-			if ($convertedPath === null) {
81
-				// no point in continuing if the section was not found, use original path
82
-				return $fullPath;
83
-			}
84
-			$path = $convertedPath . '/';
85
-		}
86
-		$path = rtrim($path, '/');
87
-		return $path;
88
-	}
89
-
90
-	/**
91
-	 * Checks whether the last path section of the given path exists in NFC or NFD form
92
-	 * and returns the correct form. If no existing path found, returns null.
93
-	 *
94
-	 * @param string $basePath base path to check
95
-	 * @param string $lastSection last section of the path to check for NFD/NFC variations
96
-	 *
97
-	 * @return string|null original or converted path, or null if none of the forms was found
98
-	 */
99
-	private function findPathToUseLastSection($basePath, $lastSection) {
100
-		$fullPath = $basePath . $lastSection;
101
-		if ($lastSection === '' || $this->isAscii($lastSection) || $this->storage->file_exists($fullPath)) {
102
-			$this->namesCache[$fullPath] = $fullPath;
103
-			return $fullPath;
104
-		}
105
-
106
-		// swap encoding
107
-		if (\Normalizer::isNormalized($lastSection, \Normalizer::FORM_C)) {
108
-			$otherFormPath = \Normalizer::normalize($lastSection, \Normalizer::FORM_D);
109
-		} else {
110
-			$otherFormPath = \Normalizer::normalize($lastSection, \Normalizer::FORM_C);
111
-		}
112
-		$otherFullPath = $basePath . $otherFormPath;
113
-		if ($this->storage->file_exists($otherFullPath)) {
114
-			$this->namesCache[$fullPath] = $otherFullPath;
115
-			return $otherFullPath;
116
-		}
117
-
118
-		// return original path, file did not exist at all
119
-		$this->namesCache[$fullPath] = $fullPath;
120
-		return null;
121
-	}
122
-
123
-	/**
124
-	 * see http://php.net/manual/en/function.mkdir.php
125
-	 *
126
-	 * @param string $path
127
-	 * @return bool
128
-	 */
129
-	public function mkdir($path) {
130
-		// note: no conversion here, method should not be called with non-NFC names!
131
-		$result = $this->storage->mkdir($path);
132
-		if ($result) {
133
-			$this->namesCache[$path] = $path;
134
-		}
135
-		return $result;
136
-	}
137
-
138
-	/**
139
-	 * see http://php.net/manual/en/function.rmdir.php
140
-	 *
141
-	 * @param string $path
142
-	 * @return bool
143
-	 */
144
-	public function rmdir($path) {
145
-		$result = $this->storage->rmdir($this->findPathToUse($path));
146
-		if ($result) {
147
-			unset($this->namesCache[$path]);
148
-		}
149
-		return $result;
150
-	}
151
-
152
-	/**
153
-	 * see http://php.net/manual/en/function.opendir.php
154
-	 *
155
-	 * @param string $path
156
-	 * @return resource
157
-	 */
158
-	public function opendir($path) {
159
-		return $this->storage->opendir($this->findPathToUse($path));
160
-	}
161
-
162
-	/**
163
-	 * see http://php.net/manual/en/function.is_dir.php
164
-	 *
165
-	 * @param string $path
166
-	 * @return bool
167
-	 */
168
-	public function is_dir($path) {
169
-		return $this->storage->is_dir($this->findPathToUse($path));
170
-	}
171
-
172
-	/**
173
-	 * see http://php.net/manual/en/function.is_file.php
174
-	 *
175
-	 * @param string $path
176
-	 * @return bool
177
-	 */
178
-	public function is_file($path) {
179
-		return $this->storage->is_file($this->findPathToUse($path));
180
-	}
181
-
182
-	/**
183
-	 * see http://php.net/manual/en/function.stat.php
184
-	 * only the following keys are required in the result: size and mtime
185
-	 *
186
-	 * @param string $path
187
-	 * @return array
188
-	 */
189
-	public function stat($path) {
190
-		return $this->storage->stat($this->findPathToUse($path));
191
-	}
192
-
193
-	/**
194
-	 * see http://php.net/manual/en/function.filetype.php
195
-	 *
196
-	 * @param string $path
197
-	 * @return bool
198
-	 */
199
-	public function filetype($path) {
200
-		return $this->storage->filetype($this->findPathToUse($path));
201
-	}
202
-
203
-	/**
204
-	 * see http://php.net/manual/en/function.filesize.php
205
-	 * The result for filesize when called on a folder is required to be 0
206
-	 *
207
-	 * @param string $path
208
-	 * @return int
209
-	 */
210
-	public function filesize($path) {
211
-		return $this->storage->filesize($this->findPathToUse($path));
212
-	}
213
-
214
-	/**
215
-	 * check if a file can be created in $path
216
-	 *
217
-	 * @param string $path
218
-	 * @return bool
219
-	 */
220
-	public function isCreatable($path) {
221
-		return $this->storage->isCreatable($this->findPathToUse($path));
222
-	}
223
-
224
-	/**
225
-	 * check if a file can be read
226
-	 *
227
-	 * @param string $path
228
-	 * @return bool
229
-	 */
230
-	public function isReadable($path) {
231
-		return $this->storage->isReadable($this->findPathToUse($path));
232
-	}
233
-
234
-	/**
235
-	 * check if a file can be written to
236
-	 *
237
-	 * @param string $path
238
-	 * @return bool
239
-	 */
240
-	public function isUpdatable($path) {
241
-		return $this->storage->isUpdatable($this->findPathToUse($path));
242
-	}
243
-
244
-	/**
245
-	 * check if a file can be deleted
246
-	 *
247
-	 * @param string $path
248
-	 * @return bool
249
-	 */
250
-	public function isDeletable($path) {
251
-		return $this->storage->isDeletable($this->findPathToUse($path));
252
-	}
253
-
254
-	/**
255
-	 * check if a file can be shared
256
-	 *
257
-	 * @param string $path
258
-	 * @return bool
259
-	 */
260
-	public function isSharable($path) {
261
-		return $this->storage->isSharable($this->findPathToUse($path));
262
-	}
263
-
264
-	/**
265
-	 * get the full permissions of a path.
266
-	 * Should return a combination of the PERMISSION_ constants defined in lib/public/constants.php
267
-	 *
268
-	 * @param string $path
269
-	 * @return int
270
-	 */
271
-	public function getPermissions($path) {
272
-		return $this->storage->getPermissions($this->findPathToUse($path));
273
-	}
274
-
275
-	/**
276
-	 * see http://php.net/manual/en/function.file_exists.php
277
-	 *
278
-	 * @param string $path
279
-	 * @return bool
280
-	 */
281
-	public function file_exists($path) {
282
-		return $this->storage->file_exists($this->findPathToUse($path));
283
-	}
284
-
285
-	/**
286
-	 * see http://php.net/manual/en/function.filemtime.php
287
-	 *
288
-	 * @param string $path
289
-	 * @return int
290
-	 */
291
-	public function filemtime($path) {
292
-		return $this->storage->filemtime($this->findPathToUse($path));
293
-	}
294
-
295
-	/**
296
-	 * see http://php.net/manual/en/function.file_get_contents.php
297
-	 *
298
-	 * @param string $path
299
-	 * @return string
300
-	 */
301
-	public function file_get_contents($path) {
302
-		return $this->storage->file_get_contents($this->findPathToUse($path));
303
-	}
304
-
305
-	/**
306
-	 * see http://php.net/manual/en/function.file_put_contents.php
307
-	 *
308
-	 * @param string $path
309
-	 * @param string $data
310
-	 * @return bool
311
-	 */
312
-	public function file_put_contents($path, $data) {
313
-		return $this->storage->file_put_contents($this->findPathToUse($path), $data);
314
-	}
315
-
316
-	/**
317
-	 * see http://php.net/manual/en/function.unlink.php
318
-	 *
319
-	 * @param string $path
320
-	 * @return bool
321
-	 */
322
-	public function unlink($path) {
323
-		$result = $this->storage->unlink($this->findPathToUse($path));
324
-		if ($result) {
325
-			unset($this->namesCache[$path]);
326
-		}
327
-		return $result;
328
-	}
329
-
330
-	/**
331
-	 * see http://php.net/manual/en/function.rename.php
332
-	 *
333
-	 * @param string $path1
334
-	 * @param string $path2
335
-	 * @return bool
336
-	 */
337
-	public function rename($path1, $path2) {
338
-		// second name always NFC
339
-		return $this->storage->rename($this->findPathToUse($path1), $this->findPathToUse($path2));
340
-	}
341
-
342
-	/**
343
-	 * see http://php.net/manual/en/function.copy.php
344
-	 *
345
-	 * @param string $path1
346
-	 * @param string $path2
347
-	 * @return bool
348
-	 */
349
-	public function copy($path1, $path2) {
350
-		return $this->storage->copy($this->findPathToUse($path1), $this->findPathToUse($path2));
351
-	}
352
-
353
-	/**
354
-	 * see http://php.net/manual/en/function.fopen.php
355
-	 *
356
-	 * @param string $path
357
-	 * @param string $mode
358
-	 * @return resource
359
-	 */
360
-	public function fopen($path, $mode) {
361
-		$result = $this->storage->fopen($this->findPathToUse($path), $mode);
362
-		if ($result && $mode !== 'r' && $mode !== 'rb') {
363
-			unset($this->namesCache[$path]);
364
-		}
365
-		return $result;
366
-	}
367
-
368
-	/**
369
-	 * get the mimetype for a file or folder
370
-	 * The mimetype for a folder is required to be "httpd/unix-directory"
371
-	 *
372
-	 * @param string $path
373
-	 * @return string
374
-	 */
375
-	public function getMimeType($path) {
376
-		return $this->storage->getMimeType($this->findPathToUse($path));
377
-	}
378
-
379
-	/**
380
-	 * see http://php.net/manual/en/function.hash.php
381
-	 *
382
-	 * @param string $type
383
-	 * @param string $path
384
-	 * @param bool $raw
385
-	 * @return string
386
-	 */
387
-	public function hash($type, $path, $raw = false) {
388
-		return $this->storage->hash($type, $this->findPathToUse($path), $raw);
389
-	}
390
-
391
-	/**
392
-	 * see http://php.net/manual/en/function.free_space.php
393
-	 *
394
-	 * @param string $path
395
-	 * @return int
396
-	 */
397
-	public function free_space($path) {
398
-		return $this->storage->free_space($this->findPathToUse($path));
399
-	}
400
-
401
-	/**
402
-	 * search for occurrences of $query in file names
403
-	 *
404
-	 * @param string $query
405
-	 * @return array
406
-	 */
407
-	public function search($query) {
408
-		return $this->storage->search($query);
409
-	}
410
-
411
-	/**
412
-	 * see http://php.net/manual/en/function.touch.php
413
-	 * If the backend does not support the operation, false should be returned
414
-	 *
415
-	 * @param string $path
416
-	 * @param int $mtime
417
-	 * @return bool
418
-	 */
419
-	public function touch($path, $mtime = null) {
420
-		return $this->storage->touch($this->findPathToUse($path), $mtime);
421
-	}
422
-
423
-	/**
424
-	 * get the path to a local version of the file.
425
-	 * The local version of the file can be temporary and doesn't have to be persistent across requests
426
-	 *
427
-	 * @param string $path
428
-	 * @return string
429
-	 */
430
-	public function getLocalFile($path) {
431
-		return $this->storage->getLocalFile($this->findPathToUse($path));
432
-	}
433
-
434
-	/**
435
-	 * check if a file or folder has been updated since $time
436
-	 *
437
-	 * @param string $path
438
-	 * @param int $time
439
-	 * @return bool
440
-	 *
441
-	 * hasUpdated for folders should return at least true if a file inside the folder is add, removed or renamed.
442
-	 * returning true for other changes in the folder is optional
443
-	 */
444
-	public function hasUpdated($path, $time) {
445
-		return $this->storage->hasUpdated($this->findPathToUse($path), $time);
446
-	}
447
-
448
-	/**
449
-	 * get a cache instance for the storage
450
-	 *
451
-	 * @param string $path
452
-	 * @param \OC\Files\Storage\Storage (optional) the storage to pass to the cache
453
-	 * @return \OC\Files\Cache\Cache
454
-	 */
455
-	public function getCache($path = '', $storage = null) {
456
-		if (!$storage) {
457
-			$storage = $this;
458
-		}
459
-		return $this->storage->getCache($this->findPathToUse($path), $storage);
460
-	}
461
-
462
-	/**
463
-	 * get a scanner instance for the storage
464
-	 *
465
-	 * @param string $path
466
-	 * @param \OC\Files\Storage\Storage (optional) the storage to pass to the scanner
467
-	 * @return \OC\Files\Cache\Scanner
468
-	 */
469
-	public function getScanner($path = '', $storage = null) {
470
-		if (!$storage) {
471
-			$storage = $this;
472
-		}
473
-		return $this->storage->getScanner($this->findPathToUse($path), $storage);
474
-	}
475
-
476
-	/**
477
-	 * get the ETag for a file or folder
478
-	 *
479
-	 * @param string $path
480
-	 * @return string
481
-	 */
482
-	public function getETag($path) {
483
-		return $this->storage->getETag($this->findPathToUse($path));
484
-	}
485
-
486
-	/**
487
-	 * @param IStorage $sourceStorage
488
-	 * @param string $sourceInternalPath
489
-	 * @param string $targetInternalPath
490
-	 * @return bool
491
-	 */
492
-	public function copyFromStorage(IStorage $sourceStorage, $sourceInternalPath, $targetInternalPath) {
493
-		if ($sourceStorage === $this) {
494
-			return $this->copy($sourceInternalPath, $this->findPathToUse($targetInternalPath));
495
-		}
496
-
497
-		$result = $this->storage->copyFromStorage($sourceStorage, $sourceInternalPath, $this->findPathToUse($targetInternalPath));
498
-		if ($result) {
499
-			unset($this->namesCache[$targetInternalPath]);
500
-		}
501
-		return $result;
502
-	}
503
-
504
-	/**
505
-	 * @param IStorage $sourceStorage
506
-	 * @param string $sourceInternalPath
507
-	 * @param string $targetInternalPath
508
-	 * @return bool
509
-	 */
510
-	public function moveFromStorage(IStorage $sourceStorage, $sourceInternalPath, $targetInternalPath) {
511
-		if ($sourceStorage === $this) {
512
-			$result = $this->rename($sourceInternalPath, $this->findPathToUse($targetInternalPath));
513
-			if ($result) {
514
-				unset($this->namesCache[$sourceInternalPath]);
515
-				unset($this->namesCache[$targetInternalPath]);
516
-			}
517
-			return $result;
518
-		}
519
-
520
-		$result = $this->storage->moveFromStorage($sourceStorage, $sourceInternalPath, $this->findPathToUse($targetInternalPath));
521
-		if ($result) {
522
-			unset($this->namesCache[$sourceInternalPath]);
523
-			unset($this->namesCache[$targetInternalPath]);
524
-		}
525
-		return $result;
526
-	}
527
-
528
-	/**
529
-	 * @param string $path
530
-	 * @return array
531
-	 */
532
-	public function getMetaData($path) {
533
-		return $this->storage->getMetaData($this->findPathToUse($path));
534
-	}
37
+    /**
38
+     * @var ICache
39
+     */
40
+    private $namesCache;
41
+
42
+    /**
43
+     * @param array $parameters
44
+     */
45
+    public function __construct($parameters) {
46
+        $this->storage = $parameters['storage'];
47
+        $this->namesCache = new CappedMemoryCache();
48
+    }
49
+
50
+    /**
51
+     * Returns whether the given string is only made of ASCII characters
52
+     *
53
+     * @param string $str string
54
+     *
55
+     * @return bool true if the string is all ASCII, false otherwise
56
+     */
57
+    private function isAscii($str) {
58
+        return (bool) !preg_match('/[\\x80-\\xff]+/', $str);
59
+    }
60
+
61
+    /**
62
+     * Checks whether the given path exists in NFC or NFD form after checking
63
+     * each form for each path section and returns the correct form.
64
+     * If no existing path found, returns the path as it was given.
65
+     *
66
+     * @param string $fullPath path to check
67
+     *
68
+     * @return string original or converted path
69
+     */
70
+    private function findPathToUse($fullPath) {
71
+        $cachedPath = $this->namesCache[$fullPath];
72
+        if ($cachedPath !== null) {
73
+            return $cachedPath;
74
+        }
75
+
76
+        $sections = explode('/', $fullPath);
77
+        $path = '';
78
+        foreach ($sections as $section) {
79
+            $convertedPath = $this->findPathToUseLastSection($path, $section);
80
+            if ($convertedPath === null) {
81
+                // no point in continuing if the section was not found, use original path
82
+                return $fullPath;
83
+            }
84
+            $path = $convertedPath . '/';
85
+        }
86
+        $path = rtrim($path, '/');
87
+        return $path;
88
+    }
89
+
90
+    /**
91
+     * Checks whether the last path section of the given path exists in NFC or NFD form
92
+     * and returns the correct form. If no existing path found, returns null.
93
+     *
94
+     * @param string $basePath base path to check
95
+     * @param string $lastSection last section of the path to check for NFD/NFC variations
96
+     *
97
+     * @return string|null original or converted path, or null if none of the forms was found
98
+     */
99
+    private function findPathToUseLastSection($basePath, $lastSection) {
100
+        $fullPath = $basePath . $lastSection;
101
+        if ($lastSection === '' || $this->isAscii($lastSection) || $this->storage->file_exists($fullPath)) {
102
+            $this->namesCache[$fullPath] = $fullPath;
103
+            return $fullPath;
104
+        }
105
+
106
+        // swap encoding
107
+        if (\Normalizer::isNormalized($lastSection, \Normalizer::FORM_C)) {
108
+            $otherFormPath = \Normalizer::normalize($lastSection, \Normalizer::FORM_D);
109
+        } else {
110
+            $otherFormPath = \Normalizer::normalize($lastSection, \Normalizer::FORM_C);
111
+        }
112
+        $otherFullPath = $basePath . $otherFormPath;
113
+        if ($this->storage->file_exists($otherFullPath)) {
114
+            $this->namesCache[$fullPath] = $otherFullPath;
115
+            return $otherFullPath;
116
+        }
117
+
118
+        // return original path, file did not exist at all
119
+        $this->namesCache[$fullPath] = $fullPath;
120
+        return null;
121
+    }
122
+
123
+    /**
124
+     * see http://php.net/manual/en/function.mkdir.php
125
+     *
126
+     * @param string $path
127
+     * @return bool
128
+     */
129
+    public function mkdir($path) {
130
+        // note: no conversion here, method should not be called with non-NFC names!
131
+        $result = $this->storage->mkdir($path);
132
+        if ($result) {
133
+            $this->namesCache[$path] = $path;
134
+        }
135
+        return $result;
136
+    }
137
+
138
+    /**
139
+     * see http://php.net/manual/en/function.rmdir.php
140
+     *
141
+     * @param string $path
142
+     * @return bool
143
+     */
144
+    public function rmdir($path) {
145
+        $result = $this->storage->rmdir($this->findPathToUse($path));
146
+        if ($result) {
147
+            unset($this->namesCache[$path]);
148
+        }
149
+        return $result;
150
+    }
151
+
152
+    /**
153
+     * see http://php.net/manual/en/function.opendir.php
154
+     *
155
+     * @param string $path
156
+     * @return resource
157
+     */
158
+    public function opendir($path) {
159
+        return $this->storage->opendir($this->findPathToUse($path));
160
+    }
161
+
162
+    /**
163
+     * see http://php.net/manual/en/function.is_dir.php
164
+     *
165
+     * @param string $path
166
+     * @return bool
167
+     */
168
+    public function is_dir($path) {
169
+        return $this->storage->is_dir($this->findPathToUse($path));
170
+    }
171
+
172
+    /**
173
+     * see http://php.net/manual/en/function.is_file.php
174
+     *
175
+     * @param string $path
176
+     * @return bool
177
+     */
178
+    public function is_file($path) {
179
+        return $this->storage->is_file($this->findPathToUse($path));
180
+    }
181
+
182
+    /**
183
+     * see http://php.net/manual/en/function.stat.php
184
+     * only the following keys are required in the result: size and mtime
185
+     *
186
+     * @param string $path
187
+     * @return array
188
+     */
189
+    public function stat($path) {
190
+        return $this->storage->stat($this->findPathToUse($path));
191
+    }
192
+
193
+    /**
194
+     * see http://php.net/manual/en/function.filetype.php
195
+     *
196
+     * @param string $path
197
+     * @return bool
198
+     */
199
+    public function filetype($path) {
200
+        return $this->storage->filetype($this->findPathToUse($path));
201
+    }
202
+
203
+    /**
204
+     * see http://php.net/manual/en/function.filesize.php
205
+     * The result for filesize when called on a folder is required to be 0
206
+     *
207
+     * @param string $path
208
+     * @return int
209
+     */
210
+    public function filesize($path) {
211
+        return $this->storage->filesize($this->findPathToUse($path));
212
+    }
213
+
214
+    /**
215
+     * check if a file can be created in $path
216
+     *
217
+     * @param string $path
218
+     * @return bool
219
+     */
220
+    public function isCreatable($path) {
221
+        return $this->storage->isCreatable($this->findPathToUse($path));
222
+    }
223
+
224
+    /**
225
+     * check if a file can be read
226
+     *
227
+     * @param string $path
228
+     * @return bool
229
+     */
230
+    public function isReadable($path) {
231
+        return $this->storage->isReadable($this->findPathToUse($path));
232
+    }
233
+
234
+    /**
235
+     * check if a file can be written to
236
+     *
237
+     * @param string $path
238
+     * @return bool
239
+     */
240
+    public function isUpdatable($path) {
241
+        return $this->storage->isUpdatable($this->findPathToUse($path));
242
+    }
243
+
244
+    /**
245
+     * check if a file can be deleted
246
+     *
247
+     * @param string $path
248
+     * @return bool
249
+     */
250
+    public function isDeletable($path) {
251
+        return $this->storage->isDeletable($this->findPathToUse($path));
252
+    }
253
+
254
+    /**
255
+     * check if a file can be shared
256
+     *
257
+     * @param string $path
258
+     * @return bool
259
+     */
260
+    public function isSharable($path) {
261
+        return $this->storage->isSharable($this->findPathToUse($path));
262
+    }
263
+
264
+    /**
265
+     * get the full permissions of a path.
266
+     * Should return a combination of the PERMISSION_ constants defined in lib/public/constants.php
267
+     *
268
+     * @param string $path
269
+     * @return int
270
+     */
271
+    public function getPermissions($path) {
272
+        return $this->storage->getPermissions($this->findPathToUse($path));
273
+    }
274
+
275
+    /**
276
+     * see http://php.net/manual/en/function.file_exists.php
277
+     *
278
+     * @param string $path
279
+     * @return bool
280
+     */
281
+    public function file_exists($path) {
282
+        return $this->storage->file_exists($this->findPathToUse($path));
283
+    }
284
+
285
+    /**
286
+     * see http://php.net/manual/en/function.filemtime.php
287
+     *
288
+     * @param string $path
289
+     * @return int
290
+     */
291
+    public function filemtime($path) {
292
+        return $this->storage->filemtime($this->findPathToUse($path));
293
+    }
294
+
295
+    /**
296
+     * see http://php.net/manual/en/function.file_get_contents.php
297
+     *
298
+     * @param string $path
299
+     * @return string
300
+     */
301
+    public function file_get_contents($path) {
302
+        return $this->storage->file_get_contents($this->findPathToUse($path));
303
+    }
304
+
305
+    /**
306
+     * see http://php.net/manual/en/function.file_put_contents.php
307
+     *
308
+     * @param string $path
309
+     * @param string $data
310
+     * @return bool
311
+     */
312
+    public function file_put_contents($path, $data) {
313
+        return $this->storage->file_put_contents($this->findPathToUse($path), $data);
314
+    }
315
+
316
+    /**
317
+     * see http://php.net/manual/en/function.unlink.php
318
+     *
319
+     * @param string $path
320
+     * @return bool
321
+     */
322
+    public function unlink($path) {
323
+        $result = $this->storage->unlink($this->findPathToUse($path));
324
+        if ($result) {
325
+            unset($this->namesCache[$path]);
326
+        }
327
+        return $result;
328
+    }
329
+
330
+    /**
331
+     * see http://php.net/manual/en/function.rename.php
332
+     *
333
+     * @param string $path1
334
+     * @param string $path2
335
+     * @return bool
336
+     */
337
+    public function rename($path1, $path2) {
338
+        // second name always NFC
339
+        return $this->storage->rename($this->findPathToUse($path1), $this->findPathToUse($path2));
340
+    }
341
+
342
+    /**
343
+     * see http://php.net/manual/en/function.copy.php
344
+     *
345
+     * @param string $path1
346
+     * @param string $path2
347
+     * @return bool
348
+     */
349
+    public function copy($path1, $path2) {
350
+        return $this->storage->copy($this->findPathToUse($path1), $this->findPathToUse($path2));
351
+    }
352
+
353
+    /**
354
+     * see http://php.net/manual/en/function.fopen.php
355
+     *
356
+     * @param string $path
357
+     * @param string $mode
358
+     * @return resource
359
+     */
360
+    public function fopen($path, $mode) {
361
+        $result = $this->storage->fopen($this->findPathToUse($path), $mode);
362
+        if ($result && $mode !== 'r' && $mode !== 'rb') {
363
+            unset($this->namesCache[$path]);
364
+        }
365
+        return $result;
366
+    }
367
+
368
+    /**
369
+     * get the mimetype for a file or folder
370
+     * The mimetype for a folder is required to be "httpd/unix-directory"
371
+     *
372
+     * @param string $path
373
+     * @return string
374
+     */
375
+    public function getMimeType($path) {
376
+        return $this->storage->getMimeType($this->findPathToUse($path));
377
+    }
378
+
379
+    /**
380
+     * see http://php.net/manual/en/function.hash.php
381
+     *
382
+     * @param string $type
383
+     * @param string $path
384
+     * @param bool $raw
385
+     * @return string
386
+     */
387
+    public function hash($type, $path, $raw = false) {
388
+        return $this->storage->hash($type, $this->findPathToUse($path), $raw);
389
+    }
390
+
391
+    /**
392
+     * see http://php.net/manual/en/function.free_space.php
393
+     *
394
+     * @param string $path
395
+     * @return int
396
+     */
397
+    public function free_space($path) {
398
+        return $this->storage->free_space($this->findPathToUse($path));
399
+    }
400
+
401
+    /**
402
+     * search for occurrences of $query in file names
403
+     *
404
+     * @param string $query
405
+     * @return array
406
+     */
407
+    public function search($query) {
408
+        return $this->storage->search($query);
409
+    }
410
+
411
+    /**
412
+     * see http://php.net/manual/en/function.touch.php
413
+     * If the backend does not support the operation, false should be returned
414
+     *
415
+     * @param string $path
416
+     * @param int $mtime
417
+     * @return bool
418
+     */
419
+    public function touch($path, $mtime = null) {
420
+        return $this->storage->touch($this->findPathToUse($path), $mtime);
421
+    }
422
+
423
+    /**
424
+     * get the path to a local version of the file.
425
+     * The local version of the file can be temporary and doesn't have to be persistent across requests
426
+     *
427
+     * @param string $path
428
+     * @return string
429
+     */
430
+    public function getLocalFile($path) {
431
+        return $this->storage->getLocalFile($this->findPathToUse($path));
432
+    }
433
+
434
+    /**
435
+     * check if a file or folder has been updated since $time
436
+     *
437
+     * @param string $path
438
+     * @param int $time
439
+     * @return bool
440
+     *
441
+     * hasUpdated for folders should return at least true if a file inside the folder is add, removed or renamed.
442
+     * returning true for other changes in the folder is optional
443
+     */
444
+    public function hasUpdated($path, $time) {
445
+        return $this->storage->hasUpdated($this->findPathToUse($path), $time);
446
+    }
447
+
448
+    /**
449
+     * get a cache instance for the storage
450
+     *
451
+     * @param string $path
452
+     * @param \OC\Files\Storage\Storage (optional) the storage to pass to the cache
453
+     * @return \OC\Files\Cache\Cache
454
+     */
455
+    public function getCache($path = '', $storage = null) {
456
+        if (!$storage) {
457
+            $storage = $this;
458
+        }
459
+        return $this->storage->getCache($this->findPathToUse($path), $storage);
460
+    }
461
+
462
+    /**
463
+     * get a scanner instance for the storage
464
+     *
465
+     * @param string $path
466
+     * @param \OC\Files\Storage\Storage (optional) the storage to pass to the scanner
467
+     * @return \OC\Files\Cache\Scanner
468
+     */
469
+    public function getScanner($path = '', $storage = null) {
470
+        if (!$storage) {
471
+            $storage = $this;
472
+        }
473
+        return $this->storage->getScanner($this->findPathToUse($path), $storage);
474
+    }
475
+
476
+    /**
477
+     * get the ETag for a file or folder
478
+     *
479
+     * @param string $path
480
+     * @return string
481
+     */
482
+    public function getETag($path) {
483
+        return $this->storage->getETag($this->findPathToUse($path));
484
+    }
485
+
486
+    /**
487
+     * @param IStorage $sourceStorage
488
+     * @param string $sourceInternalPath
489
+     * @param string $targetInternalPath
490
+     * @return bool
491
+     */
492
+    public function copyFromStorage(IStorage $sourceStorage, $sourceInternalPath, $targetInternalPath) {
493
+        if ($sourceStorage === $this) {
494
+            return $this->copy($sourceInternalPath, $this->findPathToUse($targetInternalPath));
495
+        }
496
+
497
+        $result = $this->storage->copyFromStorage($sourceStorage, $sourceInternalPath, $this->findPathToUse($targetInternalPath));
498
+        if ($result) {
499
+            unset($this->namesCache[$targetInternalPath]);
500
+        }
501
+        return $result;
502
+    }
503
+
504
+    /**
505
+     * @param IStorage $sourceStorage
506
+     * @param string $sourceInternalPath
507
+     * @param string $targetInternalPath
508
+     * @return bool
509
+     */
510
+    public function moveFromStorage(IStorage $sourceStorage, $sourceInternalPath, $targetInternalPath) {
511
+        if ($sourceStorage === $this) {
512
+            $result = $this->rename($sourceInternalPath, $this->findPathToUse($targetInternalPath));
513
+            if ($result) {
514
+                unset($this->namesCache[$sourceInternalPath]);
515
+                unset($this->namesCache[$targetInternalPath]);
516
+            }
517
+            return $result;
518
+        }
519
+
520
+        $result = $this->storage->moveFromStorage($sourceStorage, $sourceInternalPath, $this->findPathToUse($targetInternalPath));
521
+        if ($result) {
522
+            unset($this->namesCache[$sourceInternalPath]);
523
+            unset($this->namesCache[$targetInternalPath]);
524
+        }
525
+        return $result;
526
+    }
527
+
528
+    /**
529
+     * @param string $path
530
+     * @return array
531
+     */
532
+    public function getMetaData($path) {
533
+        return $this->storage->getMetaData($this->findPathToUse($path));
534
+    }
535 535
 }
Please login to merge, or discard this patch.
lib/private/Files/Storage/DAV.php 3 patches
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -90,8 +90,11 @@
 block discarded – undo
90 90
 		if (isset($params['host']) && isset($params['user']) && isset($params['password'])) {
91 91
 			$host = $params['host'];
92 92
 			//remove leading http[s], will be generated in createBaseUri()
93
-			if (substr($host, 0, 8) == "https://") $host = substr($host, 8);
94
-			else if (substr($host, 0, 7) == "http://") $host = substr($host, 7);
93
+			if (substr($host, 0, 8) == "https://") {
94
+			    $host = substr($host, 8);
95
+			} else if (substr($host, 0, 7) == "http://") {
96
+			    $host = substr($host, 7);
97
+			}
95 98
 			$this->host = $host;
96 99
 			$this->user = $params['user'];
97 100
 			$this->password = $params['password'];
Please login to merge, or discard this patch.
Spacing   +36 added lines, -36 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 				if (is_string($params['secure'])) {
108 108
 					$this->secure = ($params['secure'] === 'true');
109 109
 				} else {
110
-					$this->secure = (bool)$params['secure'];
110
+					$this->secure = (bool) $params['secure'];
111 111
 				}
112 112
 			} else {
113 113
 				$this->secure = false;
@@ -120,8 +120,8 @@  discard block
 block discarded – undo
120 120
 				}
121 121
 			}
122 122
 			$this->root = $params['root'] ?? '/';
123
-			$this->root = '/' . ltrim($this->root, '/');
124
-			$this->root = rtrim($this->root, '/') . '/';
123
+			$this->root = '/'.ltrim($this->root, '/');
124
+			$this->root = rtrim($this->root, '/').'/';
125 125
 		} else {
126 126
 			throw new \Exception('Invalid webdav storage configuration');
127 127
 		}
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 		$this->client = new Client($settings);
151 151
 		$this->client->setThrowExceptions(true);
152 152
 
153
-		if($this->secure === true) {
153
+		if ($this->secure === true) {
154 154
 			$certPath = $this->certManager->getAbsoluteBundlePath();
155 155
 			if (file_exists($certPath)) {
156 156
 				$this->certPath = $certPath;
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 
171 171
 	/** {@inheritdoc} */
172 172
 	public function getId() {
173
-		return 'webdav::' . $this->user . '@' . $this->host . '/' . $this->root;
173
+		return 'webdav::'.$this->user.'@'.$this->host.'/'.$this->root;
174 174
 	}
175 175
 
176 176
 	/** {@inheritdoc} */
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 		if ($this->secure) {
180 180
 			$baseUri .= 's';
181 181
 		}
182
-		$baseUri .= '://' . $this->host . $this->root;
182
+		$baseUri .= '://'.$this->host.$this->root;
183 183
 		return $baseUri;
184 184
 	}
185 185
 
@@ -200,8 +200,8 @@  discard block
 block discarded – undo
200 200
 		$path = $this->cleanPath($path);
201 201
 		// FIXME: some WebDAV impl return 403 when trying to DELETE
202 202
 		// a non-empty folder
203
-		$result = $this->simpleResponse('DELETE', $path . '/', null, 204);
204
-		$this->statCache->clear($path . '/');
203
+		$result = $this->simpleResponse('DELETE', $path.'/', null, 204);
204
+		$this->statCache->clear($path.'/');
205 205
 		$this->statCache->remove($path);
206 206
 		return $result;
207 207
 	}
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
 				$this->statCache->set($path, $response);
277 277
 			} catch (ClientHttpException $e) {
278 278
 				if ($e->getHttpStatus() === 404 || $e->getHttpStatus() === 405) {
279
-					$this->statCache->clear($path . '/');
279
+					$this->statCache->clear($path.'/');
280 280
 					$this->statCache->set($path, false);
281 281
 					return false;
282 282
 				}
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
 		$this->init();
334 334
 		$path = $this->cleanPath($path);
335 335
 		$result = $this->simpleResponse('DELETE', $path, null, 204);
336
-		$this->statCache->clear($path . '/');
336
+		$this->statCache->clear($path.'/');
337 337
 		$this->statCache->remove($path);
338 338
 		return $result;
339 339
 	}
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
 				try {
349 349
 					$response = $this->httpClientService
350 350
 						->newClient()
351
-						->get($this->createBaseUri() . $this->encodePath($path), [
351
+						->get($this->createBaseUri().$this->encodePath($path), [
352 352
 							'auth' => [$this->user, $this->password],
353 353
 							'stream' => true
354 354
 						]);
@@ -365,7 +365,7 @@  discard block
 block discarded – undo
365 365
 					if ($response->getStatusCode() === Http::STATUS_LOCKED) {
366 366
 						throw new \OCP\Lock\LockedException($path);
367 367
 					} else {
368
-						Util::writeLog("webdav client", 'Guzzle get returned status code ' . $response->getStatusCode(), ILogger::ERROR);
368
+						Util::writeLog("webdav client", 'Guzzle get returned status code '.$response->getStatusCode(), ILogger::ERROR);
369 369
 					}
370 370
 				}
371 371
 
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
 					$tmpFile = $tempManager->getTemporaryFile($ext);
406 406
 				}
407 407
 				$handle = fopen($tmpFile, $mode);
408
-				return CallbackWrapper::wrap($handle, null, null, function () use ($path, $tmpFile) {
408
+				return CallbackWrapper::wrap($handle, null, null, function() use ($path, $tmpFile) {
409 409
 					$this->writeBack($tmpFile, $path);
410 410
 				});
411 411
 		}
@@ -430,7 +430,7 @@  discard block
 block discarded – undo
430 430
 				return FileInfo::SPACE_UNKNOWN;
431 431
 			}
432 432
 			if (isset($response['{DAV:}quota-available-bytes'])) {
433
-				return (int)$response['{DAV:}quota-available-bytes'];
433
+				return (int) $response['{DAV:}quota-available-bytes'];
434 434
 			} else {
435 435
 				return FileInfo::SPACE_UNKNOWN;
436 436
 			}
@@ -506,7 +506,7 @@  discard block
 block discarded – undo
506 506
 
507 507
 		$this->httpClientService
508 508
 			->newClient()
509
-			->put($this->createBaseUri() . $this->encodePath($target), [
509
+			->put($this->createBaseUri().$this->encodePath($target), [
510 510
 				'body' => $source,
511 511
 				'auth' => [$this->user, $this->password]
512 512
 			]);
@@ -523,18 +523,18 @@  discard block
 block discarded – undo
523 523
 			// overwrite directory ?
524 524
 			if ($this->is_dir($path2)) {
525 525
 				// needs trailing slash in destination
526
-				$path2 = rtrim($path2, '/') . '/';
526
+				$path2 = rtrim($path2, '/').'/';
527 527
 			}
528 528
 			$this->client->request(
529 529
 				'MOVE',
530 530
 				$this->encodePath($path1),
531 531
 				null,
532 532
 				[
533
-					'Destination' => $this->createBaseUri() . $this->encodePath($path2),
533
+					'Destination' => $this->createBaseUri().$this->encodePath($path2),
534 534
 				]
535 535
 			);
536
-			$this->statCache->clear($path1 . '/');
537
-			$this->statCache->clear($path2 . '/');
536
+			$this->statCache->clear($path1.'/');
537
+			$this->statCache->clear($path2.'/');
538 538
 			$this->statCache->set($path1, false);
539 539
 			$this->statCache->set($path2, true);
540 540
 			$this->removeCachedFile($path1);
@@ -555,17 +555,17 @@  discard block
 block discarded – undo
555 555
 			// overwrite directory ?
556 556
 			if ($this->is_dir($path2)) {
557 557
 				// needs trailing slash in destination
558
-				$path2 = rtrim($path2, '/') . '/';
558
+				$path2 = rtrim($path2, '/').'/';
559 559
 			}
560 560
 			$this->client->request(
561 561
 				'COPY',
562 562
 				$this->encodePath($path1),
563 563
 				null,
564 564
 				[
565
-					'Destination' => $this->createBaseUri() . $this->encodePath($path2),
565
+					'Destination' => $this->createBaseUri().$this->encodePath($path2),
566 566
 				]
567 567
 			);
568
-			$this->statCache->clear($path2 . '/');
568
+			$this->statCache->clear($path2.'/');
569 569
 			$this->statCache->set($path2, true);
570 570
 			$this->removeCachedFile($path2);
571 571
 			return true;
@@ -584,7 +584,7 @@  discard block
 block discarded – undo
584 584
 			}
585 585
 			return [
586 586
 				'mtime' => strtotime($response['{DAV:}getlastmodified']),
587
-				'size' => (int)isset($response['{DAV:}getcontentlength']) ? $response['{DAV:}getcontentlength'] : 0,
587
+				'size' => (int) isset($response['{DAV:}getcontentlength']) ? $response['{DAV:}getcontentlength'] : 0,
588 588
 			];
589 589
 		} catch (\Exception $e) {
590 590
 			$this->convertException($e, $path);
@@ -666,7 +666,7 @@  discard block
 block discarded – undo
666 666
 			return $response['statusCode'] == $expected;
667 667
 		} catch (ClientHttpException $e) {
668 668
 			if ($e->getHttpStatus() === 404 && $method === 'DELETE') {
669
-				$this->statCache->clear($path . '/');
669
+				$this->statCache->clear($path.'/');
670 670
 				$this->statCache->set($path, false);
671 671
 				return false;
672 672
 			}
@@ -687,22 +687,22 @@  discard block
 block discarded – undo
687 687
 
688 688
 	/** {@inheritdoc} */
689 689
 	public function isUpdatable($path) {
690
-		return (bool)($this->getPermissions($path) & Constants::PERMISSION_UPDATE);
690
+		return (bool) ($this->getPermissions($path) & Constants::PERMISSION_UPDATE);
691 691
 	}
692 692
 
693 693
 	/** {@inheritdoc} */
694 694
 	public function isCreatable($path) {
695
-		return (bool)($this->getPermissions($path) & Constants::PERMISSION_CREATE);
695
+		return (bool) ($this->getPermissions($path) & Constants::PERMISSION_CREATE);
696 696
 	}
697 697
 
698 698
 	/** {@inheritdoc} */
699 699
 	public function isSharable($path) {
700
-		return (bool)($this->getPermissions($path) & Constants::PERMISSION_SHARE);
700
+		return (bool) ($this->getPermissions($path) & Constants::PERMISSION_SHARE);
701 701
 	}
702 702
 
703 703
 	/** {@inheritdoc} */
704 704
 	public function isDeletable($path) {
705
-		return (bool)($this->getPermissions($path) & Constants::PERMISSION_DELETE);
705
+		return (bool) ($this->getPermissions($path) & Constants::PERMISSION_DELETE);
706 706
 	}
707 707
 
708 708
 	/** {@inheritdoc} */
@@ -795,7 +795,7 @@  discard block
 block discarded – undo
795 795
 				if (!empty($etag) && $cachedData['etag'] !== $etag) {
796 796
 					return true;
797 797
 				} else if (isset($response['{http://open-collaboration-services.org/ns}share-permissions'])) {
798
-					$sharePermissions = (int)$response['{http://open-collaboration-services.org/ns}share-permissions'];
798
+					$sharePermissions = (int) $response['{http://open-collaboration-services.org/ns}share-permissions'];
799 799
 					return $sharePermissions !== $cachedData['permissions'];
800 800
 				} else if (isset($response['{http://owncloud.org/ns}permissions'])) {
801 801
 					$permissions = $this->parsePermissions($response['{http://owncloud.org/ns}permissions']);
@@ -811,7 +811,7 @@  discard block
 block discarded – undo
811 811
 			if ($e->getHttpStatus() === 405) {
812 812
 				if ($path === '') {
813 813
 					// if root is gone it means the storage is not available
814
-					throw new StorageNotAvailableException(get_class($e) . ': ' . $e->getMessage());
814
+					throw new StorageNotAvailableException(get_class($e).': '.$e->getMessage());
815 815
 				}
816 816
 				return false;
817 817
 			}
@@ -846,22 +846,22 @@  discard block
 block discarded – undo
846 846
 			}
847 847
 			if ($e->getHttpStatus() === Http::STATUS_UNAUTHORIZED) {
848 848
 				// either password was changed or was invalid all along
849
-				throw new StorageInvalidException(get_class($e) . ': ' . $e->getMessage());
849
+				throw new StorageInvalidException(get_class($e).': '.$e->getMessage());
850 850
 			} else if ($e->getHttpStatus() === Http::STATUS_METHOD_NOT_ALLOWED) {
851 851
 				// ignore exception for MethodNotAllowed, false will be returned
852 852
 				return;
853
-			} else if ($e->getHttpStatus() === Http::STATUS_FORBIDDEN){
853
+			} else if ($e->getHttpStatus() === Http::STATUS_FORBIDDEN) {
854 854
 				// The operation is forbidden. Fail somewhat gracefully
855
-				throw new ForbiddenException(get_class($e) . ':' . $e->getMessage());
855
+				throw new ForbiddenException(get_class($e).':'.$e->getMessage());
856 856
 			}
857
-			throw new StorageNotAvailableException(get_class($e) . ': ' . $e->getMessage());
857
+			throw new StorageNotAvailableException(get_class($e).': '.$e->getMessage());
858 858
 		} else if ($e instanceof ClientException) {
859 859
 			// connection timeout or refused, server could be temporarily down
860
-			throw new StorageNotAvailableException(get_class($e) . ': ' . $e->getMessage());
860
+			throw new StorageNotAvailableException(get_class($e).': '.$e->getMessage());
861 861
 		} else if ($e instanceof \InvalidArgumentException) {
862 862
 			// parse error because the server returned HTML instead of XML,
863 863
 			// possibly temporarily down
864
-			throw new StorageNotAvailableException(get_class($e) . ': ' . $e->getMessage());
864
+			throw new StorageNotAvailableException(get_class($e).': '.$e->getMessage());
865 865
 		} else if (($e instanceof StorageNotAvailableException) || ($e instanceof StorageInvalidException)) {
866 866
 			// rethrow
867 867
 			throw $e;
Please login to merge, or discard this patch.
Indentation   +809 added lines, -809 removed lines patch added patch discarded remove patch
@@ -62,813 +62,813 @@
 block discarded – undo
62 62
  * @package OC\Files\Storage
63 63
  */
64 64
 class DAV extends Common {
65
-	/** @var string */
66
-	protected $password;
67
-	/** @var string */
68
-	protected $user;
69
-	/** @var string */
70
-	protected $authType;
71
-	/** @var string */
72
-	protected $host;
73
-	/** @var bool */
74
-	protected $secure;
75
-	/** @var string */
76
-	protected $root;
77
-	/** @var string */
78
-	protected $certPath;
79
-	/** @var bool */
80
-	protected $ready;
81
-	/** @var Client */
82
-	protected $client;
83
-	/** @var ArrayCache */
84
-	protected $statCache;
85
-	/** @var IClientService */
86
-	protected $httpClientService;
87
-	/** @var ICertificateManager */
88
-	protected $certManager;
89
-
90
-	/**
91
-	 * @param array $params
92
-	 * @throws \Exception
93
-	 */
94
-	public function __construct($params) {
95
-		$this->statCache = new ArrayCache();
96
-		$this->httpClientService = \OC::$server->getHTTPClientService();
97
-		if (isset($params['host']) && isset($params['user']) && isset($params['password'])) {
98
-			$host = $params['host'];
99
-			//remove leading http[s], will be generated in createBaseUri()
100
-			if (substr($host, 0, 8) == "https://") $host = substr($host, 8);
101
-			else if (substr($host, 0, 7) == "http://") $host = substr($host, 7);
102
-			$this->host = $host;
103
-			$this->user = $params['user'];
104
-			$this->password = $params['password'];
105
-			if (isset($params['authType'])) {
106
-				$this->authType = $params['authType'];
107
-			}
108
-			if (isset($params['secure'])) {
109
-				if (is_string($params['secure'])) {
110
-					$this->secure = ($params['secure'] === 'true');
111
-				} else {
112
-					$this->secure = (bool)$params['secure'];
113
-				}
114
-			} else {
115
-				$this->secure = false;
116
-			}
117
-			if ($this->secure === true) {
118
-				// inject mock for testing
119
-				$this->certManager = \OC::$server->getCertificateManager();
120
-				if (is_null($this->certManager)) { //no user
121
-					$this->certManager = \OC::$server->getCertificateManager(null);
122
-				}
123
-			}
124
-			$this->root = $params['root'] ?? '/';
125
-			$this->root = '/' . ltrim($this->root, '/');
126
-			$this->root = rtrim($this->root, '/') . '/';
127
-		} else {
128
-			throw new \Exception('Invalid webdav storage configuration');
129
-		}
130
-	}
131
-
132
-	protected function init() {
133
-		if ($this->ready) {
134
-			return;
135
-		}
136
-		$this->ready = true;
137
-
138
-		$settings = [
139
-			'baseUri' => $this->createBaseUri(),
140
-			'userName' => $this->user,
141
-			'password' => $this->password,
142
-		];
143
-		if (isset($this->authType)) {
144
-			$settings['authType'] = $this->authType;
145
-		}
146
-
147
-		$proxy = \OC::$server->getConfig()->getSystemValue('proxy', '');
148
-		if ($proxy !== '') {
149
-			$settings['proxy'] = $proxy;
150
-		}
151
-
152
-		$this->client = new Client($settings);
153
-		$this->client->setThrowExceptions(true);
154
-
155
-		if($this->secure === true) {
156
-			$certPath = $this->certManager->getAbsoluteBundlePath();
157
-			if (file_exists($certPath)) {
158
-				$this->certPath = $certPath;
159
-			}
160
-			if ($this->certPath) {
161
-				$this->client->addCurlSetting(CURLOPT_CAINFO, $this->certPath);
162
-			}
163
-		}
164
-	}
165
-
166
-	/**
167
-	 * Clear the stat cache
168
-	 */
169
-	public function clearStatCache() {
170
-		$this->statCache->clear();
171
-	}
172
-
173
-	/** {@inheritdoc} */
174
-	public function getId() {
175
-		return 'webdav::' . $this->user . '@' . $this->host . '/' . $this->root;
176
-	}
177
-
178
-	/** {@inheritdoc} */
179
-	public function createBaseUri() {
180
-		$baseUri = 'http';
181
-		if ($this->secure) {
182
-			$baseUri .= 's';
183
-		}
184
-		$baseUri .= '://' . $this->host . $this->root;
185
-		return $baseUri;
186
-	}
187
-
188
-	/** {@inheritdoc} */
189
-	public function mkdir($path) {
190
-		$this->init();
191
-		$path = $this->cleanPath($path);
192
-		$result = $this->simpleResponse('MKCOL', $path, null, 201);
193
-		if ($result) {
194
-			$this->statCache->set($path, true);
195
-		}
196
-		return $result;
197
-	}
198
-
199
-	/** {@inheritdoc} */
200
-	public function rmdir($path) {
201
-		$this->init();
202
-		$path = $this->cleanPath($path);
203
-		// FIXME: some WebDAV impl return 403 when trying to DELETE
204
-		// a non-empty folder
205
-		$result = $this->simpleResponse('DELETE', $path . '/', null, 204);
206
-		$this->statCache->clear($path . '/');
207
-		$this->statCache->remove($path);
208
-		return $result;
209
-	}
210
-
211
-	/** {@inheritdoc} */
212
-	public function opendir($path) {
213
-		$this->init();
214
-		$path = $this->cleanPath($path);
215
-		try {
216
-			$response = $this->client->propFind(
217
-				$this->encodePath($path),
218
-				['{DAV:}getetag'],
219
-				1
220
-			);
221
-			if ($response === false) {
222
-				return false;
223
-			}
224
-			$content = [];
225
-			$files = array_keys($response);
226
-			array_shift($files); //the first entry is the current directory
227
-
228
-			if (!$this->statCache->hasKey($path)) {
229
-				$this->statCache->set($path, true);
230
-			}
231
-			foreach ($files as $file) {
232
-				$file = urldecode($file);
233
-				// do not store the real entry, we might not have all properties
234
-				if (!$this->statCache->hasKey($path)) {
235
-					$this->statCache->set($file, true);
236
-				}
237
-				$file = basename($file);
238
-				$content[] = $file;
239
-			}
240
-			return IteratorDirectory::wrap($content);
241
-		} catch (\Exception $e) {
242
-			$this->convertException($e, $path);
243
-		}
244
-		return false;
245
-	}
246
-
247
-	/**
248
-	 * Propfind call with cache handling.
249
-	 *
250
-	 * First checks if information is cached.
251
-	 * If not, request it from the server then store to cache.
252
-	 *
253
-	 * @param string $path path to propfind
254
-	 *
255
-	 * @return array|boolean propfind response or false if the entry was not found
256
-	 *
257
-	 * @throws ClientHttpException
258
-	 */
259
-	protected function propfind($path) {
260
-		$path = $this->cleanPath($path);
261
-		$cachedResponse = $this->statCache->get($path);
262
-		// we either don't know it, or we know it exists but need more details
263
-		if (is_null($cachedResponse) || $cachedResponse === true) {
264
-			$this->init();
265
-			try {
266
-				$response = $this->client->propFind(
267
-					$this->encodePath($path),
268
-					[
269
-						'{DAV:}getlastmodified',
270
-						'{DAV:}getcontentlength',
271
-						'{DAV:}getcontenttype',
272
-						'{http://owncloud.org/ns}permissions',
273
-						'{http://open-collaboration-services.org/ns}share-permissions',
274
-						'{DAV:}resourcetype',
275
-						'{DAV:}getetag',
276
-					]
277
-				);
278
-				$this->statCache->set($path, $response);
279
-			} catch (ClientHttpException $e) {
280
-				if ($e->getHttpStatus() === 404 || $e->getHttpStatus() === 405) {
281
-					$this->statCache->clear($path . '/');
282
-					$this->statCache->set($path, false);
283
-					return false;
284
-				}
285
-				$this->convertException($e, $path);
286
-			} catch (\Exception $e) {
287
-				$this->convertException($e, $path);
288
-			}
289
-		} else {
290
-			$response = $cachedResponse;
291
-		}
292
-		return $response;
293
-	}
294
-
295
-	/** {@inheritdoc} */
296
-	public function filetype($path) {
297
-		try {
298
-			$response = $this->propfind($path);
299
-			if ($response === false) {
300
-				return false;
301
-			}
302
-			$responseType = [];
303
-			if (isset($response["{DAV:}resourcetype"])) {
304
-				/** @var ResourceType[] $response */
305
-				$responseType = $response["{DAV:}resourcetype"]->getValue();
306
-			}
307
-			return (count($responseType) > 0 and $responseType[0] == "{DAV:}collection") ? 'dir' : 'file';
308
-		} catch (\Exception $e) {
309
-			$this->convertException($e, $path);
310
-		}
311
-		return false;
312
-	}
313
-
314
-	/** {@inheritdoc} */
315
-	public function file_exists($path) {
316
-		try {
317
-			$path = $this->cleanPath($path);
318
-			$cachedState = $this->statCache->get($path);
319
-			if ($cachedState === false) {
320
-				// we know the file doesn't exist
321
-				return false;
322
-			} else if (!is_null($cachedState)) {
323
-				return true;
324
-			}
325
-			// need to get from server
326
-			return ($this->propfind($path) !== false);
327
-		} catch (\Exception $e) {
328
-			$this->convertException($e, $path);
329
-		}
330
-		return false;
331
-	}
332
-
333
-	/** {@inheritdoc} */
334
-	public function unlink($path) {
335
-		$this->init();
336
-		$path = $this->cleanPath($path);
337
-		$result = $this->simpleResponse('DELETE', $path, null, 204);
338
-		$this->statCache->clear($path . '/');
339
-		$this->statCache->remove($path);
340
-		return $result;
341
-	}
342
-
343
-	/** {@inheritdoc} */
344
-	public function fopen($path, $mode) {
345
-		$this->init();
346
-		$path = $this->cleanPath($path);
347
-		switch ($mode) {
348
-			case 'r':
349
-			case 'rb':
350
-				try {
351
-					$response = $this->httpClientService
352
-						->newClient()
353
-						->get($this->createBaseUri() . $this->encodePath($path), [
354
-							'auth' => [$this->user, $this->password],
355
-							'stream' => true
356
-						]);
357
-				} catch (\GuzzleHttp\Exception\ClientException $e) {
358
-					if ($e->getResponse() instanceof ResponseInterface
359
-						&& $e->getResponse()->getStatusCode() === 404) {
360
-						return false;
361
-					} else {
362
-						throw $e;
363
-					}
364
-				}
365
-
366
-				if ($response->getStatusCode() !== Http::STATUS_OK) {
367
-					if ($response->getStatusCode() === Http::STATUS_LOCKED) {
368
-						throw new \OCP\Lock\LockedException($path);
369
-					} else {
370
-						Util::writeLog("webdav client", 'Guzzle get returned status code ' . $response->getStatusCode(), ILogger::ERROR);
371
-					}
372
-				}
373
-
374
-				return $response->getBody();
375
-			case 'w':
376
-			case 'wb':
377
-			case 'a':
378
-			case 'ab':
379
-			case 'r+':
380
-			case 'w+':
381
-			case 'wb+':
382
-			case 'a+':
383
-			case 'x':
384
-			case 'x+':
385
-			case 'c':
386
-			case 'c+':
387
-				//emulate these
388
-				$tempManager = \OC::$server->getTempManager();
389
-				if (strrpos($path, '.') !== false) {
390
-					$ext = substr($path, strrpos($path, '.'));
391
-				} else {
392
-					$ext = '';
393
-				}
394
-				if ($this->file_exists($path)) {
395
-					if (!$this->isUpdatable($path)) {
396
-						return false;
397
-					}
398
-					if ($mode === 'w' or $mode === 'w+') {
399
-						$tmpFile = $tempManager->getTemporaryFile($ext);
400
-					} else {
401
-						$tmpFile = $this->getCachedFile($path);
402
-					}
403
-				} else {
404
-					if (!$this->isCreatable(dirname($path))) {
405
-						return false;
406
-					}
407
-					$tmpFile = $tempManager->getTemporaryFile($ext);
408
-				}
409
-				$handle = fopen($tmpFile, $mode);
410
-				return CallbackWrapper::wrap($handle, null, null, function () use ($path, $tmpFile) {
411
-					$this->writeBack($tmpFile, $path);
412
-				});
413
-		}
414
-	}
415
-
416
-	/**
417
-	 * @param string $tmpFile
418
-	 */
419
-	public function writeBack($tmpFile, $path) {
420
-		$this->uploadFile($tmpFile, $path);
421
-		unlink($tmpFile);
422
-	}
423
-
424
-	/** {@inheritdoc} */
425
-	public function free_space($path) {
426
-		$this->init();
427
-		$path = $this->cleanPath($path);
428
-		try {
429
-			// TODO: cacheable ?
430
-			$response = $this->client->propfind($this->encodePath($path), ['{DAV:}quota-available-bytes']);
431
-			if ($response === false) {
432
-				return FileInfo::SPACE_UNKNOWN;
433
-			}
434
-			if (isset($response['{DAV:}quota-available-bytes'])) {
435
-				return (int)$response['{DAV:}quota-available-bytes'];
436
-			} else {
437
-				return FileInfo::SPACE_UNKNOWN;
438
-			}
439
-		} catch (\Exception $e) {
440
-			return FileInfo::SPACE_UNKNOWN;
441
-		}
442
-	}
443
-
444
-	/** {@inheritdoc} */
445
-	public function touch($path, $mtime = null) {
446
-		$this->init();
447
-		if (is_null($mtime)) {
448
-			$mtime = time();
449
-		}
450
-		$path = $this->cleanPath($path);
451
-
452
-		// if file exists, update the mtime, else create a new empty file
453
-		if ($this->file_exists($path)) {
454
-			try {
455
-				$this->statCache->remove($path);
456
-				$this->client->proppatch($this->encodePath($path), ['{DAV:}lastmodified' => $mtime]);
457
-				// non-owncloud clients might not have accepted the property, need to recheck it
458
-				$response = $this->client->propfind($this->encodePath($path), ['{DAV:}getlastmodified'], 0);
459
-				if ($response === false) {
460
-					return false;
461
-				}
462
-				if (isset($response['{DAV:}getlastmodified'])) {
463
-					$remoteMtime = strtotime($response['{DAV:}getlastmodified']);
464
-					if ($remoteMtime !== $mtime) {
465
-						// server has not accepted the mtime
466
-						return false;
467
-					}
468
-				}
469
-			} catch (ClientHttpException $e) {
470
-				if ($e->getHttpStatus() === 501) {
471
-					return false;
472
-				}
473
-				$this->convertException($e, $path);
474
-				return false;
475
-			} catch (\Exception $e) {
476
-				$this->convertException($e, $path);
477
-				return false;
478
-			}
479
-		} else {
480
-			$this->file_put_contents($path, '');
481
-		}
482
-		return true;
483
-	}
484
-
485
-	/**
486
-	 * @param string $path
487
-	 * @param string $data
488
-	 * @return int
489
-	 */
490
-	public function file_put_contents($path, $data) {
491
-		$path = $this->cleanPath($path);
492
-		$result = parent::file_put_contents($path, $data);
493
-		$this->statCache->remove($path);
494
-		return $result;
495
-	}
496
-
497
-	/**
498
-	 * @param string $path
499
-	 * @param string $target
500
-	 */
501
-	protected function uploadFile($path, $target) {
502
-		$this->init();
503
-
504
-		// invalidate
505
-		$target = $this->cleanPath($target);
506
-		$this->statCache->remove($target);
507
-		$source = fopen($path, 'r');
508
-
509
-		$this->httpClientService
510
-			->newClient()
511
-			->put($this->createBaseUri() . $this->encodePath($target), [
512
-				'body' => $source,
513
-				'auth' => [$this->user, $this->password]
514
-			]);
515
-
516
-		$this->removeCachedFile($target);
517
-	}
518
-
519
-	/** {@inheritdoc} */
520
-	public function rename($path1, $path2) {
521
-		$this->init();
522
-		$path1 = $this->cleanPath($path1);
523
-		$path2 = $this->cleanPath($path2);
524
-		try {
525
-			// overwrite directory ?
526
-			if ($this->is_dir($path2)) {
527
-				// needs trailing slash in destination
528
-				$path2 = rtrim($path2, '/') . '/';
529
-			}
530
-			$this->client->request(
531
-				'MOVE',
532
-				$this->encodePath($path1),
533
-				null,
534
-				[
535
-					'Destination' => $this->createBaseUri() . $this->encodePath($path2),
536
-				]
537
-			);
538
-			$this->statCache->clear($path1 . '/');
539
-			$this->statCache->clear($path2 . '/');
540
-			$this->statCache->set($path1, false);
541
-			$this->statCache->set($path2, true);
542
-			$this->removeCachedFile($path1);
543
-			$this->removeCachedFile($path2);
544
-			return true;
545
-		} catch (\Exception $e) {
546
-			$this->convertException($e);
547
-		}
548
-		return false;
549
-	}
550
-
551
-	/** {@inheritdoc} */
552
-	public function copy($path1, $path2) {
553
-		$this->init();
554
-		$path1 = $this->cleanPath($path1);
555
-		$path2 = $this->cleanPath($path2);
556
-		try {
557
-			// overwrite directory ?
558
-			if ($this->is_dir($path2)) {
559
-				// needs trailing slash in destination
560
-				$path2 = rtrim($path2, '/') . '/';
561
-			}
562
-			$this->client->request(
563
-				'COPY',
564
-				$this->encodePath($path1),
565
-				null,
566
-				[
567
-					'Destination' => $this->createBaseUri() . $this->encodePath($path2),
568
-				]
569
-			);
570
-			$this->statCache->clear($path2 . '/');
571
-			$this->statCache->set($path2, true);
572
-			$this->removeCachedFile($path2);
573
-			return true;
574
-		} catch (\Exception $e) {
575
-			$this->convertException($e);
576
-		}
577
-		return false;
578
-	}
579
-
580
-	/** {@inheritdoc} */
581
-	public function stat($path) {
582
-		try {
583
-			$response = $this->propfind($path);
584
-			if (!$response) {
585
-				return false;
586
-			}
587
-			return [
588
-				'mtime' => strtotime($response['{DAV:}getlastmodified']),
589
-				'size' => (int)isset($response['{DAV:}getcontentlength']) ? $response['{DAV:}getcontentlength'] : 0,
590
-			];
591
-		} catch (\Exception $e) {
592
-			$this->convertException($e, $path);
593
-		}
594
-		return [];
595
-	}
596
-
597
-	/** {@inheritdoc} */
598
-	public function getMimeType($path) {
599
-		$remoteMimetype = $this->getMimeTypeFromRemote($path);
600
-		if ($remoteMimetype === 'application/octet-stream') {
601
-			return \OC::$server->getMimeTypeDetector()->detectPath($path);
602
-		} else {
603
-			return $remoteMimetype;
604
-		}
605
-	}
606
-
607
-	public function getMimeTypeFromRemote($path) {
608
-		try {
609
-			$response = $this->propfind($path);
610
-			if ($response === false) {
611
-				return false;
612
-			}
613
-			$responseType = [];
614
-			if (isset($response["{DAV:}resourcetype"])) {
615
-				/** @var ResourceType[] $response */
616
-				$responseType = $response["{DAV:}resourcetype"]->getValue();
617
-			}
618
-			$type = (count($responseType) > 0 and $responseType[0] == "{DAV:}collection") ? 'dir' : 'file';
619
-			if ($type == 'dir') {
620
-				return 'httpd/unix-directory';
621
-			} elseif (isset($response['{DAV:}getcontenttype'])) {
622
-				return $response['{DAV:}getcontenttype'];
623
-			} else {
624
-				return 'application/octet-stream';
625
-			}
626
-		} catch (\Exception $e) {
627
-			return false;
628
-		}
629
-	}
630
-
631
-	/**
632
-	 * @param string $path
633
-	 * @return string
634
-	 */
635
-	public function cleanPath($path) {
636
-		if ($path === '') {
637
-			return $path;
638
-		}
639
-		$path = Filesystem::normalizePath($path);
640
-		// remove leading slash
641
-		return substr($path, 1);
642
-	}
643
-
644
-	/**
645
-	 * URL encodes the given path but keeps the slashes
646
-	 *
647
-	 * @param string $path to encode
648
-	 * @return string encoded path
649
-	 */
650
-	protected function encodePath($path) {
651
-		// slashes need to stay
652
-		return str_replace('%2F', '/', rawurlencode($path));
653
-	}
654
-
655
-	/**
656
-	 * @param string $method
657
-	 * @param string $path
658
-	 * @param string|resource|null $body
659
-	 * @param int $expected
660
-	 * @return bool
661
-	 * @throws StorageInvalidException
662
-	 * @throws StorageNotAvailableException
663
-	 */
664
-	protected function simpleResponse($method, $path, $body, $expected) {
665
-		$path = $this->cleanPath($path);
666
-		try {
667
-			$response = $this->client->request($method, $this->encodePath($path), $body);
668
-			return $response['statusCode'] == $expected;
669
-		} catch (ClientHttpException $e) {
670
-			if ($e->getHttpStatus() === 404 && $method === 'DELETE') {
671
-				$this->statCache->clear($path . '/');
672
-				$this->statCache->set($path, false);
673
-				return false;
674
-			}
675
-
676
-			$this->convertException($e, $path);
677
-		} catch (\Exception $e) {
678
-			$this->convertException($e, $path);
679
-		}
680
-		return false;
681
-	}
682
-
683
-	/**
684
-	 * check if curl is installed
685
-	 */
686
-	public static function checkDependencies() {
687
-		return true;
688
-	}
689
-
690
-	/** {@inheritdoc} */
691
-	public function isUpdatable($path) {
692
-		return (bool)($this->getPermissions($path) & Constants::PERMISSION_UPDATE);
693
-	}
694
-
695
-	/** {@inheritdoc} */
696
-	public function isCreatable($path) {
697
-		return (bool)($this->getPermissions($path) & Constants::PERMISSION_CREATE);
698
-	}
699
-
700
-	/** {@inheritdoc} */
701
-	public function isSharable($path) {
702
-		return (bool)($this->getPermissions($path) & Constants::PERMISSION_SHARE);
703
-	}
704
-
705
-	/** {@inheritdoc} */
706
-	public function isDeletable($path) {
707
-		return (bool)($this->getPermissions($path) & Constants::PERMISSION_DELETE);
708
-	}
709
-
710
-	/** {@inheritdoc} */
711
-	public function getPermissions($path) {
712
-		$this->init();
713
-		$path = $this->cleanPath($path);
714
-		$response = $this->propfind($path);
715
-		if ($response === false) {
716
-			return 0;
717
-		}
718
-		if (isset($response['{http://owncloud.org/ns}permissions'])) {
719
-			return $this->parsePermissions($response['{http://owncloud.org/ns}permissions']);
720
-		} else if ($this->is_dir($path)) {
721
-			return Constants::PERMISSION_ALL;
722
-		} else if ($this->file_exists($path)) {
723
-			return Constants::PERMISSION_ALL - Constants::PERMISSION_CREATE;
724
-		} else {
725
-			return 0;
726
-		}
727
-	}
728
-
729
-	/** {@inheritdoc} */
730
-	public function getETag($path) {
731
-		$this->init();
732
-		$path = $this->cleanPath($path);
733
-		$response = $this->propfind($path);
734
-		if ($response === false) {
735
-			return null;
736
-		}
737
-		if (isset($response['{DAV:}getetag'])) {
738
-			$etag = trim($response['{DAV:}getetag'], '"');
739
-			if (strlen($etag) > 40) {
740
-				$etag = md5($etag);
741
-			}
742
-			return $etag;
743
-		}
744
-		return parent::getEtag($path);
745
-	}
746
-
747
-	/**
748
-	 * @param string $permissionsString
749
-	 * @return int
750
-	 */
751
-	protected function parsePermissions($permissionsString) {
752
-		$permissions = Constants::PERMISSION_READ;
753
-		if (strpos($permissionsString, 'R') !== false) {
754
-			$permissions |= Constants::PERMISSION_SHARE;
755
-		}
756
-		if (strpos($permissionsString, 'D') !== false) {
757
-			$permissions |= Constants::PERMISSION_DELETE;
758
-		}
759
-		if (strpos($permissionsString, 'W') !== false) {
760
-			$permissions |= Constants::PERMISSION_UPDATE;
761
-		}
762
-		if (strpos($permissionsString, 'CK') !== false) {
763
-			$permissions |= Constants::PERMISSION_CREATE;
764
-			$permissions |= Constants::PERMISSION_UPDATE;
765
-		}
766
-		return $permissions;
767
-	}
768
-
769
-	/**
770
-	 * check if a file or folder has been updated since $time
771
-	 *
772
-	 * @param string $path
773
-	 * @param int $time
774
-	 * @throws \OCP\Files\StorageNotAvailableException
775
-	 * @return bool
776
-	 */
777
-	public function hasUpdated($path, $time) {
778
-		$this->init();
779
-		$path = $this->cleanPath($path);
780
-		try {
781
-			// force refresh for $path
782
-			$this->statCache->remove($path);
783
-			$response = $this->propfind($path);
784
-			if ($response === false) {
785
-				if ($path === '') {
786
-					// if root is gone it means the storage is not available
787
-					throw new StorageNotAvailableException('root is gone');
788
-				}
789
-				return false;
790
-			}
791
-			if (isset($response['{DAV:}getetag'])) {
792
-				$cachedData = $this->getCache()->get($path);
793
-				$etag = null;
794
-				if (isset($response['{DAV:}getetag'])) {
795
-					$etag = trim($response['{DAV:}getetag'], '"');
796
-				}
797
-				if (!empty($etag) && $cachedData['etag'] !== $etag) {
798
-					return true;
799
-				} else if (isset($response['{http://open-collaboration-services.org/ns}share-permissions'])) {
800
-					$sharePermissions = (int)$response['{http://open-collaboration-services.org/ns}share-permissions'];
801
-					return $sharePermissions !== $cachedData['permissions'];
802
-				} else if (isset($response['{http://owncloud.org/ns}permissions'])) {
803
-					$permissions = $this->parsePermissions($response['{http://owncloud.org/ns}permissions']);
804
-					return $permissions !== $cachedData['permissions'];
805
-				} else {
806
-					return false;
807
-				}
808
-			} else {
809
-				$remoteMtime = strtotime($response['{DAV:}getlastmodified']);
810
-				return $remoteMtime > $time;
811
-			}
812
-		} catch (ClientHttpException $e) {
813
-			if ($e->getHttpStatus() === 405) {
814
-				if ($path === '') {
815
-					// if root is gone it means the storage is not available
816
-					throw new StorageNotAvailableException(get_class($e) . ': ' . $e->getMessage());
817
-				}
818
-				return false;
819
-			}
820
-			$this->convertException($e, $path);
821
-			return false;
822
-		} catch (\Exception $e) {
823
-			$this->convertException($e, $path);
824
-			return false;
825
-		}
826
-	}
827
-
828
-	/**
829
-	 * Interpret the given exception and decide whether it is due to an
830
-	 * unavailable storage, invalid storage or other.
831
-	 * This will either throw StorageInvalidException, StorageNotAvailableException
832
-	 * or do nothing.
833
-	 *
834
-	 * @param Exception $e sabre exception
835
-	 * @param string $path optional path from the operation
836
-	 *
837
-	 * @throws StorageInvalidException if the storage is invalid, for example
838
-	 * when the authentication expired or is invalid
839
-	 * @throws StorageNotAvailableException if the storage is not available,
840
-	 * which might be temporary
841
-	 * @throws ForbiddenException if the action is not allowed
842
-	 */
843
-	protected function convertException(Exception $e, $path = '') {
844
-		\OC::$server->getLogger()->logException($e, ['app' => 'files_external', 'level' => ILogger::DEBUG]);
845
-		if ($e instanceof ClientHttpException) {
846
-			if ($e->getHttpStatus() === Http::STATUS_LOCKED) {
847
-				throw new \OCP\Lock\LockedException($path);
848
-			}
849
-			if ($e->getHttpStatus() === Http::STATUS_UNAUTHORIZED) {
850
-				// either password was changed or was invalid all along
851
-				throw new StorageInvalidException(get_class($e) . ': ' . $e->getMessage());
852
-			} else if ($e->getHttpStatus() === Http::STATUS_METHOD_NOT_ALLOWED) {
853
-				// ignore exception for MethodNotAllowed, false will be returned
854
-				return;
855
-			} else if ($e->getHttpStatus() === Http::STATUS_FORBIDDEN){
856
-				// The operation is forbidden. Fail somewhat gracefully
857
-				throw new ForbiddenException(get_class($e) . ':' . $e->getMessage());
858
-			}
859
-			throw new StorageNotAvailableException(get_class($e) . ': ' . $e->getMessage());
860
-		} else if ($e instanceof ClientException) {
861
-			// connection timeout or refused, server could be temporarily down
862
-			throw new StorageNotAvailableException(get_class($e) . ': ' . $e->getMessage());
863
-		} else if ($e instanceof \InvalidArgumentException) {
864
-			// parse error because the server returned HTML instead of XML,
865
-			// possibly temporarily down
866
-			throw new StorageNotAvailableException(get_class($e) . ': ' . $e->getMessage());
867
-		} else if (($e instanceof StorageNotAvailableException) || ($e instanceof StorageInvalidException)) {
868
-			// rethrow
869
-			throw $e;
870
-		}
871
-
872
-		// TODO: only log for now, but in the future need to wrap/rethrow exception
873
-	}
65
+    /** @var string */
66
+    protected $password;
67
+    /** @var string */
68
+    protected $user;
69
+    /** @var string */
70
+    protected $authType;
71
+    /** @var string */
72
+    protected $host;
73
+    /** @var bool */
74
+    protected $secure;
75
+    /** @var string */
76
+    protected $root;
77
+    /** @var string */
78
+    protected $certPath;
79
+    /** @var bool */
80
+    protected $ready;
81
+    /** @var Client */
82
+    protected $client;
83
+    /** @var ArrayCache */
84
+    protected $statCache;
85
+    /** @var IClientService */
86
+    protected $httpClientService;
87
+    /** @var ICertificateManager */
88
+    protected $certManager;
89
+
90
+    /**
91
+     * @param array $params
92
+     * @throws \Exception
93
+     */
94
+    public function __construct($params) {
95
+        $this->statCache = new ArrayCache();
96
+        $this->httpClientService = \OC::$server->getHTTPClientService();
97
+        if (isset($params['host']) && isset($params['user']) && isset($params['password'])) {
98
+            $host = $params['host'];
99
+            //remove leading http[s], will be generated in createBaseUri()
100
+            if (substr($host, 0, 8) == "https://") $host = substr($host, 8);
101
+            else if (substr($host, 0, 7) == "http://") $host = substr($host, 7);
102
+            $this->host = $host;
103
+            $this->user = $params['user'];
104
+            $this->password = $params['password'];
105
+            if (isset($params['authType'])) {
106
+                $this->authType = $params['authType'];
107
+            }
108
+            if (isset($params['secure'])) {
109
+                if (is_string($params['secure'])) {
110
+                    $this->secure = ($params['secure'] === 'true');
111
+                } else {
112
+                    $this->secure = (bool)$params['secure'];
113
+                }
114
+            } else {
115
+                $this->secure = false;
116
+            }
117
+            if ($this->secure === true) {
118
+                // inject mock for testing
119
+                $this->certManager = \OC::$server->getCertificateManager();
120
+                if (is_null($this->certManager)) { //no user
121
+                    $this->certManager = \OC::$server->getCertificateManager(null);
122
+                }
123
+            }
124
+            $this->root = $params['root'] ?? '/';
125
+            $this->root = '/' . ltrim($this->root, '/');
126
+            $this->root = rtrim($this->root, '/') . '/';
127
+        } else {
128
+            throw new \Exception('Invalid webdav storage configuration');
129
+        }
130
+    }
131
+
132
+    protected function init() {
133
+        if ($this->ready) {
134
+            return;
135
+        }
136
+        $this->ready = true;
137
+
138
+        $settings = [
139
+            'baseUri' => $this->createBaseUri(),
140
+            'userName' => $this->user,
141
+            'password' => $this->password,
142
+        ];
143
+        if (isset($this->authType)) {
144
+            $settings['authType'] = $this->authType;
145
+        }
146
+
147
+        $proxy = \OC::$server->getConfig()->getSystemValue('proxy', '');
148
+        if ($proxy !== '') {
149
+            $settings['proxy'] = $proxy;
150
+        }
151
+
152
+        $this->client = new Client($settings);
153
+        $this->client->setThrowExceptions(true);
154
+
155
+        if($this->secure === true) {
156
+            $certPath = $this->certManager->getAbsoluteBundlePath();
157
+            if (file_exists($certPath)) {
158
+                $this->certPath = $certPath;
159
+            }
160
+            if ($this->certPath) {
161
+                $this->client->addCurlSetting(CURLOPT_CAINFO, $this->certPath);
162
+            }
163
+        }
164
+    }
165
+
166
+    /**
167
+     * Clear the stat cache
168
+     */
169
+    public function clearStatCache() {
170
+        $this->statCache->clear();
171
+    }
172
+
173
+    /** {@inheritdoc} */
174
+    public function getId() {
175
+        return 'webdav::' . $this->user . '@' . $this->host . '/' . $this->root;
176
+    }
177
+
178
+    /** {@inheritdoc} */
179
+    public function createBaseUri() {
180
+        $baseUri = 'http';
181
+        if ($this->secure) {
182
+            $baseUri .= 's';
183
+        }
184
+        $baseUri .= '://' . $this->host . $this->root;
185
+        return $baseUri;
186
+    }
187
+
188
+    /** {@inheritdoc} */
189
+    public function mkdir($path) {
190
+        $this->init();
191
+        $path = $this->cleanPath($path);
192
+        $result = $this->simpleResponse('MKCOL', $path, null, 201);
193
+        if ($result) {
194
+            $this->statCache->set($path, true);
195
+        }
196
+        return $result;
197
+    }
198
+
199
+    /** {@inheritdoc} */
200
+    public function rmdir($path) {
201
+        $this->init();
202
+        $path = $this->cleanPath($path);
203
+        // FIXME: some WebDAV impl return 403 when trying to DELETE
204
+        // a non-empty folder
205
+        $result = $this->simpleResponse('DELETE', $path . '/', null, 204);
206
+        $this->statCache->clear($path . '/');
207
+        $this->statCache->remove($path);
208
+        return $result;
209
+    }
210
+
211
+    /** {@inheritdoc} */
212
+    public function opendir($path) {
213
+        $this->init();
214
+        $path = $this->cleanPath($path);
215
+        try {
216
+            $response = $this->client->propFind(
217
+                $this->encodePath($path),
218
+                ['{DAV:}getetag'],
219
+                1
220
+            );
221
+            if ($response === false) {
222
+                return false;
223
+            }
224
+            $content = [];
225
+            $files = array_keys($response);
226
+            array_shift($files); //the first entry is the current directory
227
+
228
+            if (!$this->statCache->hasKey($path)) {
229
+                $this->statCache->set($path, true);
230
+            }
231
+            foreach ($files as $file) {
232
+                $file = urldecode($file);
233
+                // do not store the real entry, we might not have all properties
234
+                if (!$this->statCache->hasKey($path)) {
235
+                    $this->statCache->set($file, true);
236
+                }
237
+                $file = basename($file);
238
+                $content[] = $file;
239
+            }
240
+            return IteratorDirectory::wrap($content);
241
+        } catch (\Exception $e) {
242
+            $this->convertException($e, $path);
243
+        }
244
+        return false;
245
+    }
246
+
247
+    /**
248
+     * Propfind call with cache handling.
249
+     *
250
+     * First checks if information is cached.
251
+     * If not, request it from the server then store to cache.
252
+     *
253
+     * @param string $path path to propfind
254
+     *
255
+     * @return array|boolean propfind response or false if the entry was not found
256
+     *
257
+     * @throws ClientHttpException
258
+     */
259
+    protected function propfind($path) {
260
+        $path = $this->cleanPath($path);
261
+        $cachedResponse = $this->statCache->get($path);
262
+        // we either don't know it, or we know it exists but need more details
263
+        if (is_null($cachedResponse) || $cachedResponse === true) {
264
+            $this->init();
265
+            try {
266
+                $response = $this->client->propFind(
267
+                    $this->encodePath($path),
268
+                    [
269
+                        '{DAV:}getlastmodified',
270
+                        '{DAV:}getcontentlength',
271
+                        '{DAV:}getcontenttype',
272
+                        '{http://owncloud.org/ns}permissions',
273
+                        '{http://open-collaboration-services.org/ns}share-permissions',
274
+                        '{DAV:}resourcetype',
275
+                        '{DAV:}getetag',
276
+                    ]
277
+                );
278
+                $this->statCache->set($path, $response);
279
+            } catch (ClientHttpException $e) {
280
+                if ($e->getHttpStatus() === 404 || $e->getHttpStatus() === 405) {
281
+                    $this->statCache->clear($path . '/');
282
+                    $this->statCache->set($path, false);
283
+                    return false;
284
+                }
285
+                $this->convertException($e, $path);
286
+            } catch (\Exception $e) {
287
+                $this->convertException($e, $path);
288
+            }
289
+        } else {
290
+            $response = $cachedResponse;
291
+        }
292
+        return $response;
293
+    }
294
+
295
+    /** {@inheritdoc} */
296
+    public function filetype($path) {
297
+        try {
298
+            $response = $this->propfind($path);
299
+            if ($response === false) {
300
+                return false;
301
+            }
302
+            $responseType = [];
303
+            if (isset($response["{DAV:}resourcetype"])) {
304
+                /** @var ResourceType[] $response */
305
+                $responseType = $response["{DAV:}resourcetype"]->getValue();
306
+            }
307
+            return (count($responseType) > 0 and $responseType[0] == "{DAV:}collection") ? 'dir' : 'file';
308
+        } catch (\Exception $e) {
309
+            $this->convertException($e, $path);
310
+        }
311
+        return false;
312
+    }
313
+
314
+    /** {@inheritdoc} */
315
+    public function file_exists($path) {
316
+        try {
317
+            $path = $this->cleanPath($path);
318
+            $cachedState = $this->statCache->get($path);
319
+            if ($cachedState === false) {
320
+                // we know the file doesn't exist
321
+                return false;
322
+            } else if (!is_null($cachedState)) {
323
+                return true;
324
+            }
325
+            // need to get from server
326
+            return ($this->propfind($path) !== false);
327
+        } catch (\Exception $e) {
328
+            $this->convertException($e, $path);
329
+        }
330
+        return false;
331
+    }
332
+
333
+    /** {@inheritdoc} */
334
+    public function unlink($path) {
335
+        $this->init();
336
+        $path = $this->cleanPath($path);
337
+        $result = $this->simpleResponse('DELETE', $path, null, 204);
338
+        $this->statCache->clear($path . '/');
339
+        $this->statCache->remove($path);
340
+        return $result;
341
+    }
342
+
343
+    /** {@inheritdoc} */
344
+    public function fopen($path, $mode) {
345
+        $this->init();
346
+        $path = $this->cleanPath($path);
347
+        switch ($mode) {
348
+            case 'r':
349
+            case 'rb':
350
+                try {
351
+                    $response = $this->httpClientService
352
+                        ->newClient()
353
+                        ->get($this->createBaseUri() . $this->encodePath($path), [
354
+                            'auth' => [$this->user, $this->password],
355
+                            'stream' => true
356
+                        ]);
357
+                } catch (\GuzzleHttp\Exception\ClientException $e) {
358
+                    if ($e->getResponse() instanceof ResponseInterface
359
+                        && $e->getResponse()->getStatusCode() === 404) {
360
+                        return false;
361
+                    } else {
362
+                        throw $e;
363
+                    }
364
+                }
365
+
366
+                if ($response->getStatusCode() !== Http::STATUS_OK) {
367
+                    if ($response->getStatusCode() === Http::STATUS_LOCKED) {
368
+                        throw new \OCP\Lock\LockedException($path);
369
+                    } else {
370
+                        Util::writeLog("webdav client", 'Guzzle get returned status code ' . $response->getStatusCode(), ILogger::ERROR);
371
+                    }
372
+                }
373
+
374
+                return $response->getBody();
375
+            case 'w':
376
+            case 'wb':
377
+            case 'a':
378
+            case 'ab':
379
+            case 'r+':
380
+            case 'w+':
381
+            case 'wb+':
382
+            case 'a+':
383
+            case 'x':
384
+            case 'x+':
385
+            case 'c':
386
+            case 'c+':
387
+                //emulate these
388
+                $tempManager = \OC::$server->getTempManager();
389
+                if (strrpos($path, '.') !== false) {
390
+                    $ext = substr($path, strrpos($path, '.'));
391
+                } else {
392
+                    $ext = '';
393
+                }
394
+                if ($this->file_exists($path)) {
395
+                    if (!$this->isUpdatable($path)) {
396
+                        return false;
397
+                    }
398
+                    if ($mode === 'w' or $mode === 'w+') {
399
+                        $tmpFile = $tempManager->getTemporaryFile($ext);
400
+                    } else {
401
+                        $tmpFile = $this->getCachedFile($path);
402
+                    }
403
+                } else {
404
+                    if (!$this->isCreatable(dirname($path))) {
405
+                        return false;
406
+                    }
407
+                    $tmpFile = $tempManager->getTemporaryFile($ext);
408
+                }
409
+                $handle = fopen($tmpFile, $mode);
410
+                return CallbackWrapper::wrap($handle, null, null, function () use ($path, $tmpFile) {
411
+                    $this->writeBack($tmpFile, $path);
412
+                });
413
+        }
414
+    }
415
+
416
+    /**
417
+     * @param string $tmpFile
418
+     */
419
+    public function writeBack($tmpFile, $path) {
420
+        $this->uploadFile($tmpFile, $path);
421
+        unlink($tmpFile);
422
+    }
423
+
424
+    /** {@inheritdoc} */
425
+    public function free_space($path) {
426
+        $this->init();
427
+        $path = $this->cleanPath($path);
428
+        try {
429
+            // TODO: cacheable ?
430
+            $response = $this->client->propfind($this->encodePath($path), ['{DAV:}quota-available-bytes']);
431
+            if ($response === false) {
432
+                return FileInfo::SPACE_UNKNOWN;
433
+            }
434
+            if (isset($response['{DAV:}quota-available-bytes'])) {
435
+                return (int)$response['{DAV:}quota-available-bytes'];
436
+            } else {
437
+                return FileInfo::SPACE_UNKNOWN;
438
+            }
439
+        } catch (\Exception $e) {
440
+            return FileInfo::SPACE_UNKNOWN;
441
+        }
442
+    }
443
+
444
+    /** {@inheritdoc} */
445
+    public function touch($path, $mtime = null) {
446
+        $this->init();
447
+        if (is_null($mtime)) {
448
+            $mtime = time();
449
+        }
450
+        $path = $this->cleanPath($path);
451
+
452
+        // if file exists, update the mtime, else create a new empty file
453
+        if ($this->file_exists($path)) {
454
+            try {
455
+                $this->statCache->remove($path);
456
+                $this->client->proppatch($this->encodePath($path), ['{DAV:}lastmodified' => $mtime]);
457
+                // non-owncloud clients might not have accepted the property, need to recheck it
458
+                $response = $this->client->propfind($this->encodePath($path), ['{DAV:}getlastmodified'], 0);
459
+                if ($response === false) {
460
+                    return false;
461
+                }
462
+                if (isset($response['{DAV:}getlastmodified'])) {
463
+                    $remoteMtime = strtotime($response['{DAV:}getlastmodified']);
464
+                    if ($remoteMtime !== $mtime) {
465
+                        // server has not accepted the mtime
466
+                        return false;
467
+                    }
468
+                }
469
+            } catch (ClientHttpException $e) {
470
+                if ($e->getHttpStatus() === 501) {
471
+                    return false;
472
+                }
473
+                $this->convertException($e, $path);
474
+                return false;
475
+            } catch (\Exception $e) {
476
+                $this->convertException($e, $path);
477
+                return false;
478
+            }
479
+        } else {
480
+            $this->file_put_contents($path, '');
481
+        }
482
+        return true;
483
+    }
484
+
485
+    /**
486
+     * @param string $path
487
+     * @param string $data
488
+     * @return int
489
+     */
490
+    public function file_put_contents($path, $data) {
491
+        $path = $this->cleanPath($path);
492
+        $result = parent::file_put_contents($path, $data);
493
+        $this->statCache->remove($path);
494
+        return $result;
495
+    }
496
+
497
+    /**
498
+     * @param string $path
499
+     * @param string $target
500
+     */
501
+    protected function uploadFile($path, $target) {
502
+        $this->init();
503
+
504
+        // invalidate
505
+        $target = $this->cleanPath($target);
506
+        $this->statCache->remove($target);
507
+        $source = fopen($path, 'r');
508
+
509
+        $this->httpClientService
510
+            ->newClient()
511
+            ->put($this->createBaseUri() . $this->encodePath($target), [
512
+                'body' => $source,
513
+                'auth' => [$this->user, $this->password]
514
+            ]);
515
+
516
+        $this->removeCachedFile($target);
517
+    }
518
+
519
+    /** {@inheritdoc} */
520
+    public function rename($path1, $path2) {
521
+        $this->init();
522
+        $path1 = $this->cleanPath($path1);
523
+        $path2 = $this->cleanPath($path2);
524
+        try {
525
+            // overwrite directory ?
526
+            if ($this->is_dir($path2)) {
527
+                // needs trailing slash in destination
528
+                $path2 = rtrim($path2, '/') . '/';
529
+            }
530
+            $this->client->request(
531
+                'MOVE',
532
+                $this->encodePath($path1),
533
+                null,
534
+                [
535
+                    'Destination' => $this->createBaseUri() . $this->encodePath($path2),
536
+                ]
537
+            );
538
+            $this->statCache->clear($path1 . '/');
539
+            $this->statCache->clear($path2 . '/');
540
+            $this->statCache->set($path1, false);
541
+            $this->statCache->set($path2, true);
542
+            $this->removeCachedFile($path1);
543
+            $this->removeCachedFile($path2);
544
+            return true;
545
+        } catch (\Exception $e) {
546
+            $this->convertException($e);
547
+        }
548
+        return false;
549
+    }
550
+
551
+    /** {@inheritdoc} */
552
+    public function copy($path1, $path2) {
553
+        $this->init();
554
+        $path1 = $this->cleanPath($path1);
555
+        $path2 = $this->cleanPath($path2);
556
+        try {
557
+            // overwrite directory ?
558
+            if ($this->is_dir($path2)) {
559
+                // needs trailing slash in destination
560
+                $path2 = rtrim($path2, '/') . '/';
561
+            }
562
+            $this->client->request(
563
+                'COPY',
564
+                $this->encodePath($path1),
565
+                null,
566
+                [
567
+                    'Destination' => $this->createBaseUri() . $this->encodePath($path2),
568
+                ]
569
+            );
570
+            $this->statCache->clear($path2 . '/');
571
+            $this->statCache->set($path2, true);
572
+            $this->removeCachedFile($path2);
573
+            return true;
574
+        } catch (\Exception $e) {
575
+            $this->convertException($e);
576
+        }
577
+        return false;
578
+    }
579
+
580
+    /** {@inheritdoc} */
581
+    public function stat($path) {
582
+        try {
583
+            $response = $this->propfind($path);
584
+            if (!$response) {
585
+                return false;
586
+            }
587
+            return [
588
+                'mtime' => strtotime($response['{DAV:}getlastmodified']),
589
+                'size' => (int)isset($response['{DAV:}getcontentlength']) ? $response['{DAV:}getcontentlength'] : 0,
590
+            ];
591
+        } catch (\Exception $e) {
592
+            $this->convertException($e, $path);
593
+        }
594
+        return [];
595
+    }
596
+
597
+    /** {@inheritdoc} */
598
+    public function getMimeType($path) {
599
+        $remoteMimetype = $this->getMimeTypeFromRemote($path);
600
+        if ($remoteMimetype === 'application/octet-stream') {
601
+            return \OC::$server->getMimeTypeDetector()->detectPath($path);
602
+        } else {
603
+            return $remoteMimetype;
604
+        }
605
+    }
606
+
607
+    public function getMimeTypeFromRemote($path) {
608
+        try {
609
+            $response = $this->propfind($path);
610
+            if ($response === false) {
611
+                return false;
612
+            }
613
+            $responseType = [];
614
+            if (isset($response["{DAV:}resourcetype"])) {
615
+                /** @var ResourceType[] $response */
616
+                $responseType = $response["{DAV:}resourcetype"]->getValue();
617
+            }
618
+            $type = (count($responseType) > 0 and $responseType[0] == "{DAV:}collection") ? 'dir' : 'file';
619
+            if ($type == 'dir') {
620
+                return 'httpd/unix-directory';
621
+            } elseif (isset($response['{DAV:}getcontenttype'])) {
622
+                return $response['{DAV:}getcontenttype'];
623
+            } else {
624
+                return 'application/octet-stream';
625
+            }
626
+        } catch (\Exception $e) {
627
+            return false;
628
+        }
629
+    }
630
+
631
+    /**
632
+     * @param string $path
633
+     * @return string
634
+     */
635
+    public function cleanPath($path) {
636
+        if ($path === '') {
637
+            return $path;
638
+        }
639
+        $path = Filesystem::normalizePath($path);
640
+        // remove leading slash
641
+        return substr($path, 1);
642
+    }
643
+
644
+    /**
645
+     * URL encodes the given path but keeps the slashes
646
+     *
647
+     * @param string $path to encode
648
+     * @return string encoded path
649
+     */
650
+    protected function encodePath($path) {
651
+        // slashes need to stay
652
+        return str_replace('%2F', '/', rawurlencode($path));
653
+    }
654
+
655
+    /**
656
+     * @param string $method
657
+     * @param string $path
658
+     * @param string|resource|null $body
659
+     * @param int $expected
660
+     * @return bool
661
+     * @throws StorageInvalidException
662
+     * @throws StorageNotAvailableException
663
+     */
664
+    protected function simpleResponse($method, $path, $body, $expected) {
665
+        $path = $this->cleanPath($path);
666
+        try {
667
+            $response = $this->client->request($method, $this->encodePath($path), $body);
668
+            return $response['statusCode'] == $expected;
669
+        } catch (ClientHttpException $e) {
670
+            if ($e->getHttpStatus() === 404 && $method === 'DELETE') {
671
+                $this->statCache->clear($path . '/');
672
+                $this->statCache->set($path, false);
673
+                return false;
674
+            }
675
+
676
+            $this->convertException($e, $path);
677
+        } catch (\Exception $e) {
678
+            $this->convertException($e, $path);
679
+        }
680
+        return false;
681
+    }
682
+
683
+    /**
684
+     * check if curl is installed
685
+     */
686
+    public static function checkDependencies() {
687
+        return true;
688
+    }
689
+
690
+    /** {@inheritdoc} */
691
+    public function isUpdatable($path) {
692
+        return (bool)($this->getPermissions($path) & Constants::PERMISSION_UPDATE);
693
+    }
694
+
695
+    /** {@inheritdoc} */
696
+    public function isCreatable($path) {
697
+        return (bool)($this->getPermissions($path) & Constants::PERMISSION_CREATE);
698
+    }
699
+
700
+    /** {@inheritdoc} */
701
+    public function isSharable($path) {
702
+        return (bool)($this->getPermissions($path) & Constants::PERMISSION_SHARE);
703
+    }
704
+
705
+    /** {@inheritdoc} */
706
+    public function isDeletable($path) {
707
+        return (bool)($this->getPermissions($path) & Constants::PERMISSION_DELETE);
708
+    }
709
+
710
+    /** {@inheritdoc} */
711
+    public function getPermissions($path) {
712
+        $this->init();
713
+        $path = $this->cleanPath($path);
714
+        $response = $this->propfind($path);
715
+        if ($response === false) {
716
+            return 0;
717
+        }
718
+        if (isset($response['{http://owncloud.org/ns}permissions'])) {
719
+            return $this->parsePermissions($response['{http://owncloud.org/ns}permissions']);
720
+        } else if ($this->is_dir($path)) {
721
+            return Constants::PERMISSION_ALL;
722
+        } else if ($this->file_exists($path)) {
723
+            return Constants::PERMISSION_ALL - Constants::PERMISSION_CREATE;
724
+        } else {
725
+            return 0;
726
+        }
727
+    }
728
+
729
+    /** {@inheritdoc} */
730
+    public function getETag($path) {
731
+        $this->init();
732
+        $path = $this->cleanPath($path);
733
+        $response = $this->propfind($path);
734
+        if ($response === false) {
735
+            return null;
736
+        }
737
+        if (isset($response['{DAV:}getetag'])) {
738
+            $etag = trim($response['{DAV:}getetag'], '"');
739
+            if (strlen($etag) > 40) {
740
+                $etag = md5($etag);
741
+            }
742
+            return $etag;
743
+        }
744
+        return parent::getEtag($path);
745
+    }
746
+
747
+    /**
748
+     * @param string $permissionsString
749
+     * @return int
750
+     */
751
+    protected function parsePermissions($permissionsString) {
752
+        $permissions = Constants::PERMISSION_READ;
753
+        if (strpos($permissionsString, 'R') !== false) {
754
+            $permissions |= Constants::PERMISSION_SHARE;
755
+        }
756
+        if (strpos($permissionsString, 'D') !== false) {
757
+            $permissions |= Constants::PERMISSION_DELETE;
758
+        }
759
+        if (strpos($permissionsString, 'W') !== false) {
760
+            $permissions |= Constants::PERMISSION_UPDATE;
761
+        }
762
+        if (strpos($permissionsString, 'CK') !== false) {
763
+            $permissions |= Constants::PERMISSION_CREATE;
764
+            $permissions |= Constants::PERMISSION_UPDATE;
765
+        }
766
+        return $permissions;
767
+    }
768
+
769
+    /**
770
+     * check if a file or folder has been updated since $time
771
+     *
772
+     * @param string $path
773
+     * @param int $time
774
+     * @throws \OCP\Files\StorageNotAvailableException
775
+     * @return bool
776
+     */
777
+    public function hasUpdated($path, $time) {
778
+        $this->init();
779
+        $path = $this->cleanPath($path);
780
+        try {
781
+            // force refresh for $path
782
+            $this->statCache->remove($path);
783
+            $response = $this->propfind($path);
784
+            if ($response === false) {
785
+                if ($path === '') {
786
+                    // if root is gone it means the storage is not available
787
+                    throw new StorageNotAvailableException('root is gone');
788
+                }
789
+                return false;
790
+            }
791
+            if (isset($response['{DAV:}getetag'])) {
792
+                $cachedData = $this->getCache()->get($path);
793
+                $etag = null;
794
+                if (isset($response['{DAV:}getetag'])) {
795
+                    $etag = trim($response['{DAV:}getetag'], '"');
796
+                }
797
+                if (!empty($etag) && $cachedData['etag'] !== $etag) {
798
+                    return true;
799
+                } else if (isset($response['{http://open-collaboration-services.org/ns}share-permissions'])) {
800
+                    $sharePermissions = (int)$response['{http://open-collaboration-services.org/ns}share-permissions'];
801
+                    return $sharePermissions !== $cachedData['permissions'];
802
+                } else if (isset($response['{http://owncloud.org/ns}permissions'])) {
803
+                    $permissions = $this->parsePermissions($response['{http://owncloud.org/ns}permissions']);
804
+                    return $permissions !== $cachedData['permissions'];
805
+                } else {
806
+                    return false;
807
+                }
808
+            } else {
809
+                $remoteMtime = strtotime($response['{DAV:}getlastmodified']);
810
+                return $remoteMtime > $time;
811
+            }
812
+        } catch (ClientHttpException $e) {
813
+            if ($e->getHttpStatus() === 405) {
814
+                if ($path === '') {
815
+                    // if root is gone it means the storage is not available
816
+                    throw new StorageNotAvailableException(get_class($e) . ': ' . $e->getMessage());
817
+                }
818
+                return false;
819
+            }
820
+            $this->convertException($e, $path);
821
+            return false;
822
+        } catch (\Exception $e) {
823
+            $this->convertException($e, $path);
824
+            return false;
825
+        }
826
+    }
827
+
828
+    /**
829
+     * Interpret the given exception and decide whether it is due to an
830
+     * unavailable storage, invalid storage or other.
831
+     * This will either throw StorageInvalidException, StorageNotAvailableException
832
+     * or do nothing.
833
+     *
834
+     * @param Exception $e sabre exception
835
+     * @param string $path optional path from the operation
836
+     *
837
+     * @throws StorageInvalidException if the storage is invalid, for example
838
+     * when the authentication expired or is invalid
839
+     * @throws StorageNotAvailableException if the storage is not available,
840
+     * which might be temporary
841
+     * @throws ForbiddenException if the action is not allowed
842
+     */
843
+    protected function convertException(Exception $e, $path = '') {
844
+        \OC::$server->getLogger()->logException($e, ['app' => 'files_external', 'level' => ILogger::DEBUG]);
845
+        if ($e instanceof ClientHttpException) {
846
+            if ($e->getHttpStatus() === Http::STATUS_LOCKED) {
847
+                throw new \OCP\Lock\LockedException($path);
848
+            }
849
+            if ($e->getHttpStatus() === Http::STATUS_UNAUTHORIZED) {
850
+                // either password was changed or was invalid all along
851
+                throw new StorageInvalidException(get_class($e) . ': ' . $e->getMessage());
852
+            } else if ($e->getHttpStatus() === Http::STATUS_METHOD_NOT_ALLOWED) {
853
+                // ignore exception for MethodNotAllowed, false will be returned
854
+                return;
855
+            } else if ($e->getHttpStatus() === Http::STATUS_FORBIDDEN){
856
+                // The operation is forbidden. Fail somewhat gracefully
857
+                throw new ForbiddenException(get_class($e) . ':' . $e->getMessage());
858
+            }
859
+            throw new StorageNotAvailableException(get_class($e) . ': ' . $e->getMessage());
860
+        } else if ($e instanceof ClientException) {
861
+            // connection timeout or refused, server could be temporarily down
862
+            throw new StorageNotAvailableException(get_class($e) . ': ' . $e->getMessage());
863
+        } else if ($e instanceof \InvalidArgumentException) {
864
+            // parse error because the server returned HTML instead of XML,
865
+            // possibly temporarily down
866
+            throw new StorageNotAvailableException(get_class($e) . ': ' . $e->getMessage());
867
+        } else if (($e instanceof StorageNotAvailableException) || ($e instanceof StorageInvalidException)) {
868
+            // rethrow
869
+            throw $e;
870
+        }
871
+
872
+        // TODO: only log for now, but in the future need to wrap/rethrow exception
873
+    }
874 874
 }
Please login to merge, or discard this patch.