nextcloud / server

apps/files_sharing/lib/Command/ExiprationNotification.php

Indentation +50 added lines, -50 removed lines

@@ -36,64 +36,64 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class ExiprationNotification extends Command {
-	/** @var NotificationManager */
-	private $notificationManager;
-	/** @var IDBConnection */
-	private $connection;
-	/** @var ITimeFactory */
-	private $time;
-	/** @var ShareManager */
-	private $shareManager;
+    /** @var NotificationManager */
+    private $notificationManager;
+    /** @var IDBConnection */
+    private $connection;
+    /** @var ITimeFactory */
+    private $time;
+    /** @var ShareManager */
+    private $shareManager;
 
-	public function __construct(ITimeFactory $time,
-								NotificationManager $notificationManager,
-								IDBConnection $connection,
-								ShareManager $shareManager) {
-		parent::__construct();
+    public function __construct(ITimeFactory $time,
+                                NotificationManager $notificationManager,
+                                IDBConnection $connection,
+                                ShareManager $shareManager) {
+        parent::__construct();
 
-		$this->notificationManager = $notificationManager;
-		$this->connection = $connection;
-		$this->time = $time;
-		$this->shareManager = $shareManager;
-	}
+        $this->notificationManager = $notificationManager;
+        $this->connection = $connection;
+        $this->time = $time;
+        $this->shareManager = $shareManager;
+    }
 
-	protected function configure() {
-		$this
-			->setName('sharing:expiration-notification')
-			->setDescription('Notify share initiators when a share will expire the next day.');
-	}
+    protected function configure() {
+        $this
+            ->setName('sharing:expiration-notification')
+            ->setDescription('Notify share initiators when a share will expire the next day.');
+    }
 
-	public function execute(InputInterface $input, OutputInterface $output): int {
-		//Current time
-		$minTime = $this->time->getDateTime();
-		$minTime->add(new \DateInterval('P1D'));
-		$minTime->setTime(0,0,0);
+    public function execute(InputInterface $input, OutputInterface $output): int {
+        //Current time
+        $minTime = $this->time->getDateTime();
+        $minTime->add(new \DateInterval('P1D'));
+        $minTime->setTime(0,0,0);
 
-		$maxTime = clone $minTime;
-		$maxTime->setTime(23, 59, 59);
+        $maxTime = clone $minTime;
+        $maxTime->setTime(23, 59, 59);
 
-		$shares = $this->shareManager->getAllShares();
+        $shares = $this->shareManager->getAllShares();
 
-		$now = $this->time->getDateTime();
+        $now = $this->time->getDateTime();
 
-		/** @var IShare $share */
-		foreach ($shares as $share) {
-			if ($share->getExpirationDate() === null
-				|| $share->getExpirationDate()->getTimestamp() < $minTime->getTimestamp()
-				|| $share->getExpirationDate()->getTimestamp() > $maxTime->getTimestamp()) {
-				continue;
-			}
+        /** @var IShare $share */
+        foreach ($shares as $share) {
+            if ($share->getExpirationDate() === null
+                || $share->getExpirationDate()->getTimestamp() < $minTime->getTimestamp()
+                || $share->getExpirationDate()->getTimestamp() > $maxTime->getTimestamp()) {
+                continue;
+            }
 
-			$notification = $this->notificationManager->createNotification();
-			$notification->setApp('files_sharing')
-				->setDateTime($now)
-				->setObject('share', $share->getFullId())
-				->setSubject('expiresTomorrow');
+            $notification = $this->notificationManager->createNotification();
+            $notification->setApp('files_sharing')
+                ->setDateTime($now)
+                ->setObject('share', $share->getFullId())
+                ->setSubject('expiresTomorrow');
 
-			// Only send to initiator for now
-			$notification->setUser($share->getSharedBy());
-			$this->notificationManager->notify($notification);
-		}
-		return 0;
-	}
+            // Only send to initiator for now
+            $notification->setUser($share->getSharedBy());
+            $this->notificationManager->notify($notification);
+        }
+        return 0;
+    }
 }

apps/files_sharing/lib/Command/CleanupRemoteStorages.php

Indentation +141 added lines, -141 removed lines

@@ -37,145 +37,145 @@
  */
 class CleanupRemoteStorages extends Command {
 
-	/**
-	 * @var IDBConnection
-	 */
-	protected $connection;
-
-	public function __construct(IDBConnection $connection) {
-		$this->connection = $connection;
-		parent::__construct();
-	}
-
-	protected function configure() {
-		$this
-			->setName('sharing:cleanup-remote-storages')
-			->setDescription('Cleanup shared storage entries that have no matching entry in the shares_external table')
-			->addOption(
-				'dry-run',
-				null,
-				InputOption::VALUE_NONE,
-				'only show which storages would be deleted'
-			);
-	}
-
-	public function execute(InputInterface $input, OutputInterface $output): int {
-		$remoteStorages = $this->getRemoteStorages();
-
-		$output->writeln(count($remoteStorages) . ' remote storage(s) need(s) to be checked');
-
-		$remoteShareIds = $this->getRemoteShareIds();
-
-		$output->writeln(count($remoteShareIds) . ' remote share(s) exist');
-
-		foreach ($remoteShareIds as $id => $remoteShareId) {
-			if (isset($remoteStorages[$remoteShareId])) {
-				if ($input->getOption('dry-run') || $output->isVerbose()) {
-					$output->writeln("<info>$remoteShareId belongs to remote share $id</info>");
-				}
-
-				unset($remoteStorages[$remoteShareId]);
-			} else {
-				$output->writeln("<comment>$remoteShareId for share $id has no matching storage, yet</comment>");
-			}
-		}
-
-		if (empty($remoteStorages)) {
-			$output->writeln('<info>no storages deleted</info>');
-		} else {
-			$dryRun = $input->getOption('dry-run');
-			foreach ($remoteStorages as $id => $numericId) {
-				if ($dryRun) {
-					$output->writeln("<error>$id [$numericId] can be deleted</error>");
-					$this->countFiles($numericId, $output);
-				} else {
-					$this->deleteStorage($id, $numericId, $output);
-				}
-			}
-		}
-		return 0;
-	}
-
-	public function countFiles($numericId, OutputInterface $output) {
-		$queryBuilder = $this->connection->getQueryBuilder();
-		$queryBuilder->select($queryBuilder->func()->count('fileid'))
-			->from('filecache')
-			->where($queryBuilder->expr()->eq(
-				'storage',
-				$queryBuilder->createNamedParameter($numericId, IQueryBuilder::PARAM_STR),
-				IQueryBuilder::PARAM_STR)
-			);
-		$result = $queryBuilder->execute();
-		$count = $result->fetchColumn();
-		$output->writeln("$count files can be deleted for storage $numericId");
-	}
-
-	public function deleteStorage($id, $numericId, OutputInterface $output) {
-		$queryBuilder = $this->connection->getQueryBuilder();
-		$queryBuilder->delete('storages')
-			->where($queryBuilder->expr()->eq(
-				'id',
-				$queryBuilder->createNamedParameter($id, IQueryBuilder::PARAM_STR),
-				IQueryBuilder::PARAM_STR)
-			);
-		$output->write("deleting $id [$numericId] ... ");
-		$count = $queryBuilder->execute();
-		$output->writeln("deleted $count storage");
-		$this->deleteFiles($numericId, $output);
-	}
-
-	public function deleteFiles($numericId, OutputInterface $output) {
-		$queryBuilder = $this->connection->getQueryBuilder();
-		$queryBuilder->delete('filecache')
-			->where($queryBuilder->expr()->eq(
-				'storage',
-				$queryBuilder->createNamedParameter($numericId, IQueryBuilder::PARAM_STR),
-				IQueryBuilder::PARAM_STR)
-			);
-		$output->write("deleting files for storage $numericId ... ");
-		$count = $queryBuilder->execute();
-		$output->writeln("deleted $count files");
-	}
-
-	public function getRemoteStorages() {
-		$queryBuilder = $this->connection->getQueryBuilder();
-		$queryBuilder->select(['id', 'numeric_id'])
-			->from('storages')
-			->where($queryBuilder->expr()->like(
-				'id',
-				// match all 'shared::' + 32 characters storages
-				$queryBuilder->createNamedParameter($this->connection->escapeLikeParameter('shared::') . str_repeat('_', 32)),
-				IQueryBuilder::PARAM_STR)
-			)
-			->andWhere($queryBuilder->expr()->notLike(
-				'id',
-				// but not the ones starting with a '/', they are for normal shares
-				$queryBuilder->createNamedParameter($this->connection->escapeLikeParameter('shared::/') . '%'),
-				IQueryBuilder::PARAM_STR)
-			)->orderBy('numeric_id');
-		$query = $queryBuilder->execute();
-
-		$remoteStorages = [];
-
-		while ($row = $query->fetch()) {
-			$remoteStorages[$row['id']] = $row['numeric_id'];
-		}
-
-		return $remoteStorages;
-	}
-
-	public function getRemoteShareIds() {
-		$queryBuilder = $this->connection->getQueryBuilder();
-		$queryBuilder->select(['id', 'share_token', 'remote'])
-			->from('share_external');
-		$query = $queryBuilder->execute();
-
-		$remoteShareIds = [];
-
-		while ($row = $query->fetch()) {
-			$remoteShareIds[$row['id']] = 'shared::' . md5($row['share_token'] . '@' . $row['remote']);
-		}
-
-		return $remoteShareIds;
-	}
+    /**
+     * @var IDBConnection
+     */
+    protected $connection;
+
+    public function __construct(IDBConnection $connection) {
+        $this->connection = $connection;
+        parent::__construct();
+    }
+
+    protected function configure() {
+        $this
+            ->setName('sharing:cleanup-remote-storages')
+            ->setDescription('Cleanup shared storage entries that have no matching entry in the shares_external table')
+            ->addOption(
+                'dry-run',
+                null,
+                InputOption::VALUE_NONE,
+                'only show which storages would be deleted'
+            );
+    }
+
+    public function execute(InputInterface $input, OutputInterface $output): int {
+        $remoteStorages = $this->getRemoteStorages();
+
+        $output->writeln(count($remoteStorages) . ' remote storage(s) need(s) to be checked');
+
+        $remoteShareIds = $this->getRemoteShareIds();
+
+        $output->writeln(count($remoteShareIds) . ' remote share(s) exist');
+
+        foreach ($remoteShareIds as $id => $remoteShareId) {
+            if (isset($remoteStorages[$remoteShareId])) {
+                if ($input->getOption('dry-run') || $output->isVerbose()) {
+                    $output->writeln("<info>$remoteShareId belongs to remote share $id</info>");
+                }
+
+                unset($remoteStorages[$remoteShareId]);
+            } else {
+                $output->writeln("<comment>$remoteShareId for share $id has no matching storage, yet</comment>");
+            }
+        }
+
+        if (empty($remoteStorages)) {
+            $output->writeln('<info>no storages deleted</info>');
+        } else {
+            $dryRun = $input->getOption('dry-run');
+            foreach ($remoteStorages as $id => $numericId) {
+                if ($dryRun) {
+                    $output->writeln("<error>$id [$numericId] can be deleted</error>");
+                    $this->countFiles($numericId, $output);
+                } else {
+                    $this->deleteStorage($id, $numericId, $output);
+                }
+            }
+        }
+        return 0;
+    }
+
+    public function countFiles($numericId, OutputInterface $output) {
+        $queryBuilder = $this->connection->getQueryBuilder();
+        $queryBuilder->select($queryBuilder->func()->count('fileid'))
+            ->from('filecache')
+            ->where($queryBuilder->expr()->eq(
+                'storage',
+                $queryBuilder->createNamedParameter($numericId, IQueryBuilder::PARAM_STR),
+                IQueryBuilder::PARAM_STR)
+            );
+        $result = $queryBuilder->execute();
+        $count = $result->fetchColumn();
+        $output->writeln("$count files can be deleted for storage $numericId");
+    }
+
+    public function deleteStorage($id, $numericId, OutputInterface $output) {
+        $queryBuilder = $this->connection->getQueryBuilder();
+        $queryBuilder->delete('storages')
+            ->where($queryBuilder->expr()->eq(
+                'id',
+                $queryBuilder->createNamedParameter($id, IQueryBuilder::PARAM_STR),
+                IQueryBuilder::PARAM_STR)
+            );
+        $output->write("deleting $id [$numericId] ... ");
+        $count = $queryBuilder->execute();
+        $output->writeln("deleted $count storage");
+        $this->deleteFiles($numericId, $output);
+    }
+
+    public function deleteFiles($numericId, OutputInterface $output) {
+        $queryBuilder = $this->connection->getQueryBuilder();
+        $queryBuilder->delete('filecache')
+            ->where($queryBuilder->expr()->eq(
+                'storage',
+                $queryBuilder->createNamedParameter($numericId, IQueryBuilder::PARAM_STR),
+                IQueryBuilder::PARAM_STR)
+            );
+        $output->write("deleting files for storage $numericId ... ");
+        $count = $queryBuilder->execute();
+        $output->writeln("deleted $count files");
+    }
+
+    public function getRemoteStorages() {
+        $queryBuilder = $this->connection->getQueryBuilder();
+        $queryBuilder->select(['id', 'numeric_id'])
+            ->from('storages')
+            ->where($queryBuilder->expr()->like(
+                'id',
+                // match all 'shared::' + 32 characters storages
+                $queryBuilder->createNamedParameter($this->connection->escapeLikeParameter('shared::') . str_repeat('_', 32)),
+                IQueryBuilder::PARAM_STR)
+            )
+            ->andWhere($queryBuilder->expr()->notLike(
+                'id',
+                // but not the ones starting with a '/', they are for normal shares
+                $queryBuilder->createNamedParameter($this->connection->escapeLikeParameter('shared::/') . '%'),
+                IQueryBuilder::PARAM_STR)
+            )->orderBy('numeric_id');
+        $query = $queryBuilder->execute();
+
+        $remoteStorages = [];
+
+        while ($row = $query->fetch()) {
+            $remoteStorages[$row['id']] = $row['numeric_id'];
+        }
+
+        return $remoteStorages;
+    }
+
+    public function getRemoteShareIds() {
+        $queryBuilder = $this->connection->getQueryBuilder();
+        $queryBuilder->select(['id', 'share_token', 'remote'])
+            ->from('share_external');
+        $query = $queryBuilder->execute();
+
+        $remoteShareIds = [];
+
+        while ($row = $query->fetch()) {
+            $remoteShareIds[$row['id']] = 'shared::' . md5($row['share_token'] . '@' . $row['remote']);
+        }
+
+        return $remoteShareIds;
+    }
 }

Spacing +5 added lines, -5 removed lines

@@ -62,11 +62,11 @@ 
 	public function execute(InputInterface $input, OutputInterface $output): int {
 		$remoteStorages = $this->getRemoteStorages();
 
-		$output->writeln(count($remoteStorages) . ' remote storage(s) need(s) to be checked');
+		$output->writeln(count($remoteStorages).' remote storage(s) need(s) to be checked');
 
 		$remoteShareIds = $this->getRemoteShareIds();
 
-		$output->writeln(count($remoteShareIds) . ' remote share(s) exist');
+		$output->writeln(count($remoteShareIds).' remote share(s) exist');
 
 		foreach ($remoteShareIds as $id => $remoteShareId) {
 			if (isset($remoteStorages[$remoteShareId])) {
@@ -144,13 +144,13 @@ 
 			->where($queryBuilder->expr()->like(
 				'id',
 				// match all 'shared::' + 32 characters storages
-				$queryBuilder->createNamedParameter($this->connection->escapeLikeParameter('shared::') . str_repeat('_', 32)),
+				$queryBuilder->createNamedParameter($this->connection->escapeLikeParameter('shared::').str_repeat('_', 32)),
 				IQueryBuilder::PARAM_STR)
 			)
 			->andWhere($queryBuilder->expr()->notLike(
 				'id',
 				// but not the ones starting with a '/', they are for normal shares
-				$queryBuilder->createNamedParameter($this->connection->escapeLikeParameter('shared::/') . '%'),
+				$queryBuilder->createNamedParameter($this->connection->escapeLikeParameter('shared::/').'%'),
 				IQueryBuilder::PARAM_STR)
 			)->orderBy('numeric_id');
 		$query = $queryBuilder->execute();
@@ -173,7 +173,7 @@ 
 		$remoteShareIds = [];
 
 		while ($row = $query->fetch()) {
-			$remoteShareIds[$row['id']] = 'shared::' . md5($row['share_token'] . '@' . $row['remote']);
+			$remoteShareIds[$row['id']] = 'shared::'.md5($row['share_token'].'@'.$row['remote']);
 		}
 
 		return $remoteShareIds;

apps/workflowengine/lib/Command/Index.php

Indentation +40 added lines, -40 removed lines

@@ -35,48 +35,48 @@
 
 class Index extends Command {
 
-	/** @var Manager */
-	private $manager;
+    /** @var Manager */
+    private $manager;
 
-	public function __construct(Manager $manager) {
-		$this->manager = $manager;
-		parent::__construct();
-	}
+    public function __construct(Manager $manager) {
+        $this->manager = $manager;
+        parent::__construct();
+    }
 
-	protected function configure() {
-		$this
-			->setName('workflows:list')
-			->setDescription('Lists configured workflows')
-			->addArgument(
-				'scope',
-				InputArgument::OPTIONAL,
-				'Lists workflows for "admin", "user"',
-				'admin'
-			)
-			->addArgument(
-				'scopeId',
-				InputArgument::OPTIONAL,
-				'User IDs when the scope is "user"',
-				null
-			);
-	}
+    protected function configure() {
+        $this
+            ->setName('workflows:list')
+            ->setDescription('Lists configured workflows')
+            ->addArgument(
+                'scope',
+                InputArgument::OPTIONAL,
+                'Lists workflows for "admin", "user"',
+                'admin'
+            )
+            ->addArgument(
+                'scopeId',
+                InputArgument::OPTIONAL,
+                'User IDs when the scope is "user"',
+                null
+            );
+    }
 
-	protected function mappedScope(string $scope): int {
-		static $scopes = [
-			'admin' => IManager::SCOPE_ADMIN,
-			'user' => IManager::SCOPE_USER,
-		];
-		return $scopes[$scope] ?? -1;
-	}
+    protected function mappedScope(string $scope): int {
+        static $scopes = [
+            'admin' => IManager::SCOPE_ADMIN,
+            'user' => IManager::SCOPE_USER,
+        ];
+        return $scopes[$scope] ?? -1;
+    }
 
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		$ops = $this->manager->getAllOperations(
-			new ScopeContext(
-				$this->mappedScope($input->getArgument('scope')),
-				$input->getArgument('scopeId')
-			)
-		);
-		$output->writeln(\json_encode($ops));
-		return 0;
-	}
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        $ops = $this->manager->getAllOperations(
+            new ScopeContext(
+                $this->mappedScope($input->getArgument('scope')),
+                $input->getArgument('scopeId')
+            )
+        );
+        $output->writeln(\json_encode($ops));
+        return 0;
+    }
 }

apps/files/lib/Command/DeleteOrphanedFiles.php

Indentation +39 added lines, -39 removed lines

@@ -33,51 +33,51 @@
  * Delete all file entries that have no matching entries in the storage table.
  */
 class DeleteOrphanedFiles extends Command {
-	public const CHUNK_SIZE = 200;
+    public const CHUNK_SIZE = 200;
 
-	/**
-	 * @var IDBConnection
-	 */
-	protected $connection;
+    /**
+     * @var IDBConnection
+     */
+    protected $connection;
 
-	public function __construct(IDBConnection $connection) {
-		$this->connection = $connection;
-		parent::__construct();
-	}
+    public function __construct(IDBConnection $connection) {
+        $this->connection = $connection;
+        parent::__construct();
+    }
 
-	protected function configure() {
-		$this
-			->setName('files:cleanup')
-			->setDescription('cleanup filecache');
-	}
+    protected function configure() {
+        $this
+            ->setName('files:cleanup')
+            ->setDescription('cleanup filecache');
+    }
 
-	public function execute(InputInterface $input, OutputInterface $output): int {
-		$deletedEntries = 0;
+    public function execute(InputInterface $input, OutputInterface $output): int {
+        $deletedEntries = 0;
 
-		$query = $this->connection->getQueryBuilder();
-		$query->select('fc.fileid')
-			->from('filecache', 'fc')
-			->where($query->expr()->isNull('s.numeric_id'))
-			->leftJoin('fc', 'storages', 's', $query->expr()->eq('fc.storage', 's.numeric_id'))
-			->setMaxResults(self::CHUNK_SIZE);
+        $query = $this->connection->getQueryBuilder();
+        $query->select('fc.fileid')
+            ->from('filecache', 'fc')
+            ->where($query->expr()->isNull('s.numeric_id'))
+            ->leftJoin('fc', 'storages', 's', $query->expr()->eq('fc.storage', 's.numeric_id'))
+            ->setMaxResults(self::CHUNK_SIZE);
 
-		$deleteQuery = $this->connection->getQueryBuilder();
-		$deleteQuery->delete('filecache')
-			->where($deleteQuery->expr()->eq('fileid', $deleteQuery->createParameter('objectid')));
+        $deleteQuery = $this->connection->getQueryBuilder();
+        $deleteQuery->delete('filecache')
+            ->where($deleteQuery->expr()->eq('fileid', $deleteQuery->createParameter('objectid')));
 
-		$deletedInLastChunk = self::CHUNK_SIZE;
-		while ($deletedInLastChunk === self::CHUNK_SIZE) {
-			$deletedInLastChunk = 0;
-			$result = $query->execute();
-			while ($row = $result->fetch()) {
-				$deletedInLastChunk++;
-				$deletedEntries += $deleteQuery->setParameter('objectid', (int) $row['fileid'])
-					->execute();
-			}
-			$result->closeCursor();
-		}
+        $deletedInLastChunk = self::CHUNK_SIZE;
+        while ($deletedInLastChunk === self::CHUNK_SIZE) {
+            $deletedInLastChunk = 0;
+            $result = $query->execute();
+            while ($row = $result->fetch()) {
+                $deletedInLastChunk++;
+                $deletedEntries += $deleteQuery->setParameter('objectid', (int) $row['fileid'])
+                    ->execute();
+            }
+            $result->closeCursor();
+        }
 
-		$output->writeln("$deletedEntries orphaned file cache entries deleted");
-		return 0;
-	}
+        $output->writeln("$deletedEntries orphaned file cache entries deleted");
+        return 0;
+    }
 }

apps/files/lib/Command/ScanAppData.php

Indentation +239 added lines, -239 removed lines

@@ -44,243 +44,243 @@
 
 class ScanAppData extends Base {
 
-	/** @var IRootFolder */
-	protected $root;
-	/** @var IConfig */
-	protected $config;
-	/** @var float */
-	protected $execTime = 0;
-	/** @var int */
-	protected $foldersCounter = 0;
-	/** @var int */
-	protected $filesCounter = 0;
-
-	public function __construct(IRootFolder $rootFolder, IConfig $config) {
-		parent::__construct();
-
-		$this->root = $rootFolder;
-		$this->config = $config;
-	}
-
-	protected function configure() {
-		parent::configure();
-
-		$this
-			->setName('files:scan-app-data')
-			->setDescription('rescan the AppData folder');
-
-		$this->addArgument('folder', InputArgument::OPTIONAL, 'The appdata subfolder to scan', '');
-	}
-
-	public function checkScanWarning($fullPath, OutputInterface $output) {
-		$normalizedPath = basename(\OC\Files\Filesystem::normalizePath($fullPath));
-		$path = basename($fullPath);
-
-		if ($normalizedPath !== $path) {
-			$output->writeln("\t<error>Entry \"" . $fullPath . '" will not be accessible due to incompatible encoding</error>');
-		}
-	}
-
-	protected function scanFiles(OutputInterface $output, string $folder): int {
-		try {
-			$appData = $this->getAppDataFolder();
-		} catch (NotFoundException $e) {
-			$output->writeln('<error>NoAppData folder found</error>');
-			return 1;
-		}
-
-		if ($folder !== '') {
-			try {
-				$appData = $appData->get($folder);
-			} catch (NotFoundException $e) {
-				$output->writeln('<error>Could not find folder: ' . $folder . '</error>');
-				return 1;
-			}
-		}
-
-		$connection = $this->reconnectToDatabase($output);
-		$scanner = new \OC\Files\Utils\Scanner(null, $connection, \OC::$server->query(IEventDispatcher::class), \OC::$server->getLogger());
-
-		# check on each file/folder if there was a user interrupt (ctrl-c) and throw an exception
-		$scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function ($path) use ($output) {
-			$output->writeln("\tFile   <info>$path</info>", OutputInterface::VERBOSITY_VERBOSE);
-			++$this->filesCounter;
-			$this->abortIfInterrupted();
-		});
-
-		$scanner->listen('\OC\Files\Utils\Scanner', 'scanFolder', function ($path) use ($output) {
-			$output->writeln("\tFolder <info>$path</info>", OutputInterface::VERBOSITY_VERBOSE);
-			++$this->foldersCounter;
-			$this->abortIfInterrupted();
-		});
-
-		$scanner->listen('\OC\Files\Utils\Scanner', 'StorageNotAvailable', function (StorageNotAvailableException $e) use ($output) {
-			$output->writeln('Error while scanning, storage not available (' . $e->getMessage() . ')', OutputInterface::VERBOSITY_VERBOSE);
-		});
-
-		$scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function ($path) use ($output) {
-			$this->checkScanWarning($path, $output);
-		});
-
-		$scanner->listen('\OC\Files\Utils\Scanner', 'scanFolder', function ($path) use ($output) {
-			$this->checkScanWarning($path, $output);
-		});
-
-		try {
-			$scanner->scan($appData->getPath());
-		} catch (ForbiddenException $e) {
-			$output->writeln('<error>Storage not writable</error>');
-			$output->writeln('<info>Make sure you\'re running the scan command only as the user the web server runs as</info>');
-			return 1;
-		} catch (InterruptedException $e) {
-			# exit the function if ctrl-c has been pressed
-			$output->writeln('<info>Interrupted by user</info>');
-			return 1;
-		} catch (NotFoundException $e) {
-			$output->writeln('<error>Path not found: ' . $e->getMessage() . '</error>');
-			return 1;
-		} catch (\Exception $e) {
-			$output->writeln('<error>Exception during scan: ' . $e->getMessage() . '</error>');
-			$output->writeln('<error>' . $e->getTraceAsString() . '</error>');
-			return 1;
-		}
-
-		return 0;
-	}
-
-
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		# restrict the verbosity level to VERBOSITY_VERBOSE
-		if ($output->getVerbosity() > OutputInterface::VERBOSITY_VERBOSE) {
-			$output->setVerbosity(OutputInterface::VERBOSITY_VERBOSE);
-		}
-
-		$output->writeln('Scanning AppData for files');
-		$output->writeln('');
-
-		$folder = $input->getArgument('folder');
-
-		$this->initTools();
-
-		$exitCode = $this->scanFiles($output, $folder);
-		if ($exitCode === 0) {
-			$this->presentStats($output);
-		}
-		return $exitCode;
-	}
-
-	/**
-	 * Initialises some useful tools for the Command
-	 */
-	protected function initTools() {
-		// Start the timer
-		$this->execTime = -microtime(true);
-		// Convert PHP errors to exceptions
-		set_error_handler([$this, 'exceptionErrorHandler'], E_ALL);
-	}
-
-	/**
-	 * Processes PHP errors as exceptions in order to be able to keep track of problems
-	 *
-	 * @see https://secure.php.net/manual/en/function.set-error-handler.php
-	 *
-	 * @param int $severity the level of the error raised
-	 * @param string $message
-	 * @param string $file the filename that the error was raised in
-	 * @param int $line the line number the error was raised
-	 *
-	 * @throws \ErrorException
-	 */
-	public function exceptionErrorHandler($severity, $message, $file, $line) {
-		if (!(error_reporting() & $severity)) {
-			// This error code is not included in error_reporting
-			return;
-		}
-		throw new \ErrorException($message, 0, $severity, $file, $line);
-	}
-
-	/**
-	 * @param OutputInterface $output
-	 */
-	protected function presentStats(OutputInterface $output) {
-		// Stop the timer
-		$this->execTime += microtime(true);
-
-		$headers = [
-			'Folders', 'Files', 'Elapsed time'
-		];
-
-		$this->showSummary($headers, null, $output);
-	}
-
-	/**
-	 * Shows a summary of operations
-	 *
-	 * @param string[] $headers
-	 * @param string[] $rows
-	 * @param OutputInterface $output
-	 */
-	protected function showSummary($headers, $rows, OutputInterface $output) {
-		$niceDate = $this->formatExecTime();
-		if (!$rows) {
-			$rows = [
-				$this->foldersCounter,
-				$this->filesCounter,
-				$niceDate,
-			];
-		}
-		$table = new Table($output);
-		$table
-			->setHeaders($headers)
-			->setRows([$rows]);
-		$table->render();
-	}
-
-
-	/**
-	 * Formats microtime into a human readable format
-	 *
-	 * @return string
-	 */
-	protected function formatExecTime() {
-		$secs = round($this->execTime);
-		# convert seconds into HH:MM:SS form
-		return sprintf('%02d:%02d:%02d', ($secs/3600), ($secs/60%60), $secs%60);
-	}
-
-	/**
-	 * @return \OCP\IDBConnection
-	 */
-	protected function reconnectToDatabase(OutputInterface $output) {
-		/** @var Connection | IDBConnection $connection*/
-		$connection = \OC::$server->getDatabaseConnection();
-		try {
-			$connection->close();
-		} catch (\Exception $ex) {
-			$output->writeln("<info>Error while disconnecting from database: {$ex->getMessage()}</info>");
-		}
-		while (!$connection->isConnected()) {
-			try {
-				$connection->connect();
-			} catch (\Exception $ex) {
-				$output->writeln("<info>Error while re-connecting to database: {$ex->getMessage()}</info>");
-				sleep(60);
-			}
-		}
-		return $connection;
-	}
-
-	/**
-	 * @return \OCP\Files\Folder
-	 * @throws NotFoundException
-	 */
-	private function getAppDataFolder() {
-		$instanceId = $this->config->getSystemValue('instanceid', null);
-
-		if ($instanceId === null) {
-			throw new NotFoundException();
-		}
-
-		return $this->root->get('appdata_'.$instanceId);
-	}
+    /** @var IRootFolder */
+    protected $root;
+    /** @var IConfig */
+    protected $config;
+    /** @var float */
+    protected $execTime = 0;
+    /** @var int */
+    protected $foldersCounter = 0;
+    /** @var int */
+    protected $filesCounter = 0;
+
+    public function __construct(IRootFolder $rootFolder, IConfig $config) {
+        parent::__construct();
+
+        $this->root = $rootFolder;
+        $this->config = $config;
+    }
+
+    protected function configure() {
+        parent::configure();
+
+        $this
+            ->setName('files:scan-app-data')
+            ->setDescription('rescan the AppData folder');
+
+        $this->addArgument('folder', InputArgument::OPTIONAL, 'The appdata subfolder to scan', '');
+    }
+
+    public function checkScanWarning($fullPath, OutputInterface $output) {
+        $normalizedPath = basename(\OC\Files\Filesystem::normalizePath($fullPath));
+        $path = basename($fullPath);
+
+        if ($normalizedPath !== $path) {
+            $output->writeln("\t<error>Entry \"" . $fullPath . '" will not be accessible due to incompatible encoding</error>');
+        }
+    }
+
+    protected function scanFiles(OutputInterface $output, string $folder): int {
+        try {
+            $appData = $this->getAppDataFolder();
+        } catch (NotFoundException $e) {
+            $output->writeln('<error>NoAppData folder found</error>');
+            return 1;
+        }
+
+        if ($folder !== '') {
+            try {
+                $appData = $appData->get($folder);
+            } catch (NotFoundException $e) {
+                $output->writeln('<error>Could not find folder: ' . $folder . '</error>');
+                return 1;
+            }
+        }
+
+        $connection = $this->reconnectToDatabase($output);
+        $scanner = new \OC\Files\Utils\Scanner(null, $connection, \OC::$server->query(IEventDispatcher::class), \OC::$server->getLogger());
+
+        # check on each file/folder if there was a user interrupt (ctrl-c) and throw an exception
+        $scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function ($path) use ($output) {
+            $output->writeln("\tFile   <info>$path</info>", OutputInterface::VERBOSITY_VERBOSE);
+            ++$this->filesCounter;
+            $this->abortIfInterrupted();
+        });
+
+        $scanner->listen('\OC\Files\Utils\Scanner', 'scanFolder', function ($path) use ($output) {
+            $output->writeln("\tFolder <info>$path</info>", OutputInterface::VERBOSITY_VERBOSE);
+            ++$this->foldersCounter;
+            $this->abortIfInterrupted();
+        });
+
+        $scanner->listen('\OC\Files\Utils\Scanner', 'StorageNotAvailable', function (StorageNotAvailableException $e) use ($output) {
+            $output->writeln('Error while scanning, storage not available (' . $e->getMessage() . ')', OutputInterface::VERBOSITY_VERBOSE);
+        });
+
+        $scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function ($path) use ($output) {
+            $this->checkScanWarning($path, $output);
+        });
+
+        $scanner->listen('\OC\Files\Utils\Scanner', 'scanFolder', function ($path) use ($output) {
+            $this->checkScanWarning($path, $output);
+        });
+
+        try {
+            $scanner->scan($appData->getPath());
+        } catch (ForbiddenException $e) {
+            $output->writeln('<error>Storage not writable</error>');
+            $output->writeln('<info>Make sure you\'re running the scan command only as the user the web server runs as</info>');
+            return 1;
+        } catch (InterruptedException $e) {
+            # exit the function if ctrl-c has been pressed
+            $output->writeln('<info>Interrupted by user</info>');
+            return 1;
+        } catch (NotFoundException $e) {
+            $output->writeln('<error>Path not found: ' . $e->getMessage() . '</error>');
+            return 1;
+        } catch (\Exception $e) {
+            $output->writeln('<error>Exception during scan: ' . $e->getMessage() . '</error>');
+            $output->writeln('<error>' . $e->getTraceAsString() . '</error>');
+            return 1;
+        }
+
+        return 0;
+    }
+
+
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        # restrict the verbosity level to VERBOSITY_VERBOSE
+        if ($output->getVerbosity() > OutputInterface::VERBOSITY_VERBOSE) {
+            $output->setVerbosity(OutputInterface::VERBOSITY_VERBOSE);
+        }
+
+        $output->writeln('Scanning AppData for files');
+        $output->writeln('');
+
+        $folder = $input->getArgument('folder');
+
+        $this->initTools();
+
+        $exitCode = $this->scanFiles($output, $folder);
+        if ($exitCode === 0) {
+            $this->presentStats($output);
+        }
+        return $exitCode;
+    }
+
+    /**
+     * Initialises some useful tools for the Command
+     */
+    protected function initTools() {
+        // Start the timer
+        $this->execTime = -microtime(true);
+        // Convert PHP errors to exceptions
+        set_error_handler([$this, 'exceptionErrorHandler'], E_ALL);
+    }
+
+    /**
+     * Processes PHP errors as exceptions in order to be able to keep track of problems
+     *
+     * @see https://secure.php.net/manual/en/function.set-error-handler.php
+     *
+     * @param int $severity the level of the error raised
+     * @param string $message
+     * @param string $file the filename that the error was raised in
+     * @param int $line the line number the error was raised
+     *
+     * @throws \ErrorException
+     */
+    public function exceptionErrorHandler($severity, $message, $file, $line) {
+        if (!(error_reporting() & $severity)) {
+            // This error code is not included in error_reporting
+            return;
+        }
+        throw new \ErrorException($message, 0, $severity, $file, $line);
+    }
+
+    /**
+     * @param OutputInterface $output
+     */
+    protected function presentStats(OutputInterface $output) {
+        // Stop the timer
+        $this->execTime += microtime(true);
+
+        $headers = [
+            'Folders', 'Files', 'Elapsed time'
+        ];
+
+        $this->showSummary($headers, null, $output);
+    }
+
+    /**
+     * Shows a summary of operations
+     *
+     * @param string[] $headers
+     * @param string[] $rows
+     * @param OutputInterface $output
+     */
+    protected function showSummary($headers, $rows, OutputInterface $output) {
+        $niceDate = $this->formatExecTime();
+        if (!$rows) {
+            $rows = [
+                $this->foldersCounter,
+                $this->filesCounter,
+                $niceDate,
+            ];
+        }
+        $table = new Table($output);
+        $table
+            ->setHeaders($headers)
+            ->setRows([$rows]);
+        $table->render();
+    }
+
+
+    /**
+     * Formats microtime into a human readable format
+     *
+     * @return string
+     */
+    protected function formatExecTime() {
+        $secs = round($this->execTime);
+        # convert seconds into HH:MM:SS form
+        return sprintf('%02d:%02d:%02d', ($secs/3600), ($secs/60%60), $secs%60);
+    }
+
+    /**
+     * @return \OCP\IDBConnection
+     */
+    protected function reconnectToDatabase(OutputInterface $output) {
+        /** @var Connection | IDBConnection $connection*/
+        $connection = \OC::$server->getDatabaseConnection();
+        try {
+            $connection->close();
+        } catch (\Exception $ex) {
+            $output->writeln("<info>Error while disconnecting from database: {$ex->getMessage()}</info>");
+        }
+        while (!$connection->isConnected()) {
+            try {
+                $connection->connect();
+            } catch (\Exception $ex) {
+                $output->writeln("<info>Error while re-connecting to database: {$ex->getMessage()}</info>");
+                sleep(60);
+            }
+        }
+        return $connection;
+    }
+
+    /**
+     * @return \OCP\Files\Folder
+     * @throws NotFoundException
+     */
+    private function getAppDataFolder() {
+        $instanceId = $this->config->getSystemValue('instanceid', null);
+
+        if ($instanceId === null) {
+            throw new NotFoundException();
+        }
+
+        return $this->root->get('appdata_'.$instanceId);
+    }
 }

apps/files/lib/Command/TransferOwnership.php

Indentation +62 added lines, -62 removed lines

@@ -45,74 +45,74 @@
 
 class TransferOwnership extends Command {
 
-	/** @var IUserManager */
-	private $userManager;
+    /** @var IUserManager */
+    private $userManager;
 
-	/** @var OwnershipTransferService */
-	private $transferService;
+    /** @var OwnershipTransferService */
+    private $transferService;
 
-	public function __construct(IUserManager $userManager,
-								OwnershipTransferService $transferService) {
-		parent::__construct();
-		$this->userManager = $userManager;
-		$this->transferService = $transferService;
-	}
+    public function __construct(IUserManager $userManager,
+                                OwnershipTransferService $transferService) {
+        parent::__construct();
+        $this->userManager = $userManager;
+        $this->transferService = $transferService;
+    }
 
-	protected function configure() {
-		$this
-			->setName('files:transfer-ownership')
-			->setDescription('All files and folders are moved to another user - shares are moved as well.')
-			->addArgument(
-				'source-user',
-				InputArgument::REQUIRED,
-				'owner of files which shall be moved'
-			)
-			->addArgument(
-				'destination-user',
-				InputArgument::REQUIRED,
-				'user who will be the new owner of the files'
-			)
-			->addOption(
-				'path',
-				null,
-				InputOption::VALUE_REQUIRED,
-				'selectively provide the path to transfer. For example --path="folder_name"',
-				''
-			)->addOption(
-				'move',
-				null,
-				InputOption::VALUE_NONE,
-				'move data from source user to root directory of destination user, which must be empty'
-		);
-	}
+    protected function configure() {
+        $this
+            ->setName('files:transfer-ownership')
+            ->setDescription('All files and folders are moved to another user - shares are moved as well.')
+            ->addArgument(
+                'source-user',
+                InputArgument::REQUIRED,
+                'owner of files which shall be moved'
+            )
+            ->addArgument(
+                'destination-user',
+                InputArgument::REQUIRED,
+                'user who will be the new owner of the files'
+            )
+            ->addOption(
+                'path',
+                null,
+                InputOption::VALUE_REQUIRED,
+                'selectively provide the path to transfer. For example --path="folder_name"',
+                ''
+            )->addOption(
+                'move',
+                null,
+                InputOption::VALUE_NONE,
+                'move data from source user to root directory of destination user, which must be empty'
+        );
+    }
 
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		$sourceUserObject = $this->userManager->get($input->getArgument('source-user'));
-		$destinationUserObject = $this->userManager->get($input->getArgument('destination-user'));
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        $sourceUserObject = $this->userManager->get($input->getArgument('source-user'));
+        $destinationUserObject = $this->userManager->get($input->getArgument('destination-user'));
 
-		if (!$sourceUserObject instanceof IUser) {
-			$output->writeln("<error>Unknown source user " . $input->getArgument('source-user') . "</error>");
-			return 1;
-		}
+        if (!$sourceUserObject instanceof IUser) {
+            $output->writeln("<error>Unknown source user " . $input->getArgument('source-user') . "</error>");
+            return 1;
+        }
 
-		if (!$destinationUserObject instanceof IUser) {
-			$output->writeln("<error>Unknown destination user " . $input->getArgument('destination-user') . "</error>");
-			return 1;
-		}
+        if (!$destinationUserObject instanceof IUser) {
+            $output->writeln("<error>Unknown destination user " . $input->getArgument('destination-user') . "</error>");
+            return 1;
+        }
 
-		try {
-			$this->transferService->transfer(
-				$sourceUserObject,
-				$destinationUserObject,
-				ltrim($input->getOption('path'), '/'),
-				$output,
-				$input->getOption('move') === true
-			);
-		} catch (TransferOwnershipException $e) {
-			$output->writeln("<error>" . $e->getMessage() . "</error>");
-			return $e->getCode() !== 0 ? $e->getCode() : 1;
-		}
+        try {
+            $this->transferService->transfer(
+                $sourceUserObject,
+                $destinationUserObject,
+                ltrim($input->getOption('path'), '/'),
+                $output,
+                $input->getOption('move') === true
+            );
+        } catch (TransferOwnershipException $e) {
+            $output->writeln("<error>" . $e->getMessage() . "</error>");
+            return $e->getCode() !== 0 ? $e->getCode() : 1;
+        }
 
-		return 0;
-	}
+        return 0;
+    }
 }

apps/files/lib/Command/Scan.php

Indentation +271 added lines, -271 removed lines

@@ -51,275 +51,275 @@
 
 class Scan extends Base {
 
-	/** @var IUserManager $userManager */
-	private $userManager;
-	/** @var float */
-	protected $execTime = 0;
-	/** @var int */
-	protected $foldersCounter = 0;
-	/** @var int */
-	protected $filesCounter = 0;
-
-	public function __construct(IUserManager $userManager) {
-		$this->userManager = $userManager;
-		parent::__construct();
-	}
-
-	protected function configure() {
-		parent::configure();
-
-		$this
-			->setName('files:scan')
-			->setDescription('rescan filesystem')
-			->addArgument(
-				'user_id',
-				InputArgument::OPTIONAL | InputArgument::IS_ARRAY,
-				'will rescan all files of the given user(s)'
-			)
-			->addOption(
-				'path',
-				'p',
-				InputArgument::OPTIONAL,
-				'limit rescan to this path, eg. --path="/alice/files/Music", the user_id is determined by the path and the user_id parameter and --all are ignored'
-			)
-			->addOption(
-				'all',
-				null,
-				InputOption::VALUE_NONE,
-				'will rescan all files of all known users'
-			)->addOption(
-				'unscanned',
-				null,
-				InputOption::VALUE_NONE,
-				'only scan files which are marked as not fully scanned'
-			)->addOption(
-				'shallow',
-				null,
-				InputOption::VALUE_NONE,
-				'do not scan folders recursively'
-			)->addOption(
-				'home-only',
-				null,
-				InputOption::VALUE_NONE,
-				'only scan the home storage, ignoring any mounted external storage or share'
-			);
-	}
-
-	public function checkScanWarning($fullPath, OutputInterface $output) {
-		$normalizedPath = basename(\OC\Files\Filesystem::normalizePath($fullPath));
-		$path = basename($fullPath);
-
-		if ($normalizedPath !== $path) {
-			$output->writeln("\t<error>Entry \"" . $fullPath . '" will not be accessible due to incompatible encoding</error>');
-		}
-	}
-
-	protected function scanFiles($user, $path, OutputInterface $output, $backgroundScan = false, $recursive = true, $homeOnly = false) {
-		$connection = $this->reconnectToDatabase($output);
-		$scanner = new \OC\Files\Utils\Scanner($user, $connection, \OC::$server->query(IEventDispatcher::class), \OC::$server->getLogger());
-
-		# check on each file/folder if there was a user interrupt (ctrl-c) and throw an exception
-
-		$scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function ($path) use ($output) {
-			$output->writeln("\tFile\t<info>$path</info>", OutputInterface::VERBOSITY_VERBOSE);
-			++$this->filesCounter;
-			$this->abortIfInterrupted();
-		});
-
-		$scanner->listen('\OC\Files\Utils\Scanner', 'scanFolder', function ($path) use ($output) {
-			$output->writeln("\tFolder\t<info>$path</info>", OutputInterface::VERBOSITY_VERBOSE);
-			++$this->foldersCounter;
-			$this->abortIfInterrupted();
-		});
-
-		$scanner->listen('\OC\Files\Utils\Scanner', 'StorageNotAvailable', function (StorageNotAvailableException $e) use ($output) {
-			$output->writeln('Error while scanning, storage not available (' . $e->getMessage() . ')', OutputInterface::VERBOSITY_VERBOSE);
-		});
-
-		$scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function ($path) use ($output) {
-			$this->checkScanWarning($path, $output);
-		});
-
-		$scanner->listen('\OC\Files\Utils\Scanner', 'scanFolder', function ($path) use ($output) {
-			$this->checkScanWarning($path, $output);
-		});
-
-		try {
-			if ($backgroundScan) {
-				$scanner->backgroundScan($path);
-			} else {
-				$scanner->scan($path, $recursive, $homeOnly ? [$this, 'filterHomeMount'] : null);
-			}
-		} catch (ForbiddenException $e) {
-			$output->writeln("<error>Home storage for user $user not writable</error>");
-			$output->writeln('Make sure you\'re running the scan command only as the user the web server runs as');
-		} catch (InterruptedException $e) {
-			# exit the function if ctrl-c has been pressed
-			$output->writeln('Interrupted by user');
-		} catch (NotFoundException $e) {
-			$output->writeln('<error>Path not found: ' . $e->getMessage() . '</error>');
-		} catch (\Exception $e) {
-			$output->writeln('<error>Exception during scan: ' . $e->getMessage() . '</error>');
-			$output->writeln('<error>' . $e->getTraceAsString() . '</error>');
-		}
-	}
-
-	public function filterHomeMount(IMountPoint $mountPoint) {
-		// any mountpoint inside '/$user/files/'
-		return substr_count($mountPoint->getMountPoint(), '/') <= 3;
-	}
-
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		$inputPath = $input->getOption('path');
-		if ($inputPath) {
-			$inputPath = '/' . trim($inputPath, '/');
-			list(, $user,) = explode('/', $inputPath, 3);
-			$users = [$user];
-		} elseif ($input->getOption('all')) {
-			$users = $this->userManager->search('');
-		} else {
-			$users = $input->getArgument('user_id');
-		}
-
-		# restrict the verbosity level to VERBOSITY_VERBOSE
-		if ($output->getVerbosity() > OutputInterface::VERBOSITY_VERBOSE) {
-			$output->setVerbosity(OutputInterface::VERBOSITY_VERBOSE);
-		}
-
-		# check quantity of users to be process and show it on the command line
-		$users_total = count($users);
-		if ($users_total === 0) {
-			$output->writeln('<error>Please specify the user id to scan, --all to scan for all users or --path=...</error>');
-			return 1;
-		}
-
-		$this->initTools();
-
-		$user_count = 0;
-		foreach ($users as $user) {
-			if (is_object($user)) {
-				$user = $user->getUID();
-			}
-			$path = $inputPath ? $inputPath : '/' . $user;
-			++$user_count;
-			if ($this->userManager->userExists($user)) {
-				$output->writeln("Starting scan for user $user_count out of $users_total ($user)");
-				$this->scanFiles($user, $path, $output, $input->getOption('unscanned'), !$input->getOption('shallow'), $input->getOption('home-only'));
-				$output->writeln('', OutputInterface::VERBOSITY_VERBOSE);
-			} else {
-				$output->writeln("<error>Unknown user $user_count $user</error>");
-				$output->writeln('', OutputInterface::VERBOSITY_VERBOSE);
-			}
-
-			try {
-				$this->abortIfInterrupted();
-			} catch (InterruptedException $e) {
-				break;
-			}
-		}
-
-		$this->presentStats($output);
-		return 0;
-	}
-
-	/**
-	 * Initialises some useful tools for the Command
-	 */
-	protected function initTools() {
-		// Start the timer
-		$this->execTime = -microtime(true);
-		// Convert PHP errors to exceptions
-		set_error_handler([$this, 'exceptionErrorHandler'], E_ALL);
-	}
-
-	/**
-	 * Processes PHP errors as exceptions in order to be able to keep track of problems
-	 *
-	 * @see https://secure.php.net/manual/en/function.set-error-handler.php
-	 *
-	 * @param int $severity the level of the error raised
-	 * @param string $message
-	 * @param string $file the filename that the error was raised in
-	 * @param int $line the line number the error was raised
-	 *
-	 * @throws \ErrorException
-	 */
-	public function exceptionErrorHandler($severity, $message, $file, $line) {
-		if (!(error_reporting() & $severity)) {
-			// This error code is not included in error_reporting
-			return;
-		}
-		throw new \ErrorException($message, 0, $severity, $file, $line);
-	}
-
-	/**
-	 * @param OutputInterface $output
-	 */
-	protected function presentStats(OutputInterface $output) {
-		// Stop the timer
-		$this->execTime += microtime(true);
-
-		$headers = [
-			'Folders', 'Files', 'Elapsed time'
-		];
-
-		$this->showSummary($headers, null, $output);
-	}
-
-	/**
-	 * Shows a summary of operations
-	 *
-	 * @param string[] $headers
-	 * @param string[] $rows
-	 * @param OutputInterface $output
-	 */
-	protected function showSummary($headers, $rows, OutputInterface $output) {
-		$niceDate = $this->formatExecTime();
-		if (!$rows) {
-			$rows = [
-				$this->foldersCounter,
-				$this->filesCounter,
-				$niceDate,
-			];
-		}
-		$table = new Table($output);
-		$table
-			->setHeaders($headers)
-			->setRows([$rows]);
-		$table->render();
-	}
-
-
-	/**
-	 * Formats microtime into a human readable format
-	 *
-	 * @return string
-	 */
-	protected function formatExecTime() {
-		$secs = round($this->execTime);
-		# convert seconds into HH:MM:SS form
-		return sprintf('%02d:%02d:%02d', ($secs/3600), ($secs/60%60), $secs%60);
-	}
-
-	/**
-	 * @return \OCP\IDBConnection
-	 */
-	protected function reconnectToDatabase(OutputInterface $output) {
-		/** @var Connection | IDBConnection $connection */
-		$connection = \OC::$server->getDatabaseConnection();
-		try {
-			$connection->close();
-		} catch (\Exception $ex) {
-			$output->writeln("<info>Error while disconnecting from database: {$ex->getMessage()}</info>");
-		}
-		while (!$connection->isConnected()) {
-			try {
-				$connection->connect();
-			} catch (\Exception $ex) {
-				$output->writeln("<info>Error while re-connecting to database: {$ex->getMessage()}</info>");
-				sleep(60);
-			}
-		}
-		return $connection;
-	}
+    /** @var IUserManager $userManager */
+    private $userManager;
+    /** @var float */
+    protected $execTime = 0;
+    /** @var int */
+    protected $foldersCounter = 0;
+    /** @var int */
+    protected $filesCounter = 0;
+
+    public function __construct(IUserManager $userManager) {
+        $this->userManager = $userManager;
+        parent::__construct();
+    }
+
+    protected function configure() {
+        parent::configure();
+
+        $this
+            ->setName('files:scan')
+            ->setDescription('rescan filesystem')
+            ->addArgument(
+                'user_id',
+                InputArgument::OPTIONAL | InputArgument::IS_ARRAY,
+                'will rescan all files of the given user(s)'
+            )
+            ->addOption(
+                'path',
+                'p',
+                InputArgument::OPTIONAL,
+                'limit rescan to this path, eg. --path="/alice/files/Music", the user_id is determined by the path and the user_id parameter and --all are ignored'
+            )
+            ->addOption(
+                'all',
+                null,
+                InputOption::VALUE_NONE,
+                'will rescan all files of all known users'
+            )->addOption(
+                'unscanned',
+                null,
+                InputOption::VALUE_NONE,
+                'only scan files which are marked as not fully scanned'
+            )->addOption(
+                'shallow',
+                null,
+                InputOption::VALUE_NONE,
+                'do not scan folders recursively'
+            )->addOption(
+                'home-only',
+                null,
+                InputOption::VALUE_NONE,
+                'only scan the home storage, ignoring any mounted external storage or share'
+            );
+    }
+
+    public function checkScanWarning($fullPath, OutputInterface $output) {
+        $normalizedPath = basename(\OC\Files\Filesystem::normalizePath($fullPath));
+        $path = basename($fullPath);
+
+        if ($normalizedPath !== $path) {
+            $output->writeln("\t<error>Entry \"" . $fullPath . '" will not be accessible due to incompatible encoding</error>');
+        }
+    }
+
+    protected function scanFiles($user, $path, OutputInterface $output, $backgroundScan = false, $recursive = true, $homeOnly = false) {
+        $connection = $this->reconnectToDatabase($output);
+        $scanner = new \OC\Files\Utils\Scanner($user, $connection, \OC::$server->query(IEventDispatcher::class), \OC::$server->getLogger());
+
+        # check on each file/folder if there was a user interrupt (ctrl-c) and throw an exception
+
+        $scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function ($path) use ($output) {
+            $output->writeln("\tFile\t<info>$path</info>", OutputInterface::VERBOSITY_VERBOSE);
+            ++$this->filesCounter;
+            $this->abortIfInterrupted();
+        });
+
+        $scanner->listen('\OC\Files\Utils\Scanner', 'scanFolder', function ($path) use ($output) {
+            $output->writeln("\tFolder\t<info>$path</info>", OutputInterface::VERBOSITY_VERBOSE);
+            ++$this->foldersCounter;
+            $this->abortIfInterrupted();
+        });
+
+        $scanner->listen('\OC\Files\Utils\Scanner', 'StorageNotAvailable', function (StorageNotAvailableException $e) use ($output) {
+            $output->writeln('Error while scanning, storage not available (' . $e->getMessage() . ')', OutputInterface::VERBOSITY_VERBOSE);
+        });
+
+        $scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function ($path) use ($output) {
+            $this->checkScanWarning($path, $output);
+        });
+
+        $scanner->listen('\OC\Files\Utils\Scanner', 'scanFolder', function ($path) use ($output) {
+            $this->checkScanWarning($path, $output);
+        });
+
+        try {
+            if ($backgroundScan) {
+                $scanner->backgroundScan($path);
+            } else {
+                $scanner->scan($path, $recursive, $homeOnly ? [$this, 'filterHomeMount'] : null);
+            }
+        } catch (ForbiddenException $e) {
+            $output->writeln("<error>Home storage for user $user not writable</error>");
+            $output->writeln('Make sure you\'re running the scan command only as the user the web server runs as');
+        } catch (InterruptedException $e) {
+            # exit the function if ctrl-c has been pressed
+            $output->writeln('Interrupted by user');
+        } catch (NotFoundException $e) {
+            $output->writeln('<error>Path not found: ' . $e->getMessage() . '</error>');
+        } catch (\Exception $e) {
+            $output->writeln('<error>Exception during scan: ' . $e->getMessage() . '</error>');
+            $output->writeln('<error>' . $e->getTraceAsString() . '</error>');
+        }
+    }
+
+    public function filterHomeMount(IMountPoint $mountPoint) {
+        // any mountpoint inside '/$user/files/'
+        return substr_count($mountPoint->getMountPoint(), '/') <= 3;
+    }
+
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        $inputPath = $input->getOption('path');
+        if ($inputPath) {
+            $inputPath = '/' . trim($inputPath, '/');
+            list(, $user,) = explode('/', $inputPath, 3);
+            $users = [$user];
+        } elseif ($input->getOption('all')) {
+            $users = $this->userManager->search('');
+        } else {
+            $users = $input->getArgument('user_id');
+        }
+
+        # restrict the verbosity level to VERBOSITY_VERBOSE
+        if ($output->getVerbosity() > OutputInterface::VERBOSITY_VERBOSE) {
+            $output->setVerbosity(OutputInterface::VERBOSITY_VERBOSE);
+        }
+
+        # check quantity of users to be process and show it on the command line
+        $users_total = count($users);
+        if ($users_total === 0) {
+            $output->writeln('<error>Please specify the user id to scan, --all to scan for all users or --path=...</error>');
+            return 1;
+        }
+
+        $this->initTools();
+
+        $user_count = 0;
+        foreach ($users as $user) {
+            if (is_object($user)) {
+                $user = $user->getUID();
+            }
+            $path = $inputPath ? $inputPath : '/' . $user;
+            ++$user_count;
+            if ($this->userManager->userExists($user)) {
+                $output->writeln("Starting scan for user $user_count out of $users_total ($user)");
+                $this->scanFiles($user, $path, $output, $input->getOption('unscanned'), !$input->getOption('shallow'), $input->getOption('home-only'));
+                $output->writeln('', OutputInterface::VERBOSITY_VERBOSE);
+            } else {
+                $output->writeln("<error>Unknown user $user_count $user</error>");
+                $output->writeln('', OutputInterface::VERBOSITY_VERBOSE);
+            }
+
+            try {
+                $this->abortIfInterrupted();
+            } catch (InterruptedException $e) {
+                break;
+            }
+        }
+
+        $this->presentStats($output);
+        return 0;
+    }
+
+    /**
+     * Initialises some useful tools for the Command
+     */
+    protected function initTools() {
+        // Start the timer
+        $this->execTime = -microtime(true);
+        // Convert PHP errors to exceptions
+        set_error_handler([$this, 'exceptionErrorHandler'], E_ALL);
+    }
+
+    /**
+     * Processes PHP errors as exceptions in order to be able to keep track of problems
+     *
+     * @see https://secure.php.net/manual/en/function.set-error-handler.php
+     *
+     * @param int $severity the level of the error raised
+     * @param string $message
+     * @param string $file the filename that the error was raised in
+     * @param int $line the line number the error was raised
+     *
+     * @throws \ErrorException
+     */
+    public function exceptionErrorHandler($severity, $message, $file, $line) {
+        if (!(error_reporting() & $severity)) {
+            // This error code is not included in error_reporting
+            return;
+        }
+        throw new \ErrorException($message, 0, $severity, $file, $line);
+    }
+
+    /**
+     * @param OutputInterface $output
+     */
+    protected function presentStats(OutputInterface $output) {
+        // Stop the timer
+        $this->execTime += microtime(true);
+
+        $headers = [
+            'Folders', 'Files', 'Elapsed time'
+        ];
+
+        $this->showSummary($headers, null, $output);
+    }
+
+    /**
+     * Shows a summary of operations
+     *
+     * @param string[] $headers
+     * @param string[] $rows
+     * @param OutputInterface $output
+     */
+    protected function showSummary($headers, $rows, OutputInterface $output) {
+        $niceDate = $this->formatExecTime();
+        if (!$rows) {
+            $rows = [
+                $this->foldersCounter,
+                $this->filesCounter,
+                $niceDate,
+            ];
+        }
+        $table = new Table($output);
+        $table
+            ->setHeaders($headers)
+            ->setRows([$rows]);
+        $table->render();
+    }
+
+
+    /**
+     * Formats microtime into a human readable format
+     *
+     * @return string
+     */
+    protected function formatExecTime() {
+        $secs = round($this->execTime);
+        # convert seconds into HH:MM:SS form
+        return sprintf('%02d:%02d:%02d', ($secs/3600), ($secs/60%60), $secs%60);
+    }
+
+    /**
+     * @return \OCP\IDBConnection
+     */
+    protected function reconnectToDatabase(OutputInterface $output) {
+        /** @var Connection | IDBConnection $connection */
+        $connection = \OC::$server->getDatabaseConnection();
+        try {
+            $connection->close();
+        } catch (\Exception $ex) {
+            $output->writeln("<info>Error while disconnecting from database: {$ex->getMessage()}</info>");
+        }
+        while (!$connection->isConnected()) {
+            try {
+                $connection->connect();
+            } catch (\Exception $ex) {
+                $output->writeln("<info>Error while re-connecting to database: {$ex->getMessage()}</info>");
+                sleep(60);
+            }
+        }
+        return $connection;
+    }
 }

Spacing +13 added lines, -13 removed lines

@@ -110,7 +110,7 @@ 
 		$path = basename($fullPath);
 
 		if ($normalizedPath !== $path) {
-			$output->writeln("\t<error>Entry \"" . $fullPath . '" will not be accessible due to incompatible encoding</error>');
+			$output->writeln("\t<error>Entry \"".$fullPath.'" will not be accessible due to incompatible encoding</error>');
 		}
 	}
 
@@ -120,27 +120,27 @@ 
 
 		# check on each file/folder if there was a user interrupt (ctrl-c) and throw an exception
 
-		$scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function ($path) use ($output) {
+		$scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function($path) use ($output) {
 			$output->writeln("\tFile\t<info>$path</info>", OutputInterface::VERBOSITY_VERBOSE);
 			++$this->filesCounter;
 			$this->abortIfInterrupted();
 		});
 
-		$scanner->listen('\OC\Files\Utils\Scanner', 'scanFolder', function ($path) use ($output) {
+		$scanner->listen('\OC\Files\Utils\Scanner', 'scanFolder', function($path) use ($output) {
 			$output->writeln("\tFolder\t<info>$path</info>", OutputInterface::VERBOSITY_VERBOSE);
 			++$this->foldersCounter;
 			$this->abortIfInterrupted();
 		});
 
-		$scanner->listen('\OC\Files\Utils\Scanner', 'StorageNotAvailable', function (StorageNotAvailableException $e) use ($output) {
-			$output->writeln('Error while scanning, storage not available (' . $e->getMessage() . ')', OutputInterface::VERBOSITY_VERBOSE);
+		$scanner->listen('\OC\Files\Utils\Scanner', 'StorageNotAvailable', function(StorageNotAvailableException $e) use ($output) {
+			$output->writeln('Error while scanning, storage not available ('.$e->getMessage().')', OutputInterface::VERBOSITY_VERBOSE);
 		});
 
-		$scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function ($path) use ($output) {
+		$scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function($path) use ($output) {
 			$this->checkScanWarning($path, $output);
 		});
 
-		$scanner->listen('\OC\Files\Utils\Scanner', 'scanFolder', function ($path) use ($output) {
+		$scanner->listen('\OC\Files\Utils\Scanner', 'scanFolder', function($path) use ($output) {
 			$this->checkScanWarning($path, $output);
 		});
 
@@ -157,10 +157,10 @@ 
 			# exit the function if ctrl-c has been pressed
 			$output->writeln('Interrupted by user');
 		} catch (NotFoundException $e) {
-			$output->writeln('<error>Path not found: ' . $e->getMessage() . '</error>');
+			$output->writeln('<error>Path not found: '.$e->getMessage().'</error>');
 		} catch (\Exception $e) {
-			$output->writeln('<error>Exception during scan: ' . $e->getMessage() . '</error>');
-			$output->writeln('<error>' . $e->getTraceAsString() . '</error>');
+			$output->writeln('<error>Exception during scan: '.$e->getMessage().'</error>');
+			$output->writeln('<error>'.$e->getTraceAsString().'</error>');
 		}
 	}
 
@@ -172,7 +172,7 @@ 
 	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$inputPath = $input->getOption('path');
 		if ($inputPath) {
-			$inputPath = '/' . trim($inputPath, '/');
+			$inputPath = '/'.trim($inputPath, '/');
 			list(, $user,) = explode('/', $inputPath, 3);
 			$users = [$user];
 		} elseif ($input->getOption('all')) {
@@ -200,7 +200,7 @@ 
 			if (is_object($user)) {
 				$user = $user->getUID();
 			}
-			$path = $inputPath ? $inputPath : '/' . $user;
+			$path = $inputPath ? $inputPath : '/'.$user;
 			++$user_count;
 			if ($this->userManager->userExists($user)) {
 				$output->writeln("Starting scan for user $user_count out of $users_total ($user)");
@@ -298,7 +298,7 @@ 
 	protected function formatExecTime() {
 		$secs = round($this->execTime);
 		# convert seconds into HH:MM:SS form
-		return sprintf('%02d:%02d:%02d', ($secs/3600), ($secs/60%60), $secs%60);
+		return sprintf('%02d:%02d:%02d', ($secs / 3600), ($secs / 60 % 60), $secs % 60);
 	}
 
 	/**

apps/updatenotification/lib/Command/Check.php

Indentation +51 added lines, -51 removed lines

@@ -34,65 +34,65 @@
 
 class Check extends Command {
 
-	/**
-	 * @var Installer $installer
-	 */
-	private $installer;
+    /**
+     * @var Installer $installer
+     */
+    private $installer;
 
-	/**
-	 * @var AppManager $appManager
-	 */
-	private $appManager;
+    /**
+     * @var AppManager $appManager
+     */
+    private $appManager;
 
-	/**
-	 * @var UpdateChecker $updateChecker
-	 */
-	private $updateChecker;
+    /**
+     * @var UpdateChecker $updateChecker
+     */
+    private $updateChecker;
 
-	public function __construct(AppManager $appManager, UpdateChecker $updateChecker, Installer $installer) {
-		parent::__construct();
-		$this->installer = $installer;
-		$this->appManager = $appManager;
-		$this->updateChecker = $updateChecker;
-	}
+    public function __construct(AppManager $appManager, UpdateChecker $updateChecker, Installer $installer) {
+        parent::__construct();
+        $this->installer = $installer;
+        $this->appManager = $appManager;
+        $this->updateChecker = $updateChecker;
+    }
 
-	protected function configure() {
-		$this
-			->setName('update:check')
-			->setDescription('Check for server and app updates')
-		;
-	}
+    protected function configure() {
+        $this
+            ->setName('update:check')
+            ->setDescription('Check for server and app updates')
+        ;
+    }
 
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		$updatesAvailableCount = 0;
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        $updatesAvailableCount = 0;
 
-		// Server
-		$r = $this->updateChecker->getUpdateState();
-		if (isset($r['updateAvailable']) && $r['updateAvailable']) {
-			$output->writeln($r['updateVersionString'] . ' is available. Get more information on how to update at '. $r['updateLink'] . '.');
-			$updatesAvailableCount += 1;
-		}
+        // Server
+        $r = $this->updateChecker->getUpdateState();
+        if (isset($r['updateAvailable']) && $r['updateAvailable']) {
+            $output->writeln($r['updateVersionString'] . ' is available. Get more information on how to update at '. $r['updateLink'] . '.');
+            $updatesAvailableCount += 1;
+        }
 
 
-		// Apps
-		$apps = $this->appManager->getInstalledApps();
-		foreach ($apps as $app) {
-			$update = $this->installer->isUpdateAvailable($app);
-			if ($update !== false) {
-				$output->writeln('Update for ' . $app . ' to version ' . $update . ' is available.');
-				$updatesAvailableCount += 1;
-			}
-		}
+        // Apps
+        $apps = $this->appManager->getInstalledApps();
+        foreach ($apps as $app) {
+            $update = $this->installer->isUpdateAvailable($app);
+            if ($update !== false) {
+                $output->writeln('Update for ' . $app . ' to version ' . $update . ' is available.');
+                $updatesAvailableCount += 1;
+            }
+        }
 
-		// Report summary
-		if ($updatesAvailableCount === 0) {
-			$output->writeln('<info>Everything up to date</info>');
-		} elseif ($updatesAvailableCount === 1) {
-			$output->writeln('<comment>1 update available</comment>');
-		} else {
-			$output->writeln('<comment>' . $updatesAvailableCount . ' updates available</comment>');
-		}
+        // Report summary
+        if ($updatesAvailableCount === 0) {
+            $output->writeln('<info>Everything up to date</info>');
+        } elseif ($updatesAvailableCount === 1) {
+            $output->writeln('<comment>1 update available</comment>');
+        } else {
+            $output->writeln('<comment>' . $updatesAvailableCount . ' updates available</comment>');
+        }
 
-		return 0;
-	}
+        return 0;
+    }
 }

apps/federation/lib/Command/SyncFederationAddressBooks.php

Indentation +33 added lines, -33 removed lines

@@ -33,43 +33,43 @@
 
 class SyncFederationAddressBooks extends Command {
 
-	/** @var \OCA\Federation\SyncFederationAddressBooks */
-	private $syncService;
+    /** @var \OCA\Federation\SyncFederationAddressBooks */
+    private $syncService;
 
-	/**
-	 * @param \OCA\Federation\SyncFederationAddressBooks $syncService
-	 */
-	public function __construct(\OCA\Federation\SyncFederationAddressBooks $syncService) {
-		parent::__construct();
+    /**
+     * @param \OCA\Federation\SyncFederationAddressBooks $syncService
+     */
+    public function __construct(\OCA\Federation\SyncFederationAddressBooks $syncService) {
+        parent::__construct();
 
-		$this->syncService = $syncService;
-	}
+        $this->syncService = $syncService;
+    }
 
-	protected function configure() {
-		$this
-			->setName('federation:sync-addressbooks')
-			->setDescription('Synchronizes addressbooks of all federated clouds');
-	}
+    protected function configure() {
+        $this
+            ->setName('federation:sync-addressbooks')
+            ->setDescription('Synchronizes addressbooks of all federated clouds');
+    }
 
-	/**
-	 * @param InputInterface $input
-	 * @param OutputInterface $output
-	 * @return int
-	 */
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		$progress = new ProgressBar($output);
-		$progress->start();
-		$this->syncService->syncThemAll(function ($url, $ex) use ($progress, $output) {
-			if ($ex instanceof \Exception) {
-				$output->writeln("Error while syncing $url : " . $ex->getMessage());
-			} else {
-				$progress->advance();
-			}
-		});
+    /**
+     * @param InputInterface $input
+     * @param OutputInterface $output
+     * @return int
+     */
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        $progress = new ProgressBar($output);
+        $progress->start();
+        $this->syncService->syncThemAll(function ($url, $ex) use ($progress, $output) {
+            if ($ex instanceof \Exception) {
+                $output->writeln("Error while syncing $url : " . $ex->getMessage());
+            } else {
+                $progress->advance();
+            }
+        });
 
-		$progress->finish();
-		$output->writeln('');
+        $progress->finish();
+        $output->writeln('');
 
-		return 0;
-	}
+        return 0;
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -59,9 +59,9 @@
 	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$progress = new ProgressBar($output);
 		$progress->start();
-		$this->syncService->syncThemAll(function ($url, $ex) use ($progress, $output) {
+		$this->syncService->syncThemAll(function($url, $ex) use ($progress, $output) {
 			if ($ex instanceof \Exception) {
-				$output->writeln("Error while syncing $url : " . $ex->getMessage());
+				$output->writeln("Error while syncing $url : ".$ex->getMessage());
 			} else {
 				$progress->advance();
 			}