Inspection of "Merge pull request #56494 from nextcloud/carl/resu..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 453450...6f0537 )

unknown

created 2025-11-20 14:41 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -53,7 +53,7 @@
 block discarded – undo
 
 		$this->commandTester->execute($input);
 
-		$this->assertMatchesRegularExpression('/' . $pattern . '/', $this->commandTester->getDisplay());
+		$this->assertMatchesRegularExpression('/'.$pattern.'/', $this->commandTester->getDisplay());
 		$this->assertSame($statusCode, $this->commandTester->getStatusCode());
 	}
 

Please login to merge, or discard this patch.

tests/Core/Command/Log/ManageTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -157,7 +157,7 @@
 block discarded – undo
 		];
 		$this->consoleOutput->expects($this->exactly(3))
 			->method('writeln')
-			->willReturnCallback(function (string $message) use (&$calls): void {
+			->willReturnCallback(function(string $message) use (&$calls): void {
 				$call = array_shift($calls);
 				$this->assertStringContainsString($call[0], $message);
 			});

Please login to merge, or discard this patch.

tests/Core/Command/Group/AddUserTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -40,7 +40,7 @@
 block discarded – undo
 
 		$this->input = $this->createMock(InputInterface::class);
 		$this->input->method('getArgument')
-			->willReturnCallback(function ($arg) {
+			->willReturnCallback(function($arg) {
 				if ($arg === 'group') {
 					return 'myGroup';
 				} elseif ($arg === 'user') {

Please login to merge, or discard this patch.

tests/Core/Command/Group/InfoTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -42,7 +42,7 @@  discard block
 block discarded – undo
 	public function testDoesNotExists(): void {
 		$gid = 'myGroup';
 		$this->input->method('getArgument')
-			->willReturnCallback(function ($arg) use ($gid) {
+			->willReturnCallback(function($arg) use ($gid) {
 				if ($arg === 'groupid') {
 					return $gid;
 				}
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
 
 		$this->output->expects($this->once())
 			->method('writeln')
-			->with($this->equalTo('<error>Group "' . $gid . '" does not exist.</error>'));
+			->with($this->equalTo('<error>Group "'.$gid.'" does not exist.</error>'));
 
 		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
 	}
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
 	public function testInfo(): void {
 		$gid = 'myGroup';
 		$this->input->method('getArgument')
-			->willReturnCallback(function ($arg) use ($gid) {
+			->willReturnCallback(function($arg) use ($gid) {
 				if ($arg === 'groupid') {
 					return $gid;
 				}

Please login to merge, or discard this patch.

tests/Core/Command/Group/ListCommandTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -74,7 +74,7 @@  discard block
 block discarded – undo
 			]);
 
 		$this->input->method('getOption')
-			->willReturnCallback(function ($arg) {
+			->willReturnCallback(function($arg) {
 				if ($arg === 'limit') {
 					return '100';
 				} elseif ($arg === 'offset') {
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
 			->willReturn(['LDAP']);
 
 		$this->input->method('getOption')
-			->willReturnCallback(function ($arg) {
+			->willReturnCallback(function($arg) {
 				if ($arg === 'limit') {
 					return '100';
 				} elseif ($arg === 'offset') {

Please login to merge, or discard this patch.

tests/Core/Command/Group/AddTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@  discard block
 block discarded – undo
 
 		$this->input = $this->createMock(InputInterface::class);
 		$this->input->method('getArgument')
-			->willReturnCallback(function ($arg) {
+			->willReturnCallback(function($arg) {
 				if ($arg === 'groupid') {
 					return 'myGroup';
 				}
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
 			->method('createGroup');
 		$this->output->expects($this->once())
 			->method('writeln')
-			->with($this->equalTo('<error>Group "' . $gid . '" already exists.</error>'));
+			->with($this->equalTo('<error>Group "'.$gid.'" already exists.</error>'));
 
 		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
 	}
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 			->with($this->equalTo($gid));
 		$this->output->expects($this->once())
 			->method('writeln')
-			->with($this->equalTo('Created group "' . $group->getGID() . '"'));
+			->with($this->equalTo('Created group "'.$group->getGID().'"'));
 
 		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
 	}

Please login to merge, or discard this patch.

tests/Core/Command/Group/DeleteTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -39,7 +39,7 @@  discard block
 block discarded – undo
 	public function testDoesNotExists(): void {
 		$gid = 'myGroup';
 		$this->input->method('getArgument')
-			->willReturnCallback(function ($arg) use ($gid) {
+			->willReturnCallback(function($arg) use ($gid) {
 				if ($arg === 'groupid') {
 					return $gid;
 				}
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
 			->method('get');
 		$this->output->expects($this->once())
 			->method('writeln')
-			->with($this->equalTo('<error>Group "' . $gid . '" does not exist.</error>'));
+			->with($this->equalTo('<error>Group "'.$gid.'" does not exist.</error>'));
 
 		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
 	}
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
 	public function testDeleteAdmin(): void {
 		$gid = 'admin';
 		$this->input->method('getArgument')
-			->willReturnCallback(function ($arg) use ($gid) {
+			->willReturnCallback(function($arg) use ($gid) {
 				if ($arg === 'groupid') {
 					return $gid;
 				}
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 			->method($this->anything());
 		$this->output->expects($this->once())
 			->method('writeln')
-			->with($this->equalTo('<error>Group "' . $gid . '" could not be deleted.</error>'));
+			->with($this->equalTo('<error>Group "'.$gid.'" could not be deleted.</error>'));
 
 		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
 	}
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
 	public function testDeleteFailed(): void {
 		$gid = 'myGroup';
 		$this->input->method('getArgument')
-			->willReturnCallback(function ($arg) use ($gid) {
+			->willReturnCallback(function($arg) use ($gid) {
 				if ($arg === 'groupid') {
 					return $gid;
 				}
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
 
 		$this->output->expects($this->once())
 			->method('writeln')
-			->with($this->equalTo('<error>Group "' . $gid . '" could not be deleted. Please check the logs.</error>'));
+			->with($this->equalTo('<error>Group "'.$gid.'" could not be deleted. Please check the logs.</error>'));
 
 		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
 	}
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
 	public function testDelete(): void {
 		$gid = 'myGroup';
 		$this->input->method('getArgument')
-			->willReturnCallback(function ($arg) use ($gid) {
+			->willReturnCallback(function($arg) use ($gid) {
 				if ($arg === 'groupid') {
 					return $gid;
 				}
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
 
 		$this->output->expects($this->once())
 			->method('writeln')
-			->with($this->equalTo('Group "' . $gid . '" was removed'));
+			->with($this->equalTo('Group "'.$gid.'" was removed'));
 
 		$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
 	}

Please login to merge, or discard this patch.

tests/redis-cluster.config.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -8,7 +8,7 @@
 block discarded – undo
 	'memcache.distributed' => '\\OC\\Memcache\\Redis',
 	'memcache.locking' => '\\OC\\Memcache\\Redis',
 	'redis.cluster' => [
-		'seeds' => [ // provide some/all of the cluster servers to bootstrap discovery, port required
+		'seeds' => [// provide some/all of the cluster servers to bootstrap discovery, port required
 			'cache-cluster:7000',
 			'cache-cluster:7001',
 			'cache-cluster:7002',

Please login to merge, or discard this patch.

tests/preseed-config.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -8,16 +8,16 @@  discard block
 block discarded – undo
 	'appstoreenabled' => false,
 	'apps_paths' => [
 		[
-			'path' => OC::$SERVERROOT . '/apps',
+			'path' => OC::$SERVERROOT.'/apps',
 			'url' => '/apps',
 			'writable' => true,
 		],
 	],
 ];
 
-if (is_dir(OC::$SERVERROOT . '/apps2')) {
+if (is_dir(OC::$SERVERROOT.'/apps2')) {
 	$CONFIG['apps_paths'][] = [
-		'path' => OC::$SERVERROOT . '/apps2',
+		'path' => OC::$SERVERROOT.'/apps2',
 		'url' => '/apps2',
 		'writable' => false,
 	];
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
 			'container' => 'test',
 			'account_name' => getenv('OBJECT_STORE_KEY') ?: 'devstoreaccount1',
 			'account_key' => getenv('OBJECT_STORE_SECRET') ?: 'Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==',
-			'endpoint' => 'http://' . (getenv('OBJECT_STORE_HOST') ?: 'localhost') . ':10000/' . (getenv('OBJECT_STORE_KEY') ?: 'devstoreaccount1'),
+			'endpoint' => 'http://'.(getenv('OBJECT_STORE_HOST') ?: 'localhost').':10000/'.(getenv('OBJECT_STORE_KEY') ?: 'devstoreaccount1'),
 			'autocreate' => true
 		]
 	];

Please login to merge, or discard this patch.

		@@ -53,7 +53,7 @@
		block discarded – undo
53	53
54	54	$this->commandTester->execute($input);
55	55
56		- $this->assertMatchesRegularExpression('/' . $pattern . '/', $this->commandTester->getDisplay());
	56	+ $this->assertMatchesRegularExpression('/'.$pattern.'/', $this->commandTester->getDisplay());
57	57	$this->assertSame($statusCode, $this->commandTester->getStatusCode());
58	58	}
59	59

		@@ -157,7 +157,7 @@
		block discarded – undo
157	157	];
158	158	$this->consoleOutput->expects($this->exactly(3))
159	159	->method('writeln')
160		- ->willReturnCallback(function (string $message) use (&$calls): void {
	160	+ ->willReturnCallback(function(string $message) use (&$calls): void {
161	161	$call = array_shift($calls);
162	162	$this->assertStringContainsString($call[0], $message);
163	163	});

		@@ -40,7 +40,7 @@
		block discarded – undo
40	40
41	41	$this->input = $this->createMock(InputInterface::class);
42	42	$this->input->method('getArgument')
43		- ->willReturnCallback(function ($arg) {
	43	+ ->willReturnCallback(function($arg) {
44	44	if ($arg === 'group') {
45	45	return 'myGroup';
46	46	} elseif ($arg === 'user') {

		@@ -42,7 +42,7 @@ discard block
		block discarded – undo
42	42	public function testDoesNotExists(): void {
43	43	$gid = 'myGroup';
44	44	$this->input->method('getArgument')
45		- ->willReturnCallback(function ($arg) use ($gid) {
	45	+ ->willReturnCallback(function($arg) use ($gid) {
46	46	if ($arg === 'groupid') {
47	47	return $gid;
48	48	}
		@@ -54,7 +54,7 @@ discard block
		block discarded – undo
54	54
55	55	$this->output->expects($this->once())
56	56	->method('writeln')
57		- ->with($this->equalTo('<error>Group "' . $gid . '" does not exist.</error>'));
	57	+ ->with($this->equalTo('<error>Group "'.$gid.'" does not exist.</error>'));
58	58
59	59	$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
60	60	}
		@@ -62,7 +62,7 @@ discard block
		block discarded – undo
62	62	public function testInfo(): void {
63	63	$gid = 'myGroup';
64	64	$this->input->method('getArgument')
65		- ->willReturnCallback(function ($arg) use ($gid) {
	65	+ ->willReturnCallback(function($arg) use ($gid) {
66	66	if ($arg === 'groupid') {
67	67	return $gid;
68	68	}

		@@ -74,7 +74,7 @@ discard block
		block discarded – undo
74	74	]);
75	75
76	76	$this->input->method('getOption')
77		- ->willReturnCallback(function ($arg) {
	77	+ ->willReturnCallback(function($arg) {
78	78	if ($arg === 'limit') {
79	79	return '100';
80	80	} elseif ($arg === 'offset') {
		@@ -155,7 +155,7 @@ discard block
		block discarded – undo
155	155	->willReturn(['LDAP']);
156	156
157	157	$this->input->method('getOption')
158		- ->willReturnCallback(function ($arg) {
	158	+ ->willReturnCallback(function($arg) {
159	159	if ($arg === 'limit') {
160	160	return '100';
161	161	} elseif ($arg === 'offset') {

		@@ -34,7 +34,7 @@ discard block
		block discarded – undo
34	34
35	35	$this->input = $this->createMock(InputInterface::class);
36	36	$this->input->method('getArgument')
37		- ->willReturnCallback(function ($arg) {
	37	+ ->willReturnCallback(function($arg) {
38	38	if ($arg === 'groupid') {
39	39	return 'myGroup';
40	40	}
		@@ -54,7 +54,7 @@ discard block
		block discarded – undo
54	54	->method('createGroup');
55	55	$this->output->expects($this->once())
56	56	->method('writeln')
57		- ->with($this->equalTo('<error>Group "' . $gid . '" already exists.</error>'));
	57	+ ->with($this->equalTo('<error>Group "'.$gid.'" already exists.</error>'));
58	58
59	59	$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
60	60	}
		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	->with($this->equalTo($gid));
73	73	$this->output->expects($this->once())
74	74	->method('writeln')
75		- ->with($this->equalTo('Created group "' . $group->getGID() . '"'));
	75	+ ->with($this->equalTo('Created group "'.$group->getGID().'"'));
76	76
77	77	$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
78	78	}

		@@ -39,7 +39,7 @@ discard block
		block discarded – undo
39	39	public function testDoesNotExists(): void {
40	40	$gid = 'myGroup';
41	41	$this->input->method('getArgument')
42		- ->willReturnCallback(function ($arg) use ($gid) {
	42	+ ->willReturnCallback(function($arg) use ($gid) {
43	43	if ($arg === 'groupid') {
44	44	return $gid;
45	45	}
		@@ -53,7 +53,7 @@ discard block
		block discarded – undo
53	53	->method('get');
54	54	$this->output->expects($this->once())
55	55	->method('writeln')
56		- ->with($this->equalTo('<error>Group "' . $gid . '" does not exist.</error>'));
	56	+ ->with($this->equalTo('<error>Group "'.$gid.'" does not exist.</error>'));
57	57
58	58	$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
59	59	}
		@@ -61,7 +61,7 @@ discard block
		block discarded – undo
61	61	public function testDeleteAdmin(): void {
62	62	$gid = 'admin';
63	63	$this->input->method('getArgument')
64		- ->willReturnCallback(function ($arg) use ($gid) {
	64	+ ->willReturnCallback(function($arg) use ($gid) {
65	65	if ($arg === 'groupid') {
66	66	return $gid;
67	67	}
		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	->method($this->anything());
73	73	$this->output->expects($this->once())
74	74	->method('writeln')
75		- ->with($this->equalTo('<error>Group "' . $gid . '" could not be deleted.</error>'));
	75	+ ->with($this->equalTo('<error>Group "'.$gid.'" could not be deleted.</error>'));
76	76
77	77	$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
78	78	}
		@@ -80,7 +80,7 @@ discard block
		block discarded – undo
80	80	public function testDeleteFailed(): void {
81	81	$gid = 'myGroup';
82	82	$this->input->method('getArgument')
83		- ->willReturnCallback(function ($arg) use ($gid) {
	83	+ ->willReturnCallback(function($arg) use ($gid) {
84	84	if ($arg === 'groupid') {
85	85	return $gid;
86	86	}
		@@ -98,7 +98,7 @@ discard block
		block discarded – undo
98	98
99	99	$this->output->expects($this->once())
100	100	->method('writeln')
101		- ->with($this->equalTo('<error>Group "' . $gid . '" could not be deleted. Please check the logs.</error>'));
	101	+ ->with($this->equalTo('<error>Group "'.$gid.'" could not be deleted. Please check the logs.</error>'));
102	102
103	103	$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
104	104	}
		@@ -106,7 +106,7 @@ discard block
		block discarded – undo
106	106	public function testDelete(): void {
107	107	$gid = 'myGroup';
108	108	$this->input->method('getArgument')
109		- ->willReturnCallback(function ($arg) use ($gid) {
	109	+ ->willReturnCallback(function($arg) use ($gid) {
110	110	if ($arg === 'groupid') {
111	111	return $gid;
112	112	}
		@@ -124,7 +124,7 @@ discard block
		block discarded – undo
124	124
125	125	$this->output->expects($this->once())
126	126	->method('writeln')
127		- ->with($this->equalTo('Group "' . $gid . '" was removed'));
	127	+ ->with($this->equalTo('Group "'.$gid.'" was removed'));
128	128
129	129	$this->invokePrivate($this->command, 'execute', [$this->input, $this->output]);
130	130	}

		@@ -8,7 +8,7 @@
		block discarded – undo
8	8	'memcache.distributed' => '\\OC\\Memcache\\Redis',
9	9	'memcache.locking' => '\\OC\\Memcache\\Redis',
10	10	'redis.cluster' => [
11		- 'seeds' => [ // provide some/all of the cluster servers to bootstrap discovery, port required
	11	+ 'seeds' => [// provide some/all of the cluster servers to bootstrap discovery, port required
12	12	'cache-cluster:7000',
13	13	'cache-cluster:7001',
14	14	'cache-cluster:7002',

		@@ -8,16 +8,16 @@ discard block
		block discarded – undo
8	8	'appstoreenabled' => false,
9	9	'apps_paths' => [
10	10	[
11		- 'path' => OC::$SERVERROOT . '/apps',
	11	+ 'path' => OC::$SERVERROOT.'/apps',
12	12	'url' => '/apps',
13	13	'writable' => true,
14	14	],
15	15	],
16	16	];
17	17
18		-if (is_dir(OC::$SERVERROOT . '/apps2')) {
	18	+if (is_dir(OC::$SERVERROOT.'/apps2')) {
19	19	$CONFIG['apps_paths'][] = [
20		- 'path' => OC::$SERVERROOT . '/apps2',
	20	+ 'path' => OC::$SERVERROOT.'/apps2',
21	21	'url' => '/apps2',
22	22	'writable' => false,
23	23	];
		@@ -60,7 +60,7 @@ discard block
		block discarded – undo
60	60	'container' => 'test',
61	61	'account_name' => getenv('OBJECT_STORE_KEY') ?: 'devstoreaccount1',
62	62	'account_key' => getenv('OBJECT_STORE_SECRET') ?: 'Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==',
63		- 'endpoint' => 'http://' . (getenv('OBJECT_STORE_HOST') ?: 'localhost') . ':10000/' . (getenv('OBJECT_STORE_KEY') ?: 'devstoreaccount1'),
	63	+ 'endpoint' => 'http://'.(getenv('OBJECT_STORE_HOST') ?: 'localhost').':10000/'.(getenv('OBJECT_STORE_KEY') ?: 'devstoreaccount1'),
64	64	'autocreate' => true
65	65	]
66	66	];

nextcloud / server

Push — master ( 453450...6f0537 )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch