nextcloud / server

apps/dav/tests/unit/DAV/CustomPropertiesBackendTest.php

Indentation +434 added lines, -434 removed lines

@@ -27,438 +27,438 @@
 
 #[\PHPUnit\Framework\Attributes\Group('DB')]
 class CustomPropertiesBackendTest extends TestCase {
-	private const BASE_URI = '/remote.php/dav/';
-
-	private Server&MockObject $server;
-	private Tree&MockObject $tree;
-	private IDBConnection $dbConnection;
-	private IUser&MockObject $user;
-	private DefaultCalendarValidator&MockObject $defaultCalendarValidator;
-	private CustomPropertiesBackend $backend;
-	private PropertyMapper $propertyMapper;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->server = $this->createMock(Server::class);
-		$this->server->method('getBaseUri')
-			->willReturn(self::BASE_URI);
-		$this->tree = $this->createMock(Tree::class);
-		$this->user = $this->createMock(IUser::class);
-		$this->user->method('getUID')
-			->with()
-			->willReturn('dummy_user_42');
-		$this->dbConnection = \OCP\Server::get(IDBConnection::class);
-		$this->propertyMapper = \OCP\Server::get(PropertyMapper::class);
-		$this->defaultCalendarValidator = $this->createMock(DefaultCalendarValidator::class);
-
-		$this->backend = new CustomPropertiesBackend(
-			$this->server,
-			$this->tree,
-			$this->dbConnection,
-			$this->user,
-			$this->propertyMapper,
-			$this->defaultCalendarValidator,
-		);
-	}
-
-	protected function tearDown(): void {
-		$query = $this->dbConnection->getQueryBuilder();
-		$query->delete('properties');
-		$query->executeStatement();
-
-		parent::tearDown();
-	}
-
-	private function formatPath(string $path): string {
-		if (strlen($path) > 250) {
-			return sha1($path);
-		} else {
-			return $path;
-		}
-	}
-
-	protected function insertProps(string $user, string $path, array $props): void {
-		foreach ($props as $name => $value) {
-			$this->insertProp($user, $path, $name, $value);
-		}
-	}
-
-	protected function insertProp(string $user, string $path, string $name, mixed $value): void {
-		$type = CustomPropertiesBackend::PROPERTY_TYPE_STRING;
-		if ($value instanceof Href) {
-			$value = $value->getHref();
-			$type = CustomPropertiesBackend::PROPERTY_TYPE_HREF;
-		}
-
-		$query = $this->dbConnection->getQueryBuilder();
-		$query->insert('properties')
-			->values([
-				'userid' => $query->createNamedParameter($user),
-				'propertypath' => $query->createNamedParameter($this->formatPath($path)),
-				'propertyname' => $query->createNamedParameter($name),
-				'propertyvalue' => $query->createNamedParameter($value),
-				'valuetype' => $query->createNamedParameter($type, IQueryBuilder::PARAM_INT)
-			]);
-		$query->executeStatement();
-	}
-
-	protected function getProps(string $user, string $path): array {
-		$query = $this->dbConnection->getQueryBuilder();
-		$query->select('propertyname', 'propertyvalue', 'valuetype')
-			->from('properties')
-			->where($query->expr()->eq('userid', $query->createNamedParameter($user)))
-			->andWhere($query->expr()->eq('propertypath', $query->createNamedParameter($this->formatPath($path))));
-
-		$result = $query->executeQuery();
-		$data = [];
-		while ($row = $result->fetchAssociative()) {
-			$value = $row['propertyvalue'];
-			if ((int)$row['valuetype'] === CustomPropertiesBackend::PROPERTY_TYPE_HREF) {
-				$value = new Href($value);
-			}
-			$data[$row['propertyname']] = $value;
-		}
-		$result->closeCursor();
-
-		return $data;
-	}
-
-	public function testPropFindNoDbCalls(): void {
-		$db = $this->createMock(IDBConnection::class);
-		$backend = new CustomPropertiesBackend(
-			$this->server,
-			$this->tree,
-			$db,
-			$this->user,
-			$this->propertyMapper,
-			$this->defaultCalendarValidator,
-		);
-
-		$propFind = $this->createMock(PropFind::class);
-		$propFind->expects($this->once())
-			->method('get404Properties')
-			->with()
-			->willReturn([
-				'{http://owncloud.org/ns}permissions',
-				'{http://owncloud.org/ns}downloadURL',
-				'{http://owncloud.org/ns}dDC',
-				'{http://owncloud.org/ns}size',
-			]);
-
-		$db->expects($this->never())
-			->method($this->anything());
-
-		$backend->propFind('foo_bar_path_1337_0', $propFind);
-	}
-
-	public function testPropFindCalendarCall(): void {
-		$propFind = $this->createMock(PropFind::class);
-		$propFind->method('get404Properties')
-			->with()
-			->willReturn([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-				'{abc}def',
-			]);
-
-		$propFind->method('getRequestedProperties')
-			->with()
-			->willReturn([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-				'{DAV:}displayname',
-				'{urn:ietf:params:xml:ns:caldav}calendar-description',
-				'{urn:ietf:params:xml:ns:caldav}calendar-timezone',
-				'{abc}def',
-			]);
-
-		$props = [
-			'{abc}def' => 'a',
-			'{DAV:}displayname' => 'b',
-			'{urn:ietf:params:xml:ns:caldav}calendar-description' => 'c',
-			'{urn:ietf:params:xml:ns:caldav}calendar-timezone' => 'd',
-		];
-
-		$this->insertProps('dummy_user_42', 'calendars/foo/bar_path_1337_0', $props);
-
-		$setProps = [];
-		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
-				$setProps[$name] = $value;
-			});
-
-		$this->backend->propFind('calendars/foo/bar_path_1337_0', $propFind);
-		$this->assertEquals($props, $setProps);
-	}
-
-	public function testPropFindPrincipalCall(): void {
-		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) {
-				$node = $this->createMock(Calendar::class);
-				$node->method('getOwner')
-					->willReturn('principals/users/dummy_user_42');
-				return $node;
-			});
-
-		$propFind = $this->createMock(PropFind::class);
-		$propFind->method('get404Properties')
-			->with()
-			->willReturn([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-				'{abc}def',
-			]);
-
-		$propFind->method('getRequestedProperties')
-			->with()
-			->willReturn([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-				'{abc}def',
-				'{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL',
-			]);
-
-		$props = [
-			'{abc}def' => 'a',
-			'{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/admin/personal'),
-		];
-		$this->insertProps('dummy_user_42', 'principals/users/dummy_user_42', $props);
-
-		$setProps = [];
-		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
-				$setProps[$name] = $value;
-			});
-
-		$this->backend->propFind('principals/users/dummy_user_42', $propFind);
-		$this->assertEquals($props, $setProps);
-	}
-
-	public static function propFindPrincipalScheduleDefaultCalendarProviderUrlProvider(): array {
-		// [ user, nodes, existingProps, requestedProps, returnedProps ]
-		return [
-			[ // Exists
-				'dummy_user_42',
-				['calendars/dummy_user_42/foo/' => Calendar::class],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
-			],
-			[ // Doesn't exist
-				'dummy_user_42',
-				['calendars/dummy_user_42/foo/' => Calendar::class],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/bar/')],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
-				[],
-			],
-			[ // No privilege
-				'dummy_user_42',
-				['calendars/user2/baz/' => Calendar::class],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/user2/baz/')],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
-				[],
-			],
-			[ // Not a calendar
-				'dummy_user_42',
-				['foo/dummy_user_42/bar/' => IACL::class],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/dummy_user_42/bar/')],
-				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
-				[],
-			],
-		];
-
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('propFindPrincipalScheduleDefaultCalendarProviderUrlProvider')]
-	public function testPropFindPrincipalScheduleDefaultCalendarUrl(
-		string $user,
-		array $nodes,
-		array $existingProps,
-		array $requestedProps,
-		array $returnedProps,
-	): void {
-		$propFind = $this->createMock(PropFind::class);
-		$propFind->method('get404Properties')
-			->with()
-			->willReturn([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-			]);
-
-		$propFind->method('getRequestedProperties')
-			->with()
-			->willReturn(array_merge([
-				'{DAV:}getcontentlength',
-				'{DAV:}getcontenttype',
-				'{DAV:}getetag',
-				'{abc}def',
-			],
-				$requestedProps,
-			));
-
-		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
-				if (!str_starts_with($uri, self::BASE_URI)) {
-					return trim(substr($uri, strlen(self::BASE_URI)), '/');
-				}
-				return null;
-			});
-		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) use ($nodes) {
-				if (str_starts_with($uri, 'principals/')) {
-					return $this->createMock(IPrincipal::class);
-				}
-				if (array_key_exists($uri, $nodes)) {
-					$owner = explode('/', $uri)[1];
-					$node = $this->createMock($nodes[$uri]);
-					$node->method('getOwner')
-						->willReturn("principals/users/$owner");
-					return $node;
-				}
-				throw new NotFound('Node not found');
-			});
-
-		$this->insertProps($user, "principals/users/$user", $existingProps);
-
-		$setProps = [];
-		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
-				$setProps[$name] = $value;
-			});
-
-		$this->backend->propFind("principals/users/$user", $propFind);
-		$this->assertEquals($returnedProps, $setProps);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('propPatchProvider')]
-	public function testPropPatch(string $path, array $existing, array $props, array $result): void {
-		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
-				if (str_starts_with($uri, self::BASE_URI)) {
-					return trim(substr($uri, strlen(self::BASE_URI)), '/');
-				}
-				return null;
-			});
-		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) {
-				$node = $this->createMock(Calendar::class);
-				$node->method('getOwner')
-					->willReturn('principals/users/' . $this->user->getUID());
-				return $node;
-			});
-
-		$this->insertProps($this->user->getUID(), $path, $existing);
-		$propPatch = new PropPatch($props);
-
-		$this->backend->propPatch($path, $propPatch);
-		$propPatch->commit();
-
-		$storedProps = $this->getProps($this->user->getUID(), $path);
-		$this->assertEquals($result, $storedProps);
-	}
-
-	public static function propPatchProvider(): array {
-		$longPath = str_repeat('long_path', 100);
-		return [
-			['foo_bar_path_1337', [], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
-			['foo_bar_path_1337', ['{DAV:}displayname' => 'foo'], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
-			['foo_bar_path_1337', ['{DAV:}displayname' => 'foo'], ['{DAV:}displayname' => null], []],
-			[$longPath, [], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
-			['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
-			['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href(self::BASE_URI . 'foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
-		];
-	}
-
-	public function testPropPatchWithUnsuitableCalendar(): void {
-		$path = 'principals/users/' . $this->user->getUID();
-
-		$node = $this->createMock(Calendar::class);
-		$node->expects(self::once())
-			->method('getOwner')
-			->willReturn($path);
-
-		$this->defaultCalendarValidator->expects(self::once())
-			->method('validateScheduleDefaultCalendar')
-			->with($node)
-			->willThrowException(new \Sabre\DAV\Exception('Invalid calendar'));
-
-		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
-				if (str_starts_with($uri, self::BASE_URI)) {
-					return trim(substr($uri, strlen(self::BASE_URI)), '/');
-				}
-				return null;
-			});
-		$this->tree->expects(self::once())
-			->method('getNodeForPath')
-			->with('foo/bar/')
-			->willReturn($node);
-
-		$storedProps = $this->getProps($this->user->getUID(), $path);
-		$this->assertEquals([], $storedProps);
-
-		$propPatch = new PropPatch([
-			'{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/'),
-		]);
-		$this->backend->propPatch($path, $propPatch);
-		try {
-			$propPatch->commit();
-		} catch (\Throwable $e) {
-			$this->assertInstanceOf(\Sabre\DAV\Exception::class, $e);
-		}
-
-		$storedProps = $this->getProps($this->user->getUID(), $path);
-		$this->assertEquals([], $storedProps);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('deleteProvider')]
-	public function testDelete(string $path): void {
-		$this->insertProps('dummy_user_42', $path, ['foo' => 'bar']);
-		$this->backend->delete($path);
-		$this->assertEquals([], $this->getProps('dummy_user_42', $path));
-	}
-
-	public static function deleteProvider(): array {
-		return [
-			['foo_bar_path_1337'],
-			[str_repeat('long_path', 100)]
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('moveProvider')]
-	public function testMove(string $source, string $target): void {
-		$this->insertProps('dummy_user_42', $source, ['foo' => 'bar']);
-		$this->backend->move($source, $target);
-		$this->assertEquals([], $this->getProps('dummy_user_42', $source));
-		$this->assertEquals(['foo' => 'bar'], $this->getProps('dummy_user_42', $target));
-	}
-
-	public static function moveProvider(): array {
-		return [
-			['foo_bar_path_1337', 'foo_bar_path_7333'],
-			[str_repeat('long_path1', 100), str_repeat('long_path2', 100)]
-		];
-	}
-
-	public function testDecodeValueFromDatabaseObjectCurrent(): void {
-		$propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"\x00*\x00value";s:6:"opaque";}';
-		$propertyType = 3;
-		$decodeValue = $this->invokePrivate($this->backend, 'decodeValueFromDatabase', [$propertyValue, $propertyType]);
-		$this->assertInstanceOf(\Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp::class, $decodeValue);
-		$this->assertEquals('opaque', $decodeValue->getValue());
-	}
-
-	public function testDecodeValueFromDatabaseObjectLegacy(): void {
-		$propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"' . chr(0) . '*' . chr(0) . 'value";s:6:"opaque";}';
-		$propertyType = 3;
-		$decodeValue = $this->invokePrivate($this->backend, 'decodeValueFromDatabase', [$propertyValue, $propertyType]);
-		$this->assertInstanceOf(\Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp::class, $decodeValue);
-		$this->assertEquals('opaque', $decodeValue->getValue());
-	}
+    private const BASE_URI = '/remote.php/dav/';
+
+    private Server&MockObject $server;
+    private Tree&MockObject $tree;
+    private IDBConnection $dbConnection;
+    private IUser&MockObject $user;
+    private DefaultCalendarValidator&MockObject $defaultCalendarValidator;
+    private CustomPropertiesBackend $backend;
+    private PropertyMapper $propertyMapper;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->server = $this->createMock(Server::class);
+        $this->server->method('getBaseUri')
+            ->willReturn(self::BASE_URI);
+        $this->tree = $this->createMock(Tree::class);
+        $this->user = $this->createMock(IUser::class);
+        $this->user->method('getUID')
+            ->with()
+            ->willReturn('dummy_user_42');
+        $this->dbConnection = \OCP\Server::get(IDBConnection::class);
+        $this->propertyMapper = \OCP\Server::get(PropertyMapper::class);
+        $this->defaultCalendarValidator = $this->createMock(DefaultCalendarValidator::class);
+
+        $this->backend = new CustomPropertiesBackend(
+            $this->server,
+            $this->tree,
+            $this->dbConnection,
+            $this->user,
+            $this->propertyMapper,
+            $this->defaultCalendarValidator,
+        );
+    }
+
+    protected function tearDown(): void {
+        $query = $this->dbConnection->getQueryBuilder();
+        $query->delete('properties');
+        $query->executeStatement();
+
+        parent::tearDown();
+    }
+
+    private function formatPath(string $path): string {
+        if (strlen($path) > 250) {
+            return sha1($path);
+        } else {
+            return $path;
+        }
+    }
+
+    protected function insertProps(string $user, string $path, array $props): void {
+        foreach ($props as $name => $value) {
+            $this->insertProp($user, $path, $name, $value);
+        }
+    }
+
+    protected function insertProp(string $user, string $path, string $name, mixed $value): void {
+        $type = CustomPropertiesBackend::PROPERTY_TYPE_STRING;
+        if ($value instanceof Href) {
+            $value = $value->getHref();
+            $type = CustomPropertiesBackend::PROPERTY_TYPE_HREF;
+        }
+
+        $query = $this->dbConnection->getQueryBuilder();
+        $query->insert('properties')
+            ->values([
+                'userid' => $query->createNamedParameter($user),
+                'propertypath' => $query->createNamedParameter($this->formatPath($path)),
+                'propertyname' => $query->createNamedParameter($name),
+                'propertyvalue' => $query->createNamedParameter($value),
+                'valuetype' => $query->createNamedParameter($type, IQueryBuilder::PARAM_INT)
+            ]);
+        $query->executeStatement();
+    }
+
+    protected function getProps(string $user, string $path): array {
+        $query = $this->dbConnection->getQueryBuilder();
+        $query->select('propertyname', 'propertyvalue', 'valuetype')
+            ->from('properties')
+            ->where($query->expr()->eq('userid', $query->createNamedParameter($user)))
+            ->andWhere($query->expr()->eq('propertypath', $query->createNamedParameter($this->formatPath($path))));
+
+        $result = $query->executeQuery();
+        $data = [];
+        while ($row = $result->fetchAssociative()) {
+            $value = $row['propertyvalue'];
+            if ((int)$row['valuetype'] === CustomPropertiesBackend::PROPERTY_TYPE_HREF) {
+                $value = new Href($value);
+            }
+            $data[$row['propertyname']] = $value;
+        }
+        $result->closeCursor();
+
+        return $data;
+    }
+
+    public function testPropFindNoDbCalls(): void {
+        $db = $this->createMock(IDBConnection::class);
+        $backend = new CustomPropertiesBackend(
+            $this->server,
+            $this->tree,
+            $db,
+            $this->user,
+            $this->propertyMapper,
+            $this->defaultCalendarValidator,
+        );
+
+        $propFind = $this->createMock(PropFind::class);
+        $propFind->expects($this->once())
+            ->method('get404Properties')
+            ->with()
+            ->willReturn([
+                '{http://owncloud.org/ns}permissions',
+                '{http://owncloud.org/ns}downloadURL',
+                '{http://owncloud.org/ns}dDC',
+                '{http://owncloud.org/ns}size',
+            ]);
+
+        $db->expects($this->never())
+            ->method($this->anything());
+
+        $backend->propFind('foo_bar_path_1337_0', $propFind);
+    }
+
+    public function testPropFindCalendarCall(): void {
+        $propFind = $this->createMock(PropFind::class);
+        $propFind->method('get404Properties')
+            ->with()
+            ->willReturn([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+                '{abc}def',
+            ]);
+
+        $propFind->method('getRequestedProperties')
+            ->with()
+            ->willReturn([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+                '{DAV:}displayname',
+                '{urn:ietf:params:xml:ns:caldav}calendar-description',
+                '{urn:ietf:params:xml:ns:caldav}calendar-timezone',
+                '{abc}def',
+            ]);
+
+        $props = [
+            '{abc}def' => 'a',
+            '{DAV:}displayname' => 'b',
+            '{urn:ietf:params:xml:ns:caldav}calendar-description' => 'c',
+            '{urn:ietf:params:xml:ns:caldav}calendar-timezone' => 'd',
+        ];
+
+        $this->insertProps('dummy_user_42', 'calendars/foo/bar_path_1337_0', $props);
+
+        $setProps = [];
+        $propFind->method('set')
+            ->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+                $setProps[$name] = $value;
+            });
+
+        $this->backend->propFind('calendars/foo/bar_path_1337_0', $propFind);
+        $this->assertEquals($props, $setProps);
+    }
+
+    public function testPropFindPrincipalCall(): void {
+        $this->tree->method('getNodeForPath')
+            ->willReturnCallback(function ($uri) {
+                $node = $this->createMock(Calendar::class);
+                $node->method('getOwner')
+                    ->willReturn('principals/users/dummy_user_42');
+                return $node;
+            });
+
+        $propFind = $this->createMock(PropFind::class);
+        $propFind->method('get404Properties')
+            ->with()
+            ->willReturn([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+                '{abc}def',
+            ]);
+
+        $propFind->method('getRequestedProperties')
+            ->with()
+            ->willReturn([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+                '{abc}def',
+                '{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL',
+            ]);
+
+        $props = [
+            '{abc}def' => 'a',
+            '{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/admin/personal'),
+        ];
+        $this->insertProps('dummy_user_42', 'principals/users/dummy_user_42', $props);
+
+        $setProps = [];
+        $propFind->method('set')
+            ->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+                $setProps[$name] = $value;
+            });
+
+        $this->backend->propFind('principals/users/dummy_user_42', $propFind);
+        $this->assertEquals($props, $setProps);
+    }
+
+    public static function propFindPrincipalScheduleDefaultCalendarProviderUrlProvider(): array {
+        // [ user, nodes, existingProps, requestedProps, returnedProps ]
+        return [
+            [ // Exists
+                'dummy_user_42',
+                ['calendars/dummy_user_42/foo/' => Calendar::class],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
+            ],
+            [ // Doesn't exist
+                'dummy_user_42',
+                ['calendars/dummy_user_42/foo/' => Calendar::class],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/bar/')],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
+                [],
+            ],
+            [ // No privilege
+                'dummy_user_42',
+                ['calendars/user2/baz/' => Calendar::class],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/user2/baz/')],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
+                [],
+            ],
+            [ // Not a calendar
+                'dummy_user_42',
+                ['foo/dummy_user_42/bar/' => IACL::class],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/dummy_user_42/bar/')],
+                ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
+                [],
+            ],
+        ];
+
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('propFindPrincipalScheduleDefaultCalendarProviderUrlProvider')]
+    public function testPropFindPrincipalScheduleDefaultCalendarUrl(
+        string $user,
+        array $nodes,
+        array $existingProps,
+        array $requestedProps,
+        array $returnedProps,
+    ): void {
+        $propFind = $this->createMock(PropFind::class);
+        $propFind->method('get404Properties')
+            ->with()
+            ->willReturn([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+            ]);
+
+        $propFind->method('getRequestedProperties')
+            ->with()
+            ->willReturn(array_merge([
+                '{DAV:}getcontentlength',
+                '{DAV:}getcontenttype',
+                '{DAV:}getetag',
+                '{abc}def',
+            ],
+                $requestedProps,
+            ));
+
+        $this->server->method('calculateUri')
+            ->willReturnCallback(function ($uri) {
+                if (!str_starts_with($uri, self::BASE_URI)) {
+                    return trim(substr($uri, strlen(self::BASE_URI)), '/');
+                }
+                return null;
+            });
+        $this->tree->method('getNodeForPath')
+            ->willReturnCallback(function ($uri) use ($nodes) {
+                if (str_starts_with($uri, 'principals/')) {
+                    return $this->createMock(IPrincipal::class);
+                }
+                if (array_key_exists($uri, $nodes)) {
+                    $owner = explode('/', $uri)[1];
+                    $node = $this->createMock($nodes[$uri]);
+                    $node->method('getOwner')
+                        ->willReturn("principals/users/$owner");
+                    return $node;
+                }
+                throw new NotFound('Node not found');
+            });
+
+        $this->insertProps($user, "principals/users/$user", $existingProps);
+
+        $setProps = [];
+        $propFind->method('set')
+            ->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+                $setProps[$name] = $value;
+            });
+
+        $this->backend->propFind("principals/users/$user", $propFind);
+        $this->assertEquals($returnedProps, $setProps);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('propPatchProvider')]
+    public function testPropPatch(string $path, array $existing, array $props, array $result): void {
+        $this->server->method('calculateUri')
+            ->willReturnCallback(function ($uri) {
+                if (str_starts_with($uri, self::BASE_URI)) {
+                    return trim(substr($uri, strlen(self::BASE_URI)), '/');
+                }
+                return null;
+            });
+        $this->tree->method('getNodeForPath')
+            ->willReturnCallback(function ($uri) {
+                $node = $this->createMock(Calendar::class);
+                $node->method('getOwner')
+                    ->willReturn('principals/users/' . $this->user->getUID());
+                return $node;
+            });
+
+        $this->insertProps($this->user->getUID(), $path, $existing);
+        $propPatch = new PropPatch($props);
+
+        $this->backend->propPatch($path, $propPatch);
+        $propPatch->commit();
+
+        $storedProps = $this->getProps($this->user->getUID(), $path);
+        $this->assertEquals($result, $storedProps);
+    }
+
+    public static function propPatchProvider(): array {
+        $longPath = str_repeat('long_path', 100);
+        return [
+            ['foo_bar_path_1337', [], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
+            ['foo_bar_path_1337', ['{DAV:}displayname' => 'foo'], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
+            ['foo_bar_path_1337', ['{DAV:}displayname' => 'foo'], ['{DAV:}displayname' => null], []],
+            [$longPath, [], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
+            ['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
+            ['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href(self::BASE_URI . 'foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
+        ];
+    }
+
+    public function testPropPatchWithUnsuitableCalendar(): void {
+        $path = 'principals/users/' . $this->user->getUID();
+
+        $node = $this->createMock(Calendar::class);
+        $node->expects(self::once())
+            ->method('getOwner')
+            ->willReturn($path);
+
+        $this->defaultCalendarValidator->expects(self::once())
+            ->method('validateScheduleDefaultCalendar')
+            ->with($node)
+            ->willThrowException(new \Sabre\DAV\Exception('Invalid calendar'));
+
+        $this->server->method('calculateUri')
+            ->willReturnCallback(function ($uri) {
+                if (str_starts_with($uri, self::BASE_URI)) {
+                    return trim(substr($uri, strlen(self::BASE_URI)), '/');
+                }
+                return null;
+            });
+        $this->tree->expects(self::once())
+            ->method('getNodeForPath')
+            ->with('foo/bar/')
+            ->willReturn($node);
+
+        $storedProps = $this->getProps($this->user->getUID(), $path);
+        $this->assertEquals([], $storedProps);
+
+        $propPatch = new PropPatch([
+            '{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/'),
+        ]);
+        $this->backend->propPatch($path, $propPatch);
+        try {
+            $propPatch->commit();
+        } catch (\Throwable $e) {
+            $this->assertInstanceOf(\Sabre\DAV\Exception::class, $e);
+        }
+
+        $storedProps = $this->getProps($this->user->getUID(), $path);
+        $this->assertEquals([], $storedProps);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('deleteProvider')]
+    public function testDelete(string $path): void {
+        $this->insertProps('dummy_user_42', $path, ['foo' => 'bar']);
+        $this->backend->delete($path);
+        $this->assertEquals([], $this->getProps('dummy_user_42', $path));
+    }
+
+    public static function deleteProvider(): array {
+        return [
+            ['foo_bar_path_1337'],
+            [str_repeat('long_path', 100)]
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('moveProvider')]
+    public function testMove(string $source, string $target): void {
+        $this->insertProps('dummy_user_42', $source, ['foo' => 'bar']);
+        $this->backend->move($source, $target);
+        $this->assertEquals([], $this->getProps('dummy_user_42', $source));
+        $this->assertEquals(['foo' => 'bar'], $this->getProps('dummy_user_42', $target));
+    }
+
+    public static function moveProvider(): array {
+        return [
+            ['foo_bar_path_1337', 'foo_bar_path_7333'],
+            [str_repeat('long_path1', 100), str_repeat('long_path2', 100)]
+        ];
+    }
+
+    public function testDecodeValueFromDatabaseObjectCurrent(): void {
+        $propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"\x00*\x00value";s:6:"opaque";}';
+        $propertyType = 3;
+        $decodeValue = $this->invokePrivate($this->backend, 'decodeValueFromDatabase', [$propertyValue, $propertyType]);
+        $this->assertInstanceOf(\Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp::class, $decodeValue);
+        $this->assertEquals('opaque', $decodeValue->getValue());
+    }
+
+    public function testDecodeValueFromDatabaseObjectLegacy(): void {
+        $propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"' . chr(0) . '*' . chr(0) . 'value";s:6:"opaque";}';
+        $propertyType = 3;
+        $decodeValue = $this->invokePrivate($this->backend, 'decodeValueFromDatabase', [$propertyValue, $propertyType]);
+        $this->assertInstanceOf(\Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp::class, $decodeValue);
+        $this->assertEquals('opaque', $decodeValue->getValue());
+    }
 }

Spacing +18 added lines, -18 removed lines

@@ -114,7 +114,7 @@ 
 		$data = [];
 		while ($row = $result->fetchAssociative()) {
 			$value = $row['propertyvalue'];
-			if ((int)$row['valuetype'] === CustomPropertiesBackend::PROPERTY_TYPE_HREF) {
+			if ((int) $row['valuetype'] === CustomPropertiesBackend::PROPERTY_TYPE_HREF) {
 				$value = new Href($value);
 			}
 			$data[$row['propertyname']] = $value;
@@ -186,7 +186,7 @@ 
 
 		$setProps = [];
 		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+			->willReturnCallback(function($name, $value, $status) use (&$setProps): void {
 				$setProps[$name] = $value;
 			});
 
@@ -196,7 +196,7 @@ 
 
 	public function testPropFindPrincipalCall(): void {
 		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) {
+			->willReturnCallback(function($uri) {
 				$node = $this->createMock(Calendar::class);
 				$node->method('getOwner')
 					->willReturn('principals/users/dummy_user_42');
@@ -231,7 +231,7 @@ 
 
 		$setProps = [];
 		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+			->willReturnCallback(function($name, $value, $status) use (&$setProps): void {
 				$setProps[$name] = $value;
 			});
 
@@ -242,28 +242,28 @@ 
 	public static function propFindPrincipalScheduleDefaultCalendarProviderUrlProvider(): array {
 		// [ user, nodes, existingProps, requestedProps, returnedProps ]
 		return [
-			[ // Exists
+			[// Exists
 				'dummy_user_42',
 				['calendars/dummy_user_42/foo/' => Calendar::class],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/foo/')],
 			],
-			[ // Doesn't exist
+			[// Doesn't exist
 				'dummy_user_42',
 				['calendars/dummy_user_42/foo/' => Calendar::class],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/dummy_user_42/bar/')],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
 				[],
 			],
-			[ // No privilege
+			[// No privilege
 				'dummy_user_42',
 				['calendars/user2/baz/' => Calendar::class],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('calendars/user2/baz/')],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'],
 				[],
 			],
-			[ // Not a calendar
+			[// Not a calendar
 				'dummy_user_42',
 				['foo/dummy_user_42/bar/' => IACL::class],
 				['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/dummy_user_42/bar/')],
@@ -303,14 +303,14 @@ 
 			));
 
 		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
+			->willReturnCallback(function($uri) {
 				if (!str_starts_with($uri, self::BASE_URI)) {
 					return trim(substr($uri, strlen(self::BASE_URI)), '/');
 				}
 				return null;
 			});
 		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) use ($nodes) {
+			->willReturnCallback(function($uri) use ($nodes) {
 				if (str_starts_with($uri, 'principals/')) {
 					return $this->createMock(IPrincipal::class);
 				}
@@ -328,7 +328,7 @@ 
 
 		$setProps = [];
 		$propFind->method('set')
-			->willReturnCallback(function ($name, $value, $status) use (&$setProps): void {
+			->willReturnCallback(function($name, $value, $status) use (&$setProps): void {
 				$setProps[$name] = $value;
 			});
 
@@ -339,17 +339,17 @@ 
 	#[\PHPUnit\Framework\Attributes\DataProvider('propPatchProvider')]
 	public function testPropPatch(string $path, array $existing, array $props, array $result): void {
 		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
+			->willReturnCallback(function($uri) {
 				if (str_starts_with($uri, self::BASE_URI)) {
 					return trim(substr($uri, strlen(self::BASE_URI)), '/');
 				}
 				return null;
 			});
 		$this->tree->method('getNodeForPath')
-			->willReturnCallback(function ($uri) {
+			->willReturnCallback(function($uri) {
 				$node = $this->createMock(Calendar::class);
 				$node->method('getOwner')
-					->willReturn('principals/users/' . $this->user->getUID());
+					->willReturn('principals/users/'.$this->user->getUID());
 				return $node;
 			});
 
@@ -371,12 +371,12 @@ 
 			['foo_bar_path_1337', ['{DAV:}displayname' => 'foo'], ['{DAV:}displayname' => null], []],
 			[$longPath, [], ['{DAV:}displayname' => 'anything'], ['{DAV:}displayname' => 'anything']],
 			['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
-			['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href(self::BASE_URI . 'foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
+			['principals/users/dummy_user_42', [], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href(self::BASE_URI.'foo/bar/')], ['{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL' => new Href('foo/bar/')]],
 		];
 	}
 
 	public function testPropPatchWithUnsuitableCalendar(): void {
-		$path = 'principals/users/' . $this->user->getUID();
+		$path = 'principals/users/'.$this->user->getUID();
 
 		$node = $this->createMock(Calendar::class);
 		$node->expects(self::once())
@@ -389,7 +389,7 @@ 
 			->willThrowException(new \Sabre\DAV\Exception('Invalid calendar'));
 
 		$this->server->method('calculateUri')
-			->willReturnCallback(function ($uri) {
+			->willReturnCallback(function($uri) {
 				if (str_starts_with($uri, self::BASE_URI)) {
 					return trim(substr($uri, strlen(self::BASE_URI)), '/');
 				}
@@ -455,7 +455,7 @@ 
 	}
 
 	public function testDecodeValueFromDatabaseObjectLegacy(): void {
-		$propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"' . chr(0) . '*' . chr(0) . 'value";s:6:"opaque";}';
+		$propertyValue = 'O:48:"Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp":1:{s:8:"'.chr(0).'*'.chr(0).'value";s:6:"opaque";}';
 		$propertyType = 3;
 		$decodeValue = $this->invokePrivate($this->backend, 'decodeValueFromDatabase', [$propertyValue, $propertyType]);
 		$this->assertInstanceOf(\Sabre\CalDAV\Xml\Property\ScheduleCalendarTransp::class, $decodeValue);

apps/dav/tests/unit/BackgroundJob/CleanupOrphanedChildrenJobTest.php

Indentation +146 added lines, -146 removed lines

@@ -21,150 +21,150 @@
 use Test\TestCase;
 
 class CleanupOrphanedChildrenJobTest extends TestCase {
-	private CleanupOrphanedChildrenJob $job;
-
-	private ITimeFactory&MockObject $timeFactory;
-	private IDBConnection&MockObject $connection;
-	private LoggerInterface&MockObject $logger;
-	private IJobList&MockObject $jobList;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->connection = $this->createMock(IDBConnection::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->jobList = $this->createMock(IJobList::class);
-
-		$this->job = new CleanupOrphanedChildrenJob(
-			$this->timeFactory,
-			$this->connection,
-			$this->logger,
-			$this->jobList,
-		);
-	}
-
-	private function getArgument(): array {
-		return [
-			'childTable' => 'childTable',
-			'parentTable' => 'parentTable',
-			'parentId' => 'parentId',
-			'logMessage' => 'logMessage',
-		];
-	}
-
-	private function getMockQueryBuilder(): IQueryBuilder&MockObject {
-		$expr = $this->createMock(IExpressionBuilder::class);
-		$qb = $this->createMock(IQueryBuilder::class);
-		$qb->method('select')
-			->willReturnSelf();
-		$qb->method('from')
-			->willReturnSelf();
-		$qb->method('leftJoin')
-			->willReturnSelf();
-		$qb->method('where')
-			->willReturnSelf();
-		$qb->method('setMaxResults')
-			->willReturnSelf();
-		$qb->method('andWhere')
-			->willReturnSelf();
-		$qb->method('expr')
-			->willReturn($expr);
-		$qb->method('delete')
-			->willReturnSelf();
-		return $qb;
-	}
-
-	public function testRunWithoutOrphans(): void {
-		$argument = $this->getArgument();
-		$selectQb = $this->getMockQueryBuilder();
-		$result = $this->createMock(IResult::class);
-
-		$this->connection->expects(self::once())
-			->method('getQueryBuilder')
-			->willReturn($selectQb);
-		$selectQb->expects(self::once())
-			->method('executeQuery')
-			->willReturn($result);
-		$result->expects(self::once())
-			->method('fetchAllAssociative')
-			->willReturn([]);
-		$result->expects(self::once())
-			->method('closeCursor');
-		$this->jobList->expects(self::never())
-			->method('add');
-
-		self::invokePrivate($this->job, 'run', [$argument]);
-	}
-
-	public function testRunWithPartialBatch(): void {
-		$argument = $this->getArgument();
-		$selectQb = $this->getMockQueryBuilder();
-		$deleteQb = $this->getMockQueryBuilder();
-		$result = $this->createMock(IResult::class);
-
-		$calls = [
-			$selectQb,
-			$deleteQb,
-		];
-		$this->connection->method('getQueryBuilder')
-			->willReturnCallback(function () use (&$calls) {
-				return array_shift($calls);
-			});
-		$selectQb->expects(self::once())
-			->method('executeQuery')
-			->willReturn($result);
-		$result->expects(self::once())
-			->method('fetchAllAssociative')
-			->willReturn([
-				['id' => 42],
-				['id' => 43],
-			]);
-		$result->expects(self::once())
-			->method('closeCursor');
-		$deleteQb->expects(self::once())
-			->method('delete')
-			->willReturnSelf();
-		$deleteQb->expects(self::once())
-			->method('executeStatement');
-		$this->jobList->expects(self::never())
-			->method('add');
-
-		self::invokePrivate($this->job, 'run', [$argument]);
-	}
-
-	public function testRunWithFullBatch(): void {
-		$argument = $this->getArgument();
-		$selectQb = $this->getMockQueryBuilder();
-		$deleteQb = $this->getMockQueryBuilder();
-		$result = $this->createMock(IResult::class);
-
-		$calls = [
-			$selectQb,
-			$deleteQb,
-		];
-		$this->connection->method('getQueryBuilder')
-			->willReturnCallback(function () use (&$calls) {
-				return array_shift($calls);
-			});
-
-		$selectQb->expects(self::once())
-			->method('executeQuery')
-			->willReturn($result);
-		$result->expects(self::once())
-			->method('fetchAllAssociative')
-			->willReturn(array_map(static fn ($i) => ['id' => 42 + $i], range(0, 999)));
-		$result->expects(self::once())
-			->method('closeCursor');
-		$deleteQb->expects(self::once())
-			->method('delete')
-			->willReturnSelf();
-		$deleteQb->expects(self::once())
-			->method('executeStatement');
-		$this->jobList->expects(self::once())
-			->method('add')
-			->with(CleanupOrphanedChildrenJob::class, $argument);
-
-		self::invokePrivate($this->job, 'run', [$argument]);
-	}
+    private CleanupOrphanedChildrenJob $job;
+
+    private ITimeFactory&MockObject $timeFactory;
+    private IDBConnection&MockObject $connection;
+    private LoggerInterface&MockObject $logger;
+    private IJobList&MockObject $jobList;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->connection = $this->createMock(IDBConnection::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->jobList = $this->createMock(IJobList::class);
+
+        $this->job = new CleanupOrphanedChildrenJob(
+            $this->timeFactory,
+            $this->connection,
+            $this->logger,
+            $this->jobList,
+        );
+    }
+
+    private function getArgument(): array {
+        return [
+            'childTable' => 'childTable',
+            'parentTable' => 'parentTable',
+            'parentId' => 'parentId',
+            'logMessage' => 'logMessage',
+        ];
+    }
+
+    private function getMockQueryBuilder(): IQueryBuilder&MockObject {
+        $expr = $this->createMock(IExpressionBuilder::class);
+        $qb = $this->createMock(IQueryBuilder::class);
+        $qb->method('select')
+            ->willReturnSelf();
+        $qb->method('from')
+            ->willReturnSelf();
+        $qb->method('leftJoin')
+            ->willReturnSelf();
+        $qb->method('where')
+            ->willReturnSelf();
+        $qb->method('setMaxResults')
+            ->willReturnSelf();
+        $qb->method('andWhere')
+            ->willReturnSelf();
+        $qb->method('expr')
+            ->willReturn($expr);
+        $qb->method('delete')
+            ->willReturnSelf();
+        return $qb;
+    }
+
+    public function testRunWithoutOrphans(): void {
+        $argument = $this->getArgument();
+        $selectQb = $this->getMockQueryBuilder();
+        $result = $this->createMock(IResult::class);
+
+        $this->connection->expects(self::once())
+            ->method('getQueryBuilder')
+            ->willReturn($selectQb);
+        $selectQb->expects(self::once())
+            ->method('executeQuery')
+            ->willReturn($result);
+        $result->expects(self::once())
+            ->method('fetchAllAssociative')
+            ->willReturn([]);
+        $result->expects(self::once())
+            ->method('closeCursor');
+        $this->jobList->expects(self::never())
+            ->method('add');
+
+        self::invokePrivate($this->job, 'run', [$argument]);
+    }
+
+    public function testRunWithPartialBatch(): void {
+        $argument = $this->getArgument();
+        $selectQb = $this->getMockQueryBuilder();
+        $deleteQb = $this->getMockQueryBuilder();
+        $result = $this->createMock(IResult::class);
+
+        $calls = [
+            $selectQb,
+            $deleteQb,
+        ];
+        $this->connection->method('getQueryBuilder')
+            ->willReturnCallback(function () use (&$calls) {
+                return array_shift($calls);
+            });
+        $selectQb->expects(self::once())
+            ->method('executeQuery')
+            ->willReturn($result);
+        $result->expects(self::once())
+            ->method('fetchAllAssociative')
+            ->willReturn([
+                ['id' => 42],
+                ['id' => 43],
+            ]);
+        $result->expects(self::once())
+            ->method('closeCursor');
+        $deleteQb->expects(self::once())
+            ->method('delete')
+            ->willReturnSelf();
+        $deleteQb->expects(self::once())
+            ->method('executeStatement');
+        $this->jobList->expects(self::never())
+            ->method('add');
+
+        self::invokePrivate($this->job, 'run', [$argument]);
+    }
+
+    public function testRunWithFullBatch(): void {
+        $argument = $this->getArgument();
+        $selectQb = $this->getMockQueryBuilder();
+        $deleteQb = $this->getMockQueryBuilder();
+        $result = $this->createMock(IResult::class);
+
+        $calls = [
+            $selectQb,
+            $deleteQb,
+        ];
+        $this->connection->method('getQueryBuilder')
+            ->willReturnCallback(function () use (&$calls) {
+                return array_shift($calls);
+            });
+
+        $selectQb->expects(self::once())
+            ->method('executeQuery')
+            ->willReturn($result);
+        $result->expects(self::once())
+            ->method('fetchAllAssociative')
+            ->willReturn(array_map(static fn ($i) => ['id' => 42 + $i], range(0, 999)));
+        $result->expects(self::once())
+            ->method('closeCursor');
+        $deleteQb->expects(self::once())
+            ->method('delete')
+            ->willReturnSelf();
+        $deleteQb->expects(self::once())
+            ->method('executeStatement');
+        $this->jobList->expects(self::once())
+            ->method('add')
+            ->with(CleanupOrphanedChildrenJob::class, $argument);
+
+        self::invokePrivate($this->job, 'run', [$argument]);
+    }
 }

apps/dav/tests/unit/Controller/InvitationResponseControllerTest.php

Indentation +358 added lines, -358 removed lines

@@ -23,50 +23,50 @@ 
 use Test\TestCase;
 
 class InvitationResponseControllerTest extends TestCase {
-	private IDBConnection&MockObject $dbConnection;
-	private IRequest&MockObject $request;
-	private ITimeFactory&MockObject $timeFactory;
-	private InvitationResponseServer&MockObject $responseServer;
-	private InvitationResponseController $controller;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->dbConnection = $this->createMock(IDBConnection::class);
-		$this->request = $this->createMock(IRequest::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->responseServer = $this->createMock(InvitationResponseServer::class);
-
-		$this->controller = new InvitationResponseController(
-			'appName',
-			$this->request,
-			$this->dbConnection,
-			$this->timeFactory,
-			$this->responseServer
-		);
-	}
-
-	public static function attendeeProvider(): array {
-		return [
-			'local attendee' => [false],
-			'external attendee' => [true]
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
-	public function testAccept(bool $isExternalAttendee): void {
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => null,
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => null,
-			'token' => 'TOKEN123',
-			'expiration' => 420000,
-		], 1337);
-
-		$expected = <<<EOF
+    private IDBConnection&MockObject $dbConnection;
+    private IRequest&MockObject $request;
+    private ITimeFactory&MockObject $timeFactory;
+    private InvitationResponseServer&MockObject $responseServer;
+    private InvitationResponseController $controller;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->dbConnection = $this->createMock(IDBConnection::class);
+        $this->request = $this->createMock(IRequest::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->responseServer = $this->createMock(InvitationResponseServer::class);
+
+        $this->controller = new InvitationResponseController(
+            'appName',
+            $this->request,
+            $this->dbConnection,
+            $this->timeFactory,
+            $this->responseServer
+        );
+    }
+
+    public static function attendeeProvider(): array {
+        return [
+            'local attendee' => [false],
+            'external attendee' => [true]
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
+    public function testAccept(bool $isExternalAttendee): void {
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => null,
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => null,
+            'token' => 'TOKEN123',
+            'expiration' => 420000,
+        ], 1337);
+
+        $expected = <<<EOF
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud/Nextcloud CalDAV Server//EN
@@ -82,53 +82,53 @@ 
 END:VCALENDAR
 
 EOF;
-		$expected = preg_replace('~\R~u', "\r\n", $expected);
-
-		$called = false;
-		$this->responseServer->expects($this->once())
-			->method('handleITipMessage')
-			->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
-				$called = true;
-				$this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
-				$this->assertEquals('VEVENT', $iTipMessage->component);
-				$this->assertEquals('REPLY', $iTipMessage->method);
-				$this->assertEquals(null, $iTipMessage->sequence);
-				$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
-				if ($isExternalAttendee) {
-					$this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
-				} else {
-					$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
-				}
-
-				$iTipMessage->scheduleStatus = '1.2;Message delivered locally';
-
-				$this->assertEquals($expected, $iTipMessage->message->serialize());
-			});
-		$this->responseServer->expects($this->once())
-			->method('isExternalAttendee')
-			->willReturn($isExternalAttendee);
-
-		$response = $this->controller->accept('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-success', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-		$this->assertTrue($called);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
-	public function testAcceptSequence(bool $isExternalAttendee): void {
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => null,
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => 1337,
-			'token' => 'TOKEN123',
-			'expiration' => 420000,
-		], 1337);
-
-		$expected = <<<EOF
+        $expected = preg_replace('~\R~u', "\r\n", $expected);
+
+        $called = false;
+        $this->responseServer->expects($this->once())
+            ->method('handleITipMessage')
+            ->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
+                $called = true;
+                $this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
+                $this->assertEquals('VEVENT', $iTipMessage->component);
+                $this->assertEquals('REPLY', $iTipMessage->method);
+                $this->assertEquals(null, $iTipMessage->sequence);
+                $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
+                if ($isExternalAttendee) {
+                    $this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
+                } else {
+                    $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
+                }
+
+                $iTipMessage->scheduleStatus = '1.2;Message delivered locally';
+
+                $this->assertEquals($expected, $iTipMessage->message->serialize());
+            });
+        $this->responseServer->expects($this->once())
+            ->method('isExternalAttendee')
+            ->willReturn($isExternalAttendee);
+
+        $response = $this->controller->accept('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-success', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+        $this->assertTrue($called);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
+    public function testAcceptSequence(bool $isExternalAttendee): void {
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => null,
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => 1337,
+            'token' => 'TOKEN123',
+            'expiration' => 420000,
+        ], 1337);
+
+        $expected = <<<EOF
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud/Nextcloud CalDAV Server//EN
@@ -144,53 +144,53 @@ 
 END:VCALENDAR
 
 EOF;
-		$expected = preg_replace('~\R~u', "\r\n", $expected);
-
-		$called = false;
-		$this->responseServer->expects($this->once())
-			->method('handleITipMessage')
-			->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
-				$called = true;
-				$this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
-				$this->assertEquals('VEVENT', $iTipMessage->component);
-				$this->assertEquals('REPLY', $iTipMessage->method);
-				$this->assertEquals(1337, $iTipMessage->sequence);
-				$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
-				if ($isExternalAttendee) {
-					$this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
-				} else {
-					$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
-				}
-
-				$iTipMessage->scheduleStatus = '1.2;Message delivered locally';
-
-				$this->assertEquals($expected, $iTipMessage->message->serialize());
-			});
-		$this->responseServer->expects($this->once())
-			->method('isExternalAttendee')
-			->willReturn($isExternalAttendee);
-
-		$response = $this->controller->accept('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-success', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-		$this->assertTrue($called);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
-	public function testAcceptRecurrenceId(bool $isExternalAttendee): void {
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => "RECURRENCE-ID;TZID=Europe/Berlin:20180726T150000\n",
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => null,
-			'token' => 'TOKEN123',
-			'expiration' => 420000,
-		], 1337);
-
-		$expected = <<<EOF
+        $expected = preg_replace('~\R~u', "\r\n", $expected);
+
+        $called = false;
+        $this->responseServer->expects($this->once())
+            ->method('handleITipMessage')
+            ->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
+                $called = true;
+                $this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
+                $this->assertEquals('VEVENT', $iTipMessage->component);
+                $this->assertEquals('REPLY', $iTipMessage->method);
+                $this->assertEquals(1337, $iTipMessage->sequence);
+                $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
+                if ($isExternalAttendee) {
+                    $this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
+                } else {
+                    $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
+                }
+
+                $iTipMessage->scheduleStatus = '1.2;Message delivered locally';
+
+                $this->assertEquals($expected, $iTipMessage->message->serialize());
+            });
+        $this->responseServer->expects($this->once())
+            ->method('isExternalAttendee')
+            ->willReturn($isExternalAttendee);
+
+        $response = $this->controller->accept('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-success', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+        $this->assertTrue($called);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
+    public function testAcceptRecurrenceId(bool $isExternalAttendee): void {
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => "RECURRENCE-ID;TZID=Europe/Berlin:20180726T150000\n",
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => null,
+            'token' => 'TOKEN123',
+            'expiration' => 420000,
+        ], 1337);
+
+        $expected = <<<EOF
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud/Nextcloud CalDAV Server//EN
@@ -207,80 +207,80 @@ 
 END:VCALENDAR
 
 EOF;
-		$expected = preg_replace('~\R~u', "\r\n", $expected);
-
-		$called = false;
-		$this->responseServer->expects($this->once())
-			->method('handleITipMessage')
-			->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
-				$called = true;
-				$this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
-				$this->assertEquals('VEVENT', $iTipMessage->component);
-				$this->assertEquals('REPLY', $iTipMessage->method);
-				$this->assertEquals(0, $iTipMessage->sequence);
-				$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
-				if ($isExternalAttendee) {
-					$this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
-				} else {
-					$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
-				}
-
-				$iTipMessage->scheduleStatus = '1.2;Message delivered locally';
-
-				$this->assertEquals($expected, $iTipMessage->message->serialize());
-			});
-		$this->responseServer->expects($this->once())
-			->method('isExternalAttendee')
-			->willReturn($isExternalAttendee);
-
-		$response = $this->controller->accept('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-success', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-		$this->assertTrue($called);
-	}
-
-	public function testAcceptTokenNotFound(): void {
-		$this->buildQueryExpects('TOKEN123', null, 1337);
-
-		$response = $this->controller->accept('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-error', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-	}
-
-	public function testAcceptExpiredToken(): void {
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => null,
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => null,
-			'token' => 'TOKEN123',
-			'expiration' => 42,
-		], 1337);
-
-		$response = $this->controller->accept('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-error', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
-	public function testDecline(bool $isExternalAttendee): void {
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => null,
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => null,
-			'token' => 'TOKEN123',
-			'expiration' => 420000,
-		], 1337);
-
-		$expected = <<<EOF
+        $expected = preg_replace('~\R~u', "\r\n", $expected);
+
+        $called = false;
+        $this->responseServer->expects($this->once())
+            ->method('handleITipMessage')
+            ->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
+                $called = true;
+                $this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
+                $this->assertEquals('VEVENT', $iTipMessage->component);
+                $this->assertEquals('REPLY', $iTipMessage->method);
+                $this->assertEquals(0, $iTipMessage->sequence);
+                $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
+                if ($isExternalAttendee) {
+                    $this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
+                } else {
+                    $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
+                }
+
+                $iTipMessage->scheduleStatus = '1.2;Message delivered locally';
+
+                $this->assertEquals($expected, $iTipMessage->message->serialize());
+            });
+        $this->responseServer->expects($this->once())
+            ->method('isExternalAttendee')
+            ->willReturn($isExternalAttendee);
+
+        $response = $this->controller->accept('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-success', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+        $this->assertTrue($called);
+    }
+
+    public function testAcceptTokenNotFound(): void {
+        $this->buildQueryExpects('TOKEN123', null, 1337);
+
+        $response = $this->controller->accept('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-error', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+    }
+
+    public function testAcceptExpiredToken(): void {
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => null,
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => null,
+            'token' => 'TOKEN123',
+            'expiration' => 42,
+        ], 1337);
+
+        $response = $this->controller->accept('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-error', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
+    public function testDecline(bool $isExternalAttendee): void {
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => null,
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => null,
+            'token' => 'TOKEN123',
+            'expiration' => 420000,
+        ], 1337);
+
+        $expected = <<<EOF
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud/Nextcloud CalDAV Server//EN
@@ -296,65 +296,65 @@ 
 END:VCALENDAR
 
 EOF;
-		$expected = preg_replace('~\R~u', "\r\n", $expected);
-
-		$called = false;
-		$this->responseServer->expects($this->once())
-			->method('handleITipMessage')
-			->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
-				$called = true;
-				$this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
-				$this->assertEquals('VEVENT', $iTipMessage->component);
-				$this->assertEquals('REPLY', $iTipMessage->method);
-				$this->assertEquals(null, $iTipMessage->sequence);
-				$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
-				if ($isExternalAttendee) {
-					$this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
-				} else {
-					$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
-				}
-
-				$iTipMessage->scheduleStatus = '1.2;Message delivered locally';
-
-				$this->assertEquals($expected, $iTipMessage->message->serialize());
-			});
-		$this->responseServer->expects($this->once())
-			->method('isExternalAttendee')
-			->willReturn($isExternalAttendee);
-
-		$response = $this->controller->decline('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-success', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-		$this->assertTrue($called);
-	}
-
-	public function testOptions(): void {
-		$response = $this->controller->options('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-options', $response->getTemplateName());
-		$this->assertEquals(['token' => 'TOKEN123'], $response->getParams());
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
-	public function testProcessMoreOptionsResult(bool $isExternalAttendee): void {
-		$this->request->expects($this->once())
-			->method('getParam')
-			->with('partStat')
-			->willReturn('TENTATIVE');
-
-		$this->buildQueryExpects('TOKEN123', [
-			'id' => 0,
-			'uid' => 'this-is-the-events-uid',
-			'recurrenceid' => null,
-			'attendee' => 'mailto:attendee@foo.bar',
-			'organizer' => 'mailto:organizer@foo.bar',
-			'sequence' => null,
-			'token' => 'TOKEN123',
-			'expiration' => 420000,
-		], 1337);
-
-		$expected = <<<EOF
+        $expected = preg_replace('~\R~u', "\r\n", $expected);
+
+        $called = false;
+        $this->responseServer->expects($this->once())
+            ->method('handleITipMessage')
+            ->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
+                $called = true;
+                $this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
+                $this->assertEquals('VEVENT', $iTipMessage->component);
+                $this->assertEquals('REPLY', $iTipMessage->method);
+                $this->assertEquals(null, $iTipMessage->sequence);
+                $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
+                if ($isExternalAttendee) {
+                    $this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
+                } else {
+                    $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
+                }
+
+                $iTipMessage->scheduleStatus = '1.2;Message delivered locally';
+
+                $this->assertEquals($expected, $iTipMessage->message->serialize());
+            });
+        $this->responseServer->expects($this->once())
+            ->method('isExternalAttendee')
+            ->willReturn($isExternalAttendee);
+
+        $response = $this->controller->decline('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-success', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+        $this->assertTrue($called);
+    }
+
+    public function testOptions(): void {
+        $response = $this->controller->options('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-options', $response->getTemplateName());
+        $this->assertEquals(['token' => 'TOKEN123'], $response->getParams());
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('attendeeProvider')]
+    public function testProcessMoreOptionsResult(bool $isExternalAttendee): void {
+        $this->request->expects($this->once())
+            ->method('getParam')
+            ->with('partStat')
+            ->willReturn('TENTATIVE');
+
+        $this->buildQueryExpects('TOKEN123', [
+            'id' => 0,
+            'uid' => 'this-is-the-events-uid',
+            'recurrenceid' => null,
+            'attendee' => 'mailto:attendee@foo.bar',
+            'organizer' => 'mailto:organizer@foo.bar',
+            'sequence' => null,
+            'token' => 'TOKEN123',
+            'expiration' => 420000,
+        ], 1337);
+
+        $expected = <<<EOF
 BEGIN:VCALENDAR
 VERSION:2.0
 PRODID:-//Nextcloud/Nextcloud CalDAV Server//EN
@@ -370,91 +370,91 @@ 
 END:VCALENDAR
 
 EOF;
-		$expected = preg_replace('~\R~u', "\r\n", $expected);
-
-		$called = false;
-		$this->responseServer->expects($this->once())
-			->method('handleITipMessage')
-			->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
-				$called = true;
-				$this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
-				$this->assertEquals('VEVENT', $iTipMessage->component);
-				$this->assertEquals('REPLY', $iTipMessage->method);
-				$this->assertEquals(null, $iTipMessage->sequence);
-				$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
-				if ($isExternalAttendee) {
-					$this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
-				} else {
-					$this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
-				}
-
-				$iTipMessage->scheduleStatus = '1.2;Message delivered locally';
-
-				$this->assertEquals($expected, $iTipMessage->message->serialize());
-			});
-		$this->responseServer->expects($this->once())
-			->method('isExternalAttendee')
-			->willReturn($isExternalAttendee);
-
-
-		$response = $this->controller->processMoreOptionsResult('TOKEN123');
-		$this->assertInstanceOf(TemplateResponse::class, $response);
-		$this->assertEquals('schedule-response-success', $response->getTemplateName());
-		$this->assertEquals([], $response->getParams());
-		$this->assertTrue($called);
-	}
-
-	private function buildQueryExpects(string $token, ?array $return, int $time): void {
-		$queryBuilder = $this->createMock(IQueryBuilder::class);
-		$stmt = $this->createMock(IResult::class);
-		$expr = $this->createMock(IExpressionBuilder::class);
-
-		$this->dbConnection->expects($this->once())
-			->method('getQueryBuilder')
-			->with()
-			->willReturn($queryBuilder);
-		$queryBuilder->method('expr')
-			->willReturn($expr);
-		$queryBuilder->method('createNamedParameter')
-			->willReturnMap([
-				[$token, \PDO::PARAM_STR, null, 'namedParameterToken']
-			]);
-
-		$stmt->expects($this->once())
-			->method('fetchAssociative')
-			->willReturn($return ?? false);
-		$stmt->expects($this->once())
-			->method('closeCursor');
-
-		$function = 'functionToken';
-		$expr->expects($this->once())
-			->method('eq')
-			->with('token', 'namedParameterToken')
-			->willReturn((string)$function);
-
-		$this->dbConnection->expects($this->once())
-			->method('getQueryBuilder')
-			->with()
-			->willReturn($queryBuilder);
-
-		$queryBuilder->expects($this->once())
-			->method('select')
-			->with('*')
-			->willReturn($queryBuilder);
-		$queryBuilder->expects($this->once())
-			->method('from')
-			->with('calendar_invitations')
-			->willReturn($queryBuilder);
-		$queryBuilder->expects($this->once())
-			->method('where')
-			->with($function)
-			->willReturn($queryBuilder);
-		$queryBuilder->expects($this->once())
-			->method('executeQuery')
-			->with()
-			->willReturn($stmt);
-
-		$this->timeFactory->method('getTime')
-			->willReturn($time);
-	}
+        $expected = preg_replace('~\R~u', "\r\n", $expected);
+
+        $called = false;
+        $this->responseServer->expects($this->once())
+            ->method('handleITipMessage')
+            ->willReturnCallback(function (Message $iTipMessage) use (&$called, $isExternalAttendee, $expected): void {
+                $called = true;
+                $this->assertEquals('this-is-the-events-uid', $iTipMessage->uid);
+                $this->assertEquals('VEVENT', $iTipMessage->component);
+                $this->assertEquals('REPLY', $iTipMessage->method);
+                $this->assertEquals(null, $iTipMessage->sequence);
+                $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->sender);
+                if ($isExternalAttendee) {
+                    $this->assertEquals('mailto:organizer@foo.bar', $iTipMessage->recipient);
+                } else {
+                    $this->assertEquals('mailto:attendee@foo.bar', $iTipMessage->recipient);
+                }
+
+                $iTipMessage->scheduleStatus = '1.2;Message delivered locally';
+
+                $this->assertEquals($expected, $iTipMessage->message->serialize());
+            });
+        $this->responseServer->expects($this->once())
+            ->method('isExternalAttendee')
+            ->willReturn($isExternalAttendee);
+
+
+        $response = $this->controller->processMoreOptionsResult('TOKEN123');
+        $this->assertInstanceOf(TemplateResponse::class, $response);
+        $this->assertEquals('schedule-response-success', $response->getTemplateName());
+        $this->assertEquals([], $response->getParams());
+        $this->assertTrue($called);
+    }
+
+    private function buildQueryExpects(string $token, ?array $return, int $time): void {
+        $queryBuilder = $this->createMock(IQueryBuilder::class);
+        $stmt = $this->createMock(IResult::class);
+        $expr = $this->createMock(IExpressionBuilder::class);
+
+        $this->dbConnection->expects($this->once())
+            ->method('getQueryBuilder')
+            ->with()
+            ->willReturn($queryBuilder);
+        $queryBuilder->method('expr')
+            ->willReturn($expr);
+        $queryBuilder->method('createNamedParameter')
+            ->willReturnMap([
+                [$token, \PDO::PARAM_STR, null, 'namedParameterToken']
+            ]);
+
+        $stmt->expects($this->once())
+            ->method('fetchAssociative')
+            ->willReturn($return ?? false);
+        $stmt->expects($this->once())
+            ->method('closeCursor');
+
+        $function = 'functionToken';
+        $expr->expects($this->once())
+            ->method('eq')
+            ->with('token', 'namedParameterToken')
+            ->willReturn((string)$function);
+
+        $this->dbConnection->expects($this->once())
+            ->method('getQueryBuilder')
+            ->with()
+            ->willReturn($queryBuilder);
+
+        $queryBuilder->expects($this->once())
+            ->method('select')
+            ->with('*')
+            ->willReturn($queryBuilder);
+        $queryBuilder->expects($this->once())
+            ->method('from')
+            ->with('calendar_invitations')
+            ->willReturn($queryBuilder);
+        $queryBuilder->expects($this->once())
+            ->method('where')
+            ->with($function)
+            ->willReturn($queryBuilder);
+        $queryBuilder->expects($this->once())
+            ->method('executeQuery')
+            ->with()
+            ->willReturn($stmt);
+
+        $this->timeFactory->method('getTime')
+            ->willReturn($time);
+    }
 }

apps/dav/tests/unit/CardDAV/CardDavBackendTest.php

Indentation +875 added lines, -875 removed lines

@@ -48,879 +48,879 @@
  */
 #[\PHPUnit\Framework\Attributes\Group('DB')]
 class CardDavBackendTest extends TestCase {
-	private Principal&MockObject $principal;
-	private IUserManager&MockObject $userManager;
-	private IGroupManager&MockObject $groupManager;
-	private IEventDispatcher&MockObject $dispatcher;
-	private IConfig&MockObject $config;
-	private RemoteUserPrincipalBackend&MockObject $remoteUserPrincipalBackend;
-	private FederationSharingService&MockObject $federationSharingService;
-	private Backend $sharingBackend;
-	private IDBConnection $db;
-	private CardDavBackend $backend;
-	private string $dbCardsTable = 'cards';
-	private string $dbCardsPropertiesTable = 'cards_properties';
-
-	public const UNIT_TEST_USER = 'principals/users/carddav-unit-test';
-	public const UNIT_TEST_USER1 = 'principals/users/carddav-unit-test1';
-	public const UNIT_TEST_GROUP = 'principals/groups/carddav-unit-test-group';
-
-	private $vcardTest0 = 'BEGIN:VCARD' . PHP_EOL
-		. 'VERSION:3.0' . PHP_EOL
-		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
-		. 'UID:Test' . PHP_EOL
-		. 'FN:Test' . PHP_EOL
-		. 'N:Test;;;;' . PHP_EOL
-		. 'END:VCARD';
-
-	private $vcardTest1 = 'BEGIN:VCARD' . PHP_EOL
-		. 'VERSION:3.0' . PHP_EOL
-		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
-		. 'UID:Test2' . PHP_EOL
-		. 'FN:Test2' . PHP_EOL
-		. 'N:Test2;;;;' . PHP_EOL
-		. 'END:VCARD';
-
-	private $vcardTest2 = 'BEGIN:VCARD' . PHP_EOL
-		. 'VERSION:3.0' . PHP_EOL
-		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
-		. 'UID:Test3' . PHP_EOL
-		. 'FN:Test3' . PHP_EOL
-		. 'N:Test3;;;;' . PHP_EOL
-		. 'END:VCARD';
-
-	private $vcardTestNoUID = 'BEGIN:VCARD' . PHP_EOL
-		. 'VERSION:3.0' . PHP_EOL
-		. 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
-		. 'FN:TestNoUID' . PHP_EOL
-		. 'N:TestNoUID;;;;' . PHP_EOL
-		. 'END:VCARD';
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->principal = $this->getMockBuilder(Principal::class)
-			->setConstructorArgs([
-				$this->userManager,
-				$this->groupManager,
-				$this->createMock(IAccountManager::class),
-				$this->createMock(ShareManager::class),
-				$this->createMock(IUserSession::class),
-				$this->createMock(IAppManager::class),
-				$this->createMock(ProxyMapper::class),
-				$this->createMock(KnownUserService::class),
-				$this->config,
-				$this->createMock(IFactory::class)
-			])
-			->onlyMethods(['getPrincipalByPath', 'getGroupMembership', 'findByUri'])
-			->getMock();
-		$this->principal->method('getPrincipalByPath')
-			->willReturn([
-				'uri' => 'principals/best-friend',
-				'{DAV:}displayname' => 'User\'s displayname',
-			]);
-		$this->principal->method('getGroupMembership')
-			->withAnyParameters()
-			->willReturn([self::UNIT_TEST_GROUP]);
-		$this->dispatcher = $this->createMock(IEventDispatcher::class);
-		$this->remoteUserPrincipalBackend = $this->createMock(RemoteUserPrincipalBackend::class);
-		$this->federationSharingService = $this->createMock(FederationSharingService::class);
-
-		$this->db = Server::get(IDBConnection::class);
-		$this->sharingBackend = new Backend($this->userManager,
-			$this->groupManager,
-			$this->principal,
-			$this->remoteUserPrincipalBackend,
-			$this->createMock(ICacheFactory::class),
-			new Service(new SharingMapper($this->db)),
-			$this->federationSharingService,
-			$this->createMock(LoggerInterface::class)
-		);
-
-		$this->backend = new CardDavBackend($this->db,
-			$this->principal,
-			$this->userManager,
-			$this->dispatcher,
-			$this->sharingBackend,
-			$this->config,
-		);
-		// start every test with a empty cards_properties and cards table
-		$query = $this->db->getQueryBuilder();
-		$query->delete('cards_properties')->executeStatement();
-		$query = $this->db->getQueryBuilder();
-		$query->delete('cards')->executeStatement();
-
-		$this->principal->method('getGroupMembership')
-			->withAnyParameters()
-			->willReturn([self::UNIT_TEST_GROUP]);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		foreach ($books as $book) {
-			$this->backend->deleteAddressBook($book['id']);
-		}
-	}
-
-	protected function tearDown(): void {
-		if (is_null($this->backend)) {
-			return;
-		}
-
-		$this->principal->method('getGroupMembership')
-			->withAnyParameters()
-			->willReturn([self::UNIT_TEST_GROUP]);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		foreach ($books as $book) {
-			$this->backend->deleteAddressBook($book['id']);
-		}
-
-		parent::tearDown();
-	}
-
-	public function testAddressBookOperations(): void {
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-
-		$this->assertEquals(1, $this->backend->getAddressBooksForUserCount(self::UNIT_TEST_USER));
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$this->assertEquals('Example', $books[0]['{DAV:}displayname']);
-		$this->assertEquals('User\'s displayname', $books[0]['{http://nextcloud.com/ns}owner-displayname']);
-
-		// update its display name
-		$patch = new PropPatch([
-			'{DAV:}displayname' => 'Unit test',
-			'{urn:ietf:params:xml:ns:carddav}addressbook-description' => 'Addressbook used for unit testing'
-		]);
-		$this->backend->updateAddressBook($books[0]['id'], $patch);
-		$patch->commit();
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$this->assertEquals('Unit test', $books[0]['{DAV:}displayname']);
-		$this->assertEquals('Addressbook used for unit testing', $books[0]['{urn:ietf:params:xml:ns:carddav}addressbook-description']);
-
-		// delete the address book
-		$this->backend->deleteAddressBook($books[0]['id']);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(0, count($books));
-	}
-
-	public function testAddressBookSharing(): void {
-		$this->userManager->expects($this->any())
-			->method('userExists')
-			->willReturn(true);
-		$this->groupManager->expects($this->any())
-			->method('groupExists')
-			->willReturn(true);
-		$this->principal->expects(self::atLeastOnce())
-			->method('findByUri')
-			->willReturnOnConsecutiveCalls(self::UNIT_TEST_USER1, self::UNIT_TEST_GROUP);
-
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$l = $this->createMock(IL10N::class);
-		$addressBook = new AddressBook($this->backend, $books[0], $l);
-		$this->backend->updateShares($addressBook, [
-			[
-				'href' => 'principal:' . self::UNIT_TEST_USER1,
-			],
-			[
-				'href' => 'principal:' . self::UNIT_TEST_GROUP,
-			]
-		], []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
-		$this->assertEquals(1, count($books));
-
-		// delete the address book
-		$this->backend->deleteAddressBook($books[0]['id']);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(0, count($books));
-	}
-
-	public function testCardOperations(): void {
-		/** @var CardDavBackend&MockObject $backend */
-		$backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend,$this->config])
-			->onlyMethods(['updateProperties', 'purgeProperties'])
-			->getMock();
-
-		// create a new address book
-		$backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$bookId = $books[0]['id'];
-
-		$uri = $this->getUniqueID('card');
-		// updateProperties is expected twice, once for createCard and once for updateCard
-		$calls = [
-			[$bookId, $uri, $this->vcardTest0],
-			[$bookId, $uri, $this->vcardTest1],
-		];
-		$backend->expects($this->exactly(count($calls)))
-			->method('updateProperties')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-
-		// Expect event
-		$this->dispatcher
-			->expects($this->exactly(3))
-			->method('dispatchTyped');
-
-		// create a card
-		$backend->createCard($bookId, $uri, $this->vcardTest0);
-
-		// get all the cards
-		$cards = $backend->getCards($bookId);
-		$this->assertEquals(1, count($cards));
-		$this->assertEquals($this->vcardTest0, $cards[0]['carddata']);
-
-		// get the cards
-		$card = $backend->getCard($bookId, $uri);
-		$this->assertNotNull($card);
-		$this->assertArrayHasKey('id', $card);
-		$this->assertArrayHasKey('uri', $card);
-		$this->assertArrayHasKey('lastmodified', $card);
-		$this->assertArrayHasKey('etag', $card);
-		$this->assertArrayHasKey('size', $card);
-		$this->assertEquals($this->vcardTest0, $card['carddata']);
-
-		// update the card
-		$backend->updateCard($bookId, $uri, $this->vcardTest1);
-		$card = $backend->getCard($bookId, $uri);
-		$this->assertEquals($this->vcardTest1, $card['carddata']);
-
-		// delete the card
-		$backend->expects($this->once())->method('purgeProperties')->with($bookId, $card['id']);
-		$backend->deleteCard($bookId, $uri);
-		$cards = $backend->getCards($bookId);
-		$this->assertEquals(0, count($cards));
-	}
-
-	public function testMultiCard(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend,$this->config])
-			->onlyMethods(['updateProperties'])
-			->getMock();
-
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$bookId = $books[0]['id'];
-
-		// create a card
-		$uri0 = self::getUniqueID('card');
-		$this->backend->createCard($bookId, $uri0, $this->vcardTest0);
-		$uri1 = self::getUniqueID('card');
-		$this->backend->createCard($bookId, $uri1, $this->vcardTest1);
-		$uri2 = self::getUniqueID('card');
-		$this->backend->createCard($bookId, $uri2, $this->vcardTest2);
-
-		// get all the cards
-		$cards = $this->backend->getCards($bookId);
-		$this->assertEquals(3, count($cards));
-		usort($cards, function ($a, $b) {
-			return $a['id'] < $b['id'] ? -1 : 1;
-		});
-
-		$this->assertEquals($this->vcardTest0, $cards[0]['carddata']);
-		$this->assertEquals($this->vcardTest1, $cards[1]['carddata']);
-		$this->assertEquals($this->vcardTest2, $cards[2]['carddata']);
-
-		// get the cards 1 & 2 (not 0)
-		$cards = $this->backend->getMultipleCards($bookId, [$uri1, $uri2]);
-		$this->assertEquals(2, count($cards));
-		usort($cards, function ($a, $b) {
-			return $a['id'] < $b['id'] ? -1 : 1;
-		});
-		foreach ($cards as $index => $card) {
-			$this->assertArrayHasKey('id', $card);
-			$this->assertArrayHasKey('uri', $card);
-			$this->assertArrayHasKey('lastmodified', $card);
-			$this->assertArrayHasKey('etag', $card);
-			$this->assertArrayHasKey('size', $card);
-			$this->assertEquals($this->{ 'vcardTest' . ($index + 1) }, $card['carddata']);
-		}
-
-		// delete the card
-		$this->backend->deleteCard($bookId, $uri0);
-		$this->backend->deleteCard($bookId, $uri1);
-		$this->backend->deleteCard($bookId, $uri2);
-		$cards = $this->backend->getCards($bookId);
-		$this->assertEquals(0, count($cards));
-	}
-
-	public function testMultipleUIDOnDifferentAddressbooks(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend,$this->config])
-			->onlyMethods(['updateProperties'])
-			->getMock();
-
-		// create 2 new address books
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example2', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(2, count($books));
-		$bookId0 = $books[0]['id'];
-		$bookId1 = $books[1]['id'];
-
-		// create a card
-		$uri0 = $this->getUniqueID('card');
-		$this->backend->createCard($bookId0, $uri0, $this->vcardTest0);
-
-		// create another card with same uid but in second address book
-		$uri1 = $this->getUniqueID('card');
-		$this->backend->createCard($bookId1, $uri1, $this->vcardTest0);
-	}
-
-	public function testMultipleUIDDenied(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
-			->onlyMethods(['updateProperties'])
-			->getMock();
-
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$bookId = $books[0]['id'];
-
-		// create a card
-		$uri0 = $this->getUniqueID('card');
-		$this->backend->createCard($bookId, $uri0, $this->vcardTest0);
-
-		// create another card with same uid
-		$uri1 = $this->getUniqueID('card');
-		$this->expectException(BadRequest::class);
-		$test = $this->backend->createCard($bookId, $uri1, $this->vcardTest0);
-	}
-
-	public function testNoValidUID(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
-			->onlyMethods(['updateProperties'])
-			->getMock();
-
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$bookId = $books[0]['id'];
-
-		// create a card without uid
-		$uri1 = $this->getUniqueID('card');
-		$this->expectException(BadRequest::class);
-		$test = $this->backend->createCard($bookId, $uri1, $this->vcardTestNoUID);
-	}
-
-	public function testDeleteWithoutCard(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
-			->onlyMethods([
-				'getCardId',
-				'addChange',
-				'purgeProperties',
-				'updateProperties',
-			])
-			->getMock();
-
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getUsersOwnAddressBooks(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-
-		$bookId = $books[0]['id'];
-		$uri = $this->getUniqueID('card');
-
-		// create a new address book
-		$this->backend->expects($this->once())
-			->method('getCardId')
-			->with($bookId, $uri)
-			->willThrowException(new \InvalidArgumentException());
-
-		$calls = [
-			[$bookId, $uri, 1],
-			[$bookId, $uri, 3],
-		];
-		$this->backend->expects($this->exactly(count($calls)))
-			->method('addChange')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-		$this->backend->expects($this->never())
-			->method('purgeProperties');
-
-		// create a card
-		$this->backend->createCard($bookId, $uri, $this->vcardTest0);
-
-		// delete the card
-		$this->assertTrue($this->backend->deleteCard($bookId, $uri));
-	}
-
-	public function testSyncSupport(): void {
-		$this->backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
-			->onlyMethods(['updateProperties'])
-			->getMock();
-
-		// create a new address book
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-		$bookId = $books[0]['id'];
-
-		// fist call without synctoken
-		$changes = $this->backend->getChangesForAddressBook($bookId, '', 1);
-		$syncToken = $changes['syncToken'];
-
-		// add a change
-		$uri0 = $this->getUniqueID('card');
-		$this->backend->createCard($bookId, $uri0, $this->vcardTest0);
-
-		// look for changes
-		$changes = $this->backend->getChangesForAddressBook($bookId, $syncToken, 1);
-		$this->assertEquals($uri0, $changes['added'][0]);
-	}
-
-	public function testSharing(): void {
-		$this->userManager->expects($this->any())
-			->method('userExists')
-			->willReturn(true);
-		$this->groupManager->expects($this->any())
-			->method('groupExists')
-			->willReturn(true);
-		$this->principal->expects(self::any())
-			->method('findByUri')
-			->willReturn(self::UNIT_TEST_USER1);
-
-		$this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
-		$this->assertEquals(1, count($books));
-
-		$l = $this->createMock(IL10N::class);
-		$exampleBook = new AddressBook($this->backend, $books[0], $l);
-		$this->backend->updateShares($exampleBook, [['href' => 'principal:' . self::UNIT_TEST_USER1]], []);
-
-		$shares = $this->backend->getShares($exampleBook->getResourceId());
-		$this->assertEquals(1, count($shares));
-
-		// adding the same sharee again has no effect
-		$this->backend->updateShares($exampleBook, [['href' => 'principal:' . self::UNIT_TEST_USER1]], []);
-
-		$shares = $this->backend->getShares($exampleBook->getResourceId());
-		$this->assertEquals(1, count($shares));
-
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
-		$this->assertEquals(1, count($books));
-
-		$this->backend->updateShares($exampleBook, [], ['principal:' . self::UNIT_TEST_USER1]);
-
-		$shares = $this->backend->getShares($exampleBook->getResourceId());
-		$this->assertEquals(0, count($shares));
-
-		$books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
-		$this->assertEquals(0, count($books));
-	}
-
-	public function testUpdateProperties(): void {
-		$bookId = 42;
-		$cardUri = 'card-uri';
-		$cardId = 2;
-
-		$backend = $this->getMockBuilder(CardDavBackend::class)
-			->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
-			->onlyMethods(['getCardId'])->getMock();
-
-		$backend->expects($this->any())->method('getCardId')->willReturn($cardId);
-
-		// add properties for new vCard
-		$vCard = new VCard();
-		$vCard->UID = $cardUri;
-		$vCard->FN = 'John Doe';
-		$this->invokePrivate($backend, 'updateProperties', [$bookId, $cardUri, $vCard->serialize()]);
-
-		$query = $this->db->getQueryBuilder();
-		$query->select('*')
-			->from('cards_properties')
-			->orderBy('name');
-
-		$qResult = $query->executeQuery();
-		$result = $qResult->fetchAllAssociative();
-		$qResult->closeCursor();
-
-		$this->assertSame(2, count($result));
-
-		$this->assertSame('FN', $result[0]['name']);
-		$this->assertSame('John Doe', $result[0]['value']);
-		$this->assertSame($bookId, (int)$result[0]['addressbookid']);
-		$this->assertSame($cardId, (int)$result[0]['cardid']);
-
-		$this->assertSame('UID', $result[1]['name']);
-		$this->assertSame($cardUri, $result[1]['value']);
-		$this->assertSame($bookId, (int)$result[1]['addressbookid']);
-		$this->assertSame($cardId, (int)$result[1]['cardid']);
-
-		// update properties for existing vCard
-		$vCard = new VCard();
-		$vCard->UID = $cardUri;
-		$this->invokePrivate($backend, 'updateProperties', [$bookId, $cardUri, $vCard->serialize()]);
-
-		$query = $this->db->getQueryBuilder();
-		$query->select('*')
-			->from('cards_properties');
-
-		$qResult = $query->executeQuery();
-		$result = $qResult->fetchAllAssociative();
-		$qResult->closeCursor();
-
-		$this->assertSame(1, count($result));
-
-		$this->assertSame('UID', $result[0]['name']);
-		$this->assertSame($cardUri, $result[0]['value']);
-		$this->assertSame($bookId, (int)$result[0]['addressbookid']);
-		$this->assertSame($cardId, (int)$result[0]['cardid']);
-	}
-
-	public function testPurgeProperties(): void {
-		$query = $this->db->getQueryBuilder();
-		$query->insert('cards_properties')
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(1),
-					'cardid' => $query->createNamedParameter(1),
-					'name' => $query->createNamedParameter('name1'),
-					'value' => $query->createNamedParameter('value1'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->executeStatement();
-
-		$query = $this->db->getQueryBuilder();
-		$query->insert('cards_properties')
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(1),
-					'cardid' => $query->createNamedParameter(2),
-					'name' => $query->createNamedParameter('name2'),
-					'value' => $query->createNamedParameter('value2'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->executeStatement();
-
-		$this->invokePrivate($this->backend, 'purgeProperties', [1, 1]);
-
-		$query = $this->db->getQueryBuilder();
-		$query->select('*')
-			->from('cards_properties');
-
-		$qResult = $query->executeQuery();
-		$result = $qResult->fetchAllAssociative();
-		$qResult->closeCursor();
-
-		$this->assertSame(1, count($result));
-		$this->assertSame(1, (int)$result[0]['addressbookid']);
-		$this->assertSame(2, (int)$result[0]['cardid']);
-	}
-
-	public function testGetCardId(): void {
-		$query = $this->db->getQueryBuilder();
-
-		$query->insert('cards')
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(1),
-					'carddata' => $query->createNamedParameter(''),
-					'uri' => $query->createNamedParameter('uri'),
-					'lastmodified' => $query->createNamedParameter(4738743),
-					'etag' => $query->createNamedParameter('etag'),
-					'size' => $query->createNamedParameter(120)
-				]
-			);
-		$query->executeStatement();
-		$id = $query->getLastInsertId();
-
-		$this->assertSame($id,
-			$this->invokePrivate($this->backend, 'getCardId', [1, 'uri']));
-	}
-
-
-	public function testGetCardIdFailed(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$this->invokePrivate($this->backend, 'getCardId', [1, 'uri']);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestSearch')]
-	public function testSearch(string $pattern, array $properties, array $options, array $expected): void {
-		/** @var VCard $vCards */
-		$vCards = [];
-		$vCards[0] = new VCard();
-		$vCards[0]->add(new Text($vCards[0], 'UID', 'uid'));
-		$vCards[0]->add(new Text($vCards[0], 'FN', 'John Doe'));
-		$vCards[0]->add(new Text($vCards[0], 'CLOUD', 'john@nextcloud.com'));
-		$vCards[1] = new VCard();
-		$vCards[1]->add(new Text($vCards[1], 'UID', 'uid'));
-		$vCards[1]->add(new Text($vCards[1], 'FN', 'John M. Doe'));
-		$vCards[2] = new VCard();
-		$vCards[2]->add(new Text($vCards[2], 'UID', 'uid'));
-		$vCards[2]->add(new Text($vCards[2], 'FN', 'find without options'));
-		$vCards[2]->add(new Text($vCards[2], 'CLOUD', 'peter_pan@nextcloud.com'));
-
-		$vCardIds = [];
-		$query = $this->db->getQueryBuilder();
-		for ($i = 0; $i < 3; $i++) {
-			$query->insert($this->dbCardsTable)
-				->values(
-					[
-						'addressbookid' => $query->createNamedParameter(0),
-						'carddata' => $query->createNamedParameter($vCards[$i]->serialize(), IQueryBuilder::PARAM_LOB),
-						'uri' => $query->createNamedParameter('uri' . $i),
-						'lastmodified' => $query->createNamedParameter(time()),
-						'etag' => $query->createNamedParameter('etag' . $i),
-						'size' => $query->createNamedParameter(120),
-					]
-				);
-			$query->executeStatement();
-			$vCardIds[] = $query->getLastInsertId();
-		}
-
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(0),
-					'cardid' => $query->createNamedParameter($vCardIds[0]),
-					'name' => $query->createNamedParameter('FN'),
-					'value' => $query->createNamedParameter('John Doe'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->executeStatement();
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(0),
-					'cardid' => $query->createNamedParameter($vCardIds[0]),
-					'name' => $query->createNamedParameter('CLOUD'),
-					'value' => $query->createNamedParameter('John@nextcloud.com'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->executeStatement();
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(0),
-					'cardid' => $query->createNamedParameter($vCardIds[1]),
-					'name' => $query->createNamedParameter('FN'),
-					'value' => $query->createNamedParameter('John M. Doe'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->executeStatement();
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(0),
-					'cardid' => $query->createNamedParameter($vCardIds[2]),
-					'name' => $query->createNamedParameter('FN'),
-					'value' => $query->createNamedParameter('find without options'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->executeStatement();
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(0),
-					'cardid' => $query->createNamedParameter($vCardIds[2]),
-					'name' => $query->createNamedParameter('CLOUD'),
-					'value' => $query->createNamedParameter('peter_pan@nextcloud.com'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			);
-		$query->executeStatement();
-
-		$result = $this->backend->search(0, $pattern, $properties, $options);
-
-		// check result
-		$this->assertSame(count($expected), count($result));
-		$found = [];
-		foreach ($result as $r) {
-			foreach ($expected as $exp) {
-				if ($r['uri'] === $exp[0] && strpos($r['carddata'], $exp[1]) > 0) {
-					$found[$exp[1]] = true;
-					break;
-				}
-			}
-		}
-
-		$this->assertSame(count($expected), count($found));
-	}
-
-	public static function dataTestSearch(): array {
-		return [
-			['John', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
-			['M. Doe', ['FN'], [], [['uri1', 'John M. Doe']]],
-			['Do', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
-			'check if duplicates are handled correctly' => ['John', ['FN', 'CLOUD'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
-			'case insensitive' => ['john', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
-			'limit' => ['john', ['FN'], ['limit' => 1], [['uri0', 'John Doe']]],
-			'limit and offset' => ['john', ['FN'], ['limit' => 1, 'offset' => 1], [['uri1', 'John M. Doe']]],
-			'find "_" escaped' => ['_', ['CLOUD'], [], [['uri2', 'find without options']]],
-			'find not empty CLOUD' => ['%_%', ['CLOUD'], ['escape_like_param' => false], [['uri0', 'John Doe'], ['uri2', 'find without options']]],
-		];
-	}
-
-	public function testGetCardUri(): void {
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(1),
-					'carddata' => $query->createNamedParameter('carddata', IQueryBuilder::PARAM_LOB),
-					'uri' => $query->createNamedParameter('uri'),
-					'lastmodified' => $query->createNamedParameter(5489543),
-					'etag' => $query->createNamedParameter('etag'),
-					'size' => $query->createNamedParameter(120),
-				]
-			);
-		$query->executeStatement();
-
-		$id = $query->getLastInsertId();
-
-		$this->assertSame('uri', $this->backend->getCardUri($id));
-	}
-
-
-	public function testGetCardUriFailed(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$this->backend->getCardUri(1);
-	}
-
-	public function testGetContact(): void {
-		$query = $this->db->getQueryBuilder();
-		for ($i = 0; $i < 2; $i++) {
-			$query->insert($this->dbCardsTable)
-				->values(
-					[
-						'addressbookid' => $query->createNamedParameter($i),
-						'carddata' => $query->createNamedParameter('carddata' . $i, IQueryBuilder::PARAM_LOB),
-						'uri' => $query->createNamedParameter('uri' . $i),
-						'lastmodified' => $query->createNamedParameter(5489543),
-						'etag' => $query->createNamedParameter('etag' . $i),
-						'size' => $query->createNamedParameter(120),
-					]
-				);
-			$query->executeStatement();
-		}
-
-		$result = $this->backend->getContact(0, 'uri0');
-		$this->assertSame(8, count($result));
-		$this->assertSame(0, (int)$result['addressbookid']);
-		$this->assertSame('uri0', $result['uri']);
-		$this->assertSame(5489543, (int)$result['lastmodified']);
-		$this->assertSame('"etag0"', $result['etag']);
-		$this->assertSame(120, (int)$result['size']);
-
-		// this shouldn't return any result because 'uri1' is in address book 1
-		// see https://github.com/nextcloud/server/issues/229
-		$result = $this->backend->getContact(0, 'uri1');
-		$this->assertEmpty($result);
-	}
-
-	public function testGetContactFail(): void {
-		$this->assertEmpty($this->backend->getContact(0, 'uri'));
-	}
-
-	public function testCollectCardProperties(): void {
-		$query = $this->db->getQueryBuilder();
-		$query->insert($this->dbCardsPropertiesTable)
-			->values(
-				[
-					'addressbookid' => $query->createNamedParameter(666),
-					'cardid' => $query->createNamedParameter(777),
-					'name' => $query->createNamedParameter('FN'),
-					'value' => $query->createNamedParameter('John Doe'),
-					'preferred' => $query->createNamedParameter(0)
-				]
-			)
-			->executeStatement();
-
-		$result = $this->backend->collectCardProperties(666, 'FN');
-		$this->assertEquals(['John Doe'], $result);
-	}
-
-	/**
-	 * @throws \OCP\DB\Exception
-	 * @throws \Sabre\DAV\Exception\BadRequest
-	 */
-	public function testPruneOutdatedSyncTokens(): void {
-		$addressBookId = $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, '', 1);
-		$syncToken = $changes['syncToken'];
-
-		$uri = $this->getUniqueID('card');
-		$this->backend->createCard($addressBookId, $uri, $this->vcardTest0);
-		$this->backend->updateCard($addressBookId, $uri, $this->vcardTest1);
-
-		// Do not delete anything if week data as old as ts=0
-		$deleted = $this->backend->pruneOutdatedSyncTokens(0, 0);
-		self::assertSame(0, $deleted);
-
-		$deleted = $this->backend->pruneOutdatedSyncTokens(0, time());
-		// At least one from the object creation and one from the object update
-		$this->assertGreaterThanOrEqual(2, $deleted);
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 1);
-		$this->assertEmpty($changes['added']);
-		$this->assertEmpty($changes['modified']);
-		$this->assertEmpty($changes['deleted']);
-
-		// Test that objects remain
-
-		// Currently changes are empty
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
-		$this->assertEquals(0, count($changes['added'] + $changes['modified'] + $changes['deleted']));
-
-		// Create card
-		$uri = $this->getUniqueID('card');
-		$this->backend->createCard($addressBookId, $uri, $this->vcardTest0);
-		// We now have one add
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
-		$this->assertEquals(1, count($changes['added']));
-		$this->assertEmpty($changes['modified']);
-		$this->assertEmpty($changes['deleted']);
-
-		// Update card
-		$this->backend->updateCard($addressBookId, $uri, $this->vcardTest1);
-		// One add, one modify, but shortened to modify
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
-		$this->assertEmpty($changes['added']);
-		$this->assertEquals(1, count($changes['modified']));
-		$this->assertEmpty($changes['deleted']);
-
-		// Delete all but last change
-		$deleted = $this->backend->pruneOutdatedSyncTokens(1, time());
-		$this->assertEquals(1, $deleted); // We had two changes before, now one
-
-		// Only update should remain
-		$changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
-		$this->assertEmpty($changes['added']);
-		$this->assertEquals(1, count($changes['modified']));
-		$this->assertEmpty($changes['deleted']);
-
-		// Check that no crash occurs when prune is called without current changes
-		$deleted = $this->backend->pruneOutdatedSyncTokens(1, time());
-	}
+    private Principal&MockObject $principal;
+    private IUserManager&MockObject $userManager;
+    private IGroupManager&MockObject $groupManager;
+    private IEventDispatcher&MockObject $dispatcher;
+    private IConfig&MockObject $config;
+    private RemoteUserPrincipalBackend&MockObject $remoteUserPrincipalBackend;
+    private FederationSharingService&MockObject $federationSharingService;
+    private Backend $sharingBackend;
+    private IDBConnection $db;
+    private CardDavBackend $backend;
+    private string $dbCardsTable = 'cards';
+    private string $dbCardsPropertiesTable = 'cards_properties';
+
+    public const UNIT_TEST_USER = 'principals/users/carddav-unit-test';
+    public const UNIT_TEST_USER1 = 'principals/users/carddav-unit-test1';
+    public const UNIT_TEST_GROUP = 'principals/groups/carddav-unit-test-group';
+
+    private $vcardTest0 = 'BEGIN:VCARD' . PHP_EOL
+        . 'VERSION:3.0' . PHP_EOL
+        . 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
+        . 'UID:Test' . PHP_EOL
+        . 'FN:Test' . PHP_EOL
+        . 'N:Test;;;;' . PHP_EOL
+        . 'END:VCARD';
+
+    private $vcardTest1 = 'BEGIN:VCARD' . PHP_EOL
+        . 'VERSION:3.0' . PHP_EOL
+        . 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
+        . 'UID:Test2' . PHP_EOL
+        . 'FN:Test2' . PHP_EOL
+        . 'N:Test2;;;;' . PHP_EOL
+        . 'END:VCARD';
+
+    private $vcardTest2 = 'BEGIN:VCARD' . PHP_EOL
+        . 'VERSION:3.0' . PHP_EOL
+        . 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
+        . 'UID:Test3' . PHP_EOL
+        . 'FN:Test3' . PHP_EOL
+        . 'N:Test3;;;;' . PHP_EOL
+        . 'END:VCARD';
+
+    private $vcardTestNoUID = 'BEGIN:VCARD' . PHP_EOL
+        . 'VERSION:3.0' . PHP_EOL
+        . 'PRODID:-//Sabre//Sabre VObject 4.1.2//EN' . PHP_EOL
+        . 'FN:TestNoUID' . PHP_EOL
+        . 'N:TestNoUID;;;;' . PHP_EOL
+        . 'END:VCARD';
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->principal = $this->getMockBuilder(Principal::class)
+            ->setConstructorArgs([
+                $this->userManager,
+                $this->groupManager,
+                $this->createMock(IAccountManager::class),
+                $this->createMock(ShareManager::class),
+                $this->createMock(IUserSession::class),
+                $this->createMock(IAppManager::class),
+                $this->createMock(ProxyMapper::class),
+                $this->createMock(KnownUserService::class),
+                $this->config,
+                $this->createMock(IFactory::class)
+            ])
+            ->onlyMethods(['getPrincipalByPath', 'getGroupMembership', 'findByUri'])
+            ->getMock();
+        $this->principal->method('getPrincipalByPath')
+            ->willReturn([
+                'uri' => 'principals/best-friend',
+                '{DAV:}displayname' => 'User\'s displayname',
+            ]);
+        $this->principal->method('getGroupMembership')
+            ->withAnyParameters()
+            ->willReturn([self::UNIT_TEST_GROUP]);
+        $this->dispatcher = $this->createMock(IEventDispatcher::class);
+        $this->remoteUserPrincipalBackend = $this->createMock(RemoteUserPrincipalBackend::class);
+        $this->federationSharingService = $this->createMock(FederationSharingService::class);
+
+        $this->db = Server::get(IDBConnection::class);
+        $this->sharingBackend = new Backend($this->userManager,
+            $this->groupManager,
+            $this->principal,
+            $this->remoteUserPrincipalBackend,
+            $this->createMock(ICacheFactory::class),
+            new Service(new SharingMapper($this->db)),
+            $this->federationSharingService,
+            $this->createMock(LoggerInterface::class)
+        );
+
+        $this->backend = new CardDavBackend($this->db,
+            $this->principal,
+            $this->userManager,
+            $this->dispatcher,
+            $this->sharingBackend,
+            $this->config,
+        );
+        // start every test with a empty cards_properties and cards table
+        $query = $this->db->getQueryBuilder();
+        $query->delete('cards_properties')->executeStatement();
+        $query = $this->db->getQueryBuilder();
+        $query->delete('cards')->executeStatement();
+
+        $this->principal->method('getGroupMembership')
+            ->withAnyParameters()
+            ->willReturn([self::UNIT_TEST_GROUP]);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        foreach ($books as $book) {
+            $this->backend->deleteAddressBook($book['id']);
+        }
+    }
+
+    protected function tearDown(): void {
+        if (is_null($this->backend)) {
+            return;
+        }
+
+        $this->principal->method('getGroupMembership')
+            ->withAnyParameters()
+            ->willReturn([self::UNIT_TEST_GROUP]);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        foreach ($books as $book) {
+            $this->backend->deleteAddressBook($book['id']);
+        }
+
+        parent::tearDown();
+    }
+
+    public function testAddressBookOperations(): void {
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+
+        $this->assertEquals(1, $this->backend->getAddressBooksForUserCount(self::UNIT_TEST_USER));
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $this->assertEquals('Example', $books[0]['{DAV:}displayname']);
+        $this->assertEquals('User\'s displayname', $books[0]['{http://nextcloud.com/ns}owner-displayname']);
+
+        // update its display name
+        $patch = new PropPatch([
+            '{DAV:}displayname' => 'Unit test',
+            '{urn:ietf:params:xml:ns:carddav}addressbook-description' => 'Addressbook used for unit testing'
+        ]);
+        $this->backend->updateAddressBook($books[0]['id'], $patch);
+        $patch->commit();
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $this->assertEquals('Unit test', $books[0]['{DAV:}displayname']);
+        $this->assertEquals('Addressbook used for unit testing', $books[0]['{urn:ietf:params:xml:ns:carddav}addressbook-description']);
+
+        // delete the address book
+        $this->backend->deleteAddressBook($books[0]['id']);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(0, count($books));
+    }
+
+    public function testAddressBookSharing(): void {
+        $this->userManager->expects($this->any())
+            ->method('userExists')
+            ->willReturn(true);
+        $this->groupManager->expects($this->any())
+            ->method('groupExists')
+            ->willReturn(true);
+        $this->principal->expects(self::atLeastOnce())
+            ->method('findByUri')
+            ->willReturnOnConsecutiveCalls(self::UNIT_TEST_USER1, self::UNIT_TEST_GROUP);
+
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $l = $this->createMock(IL10N::class);
+        $addressBook = new AddressBook($this->backend, $books[0], $l);
+        $this->backend->updateShares($addressBook, [
+            [
+                'href' => 'principal:' . self::UNIT_TEST_USER1,
+            ],
+            [
+                'href' => 'principal:' . self::UNIT_TEST_GROUP,
+            ]
+        ], []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
+        $this->assertEquals(1, count($books));
+
+        // delete the address book
+        $this->backend->deleteAddressBook($books[0]['id']);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(0, count($books));
+    }
+
+    public function testCardOperations(): void {
+        /** @var CardDavBackend&MockObject $backend */
+        $backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend,$this->config])
+            ->onlyMethods(['updateProperties', 'purgeProperties'])
+            ->getMock();
+
+        // create a new address book
+        $backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $bookId = $books[0]['id'];
+
+        $uri = $this->getUniqueID('card');
+        // updateProperties is expected twice, once for createCard and once for updateCard
+        $calls = [
+            [$bookId, $uri, $this->vcardTest0],
+            [$bookId, $uri, $this->vcardTest1],
+        ];
+        $backend->expects($this->exactly(count($calls)))
+            ->method('updateProperties')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+
+        // Expect event
+        $this->dispatcher
+            ->expects($this->exactly(3))
+            ->method('dispatchTyped');
+
+        // create a card
+        $backend->createCard($bookId, $uri, $this->vcardTest0);
+
+        // get all the cards
+        $cards = $backend->getCards($bookId);
+        $this->assertEquals(1, count($cards));
+        $this->assertEquals($this->vcardTest0, $cards[0]['carddata']);
+
+        // get the cards
+        $card = $backend->getCard($bookId, $uri);
+        $this->assertNotNull($card);
+        $this->assertArrayHasKey('id', $card);
+        $this->assertArrayHasKey('uri', $card);
+        $this->assertArrayHasKey('lastmodified', $card);
+        $this->assertArrayHasKey('etag', $card);
+        $this->assertArrayHasKey('size', $card);
+        $this->assertEquals($this->vcardTest0, $card['carddata']);
+
+        // update the card
+        $backend->updateCard($bookId, $uri, $this->vcardTest1);
+        $card = $backend->getCard($bookId, $uri);
+        $this->assertEquals($this->vcardTest1, $card['carddata']);
+
+        // delete the card
+        $backend->expects($this->once())->method('purgeProperties')->with($bookId, $card['id']);
+        $backend->deleteCard($bookId, $uri);
+        $cards = $backend->getCards($bookId);
+        $this->assertEquals(0, count($cards));
+    }
+
+    public function testMultiCard(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend,$this->config])
+            ->onlyMethods(['updateProperties'])
+            ->getMock();
+
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $bookId = $books[0]['id'];
+
+        // create a card
+        $uri0 = self::getUniqueID('card');
+        $this->backend->createCard($bookId, $uri0, $this->vcardTest0);
+        $uri1 = self::getUniqueID('card');
+        $this->backend->createCard($bookId, $uri1, $this->vcardTest1);
+        $uri2 = self::getUniqueID('card');
+        $this->backend->createCard($bookId, $uri2, $this->vcardTest2);
+
+        // get all the cards
+        $cards = $this->backend->getCards($bookId);
+        $this->assertEquals(3, count($cards));
+        usort($cards, function ($a, $b) {
+            return $a['id'] < $b['id'] ? -1 : 1;
+        });
+
+        $this->assertEquals($this->vcardTest0, $cards[0]['carddata']);
+        $this->assertEquals($this->vcardTest1, $cards[1]['carddata']);
+        $this->assertEquals($this->vcardTest2, $cards[2]['carddata']);
+
+        // get the cards 1 & 2 (not 0)
+        $cards = $this->backend->getMultipleCards($bookId, [$uri1, $uri2]);
+        $this->assertEquals(2, count($cards));
+        usort($cards, function ($a, $b) {
+            return $a['id'] < $b['id'] ? -1 : 1;
+        });
+        foreach ($cards as $index => $card) {
+            $this->assertArrayHasKey('id', $card);
+            $this->assertArrayHasKey('uri', $card);
+            $this->assertArrayHasKey('lastmodified', $card);
+            $this->assertArrayHasKey('etag', $card);
+            $this->assertArrayHasKey('size', $card);
+            $this->assertEquals($this->{ 'vcardTest' . ($index + 1) }, $card['carddata']);
+        }
+
+        // delete the card
+        $this->backend->deleteCard($bookId, $uri0);
+        $this->backend->deleteCard($bookId, $uri1);
+        $this->backend->deleteCard($bookId, $uri2);
+        $cards = $this->backend->getCards($bookId);
+        $this->assertEquals(0, count($cards));
+    }
+
+    public function testMultipleUIDOnDifferentAddressbooks(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend,$this->config])
+            ->onlyMethods(['updateProperties'])
+            ->getMock();
+
+        // create 2 new address books
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example2', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(2, count($books));
+        $bookId0 = $books[0]['id'];
+        $bookId1 = $books[1]['id'];
+
+        // create a card
+        $uri0 = $this->getUniqueID('card');
+        $this->backend->createCard($bookId0, $uri0, $this->vcardTest0);
+
+        // create another card with same uid but in second address book
+        $uri1 = $this->getUniqueID('card');
+        $this->backend->createCard($bookId1, $uri1, $this->vcardTest0);
+    }
+
+    public function testMultipleUIDDenied(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
+            ->onlyMethods(['updateProperties'])
+            ->getMock();
+
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $bookId = $books[0]['id'];
+
+        // create a card
+        $uri0 = $this->getUniqueID('card');
+        $this->backend->createCard($bookId, $uri0, $this->vcardTest0);
+
+        // create another card with same uid
+        $uri1 = $this->getUniqueID('card');
+        $this->expectException(BadRequest::class);
+        $test = $this->backend->createCard($bookId, $uri1, $this->vcardTest0);
+    }
+
+    public function testNoValidUID(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
+            ->onlyMethods(['updateProperties'])
+            ->getMock();
+
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $bookId = $books[0]['id'];
+
+        // create a card without uid
+        $uri1 = $this->getUniqueID('card');
+        $this->expectException(BadRequest::class);
+        $test = $this->backend->createCard($bookId, $uri1, $this->vcardTestNoUID);
+    }
+
+    public function testDeleteWithoutCard(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
+            ->onlyMethods([
+                'getCardId',
+                'addChange',
+                'purgeProperties',
+                'updateProperties',
+            ])
+            ->getMock();
+
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getUsersOwnAddressBooks(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+
+        $bookId = $books[0]['id'];
+        $uri = $this->getUniqueID('card');
+
+        // create a new address book
+        $this->backend->expects($this->once())
+            ->method('getCardId')
+            ->with($bookId, $uri)
+            ->willThrowException(new \InvalidArgumentException());
+
+        $calls = [
+            [$bookId, $uri, 1],
+            [$bookId, $uri, 3],
+        ];
+        $this->backend->expects($this->exactly(count($calls)))
+            ->method('addChange')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+        $this->backend->expects($this->never())
+            ->method('purgeProperties');
+
+        // create a card
+        $this->backend->createCard($bookId, $uri, $this->vcardTest0);
+
+        // delete the card
+        $this->assertTrue($this->backend->deleteCard($bookId, $uri));
+    }
+
+    public function testSyncSupport(): void {
+        $this->backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
+            ->onlyMethods(['updateProperties'])
+            ->getMock();
+
+        // create a new address book
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+        $bookId = $books[0]['id'];
+
+        // fist call without synctoken
+        $changes = $this->backend->getChangesForAddressBook($bookId, '', 1);
+        $syncToken = $changes['syncToken'];
+
+        // add a change
+        $uri0 = $this->getUniqueID('card');
+        $this->backend->createCard($bookId, $uri0, $this->vcardTest0);
+
+        // look for changes
+        $changes = $this->backend->getChangesForAddressBook($bookId, $syncToken, 1);
+        $this->assertEquals($uri0, $changes['added'][0]);
+    }
+
+    public function testSharing(): void {
+        $this->userManager->expects($this->any())
+            ->method('userExists')
+            ->willReturn(true);
+        $this->groupManager->expects($this->any())
+            ->method('groupExists')
+            ->willReturn(true);
+        $this->principal->expects(self::any())
+            ->method('findByUri')
+            ->willReturn(self::UNIT_TEST_USER1);
+
+        $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER);
+        $this->assertEquals(1, count($books));
+
+        $l = $this->createMock(IL10N::class);
+        $exampleBook = new AddressBook($this->backend, $books[0], $l);
+        $this->backend->updateShares($exampleBook, [['href' => 'principal:' . self::UNIT_TEST_USER1]], []);
+
+        $shares = $this->backend->getShares($exampleBook->getResourceId());
+        $this->assertEquals(1, count($shares));
+
+        // adding the same sharee again has no effect
+        $this->backend->updateShares($exampleBook, [['href' => 'principal:' . self::UNIT_TEST_USER1]], []);
+
+        $shares = $this->backend->getShares($exampleBook->getResourceId());
+        $this->assertEquals(1, count($shares));
+
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
+        $this->assertEquals(1, count($books));
+
+        $this->backend->updateShares($exampleBook, [], ['principal:' . self::UNIT_TEST_USER1]);
+
+        $shares = $this->backend->getShares($exampleBook->getResourceId());
+        $this->assertEquals(0, count($shares));
+
+        $books = $this->backend->getAddressBooksForUser(self::UNIT_TEST_USER1);
+        $this->assertEquals(0, count($books));
+    }
+
+    public function testUpdateProperties(): void {
+        $bookId = 42;
+        $cardUri = 'card-uri';
+        $cardId = 2;
+
+        $backend = $this->getMockBuilder(CardDavBackend::class)
+            ->setConstructorArgs([$this->db, $this->principal, $this->userManager, $this->dispatcher, $this->sharingBackend, $this->config])
+            ->onlyMethods(['getCardId'])->getMock();
+
+        $backend->expects($this->any())->method('getCardId')->willReturn($cardId);
+
+        // add properties for new vCard
+        $vCard = new VCard();
+        $vCard->UID = $cardUri;
+        $vCard->FN = 'John Doe';
+        $this->invokePrivate($backend, 'updateProperties', [$bookId, $cardUri, $vCard->serialize()]);
+
+        $query = $this->db->getQueryBuilder();
+        $query->select('*')
+            ->from('cards_properties')
+            ->orderBy('name');
+
+        $qResult = $query->executeQuery();
+        $result = $qResult->fetchAllAssociative();
+        $qResult->closeCursor();
+
+        $this->assertSame(2, count($result));
+
+        $this->assertSame('FN', $result[0]['name']);
+        $this->assertSame('John Doe', $result[0]['value']);
+        $this->assertSame($bookId, (int)$result[0]['addressbookid']);
+        $this->assertSame($cardId, (int)$result[0]['cardid']);
+
+        $this->assertSame('UID', $result[1]['name']);
+        $this->assertSame($cardUri, $result[1]['value']);
+        $this->assertSame($bookId, (int)$result[1]['addressbookid']);
+        $this->assertSame($cardId, (int)$result[1]['cardid']);
+
+        // update properties for existing vCard
+        $vCard = new VCard();
+        $vCard->UID = $cardUri;
+        $this->invokePrivate($backend, 'updateProperties', [$bookId, $cardUri, $vCard->serialize()]);
+
+        $query = $this->db->getQueryBuilder();
+        $query->select('*')
+            ->from('cards_properties');
+
+        $qResult = $query->executeQuery();
+        $result = $qResult->fetchAllAssociative();
+        $qResult->closeCursor();
+
+        $this->assertSame(1, count($result));
+
+        $this->assertSame('UID', $result[0]['name']);
+        $this->assertSame($cardUri, $result[0]['value']);
+        $this->assertSame($bookId, (int)$result[0]['addressbookid']);
+        $this->assertSame($cardId, (int)$result[0]['cardid']);
+    }
+
+    public function testPurgeProperties(): void {
+        $query = $this->db->getQueryBuilder();
+        $query->insert('cards_properties')
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(1),
+                    'cardid' => $query->createNamedParameter(1),
+                    'name' => $query->createNamedParameter('name1'),
+                    'value' => $query->createNamedParameter('value1'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->executeStatement();
+
+        $query = $this->db->getQueryBuilder();
+        $query->insert('cards_properties')
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(1),
+                    'cardid' => $query->createNamedParameter(2),
+                    'name' => $query->createNamedParameter('name2'),
+                    'value' => $query->createNamedParameter('value2'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->executeStatement();
+
+        $this->invokePrivate($this->backend, 'purgeProperties', [1, 1]);
+
+        $query = $this->db->getQueryBuilder();
+        $query->select('*')
+            ->from('cards_properties');
+
+        $qResult = $query->executeQuery();
+        $result = $qResult->fetchAllAssociative();
+        $qResult->closeCursor();
+
+        $this->assertSame(1, count($result));
+        $this->assertSame(1, (int)$result[0]['addressbookid']);
+        $this->assertSame(2, (int)$result[0]['cardid']);
+    }
+
+    public function testGetCardId(): void {
+        $query = $this->db->getQueryBuilder();
+
+        $query->insert('cards')
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(1),
+                    'carddata' => $query->createNamedParameter(''),
+                    'uri' => $query->createNamedParameter('uri'),
+                    'lastmodified' => $query->createNamedParameter(4738743),
+                    'etag' => $query->createNamedParameter('etag'),
+                    'size' => $query->createNamedParameter(120)
+                ]
+            );
+        $query->executeStatement();
+        $id = $query->getLastInsertId();
+
+        $this->assertSame($id,
+            $this->invokePrivate($this->backend, 'getCardId', [1, 'uri']));
+    }
+
+
+    public function testGetCardIdFailed(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $this->invokePrivate($this->backend, 'getCardId', [1, 'uri']);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestSearch')]
+    public function testSearch(string $pattern, array $properties, array $options, array $expected): void {
+        /** @var VCard $vCards */
+        $vCards = [];
+        $vCards[0] = new VCard();
+        $vCards[0]->add(new Text($vCards[0], 'UID', 'uid'));
+        $vCards[0]->add(new Text($vCards[0], 'FN', 'John Doe'));
+        $vCards[0]->add(new Text($vCards[0], 'CLOUD', 'john@nextcloud.com'));
+        $vCards[1] = new VCard();
+        $vCards[1]->add(new Text($vCards[1], 'UID', 'uid'));
+        $vCards[1]->add(new Text($vCards[1], 'FN', 'John M. Doe'));
+        $vCards[2] = new VCard();
+        $vCards[2]->add(new Text($vCards[2], 'UID', 'uid'));
+        $vCards[2]->add(new Text($vCards[2], 'FN', 'find without options'));
+        $vCards[2]->add(new Text($vCards[2], 'CLOUD', 'peter_pan@nextcloud.com'));
+
+        $vCardIds = [];
+        $query = $this->db->getQueryBuilder();
+        for ($i = 0; $i < 3; $i++) {
+            $query->insert($this->dbCardsTable)
+                ->values(
+                    [
+                        'addressbookid' => $query->createNamedParameter(0),
+                        'carddata' => $query->createNamedParameter($vCards[$i]->serialize(), IQueryBuilder::PARAM_LOB),
+                        'uri' => $query->createNamedParameter('uri' . $i),
+                        'lastmodified' => $query->createNamedParameter(time()),
+                        'etag' => $query->createNamedParameter('etag' . $i),
+                        'size' => $query->createNamedParameter(120),
+                    ]
+                );
+            $query->executeStatement();
+            $vCardIds[] = $query->getLastInsertId();
+        }
+
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(0),
+                    'cardid' => $query->createNamedParameter($vCardIds[0]),
+                    'name' => $query->createNamedParameter('FN'),
+                    'value' => $query->createNamedParameter('John Doe'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->executeStatement();
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(0),
+                    'cardid' => $query->createNamedParameter($vCardIds[0]),
+                    'name' => $query->createNamedParameter('CLOUD'),
+                    'value' => $query->createNamedParameter('John@nextcloud.com'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->executeStatement();
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(0),
+                    'cardid' => $query->createNamedParameter($vCardIds[1]),
+                    'name' => $query->createNamedParameter('FN'),
+                    'value' => $query->createNamedParameter('John M. Doe'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->executeStatement();
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(0),
+                    'cardid' => $query->createNamedParameter($vCardIds[2]),
+                    'name' => $query->createNamedParameter('FN'),
+                    'value' => $query->createNamedParameter('find without options'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->executeStatement();
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(0),
+                    'cardid' => $query->createNamedParameter($vCardIds[2]),
+                    'name' => $query->createNamedParameter('CLOUD'),
+                    'value' => $query->createNamedParameter('peter_pan@nextcloud.com'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            );
+        $query->executeStatement();
+
+        $result = $this->backend->search(0, $pattern, $properties, $options);
+
+        // check result
+        $this->assertSame(count($expected), count($result));
+        $found = [];
+        foreach ($result as $r) {
+            foreach ($expected as $exp) {
+                if ($r['uri'] === $exp[0] && strpos($r['carddata'], $exp[1]) > 0) {
+                    $found[$exp[1]] = true;
+                    break;
+                }
+            }
+        }
+
+        $this->assertSame(count($expected), count($found));
+    }
+
+    public static function dataTestSearch(): array {
+        return [
+            ['John', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
+            ['M. Doe', ['FN'], [], [['uri1', 'John M. Doe']]],
+            ['Do', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
+            'check if duplicates are handled correctly' => ['John', ['FN', 'CLOUD'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
+            'case insensitive' => ['john', ['FN'], [], [['uri0', 'John Doe'], ['uri1', 'John M. Doe']]],
+            'limit' => ['john', ['FN'], ['limit' => 1], [['uri0', 'John Doe']]],
+            'limit and offset' => ['john', ['FN'], ['limit' => 1, 'offset' => 1], [['uri1', 'John M. Doe']]],
+            'find "_" escaped' => ['_', ['CLOUD'], [], [['uri2', 'find without options']]],
+            'find not empty CLOUD' => ['%_%', ['CLOUD'], ['escape_like_param' => false], [['uri0', 'John Doe'], ['uri2', 'find without options']]],
+        ];
+    }
+
+    public function testGetCardUri(): void {
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(1),
+                    'carddata' => $query->createNamedParameter('carddata', IQueryBuilder::PARAM_LOB),
+                    'uri' => $query->createNamedParameter('uri'),
+                    'lastmodified' => $query->createNamedParameter(5489543),
+                    'etag' => $query->createNamedParameter('etag'),
+                    'size' => $query->createNamedParameter(120),
+                ]
+            );
+        $query->executeStatement();
+
+        $id = $query->getLastInsertId();
+
+        $this->assertSame('uri', $this->backend->getCardUri($id));
+    }
+
+
+    public function testGetCardUriFailed(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $this->backend->getCardUri(1);
+    }
+
+    public function testGetContact(): void {
+        $query = $this->db->getQueryBuilder();
+        for ($i = 0; $i < 2; $i++) {
+            $query->insert($this->dbCardsTable)
+                ->values(
+                    [
+                        'addressbookid' => $query->createNamedParameter($i),
+                        'carddata' => $query->createNamedParameter('carddata' . $i, IQueryBuilder::PARAM_LOB),
+                        'uri' => $query->createNamedParameter('uri' . $i),
+                        'lastmodified' => $query->createNamedParameter(5489543),
+                        'etag' => $query->createNamedParameter('etag' . $i),
+                        'size' => $query->createNamedParameter(120),
+                    ]
+                );
+            $query->executeStatement();
+        }
+
+        $result = $this->backend->getContact(0, 'uri0');
+        $this->assertSame(8, count($result));
+        $this->assertSame(0, (int)$result['addressbookid']);
+        $this->assertSame('uri0', $result['uri']);
+        $this->assertSame(5489543, (int)$result['lastmodified']);
+        $this->assertSame('"etag0"', $result['etag']);
+        $this->assertSame(120, (int)$result['size']);
+
+        // this shouldn't return any result because 'uri1' is in address book 1
+        // see https://github.com/nextcloud/server/issues/229
+        $result = $this->backend->getContact(0, 'uri1');
+        $this->assertEmpty($result);
+    }
+
+    public function testGetContactFail(): void {
+        $this->assertEmpty($this->backend->getContact(0, 'uri'));
+    }
+
+    public function testCollectCardProperties(): void {
+        $query = $this->db->getQueryBuilder();
+        $query->insert($this->dbCardsPropertiesTable)
+            ->values(
+                [
+                    'addressbookid' => $query->createNamedParameter(666),
+                    'cardid' => $query->createNamedParameter(777),
+                    'name' => $query->createNamedParameter('FN'),
+                    'value' => $query->createNamedParameter('John Doe'),
+                    'preferred' => $query->createNamedParameter(0)
+                ]
+            )
+            ->executeStatement();
+
+        $result = $this->backend->collectCardProperties(666, 'FN');
+        $this->assertEquals(['John Doe'], $result);
+    }
+
+    /**
+     * @throws \OCP\DB\Exception
+     * @throws \Sabre\DAV\Exception\BadRequest
+     */
+    public function testPruneOutdatedSyncTokens(): void {
+        $addressBookId = $this->backend->createAddressBook(self::UNIT_TEST_USER, 'Example', []);
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, '', 1);
+        $syncToken = $changes['syncToken'];
+
+        $uri = $this->getUniqueID('card');
+        $this->backend->createCard($addressBookId, $uri, $this->vcardTest0);
+        $this->backend->updateCard($addressBookId, $uri, $this->vcardTest1);
+
+        // Do not delete anything if week data as old as ts=0
+        $deleted = $this->backend->pruneOutdatedSyncTokens(0, 0);
+        self::assertSame(0, $deleted);
+
+        $deleted = $this->backend->pruneOutdatedSyncTokens(0, time());
+        // At least one from the object creation and one from the object update
+        $this->assertGreaterThanOrEqual(2, $deleted);
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 1);
+        $this->assertEmpty($changes['added']);
+        $this->assertEmpty($changes['modified']);
+        $this->assertEmpty($changes['deleted']);
+
+        // Test that objects remain
+
+        // Currently changes are empty
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
+        $this->assertEquals(0, count($changes['added'] + $changes['modified'] + $changes['deleted']));
+
+        // Create card
+        $uri = $this->getUniqueID('card');
+        $this->backend->createCard($addressBookId, $uri, $this->vcardTest0);
+        // We now have one add
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
+        $this->assertEquals(1, count($changes['added']));
+        $this->assertEmpty($changes['modified']);
+        $this->assertEmpty($changes['deleted']);
+
+        // Update card
+        $this->backend->updateCard($addressBookId, $uri, $this->vcardTest1);
+        // One add, one modify, but shortened to modify
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
+        $this->assertEmpty($changes['added']);
+        $this->assertEquals(1, count($changes['modified']));
+        $this->assertEmpty($changes['deleted']);
+
+        // Delete all but last change
+        $deleted = $this->backend->pruneOutdatedSyncTokens(1, time());
+        $this->assertEquals(1, $deleted); // We had two changes before, now one
+
+        // Only update should remain
+        $changes = $this->backend->getChangesForAddressBook($addressBookId, $syncToken, 100);
+        $this->assertEmpty($changes['added']);
+        $this->assertEquals(1, count($changes['modified']));
+        $this->assertEmpty($changes['deleted']);
+
+        // Check that no crash occurs when prune is called without current changes
+        $deleted = $this->backend->pruneOutdatedSyncTokens(1, time());
+    }
 }

apps/dav/tests/unit/Paginate/PaginatePluginTest.php

Indentation +284 added lines, -284 removed lines

@@ -20,129 +20,129 @@ 
 
 class PaginatePluginTest extends TestCase {
 
-	private PaginateCache&MockObject $cache;
-	private PaginatePlugin $plugin;
-	private Server&MockObject $server;
-	private RequestInterface&MockObject $request;
-	private ResponseInterface&MockObject $response;
-
-	public function testOnMultiStatusCachesAndUpdatesResponse(): void {
-		$this->initializePlugin();
-
-		$fileProperties = [
-			[
-				'href' => '/file1',
-				200 => [
-					'{DAV:}displayname' => 'File 1',
-					'{DAV:}resourcetype' => null
-				],
-			],
-			[
-				'href' => '/file2',
-				200 => [
-					'{DAV:}displayname' => 'File 2',
-					'{DAV:}resourcetype' => null
-				],
-			],
-			[
-				'href' => '/file3',
-				200 => [
-					'{DAV:}displayname' => 'File 3',
-					'{DAV:}resourcetype' => null
-				],
-			],
-		];
-
-		$this->request->expects(self::exactly(2))
-			->method('hasHeader')
-			->willReturnMap([
-				[PaginatePlugin::PAGINATE_HEADER, true],
-				[PaginatePlugin::PAGINATE_TOKEN_HEADER, false],
-			]);
-
-		$this->request->expects(self::once())
-			->method('getUrl')
-			->willReturn('url');
-
-		$this->request->expects(self::exactly(2))
-			->method('getHeader')
-			->willReturnMap([
-				[PaginatePlugin::PAGINATE_COUNT_HEADER, 2],
-				[PaginatePlugin::PAGINATE_OFFSET_HEADER, 0],
-			]);
-
-		$this->request->expects(self::once())
-			->method('setHeader')
-			->with(PaginatePlugin::PAGINATE_TOKEN_HEADER, 'token');
-
-		$this->cache->expects(self::once())
-			->method('store')
-			->with(
-				'url',
-				$this->callback(function ($generator) {
-					self::assertInstanceOf(\Generator::class, $generator);
-					$items = iterator_to_array($generator);
-					self::assertCount(3, $items);
-					self::assertStringContainsString($this->getResponseXmlForFile('/dav/file1', 'File 1'), $items[0]);
-					self::assertStringContainsString($this->getResponseXmlForFile('/dav/file2', 'File 2'), $items[1]);
-					self::assertStringContainsString($this->getResponseXmlForFile('/dav/file3', 'File 3'), $items[2]);
-					return true;
-				}),
-			)
-			->willReturn([
-				'token' => 'token',
-				'count' => 3,
-			]);
-
-		$this->expectSequentialCalls(
-			$this->response,
-			'addHeader',
-			[
-				[PaginatePlugin::PAGINATE_HEADER, 'true'],
-				[PaginatePlugin::PAGINATE_TOKEN_HEADER, 'token'],
-				[PaginatePlugin::PAGINATE_TOTAL_HEADER, '3'],
-			],
-		);
-
-		$this->plugin->onMultiStatus($fileProperties);
-
-		self::assertInstanceOf(\Iterator::class, $fileProperties);
-		// the iterator should be replaced with one that has the amount of
-		// items for the page
-		$items = iterator_to_array($fileProperties, false);
-		$this->assertCount(2, $items);
-	}
-
-	private function initializePlugin(): void {
-		$this->expectSequentialCalls(
-			$this->server,
-			'on',
-			[
-				['beforeMultiStatus', [$this->plugin, 'onMultiStatus'], 100],
-				['method:SEARCH', [$this->plugin, 'onMethod'], 1],
-				['method:PROPFIND', [$this->plugin, 'onMethod'], 1],
-				['method:REPORT', [$this->plugin, 'onMethod'], 1],
-			],
-		);
-
-		$this->plugin->initialize($this->server);
-	}
-
-	/**
-	 * @param array<int, array<int, mixed>> $expectedCalls
-	 */
-	private function expectSequentialCalls(MockObject $mock, string $method, array $expectedCalls): void {
-		$mock->expects(self::exactly(\count($expectedCalls)))
-			->method($method)
-			->willReturnCallback(function (...$args) use (&$expectedCalls): void {
-				$expected = array_shift($expectedCalls);
-				self::assertNotNull($expected);
-				self::assertSame($expected, $args);
-			});
-	}
-
-	private function getResponseXmlForFile(string $fileName, string $displayName): string {
-		return preg_replace('/>\s+</', '><', <<<XML
+    private PaginateCache&MockObject $cache;
+    private PaginatePlugin $plugin;
+    private Server&MockObject $server;
+    private RequestInterface&MockObject $request;
+    private ResponseInterface&MockObject $response;
+
+    public function testOnMultiStatusCachesAndUpdatesResponse(): void {
+        $this->initializePlugin();
+
+        $fileProperties = [
+            [
+                'href' => '/file1',
+                200 => [
+                    '{DAV:}displayname' => 'File 1',
+                    '{DAV:}resourcetype' => null
+                ],
+            ],
+            [
+                'href' => '/file2',
+                200 => [
+                    '{DAV:}displayname' => 'File 2',
+                    '{DAV:}resourcetype' => null
+                ],
+            ],
+            [
+                'href' => '/file3',
+                200 => [
+                    '{DAV:}displayname' => 'File 3',
+                    '{DAV:}resourcetype' => null
+                ],
+            ],
+        ];
+
+        $this->request->expects(self::exactly(2))
+            ->method('hasHeader')
+            ->willReturnMap([
+                [PaginatePlugin::PAGINATE_HEADER, true],
+                [PaginatePlugin::PAGINATE_TOKEN_HEADER, false],
+            ]);
+
+        $this->request->expects(self::once())
+            ->method('getUrl')
+            ->willReturn('url');
+
+        $this->request->expects(self::exactly(2))
+            ->method('getHeader')
+            ->willReturnMap([
+                [PaginatePlugin::PAGINATE_COUNT_HEADER, 2],
+                [PaginatePlugin::PAGINATE_OFFSET_HEADER, 0],
+            ]);
+
+        $this->request->expects(self::once())
+            ->method('setHeader')
+            ->with(PaginatePlugin::PAGINATE_TOKEN_HEADER, 'token');
+
+        $this->cache->expects(self::once())
+            ->method('store')
+            ->with(
+                'url',
+                $this->callback(function ($generator) {
+                    self::assertInstanceOf(\Generator::class, $generator);
+                    $items = iterator_to_array($generator);
+                    self::assertCount(3, $items);
+                    self::assertStringContainsString($this->getResponseXmlForFile('/dav/file1', 'File 1'), $items[0]);
+                    self::assertStringContainsString($this->getResponseXmlForFile('/dav/file2', 'File 2'), $items[1]);
+                    self::assertStringContainsString($this->getResponseXmlForFile('/dav/file3', 'File 3'), $items[2]);
+                    return true;
+                }),
+            )
+            ->willReturn([
+                'token' => 'token',
+                'count' => 3,
+            ]);
+
+        $this->expectSequentialCalls(
+            $this->response,
+            'addHeader',
+            [
+                [PaginatePlugin::PAGINATE_HEADER, 'true'],
+                [PaginatePlugin::PAGINATE_TOKEN_HEADER, 'token'],
+                [PaginatePlugin::PAGINATE_TOTAL_HEADER, '3'],
+            ],
+        );
+
+        $this->plugin->onMultiStatus($fileProperties);
+
+        self::assertInstanceOf(\Iterator::class, $fileProperties);
+        // the iterator should be replaced with one that has the amount of
+        // items for the page
+        $items = iterator_to_array($fileProperties, false);
+        $this->assertCount(2, $items);
+    }
+
+    private function initializePlugin(): void {
+        $this->expectSequentialCalls(
+            $this->server,
+            'on',
+            [
+                ['beforeMultiStatus', [$this->plugin, 'onMultiStatus'], 100],
+                ['method:SEARCH', [$this->plugin, 'onMethod'], 1],
+                ['method:PROPFIND', [$this->plugin, 'onMethod'], 1],
+                ['method:REPORT', [$this->plugin, 'onMethod'], 1],
+            ],
+        );
+
+        $this->plugin->initialize($this->server);
+    }
+
+    /**
+     * @param array<int, array<int, mixed>> $expectedCalls
+     */
+    private function expectSequentialCalls(MockObject $mock, string $method, array $expectedCalls): void {
+        $mock->expects(self::exactly(\count($expectedCalls)))
+            ->method($method)
+            ->willReturnCallback(function (...$args) use (&$expectedCalls): void {
+                $expected = array_shift($expectedCalls);
+                self::assertNotNull($expected);
+                self::assertSame($expected, $args);
+            });
+    }
+
+    private function getResponseXmlForFile(string $fileName, string $displayName): string {
+        return preg_replace('/>\s+</', '><', <<<XML
 			<d:response>
 				<d:href>$fileName</d:href>
 				<d:propstat>
@@ -154,184 +154,184 @@ 
 				</d:propstat>
 			</d:response>
 			XML
-		);
-	}
-
-	public function testOnMultiStatusSkipsWhenHeadersAndCacheExist(): void {
-		$this->initializePlugin();
-
-		$fileProperties = [
-			[
-				'href' => '/file1',
-			],
-			[
-				'href' => '/file2',
-			],
-		];
-
-		$this->request->expects(self::exactly(2))
-			->method('hasHeader')
-			->willReturnMap([
-				[PaginatePlugin::PAGINATE_HEADER, true],
-				[PaginatePlugin::PAGINATE_TOKEN_HEADER, true],
-			]);
-
-		$this->request->expects(self::once())
-			->method('getUrl')
-			->willReturn('');
-
-		$this->request->expects(self::once())
-			->method('getHeader')
-			->with(PaginatePlugin::PAGINATE_TOKEN_HEADER)
-			->willReturn('token');
-
-		$this->cache->expects(self::once())
-			->method('exists')
-			->with('', 'token')
-			->willReturn(true);
-
-		$this->cache->expects(self::never())
-			->method('store');
-
-		$this->plugin->onMultiStatus($fileProperties);
-
-		self::assertInstanceOf(\Iterator::class, $fileProperties);
-		self::assertSame(
-			[
-				['href' => '/file1'],
-				['href' => '/file2'],
-			],
-			iterator_to_array($fileProperties)
-		);
-	}
-
-	public function testOnMethodReturnsCachedResponse(): void {
-		$this->initializePlugin();
-
-		$response = $this->createMock(ResponseInterface::class);
-
-		$this->request->expects(self::exactly(2))
-			->method('hasHeader')
-			->willReturnMap([
-				[PaginatePlugin::PAGINATE_TOKEN_HEADER, true],
-				[PaginatePlugin::PAGINATE_OFFSET_HEADER, true],
-			]);
-
-		$this->request->expects(self::once())
-			->method('getUrl')
-			->willReturn('url');
-
-		$this->request->expects(self::exactly(4))
-			->method('getHeader')
-			->willReturnMap([
-				[PaginatePlugin::PAGINATE_TOKEN_HEADER, 'token'],
-				[PaginatePlugin::PAGINATE_OFFSET_HEADER, '2'],
-				[PaginatePlugin::PAGINATE_COUNT_HEADER, '4'],
-			]);
-
-		$this->cache->expects(self::once())
-			->method('exists')
-			->with('url', 'token')
-			->willReturn(true);
-
-		$this->cache->expects(self::once())
-			->method('get')
-			->with('url', 'token', 2, 4)
-			->willReturn((function (): \Generator {
-				yield $this->getResponseXmlForFile('/file1', 'File 1');
-				yield $this->getResponseXmlForFile('/file2', 'File 2');
-			})());
-
-		$response->expects(self::once())
-			->method('setStatus')
-			->with(207);
-
-		$response->expects(self::once())
-			->method('addHeader')
-			->with(PaginatePlugin::PAGINATE_HEADER, 'true');
-
-		$this->expectSequentialCalls(
-			$response,
-			'setHeader',
-			[
-				['Content-Type', 'application/xml; charset=utf-8'],
-				['Vary', 'Brief,Prefer'],
-			],
-		);
-
-		$response->expects(self::once())
-			->method('setBody')
-			->with($this->callback(function (string $body) {
-				// header of the XML
-				self::assertStringContainsString(<<<XML
+        );
+    }
+
+    public function testOnMultiStatusSkipsWhenHeadersAndCacheExist(): void {
+        $this->initializePlugin();
+
+        $fileProperties = [
+            [
+                'href' => '/file1',
+            ],
+            [
+                'href' => '/file2',
+            ],
+        ];
+
+        $this->request->expects(self::exactly(2))
+            ->method('hasHeader')
+            ->willReturnMap([
+                [PaginatePlugin::PAGINATE_HEADER, true],
+                [PaginatePlugin::PAGINATE_TOKEN_HEADER, true],
+            ]);
+
+        $this->request->expects(self::once())
+            ->method('getUrl')
+            ->willReturn('');
+
+        $this->request->expects(self::once())
+            ->method('getHeader')
+            ->with(PaginatePlugin::PAGINATE_TOKEN_HEADER)
+            ->willReturn('token');
+
+        $this->cache->expects(self::once())
+            ->method('exists')
+            ->with('', 'token')
+            ->willReturn(true);
+
+        $this->cache->expects(self::never())
+            ->method('store');
+
+        $this->plugin->onMultiStatus($fileProperties);
+
+        self::assertInstanceOf(\Iterator::class, $fileProperties);
+        self::assertSame(
+            [
+                ['href' => '/file1'],
+                ['href' => '/file2'],
+            ],
+            iterator_to_array($fileProperties)
+        );
+    }
+
+    public function testOnMethodReturnsCachedResponse(): void {
+        $this->initializePlugin();
+
+        $response = $this->createMock(ResponseInterface::class);
+
+        $this->request->expects(self::exactly(2))
+            ->method('hasHeader')
+            ->willReturnMap([
+                [PaginatePlugin::PAGINATE_TOKEN_HEADER, true],
+                [PaginatePlugin::PAGINATE_OFFSET_HEADER, true],
+            ]);
+
+        $this->request->expects(self::once())
+            ->method('getUrl')
+            ->willReturn('url');
+
+        $this->request->expects(self::exactly(4))
+            ->method('getHeader')
+            ->willReturnMap([
+                [PaginatePlugin::PAGINATE_TOKEN_HEADER, 'token'],
+                [PaginatePlugin::PAGINATE_OFFSET_HEADER, '2'],
+                [PaginatePlugin::PAGINATE_COUNT_HEADER, '4'],
+            ]);
+
+        $this->cache->expects(self::once())
+            ->method('exists')
+            ->with('url', 'token')
+            ->willReturn(true);
+
+        $this->cache->expects(self::once())
+            ->method('get')
+            ->with('url', 'token', 2, 4)
+            ->willReturn((function (): \Generator {
+                yield $this->getResponseXmlForFile('/file1', 'File 1');
+                yield $this->getResponseXmlForFile('/file2', 'File 2');
+            })());
+
+        $response->expects(self::once())
+            ->method('setStatus')
+            ->with(207);
+
+        $response->expects(self::once())
+            ->method('addHeader')
+            ->with(PaginatePlugin::PAGINATE_HEADER, 'true');
+
+        $this->expectSequentialCalls(
+            $response,
+            'setHeader',
+            [
+                ['Content-Type', 'application/xml; charset=utf-8'],
+                ['Vary', 'Brief,Prefer'],
+            ],
+        );
+
+        $response->expects(self::once())
+            ->method('setBody')
+            ->with($this->callback(function (string $body) {
+                // header of the XML
+                self::assertStringContainsString(<<<XML
 					<?xml version="1.0"?>
 					<d:multistatus xmlns:d="DAV:">
 					XML,
-					$body);
-				self::assertStringContainsString($this->getResponseXmlForFile('/file1', 'File 1'), $body);
-				self::assertStringContainsString($this->getResponseXmlForFile('/file2', 'File 2'), $body);
-				// footer of the XML
-				self::assertStringContainsString('</d:multistatus>', $body);
+                    $body);
+                self::assertStringContainsString($this->getResponseXmlForFile('/file1', 'File 1'), $body);
+                self::assertStringContainsString($this->getResponseXmlForFile('/file2', 'File 2'), $body);
+                // footer of the XML
+                self::assertStringContainsString('</d:multistatus>', $body);
 
-				return true;
-			}));
+                return true;
+            }));
 
-		self::assertFalse($this->plugin->onMethod($this->request, $response));
-	}
+        self::assertFalse($this->plugin->onMethod($this->request, $response));
+    }
 
-	public function testOnMultiStatusNoPaginateHeaderShouldSucceed(): void {
-		$this->initializePlugin();
+    public function testOnMultiStatusNoPaginateHeaderShouldSucceed(): void {
+        $this->initializePlugin();
 
-		$this->request->expects(self::once())
-			->method('getUrl')
-			->willReturn('');
+        $this->request->expects(self::once())
+            ->method('getUrl')
+            ->willReturn('');
 
-		$this->cache->expects(self::never())
-			->method('exists');
-		$this->cache->expects(self::never())
-			->method('store');
+        $this->cache->expects(self::never())
+            ->method('exists');
+        $this->cache->expects(self::never())
+            ->method('store');
 
-		$this->plugin->onMultiStatus($this->request);
-	}
+        $this->plugin->onMultiStatus($this->request);
+    }
 
-	public function testOnMethodNoTokenHeaderShouldSucceed(): void {
-		$this->initializePlugin();
-		$this->request->expects(self::once())
-			->method('hasHeader')
-			->with(PaginatePlugin::PAGINATE_TOKEN_HEADER)
-			->willReturn(false);
+    public function testOnMethodNoTokenHeaderShouldSucceed(): void {
+        $this->initializePlugin();
+        $this->request->expects(self::once())
+            ->method('hasHeader')
+            ->with(PaginatePlugin::PAGINATE_TOKEN_HEADER)
+            ->willReturn(false);
 
-		$this->cache->expects(self::never())
-			->method('exists');
-		$this->cache->expects(self::never())
-			->method('get');
+        $this->cache->expects(self::never())
+            ->method('exists');
+        $this->cache->expects(self::never())
+            ->method('get');
 
-		$this->plugin->onMethod($this->request, $this->response);
-	}
+        $this->plugin->onMethod($this->request, $this->response);
+    }
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->cache = $this->createMock(PaginateCache::class);
+        $this->cache = $this->createMock(PaginateCache::class);
 
-		$this->server = $this->getMockBuilder(Server::class)
-			->disableOriginalConstructor()
-			->onlyMethods(['on', 'getHTTPPrefer', 'getBaseUri'])
-			->getMock();
+        $this->server = $this->getMockBuilder(Server::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods(['on', 'getHTTPPrefer', 'getBaseUri'])
+            ->getMock();
 
-		$this->request = $this->createMock(RequestInterface::class);
-		$this->response = $this->createMock(ResponseInterface::class);
+        $this->request = $this->createMock(RequestInterface::class);
+        $this->response = $this->createMock(ResponseInterface::class);
 
-		$this->server->httpRequest = $this->request;
-		$this->server->httpResponse = $this->response;
-		$this->server->xml = new Service();
-		$this->server->xml->namespaceMap = [ 'DAV:' => 'd' ];
+        $this->server->httpRequest = $this->request;
+        $this->server->httpResponse = $this->response;
+        $this->server->xml = new Service();
+        $this->server->xml->namespaceMap = [ 'DAV:' => 'd' ];
 
-		$this->server->method('getHTTPPrefer')
-			->willReturn(['return' => null]);
-		$this->server->method('getBaseUri')
-			->willReturn('/dav/');
+        $this->server->method('getHTTPPrefer')
+            ->willReturn(['return' => null]);
+        $this->server->method('getBaseUri')
+            ->willReturn('/dav/');
 
-		$this->plugin = new PaginatePlugin($this->cache, 2);
-	}
+        $this->plugin = new PaginatePlugin($this->cache, 2);
+    }
 }

Spacing +5 added lines, -5 removed lines

@@ -79,7 +79,7 @@ 
 			->method('store')
 			->with(
 				'url',
-				$this->callback(function ($generator) {
+				$this->callback(function($generator) {
 					self::assertInstanceOf(\Generator::class, $generator);
 					$items = iterator_to_array($generator);
 					self::assertCount(3, $items);
@@ -134,7 +134,7 @@ 
 	private function expectSequentialCalls(MockObject $mock, string $method, array $expectedCalls): void {
 		$mock->expects(self::exactly(\count($expectedCalls)))
 			->method($method)
-			->willReturnCallback(function (...$args) use (&$expectedCalls): void {
+			->willReturnCallback(function(...$args) use (&$expectedCalls): void {
 				$expected = array_shift($expectedCalls);
 				self::assertNotNull($expected);
 				self::assertSame($expected, $args);
@@ -237,7 +237,7 @@ 
 		$this->cache->expects(self::once())
 			->method('get')
 			->with('url', 'token', 2, 4)
-			->willReturn((function (): \Generator {
+			->willReturn((function(): \Generator {
 				yield $this->getResponseXmlForFile('/file1', 'File 1');
 				yield $this->getResponseXmlForFile('/file2', 'File 2');
 			})());
@@ -261,7 +261,7 @@ 
 
 		$response->expects(self::once())
 			->method('setBody')
-			->with($this->callback(function (string $body) {
+			->with($this->callback(function(string $body) {
 				// header of the XML
 				self::assertStringContainsString(<<<XML
 					<?xml version="1.0"?>
@@ -325,7 +325,7 @@ 
 		$this->server->httpRequest = $this->request;
 		$this->server->httpResponse = $this->response;
 		$this->server->xml = new Service();
-		$this->server->xml->namespaceMap = [ 'DAV:' => 'd' ];
+		$this->server->xml->namespaceMap = ['DAV:' => 'd'];
 
 		$this->server->method('getHTTPPrefer')
 			->willReturn(['return' => null]);

apps/dav/tests/unit/Command/RemoveInvalidSharesTest.php

Indentation +114 added lines, -114 removed lines

@@ -26,118 +26,118 @@
  */
 #[\PHPUnit\Framework\Attributes\Group('DB')]
 class RemoveInvalidSharesTest extends TestCase {
-	private RemoveInvalidShares $command;
-
-	private IDBConnection $db;
-	private Principal&MockObject $principalBackend;
-	private RemoteUserPrincipalBackend&MockObject $remoteUserPrincipalBackend;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->db = Server::get(IDBConnection::class);
-		$this->principalBackend = $this->createMock(Principal::class);
-		$this->remoteUserPrincipalBackend = $this->createMock(RemoteUserPrincipalBackend::class);
-
-		$this->db->insertIfNotExist('*PREFIX*dav_shares', [
-			'principaluri' => 'principal:unknown',
-			'type' => 'calendar',
-			'access' => 2,
-			'resourceid' => 666,
-		]);
-		$this->db->insertIfNotExist('*PREFIX*dav_shares', [
-			'principaluri' => 'principals/remote-users/foobar',
-			'type' => 'calendar',
-			'access' => 2,
-			'resourceid' => 666,
-		]);
-
-		$this->command = new RemoveInvalidShares(
-			$this->db,
-			$this->principalBackend,
-			$this->remoteUserPrincipalBackend,
-		);
-	}
-
-	private function selectShares(): array {
-		$query = $this->db->getQueryBuilder();
-		$query->select('*')
-			->from('dav_shares')
-			->where($query->expr()->in(
-				'principaluri',
-				$query->createNamedParameter(
-					['principal:unknown', 'principals/remote-users/foobar'],
-					IQueryBuilder::PARAM_STR_ARRAY,
-				),
-			));
-		$result = $query->executeQuery();
-		$data = $result->fetchAllAssociative();
-		$result->closeCursor();
-
-		return $data;
-	}
-
-	public function testWithoutPrincipals(): void {
-		$this->principalBackend->method('getPrincipalByPath')
-			->willReturnMap([
-				['principal:unknown', null],
-				['principals/remote-users/foobar', null],
-			]);
-		$this->remoteUserPrincipalBackend->method('getPrincipalByPath')
-			->willReturnMap([
-				['principal:unknown', null],
-				['principals/remote-users/foobar', null],
-			]);
-
-		$this->command->run(
-			$this->createMock(InputInterface::class),
-			$this->createMock(OutputInterface::class),
-		);
-
-		$data = $this->selectShares();
-		$this->assertCount(0, $data);
-	}
-
-	public function testWithLocalPrincipal(): void {
-		$this->principalBackend->method('getPrincipalByPath')
-			->willReturnMap([
-				['principal:unknown', ['uri' => 'principal:unknown']],
-				['principals/remote-users/foobar', null],
-			]);
-		$this->remoteUserPrincipalBackend->method('getPrincipalByPath')
-			->willReturnMap([
-				['principals/remote-users/foobar', null],
-			]);
-
-		$this->command->run(
-			$this->createMock(InputInterface::class),
-			$this->createMock(OutputInterface::class),
-		);
-
-		$data = $this->selectShares();
-		$this->assertCount(1, $data);
-		$this->assertEquals('principal:unknown', $data[0]['principaluri']);
-	}
-
-	public function testWithRemotePrincipal() {
-		$this->principalBackend->method('getPrincipalByPath')
-			->willReturnMap([
-				['principal:unknown', null],
-				['principals/remote-users/foobar', null],
-			]);
-		$this->remoteUserPrincipalBackend->method('getPrincipalByPath')
-			->willReturnMap([
-				['principal:unknown', null],
-				['principals/remote-users/foobar', ['uri' => 'principals/remote-users/foobar']],
-			]);
-
-		$this->command->run(
-			$this->createMock(InputInterface::class),
-			$this->createMock(OutputInterface::class),
-		);
-
-		$data = $this->selectShares();
-		$this->assertCount(1, $data);
-		$this->assertEquals('principals/remote-users/foobar', $data[0]['principaluri']);
-	}
+    private RemoveInvalidShares $command;
+
+    private IDBConnection $db;
+    private Principal&MockObject $principalBackend;
+    private RemoteUserPrincipalBackend&MockObject $remoteUserPrincipalBackend;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->db = Server::get(IDBConnection::class);
+        $this->principalBackend = $this->createMock(Principal::class);
+        $this->remoteUserPrincipalBackend = $this->createMock(RemoteUserPrincipalBackend::class);
+
+        $this->db->insertIfNotExist('*PREFIX*dav_shares', [
+            'principaluri' => 'principal:unknown',
+            'type' => 'calendar',
+            'access' => 2,
+            'resourceid' => 666,
+        ]);
+        $this->db->insertIfNotExist('*PREFIX*dav_shares', [
+            'principaluri' => 'principals/remote-users/foobar',
+            'type' => 'calendar',
+            'access' => 2,
+            'resourceid' => 666,
+        ]);
+
+        $this->command = new RemoveInvalidShares(
+            $this->db,
+            $this->principalBackend,
+            $this->remoteUserPrincipalBackend,
+        );
+    }
+
+    private function selectShares(): array {
+        $query = $this->db->getQueryBuilder();
+        $query->select('*')
+            ->from('dav_shares')
+            ->where($query->expr()->in(
+                'principaluri',
+                $query->createNamedParameter(
+                    ['principal:unknown', 'principals/remote-users/foobar'],
+                    IQueryBuilder::PARAM_STR_ARRAY,
+                ),
+            ));
+        $result = $query->executeQuery();
+        $data = $result->fetchAllAssociative();
+        $result->closeCursor();
+
+        return $data;
+    }
+
+    public function testWithoutPrincipals(): void {
+        $this->principalBackend->method('getPrincipalByPath')
+            ->willReturnMap([
+                ['principal:unknown', null],
+                ['principals/remote-users/foobar', null],
+            ]);
+        $this->remoteUserPrincipalBackend->method('getPrincipalByPath')
+            ->willReturnMap([
+                ['principal:unknown', null],
+                ['principals/remote-users/foobar', null],
+            ]);
+
+        $this->command->run(
+            $this->createMock(InputInterface::class),
+            $this->createMock(OutputInterface::class),
+        );
+
+        $data = $this->selectShares();
+        $this->assertCount(0, $data);
+    }
+
+    public function testWithLocalPrincipal(): void {
+        $this->principalBackend->method('getPrincipalByPath')
+            ->willReturnMap([
+                ['principal:unknown', ['uri' => 'principal:unknown']],
+                ['principals/remote-users/foobar', null],
+            ]);
+        $this->remoteUserPrincipalBackend->method('getPrincipalByPath')
+            ->willReturnMap([
+                ['principals/remote-users/foobar', null],
+            ]);
+
+        $this->command->run(
+            $this->createMock(InputInterface::class),
+            $this->createMock(OutputInterface::class),
+        );
+
+        $data = $this->selectShares();
+        $this->assertCount(1, $data);
+        $this->assertEquals('principal:unknown', $data[0]['principaluri']);
+    }
+
+    public function testWithRemotePrincipal() {
+        $this->principalBackend->method('getPrincipalByPath')
+            ->willReturnMap([
+                ['principal:unknown', null],
+                ['principals/remote-users/foobar', null],
+            ]);
+        $this->remoteUserPrincipalBackend->method('getPrincipalByPath')
+            ->willReturnMap([
+                ['principal:unknown', null],
+                ['principals/remote-users/foobar', ['uri' => 'principals/remote-users/foobar']],
+            ]);
+
+        $this->command->run(
+            $this->createMock(InputInterface::class),
+            $this->createMock(OutputInterface::class),
+        );
+
+        $data = $this->selectShares();
+        $this->assertCount(1, $data);
+        $this->assertEquals('principals/remote-users/foobar', $data[0]['principaluri']);
+    }
 }

apps/dav/tests/unit/Migration/RefreshWebcalJobRegistrarTest.php

Indentation +97 added lines, -97 removed lines

@@ -18,101 +18,101 @@
 use Test\TestCase;
 
 class RefreshWebcalJobRegistrarTest extends TestCase {
-	private IDBConnection&MockObject $db;
-	private IJobList&MockObject $jobList;
-	private RefreshWebcalJobRegistrar $migration;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->db = $this->createMock(IDBConnection::class);
-		$this->jobList = $this->createMock(IJobList::class);
-
-		$this->migration = new RefreshWebcalJobRegistrar($this->db, $this->jobList);
-	}
-
-	public function testGetName(): void {
-		$this->assertEquals($this->migration->getName(), 'Registering background jobs to update cache for webcal calendars');
-	}
-
-	public function testRun(): void {
-		$output = $this->createMock(IOutput::class);
-
-		$queryBuilder = $this->createMock(IQueryBuilder::class);
-		$statement = $this->createMock(IResult::class);
-
-		$this->db->expects($this->once())
-			->method('getQueryBuilder')
-			->willReturn($queryBuilder);
-
-		$queryBuilder->expects($this->once())
-			->method('select')
-			->with(['principaluri', 'uri'])
-			->willReturn($queryBuilder);
-		$queryBuilder->expects($this->once())
-			->method('from')
-			->with('calendarsubscriptions')
-			->willReturn($queryBuilder);
-		$queryBuilder->expects($this->once())
-			->method('executeQuery')
-			->willReturn($statement);
-
-		$statement->expects($this->exactly(4))
-			->method('fetchAssociative')
-			->willReturnOnConsecutiveCalls(
-				[
-					'principaluri' => 'foo1',
-					'uri' => 'bar1',
-				],
-				[
-					'principaluri' => 'foo2',
-					'uri' => 'bar2',
-				],
-				[
-					'principaluri' => 'foo3',
-					'uri' => 'bar3',
-				],
-				false,
-			);
-
-		$this->jobList->expects($this->exactly(3))
-			->method('has')
-			->willReturnMap([
-				[RefreshWebcalJob::class, [
-					'principaluri' => 'foo1',
-					'uri' => 'bar1',
-				], false],
-				[RefreshWebcalJob::class, [
-					'principaluri' => 'foo2',
-					'uri' => 'bar2',
-				], true ],
-				[RefreshWebcalJob::class, [
-					'principaluri' => 'foo3',
-					'uri' => 'bar3',
-				], false],
-			]);
-
-		$calls = [
-			[RefreshWebcalJob::class, [
-				'principaluri' => 'foo1',
-				'uri' => 'bar1',
-			]],
-			[RefreshWebcalJob::class, [
-				'principaluri' => 'foo3',
-				'uri' => 'bar3',
-			]]
-		];
-		$this->jobList->expects($this->exactly(2))
-			->method('add')
-			->willReturnCallback(function () use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-
-		$output->expects($this->once())
-			->method('info')
-			->with('Added 2 background jobs to update webcal calendars');
-
-		$this->migration->run($output);
-	}
+    private IDBConnection&MockObject $db;
+    private IJobList&MockObject $jobList;
+    private RefreshWebcalJobRegistrar $migration;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->db = $this->createMock(IDBConnection::class);
+        $this->jobList = $this->createMock(IJobList::class);
+
+        $this->migration = new RefreshWebcalJobRegistrar($this->db, $this->jobList);
+    }
+
+    public function testGetName(): void {
+        $this->assertEquals($this->migration->getName(), 'Registering background jobs to update cache for webcal calendars');
+    }
+
+    public function testRun(): void {
+        $output = $this->createMock(IOutput::class);
+
+        $queryBuilder = $this->createMock(IQueryBuilder::class);
+        $statement = $this->createMock(IResult::class);
+
+        $this->db->expects($this->once())
+            ->method('getQueryBuilder')
+            ->willReturn($queryBuilder);
+
+        $queryBuilder->expects($this->once())
+            ->method('select')
+            ->with(['principaluri', 'uri'])
+            ->willReturn($queryBuilder);
+        $queryBuilder->expects($this->once())
+            ->method('from')
+            ->with('calendarsubscriptions')
+            ->willReturn($queryBuilder);
+        $queryBuilder->expects($this->once())
+            ->method('executeQuery')
+            ->willReturn($statement);
+
+        $statement->expects($this->exactly(4))
+            ->method('fetchAssociative')
+            ->willReturnOnConsecutiveCalls(
+                [
+                    'principaluri' => 'foo1',
+                    'uri' => 'bar1',
+                ],
+                [
+                    'principaluri' => 'foo2',
+                    'uri' => 'bar2',
+                ],
+                [
+                    'principaluri' => 'foo3',
+                    'uri' => 'bar3',
+                ],
+                false,
+            );
+
+        $this->jobList->expects($this->exactly(3))
+            ->method('has')
+            ->willReturnMap([
+                [RefreshWebcalJob::class, [
+                    'principaluri' => 'foo1',
+                    'uri' => 'bar1',
+                ], false],
+                [RefreshWebcalJob::class, [
+                    'principaluri' => 'foo2',
+                    'uri' => 'bar2',
+                ], true ],
+                [RefreshWebcalJob::class, [
+                    'principaluri' => 'foo3',
+                    'uri' => 'bar3',
+                ], false],
+            ]);
+
+        $calls = [
+            [RefreshWebcalJob::class, [
+                'principaluri' => 'foo1',
+                'uri' => 'bar1',
+            ]],
+            [RefreshWebcalJob::class, [
+                'principaluri' => 'foo3',
+                'uri' => 'bar3',
+            ]]
+        ];
+        $this->jobList->expects($this->exactly(2))
+            ->method('add')
+            ->willReturnCallback(function () use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+
+        $output->expects($this->once())
+            ->method('info')
+            ->with('Added 2 background jobs to update webcal calendars');
+
+        $this->migration->run($output);
+    }
 }

apps/dav/tests/unit/Migration/RemoveDeletedUsersCalendarSubscriptionsTest.php

Indentation +113 added lines, -113 removed lines

@@ -22,119 +22,119 @@
 use Test\TestCase;
 
 class RemoveDeletedUsersCalendarSubscriptionsTest extends TestCase {
-	private IDBConnection&MockObject $dbConnection;
-	private IUserManager&MockObject $userManager;
-	private IOutput&MockObject $output;
-	private RemoveDeletedUsersCalendarSubscriptions $migration;
+    private IDBConnection&MockObject $dbConnection;
+    private IUserManager&MockObject $userManager;
+    private IOutput&MockObject $output;
+    private RemoveDeletedUsersCalendarSubscriptions $migration;
 
 
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->dbConnection = $this->createMock(IDBConnection::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->output = $this->createMock(IOutput::class);
-
-		$this->migration = new RemoveDeletedUsersCalendarSubscriptions($this->dbConnection, $this->userManager);
-	}
-
-	public function testGetName(): void {
-		$this->assertEquals(
-			'Clean up old calendar subscriptions from deleted users that were not cleaned-up',
-			$this->migration->getName()
-		);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataTestRun')]
-	public function testRun(array $subscriptions, array $userExists, int $deletions): void {
-		$qb = $this->createMock(IQueryBuilder::class);
-
-		$qb->method('select')->willReturn($qb);
-
-		$functionBuilder = $this->createMock(IFunctionBuilder::class);
-
-		$qb->method('func')->willReturn($functionBuilder);
-		$functionBuilder->method('count')->willReturn($this->createMock(IQueryFunction::class));
-
-		$qb->method('selectDistinct')
-			->with(['id', 'principaluri'])
-			->willReturn($qb);
-
-		$qb->method('from')
-			->with('calendarsubscriptions')
-			->willReturn($qb);
-
-		$qb->method('setMaxResults')
-			->willReturn($qb);
-
-		$qb->method('setFirstResult')
-			->willReturn($qb);
-
-		$result = $this->createMock(IResult::class);
-
-		$qb->method('executeQuery')
-			->willReturn($result);
-
-		$result->expects($this->once())
-			->method('fetchOne')
-			->willReturn(count($subscriptions));
-
-		$result
-			->method('fetchAssociative')
-			->willReturnOnConsecutiveCalls(...$subscriptions);
-
-		$qb->method('delete')
-			->with('calendarsubscriptions')
-			->willReturn($qb);
-
-		$expr = $this->createMock(IExpressionBuilder::class);
-
-		$qb->method('expr')->willReturn($expr);
-		$qb->method('createNamedParameter')->willReturn($this->createMock(IParameter::class));
-		$qb->method('where')->willReturn($qb);
-		// Only when user exists
-		$qb->expects($this->exactly($deletions))->method('executeStatement');
-
-		$this->dbConnection->method('getQueryBuilder')->willReturn($qb);
-
-
-		$this->output->expects($this->once())->method('startProgress');
-
-		$this->output->expects($subscriptions === [] ? $this->never(): $this->once())->method('advance');
-		if (count($subscriptions)) {
-			$this->userManager->method('userExists')
-				->willReturnCallback(function (string $username) use ($userExists) {
-					return $userExists[$username];
-				});
-		}
-		$this->output->expects($this->once())->method('finishProgress');
-		$this->output->expects($this->once())->method('info')->with(sprintf('%d calendar subscriptions without an user have been cleaned up', $deletions));
-
-		$this->migration->run($this->output);
-	}
-
-	public static function dataTestRun(): array {
-		return [
-			[[], [], 0],
-			[
-				[
-					[
-						'id' => 1,
-						'principaluri' => 'users/principals/foo1',
-					],
-					[
-						'id' => 2,
-						'principaluri' => 'users/principals/bar1',
-					],
-					[
-						'id' => 3,
-						'principaluri' => 'users/principals/bar1',
-					],
-					[],
-				],
-				['foo1' => true, 'bar1' => false],
-				2
-			],
-		];
-	}
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->dbConnection = $this->createMock(IDBConnection::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->output = $this->createMock(IOutput::class);
+
+        $this->migration = new RemoveDeletedUsersCalendarSubscriptions($this->dbConnection, $this->userManager);
+    }
+
+    public function testGetName(): void {
+        $this->assertEquals(
+            'Clean up old calendar subscriptions from deleted users that were not cleaned-up',
+            $this->migration->getName()
+        );
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataTestRun')]
+    public function testRun(array $subscriptions, array $userExists, int $deletions): void {
+        $qb = $this->createMock(IQueryBuilder::class);
+
+        $qb->method('select')->willReturn($qb);
+
+        $functionBuilder = $this->createMock(IFunctionBuilder::class);
+
+        $qb->method('func')->willReturn($functionBuilder);
+        $functionBuilder->method('count')->willReturn($this->createMock(IQueryFunction::class));
+
+        $qb->method('selectDistinct')
+            ->with(['id', 'principaluri'])
+            ->willReturn($qb);
+
+        $qb->method('from')
+            ->with('calendarsubscriptions')
+            ->willReturn($qb);
+
+        $qb->method('setMaxResults')
+            ->willReturn($qb);
+
+        $qb->method('setFirstResult')
+            ->willReturn($qb);
+
+        $result = $this->createMock(IResult::class);
+
+        $qb->method('executeQuery')
+            ->willReturn($result);
+
+        $result->expects($this->once())
+            ->method('fetchOne')
+            ->willReturn(count($subscriptions));
+
+        $result
+            ->method('fetchAssociative')
+            ->willReturnOnConsecutiveCalls(...$subscriptions);
+
+        $qb->method('delete')
+            ->with('calendarsubscriptions')
+            ->willReturn($qb);
+
+        $expr = $this->createMock(IExpressionBuilder::class);
+
+        $qb->method('expr')->willReturn($expr);
+        $qb->method('createNamedParameter')->willReturn($this->createMock(IParameter::class));
+        $qb->method('where')->willReturn($qb);
+        // Only when user exists
+        $qb->expects($this->exactly($deletions))->method('executeStatement');
+
+        $this->dbConnection->method('getQueryBuilder')->willReturn($qb);
+
+
+        $this->output->expects($this->once())->method('startProgress');
+
+        $this->output->expects($subscriptions === [] ? $this->never(): $this->once())->method('advance');
+        if (count($subscriptions)) {
+            $this->userManager->method('userExists')
+                ->willReturnCallback(function (string $username) use ($userExists) {
+                    return $userExists[$username];
+                });
+        }
+        $this->output->expects($this->once())->method('finishProgress');
+        $this->output->expects($this->once())->method('info')->with(sprintf('%d calendar subscriptions without an user have been cleaned up', $deletions));
+
+        $this->migration->run($this->output);
+    }
+
+    public static function dataTestRun(): array {
+        return [
+            [[], [], 0],
+            [
+                [
+                    [
+                        'id' => 1,
+                        'principaluri' => 'users/principals/foo1',
+                    ],
+                    [
+                        'id' => 2,
+                        'principaluri' => 'users/principals/bar1',
+                    ],
+                    [
+                        'id' => 3,
+                        'principaluri' => 'users/principals/bar1',
+                    ],
+                    [],
+                ],
+                ['foo1' => true, 'bar1' => false],
+                2
+            ],
+        ];
+    }
 }

apps/dav/lib/CalDAV/Federation/FederatedCalendarMapper.php

Indentation +188 added lines, -188 removed lines

@@ -18,192 +18,192 @@
 
 /** @template-extends QBMapper<FederatedCalendarEntity>  */
 class FederatedCalendarMapper extends QBMapper {
-	public const TABLE_NAME = 'calendars_federated';
-
-	public function __construct(
-		IDBConnection $db,
-		private readonly ITimeFactory $time,
-	) {
-		parent::__construct($db, self::TABLE_NAME, FederatedCalendarEntity::class);
-	}
-
-	/**
-	 * @throws DoesNotExistException If there is no federated calendar with the given id.
-	 */
-	public function find(int $id): FederatedCalendarEntity {
-		$qb = $this->db->getQueryBuilder();
-		$qb->select('*')
-			->from(self::TABLE_NAME)
-			->where($qb->expr()->eq(
-				'id',
-				$qb->createNamedParameter($id, IQueryBuilder::PARAM_INT),
-				IQueryBuilder::PARAM_INT,
-			));
-		return $this->findEntity($qb);
-	}
-
-	/**
-	 * @return FederatedCalendarEntity[]
-	 */
-	public function findByPrincipalUri(string $principalUri): array {
-		$qb = $this->db->getQueryBuilder();
-		$qb->select('*')
-			->from(self::TABLE_NAME)
-			->where($qb->expr()->eq(
-				'principaluri',
-				$qb->createNamedParameter($principalUri, IQueryBuilder::PARAM_STR),
-				IQueryBuilder::PARAM_STR,
-			));
-		return $this->findEntities($qb);
-	}
-
-	public function findByUri(string $principalUri, string $uri): ?FederatedCalendarEntity {
-		$qb = $this->db->getQueryBuilder();
-		$qb->select('*')
-			->from(self::TABLE_NAME)
-			->where($qb->expr()->eq(
-				'principaluri',
-				$qb->createNamedParameter($principalUri, IQueryBuilder::PARAM_STR),
-				IQueryBuilder::PARAM_STR,
-			))
-			->andWhere($qb->expr()->eq(
-				'uri',
-				$qb->createNamedParameter($uri, IQueryBuilder::PARAM_STR),
-				IQueryBuilder::PARAM_STR,
-			));
-
-		try {
-			return $this->findEntity($qb);
-		} catch (DoesNotExistException $e) {
-			return null;
-		} catch (MultipleObjectsReturnedException $e) {
-			// Should never happen
-			return null;
-		}
-	}
-
-	/**
-	 * @return FederatedCalendarEntity[]
-	 */
-	public function findUnsyncedSinceBefore(int $beforeTimestamp): array {
-		$qb = $this->db->getQueryBuilder();
-		$qb->select('*')
-			->from(self::TABLE_NAME)
-			->where($qb->expr()->lt(
-				'last_sync',
-				$qb->createNamedParameter($beforeTimestamp, IQueryBuilder::PARAM_INT),
-				IQueryBuilder::PARAM_INT,
-			))
-			// Omit unsynced calendars for now as they are synced by a separate job
-			->andWhere($qb->expr()->isNotNull('last_sync'));
-		return $this->findEntities($qb);
-	}
-
-	public function deleteById(int $id): void {
-		$qb = $this->db->getQueryBuilder();
-		$qb->delete(self::TABLE_NAME)
-			->where($qb->expr()->eq(
-				'id',
-				$qb->createNamedParameter($id, IQueryBuilder::PARAM_INT),
-				IQueryBuilder::PARAM_INT,
-			));
-		$qb->executeStatement();
-	}
-
-	public function updateSyncTime(int $id): void {
-		$now = $this->time->getTime();
-
-		$qb = $this->db->getQueryBuilder();
-		$qb->update(self::TABLE_NAME)
-			->set('last_sync', $qb->createNamedParameter($now, IQueryBuilder::PARAM_INT))
-			->where($qb->expr()->eq(
-				'id',
-				$qb->createNamedParameter($id, IQueryBuilder::PARAM_INT),
-				IQueryBuilder::PARAM_INT,
-			));
-		$qb->executeStatement();
-	}
-
-	public function updateSyncTokenAndTime(int $id, int $syncToken): void {
-		$now = $this->time->getTime();
-
-		$qb = $this->db->getQueryBuilder();
-		$qb->update(self::TABLE_NAME)
-			->set('sync_token', $qb->createNamedParameter($syncToken, IQueryBuilder::PARAM_INT))
-			->set('last_sync', $qb->createNamedParameter($now, IQueryBuilder::PARAM_INT))
-			->where($qb->expr()->eq(
-				'id',
-				$qb->createNamedParameter($id, IQueryBuilder::PARAM_INT),
-				IQueryBuilder::PARAM_INT,
-			));
-		$qb->executeStatement();
-	}
-
-	/**
-	 * @return \Generator<mixed, FederatedCalendarEntity>
-	 */
-	public function findAll(): \Generator {
-		$qb = $this->db->getQueryBuilder();
-		$qb->select('*')
-			->from(self::TABLE_NAME);
-
-		$result = $qb->executeQuery();
-		while ($row = $result->fetchAssociative()) {
-			yield $this->mapRowToEntity($row);
-		}
-		$result->closeCursor();
-	}
-
-	public function countAll(): int {
-		$qb = $this->db->getQueryBuilder();
-		$qb->select($qb->func()->count('*'))
-			->from(self::TABLE_NAME);
-		$result = $qb->executeQuery();
-		$count = (int)$result->fetchOne();
-		$result->closeCursor();
-		return $count;
-	}
-
-	public function deleteByUri(string $principalUri, string $uri): void {
-		$qb = $this->db->getQueryBuilder();
-		$qb->delete(self::TABLE_NAME)
-			->where($qb->expr()->eq(
-				'principaluri',
-				$qb->createNamedParameter($principalUri, IQueryBuilder::PARAM_STR),
-				IQueryBuilder::PARAM_STR,
-			))
-			->andWhere($qb->expr()->eq(
-				'uri',
-				$qb->createNamedParameter($uri, IQueryBuilder::PARAM_STR),
-				IQueryBuilder::PARAM_STR,
-			));
-
-		$qb->executeStatement();
-	}
-
-	/**
-	 * @return FederatedCalendarEntity[]
-	 */
-	public function findByRemoteUrl(string $remoteUrl, string $principalUri, string $token): array {
-		$qb = $this->db->getQueryBuilder();
-		$qb->select('*')
-			->from(self::TABLE_NAME)
-			->where($qb->expr()->eq(
-				'remote_url',
-				$qb->createNamedParameter($remoteUrl, IQueryBuilder::PARAM_STR),
-				IQueryBuilder::PARAM_STR,
-			))
-			->andWhere($qb->expr()->eq(
-				'principaluri',
-				$qb->createNamedParameter($principalUri, IQueryBuilder::PARAM_STR),
-				IQueryBuilder::PARAM_STR,
-			))
-			->andWhere($qb->expr()->eq(
-				'token',
-				$qb->createNamedParameter($token, IQueryBuilder::PARAM_STR),
-				IQueryBuilder::PARAM_STR,
-			));
-
-		return $this->findEntities($qb);
-	}
+    public const TABLE_NAME = 'calendars_federated';
+
+    public function __construct(
+        IDBConnection $db,
+        private readonly ITimeFactory $time,
+    ) {
+        parent::__construct($db, self::TABLE_NAME, FederatedCalendarEntity::class);
+    }
+
+    /**
+     * @throws DoesNotExistException If there is no federated calendar with the given id.
+     */
+    public function find(int $id): FederatedCalendarEntity {
+        $qb = $this->db->getQueryBuilder();
+        $qb->select('*')
+            ->from(self::TABLE_NAME)
+            ->where($qb->expr()->eq(
+                'id',
+                $qb->createNamedParameter($id, IQueryBuilder::PARAM_INT),
+                IQueryBuilder::PARAM_INT,
+            ));
+        return $this->findEntity($qb);
+    }
+
+    /**
+     * @return FederatedCalendarEntity[]
+     */
+    public function findByPrincipalUri(string $principalUri): array {
+        $qb = $this->db->getQueryBuilder();
+        $qb->select('*')
+            ->from(self::TABLE_NAME)
+            ->where($qb->expr()->eq(
+                'principaluri',
+                $qb->createNamedParameter($principalUri, IQueryBuilder::PARAM_STR),
+                IQueryBuilder::PARAM_STR,
+            ));
+        return $this->findEntities($qb);
+    }
+
+    public function findByUri(string $principalUri, string $uri): ?FederatedCalendarEntity {
+        $qb = $this->db->getQueryBuilder();
+        $qb->select('*')
+            ->from(self::TABLE_NAME)
+            ->where($qb->expr()->eq(
+                'principaluri',
+                $qb->createNamedParameter($principalUri, IQueryBuilder::PARAM_STR),
+                IQueryBuilder::PARAM_STR,
+            ))
+            ->andWhere($qb->expr()->eq(
+                'uri',
+                $qb->createNamedParameter($uri, IQueryBuilder::PARAM_STR),
+                IQueryBuilder::PARAM_STR,
+            ));
+
+        try {
+            return $this->findEntity($qb);
+        } catch (DoesNotExistException $e) {
+            return null;
+        } catch (MultipleObjectsReturnedException $e) {
+            // Should never happen
+            return null;
+        }
+    }
+
+    /**
+     * @return FederatedCalendarEntity[]
+     */
+    public function findUnsyncedSinceBefore(int $beforeTimestamp): array {
+        $qb = $this->db->getQueryBuilder();
+        $qb->select('*')
+            ->from(self::TABLE_NAME)
+            ->where($qb->expr()->lt(
+                'last_sync',
+                $qb->createNamedParameter($beforeTimestamp, IQueryBuilder::PARAM_INT),
+                IQueryBuilder::PARAM_INT,
+            ))
+            // Omit unsynced calendars for now as they are synced by a separate job
+            ->andWhere($qb->expr()->isNotNull('last_sync'));
+        return $this->findEntities($qb);
+    }
+
+    public function deleteById(int $id): void {
+        $qb = $this->db->getQueryBuilder();
+        $qb->delete(self::TABLE_NAME)
+            ->where($qb->expr()->eq(
+                'id',
+                $qb->createNamedParameter($id, IQueryBuilder::PARAM_INT),
+                IQueryBuilder::PARAM_INT,
+            ));
+        $qb->executeStatement();
+    }
+
+    public function updateSyncTime(int $id): void {
+        $now = $this->time->getTime();
+
+        $qb = $this->db->getQueryBuilder();
+        $qb->update(self::TABLE_NAME)
+            ->set('last_sync', $qb->createNamedParameter($now, IQueryBuilder::PARAM_INT))
+            ->where($qb->expr()->eq(
+                'id',
+                $qb->createNamedParameter($id, IQueryBuilder::PARAM_INT),
+                IQueryBuilder::PARAM_INT,
+            ));
+        $qb->executeStatement();
+    }
+
+    public function updateSyncTokenAndTime(int $id, int $syncToken): void {
+        $now = $this->time->getTime();
+
+        $qb = $this->db->getQueryBuilder();
+        $qb->update(self::TABLE_NAME)
+            ->set('sync_token', $qb->createNamedParameter($syncToken, IQueryBuilder::PARAM_INT))
+            ->set('last_sync', $qb->createNamedParameter($now, IQueryBuilder::PARAM_INT))
+            ->where($qb->expr()->eq(
+                'id',
+                $qb->createNamedParameter($id, IQueryBuilder::PARAM_INT),
+                IQueryBuilder::PARAM_INT,
+            ));
+        $qb->executeStatement();
+    }
+
+    /**
+     * @return \Generator<mixed, FederatedCalendarEntity>
+     */
+    public function findAll(): \Generator {
+        $qb = $this->db->getQueryBuilder();
+        $qb->select('*')
+            ->from(self::TABLE_NAME);
+
+        $result = $qb->executeQuery();
+        while ($row = $result->fetchAssociative()) {
+            yield $this->mapRowToEntity($row);
+        }
+        $result->closeCursor();
+    }
+
+    public function countAll(): int {
+        $qb = $this->db->getQueryBuilder();
+        $qb->select($qb->func()->count('*'))
+            ->from(self::TABLE_NAME);
+        $result = $qb->executeQuery();
+        $count = (int)$result->fetchOne();
+        $result->closeCursor();
+        return $count;
+    }
+
+    public function deleteByUri(string $principalUri, string $uri): void {
+        $qb = $this->db->getQueryBuilder();
+        $qb->delete(self::TABLE_NAME)
+            ->where($qb->expr()->eq(
+                'principaluri',
+                $qb->createNamedParameter($principalUri, IQueryBuilder::PARAM_STR),
+                IQueryBuilder::PARAM_STR,
+            ))
+            ->andWhere($qb->expr()->eq(
+                'uri',
+                $qb->createNamedParameter($uri, IQueryBuilder::PARAM_STR),
+                IQueryBuilder::PARAM_STR,
+            ));
+
+        $qb->executeStatement();
+    }
+
+    /**
+     * @return FederatedCalendarEntity[]
+     */
+    public function findByRemoteUrl(string $remoteUrl, string $principalUri, string $token): array {
+        $qb = $this->db->getQueryBuilder();
+        $qb->select('*')
+            ->from(self::TABLE_NAME)
+            ->where($qb->expr()->eq(
+                'remote_url',
+                $qb->createNamedParameter($remoteUrl, IQueryBuilder::PARAM_STR),
+                IQueryBuilder::PARAM_STR,
+            ))
+            ->andWhere($qb->expr()->eq(
+                'principaluri',
+                $qb->createNamedParameter($principalUri, IQueryBuilder::PARAM_STR),
+                IQueryBuilder::PARAM_STR,
+            ))
+            ->andWhere($qb->expr()->eq(
+                'token',
+                $qb->createNamedParameter($token, IQueryBuilder::PARAM_STR),
+                IQueryBuilder::PARAM_STR,
+            ));
+
+        return $this->findEntities($qb);
+    }
 }