nextcloud / server

tests/lib/Files/Config/UserMountCacheTest.php

Indentation +457 added lines, -457 removed lines

@@ -34,566 +34,566 @@
 
 #[\PHPUnit\Framework\Attributes\Group('DB')]
 class UserMountCacheTest extends TestCase {
-	private IDBConnection $connection;
-	private IUserManager $userManager;
-	private IEventDispatcher $eventDispatcher;
-	private UserMountCache $cache;
-	private array $fileIds = [];
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->fileIds = [];
-
-		$this->connection = Server::get(IDBConnection::class);
-
-		$config = $this->getMockBuilder(IConfig::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$config
-			->expects($this->any())
-			->method('getUserValue')
-			->willReturnArgument(3);
-		$config
-			->expects($this->any())
-			->method('getAppValue')
-			->willReturnArgument(2);
-
-		$this->userManager = new Manager($config, $this->createMock(ICacheFactory::class), $this->createMock(IEventDispatcher::class), $this->createMock(LoggerInterface::class));
-		$userBackend = new Dummy();
-		$userBackend->createUser('u1', '');
-		$userBackend->createUser('u2', '');
-		$userBackend->createUser('u3', '');
-		$this->userManager->registerBackend($userBackend);
-
-		$this->eventDispatcher = $this->createMock(IEventDispatcher::class);
+    private IDBConnection $connection;
+    private IUserManager $userManager;
+    private IEventDispatcher $eventDispatcher;
+    private UserMountCache $cache;
+    private array $fileIds = [];
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->fileIds = [];
+
+        $this->connection = Server::get(IDBConnection::class);
+
+        $config = $this->getMockBuilder(IConfig::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $config
+            ->expects($this->any())
+            ->method('getUserValue')
+            ->willReturnArgument(3);
+        $config
+            ->expects($this->any())
+            ->method('getAppValue')
+            ->willReturnArgument(2);
+
+        $this->userManager = new Manager($config, $this->createMock(ICacheFactory::class), $this->createMock(IEventDispatcher::class), $this->createMock(LoggerInterface::class));
+        $userBackend = new Dummy();
+        $userBackend->createUser('u1', '');
+        $userBackend->createUser('u2', '');
+        $userBackend->createUser('u3', '');
+        $this->userManager->registerBackend($userBackend);
+
+        $this->eventDispatcher = $this->createMock(IEventDispatcher::class);
 
-		$this->cache = new UserMountCache($this->connection,
-			$this->userManager,
-			$this->createMock(LoggerInterface::class),
-			$this->createMock(IEventLogger::class),
-			$this->eventDispatcher,
-		);
-	}
-
-	protected function tearDown(): void {
-		$builder = $this->connection->getQueryBuilder();
-
-		$builder->delete('mounts')->executeStatement();
-
-		$builder = $this->connection->getQueryBuilder();
-
-		foreach ($this->fileIds as $fileId) {
-			$builder->delete('filecache')
-				->where($builder->expr()->eq('fileid', new Literal($fileId)))
-				->executeStatement();
-		}
-	}
-
-	private function getStorage($storageId, $rootInternalPath = '') {
-		$rootId = $this->createCacheEntry($rootInternalPath, $storageId);
-
-		$storageCache = $this->createMock(\OC\Files\Cache\Storage::class);
-		$storageCache->expects($this->any())
-			->method('getNumericId')
-			->willReturn($storageId);
-
-		$cache = $this->createMock(Cache::class);
-		$cache->expects($this->any())
-			->method('getId')
-			->willReturn($rootId);
-		$cache->method('getNumericStorageId')
-			->willReturn($storageId);
+        $this->cache = new UserMountCache($this->connection,
+            $this->userManager,
+            $this->createMock(LoggerInterface::class),
+            $this->createMock(IEventLogger::class),
+            $this->eventDispatcher,
+        );
+    }
+
+    protected function tearDown(): void {
+        $builder = $this->connection->getQueryBuilder();
+
+        $builder->delete('mounts')->executeStatement();
+
+        $builder = $this->connection->getQueryBuilder();
+
+        foreach ($this->fileIds as $fileId) {
+            $builder->delete('filecache')
+                ->where($builder->expr()->eq('fileid', new Literal($fileId)))
+                ->executeStatement();
+        }
+    }
+
+    private function getStorage($storageId, $rootInternalPath = '') {
+        $rootId = $this->createCacheEntry($rootInternalPath, $storageId);
+
+        $storageCache = $this->createMock(\OC\Files\Cache\Storage::class);
+        $storageCache->expects($this->any())
+            ->method('getNumericId')
+            ->willReturn($storageId);
+
+        $cache = $this->createMock(Cache::class);
+        $cache->expects($this->any())
+            ->method('getId')
+            ->willReturn($rootId);
+        $cache->method('getNumericStorageId')
+            ->willReturn($storageId);
 
-		$storage = $this->createMock(Storage::class);
-		$storage->expects($this->any())
-			->method('getStorageCache')
-			->willReturn($storageCache);
-		$storage->expects($this->any())
-			->method('getCache')
-			->willReturn($cache);
+        $storage = $this->createMock(Storage::class);
+        $storage->expects($this->any())
+            ->method('getStorageCache')
+            ->willReturn($storageCache);
+        $storage->expects($this->any())
+            ->method('getCache')
+            ->willReturn($cache);
 
-		return [$storage, $rootId];
-	}
-
-	private function clearCache() {
-		$this->invokePrivate($this->cache, 'mountsForUsers', [new CappedMemoryCache()]);
-	}
-
-	private function keyForMount(MountPoint $mount): string {
-		return $mount->getStorageRootId() . '::' . $mount->getMountPoint();
-	}
-
-	public function testNewMounts(): void {
-		$this->eventDispatcher
-			->expects($this->once())
-			->method('dispatchTyped')
-			->with($this->callback(fn (UserMountAddedEvent $event) => $event->mountPoint->getMountPoint() === '/asd/'));
-
-		$user = $this->userManager->get('u1');
+        return [$storage, $rootId];
+    }
+
+    private function clearCache() {
+        $this->invokePrivate($this->cache, 'mountsForUsers', [new CappedMemoryCache()]);
+    }
+
+    private function keyForMount(MountPoint $mount): string {
+        return $mount->getStorageRootId() . '::' . $mount->getMountPoint();
+    }
+
+    public function testNewMounts(): void {
+        $this->eventDispatcher
+            ->expects($this->once())
+            ->method('dispatchTyped')
+            ->with($this->callback(fn (UserMountAddedEvent $event) => $event->mountPoint->getMountPoint() === '/asd/'));
+
+        $user = $this->userManager->get('u1');
 
-		[$storage] = $this->getStorage(10);
-		$mount = new MountPoint($storage, '/asd/');
+        [$storage] = $this->getStorage(10);
+        $mount = new MountPoint($storage, '/asd/');
 
-		$this->cache->registerMounts($user, [$mount]);
+        $this->cache->registerMounts($user, [$mount]);
 
-		$this->clearCache();
+        $this->clearCache();
 
-		$cachedMounts = $this->cache->getMountsForUser($user);
+        $cachedMounts = $this->cache->getMountsForUser($user);
 
-		$this->assertCount(1, $cachedMounts);
-		$cachedMount = $cachedMounts[$this->keyForMount($mount)];
-		$this->assertEquals('/asd/', $cachedMount->getMountPoint());
-		$this->assertEquals($user->getUID(), $cachedMount->getUser()->getUID());
-		$this->assertEquals($storage->getCache()->getId(''), $cachedMount->getRootId());
-		$this->assertEquals($storage->getStorageCache()->getNumericId(), $cachedMount->getStorageId());
-	}
+        $this->assertCount(1, $cachedMounts);
+        $cachedMount = $cachedMounts[$this->keyForMount($mount)];
+        $this->assertEquals('/asd/', $cachedMount->getMountPoint());
+        $this->assertEquals($user->getUID(), $cachedMount->getUser()->getUID());
+        $this->assertEquals($storage->getCache()->getId(''), $cachedMount->getRootId());
+        $this->assertEquals($storage->getStorageCache()->getNumericId(), $cachedMount->getStorageId());
+    }
 
-	public function testSameMounts(): void {
-		$this->eventDispatcher
-			->expects($this->once())
-			->method('dispatchTyped')
-			->with($this->callback(fn (UserMountAddedEvent $event) => $event->mountPoint->getMountPoint() === '/asd/'));
+    public function testSameMounts(): void {
+        $this->eventDispatcher
+            ->expects($this->once())
+            ->method('dispatchTyped')
+            ->with($this->callback(fn (UserMountAddedEvent $event) => $event->mountPoint->getMountPoint() === '/asd/'));
 
-		$user = $this->userManager->get('u1');
+        $user = $this->userManager->get('u1');
 
-		[$storage] = $this->getStorage(10);
-		$mount = new MountPoint($storage, '/asd/');
+        [$storage] = $this->getStorage(10);
+        $mount = new MountPoint($storage, '/asd/');
 
-		$this->cache->registerMounts($user, [$mount]);
+        $this->cache->registerMounts($user, [$mount]);
 
-		$this->clearCache();
+        $this->clearCache();
 
-		$this->cache->registerMounts($user, [$mount]);
+        $this->cache->registerMounts($user, [$mount]);
 
-		$this->clearCache();
+        $this->clearCache();
 
-		$cachedMounts = $this->cache->getMountsForUser($user);
+        $cachedMounts = $this->cache->getMountsForUser($user);
 
-		$this->assertCount(1, $cachedMounts);
-		$cachedMount = $cachedMounts[$this->keyForMount($mount)];
-		$this->assertEquals('/asd/', $cachedMount->getMountPoint());
-		$this->assertEquals($user->getUID(), $cachedMount->getUser()->getUID());
-		$this->assertEquals($storage->getCache()->getId(''), $cachedMount->getRootId());
-		$this->assertEquals($storage->getStorageCache()->getNumericId(), $cachedMount->getStorageId());
-	}
+        $this->assertCount(1, $cachedMounts);
+        $cachedMount = $cachedMounts[$this->keyForMount($mount)];
+        $this->assertEquals('/asd/', $cachedMount->getMountPoint());
+        $this->assertEquals($user->getUID(), $cachedMount->getUser()->getUID());
+        $this->assertEquals($storage->getCache()->getId(''), $cachedMount->getRootId());
+        $this->assertEquals($storage->getStorageCache()->getNumericId(), $cachedMount->getStorageId());
+    }
 
-	public function testRemoveMounts(): void {
-		$operation = 0;
-		$this->eventDispatcher
-			->expects($this->exactly(2))
-			->method('dispatchTyped')
-			->with($this->callback(function (UserMountAddedEvent|UserMountRemovedEvent $event) use (&$operation) {
-				return match(++$operation) {
-					1 => $event instanceof UserMountAddedEvent && $event->mountPoint->getMountPoint() === '/asd/',
-					2 => $event instanceof UserMountRemovedEvent && $event->mountPoint->getMountPoint() === '/asd/',
-					default => false,
-				};
-			}));
+    public function testRemoveMounts(): void {
+        $operation = 0;
+        $this->eventDispatcher
+            ->expects($this->exactly(2))
+            ->method('dispatchTyped')
+            ->with($this->callback(function (UserMountAddedEvent|UserMountRemovedEvent $event) use (&$operation) {
+                return match(++$operation) {
+                    1 => $event instanceof UserMountAddedEvent && $event->mountPoint->getMountPoint() === '/asd/',
+                    2 => $event instanceof UserMountRemovedEvent && $event->mountPoint->getMountPoint() === '/asd/',
+                    default => false,
+                };
+            }));
 
-		$user = $this->userManager->get('u1');
+        $user = $this->userManager->get('u1');
 
-		[$storage] = $this->getStorage(10);
-		$mount = new MountPoint($storage, '/asd/');
+        [$storage] = $this->getStorage(10);
+        $mount = new MountPoint($storage, '/asd/');
 
-		$this->cache->registerMounts($user, [$mount]);
+        $this->cache->registerMounts($user, [$mount]);
 
-		$this->clearCache();
+        $this->clearCache();
 
-		$this->cache->registerMounts($user, []);
+        $this->cache->registerMounts($user, []);
 
-		$this->clearCache();
+        $this->clearCache();
 
-		$cachedMounts = $this->cache->getMountsForUser($user);
+        $cachedMounts = $this->cache->getMountsForUser($user);
 
-		$this->assertCount(0, $cachedMounts);
-	}
+        $this->assertCount(0, $cachedMounts);
+    }
 
-	public function testChangeMounts(): void {
-		$operation = 0;
-		$this->eventDispatcher
-			->expects($this->exactly(3))
-			->method('dispatchTyped')
-			->with($this->callback(function (UserMountAddedEvent|UserMountRemovedEvent $event) use (&$operation) {
-				return match(++$operation) {
-					1 => $event instanceof UserMountAddedEvent && $event->mountPoint->getMountPoint() === '/bar/',
-					2 => $event instanceof UserMountAddedEvent && $event->mountPoint->getMountPoint() === '/foo/',
-					3 => $event instanceof UserMountRemovedEvent && $event->mountPoint->getMountPoint() === '/bar/',
-					default => false,
-				};
-			}));
+    public function testChangeMounts(): void {
+        $operation = 0;
+        $this->eventDispatcher
+            ->expects($this->exactly(3))
+            ->method('dispatchTyped')
+            ->with($this->callback(function (UserMountAddedEvent|UserMountRemovedEvent $event) use (&$operation) {
+                return match(++$operation) {
+                    1 => $event instanceof UserMountAddedEvent && $event->mountPoint->getMountPoint() === '/bar/',
+                    2 => $event instanceof UserMountAddedEvent && $event->mountPoint->getMountPoint() === '/foo/',
+                    3 => $event instanceof UserMountRemovedEvent && $event->mountPoint->getMountPoint() === '/bar/',
+                    default => false,
+                };
+            }));
 
-		$user = $this->userManager->get('u1');
+        $user = $this->userManager->get('u1');
 
-		[$storage] = $this->getStorage(10);
-		$mount = new MountPoint($storage, '/bar/');
+        [$storage] = $this->getStorage(10);
+        $mount = new MountPoint($storage, '/bar/');
 
-		$this->cache->registerMounts($user, [$mount]);
+        $this->cache->registerMounts($user, [$mount]);
 
-		$this->clearCache();
+        $this->clearCache();
 
-		$mount = new MountPoint($storage, '/foo/');
+        $mount = new MountPoint($storage, '/foo/');
 
-		$this->cache->registerMounts($user, [$mount]);
+        $this->cache->registerMounts($user, [$mount]);
 
-		$this->clearCache();
+        $this->clearCache();
 
-		$cachedMounts = $this->cache->getMountsForUser($user);
+        $cachedMounts = $this->cache->getMountsForUser($user);
 
-		$this->assertCount(1, $cachedMounts);
-		$cachedMount = $cachedMounts[$this->keyForMount($mount)];
-		$this->assertEquals('/foo/', $cachedMount->getMountPoint());
-	}
+        $this->assertCount(1, $cachedMounts);
+        $cachedMount = $cachedMounts[$this->keyForMount($mount)];
+        $this->assertEquals('/foo/', $cachedMount->getMountPoint());
+    }
 
-	public function testChangeMountId(): void {
-		$operation = 0;
-		$this->eventDispatcher
-			->expects($this->exactly(2))
-			->method('dispatchTyped')
-			->with($this->callback(function (UserMountAddedEvent|UserMountUpdatedEvent $event) use (&$operation) {
-				return match(++$operation) {
-					1 => $event instanceof UserMountAddedEvent && $event->mountPoint->getMountPoint() === '/foo/',
-					2 => $event instanceof UserMountUpdatedEvent && $event->oldMountPoint->getMountId() === null && $event->newMountPoint->getMountId() === 1,
-					default => false,
-				};
-			}));
+    public function testChangeMountId(): void {
+        $operation = 0;
+        $this->eventDispatcher
+            ->expects($this->exactly(2))
+            ->method('dispatchTyped')
+            ->with($this->callback(function (UserMountAddedEvent|UserMountUpdatedEvent $event) use (&$operation) {
+                return match(++$operation) {
+                    1 => $event instanceof UserMountAddedEvent && $event->mountPoint->getMountPoint() === '/foo/',
+                    2 => $event instanceof UserMountUpdatedEvent && $event->oldMountPoint->getMountId() === null && $event->newMountPoint->getMountId() === 1,
+                    default => false,
+                };
+            }));
 
-		$user = $this->userManager->get('u1');
+        $user = $this->userManager->get('u1');
 
-		[$storage] = $this->getStorage(10);
-		$mount = new MountPoint($storage, '/foo/', null, null, null, null);
+        [$storage] = $this->getStorage(10);
+        $mount = new MountPoint($storage, '/foo/', null, null, null, null);
 
-		$this->cache->registerMounts($user, [$mount]);
+        $this->cache->registerMounts($user, [$mount]);
 
-		$this->clearCache();
+        $this->clearCache();
 
-		$mount = new MountPoint($storage, '/foo/', null, null, null, 1);
+        $mount = new MountPoint($storage, '/foo/', null, null, null, 1);
 
-		$this->cache->registerMounts($user, [$mount]);
+        $this->cache->registerMounts($user, [$mount]);
 
-		$this->clearCache();
+        $this->clearCache();
 
-		$cachedMounts = $this->cache->getMountsForUser($user);
+        $cachedMounts = $this->cache->getMountsForUser($user);
 
-		$this->assertCount(1, $cachedMounts);
-		$cachedMount = $cachedMounts[$this->keyForMount($mount)];
-		$this->assertEquals(1, $cachedMount->getMountId());
-	}
+        $this->assertCount(1, $cachedMounts);
+        $cachedMount = $cachedMounts[$this->keyForMount($mount)];
+        $this->assertEquals(1, $cachedMount->getMountId());
+    }
 
-	public function testGetMountsForUser(): void {
-		$user1 = $this->userManager->get('u1');
-		$user2 = $this->userManager->get('u2');
-		$user3 = $this->userManager->get('u3');
+    public function testGetMountsForUser(): void {
+        $user1 = $this->userManager->get('u1');
+        $user2 = $this->userManager->get('u2');
+        $user3 = $this->userManager->get('u3');
 
-		[$storage1, $id1] = $this->getStorage(1);
-		[$storage2, $id2] = $this->getStorage(2, 'foo/bar');
-		$mount1 = new MountPoint($storage1, '/foo/');
-		$mount2 = new MountPoint($storage2, '/bar/');
+        [$storage1, $id1] = $this->getStorage(1);
+        [$storage2, $id2] = $this->getStorage(2, 'foo/bar');
+        $mount1 = new MountPoint($storage1, '/foo/');
+        $mount2 = new MountPoint($storage2, '/bar/');
 
-		$this->cache->registerMounts($user1, [$mount1, $mount2]);
-		$this->cache->registerMounts($user2, [$mount2]);
-		$this->cache->registerMounts($user3, [$mount2]);
+        $this->cache->registerMounts($user1, [$mount1, $mount2]);
+        $this->cache->registerMounts($user2, [$mount2]);
+        $this->cache->registerMounts($user3, [$mount2]);
 
-		$this->clearCache();
+        $this->clearCache();
 
-		$user3->delete();
+        $user3->delete();
 
-		$cachedMounts = $this->cache->getMountsForUser($user1);
+        $cachedMounts = $this->cache->getMountsForUser($user1);
 
-		$this->assertCount(2, $cachedMounts);
-		$this->assertEquals('/foo/', $cachedMounts[$this->keyForMount($mount1)]->getMountPoint());
-		$this->assertEquals($user1->getUID(), $cachedMounts[$this->keyForMount($mount1)]->getUser()->getUID());
-		$this->assertEquals($id1, $cachedMounts[$this->keyForMount($mount1)]->getRootId());
-		$this->assertEquals(1, $cachedMounts[$this->keyForMount($mount1)]->getStorageId());
-		$this->assertEquals('', $cachedMounts[$this->keyForMount($mount1)]->getRootInternalPath());
-
-		$this->assertEquals('/bar/', $cachedMounts[$this->keyForMount($mount2)]->getMountPoint());
-		$this->assertEquals($user1->getUID(), $cachedMounts[$this->keyForMount($mount2)]->getUser()->getUID());
-		$this->assertEquals($id2, $cachedMounts[$this->keyForMount($mount2)]->getRootId());
-		$this->assertEquals(2, $cachedMounts[$this->keyForMount($mount2)]->getStorageId());
-		$this->assertEquals('foo/bar', $cachedMounts[$this->keyForMount($mount2)]->getRootInternalPath());
-
-		$cachedMounts = $this->cache->getMountsForUser($user3);
-		$this->assertEmpty($cachedMounts);
-	}
-
-	public function testGetMountsByStorageId(): void {
-		$user1 = $this->userManager->get('u1');
-		$user2 = $this->userManager->get('u2');
-
-		[$storage1, $id1] = $this->getStorage(1);
-		[$storage2, $id2] = $this->getStorage(2);
-		$mount1 = new MountPoint($storage1, '/foo/');
-		$mount2 = new MountPoint($storage2, '/bar/');
-
-		$this->cache->registerMounts($user1, [$mount1, $mount2]);
-		$this->cache->registerMounts($user2, [$mount2]);
-
-		$this->clearCache();
-
-		$cachedMounts = $this->cache->getMountsForStorageId(2);
-		$this->sortMounts($cachedMounts);
-
-		$this->assertCount(2, $cachedMounts);
-
-		$this->assertEquals('/bar/', $cachedMounts[0]->getMountPoint());
-		$this->assertEquals($user1->getUID(), $cachedMounts[0]->getUser()->getUID());
-		$this->assertEquals($id2, $cachedMounts[0]->getRootId());
-		$this->assertEquals(2, $cachedMounts[0]->getStorageId());
-
-		$this->assertEquals('/bar/', $cachedMounts[1]->getMountPoint());
-		$this->assertEquals($user2->getUID(), $cachedMounts[1]->getUser()->getUID());
-		$this->assertEquals($id2, $cachedMounts[1]->getRootId());
-		$this->assertEquals(2, $cachedMounts[1]->getStorageId());
-	}
-
-	public function testGetMountsByRootId(): void {
-		$user1 = $this->userManager->get('u1');
-		$user2 = $this->userManager->get('u2');
-
-		[$storage1, $id1] = $this->getStorage(1);
-		[$storage2, $id2] = $this->getStorage(2);
-		$mount1 = new MountPoint($storage1, '/foo/');
-		$mount2 = new MountPoint($storage2, '/bar/');
+        $this->assertCount(2, $cachedMounts);
+        $this->assertEquals('/foo/', $cachedMounts[$this->keyForMount($mount1)]->getMountPoint());
+        $this->assertEquals($user1->getUID(), $cachedMounts[$this->keyForMount($mount1)]->getUser()->getUID());
+        $this->assertEquals($id1, $cachedMounts[$this->keyForMount($mount1)]->getRootId());
+        $this->assertEquals(1, $cachedMounts[$this->keyForMount($mount1)]->getStorageId());
+        $this->assertEquals('', $cachedMounts[$this->keyForMount($mount1)]->getRootInternalPath());
+
+        $this->assertEquals('/bar/', $cachedMounts[$this->keyForMount($mount2)]->getMountPoint());
+        $this->assertEquals($user1->getUID(), $cachedMounts[$this->keyForMount($mount2)]->getUser()->getUID());
+        $this->assertEquals($id2, $cachedMounts[$this->keyForMount($mount2)]->getRootId());
+        $this->assertEquals(2, $cachedMounts[$this->keyForMount($mount2)]->getStorageId());
+        $this->assertEquals('foo/bar', $cachedMounts[$this->keyForMount($mount2)]->getRootInternalPath());
+
+        $cachedMounts = $this->cache->getMountsForUser($user3);
+        $this->assertEmpty($cachedMounts);
+    }
+
+    public function testGetMountsByStorageId(): void {
+        $user1 = $this->userManager->get('u1');
+        $user2 = $this->userManager->get('u2');
+
+        [$storage1, $id1] = $this->getStorage(1);
+        [$storage2, $id2] = $this->getStorage(2);
+        $mount1 = new MountPoint($storage1, '/foo/');
+        $mount2 = new MountPoint($storage2, '/bar/');
+
+        $this->cache->registerMounts($user1, [$mount1, $mount2]);
+        $this->cache->registerMounts($user2, [$mount2]);
+
+        $this->clearCache();
+
+        $cachedMounts = $this->cache->getMountsForStorageId(2);
+        $this->sortMounts($cachedMounts);
+
+        $this->assertCount(2, $cachedMounts);
+
+        $this->assertEquals('/bar/', $cachedMounts[0]->getMountPoint());
+        $this->assertEquals($user1->getUID(), $cachedMounts[0]->getUser()->getUID());
+        $this->assertEquals($id2, $cachedMounts[0]->getRootId());
+        $this->assertEquals(2, $cachedMounts[0]->getStorageId());
+
+        $this->assertEquals('/bar/', $cachedMounts[1]->getMountPoint());
+        $this->assertEquals($user2->getUID(), $cachedMounts[1]->getUser()->getUID());
+        $this->assertEquals($id2, $cachedMounts[1]->getRootId());
+        $this->assertEquals(2, $cachedMounts[1]->getStorageId());
+    }
+
+    public function testGetMountsByRootId(): void {
+        $user1 = $this->userManager->get('u1');
+        $user2 = $this->userManager->get('u2');
+
+        [$storage1, $id1] = $this->getStorage(1);
+        [$storage2, $id2] = $this->getStorage(2);
+        $mount1 = new MountPoint($storage1, '/foo/');
+        $mount2 = new MountPoint($storage2, '/bar/');
 
-		$this->cache->registerMounts($user1, [$mount1, $mount2]);
-		$this->cache->registerMounts($user2, [$mount2]);
+        $this->cache->registerMounts($user1, [$mount1, $mount2]);
+        $this->cache->registerMounts($user2, [$mount2]);
 
-		$this->clearCache();
-
-		$cachedMounts = $this->cache->getMountsForRootId($id2);
-		$this->sortMounts($cachedMounts);
-
-		$this->assertCount(2, $cachedMounts);
-
-		$this->assertEquals('/bar/', $cachedMounts[0]->getMountPoint());
-		$this->assertEquals($user1->getUID(), $cachedMounts[0]->getUser()->getUID());
-		$this->assertEquals($id2, $cachedMounts[0]->getRootId());
-		$this->assertEquals(2, $cachedMounts[0]->getStorageId());
-
-		$this->assertEquals('/bar/', $cachedMounts[1]->getMountPoint());
-		$this->assertEquals($user2->getUID(), $cachedMounts[1]->getUser()->getUID());
-		$this->assertEquals($id2, $cachedMounts[1]->getRootId());
-		$this->assertEquals(2, $cachedMounts[1]->getStorageId());
-	}
-
-	private function sortMounts(&$mounts) {
-		usort($mounts, function (ICachedMountInfo $a, ICachedMountInfo $b) {
-			return strcmp($a->getUser()->getUID(), $b->getUser()->getUID());
-		});
-	}
-
-	private function createCacheEntry($internalPath, $storageId, $size = 0) {
-		$internalPath = trim($internalPath, '/');
-		try {
-			$query = $this->connection->getQueryBuilder();
-			$query->insert('filecache')
-				->values([
-					'storage' => $query->createNamedParameter($storageId),
-					'path' => $query->createNamedParameter($internalPath),
-					'path_hash' => $query->createNamedParameter(md5($internalPath)),
-					'parent' => $query->createNamedParameter(-1, IQueryBuilder::PARAM_INT),
-					'name' => $query->createNamedParameter(basename($internalPath)),
-					'mimetype' => $query->createNamedParameter(0, IQueryBuilder::PARAM_INT),
-					'mimepart' => $query->createNamedParameter(0, IQueryBuilder::PARAM_INT),
-					'size' => $query->createNamedParameter($size),
-					'storage_mtime' => $query->createNamedParameter(0, IQueryBuilder::PARAM_INT),
-					'encrypted' => $query->createNamedParameter(0, IQueryBuilder::PARAM_INT),
-					'unencrypted_size' => $query->createNamedParameter(0, IQueryBuilder::PARAM_INT),
-					'etag' => $query->createNamedParameter(''),
-					'permissions' => $query->createNamedParameter(31, IQueryBuilder::PARAM_INT),
-				]);
-			$query->executeStatement();
-			$id = $query->getLastInsertId();
-			$this->fileIds[] = $id;
-		} catch (DbalException $e) {
-			if ($e->getReason() === DbalException::REASON_UNIQUE_CONSTRAINT_VIOLATION) {
-				$query = $this->connection->getQueryBuilder();
-				$query->select('fileid')
-					->from('filecache')
-					->where($query->expr()->eq('storage', $query->createNamedParameter($storageId)))
-					->andWhere($query->expr()->eq('path_hash', $query->createNamedParameter(md5($internalPath))));
-				$id = (int)$query->executeQuery()->fetchOne();
-			} else {
-				throw $e;
-			}
-		}
-		return $id;
-	}
+        $this->clearCache();
+
+        $cachedMounts = $this->cache->getMountsForRootId($id2);
+        $this->sortMounts($cachedMounts);
+
+        $this->assertCount(2, $cachedMounts);
+
+        $this->assertEquals('/bar/', $cachedMounts[0]->getMountPoint());
+        $this->assertEquals($user1->getUID(), $cachedMounts[0]->getUser()->getUID());
+        $this->assertEquals($id2, $cachedMounts[0]->getRootId());
+        $this->assertEquals(2, $cachedMounts[0]->getStorageId());
+
+        $this->assertEquals('/bar/', $cachedMounts[1]->getMountPoint());
+        $this->assertEquals($user2->getUID(), $cachedMounts[1]->getUser()->getUID());
+        $this->assertEquals($id2, $cachedMounts[1]->getRootId());
+        $this->assertEquals(2, $cachedMounts[1]->getStorageId());
+    }
+
+    private function sortMounts(&$mounts) {
+        usort($mounts, function (ICachedMountInfo $a, ICachedMountInfo $b) {
+            return strcmp($a->getUser()->getUID(), $b->getUser()->getUID());
+        });
+    }
+
+    private function createCacheEntry($internalPath, $storageId, $size = 0) {
+        $internalPath = trim($internalPath, '/');
+        try {
+            $query = $this->connection->getQueryBuilder();
+            $query->insert('filecache')
+                ->values([
+                    'storage' => $query->createNamedParameter($storageId),
+                    'path' => $query->createNamedParameter($internalPath),
+                    'path_hash' => $query->createNamedParameter(md5($internalPath)),
+                    'parent' => $query->createNamedParameter(-1, IQueryBuilder::PARAM_INT),
+                    'name' => $query->createNamedParameter(basename($internalPath)),
+                    'mimetype' => $query->createNamedParameter(0, IQueryBuilder::PARAM_INT),
+                    'mimepart' => $query->createNamedParameter(0, IQueryBuilder::PARAM_INT),
+                    'size' => $query->createNamedParameter($size),
+                    'storage_mtime' => $query->createNamedParameter(0, IQueryBuilder::PARAM_INT),
+                    'encrypted' => $query->createNamedParameter(0, IQueryBuilder::PARAM_INT),
+                    'unencrypted_size' => $query->createNamedParameter(0, IQueryBuilder::PARAM_INT),
+                    'etag' => $query->createNamedParameter(''),
+                    'permissions' => $query->createNamedParameter(31, IQueryBuilder::PARAM_INT),
+                ]);
+            $query->executeStatement();
+            $id = $query->getLastInsertId();
+            $this->fileIds[] = $id;
+        } catch (DbalException $e) {
+            if ($e->getReason() === DbalException::REASON_UNIQUE_CONSTRAINT_VIOLATION) {
+                $query = $this->connection->getQueryBuilder();
+                $query->select('fileid')
+                    ->from('filecache')
+                    ->where($query->expr()->eq('storage', $query->createNamedParameter($storageId)))
+                    ->andWhere($query->expr()->eq('path_hash', $query->createNamedParameter(md5($internalPath))));
+                $id = (int)$query->executeQuery()->fetchOne();
+            } else {
+                throw $e;
+            }
+        }
+        return $id;
+    }
 
-	public function testGetMountsForFileIdRootId(): void {
-		$user1 = $this->userManager->get('u1');
+    public function testGetMountsForFileIdRootId(): void {
+        $user1 = $this->userManager->get('u1');
 
-		[$storage1, $rootId] = $this->getStorage(2);
-		$mount1 = new MountPoint($storage1, '/foo/');
+        [$storage1, $rootId] = $this->getStorage(2);
+        $mount1 = new MountPoint($storage1, '/foo/');
 
-		$this->cache->registerMounts($user1, [$mount1]);
+        $this->cache->registerMounts($user1, [$mount1]);
 
-		$this->clearCache();
+        $this->clearCache();
 
-		$cachedMounts = $this->cache->getMountsForFileId($rootId);
+        $cachedMounts = $this->cache->getMountsForFileId($rootId);
 
-		$this->assertCount(1, $cachedMounts);
+        $this->assertCount(1, $cachedMounts);
 
-		$this->assertEquals('/foo/', $cachedMounts[0]->getMountPoint());
-		$this->assertEquals($user1->getUID(), $cachedMounts[0]->getUser()->getUID());
-		$this->assertEquals($rootId, $cachedMounts[0]->getRootId());
-		$this->assertEquals(2, $cachedMounts[0]->getStorageId());
-	}
+        $this->assertEquals('/foo/', $cachedMounts[0]->getMountPoint());
+        $this->assertEquals($user1->getUID(), $cachedMounts[0]->getUser()->getUID());
+        $this->assertEquals($rootId, $cachedMounts[0]->getRootId());
+        $this->assertEquals(2, $cachedMounts[0]->getStorageId());
+    }
 
-	public function testGetMountsForFileIdSubFolder(): void {
-		$user1 = $this->userManager->get('u1');
+    public function testGetMountsForFileIdSubFolder(): void {
+        $user1 = $this->userManager->get('u1');
 
-		$fileId = $this->createCacheEntry('/foo/bar', 2);
+        $fileId = $this->createCacheEntry('/foo/bar', 2);
 
-		[$storage1, $rootId] = $this->getStorage(2);
-		$mount1 = new MountPoint($storage1, '/foo/');
+        [$storage1, $rootId] = $this->getStorage(2);
+        $mount1 = new MountPoint($storage1, '/foo/');
 
-		$this->cache->registerMounts($user1, [$mount1]);
+        $this->cache->registerMounts($user1, [$mount1]);
 
-		$this->clearCache();
+        $this->clearCache();
 
-		$cachedMounts = $this->cache->getMountsForFileId($fileId);
-
-		$this->assertCount(1, $cachedMounts);
-
-		$this->assertEquals('/foo/', $cachedMounts[0]->getMountPoint());
-		$this->assertEquals($user1->getUID(), $cachedMounts[0]->getUser()->getUID());
-		$this->assertEquals($rootId, $cachedMounts[0]->getRootId());
-		$this->assertEquals(2, $cachedMounts[0]->getStorageId());
-		$this->assertEquals('foo/bar', $cachedMounts[0]->getInternalPath());
-		$this->assertEquals('/foo/foo/bar', $cachedMounts[0]->getPath());
-	}
-
-	public function testGetMountsForFileIdSubFolderMount(): void {
-		$user1 = $this->userManager->get('u1');
-
-		[$storage1, $rootId] = $this->getStorage(2);
-		$folderId = $this->createCacheEntry('/foo', 2);
-		$fileId = $this->createCacheEntry('/foo/bar', 2);
+        $cachedMounts = $this->cache->getMountsForFileId($fileId);
+
+        $this->assertCount(1, $cachedMounts);
+
+        $this->assertEquals('/foo/', $cachedMounts[0]->getMountPoint());
+        $this->assertEquals($user1->getUID(), $cachedMounts[0]->getUser()->getUID());
+        $this->assertEquals($rootId, $cachedMounts[0]->getRootId());
+        $this->assertEquals(2, $cachedMounts[0]->getStorageId());
+        $this->assertEquals('foo/bar', $cachedMounts[0]->getInternalPath());
+        $this->assertEquals('/foo/foo/bar', $cachedMounts[0]->getPath());
+    }
+
+    public function testGetMountsForFileIdSubFolderMount(): void {
+        $user1 = $this->userManager->get('u1');
+
+        [$storage1, $rootId] = $this->getStorage(2);
+        $folderId = $this->createCacheEntry('/foo', 2);
+        $fileId = $this->createCacheEntry('/foo/bar', 2);
 
 
-		$mount1 = $this->getMockBuilder(MountPoint::class)
-			->setConstructorArgs([$storage1, '/'])
-			->onlyMethods(['getStorageRootId'])
-			->getMock();
+        $mount1 = $this->getMockBuilder(MountPoint::class)
+            ->setConstructorArgs([$storage1, '/'])
+            ->onlyMethods(['getStorageRootId'])
+            ->getMock();
 
-		$mount1->expects($this->any())
-			->method('getStorageRootId')
-			->willReturn($folderId);
+        $mount1->expects($this->any())
+            ->method('getStorageRootId')
+            ->willReturn($folderId);
 
-		$this->cache->registerMounts($user1, [$mount1]);
+        $this->cache->registerMounts($user1, [$mount1]);
 
-		$this->clearCache();
+        $this->clearCache();
 
-		$cachedMounts = $this->cache->getMountsForFileId($fileId);
+        $cachedMounts = $this->cache->getMountsForFileId($fileId);
 
-		$this->assertCount(1, $cachedMounts);
+        $this->assertCount(1, $cachedMounts);
 
-		$this->assertEquals('/', $cachedMounts[0]->getMountPoint());
-		$this->assertEquals($user1->getUID(), $cachedMounts[0]->getUser()->getUID());
-		$this->assertEquals($folderId, $cachedMounts[0]->getRootId());
-		$this->assertEquals(2, $cachedMounts[0]->getStorageId());
-		$this->assertEquals('foo', $cachedMounts[0]->getRootInternalPath());
-		$this->assertEquals('bar', $cachedMounts[0]->getInternalPath());
-		$this->assertEquals('/bar', $cachedMounts[0]->getPath());
-	}
+        $this->assertEquals('/', $cachedMounts[0]->getMountPoint());
+        $this->assertEquals($user1->getUID(), $cachedMounts[0]->getUser()->getUID());
+        $this->assertEquals($folderId, $cachedMounts[0]->getRootId());
+        $this->assertEquals(2, $cachedMounts[0]->getStorageId());
+        $this->assertEquals('foo', $cachedMounts[0]->getRootInternalPath());
+        $this->assertEquals('bar', $cachedMounts[0]->getInternalPath());
+        $this->assertEquals('/bar', $cachedMounts[0]->getPath());
+    }
 
-	public function testGetMountsForFileIdSubFolderMountOutside(): void {
-		$user1 = $this->userManager->get('u1');
+    public function testGetMountsForFileIdSubFolderMountOutside(): void {
+        $user1 = $this->userManager->get('u1');
 
-		[$storage1, $rootId] = $this->getStorage(2);
-		$folderId = $this->createCacheEntry('/foo', 2);
-		$fileId = $this->createCacheEntry('/bar/asd', 2);
+        [$storage1, $rootId] = $this->getStorage(2);
+        $folderId = $this->createCacheEntry('/foo', 2);
+        $fileId = $this->createCacheEntry('/bar/asd', 2);
 
-		$mount1 = $this->getMockBuilder(MountPoint::class)
-			->setConstructorArgs([$storage1, '/foo/'])
-			->onlyMethods(['getStorageRootId'])
-			->getMock();
+        $mount1 = $this->getMockBuilder(MountPoint::class)
+            ->setConstructorArgs([$storage1, '/foo/'])
+            ->onlyMethods(['getStorageRootId'])
+            ->getMock();
 
-		$mount1->expects($this->any())
-			->method('getStorageRootId')
-			->willReturn($folderId);
+        $mount1->expects($this->any())
+            ->method('getStorageRootId')
+            ->willReturn($folderId);
 
-		$this->cache->registerMounts($user1, [$mount1]);
+        $this->cache->registerMounts($user1, [$mount1]);
 
-		$this->cache->registerMounts($user1, [$mount1]);
+        $this->cache->registerMounts($user1, [$mount1]);
 
-		$this->clearCache();
+        $this->clearCache();
 
-		$cachedMounts = $this->cache->getMountsForFileId($fileId);
+        $cachedMounts = $this->cache->getMountsForFileId($fileId);
 
-		$this->assertCount(0, $cachedMounts);
-	}
+        $this->assertCount(0, $cachedMounts);
+    }
 
 
-	public function testGetMountsForFileIdDeletedUser(): void {
-		$user1 = $this->userManager->get('u1');
+    public function testGetMountsForFileIdDeletedUser(): void {
+        $user1 = $this->userManager->get('u1');
 
-		[$storage1, $rootId] = $this->getStorage(2);
-		$rootId = $this->createCacheEntry('', 2);
-		$mount1 = new MountPoint($storage1, '/foo/');
-		$this->cache->registerMounts($user1, [$mount1]);
+        [$storage1, $rootId] = $this->getStorage(2);
+        $rootId = $this->createCacheEntry('', 2);
+        $mount1 = new MountPoint($storage1, '/foo/');
+        $this->cache->registerMounts($user1, [$mount1]);
 
-		$user1->delete();
-		$this->clearCache();
+        $user1->delete();
+        $this->clearCache();
 
-		$cachedMounts = $this->cache->getMountsForFileId($rootId);
-		$this->assertEmpty($cachedMounts);
-	}
+        $cachedMounts = $this->cache->getMountsForFileId($rootId);
+        $this->assertEmpty($cachedMounts);
+    }
 
-	public function testGetUsedSpaceForUsers(): void {
-		$user1 = $this->userManager->get('u1');
-		$user2 = $this->userManager->get('u2');
+    public function testGetUsedSpaceForUsers(): void {
+        $user1 = $this->userManager->get('u1');
+        $user2 = $this->userManager->get('u2');
 
-		/** @var Storage $storage1 */
-		[$storage1, $rootId] = $this->getStorage(2);
-		$folderId = $this->createCacheEntry('files', 2, 100);
-		$fileId = $this->createCacheEntry('files/foo', 2, 7);
-		$storage1->getCache()->put($folderId, ['size' => 100]);
-		$storage1->getCache()->update($fileId, ['size' => 70]);
+        /** @var Storage $storage1 */
+        [$storage1, $rootId] = $this->getStorage(2);
+        $folderId = $this->createCacheEntry('files', 2, 100);
+        $fileId = $this->createCacheEntry('files/foo', 2, 7);
+        $storage1->getCache()->put($folderId, ['size' => 100]);
+        $storage1->getCache()->update($fileId, ['size' => 70]);
 
-		$mount1 = $this->getMockBuilder(MountPoint::class)
-			->setConstructorArgs([$storage1, '/u1/'])
-			->onlyMethods(['getStorageRootId', 'getNumericStorageId'])
-			->getMock();
+        $mount1 = $this->getMockBuilder(MountPoint::class)
+            ->setConstructorArgs([$storage1, '/u1/'])
+            ->onlyMethods(['getStorageRootId', 'getNumericStorageId'])
+            ->getMock();
 
-		$mount1->expects($this->any())
-			->method('getStorageRootId')
-			->willReturn($rootId);
+        $mount1->expects($this->any())
+            ->method('getStorageRootId')
+            ->willReturn($rootId);
 
-		$mount1->expects($this->any())
-			->method('getNumericStorageId')
-			->willReturn(2);
+        $mount1->expects($this->any())
+            ->method('getNumericStorageId')
+            ->willReturn(2);
 
-		$this->cache->registerMounts($user1, [$mount1]);
+        $this->cache->registerMounts($user1, [$mount1]);
 
-		$result = $this->cache->getUsedSpaceForUsers([$user1, $user2]);
-		$this->assertEquals(['u1' => 100], $result);
-	}
+        $result = $this->cache->getUsedSpaceForUsers([$user1, $user2]);
+        $this->assertEquals(['u1' => 100], $result);
+    }
 
 
-	public function testMigrateMountProvider(): void {
-		$user1 = $this->userManager->get('u1');
+    public function testMigrateMountProvider(): void {
+        $user1 = $this->userManager->get('u1');
 
-		[$storage1, $rootId] = $this->getStorage(2);
-		$rootId = $this->createCacheEntry('', 2);
-		$mount1 = new MountPoint($storage1, '/foo/');
-		$this->cache->registerMounts($user1, [$mount1]);
+        [$storage1, $rootId] = $this->getStorage(2);
+        $rootId = $this->createCacheEntry('', 2);
+        $mount1 = new MountPoint($storage1, '/foo/');
+        $this->cache->registerMounts($user1, [$mount1]);
 
-		$this->clearCache();
+        $this->clearCache();
 
-		$cachedMounts = $this->cache->getMountsForUser($user1);
-		$this->assertCount(1, $cachedMounts);
-		$this->assertEquals('', $cachedMounts[$this->keyForMount($mount1)]->getMountProvider());
+        $cachedMounts = $this->cache->getMountsForUser($user1);
+        $this->assertCount(1, $cachedMounts);
+        $this->assertEquals('', $cachedMounts[$this->keyForMount($mount1)]->getMountProvider());
 
-		$mount1 = new MountPoint($storage1, '/foo/', null, null, null, null, 'dummy');
-		$this->cache->registerMounts($user1, [$mount1], ['dummy']);
+        $mount1 = new MountPoint($storage1, '/foo/', null, null, null, null, 'dummy');
+        $this->cache->registerMounts($user1, [$mount1], ['dummy']);
 
-		$this->clearCache();
+        $this->clearCache();
 
-		$cachedMounts = $this->cache->getMountsForUser($user1);
-		$this->assertCount(1, $cachedMounts);
-		$this->assertEquals('dummy', $cachedMounts[$this->keyForMount($mount1)]->getMountProvider());
-	}
+        $cachedMounts = $this->cache->getMountsForUser($user1);
+        $this->assertCount(1, $cachedMounts);
+        $this->assertEquals('dummy', $cachedMounts[$this->keyForMount($mount1)]->getMountProvider());
+    }
 }

tests/lib/Files/Template/TemplateManagerTest.php

Indentation +74 added lines, -74 removed lines

@@ -31,78 +31,78 @@
 
 class TemplateManagerTest extends TestCase {
 
-	private IRootFolder $rootFolder;
-	private Coordinator $bootstrapCoordinator;
-
-	private TemplateManager $templateManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$l10n = $this->createMock(IL10N::class);
-		$l10n->method('t')
-			->willReturnCallback(fn ($string, $params) => sprintf($string, ...$params));
-		$l10nFactory = $this->createMock(IFactory::class);
-		$l10nFactory->method('get')
-			->willReturn($l10n);
-		$database = $this->createMock(IDBConnection::class);
-		$database->method('supports4ByteText')->willReturn(true);
-		$config = $this->createMock(IConfig::class);
-		$logger = new NullLogger();
-
-		$filenameValidator = new FilenameValidator(
-			$l10nFactory,
-			$database,
-			$config,
-			$logger,
-		);
-
-		$serverContainer = $this->createMock(IServerContainer::class);
-		$eventDispatcher = $this->createMock(IEventDispatcher::class);
-		$this->bootstrapCoordinator = $this->createMock(Coordinator::class);
-		$this->bootstrapCoordinator->method('getRegistrationContext')
-			->willReturn(new RegistrationContext($logger));
-		$this->rootFolder = $this->createMock(IRootFolder::class);
-		$userSession = $this->createMock(IUserSession::class);
-		$userManager = $this->createMock(IUserManager::class);
-		$previewManager = $this->createMock(IPreview::class);
-
-		$this->templateManager = new TemplateManager(
-			$serverContainer,
-			$eventDispatcher,
-			$this->bootstrapCoordinator,
-			$this->rootFolder,
-			$userSession,
-			$userManager,
-			$previewManager,
-			$config,
-			$l10nFactory,
-			$logger,
-			$filenameValidator
-		);
-	}
-
-	public function testCreateFromTemplateShoudValidateFilename(): void {
-		$this->expectException(GenericFileException::class);
-
-		$fileDirectory = '/';
-		$filePath = $fileDirectory . str_repeat('a', 251);
-
-		$userFolder = $this->createMock(Folder::class);
-		$userFolder->method('get')
-			->willReturnCallback(function ($path) use ($filePath, $fileDirectory) {
-				if ($path === $filePath) {
-					throw new NotFoundException();
-				}
-				return $this->createMock(Folder::class);
-			});
-		$userFolder->method('nodeExists')
-			->willReturnCallback(function ($path) use ($filePath, $fileDirectory) {
-				return $path === $fileDirectory;
-			});
-		$this->rootFolder->method('getUserFolder')
-			->willReturn($userFolder);
-
-		$this->templateManager->createFromTemplate($filePath);
-	}
+    private IRootFolder $rootFolder;
+    private Coordinator $bootstrapCoordinator;
+
+    private TemplateManager $templateManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $l10n = $this->createMock(IL10N::class);
+        $l10n->method('t')
+            ->willReturnCallback(fn ($string, $params) => sprintf($string, ...$params));
+        $l10nFactory = $this->createMock(IFactory::class);
+        $l10nFactory->method('get')
+            ->willReturn($l10n);
+        $database = $this->createMock(IDBConnection::class);
+        $database->method('supports4ByteText')->willReturn(true);
+        $config = $this->createMock(IConfig::class);
+        $logger = new NullLogger();
+
+        $filenameValidator = new FilenameValidator(
+            $l10nFactory,
+            $database,
+            $config,
+            $logger,
+        );
+
+        $serverContainer = $this->createMock(IServerContainer::class);
+        $eventDispatcher = $this->createMock(IEventDispatcher::class);
+        $this->bootstrapCoordinator = $this->createMock(Coordinator::class);
+        $this->bootstrapCoordinator->method('getRegistrationContext')
+            ->willReturn(new RegistrationContext($logger));
+        $this->rootFolder = $this->createMock(IRootFolder::class);
+        $userSession = $this->createMock(IUserSession::class);
+        $userManager = $this->createMock(IUserManager::class);
+        $previewManager = $this->createMock(IPreview::class);
+
+        $this->templateManager = new TemplateManager(
+            $serverContainer,
+            $eventDispatcher,
+            $this->bootstrapCoordinator,
+            $this->rootFolder,
+            $userSession,
+            $userManager,
+            $previewManager,
+            $config,
+            $l10nFactory,
+            $logger,
+            $filenameValidator
+        );
+    }
+
+    public function testCreateFromTemplateShoudValidateFilename(): void {
+        $this->expectException(GenericFileException::class);
+
+        $fileDirectory = '/';
+        $filePath = $fileDirectory . str_repeat('a', 251);
+
+        $userFolder = $this->createMock(Folder::class);
+        $userFolder->method('get')
+            ->willReturnCallback(function ($path) use ($filePath, $fileDirectory) {
+                if ($path === $filePath) {
+                    throw new NotFoundException();
+                }
+                return $this->createMock(Folder::class);
+            });
+        $userFolder->method('nodeExists')
+            ->willReturnCallback(function ($path) use ($filePath, $fileDirectory) {
+                return $path === $fileDirectory;
+            });
+        $this->rootFolder->method('getUserFolder')
+            ->willReturn($userFolder);
+
+        $this->templateManager->createFromTemplate($filePath);
+    }
 }

tests/lib/Files/Cache/SearchBuilderTest.php

Indentation +185 added lines, -185 removed lines

@@ -23,189 +23,189 @@
 
 #[\PHPUnit\Framework\Attributes\Group('DB')]
 class SearchBuilderTest extends TestCase {
-	/** @var IQueryBuilder */
-	private $builder;
-
-	/** @var IMimeTypeLoader&\PHPUnit\Framework\MockObject\MockObject */
-	private $mimetypeLoader;
-
-	/** @var IFilesMetadataManager&\PHPUnit\Framework\MockObject\MockObject */
-	private $filesMetadataManager;
-
-	/** @var SearchBuilder */
-	private $searchBuilder;
-
-	/** @var integer */
-	private $numericStorageId;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->builder = Server::get(IDBConnection::class)->getQueryBuilder();
-		$this->mimetypeLoader = $this->createMock(IMimeTypeLoader::class);
-		$this->filesMetadataManager = $this->createMock(IFilesMetadataManager::class);
-
-		$this->mimetypeLoader->expects($this->any())
-			->method('getId')
-			->willReturnMap([
-				['text', 1],
-				['text/plain', 2],
-				['text/xml', 3],
-				['image/jpg', 4],
-				['image/png', 5],
-				['image', 6],
-			]);
-
-		$this->mimetypeLoader->expects($this->any())
-			->method('getMimetypeById')
-			->willReturnMap([
-				[1, 'text'],
-				[2, 'text/plain'],
-				[3, 'text/xml'],
-				[4, 'image/jpg'],
-				[5, 'image/png'],
-				[6, 'image']
-			]);
-
-		$this->searchBuilder = new SearchBuilder($this->mimetypeLoader, $this->filesMetadataManager);
-		$this->numericStorageId = 10000;
-
-		$this->builder->select(['fileid'])
-			->from('filecache', 'file') // alias needed for QuerySearchHelper#getOperatorFieldAndValue
-			->where($this->builder->expr()->eq('storage', new Literal($this->numericStorageId)));
-	}
-
-	protected function tearDown(): void {
-		parent::tearDown();
-
-		$builder = Server::get(IDBConnection::class)->getQueryBuilder();
-
-		$builder->delete('filecache')
-			->where($builder->expr()->eq('storage', $builder->createNamedParameter($this->numericStorageId, IQueryBuilder::PARAM_INT)));
-
-		$builder->executeStatement();
-	}
-
-	private function addCacheEntry(array $data) {
-		$data['storage'] = $this->numericStorageId;
-		$data['etag'] = 'unimportant';
-		$data['storage_mtime'] = $data['mtime'];
-		if (!isset($data['path'])) {
-			$data['path'] = 'random/' . $this->getUniqueID();
-		}
-		$data['path_hash'] = md5($data['path']);
-		if (!isset($data['mtime'])) {
-			$data['mtime'] = 100;
-		}
-		if (!isset($data['size'])) {
-			$data['size'] = 100;
-		}
-		$data['name'] = basename($data['path']);
-		$data['parent'] = -1;
-		if (isset($data['mimetype'])) {
-			[$mimepart,] = explode('/', $data['mimetype']);
-			$data['mimepart'] = $this->mimetypeLoader->getId($mimepart);
-			$data['mimetype'] = $this->mimetypeLoader->getId($data['mimetype']);
-		} else {
-			$data['mimepart'] = 1;
-			$data['mimetype'] = 1;
-		}
-
-		$builder = Server::get(IDBConnection::class)->getQueryBuilder();
-
-		$values = [];
-		foreach ($data as $key => $value) {
-			$values[$key] = $builder->createNamedParameter($value);
-		}
-
-		$builder->insert('filecache')
-			->values($values)
-			->executeStatement();
-
-		return $builder->getLastInsertId();
-	}
-
-	private function search(ISearchOperator $operator) {
-		$dbOperator = $this->searchBuilder->searchOperatorToDBExpr($this->builder, $operator);
-		$this->builder->andWhere($dbOperator);
-
-		$result = $this->builder->executeQuery();
-		$rows = $result->fetchFirstColumn();
-		$result->closeCursor();
-
-		return $rows;
-	}
-
-	public static function comparisonProvider(): array {
-		return [
-			[new SearchComparison(ISearchComparison::COMPARE_GREATER_THAN, 'mtime', 125), [1]],
-			[new SearchComparison(ISearchComparison::COMPARE_LESS_THAN, 'mtime', 125), [0]],
-			[new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'size', 125), []],
-			[new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'size', 50), [0, 1]],
-			[new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'name', 'foobar'), [0]],
-			[new SearchComparison(ISearchComparison::COMPARE_LIKE, 'name', 'foo%'), [0, 1]],
-			[new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'mimetype', 'image/jpg'), [0]],
-			[new SearchComparison(ISearchComparison::COMPARE_LIKE, 'mimetype', 'image/%'), [0, 1]],
-			[new SearchComparison(ISearchComparison::COMPARE_IN, 'mimetype', ['image/jpg', 'image/png']), [0, 1]],
-			[new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_AND, [
-				new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'size', 50),
-				new SearchComparison(ISearchComparison::COMPARE_LESS_THAN, 'mtime', 125)
-			]), [0]],
-			[new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_AND, [
-				new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'size', 50),
-				new SearchComparison(ISearchComparison::COMPARE_LESS_THAN, 'mtime', 125),
-				new SearchComparison(ISearchComparison::COMPARE_LIKE, 'mimetype', 'text/%')
-			]), []],
-			[new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_OR, [
-				new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'mtime', 100),
-				new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'mtime', 150),
-			]), [0, 1]],
-			[new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_NOT, [
-				new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'mtime', 150),
-			]), [0]],
-			[new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_NOT, [
-				new SearchComparison(ISearchComparison::COMPARE_GREATER_THAN, 'mtime', 125),
-			]), [0]],
-			[new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_NOT, [
-				new SearchComparison(ISearchComparison::COMPARE_LESS_THAN, 'mtime', 125),
-			]), [1]],
-			[new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_NOT, [
-				new SearchComparison(ISearchComparison::COMPARE_LIKE, 'name', '%bar'),
-			]), [1]],
-
-		];
-	}
-
-	/**
-	 *
-	 * @param ISearchOperator $operator
-	 * @param array $fileIds
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('comparisonProvider')]
-	public function testComparison(ISearchOperator $operator, array $fileIds): void {
-		$fileId = [];
-		$fileId[] = $this->addCacheEntry([
-			'path' => 'foobar',
-			'mtime' => 100,
-			'size' => 50,
-			'mimetype' => 'image/jpg'
-		]);
-
-		$fileId[] = $this->addCacheEntry([
-			'path' => 'fooasd',
-			'mtime' => 150,
-			'size' => 50,
-			'mimetype' => 'image/png'
-		]);
-
-		$fileIds = array_map(function ($i) use ($fileId) {
-			return $fileId[$i];
-		}, $fileIds);
-
-		$results = $this->search($operator);
-
-		sort($fileIds);
-		sort($results);
-
-		$this->assertEquals($fileIds, $results);
-	}
+    /** @var IQueryBuilder */
+    private $builder;
+
+    /** @var IMimeTypeLoader&\PHPUnit\Framework\MockObject\MockObject */
+    private $mimetypeLoader;
+
+    /** @var IFilesMetadataManager&\PHPUnit\Framework\MockObject\MockObject */
+    private $filesMetadataManager;
+
+    /** @var SearchBuilder */
+    private $searchBuilder;
+
+    /** @var integer */
+    private $numericStorageId;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->builder = Server::get(IDBConnection::class)->getQueryBuilder();
+        $this->mimetypeLoader = $this->createMock(IMimeTypeLoader::class);
+        $this->filesMetadataManager = $this->createMock(IFilesMetadataManager::class);
+
+        $this->mimetypeLoader->expects($this->any())
+            ->method('getId')
+            ->willReturnMap([
+                ['text', 1],
+                ['text/plain', 2],
+                ['text/xml', 3],
+                ['image/jpg', 4],
+                ['image/png', 5],
+                ['image', 6],
+            ]);
+
+        $this->mimetypeLoader->expects($this->any())
+            ->method('getMimetypeById')
+            ->willReturnMap([
+                [1, 'text'],
+                [2, 'text/plain'],
+                [3, 'text/xml'],
+                [4, 'image/jpg'],
+                [5, 'image/png'],
+                [6, 'image']
+            ]);
+
+        $this->searchBuilder = new SearchBuilder($this->mimetypeLoader, $this->filesMetadataManager);
+        $this->numericStorageId = 10000;
+
+        $this->builder->select(['fileid'])
+            ->from('filecache', 'file') // alias needed for QuerySearchHelper#getOperatorFieldAndValue
+            ->where($this->builder->expr()->eq('storage', new Literal($this->numericStorageId)));
+    }
+
+    protected function tearDown(): void {
+        parent::tearDown();
+
+        $builder = Server::get(IDBConnection::class)->getQueryBuilder();
+
+        $builder->delete('filecache')
+            ->where($builder->expr()->eq('storage', $builder->createNamedParameter($this->numericStorageId, IQueryBuilder::PARAM_INT)));
+
+        $builder->executeStatement();
+    }
+
+    private function addCacheEntry(array $data) {
+        $data['storage'] = $this->numericStorageId;
+        $data['etag'] = 'unimportant';
+        $data['storage_mtime'] = $data['mtime'];
+        if (!isset($data['path'])) {
+            $data['path'] = 'random/' . $this->getUniqueID();
+        }
+        $data['path_hash'] = md5($data['path']);
+        if (!isset($data['mtime'])) {
+            $data['mtime'] = 100;
+        }
+        if (!isset($data['size'])) {
+            $data['size'] = 100;
+        }
+        $data['name'] = basename($data['path']);
+        $data['parent'] = -1;
+        if (isset($data['mimetype'])) {
+            [$mimepart,] = explode('/', $data['mimetype']);
+            $data['mimepart'] = $this->mimetypeLoader->getId($mimepart);
+            $data['mimetype'] = $this->mimetypeLoader->getId($data['mimetype']);
+        } else {
+            $data['mimepart'] = 1;
+            $data['mimetype'] = 1;
+        }
+
+        $builder = Server::get(IDBConnection::class)->getQueryBuilder();
+
+        $values = [];
+        foreach ($data as $key => $value) {
+            $values[$key] = $builder->createNamedParameter($value);
+        }
+
+        $builder->insert('filecache')
+            ->values($values)
+            ->executeStatement();
+
+        return $builder->getLastInsertId();
+    }
+
+    private function search(ISearchOperator $operator) {
+        $dbOperator = $this->searchBuilder->searchOperatorToDBExpr($this->builder, $operator);
+        $this->builder->andWhere($dbOperator);
+
+        $result = $this->builder->executeQuery();
+        $rows = $result->fetchFirstColumn();
+        $result->closeCursor();
+
+        return $rows;
+    }
+
+    public static function comparisonProvider(): array {
+        return [
+            [new SearchComparison(ISearchComparison::COMPARE_GREATER_THAN, 'mtime', 125), [1]],
+            [new SearchComparison(ISearchComparison::COMPARE_LESS_THAN, 'mtime', 125), [0]],
+            [new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'size', 125), []],
+            [new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'size', 50), [0, 1]],
+            [new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'name', 'foobar'), [0]],
+            [new SearchComparison(ISearchComparison::COMPARE_LIKE, 'name', 'foo%'), [0, 1]],
+            [new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'mimetype', 'image/jpg'), [0]],
+            [new SearchComparison(ISearchComparison::COMPARE_LIKE, 'mimetype', 'image/%'), [0, 1]],
+            [new SearchComparison(ISearchComparison::COMPARE_IN, 'mimetype', ['image/jpg', 'image/png']), [0, 1]],
+            [new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_AND, [
+                new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'size', 50),
+                new SearchComparison(ISearchComparison::COMPARE_LESS_THAN, 'mtime', 125)
+            ]), [0]],
+            [new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_AND, [
+                new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'size', 50),
+                new SearchComparison(ISearchComparison::COMPARE_LESS_THAN, 'mtime', 125),
+                new SearchComparison(ISearchComparison::COMPARE_LIKE, 'mimetype', 'text/%')
+            ]), []],
+            [new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_OR, [
+                new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'mtime', 100),
+                new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'mtime', 150),
+            ]), [0, 1]],
+            [new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_NOT, [
+                new SearchComparison(ISearchComparison::COMPARE_EQUAL, 'mtime', 150),
+            ]), [0]],
+            [new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_NOT, [
+                new SearchComparison(ISearchComparison::COMPARE_GREATER_THAN, 'mtime', 125),
+            ]), [0]],
+            [new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_NOT, [
+                new SearchComparison(ISearchComparison::COMPARE_LESS_THAN, 'mtime', 125),
+            ]), [1]],
+            [new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_NOT, [
+                new SearchComparison(ISearchComparison::COMPARE_LIKE, 'name', '%bar'),
+            ]), [1]],
+
+        ];
+    }
+
+    /**
+     *
+     * @param ISearchOperator $operator
+     * @param array $fileIds
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('comparisonProvider')]
+    public function testComparison(ISearchOperator $operator, array $fileIds): void {
+        $fileId = [];
+        $fileId[] = $this->addCacheEntry([
+            'path' => 'foobar',
+            'mtime' => 100,
+            'size' => 50,
+            'mimetype' => 'image/jpg'
+        ]);
+
+        $fileId[] = $this->addCacheEntry([
+            'path' => 'fooasd',
+            'mtime' => 150,
+            'size' => 50,
+            'mimetype' => 'image/png'
+        ]);
+
+        $fileIds = array_map(function ($i) use ($fileId) {
+            return $fileId[$i];
+        }, $fileIds);
+
+        $results = $this->search($operator);
+
+        sort($fileIds);
+        sort($results);
+
+        $this->assertEquals($fileIds, $results);
+    }
 }

tests/lib/Repair/OldGroupMembershipSharesTest.php

Indentation +105 added lines, -105 removed lines

@@ -25,109 +25,109 @@
 #[\PHPUnit\Framework\Attributes\Group('DB')]
 class OldGroupMembershipSharesTest extends \Test\TestCase {
 
-	private IDBConnection $connection;
-	private IGroupManager&MockObject $groupManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->groupManager = $this->getMockBuilder(IGroupManager::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$this->connection = Server::get(IDBConnection::class);
-
-		$this->deleteAllShares();
-	}
-
-	protected function tearDown(): void {
-		$this->deleteAllShares();
-
-		parent::tearDown();
-	}
-
-	protected function deleteAllShares() {
-		$qb = $this->connection->getQueryBuilder();
-		$qb->delete('share')->executeStatement();
-	}
-
-	public function testRun(): void {
-		$repair = new OldGroupMembershipShares(
-			$this->connection,
-			$this->groupManager
-		);
-
-		$this->groupManager->expects($this->exactly(2))
-			->method('isInGroup')
-			->willReturnMap([
-				['member', 'group', true],
-				['not-a-member', 'group', false],
-			]);
-
-		$parent = $this->createShare(IShare::TYPE_GROUP, 'group', null);
-		$group2 = $this->createShare(IShare::TYPE_GROUP, 'group2', $parent);
-		$user1 = $this->createShare(IShare::TYPE_USER, 'user1', $parent);
-
-		// \OC\Share\Constant::$shareTypeGroupUserUnique === 2
-		$member = $this->createShare(2, 'member', $parent);
-		$notAMember = $this->createShare(2, 'not-a-member', $parent);
-
-		$query = $this->connection->getQueryBuilder();
-		$result = $query->select('id')
-			->from('share')
-			->orderBy('id', 'ASC')
-			->executeQuery();
-		$rows = $result->fetchAllAssociative();
-		$this->assertEquals([['id' => $parent], ['id' => $group2], ['id' => $user1], ['id' => $member], ['id' => $notAMember]], $rows);
-		$result->closeCursor();
-
-		/** @var IOutput | \PHPUnit\Framework\MockObject\MockObject $outputMock */
-		$outputMock = $this->getMockBuilder('\OCP\Migration\IOutput')
-			->disableOriginalConstructor()
-			->getMock();
-
-		$repair->run($outputMock);
-
-		$query = $this->connection->getQueryBuilder();
-		$result = $query->select('id')
-			->from('share')
-			->orderBy('id', 'ASC')
-			->executeQuery();
-		$rows = $result->fetchAllAssociative();
-		$this->assertEquals([['id' => $parent], ['id' => $group2], ['id' => $user1], ['id' => $member]], $rows);
-		$result->closeCursor();
-	}
-
-	/**
-	 * @param string $shareType
-	 * @param string $shareWith
-	 * @param null|int $parent
-	 * @return int
-	 */
-	protected function createShare($shareType, $shareWith, $parent) {
-		$qb = $this->connection->getQueryBuilder();
-		$shareValues = [
-			'share_type' => $qb->expr()->literal($shareType),
-			'share_with' => $qb->expr()->literal($shareWith),
-			'uid_owner' => $qb->expr()->literal('user1'),
-			'item_type' => $qb->expr()->literal('folder'),
-			'item_source' => $qb->expr()->literal(123),
-			'item_target' => $qb->expr()->literal('/123'),
-			'file_source' => $qb->expr()->literal(123),
-			'file_target' => $qb->expr()->literal('/test'),
-			'permissions' => $qb->expr()->literal(1),
-			'stime' => $qb->expr()->literal(time()),
-			'expiration' => $qb->expr()->literal('2015-09-25 00:00:00'),
-		];
-
-		if ($parent) {
-			$shareValues['parent'] = $qb->expr()->literal($parent);
-		}
-
-		$qb = $this->connection->getQueryBuilder();
-		$qb->insert('share')
-			->values($shareValues)
-			->executeStatement();
-
-		return $qb->getLastInsertId();
-	}
+    private IDBConnection $connection;
+    private IGroupManager&MockObject $groupManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->groupManager = $this->getMockBuilder(IGroupManager::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->connection = Server::get(IDBConnection::class);
+
+        $this->deleteAllShares();
+    }
+
+    protected function tearDown(): void {
+        $this->deleteAllShares();
+
+        parent::tearDown();
+    }
+
+    protected function deleteAllShares() {
+        $qb = $this->connection->getQueryBuilder();
+        $qb->delete('share')->executeStatement();
+    }
+
+    public function testRun(): void {
+        $repair = new OldGroupMembershipShares(
+            $this->connection,
+            $this->groupManager
+        );
+
+        $this->groupManager->expects($this->exactly(2))
+            ->method('isInGroup')
+            ->willReturnMap([
+                ['member', 'group', true],
+                ['not-a-member', 'group', false],
+            ]);
+
+        $parent = $this->createShare(IShare::TYPE_GROUP, 'group', null);
+        $group2 = $this->createShare(IShare::TYPE_GROUP, 'group2', $parent);
+        $user1 = $this->createShare(IShare::TYPE_USER, 'user1', $parent);
+
+        // \OC\Share\Constant::$shareTypeGroupUserUnique === 2
+        $member = $this->createShare(2, 'member', $parent);
+        $notAMember = $this->createShare(2, 'not-a-member', $parent);
+
+        $query = $this->connection->getQueryBuilder();
+        $result = $query->select('id')
+            ->from('share')
+            ->orderBy('id', 'ASC')
+            ->executeQuery();
+        $rows = $result->fetchAllAssociative();
+        $this->assertEquals([['id' => $parent], ['id' => $group2], ['id' => $user1], ['id' => $member], ['id' => $notAMember]], $rows);
+        $result->closeCursor();
+
+        /** @var IOutput | \PHPUnit\Framework\MockObject\MockObject $outputMock */
+        $outputMock = $this->getMockBuilder('\OCP\Migration\IOutput')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $repair->run($outputMock);
+
+        $query = $this->connection->getQueryBuilder();
+        $result = $query->select('id')
+            ->from('share')
+            ->orderBy('id', 'ASC')
+            ->executeQuery();
+        $rows = $result->fetchAllAssociative();
+        $this->assertEquals([['id' => $parent], ['id' => $group2], ['id' => $user1], ['id' => $member]], $rows);
+        $result->closeCursor();
+    }
+
+    /**
+     * @param string $shareType
+     * @param string $shareWith
+     * @param null|int $parent
+     * @return int
+     */
+    protected function createShare($shareType, $shareWith, $parent) {
+        $qb = $this->connection->getQueryBuilder();
+        $shareValues = [
+            'share_type' => $qb->expr()->literal($shareType),
+            'share_with' => $qb->expr()->literal($shareWith),
+            'uid_owner' => $qb->expr()->literal('user1'),
+            'item_type' => $qb->expr()->literal('folder'),
+            'item_source' => $qb->expr()->literal(123),
+            'item_target' => $qb->expr()->literal('/123'),
+            'file_source' => $qb->expr()->literal(123),
+            'file_target' => $qb->expr()->literal('/test'),
+            'permissions' => $qb->expr()->literal(1),
+            'stime' => $qb->expr()->literal(time()),
+            'expiration' => $qb->expr()->literal('2015-09-25 00:00:00'),
+        ];
+
+        if ($parent) {
+            $shareValues['parent'] = $qb->expr()->literal($parent);
+        }
+
+        $qb = $this->connection->getQueryBuilder();
+        $qb->insert('share')
+            ->values($shareValues)
+            ->executeStatement();
+
+        return $qb->getLastInsertId();
+    }
 }

tests/lib/Repair/Owncloud/UpdateLanguageCodesTest.php

Indentation +128 added lines, -128 removed lines

@@ -25,132 +25,132 @@
 #[\PHPUnit\Framework\Attributes\Group('DB')]
 class UpdateLanguageCodesTest extends TestCase {
 
-	protected IDBConnection $connection;
-	private IConfig&MockObject $config;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->connection = Server::get(IDBConnection::class);
-		$this->config = $this->createMock(IConfig::class);
-	}
-
-	public function testRun(): void {
-		$users = [
-			['userid' => 'user1', 'configvalue' => 'fi_FI'],
-			['userid' => 'user2', 'configvalue' => 'de'],
-			['userid' => 'user3', 'configvalue' => 'fi'],
-			['userid' => 'user4', 'configvalue' => 'ja'],
-			['userid' => 'user5', 'configvalue' => 'bg_BG'],
-			['userid' => 'user6', 'configvalue' => 'ja'],
-			['userid' => 'user7', 'configvalue' => 'th_TH'],
-			['userid' => 'user8', 'configvalue' => 'th_TH'],
-		];
-
-		// insert test data
-		$qb = $this->connection->getQueryBuilder();
-		$qb->insert('preferences')
-			->values([
-				'userid' => $qb->createParameter('userid'),
-				'appid' => $qb->createParameter('appid'),
-				'configkey' => $qb->createParameter('configkey'),
-				'configvalue' => $qb->createParameter('configvalue'),
-			]);
-		foreach ($users as $user) {
-			$qb->setParameters([
-				'userid' => $user['userid'],
-				'appid' => 'core',
-				'configkey' => 'lang',
-				'configvalue' => $user['configvalue'],
-			])->executeStatement();
-		}
-
-		// check if test data is written to DB
-		$qb = $this->connection->getQueryBuilder();
-		$result = $qb->select(['userid', 'configvalue'])
-			->from('preferences')
-			->where($qb->expr()->eq('appid', $qb->createNamedParameter('core')))
-			->andWhere($qb->expr()->eq('configkey', $qb->createNamedParameter('lang')))
-			->orderBy('userid')
-			->executeQuery();
-
-		$rows = $result->fetchAllAssociative();
-		$result->closeCursor();
-
-		$this->assertSame($users, $rows, 'Asserts that the entries are the ones from the test data set');
-
-		$expectedOutput = [
-			['Changed 1 setting(s) from "bg_BG" to "bg" in preferences table.'],
-			['Changed 0 setting(s) from "cs_CZ" to "cs" in preferences table.'],
-			['Changed 1 setting(s) from "fi_FI" to "fi" in preferences table.'],
-			['Changed 0 setting(s) from "hu_HU" to "hu" in preferences table.'],
-			['Changed 0 setting(s) from "nb_NO" to "nb" in preferences table.'],
-			['Changed 0 setting(s) from "sk_SK" to "sk" in preferences table.'],
-			['Changed 2 setting(s) from "th_TH" to "th" in preferences table.'],
-		];
-		$outputMessages = [];
-		/** @var IOutput&MockObject $outputMock */
-		$outputMock = $this->createMock(IOutput::class);
-		$outputMock->expects($this->exactly(7))
-			->method('info')
-			->willReturnCallback(function () use (&$outputMessages): void {
-				$outputMessages[] = func_get_args();
-			});
-
-		$this->config->expects($this->once())
-			->method('getSystemValueString')
-			->with('version', '0.0.0')
-			->willReturn('12.0.0.13');
-
-		// run repair step
-		$repair = new UpdateLanguageCodes($this->connection, $this->config);
-		$repair->run($outputMock);
-
-		// check if test data is correctly modified in DB
-		$qb = $this->connection->getQueryBuilder();
-		$result = $qb->select(['userid', 'configvalue'])
-			->from('preferences')
-			->where($qb->expr()->eq('appid', $qb->createNamedParameter('core')))
-			->andWhere($qb->expr()->eq('configkey', $qb->createNamedParameter('lang')))
-			->orderBy('userid')
-			->executeQuery();
-
-		$rows = $result->fetchAllAssociative();
-		$result->closeCursor();
-
-		// value has changed for one user
-		$users[0]['configvalue'] = 'fi';
-		$users[4]['configvalue'] = 'bg';
-		$users[6]['configvalue'] = 'th';
-		$users[7]['configvalue'] = 'th';
-		$this->assertSame($users, $rows, 'Asserts that the entries are updated correctly.');
-
-		// remove test data
-		foreach ($users as $user) {
-			$qb = $this->connection->getQueryBuilder();
-			$qb->delete('preferences')
-				->where($qb->expr()->eq('userid', $qb->createNamedParameter($user['userid'])))
-				->andWhere($qb->expr()->eq('appid', $qb->createNamedParameter('core')))
-				->andWhere($qb->expr()->eq('configkey', $qb->createNamedParameter('lang')))
-				->andWhere($qb->expr()->eq('configvalue', $qb->createNamedParameter($user['configvalue']), IQueryBuilder::PARAM_STR))
-				->executeStatement();
-		}
-		self::assertEquals($expectedOutput, $outputMessages);
-	}
-
-	public function testSecondRun(): void {
-		/** @var IOutput&MockObject $outputMock */
-		$outputMock = $this->createMock(IOutput::class);
-		$outputMock->expects($this->never())
-			->method('info');
-
-		$this->config->expects($this->once())
-			->method('getSystemValueString')
-			->with('version', '0.0.0')
-			->willReturn('12.0.0.14');
-
-		// run repair step
-		$repair = new UpdateLanguageCodes($this->connection, $this->config);
-		$repair->run($outputMock);
-	}
+    protected IDBConnection $connection;
+    private IConfig&MockObject $config;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->connection = Server::get(IDBConnection::class);
+        $this->config = $this->createMock(IConfig::class);
+    }
+
+    public function testRun(): void {
+        $users = [
+            ['userid' => 'user1', 'configvalue' => 'fi_FI'],
+            ['userid' => 'user2', 'configvalue' => 'de'],
+            ['userid' => 'user3', 'configvalue' => 'fi'],
+            ['userid' => 'user4', 'configvalue' => 'ja'],
+            ['userid' => 'user5', 'configvalue' => 'bg_BG'],
+            ['userid' => 'user6', 'configvalue' => 'ja'],
+            ['userid' => 'user7', 'configvalue' => 'th_TH'],
+            ['userid' => 'user8', 'configvalue' => 'th_TH'],
+        ];
+
+        // insert test data
+        $qb = $this->connection->getQueryBuilder();
+        $qb->insert('preferences')
+            ->values([
+                'userid' => $qb->createParameter('userid'),
+                'appid' => $qb->createParameter('appid'),
+                'configkey' => $qb->createParameter('configkey'),
+                'configvalue' => $qb->createParameter('configvalue'),
+            ]);
+        foreach ($users as $user) {
+            $qb->setParameters([
+                'userid' => $user['userid'],
+                'appid' => 'core',
+                'configkey' => 'lang',
+                'configvalue' => $user['configvalue'],
+            ])->executeStatement();
+        }
+
+        // check if test data is written to DB
+        $qb = $this->connection->getQueryBuilder();
+        $result = $qb->select(['userid', 'configvalue'])
+            ->from('preferences')
+            ->where($qb->expr()->eq('appid', $qb->createNamedParameter('core')))
+            ->andWhere($qb->expr()->eq('configkey', $qb->createNamedParameter('lang')))
+            ->orderBy('userid')
+            ->executeQuery();
+
+        $rows = $result->fetchAllAssociative();
+        $result->closeCursor();
+
+        $this->assertSame($users, $rows, 'Asserts that the entries are the ones from the test data set');
+
+        $expectedOutput = [
+            ['Changed 1 setting(s) from "bg_BG" to "bg" in preferences table.'],
+            ['Changed 0 setting(s) from "cs_CZ" to "cs" in preferences table.'],
+            ['Changed 1 setting(s) from "fi_FI" to "fi" in preferences table.'],
+            ['Changed 0 setting(s) from "hu_HU" to "hu" in preferences table.'],
+            ['Changed 0 setting(s) from "nb_NO" to "nb" in preferences table.'],
+            ['Changed 0 setting(s) from "sk_SK" to "sk" in preferences table.'],
+            ['Changed 2 setting(s) from "th_TH" to "th" in preferences table.'],
+        ];
+        $outputMessages = [];
+        /** @var IOutput&MockObject $outputMock */
+        $outputMock = $this->createMock(IOutput::class);
+        $outputMock->expects($this->exactly(7))
+            ->method('info')
+            ->willReturnCallback(function () use (&$outputMessages): void {
+                $outputMessages[] = func_get_args();
+            });
+
+        $this->config->expects($this->once())
+            ->method('getSystemValueString')
+            ->with('version', '0.0.0')
+            ->willReturn('12.0.0.13');
+
+        // run repair step
+        $repair = new UpdateLanguageCodes($this->connection, $this->config);
+        $repair->run($outputMock);
+
+        // check if test data is correctly modified in DB
+        $qb = $this->connection->getQueryBuilder();
+        $result = $qb->select(['userid', 'configvalue'])
+            ->from('preferences')
+            ->where($qb->expr()->eq('appid', $qb->createNamedParameter('core')))
+            ->andWhere($qb->expr()->eq('configkey', $qb->createNamedParameter('lang')))
+            ->orderBy('userid')
+            ->executeQuery();
+
+        $rows = $result->fetchAllAssociative();
+        $result->closeCursor();
+
+        // value has changed for one user
+        $users[0]['configvalue'] = 'fi';
+        $users[4]['configvalue'] = 'bg';
+        $users[6]['configvalue'] = 'th';
+        $users[7]['configvalue'] = 'th';
+        $this->assertSame($users, $rows, 'Asserts that the entries are updated correctly.');
+
+        // remove test data
+        foreach ($users as $user) {
+            $qb = $this->connection->getQueryBuilder();
+            $qb->delete('preferences')
+                ->where($qb->expr()->eq('userid', $qb->createNamedParameter($user['userid'])))
+                ->andWhere($qb->expr()->eq('appid', $qb->createNamedParameter('core')))
+                ->andWhere($qb->expr()->eq('configkey', $qb->createNamedParameter('lang')))
+                ->andWhere($qb->expr()->eq('configvalue', $qb->createNamedParameter($user['configvalue']), IQueryBuilder::PARAM_STR))
+                ->executeStatement();
+        }
+        self::assertEquals($expectedOutput, $outputMessages);
+    }
+
+    public function testSecondRun(): void {
+        /** @var IOutput&MockObject $outputMock */
+        $outputMock = $this->createMock(IOutput::class);
+        $outputMock->expects($this->never())
+            ->method('info');
+
+        $this->config->expects($this->once())
+            ->method('getSystemValueString')
+            ->with('version', '0.0.0')
+            ->willReturn('12.0.0.14');
+
+        // run repair step
+        $repair = new UpdateLanguageCodes($this->connection, $this->config);
+        $repair->run($outputMock);
+    }
 }

tests/lib/Repair/RepairInvalidSharesTest.php

Indentation +162 added lines, -162 removed lines

@@ -26,166 +26,166 @@
 #[\PHPUnit\Framework\Attributes\Group('DB')]
 class RepairInvalidSharesTest extends TestCase {
 
-	private RepairInvalidShares $repair;
-	private IDBConnection $connection;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$config = $this->getMockBuilder(IConfig::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$config->expects($this->any())
-			->method('getSystemValueString')
-			->with('version')
-			->willReturn('12.0.0.0');
-
-		$this->connection = Server::get(IDBConnection::class);
-		$this->deleteAllShares();
-
-		$this->repair = new RepairInvalidShares($config, $this->connection);
-	}
-
-	protected function tearDown(): void {
-		$this->deleteAllShares();
-
-		parent::tearDown();
-	}
-
-	protected function deleteAllShares() {
-		$qb = $this->connection->getQueryBuilder();
-		$qb->delete('share')->executeStatement();
-	}
-
-	/**
-	 * Test remove shares where the parent share does not exist anymore
-	 */
-	public function testSharesNonExistingParent(): void {
-		$qb = $this->connection->getQueryBuilder();
-		$shareValues = [
-			'share_type' => $qb->expr()->literal(IShare::TYPE_USER),
-			'share_with' => $qb->expr()->literal('recipientuser1'),
-			'uid_owner' => $qb->expr()->literal('user1'),
-			'item_type' => $qb->expr()->literal('folder'),
-			'item_source' => $qb->expr()->literal(123),
-			'item_target' => $qb->expr()->literal('/123'),
-			'file_source' => $qb->expr()->literal(123),
-			'file_target' => $qb->expr()->literal('/test'),
-			'permissions' => $qb->expr()->literal(1),
-			'stime' => $qb->expr()->literal(time()),
-			'expiration' => $qb->expr()->literal('2015-09-25 00:00:00')
-		];
-
-		// valid share
-		$qb = $this->connection->getQueryBuilder();
-		$qb->insert('share')
-			->values($shareValues)
-			->executeStatement();
-		$parent = $qb->getLastInsertId();
-
-		// share with existing parent
-		$qb = $this->connection->getQueryBuilder();
-		$qb->insert('share')
-			->values(array_merge($shareValues, [
-				'parent' => $qb->expr()->literal($parent),
-			]))->executeStatement();
-		$validChild = $qb->getLastInsertId();
-
-		// share with non-existing parent
-		$qb = $this->connection->getQueryBuilder();
-		$qb->insert('share')
-			->values(array_merge($shareValues, [
-				'parent' => $qb->expr()->literal($parent + 100),
-			]))->executeStatement();
-		$invalidChild = $qb->getLastInsertId();
-
-		$query = $this->connection->getQueryBuilder();
-		$result = $query->select('id')
-			->from('share')
-			->orderBy('id', 'ASC')
-			->executeQuery();
-		$rows = $result->fetchAllAssociative();
-		$this->assertEquals([['id' => $parent], ['id' => $validChild], ['id' => $invalidChild]], $rows);
-		$result->closeCursor();
-
-		/** @var IOutput | \PHPUnit\Framework\MockObject\MockObject $outputMock */
-		$outputMock = $this->getMockBuilder('\OCP\Migration\IOutput')
-			->disableOriginalConstructor()
-			->getMock();
-
-		$this->repair->run($outputMock);
-
-		$query = $this->connection->getQueryBuilder();
-		$result = $query->select('id')
-			->from('share')
-			->orderBy('id', 'ASC')
-			->executeQuery();
-		$rows = $result->fetchAllAssociative();
-		$this->assertEquals([['id' => $parent], ['id' => $validChild]], $rows);
-		$result->closeCursor();
-	}
-
-	public static function fileSharePermissionsProvider(): array {
-		return [
-			// unchanged for folder
-			[
-				'folder',
-				31,
-				31,
-			],
-			// unchanged for read-write + share
-			[
-				'file',
-				Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE | Constants::PERMISSION_SHARE,
-				Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE | Constants::PERMISSION_SHARE,
-			],
-			// fixed for all perms
-			[
-				'file',
-				Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE | Constants::PERMISSION_SHARE,
-				Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE | Constants::PERMISSION_SHARE,
-			],
-		];
-	}
-
-	/**
-	 * Test adjusting file share permissions
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('fileSharePermissionsProvider')]
-	public function testFileSharePermissions($itemType, $testPerms, $expectedPerms): void {
-		$qb = $this->connection->getQueryBuilder();
-		$qb->insert('share')
-			->values([
-				'share_type' => $qb->expr()->literal(IShare::TYPE_LINK),
-				'uid_owner' => $qb->expr()->literal('user1'),
-				'item_type' => $qb->expr()->literal($itemType),
-				'item_source' => $qb->expr()->literal(123),
-				'item_target' => $qb->expr()->literal('/123'),
-				'file_source' => $qb->expr()->literal(123),
-				'file_target' => $qb->expr()->literal('/test'),
-				'permissions' => $qb->expr()->literal($testPerms),
-				'stime' => $qb->expr()->literal(time()),
-			])
-			->executeStatement();
-
-		/** @var IOutput | \PHPUnit\Framework\MockObject\MockObject $outputMock */
-		$outputMock = $this->getMockBuilder('\OCP\Migration\IOutput')
-			->disableOriginalConstructor()
-			->getMock();
-
-		$this->repair->run($outputMock);
-
-		$results = $this->connection->getQueryBuilder()
-			->select('*')
-			->from('share')
-			->orderBy('permissions', 'ASC')
-			->executeQuery()
-			->fetchAllAssociative();
-
-		$this->assertCount(1, $results);
-
-		$updatedShare = $results[0];
-
-		$this->assertEquals($expectedPerms, $updatedShare['permissions']);
-	}
+    private RepairInvalidShares $repair;
+    private IDBConnection $connection;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $config = $this->getMockBuilder(IConfig::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $config->expects($this->any())
+            ->method('getSystemValueString')
+            ->with('version')
+            ->willReturn('12.0.0.0');
+
+        $this->connection = Server::get(IDBConnection::class);
+        $this->deleteAllShares();
+
+        $this->repair = new RepairInvalidShares($config, $this->connection);
+    }
+
+    protected function tearDown(): void {
+        $this->deleteAllShares();
+
+        parent::tearDown();
+    }
+
+    protected function deleteAllShares() {
+        $qb = $this->connection->getQueryBuilder();
+        $qb->delete('share')->executeStatement();
+    }
+
+    /**
+     * Test remove shares where the parent share does not exist anymore
+     */
+    public function testSharesNonExistingParent(): void {
+        $qb = $this->connection->getQueryBuilder();
+        $shareValues = [
+            'share_type' => $qb->expr()->literal(IShare::TYPE_USER),
+            'share_with' => $qb->expr()->literal('recipientuser1'),
+            'uid_owner' => $qb->expr()->literal('user1'),
+            'item_type' => $qb->expr()->literal('folder'),
+            'item_source' => $qb->expr()->literal(123),
+            'item_target' => $qb->expr()->literal('/123'),
+            'file_source' => $qb->expr()->literal(123),
+            'file_target' => $qb->expr()->literal('/test'),
+            'permissions' => $qb->expr()->literal(1),
+            'stime' => $qb->expr()->literal(time()),
+            'expiration' => $qb->expr()->literal('2015-09-25 00:00:00')
+        ];
+
+        // valid share
+        $qb = $this->connection->getQueryBuilder();
+        $qb->insert('share')
+            ->values($shareValues)
+            ->executeStatement();
+        $parent = $qb->getLastInsertId();
+
+        // share with existing parent
+        $qb = $this->connection->getQueryBuilder();
+        $qb->insert('share')
+            ->values(array_merge($shareValues, [
+                'parent' => $qb->expr()->literal($parent),
+            ]))->executeStatement();
+        $validChild = $qb->getLastInsertId();
+
+        // share with non-existing parent
+        $qb = $this->connection->getQueryBuilder();
+        $qb->insert('share')
+            ->values(array_merge($shareValues, [
+                'parent' => $qb->expr()->literal($parent + 100),
+            ]))->executeStatement();
+        $invalidChild = $qb->getLastInsertId();
+
+        $query = $this->connection->getQueryBuilder();
+        $result = $query->select('id')
+            ->from('share')
+            ->orderBy('id', 'ASC')
+            ->executeQuery();
+        $rows = $result->fetchAllAssociative();
+        $this->assertEquals([['id' => $parent], ['id' => $validChild], ['id' => $invalidChild]], $rows);
+        $result->closeCursor();
+
+        /** @var IOutput | \PHPUnit\Framework\MockObject\MockObject $outputMock */
+        $outputMock = $this->getMockBuilder('\OCP\Migration\IOutput')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $this->repair->run($outputMock);
+
+        $query = $this->connection->getQueryBuilder();
+        $result = $query->select('id')
+            ->from('share')
+            ->orderBy('id', 'ASC')
+            ->executeQuery();
+        $rows = $result->fetchAllAssociative();
+        $this->assertEquals([['id' => $parent], ['id' => $validChild]], $rows);
+        $result->closeCursor();
+    }
+
+    public static function fileSharePermissionsProvider(): array {
+        return [
+            // unchanged for folder
+            [
+                'folder',
+                31,
+                31,
+            ],
+            // unchanged for read-write + share
+            [
+                'file',
+                Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE | Constants::PERMISSION_SHARE,
+                Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE | Constants::PERMISSION_SHARE,
+            ],
+            // fixed for all perms
+            [
+                'file',
+                Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE | Constants::PERMISSION_SHARE,
+                Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE | Constants::PERMISSION_SHARE,
+            ],
+        ];
+    }
+
+    /**
+     * Test adjusting file share permissions
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('fileSharePermissionsProvider')]
+    public function testFileSharePermissions($itemType, $testPerms, $expectedPerms): void {
+        $qb = $this->connection->getQueryBuilder();
+        $qb->insert('share')
+            ->values([
+                'share_type' => $qb->expr()->literal(IShare::TYPE_LINK),
+                'uid_owner' => $qb->expr()->literal('user1'),
+                'item_type' => $qb->expr()->literal($itemType),
+                'item_source' => $qb->expr()->literal(123),
+                'item_target' => $qb->expr()->literal('/123'),
+                'file_source' => $qb->expr()->literal(123),
+                'file_target' => $qb->expr()->literal('/test'),
+                'permissions' => $qb->expr()->literal($testPerms),
+                'stime' => $qb->expr()->literal(time()),
+            ])
+            ->executeStatement();
+
+        /** @var IOutput | \PHPUnit\Framework\MockObject\MockObject $outputMock */
+        $outputMock = $this->getMockBuilder('\OCP\Migration\IOutput')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $this->repair->run($outputMock);
+
+        $results = $this->connection->getQueryBuilder()
+            ->select('*')
+            ->from('share')
+            ->orderBy('permissions', 'ASC')
+            ->executeQuery()
+            ->fetchAllAssociative();
+
+        $this->assertCount(1, $results);
+
+        $updatedShare = $results[0];
+
+        $this->assertEquals($expectedPerms, $updatedShare['permissions']);
+    }
 }

tests/lib/Calendar/ResourcesRoomsUpdaterTest.php

Indentation +411 added lines, -411 removed lines

@@ -25,415 +25,415 @@
 }
 
 class ResourcesRoomsUpdaterTest extends TestCase {
-	private ResourcesRoomsUpdater $updater;
-
-	/** @var IResourceManager|MockObject */
-	private $resourceManager;
-
-	/** @var IRoomManager|MockObject */
-	private $roomManager;
-
-	/** @var ContainerInterface|MockObject */
-	private $container;
-
-	/** @var CalDavBackend|MockObject */
-	private $calDavBackend;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->resourceManager = $this->createMock(IResourceManager::class);
-		$this->roomManager = $this->createMock(IRoomManager::class);
-		$this->container = $this->createMock(ContainerInterface::class);
-		$this->calDavBackend = $this->createMock(CalDavBackend::class);
-
-		$this->container->method('get')
-			->willReturnMap([
-				[IResourceManager::class, $this->resourceManager],
-				[IRoomManager::class, $this->roomManager],
-			]);
-
-		$this->updater = new ResourcesRoomsUpdater(
-			$this->container,
-			self::$realDatabase,
-			$this->calDavBackend
-		);
-	}
-
-	protected function tearDown(): void {
-		$query = self::$realDatabase->getQueryBuilder();
-		$query->delete('calendar_resources')->executeStatement();
-		$query->delete('calendar_resources_md')->executeStatement();
-		$query->delete('calendar_rooms')->executeStatement();
-		$query->delete('calendar_rooms_md')->executeStatement();
-	}
-
-	/**
-	 * Data in Cache:
-	 * resources:
-	 *  [backend1, res1, Beamer1, {}] - []
-	 *  [backend1, res2, TV1, {}] - []
-	 *  [backend2, res3, Beamer2, {}] - ['meta1' => 'value1', 'meta2' => 'value2']
-	 *  [backend2, res4, TV2, {}] - ['meta1' => 'value1', 'meta3' => 'value3-old']
-	 *  [backend3, res5, Beamer3, {}] - []
-	 *  [backend3, res6, Pointer, {foo, bar}] - ['meta99' => 'value99']
-	 *
-	 * Data in Backend:
-	 *  backend1 gone
-	 *  backend2 throws BackendTemporarilyUnavailableException
-	 *  [backend3, res6, Pointer123, {foo, biz}] - ['meta99' => 'value99-new', 'meta123' => 'meta456']
-	 *  [backend3, res7, Resource4, {biz}] - ['meta1' => 'value1']
-	 *  [backend4, res8, Beamer, {}] - ['meta2' => 'value2']
-	 *  [backend4, res9, Beamer2, {}] - []
-	 *
-	 * Expected after run:
-	 * 	[backend1, res1, Beamer1, {}] - []
-	 *  [backend1, res2, TV1, {}] - []
-	 *  [backend2, res3, Beamer2, {}] - ['meta1' => 'value1', 'meta2' => 'value2']
-	 *  [backend2, res4, TV2, {}] - ['meta1' => 'value1', 'meta3' => 'value3-old']
-	 *  [backend3, res6, Pointer123, {foo, biz}]  - ['meta99' => 'value99-new', 'meta123' => 'meta456']
-	 *  [backend3, res7, Resource4, {biz}] - ['meta1' => 'value1']
-	 *  [backend4, res8, Beamer, {}] - ['meta2' => 'value2']
-	 *  [backend4, res9, Beamer2, {}] - []
-	 */
-
-	public function testUpdateBoth(): void {
-		$this->createTestResourcesInCache();
-
-		$backend2 = $this->createMock(IBackend::class);
-		$backend3 = $this->createMock(IBackend::class);
-		$backend4 = $this->createMock(IBackend::class);
-
-		$res6 = $this->createMock(tmpI::class);
-		$res7 = $this->createMock(tmpI::class);
-		$res8 = $this->createMock(tmpI::class);
-		$res9 = $this->createMock(IResource::class);
-
-		$backend2->method('getBackendIdentifier')
-			->willReturn('backend2');
-		$backend2->method('listAllResources')
-			->willThrowException(new BackendTemporarilyUnavailableException());
-		$backend2->method('getResource')
-			->willThrowException(new BackendTemporarilyUnavailableException());
-		$backend2->method('getAllResources')
-			->willThrowException(new BackendTemporarilyUnavailableException());
-		$backend3->method('getBackendIdentifier')
-			->willReturn('backend3');
-		$backend3->method('listAllResources')
-			->willReturn(['res6', 'res7']);
-		$backend3->method('getResource')
-			->willReturnMap([
-				['res6', $res6],
-				['res7', $res7],
-			]);
-		$backend4->method('getBackendIdentifier')
-			->willReturn('backend4');
-		$backend4->method('listAllResources')
-			->willReturn(['res8', 'res9']);
-		$backend4->method('getResource')
-			->willReturnMap([
-				['res8', $res8],
-				['res9', $res9],
-			]);
-
-		$res6->method('getId')->willReturn('res6');
-		$res6->method('getDisplayName')->willReturn('Pointer123');
-		$res6->method('getGroupRestrictions')->willReturn(['foo', 'biz']);
-		$res6->method('getEMail')->willReturn('res6@foo.bar');
-		$res6->method('getBackend')->willReturn($backend3);
-
-		$res6->method('getAllAvailableMetadataKeys')->willReturn(['meta99', 'meta123']);
-		$res6->method('getMetadataForKey')->willReturnCallback(function ($key) {
-			switch ($key) {
-				case 'meta99':
-					return 'value99-new';
-
-				case 'meta123':
-					return 'meta456';
-
-				default:
-					return null;
-			}
-		});
-
-		$res7->method('getId')->willReturn('res7');
-		$res7->method('getDisplayName')->willReturn('Resource4');
-		$res7->method('getGroupRestrictions')->willReturn(['biz']);
-		$res7->method('getEMail')->willReturn('res7@foo.bar');
-		$res7->method('getBackend')->willReturn($backend3);
-		$res7->method('getAllAvailableMetadataKeys')->willReturn(['meta1']);
-		$res7->method('getMetadataForKey')->willReturnCallback(function ($key) {
-			switch ($key) {
-				case 'meta1':
-					return 'value1';
-
-				default:
-					return null;
-			}
-		});
-
-		$res8->method('getId')->willReturn('res8');
-		$res8->method('getDisplayName')->willReturn('Beamer');
-		$res8->method('getGroupRestrictions')->willReturn([]);
-		$res8->method('getEMail')->willReturn('res8@foo.bar');
-		$res8->method('getBackend')->willReturn($backend4);
-		$res8->method('getAllAvailableMetadataKeys')->willReturn(['meta2']);
-		$res8->method('getMetadataForKey')->willReturnCallback(function ($key) {
-			switch ($key) {
-				case 'meta2':
-					return 'value2';
-
-				default:
-					return null;
-			}
-		});
-
-		$res9->method('getId')->willReturn('res9');
-		$res9->method('getDisplayName')->willReturn('Beamer2');
-		$res9->method('getGroupRestrictions')->willReturn([]);
-		$res9->method('getEMail')->willReturn('res9@foo.bar');
-		$res9->method('getBackend')->willReturn($backend4);
-
-		$this->resourceManager
-			->method('getBackends')
-			->willReturn([
-				$backend2, $backend3, $backend4
-			]);
-		$this->resourceManager
-			->method('getBackend')
-			->willReturnMap([
-				['backend2', $backend2],
-				['backend3', $backend3],
-				['backend4', $backend4],
-			]);
-
-		$this->updater->updateResources();
-		$this->updater->updateRooms();
-
-		$query = self::$realDatabase->getQueryBuilder();
-		$query->select('*')->from('calendar_resources');
-
-		$rows = [];
-		$ids = [];
-		$stmt = $query->executeQuery();
-		while ($row = $stmt->fetchAssociative()) {
-			$ids[$row['backend_id'] . '::' . $row['resource_id']] = $row['id'];
-			unset($row['id']);
-			$rows[] = $row;
-		}
-
-		$this->assertEquals([
-			[
-				'backend_id' => 'backend1',
-				'resource_id' => 'res1',
-				'displayname' => 'Beamer1',
-				'email' => 'res1@foo.bar',
-				'group_restrictions' => '[]',
-			],
-			[
-				'backend_id' => 'backend1',
-				'resource_id' => 'res2',
-				'displayname' => 'TV1',
-				'email' => 'res2@foo.bar',
-				'group_restrictions' => '[]',
-			],
-			[
-				'backend_id' => 'backend2',
-				'resource_id' => 'res3',
-				'displayname' => 'Beamer2',
-				'email' => 'res3@foo.bar',
-				'group_restrictions' => '[]',
-			],
-			[
-				'backend_id' => 'backend2',
-				'resource_id' => 'res4',
-				'displayname' => 'TV2',
-				'email' => 'res4@foo.bar',
-				'group_restrictions' => '[]',
-			],
-			[
-				'backend_id' => 'backend3',
-				'resource_id' => 'res6',
-				'displayname' => 'Pointer123',
-				'email' => 'res6@foo.bar',
-				'group_restrictions' => '["foo","biz"]',
-			],
-			[
-				'backend_id' => 'backend3',
-				'resource_id' => 'res7',
-				'displayname' => 'Resource4',
-				'email' => 'res7@foo.bar',
-				'group_restrictions' => '["biz"]',
-			],
-			[
-				'backend_id' => 'backend4',
-				'resource_id' => 'res8',
-				'displayname' => 'Beamer',
-				'email' => 'res8@foo.bar',
-				'group_restrictions' => '[]',
-			],
-			[
-				'backend_id' => 'backend4',
-				'resource_id' => 'res9',
-				'displayname' => 'Beamer2',
-				'email' => 'res9@foo.bar',
-				'group_restrictions' => '[]',
-			],
-		], $rows);
-
-		$query2 = self::$realDatabase->getQueryBuilder();
-		$query2->select('*')->from('calendar_resources_md');
-
-		$rows2 = [];
-		$stmt = $query2->executeQuery();
-		while ($row = $stmt->fetchAssociative()) {
-			unset($row['id']);
-			$rows2[] = $row;
-		}
-
-		$this->assertEquals([
-			[
-				'resource_id' => $ids['backend2::res3'],
-				'key' => 'meta1',
-				'value' => 'value1',
-			],
-			[
-				'resource_id' => $ids['backend2::res3'],
-				'key' => 'meta2',
-				'value' => 'value2',
-			],
-			[
-				'resource_id' => $ids['backend2::res4'],
-				'key' => 'meta1',
-				'value' => 'value1',
-			],
-			[
-				'resource_id' => $ids['backend2::res4'],
-				'key' => 'meta3',
-				'value' => 'value3-old',
-			],
-			[
-				'resource_id' => $ids['backend3::res6'],
-				'key' => 'meta99',
-				'value' => 'value99-new',
-			],
-			[
-				'resource_id' => $ids['backend3::res7'],
-				'key' => 'meta1',
-				'value' => 'value1',
-			],
-			[
-				'resource_id' => $ids['backend3::res6'],
-				'key' => 'meta123',
-				'value' => 'meta456',
-			],
-			[
-				'resource_id' => $ids['backend4::res8'],
-				'key' => 'meta2',
-				'value' => 'value2',
-			]
-		], $rows2);
-	}
-
-	protected function createTestResourcesInCache() {
-		$query = self::$realDatabase->getQueryBuilder();
-		$query->insert('calendar_resources')
-			->values([
-				'backend_id' => $query->createNamedParameter('backend1'),
-				'resource_id' => $query->createNamedParameter('res1'),
-				'email' => $query->createNamedParameter('res1@foo.bar'),
-				'displayname' => $query->createNamedParameter('Beamer1'),
-				'group_restrictions' => $query->createNamedParameter('[]'),
-			])
-			->executeStatement();
-
-		$query->insert('calendar_resources')
-			->values([
-				'backend_id' => $query->createNamedParameter('backend1'),
-				'resource_id' => $query->createNamedParameter('res2'),
-				'email' => $query->createNamedParameter('res2@foo.bar'),
-				'displayname' => $query->createNamedParameter('TV1'),
-				'group_restrictions' => $query->createNamedParameter('[]'),
-			])
-			->executeStatement();
-
-		$query->insert('calendar_resources')
-			->values([
-				'backend_id' => $query->createNamedParameter('backend2'),
-				'resource_id' => $query->createNamedParameter('res3'),
-				'email' => $query->createNamedParameter('res3@foo.bar'),
-				'displayname' => $query->createNamedParameter('Beamer2'),
-				'group_restrictions' => $query->createNamedParameter('[]'),
-			])
-			->executeStatement();
-		$id3 = $query->getLastInsertId();
-
-		$query->insert('calendar_resources')
-			->values([
-				'backend_id' => $query->createNamedParameter('backend2'),
-				'resource_id' => $query->createNamedParameter('res4'),
-				'email' => $query->createNamedParameter('res4@foo.bar'),
-				'displayname' => $query->createNamedParameter('TV2'),
-				'group_restrictions' => $query->createNamedParameter('[]'),
-			])
-			->executeStatement();
-		$id4 = $query->getLastInsertId();
-
-		$query->insert('calendar_resources')
-			->values([
-				'backend_id' => $query->createNamedParameter('backend3'),
-				'resource_id' => $query->createNamedParameter('res5'),
-				'email' => $query->createNamedParameter('res5@foo.bar'),
-				'displayname' => $query->createNamedParameter('Beamer3'),
-				'group_restrictions' => $query->createNamedParameter('[]'),
-			])
-			->executeStatement();
-
-		$query->insert('calendar_resources')
-			->values([
-				'backend_id' => $query->createNamedParameter('backend3'),
-				'resource_id' => $query->createNamedParameter('res6'),
-				'email' => $query->createNamedParameter('res6@foo.bar'),
-				'displayname' => $query->createNamedParameter('Pointer'),
-				'group_restrictions' => $query->createNamedParameter('["foo", "bar"]'),
-			])
-			->executeStatement();
-		$id6 = $query->getLastInsertId();
-
-		$query->insert('calendar_resources_md')
-			->values([
-				'resource_id' => $query->createNamedParameter($id3),
-				'key' => $query->createNamedParameter('meta1'),
-				'value' => $query->createNamedParameter('value1')
-			])
-			->executeStatement();
-		$query->insert('calendar_resources_md')
-			->values([
-				'resource_id' => $query->createNamedParameter($id3),
-				'key' => $query->createNamedParameter('meta2'),
-				'value' => $query->createNamedParameter('value2')
-			])
-			->executeStatement();
-		$query->insert('calendar_resources_md')
-			->values([
-				'resource_id' => $query->createNamedParameter($id4),
-				'key' => $query->createNamedParameter('meta1'),
-				'value' => $query->createNamedParameter('value1')
-			])
-			->executeStatement();
-		$query->insert('calendar_resources_md')
-			->values([
-				'resource_id' => $query->createNamedParameter($id4),
-				'key' => $query->createNamedParameter('meta3'),
-				'value' => $query->createNamedParameter('value3-old')
-			])
-			->executeStatement();
-		$query->insert('calendar_resources_md')
-			->values([
-				'resource_id' => $query->createNamedParameter($id6),
-				'key' => $query->createNamedParameter('meta99'),
-				'value' => $query->createNamedParameter('value99')
-			])
-			->executeStatement();
-	}
+    private ResourcesRoomsUpdater $updater;
+
+    /** @var IResourceManager|MockObject */
+    private $resourceManager;
+
+    /** @var IRoomManager|MockObject */
+    private $roomManager;
+
+    /** @var ContainerInterface|MockObject */
+    private $container;
+
+    /** @var CalDavBackend|MockObject */
+    private $calDavBackend;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->resourceManager = $this->createMock(IResourceManager::class);
+        $this->roomManager = $this->createMock(IRoomManager::class);
+        $this->container = $this->createMock(ContainerInterface::class);
+        $this->calDavBackend = $this->createMock(CalDavBackend::class);
+
+        $this->container->method('get')
+            ->willReturnMap([
+                [IResourceManager::class, $this->resourceManager],
+                [IRoomManager::class, $this->roomManager],
+            ]);
+
+        $this->updater = new ResourcesRoomsUpdater(
+            $this->container,
+            self::$realDatabase,
+            $this->calDavBackend
+        );
+    }
+
+    protected function tearDown(): void {
+        $query = self::$realDatabase->getQueryBuilder();
+        $query->delete('calendar_resources')->executeStatement();
+        $query->delete('calendar_resources_md')->executeStatement();
+        $query->delete('calendar_rooms')->executeStatement();
+        $query->delete('calendar_rooms_md')->executeStatement();
+    }
+
+    /**
+     * Data in Cache:
+     * resources:
+     *  [backend1, res1, Beamer1, {}] - []
+     *  [backend1, res2, TV1, {}] - []
+     *  [backend2, res3, Beamer2, {}] - ['meta1' => 'value1', 'meta2' => 'value2']
+     *  [backend2, res4, TV2, {}] - ['meta1' => 'value1', 'meta3' => 'value3-old']
+     *  [backend3, res5, Beamer3, {}] - []
+     *  [backend3, res6, Pointer, {foo, bar}] - ['meta99' => 'value99']
+     *
+     * Data in Backend:
+     *  backend1 gone
+     *  backend2 throws BackendTemporarilyUnavailableException
+     *  [backend3, res6, Pointer123, {foo, biz}] - ['meta99' => 'value99-new', 'meta123' => 'meta456']
+     *  [backend3, res7, Resource4, {biz}] - ['meta1' => 'value1']
+     *  [backend4, res8, Beamer, {}] - ['meta2' => 'value2']
+     *  [backend4, res9, Beamer2, {}] - []
+     *
+     * Expected after run:
+     * 	[backend1, res1, Beamer1, {}] - []
+     *  [backend1, res2, TV1, {}] - []
+     *  [backend2, res3, Beamer2, {}] - ['meta1' => 'value1', 'meta2' => 'value2']
+     *  [backend2, res4, TV2, {}] - ['meta1' => 'value1', 'meta3' => 'value3-old']
+     *  [backend3, res6, Pointer123, {foo, biz}]  - ['meta99' => 'value99-new', 'meta123' => 'meta456']
+     *  [backend3, res7, Resource4, {biz}] - ['meta1' => 'value1']
+     *  [backend4, res8, Beamer, {}] - ['meta2' => 'value2']
+     *  [backend4, res9, Beamer2, {}] - []
+     */
+
+    public function testUpdateBoth(): void {
+        $this->createTestResourcesInCache();
+
+        $backend2 = $this->createMock(IBackend::class);
+        $backend3 = $this->createMock(IBackend::class);
+        $backend4 = $this->createMock(IBackend::class);
+
+        $res6 = $this->createMock(tmpI::class);
+        $res7 = $this->createMock(tmpI::class);
+        $res8 = $this->createMock(tmpI::class);
+        $res9 = $this->createMock(IResource::class);
+
+        $backend2->method('getBackendIdentifier')
+            ->willReturn('backend2');
+        $backend2->method('listAllResources')
+            ->willThrowException(new BackendTemporarilyUnavailableException());
+        $backend2->method('getResource')
+            ->willThrowException(new BackendTemporarilyUnavailableException());
+        $backend2->method('getAllResources')
+            ->willThrowException(new BackendTemporarilyUnavailableException());
+        $backend3->method('getBackendIdentifier')
+            ->willReturn('backend3');
+        $backend3->method('listAllResources')
+            ->willReturn(['res6', 'res7']);
+        $backend3->method('getResource')
+            ->willReturnMap([
+                ['res6', $res6],
+                ['res7', $res7],
+            ]);
+        $backend4->method('getBackendIdentifier')
+            ->willReturn('backend4');
+        $backend4->method('listAllResources')
+            ->willReturn(['res8', 'res9']);
+        $backend4->method('getResource')
+            ->willReturnMap([
+                ['res8', $res8],
+                ['res9', $res9],
+            ]);
+
+        $res6->method('getId')->willReturn('res6');
+        $res6->method('getDisplayName')->willReturn('Pointer123');
+        $res6->method('getGroupRestrictions')->willReturn(['foo', 'biz']);
+        $res6->method('getEMail')->willReturn('res6@foo.bar');
+        $res6->method('getBackend')->willReturn($backend3);
+
+        $res6->method('getAllAvailableMetadataKeys')->willReturn(['meta99', 'meta123']);
+        $res6->method('getMetadataForKey')->willReturnCallback(function ($key) {
+            switch ($key) {
+                case 'meta99':
+                    return 'value99-new';
+
+                case 'meta123':
+                    return 'meta456';
+
+                default:
+                    return null;
+            }
+        });
+
+        $res7->method('getId')->willReturn('res7');
+        $res7->method('getDisplayName')->willReturn('Resource4');
+        $res7->method('getGroupRestrictions')->willReturn(['biz']);
+        $res7->method('getEMail')->willReturn('res7@foo.bar');
+        $res7->method('getBackend')->willReturn($backend3);
+        $res7->method('getAllAvailableMetadataKeys')->willReturn(['meta1']);
+        $res7->method('getMetadataForKey')->willReturnCallback(function ($key) {
+            switch ($key) {
+                case 'meta1':
+                    return 'value1';
+
+                default:
+                    return null;
+            }
+        });
+
+        $res8->method('getId')->willReturn('res8');
+        $res8->method('getDisplayName')->willReturn('Beamer');
+        $res8->method('getGroupRestrictions')->willReturn([]);
+        $res8->method('getEMail')->willReturn('res8@foo.bar');
+        $res8->method('getBackend')->willReturn($backend4);
+        $res8->method('getAllAvailableMetadataKeys')->willReturn(['meta2']);
+        $res8->method('getMetadataForKey')->willReturnCallback(function ($key) {
+            switch ($key) {
+                case 'meta2':
+                    return 'value2';
+
+                default:
+                    return null;
+            }
+        });
+
+        $res9->method('getId')->willReturn('res9');
+        $res9->method('getDisplayName')->willReturn('Beamer2');
+        $res9->method('getGroupRestrictions')->willReturn([]);
+        $res9->method('getEMail')->willReturn('res9@foo.bar');
+        $res9->method('getBackend')->willReturn($backend4);
+
+        $this->resourceManager
+            ->method('getBackends')
+            ->willReturn([
+                $backend2, $backend3, $backend4
+            ]);
+        $this->resourceManager
+            ->method('getBackend')
+            ->willReturnMap([
+                ['backend2', $backend2],
+                ['backend3', $backend3],
+                ['backend4', $backend4],
+            ]);
+
+        $this->updater->updateResources();
+        $this->updater->updateRooms();
+
+        $query = self::$realDatabase->getQueryBuilder();
+        $query->select('*')->from('calendar_resources');
+
+        $rows = [];
+        $ids = [];
+        $stmt = $query->executeQuery();
+        while ($row = $stmt->fetchAssociative()) {
+            $ids[$row['backend_id'] . '::' . $row['resource_id']] = $row['id'];
+            unset($row['id']);
+            $rows[] = $row;
+        }
+
+        $this->assertEquals([
+            [
+                'backend_id' => 'backend1',
+                'resource_id' => 'res1',
+                'displayname' => 'Beamer1',
+                'email' => 'res1@foo.bar',
+                'group_restrictions' => '[]',
+            ],
+            [
+                'backend_id' => 'backend1',
+                'resource_id' => 'res2',
+                'displayname' => 'TV1',
+                'email' => 'res2@foo.bar',
+                'group_restrictions' => '[]',
+            ],
+            [
+                'backend_id' => 'backend2',
+                'resource_id' => 'res3',
+                'displayname' => 'Beamer2',
+                'email' => 'res3@foo.bar',
+                'group_restrictions' => '[]',
+            ],
+            [
+                'backend_id' => 'backend2',
+                'resource_id' => 'res4',
+                'displayname' => 'TV2',
+                'email' => 'res4@foo.bar',
+                'group_restrictions' => '[]',
+            ],
+            [
+                'backend_id' => 'backend3',
+                'resource_id' => 'res6',
+                'displayname' => 'Pointer123',
+                'email' => 'res6@foo.bar',
+                'group_restrictions' => '["foo","biz"]',
+            ],
+            [
+                'backend_id' => 'backend3',
+                'resource_id' => 'res7',
+                'displayname' => 'Resource4',
+                'email' => 'res7@foo.bar',
+                'group_restrictions' => '["biz"]',
+            ],
+            [
+                'backend_id' => 'backend4',
+                'resource_id' => 'res8',
+                'displayname' => 'Beamer',
+                'email' => 'res8@foo.bar',
+                'group_restrictions' => '[]',
+            ],
+            [
+                'backend_id' => 'backend4',
+                'resource_id' => 'res9',
+                'displayname' => 'Beamer2',
+                'email' => 'res9@foo.bar',
+                'group_restrictions' => '[]',
+            ],
+        ], $rows);
+
+        $query2 = self::$realDatabase->getQueryBuilder();
+        $query2->select('*')->from('calendar_resources_md');
+
+        $rows2 = [];
+        $stmt = $query2->executeQuery();
+        while ($row = $stmt->fetchAssociative()) {
+            unset($row['id']);
+            $rows2[] = $row;
+        }
+
+        $this->assertEquals([
+            [
+                'resource_id' => $ids['backend2::res3'],
+                'key' => 'meta1',
+                'value' => 'value1',
+            ],
+            [
+                'resource_id' => $ids['backend2::res3'],
+                'key' => 'meta2',
+                'value' => 'value2',
+            ],
+            [
+                'resource_id' => $ids['backend2::res4'],
+                'key' => 'meta1',
+                'value' => 'value1',
+            ],
+            [
+                'resource_id' => $ids['backend2::res4'],
+                'key' => 'meta3',
+                'value' => 'value3-old',
+            ],
+            [
+                'resource_id' => $ids['backend3::res6'],
+                'key' => 'meta99',
+                'value' => 'value99-new',
+            ],
+            [
+                'resource_id' => $ids['backend3::res7'],
+                'key' => 'meta1',
+                'value' => 'value1',
+            ],
+            [
+                'resource_id' => $ids['backend3::res6'],
+                'key' => 'meta123',
+                'value' => 'meta456',
+            ],
+            [
+                'resource_id' => $ids['backend4::res8'],
+                'key' => 'meta2',
+                'value' => 'value2',
+            ]
+        ], $rows2);
+    }
+
+    protected function createTestResourcesInCache() {
+        $query = self::$realDatabase->getQueryBuilder();
+        $query->insert('calendar_resources')
+            ->values([
+                'backend_id' => $query->createNamedParameter('backend1'),
+                'resource_id' => $query->createNamedParameter('res1'),
+                'email' => $query->createNamedParameter('res1@foo.bar'),
+                'displayname' => $query->createNamedParameter('Beamer1'),
+                'group_restrictions' => $query->createNamedParameter('[]'),
+            ])
+            ->executeStatement();
+
+        $query->insert('calendar_resources')
+            ->values([
+                'backend_id' => $query->createNamedParameter('backend1'),
+                'resource_id' => $query->createNamedParameter('res2'),
+                'email' => $query->createNamedParameter('res2@foo.bar'),
+                'displayname' => $query->createNamedParameter('TV1'),
+                'group_restrictions' => $query->createNamedParameter('[]'),
+            ])
+            ->executeStatement();
+
+        $query->insert('calendar_resources')
+            ->values([
+                'backend_id' => $query->createNamedParameter('backend2'),
+                'resource_id' => $query->createNamedParameter('res3'),
+                'email' => $query->createNamedParameter('res3@foo.bar'),
+                'displayname' => $query->createNamedParameter('Beamer2'),
+                'group_restrictions' => $query->createNamedParameter('[]'),
+            ])
+            ->executeStatement();
+        $id3 = $query->getLastInsertId();
+
+        $query->insert('calendar_resources')
+            ->values([
+                'backend_id' => $query->createNamedParameter('backend2'),
+                'resource_id' => $query->createNamedParameter('res4'),
+                'email' => $query->createNamedParameter('res4@foo.bar'),
+                'displayname' => $query->createNamedParameter('TV2'),
+                'group_restrictions' => $query->createNamedParameter('[]'),
+            ])
+            ->executeStatement();
+        $id4 = $query->getLastInsertId();
+
+        $query->insert('calendar_resources')
+            ->values([
+                'backend_id' => $query->createNamedParameter('backend3'),
+                'resource_id' => $query->createNamedParameter('res5'),
+                'email' => $query->createNamedParameter('res5@foo.bar'),
+                'displayname' => $query->createNamedParameter('Beamer3'),
+                'group_restrictions' => $query->createNamedParameter('[]'),
+            ])
+            ->executeStatement();
+
+        $query->insert('calendar_resources')
+            ->values([
+                'backend_id' => $query->createNamedParameter('backend3'),
+                'resource_id' => $query->createNamedParameter('res6'),
+                'email' => $query->createNamedParameter('res6@foo.bar'),
+                'displayname' => $query->createNamedParameter('Pointer'),
+                'group_restrictions' => $query->createNamedParameter('["foo", "bar"]'),
+            ])
+            ->executeStatement();
+        $id6 = $query->getLastInsertId();
+
+        $query->insert('calendar_resources_md')
+            ->values([
+                'resource_id' => $query->createNamedParameter($id3),
+                'key' => $query->createNamedParameter('meta1'),
+                'value' => $query->createNamedParameter('value1')
+            ])
+            ->executeStatement();
+        $query->insert('calendar_resources_md')
+            ->values([
+                'resource_id' => $query->createNamedParameter($id3),
+                'key' => $query->createNamedParameter('meta2'),
+                'value' => $query->createNamedParameter('value2')
+            ])
+            ->executeStatement();
+        $query->insert('calendar_resources_md')
+            ->values([
+                'resource_id' => $query->createNamedParameter($id4),
+                'key' => $query->createNamedParameter('meta1'),
+                'value' => $query->createNamedParameter('value1')
+            ])
+            ->executeStatement();
+        $query->insert('calendar_resources_md')
+            ->values([
+                'resource_id' => $query->createNamedParameter($id4),
+                'key' => $query->createNamedParameter('meta3'),
+                'value' => $query->createNamedParameter('value3-old')
+            ])
+            ->executeStatement();
+        $query->insert('calendar_resources_md')
+            ->values([
+                'resource_id' => $query->createNamedParameter($id6),
+                'key' => $query->createNamedParameter('meta99'),
+                'value' => $query->createNamedParameter('value99')
+            ])
+            ->executeStatement();
+    }
 }

tests/lib/AllConfigTest.php

Indentation +501 added lines, -501 removed lines

@@ -21,513 +21,513 @@
  */
 #[\PHPUnit\Framework\Attributes\Group('DB')]
 class AllConfigTest extends \Test\TestCase {
-	/** @var IDBConnection */
-	protected $connection;
-
-	protected function getConfig($systemConfig = null, $connection = null) {
-		if ($this->connection === null) {
-			$this->connection = Server::get(IDBConnection::class);
-		}
-		if ($connection === null) {
-			$connection = $this->connection;
-		}
-		if ($systemConfig === null) {
-			$systemConfig = $this->getMockBuilder('\OC\SystemConfig')
-				->disableOriginalConstructor()
-				->getMock();
-		}
-		return new AllConfig($systemConfig, $connection);
-	}
-
-	public function testDeleteUserValue(): void {
-		$config = $this->getConfig();
-
-		// preparation - add something to the database
-		$this->connection->executeUpdate(
-			'INSERT INTO `*PREFIX*preferences` (`userid`, `appid`, '
-			. '`configkey`, `configvalue`) VALUES (?, ?, ?, ?)',
-			['userDelete', 'appDelete', 'keyDelete', 'valueDelete']
-		);
-
-		$config->deleteUserValue('userDelete', 'appDelete', 'keyDelete');
-
-		$result = $this->connection->executeQuery(
-			'SELECT COUNT(*) AS `count` FROM `*PREFIX*preferences` WHERE `userid` = ?',
-			['userDelete']
-		)->fetchAssociative();
-		$actualCount = $result['count'];
-
-		$this->assertEquals(0, $actualCount, 'There was one value in the database and after the tests there should be no entry left.');
-	}
-
-	public function testSetUserValue(): void {
-		$selectAllSQL = 'SELECT `userid`, `appid`, `configkey`, `configvalue` FROM `*PREFIX*preferences` WHERE `userid` = ?';
-		$config = $this->getConfig();
-
-		$config->setUserValue('userSet', 'appSet', 'keySet', 'valueSet');
-
-		$result = $this->connection->executeQuery($selectAllSQL, ['userSet'])->fetchAllAssociative();
-
-		$this->assertEquals(1, count($result));
-		$this->assertEquals([
-			'userid' => 'userSet',
-			'appid' => 'appSet',
-			'configkey' => 'keySet',
-			'configvalue' => 'valueSet'
-		], $result[0]);
-
-		// test if the method overwrites existing database entries
-		$config->setUserValue('userSet', 'appSet', 'keySet', 'valueSet2');
-
-		$result = $this->connection->executeQuery($selectAllSQL, ['userSet'])->fetchAllAssociative();
-
-		$this->assertEquals(1, count($result));
-		$this->assertEquals([
-			'userid' => 'userSet',
-			'appid' => 'appSet',
-			'configkey' => 'keySet',
-			'configvalue' => 'valueSet2'
-		], $result[0]);
-
-		// cleanup - it therefore relies on the successful execution of the previous test
-		$config->deleteUserValue('userSet', 'appSet', 'keySet');
-	}
-
-	/**
-	 * This test needs to stay! Emails are expected to be lowercase due to performance reasons.
-	 * This way we can skip the expensive casing change on the database.
-	 */
-	public function testSetUserValueSettingsEmail(): void {
-		$selectAllSQL = 'SELECT `userid`, `appid`, `configkey`, `configvalue` FROM `*PREFIX*preferences` WHERE `userid` = ?';
-		$config = $this->getConfig();
-
-		$config->setUserValue('userSet', 'settings', 'email', 'mixed.CASE@domain.COM');
-
-		$result = $this->connection->executeQuery($selectAllSQL, ['userSet'])->fetchAllAssociative();
-
-		$this->assertEquals(1, count($result));
-		$this->assertEquals([
-			'userid' => 'userSet',
-			'appid' => 'settings',
-			'configkey' => 'email',
-			'configvalue' => 'mixed.case@domain.com'
-		], $result[0]);
-	}
-
-	public function testSetUserValueWithPreCondition(): void {
-		$config = $this->getConfig();
-
-		$selectAllSQL = 'SELECT `userid`, `appid`, `configkey`, `configvalue` FROM `*PREFIX*preferences` WHERE `userid` = ?';
-
-		$config->setUserValue('userPreCond', 'appPreCond', 'keyPreCond', 'valuePreCond');
-
-		$result = $this->connection->executeQuery($selectAllSQL, ['userPreCond'])->fetchAllAssociative();
-
-		$this->assertEquals(1, count($result));
-		$this->assertEquals([
-			'userid' => 'userPreCond',
-			'appid' => 'appPreCond',
-			'configkey' => 'keyPreCond',
-			'configvalue' => 'valuePreCond'
-		], $result[0]);
-
-		// test if the method overwrites existing database entries with valid precond
-		$config->setUserValue('userPreCond', 'appPreCond', 'keyPreCond', 'valuePreCond2', 'valuePreCond');
-
-		$result = $this->connection->executeQuery($selectAllSQL, ['userPreCond'])->fetchAllAssociative();
-
-		$this->assertEquals(1, count($result));
-		$this->assertEquals([
-			'userid' => 'userPreCond',
-			'appid' => 'appPreCond',
-			'configkey' => 'keyPreCond',
-			'configvalue' => 'valuePreCond2'
-		], $result[0]);
-
-		// cleanup
-		$config->deleteUserValue('userPreCond', 'appPreCond', 'keyPreCond');
-	}
+    /** @var IDBConnection */
+    protected $connection;
+
+    protected function getConfig($systemConfig = null, $connection = null) {
+        if ($this->connection === null) {
+            $this->connection = Server::get(IDBConnection::class);
+        }
+        if ($connection === null) {
+            $connection = $this->connection;
+        }
+        if ($systemConfig === null) {
+            $systemConfig = $this->getMockBuilder('\OC\SystemConfig')
+                ->disableOriginalConstructor()
+                ->getMock();
+        }
+        return new AllConfig($systemConfig, $connection);
+    }
+
+    public function testDeleteUserValue(): void {
+        $config = $this->getConfig();
+
+        // preparation - add something to the database
+        $this->connection->executeUpdate(
+            'INSERT INTO `*PREFIX*preferences` (`userid`, `appid`, '
+            . '`configkey`, `configvalue`) VALUES (?, ?, ?, ?)',
+            ['userDelete', 'appDelete', 'keyDelete', 'valueDelete']
+        );
+
+        $config->deleteUserValue('userDelete', 'appDelete', 'keyDelete');
+
+        $result = $this->connection->executeQuery(
+            'SELECT COUNT(*) AS `count` FROM `*PREFIX*preferences` WHERE `userid` = ?',
+            ['userDelete']
+        )->fetchAssociative();
+        $actualCount = $result['count'];
+
+        $this->assertEquals(0, $actualCount, 'There was one value in the database and after the tests there should be no entry left.');
+    }
+
+    public function testSetUserValue(): void {
+        $selectAllSQL = 'SELECT `userid`, `appid`, `configkey`, `configvalue` FROM `*PREFIX*preferences` WHERE `userid` = ?';
+        $config = $this->getConfig();
+
+        $config->setUserValue('userSet', 'appSet', 'keySet', 'valueSet');
+
+        $result = $this->connection->executeQuery($selectAllSQL, ['userSet'])->fetchAllAssociative();
+
+        $this->assertEquals(1, count($result));
+        $this->assertEquals([
+            'userid' => 'userSet',
+            'appid' => 'appSet',
+            'configkey' => 'keySet',
+            'configvalue' => 'valueSet'
+        ], $result[0]);
+
+        // test if the method overwrites existing database entries
+        $config->setUserValue('userSet', 'appSet', 'keySet', 'valueSet2');
+
+        $result = $this->connection->executeQuery($selectAllSQL, ['userSet'])->fetchAllAssociative();
+
+        $this->assertEquals(1, count($result));
+        $this->assertEquals([
+            'userid' => 'userSet',
+            'appid' => 'appSet',
+            'configkey' => 'keySet',
+            'configvalue' => 'valueSet2'
+        ], $result[0]);
+
+        // cleanup - it therefore relies on the successful execution of the previous test
+        $config->deleteUserValue('userSet', 'appSet', 'keySet');
+    }
+
+    /**
+     * This test needs to stay! Emails are expected to be lowercase due to performance reasons.
+     * This way we can skip the expensive casing change on the database.
+     */
+    public function testSetUserValueSettingsEmail(): void {
+        $selectAllSQL = 'SELECT `userid`, `appid`, `configkey`, `configvalue` FROM `*PREFIX*preferences` WHERE `userid` = ?';
+        $config = $this->getConfig();
+
+        $config->setUserValue('userSet', 'settings', 'email', 'mixed.CASE@domain.COM');
+
+        $result = $this->connection->executeQuery($selectAllSQL, ['userSet'])->fetchAllAssociative();
+
+        $this->assertEquals(1, count($result));
+        $this->assertEquals([
+            'userid' => 'userSet',
+            'appid' => 'settings',
+            'configkey' => 'email',
+            'configvalue' => 'mixed.case@domain.com'
+        ], $result[0]);
+    }
+
+    public function testSetUserValueWithPreCondition(): void {
+        $config = $this->getConfig();
+
+        $selectAllSQL = 'SELECT `userid`, `appid`, `configkey`, `configvalue` FROM `*PREFIX*preferences` WHERE `userid` = ?';
+
+        $config->setUserValue('userPreCond', 'appPreCond', 'keyPreCond', 'valuePreCond');
+
+        $result = $this->connection->executeQuery($selectAllSQL, ['userPreCond'])->fetchAllAssociative();
+
+        $this->assertEquals(1, count($result));
+        $this->assertEquals([
+            'userid' => 'userPreCond',
+            'appid' => 'appPreCond',
+            'configkey' => 'keyPreCond',
+            'configvalue' => 'valuePreCond'
+        ], $result[0]);
+
+        // test if the method overwrites existing database entries with valid precond
+        $config->setUserValue('userPreCond', 'appPreCond', 'keyPreCond', 'valuePreCond2', 'valuePreCond');
+
+        $result = $this->connection->executeQuery($selectAllSQL, ['userPreCond'])->fetchAllAssociative();
+
+        $this->assertEquals(1, count($result));
+        $this->assertEquals([
+            'userid' => 'userPreCond',
+            'appid' => 'appPreCond',
+            'configkey' => 'keyPreCond',
+            'configvalue' => 'valuePreCond2'
+        ], $result[0]);
+
+        // cleanup
+        $config->deleteUserValue('userPreCond', 'appPreCond', 'keyPreCond');
+    }
 
-	public static function dataSetUserValueUnexpectedValue(): array {
-		return [
-			[true],
-			[false],
-			[null],
-			[new \stdClass()],
-		];
-	}
-
-	/**
-	 * @param mixed $value
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataSetUserValueUnexpectedValue')]
-	public function testSetUserValueUnexpectedValue($value): void {
-		$this->expectException(\UnexpectedValueException::class);
-
-		$config = $this->getConfig();
-		$config->setUserValue('userSetBool', 'appSetBool', 'keySetBool', $value);
-	}
-
-
-	public function testSetUserValueWithPreConditionFailure(): void {
-		$this->expectException(PreConditionNotMetException::class);
-
-		$config = $this->getConfig();
-
-		$selectAllSQL = 'SELECT `userid`, `appid`, `configkey`, `configvalue` FROM `*PREFIX*preferences` WHERE `userid` = ?';
+    public static function dataSetUserValueUnexpectedValue(): array {
+        return [
+            [true],
+            [false],
+            [null],
+            [new \stdClass()],
+        ];
+    }
+
+    /**
+     * @param mixed $value
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataSetUserValueUnexpectedValue')]
+    public function testSetUserValueUnexpectedValue($value): void {
+        $this->expectException(\UnexpectedValueException::class);
+
+        $config = $this->getConfig();
+        $config->setUserValue('userSetBool', 'appSetBool', 'keySetBool', $value);
+    }
+
+
+    public function testSetUserValueWithPreConditionFailure(): void {
+        $this->expectException(PreConditionNotMetException::class);
+
+        $config = $this->getConfig();
+
+        $selectAllSQL = 'SELECT `userid`, `appid`, `configkey`, `configvalue` FROM `*PREFIX*preferences` WHERE `userid` = ?';
 
-		$config->setUserValue('userPreCond1', 'appPreCond', 'keyPreCond', 'valuePreCond');
-
-		$result = $this->connection->executeQuery($selectAllSQL, ['userPreCond1'])->fetchAllAssociative();
-
-		$this->assertEquals(1, count($result));
-		$this->assertEquals([
-			'userid' => 'userPreCond1',
-			'appid' => 'appPreCond',
-			'configkey' => 'keyPreCond',
-			'configvalue' => 'valuePreCond'
-		], $result[0]);
-
-		// test if the method overwrites existing database entries with valid precond
-		$config->setUserValue('userPreCond1', 'appPreCond', 'keyPreCond', 'valuePreCond2', 'valuePreCond3');
-
-		$result = $this->connection->executeQuery($selectAllSQL, ['userPreCond1'])->fetchAllAssociative();
-
-		$this->assertEquals(1, count($result));
-		$this->assertEquals([
-			'userid' => 'userPreCond1',
-			'appid' => 'appPreCond',
-			'configkey' => 'keyPreCond',
-			'configvalue' => 'valuePreCond'
-		], $result[0]);
+        $config->setUserValue('userPreCond1', 'appPreCond', 'keyPreCond', 'valuePreCond');
+
+        $result = $this->connection->executeQuery($selectAllSQL, ['userPreCond1'])->fetchAllAssociative();
+
+        $this->assertEquals(1, count($result));
+        $this->assertEquals([
+            'userid' => 'userPreCond1',
+            'appid' => 'appPreCond',
+            'configkey' => 'keyPreCond',
+            'configvalue' => 'valuePreCond'
+        ], $result[0]);
+
+        // test if the method overwrites existing database entries with valid precond
+        $config->setUserValue('userPreCond1', 'appPreCond', 'keyPreCond', 'valuePreCond2', 'valuePreCond3');
+
+        $result = $this->connection->executeQuery($selectAllSQL, ['userPreCond1'])->fetchAllAssociative();
+
+        $this->assertEquals(1, count($result));
+        $this->assertEquals([
+            'userid' => 'userPreCond1',
+            'appid' => 'appPreCond',
+            'configkey' => 'keyPreCond',
+            'configvalue' => 'valuePreCond'
+        ], $result[0]);
 
-		// cleanup
-		$config->deleteUserValue('userPreCond1', 'appPreCond', 'keyPreCond');
-	}
+        // cleanup
+        $config->deleteUserValue('userPreCond1', 'appPreCond', 'keyPreCond');
+    }
 
-	public function testSetUserValueWithPreConditionFailureWhenResultStillMatches(): void {
-		$this->expectException(PreConditionNotMetException::class);
+    public function testSetUserValueWithPreConditionFailureWhenResultStillMatches(): void {
+        $this->expectException(PreConditionNotMetException::class);
 
-		$config = $this->getConfig();
+        $config = $this->getConfig();
 
-		$selectAllSQL = 'SELECT `userid`, `appid`, `configkey`, `configvalue` FROM `*PREFIX*preferences` WHERE `userid` = ?';
+        $selectAllSQL = 'SELECT `userid`, `appid`, `configkey`, `configvalue` FROM `*PREFIX*preferences` WHERE `userid` = ?';
 
-		$config->setUserValue('userPreCond1', 'appPreCond', 'keyPreCond', 'valuePreCond');
+        $config->setUserValue('userPreCond1', 'appPreCond', 'keyPreCond', 'valuePreCond');
 
-		$result = $this->connection->executeQuery($selectAllSQL, ['userPreCond1'])->fetchAllAssociative();
-
-		$this->assertCount(1, $result);
-		$this->assertEquals([
-			'userid' => 'userPreCond1',
-			'appid' => 'appPreCond',
-			'configkey' => 'keyPreCond',
-			'configvalue' => 'valuePreCond'
-		], $result[0]);
-
-		// test if the method throws with invalid precondition when the value is the same
-		$config->setUserValue('userPreCond1', 'appPreCond', 'keyPreCond', 'valuePreCond', 'valuePreCond3');
-
-		$result = $this->connection->executeQuery($selectAllSQL, ['userPreCond1'])->fetchAllAssociative();
-
-		$this->assertCount(1, $result);
-		$this->assertEquals([
-			'userid' => 'userPreCond1',
-			'appid' => 'appPreCond',
-			'configkey' => 'keyPreCond',
-			'configvalue' => 'valuePreCond'
-		], $result[0]);
-
-		// cleanup
-		$config->deleteUserValue('userPreCond1', 'appPreCond', 'keyPreCond');
-	}
-
-	public function testSetUserValueUnchanged(): void {
-		// TODO - FIXME until the dependency injection is handled properly (in AllConfig)
-		$this->markTestSkipped('Skipped because this is just testable if database connection can be injected');
-
-		$resultMock = $this->getMockBuilder('\Doctrine\DBAL\Driver\Statement')
-			->disableOriginalConstructor()->getMock();
-		$resultMock->expects($this->once())
-			->method('fetchColumn')
-			->willReturn('valueSetUnchanged');
-
-		$connectionMock = $this->createMock(IDBConnection::class);
-		$connectionMock->expects($this->once())
-			->method('executeQuery')
-			->with($this->equalTo('SELECT `configvalue` FROM `*PREFIX*preferences` '
-					. 'WHERE `userid` = ? AND `appid` = ? AND `configkey` = ?'),
-				$this->equalTo(['userSetUnchanged', 'appSetUnchanged', 'keySetUnchanged']))
-			->willReturn($resultMock);
-		$connectionMock->expects($this->never())
-			->method('executeUpdate');
-
-		$config = $this->getConfig(null, $connectionMock);
-
-		$config->setUserValue('userSetUnchanged', 'appSetUnchanged', 'keySetUnchanged', 'valueSetUnchanged');
-	}
-
-	public function testGetUserValue(): void {
-		$config = $this->getConfig();
-
-		// setup - it therefore relies on the successful execution of the previous test
-		$config->setUserValue('userGet', 'appGet', 'keyGet', 'valueGet');
-		$value = $config->getUserValue('userGet', 'appGet', 'keyGet');
-
-		$this->assertEquals('valueGet', $value);
-
-		$result = $this->connection->executeQuery(
-			'SELECT `userid`, `appid`, `configkey`, `configvalue` FROM `*PREFIX*preferences` WHERE `userid` = ?',
-			['userGet']
-		)->fetchAllAssociative();
-
-		$this->assertEquals(1, count($result));
-		$this->assertEquals([
-			'userid' => 'userGet',
-			'appid' => 'appGet',
-			'configkey' => 'keyGet',
-			'configvalue' => 'valueGet'
-		], $result[0]);
-
-		// drop data from database - but the config option should be cached in the config object
-		$this->connection->executeUpdate('DELETE FROM `*PREFIX*preferences` WHERE `userid` = ?', ['userGet']);
-
-		// testing the caching mechanism
-		$value = $config->getUserValue('userGet', 'appGet', 'keyGet');
-
-		$this->assertEquals('valueGet', $value);
-
-		$result = $this->connection->executeQuery(
-			'SELECT `userid`, `appid`, `configkey`, `configvalue` FROM `*PREFIX*preferences` WHERE `userid` = ?',
-			['userGet']
-		)->fetchAllAssociative();
-
-		$this->assertEquals(0, count($result));
-	}
-
-	public function testGetUserKeys(): void {
-		$config = $this->getConfig();
-
-		// preparation - add something to the database
-		$data = [
-			['userFetch', 'appFetch1', 'keyFetch1', 'value1'],
-			['userFetch', 'appFetch1', 'keyFetch2', 'value2'],
-			['userFetch', 'appFetch2', 'keyFetch3', 'value3'],
-			['userFetch', 'appFetch1', 'keyFetch4', 'value4'],
-			['userFetch', 'appFetch4', 'keyFetch1', 'value5'],
-			['userFetch', 'appFetch5', 'keyFetch1', 'value6'],
-			['userFetch2', 'appFetch', 'keyFetch1', 'value7']
-		];
-		foreach ($data as $entry) {
-			$this->connection->executeUpdate(
-				'INSERT INTO `*PREFIX*preferences` (`userid`, `appid`, '
-				. '`configkey`, `configvalue`) VALUES (?, ?, ?, ?)',
-				$entry
-			);
-		}
-
-		$value = $config->getUserKeys('userFetch', 'appFetch1');
-		$this->assertEquals(['keyFetch1', 'keyFetch2', 'keyFetch4'], $value);
-
-		$value = $config->getUserKeys('userFetch2', 'appFetch');
-		$this->assertEquals(['keyFetch1'], $value);
-
-		// cleanup
-		$this->connection->executeUpdate('DELETE FROM `*PREFIX*preferences`');
-	}
-
-	public function testGetUserKeysAllInts(): void {
-		$config = $this->getConfig();
-
-		// preparation - add something to the database
-		$data = [
-			['userFetch8', 'appFetch1', '123', 'value'],
-			['userFetch8', 'appFetch1', '456', 'value'],
-		];
-		foreach ($data as $entry) {
-			$this->connection->executeUpdate(
-				'INSERT INTO `*PREFIX*preferences` (`userid`, `appid`, '
-				. '`configkey`, `configvalue`) VALUES (?, ?, ?, ?)',
-				$entry
-			);
-		}
-
-		$value = $config->getUserKeys('userFetch8', 'appFetch1');
-		$this->assertEquals(['123', '456'], $value);
-		$this->assertIsString($value[0]);
-		$this->assertIsString($value[1]);
-
-		// cleanup
-		$this->connection->executeUpdate('DELETE FROM `*PREFIX*preferences`');
-	}
-
-	public function testGetUserValueDefault(): void {
-		$config = $this->getConfig();
-
-		$this->assertEquals('', $config->getUserValue('userGetUnset', 'appGetUnset', 'keyGetUnset'));
-		$this->assertEquals(null, $config->getUserValue('userGetUnset', 'appGetUnset', 'keyGetUnset', null));
-		$this->assertEquals('foobar', $config->getUserValue('userGetUnset', 'appGetUnset', 'keyGetUnset', 'foobar'));
-	}
-
-	public function testGetUserValueForUsers(): void {
-		$config = $this->getConfig();
-
-		// preparation - add something to the database
-		$data = [
-			['userFetch1', 'appFetch2', 'keyFetch1', 'value1'],
-			['userFetch2', 'appFetch2', 'keyFetch1', 'value2'],
-			['userFetch3', 'appFetch2', 'keyFetch1', 3],
-			['userFetch4', 'appFetch2', 'keyFetch1', 'value4'],
-			['userFetch5', 'appFetch2', 'keyFetch1', 'value5'],
-			['userFetch6', 'appFetch2', 'keyFetch1', 'value6'],
-			['userFetch7', 'appFetch2', 'keyFetch1', 'value7']
-		];
-		foreach ($data as $entry) {
-			$this->connection->executeUpdate(
-				'INSERT INTO `*PREFIX*preferences` (`userid`, `appid`, '
-				. '`configkey`, `configvalue`) VALUES (?, ?, ?, ?)',
-				$entry
-			);
-		}
-
-		$value = $config->getUserValueForUsers('appFetch2', 'keyFetch1',
-			['userFetch1', 'userFetch2', 'userFetch3', 'userFetch5']);
-		$this->assertEquals([
-			'userFetch1' => 'value1',
-			'userFetch2' => 'value2',
-			'userFetch3' => 3,
-			'userFetch5' => 'value5'
-		], $value);
-
-		$value = $config->getUserValueForUsers('appFetch2', 'keyFetch1',
-			['userFetch1', 'userFetch4', 'userFetch9']);
-		$this->assertEquals([
-			'userFetch1' => 'value1',
-			'userFetch4' => 'value4'
-		], $value, 'userFetch9 is an non-existent user and should not be shown.');
-
-		// cleanup
-		$this->connection->executeUpdate('DELETE FROM `*PREFIX*preferences`');
-	}
-
-	public function testDeleteAllUserValues(): void {
-		$config = $this->getConfig();
-
-		// preparation - add something to the database
-		$data = [
-			['userFetch3', 'appFetch1', 'keyFetch1', 'value1'],
-			['userFetch3', 'appFetch1', 'keyFetch2', 'value2'],
-			['userFetch3', 'appFetch2', 'keyFetch3', 'value3'],
-			['userFetch3', 'appFetch1', 'keyFetch4', 'value4'],
-			['userFetch3', 'appFetch4', 'keyFetch1', 'value5'],
-			['userFetch3', 'appFetch5', 'keyFetch1', 'value6'],
-			['userFetch4', 'appFetch2', 'keyFetch1', 'value7']
-		];
-		foreach ($data as $entry) {
-			$this->connection->executeUpdate(
-				'INSERT INTO `*PREFIX*preferences` (`userid`, `appid`, '
-				. '`configkey`, `configvalue`) VALUES (?, ?, ?, ?)',
-				$entry
-			);
-		}
-
-		$config->deleteAllUserValues('userFetch3');
-
-		$result = $this->connection->executeQuery(
-			'SELECT COUNT(*) AS `count` FROM `*PREFIX*preferences`'
-		)->fetchAssociative();
-		$actualCount = $result['count'];
-
-		$this->assertEquals(1, $actualCount, 'After removing `userFetch3` there should be exactly 1 entry left.');
-
-		// cleanup
-		$this->connection->executeUpdate('DELETE FROM `*PREFIX*preferences`');
-	}
-
-	public function testDeleteAppFromAllUsers(): void {
-		$config = $this->getConfig();
-
-		// preparation - add something to the database
-		$data = [
-			['userFetch5', 'appFetch1', 'keyFetch1', 'value1'],
-			['userFetch5', 'appFetch1', 'keyFetch2', 'value2'],
-			['userFetch5', 'appFetch2', 'keyFetch3', 'value3'],
-			['userFetch5', 'appFetch1', 'keyFetch4', 'value4'],
-			['userFetch5', 'appFetch4', 'keyFetch1', 'value5'],
-			['userFetch5', 'appFetch5', 'keyFetch1', 'value6'],
-			['userFetch6', 'appFetch2', 'keyFetch1', 'value7']
-		];
-		foreach ($data as $entry) {
-			$this->connection->executeUpdate(
-				'INSERT INTO `*PREFIX*preferences` (`userid`, `appid`, '
-				. '`configkey`, `configvalue`) VALUES (?, ?, ?, ?)',
-				$entry
-			);
-		}
-
-		$config->deleteAppFromAllUsers('appFetch1');
-
-		$result = $this->connection->executeQuery(
-			'SELECT COUNT(*) AS `count` FROM `*PREFIX*preferences`'
-		)->fetchAssociative();
-		$actualCount = $result['count'];
-
-		$this->assertEquals(4, $actualCount, 'After removing `appFetch1` there should be exactly 4 entries left.');
-
-		$config->deleteAppFromAllUsers('appFetch2');
-
-		$result = $this->connection->executeQuery(
-			'SELECT COUNT(*) AS `count` FROM `*PREFIX*preferences`'
-		)->fetchAssociative();
-		$actualCount = $result['count'];
-
-		$this->assertEquals(2, $actualCount, 'After removing `appFetch2` there should be exactly 2 entries left.');
-
-		// cleanup
-		$this->connection->executeUpdate('DELETE FROM `*PREFIX*preferences`');
-	}
-
-	public function testGetUsersForUserValue(): void {
-		// mock the check for the database to run the correct SQL statements for each database type
-		$systemConfig = $this->getMockBuilder('\OC\SystemConfig')
-			->disableOriginalConstructor()
-			->getMock();
-		$config = $this->getConfig($systemConfig);
-
-		// preparation - add something to the database
-		$data = [
-			['user1', 'appFetch9', 'keyFetch9', 'value9'],
-			['user2', 'appFetch9', 'keyFetch9', 'value9'],
-			['user3', 'appFetch9', 'keyFetch9', 'value8'],
-			['user4', 'appFetch9', 'keyFetch8', 'value9'],
-			['user5', 'appFetch8', 'keyFetch9', 'value9'],
-			['user6', 'appFetch9', 'keyFetch9', 'value9'],
-		];
-		foreach ($data as $entry) {
-			$this->connection->executeUpdate(
-				'INSERT INTO `*PREFIX*preferences` (`userid`, `appid`, '
-				. '`configkey`, `configvalue`) VALUES (?, ?, ?, ?)',
-				$entry
-			);
-		}
-
-		$value = $config->getUsersForUserValue('appFetch9', 'keyFetch9', 'value9');
-		$this->assertEquals(['user1', 'user2', 'user6'], $value);
-
-		// cleanup
-		$this->connection->executeUpdate('DELETE FROM `*PREFIX*preferences`');
-	}
-
-	public function testGetUsersForUserValueCaseInsensitive(): void {
-		// mock the check for the database to run the correct SQL statements for each database type
-		$systemConfig = $this->createMock(SystemConfig::class);
-		$config = $this->getConfig($systemConfig);
-
-		$config->setUserValue('user1', 'myApp', 'myKey', 'test123');
-		$config->setUserValue('user2', 'myApp', 'myKey', 'TEST123');
-		$config->setUserValue('user3', 'myApp', 'myKey', 'test12345');
-
-		$users = $config->getUsersForUserValueCaseInsensitive('myApp', 'myKey', 'test123');
-		$this->assertSame(2, count($users));
-		$this->assertSame(['user1', 'user2'], $users);
-	}
+        $result = $this->connection->executeQuery($selectAllSQL, ['userPreCond1'])->fetchAllAssociative();
+
+        $this->assertCount(1, $result);
+        $this->assertEquals([
+            'userid' => 'userPreCond1',
+            'appid' => 'appPreCond',
+            'configkey' => 'keyPreCond',
+            'configvalue' => 'valuePreCond'
+        ], $result[0]);
+
+        // test if the method throws with invalid precondition when the value is the same
+        $config->setUserValue('userPreCond1', 'appPreCond', 'keyPreCond', 'valuePreCond', 'valuePreCond3');
+
+        $result = $this->connection->executeQuery($selectAllSQL, ['userPreCond1'])->fetchAllAssociative();
+
+        $this->assertCount(1, $result);
+        $this->assertEquals([
+            'userid' => 'userPreCond1',
+            'appid' => 'appPreCond',
+            'configkey' => 'keyPreCond',
+            'configvalue' => 'valuePreCond'
+        ], $result[0]);
+
+        // cleanup
+        $config->deleteUserValue('userPreCond1', 'appPreCond', 'keyPreCond');
+    }
+
+    public function testSetUserValueUnchanged(): void {
+        // TODO - FIXME until the dependency injection is handled properly (in AllConfig)
+        $this->markTestSkipped('Skipped because this is just testable if database connection can be injected');
+
+        $resultMock = $this->getMockBuilder('\Doctrine\DBAL\Driver\Statement')
+            ->disableOriginalConstructor()->getMock();
+        $resultMock->expects($this->once())
+            ->method('fetchColumn')
+            ->willReturn('valueSetUnchanged');
+
+        $connectionMock = $this->createMock(IDBConnection::class);
+        $connectionMock->expects($this->once())
+            ->method('executeQuery')
+            ->with($this->equalTo('SELECT `configvalue` FROM `*PREFIX*preferences` '
+                    . 'WHERE `userid` = ? AND `appid` = ? AND `configkey` = ?'),
+                $this->equalTo(['userSetUnchanged', 'appSetUnchanged', 'keySetUnchanged']))
+            ->willReturn($resultMock);
+        $connectionMock->expects($this->never())
+            ->method('executeUpdate');
+
+        $config = $this->getConfig(null, $connectionMock);
+
+        $config->setUserValue('userSetUnchanged', 'appSetUnchanged', 'keySetUnchanged', 'valueSetUnchanged');
+    }
+
+    public function testGetUserValue(): void {
+        $config = $this->getConfig();
+
+        // setup - it therefore relies on the successful execution of the previous test
+        $config->setUserValue('userGet', 'appGet', 'keyGet', 'valueGet');
+        $value = $config->getUserValue('userGet', 'appGet', 'keyGet');
+
+        $this->assertEquals('valueGet', $value);
+
+        $result = $this->connection->executeQuery(
+            'SELECT `userid`, `appid`, `configkey`, `configvalue` FROM `*PREFIX*preferences` WHERE `userid` = ?',
+            ['userGet']
+        )->fetchAllAssociative();
+
+        $this->assertEquals(1, count($result));
+        $this->assertEquals([
+            'userid' => 'userGet',
+            'appid' => 'appGet',
+            'configkey' => 'keyGet',
+            'configvalue' => 'valueGet'
+        ], $result[0]);
+
+        // drop data from database - but the config option should be cached in the config object
+        $this->connection->executeUpdate('DELETE FROM `*PREFIX*preferences` WHERE `userid` = ?', ['userGet']);
+
+        // testing the caching mechanism
+        $value = $config->getUserValue('userGet', 'appGet', 'keyGet');
+
+        $this->assertEquals('valueGet', $value);
+
+        $result = $this->connection->executeQuery(
+            'SELECT `userid`, `appid`, `configkey`, `configvalue` FROM `*PREFIX*preferences` WHERE `userid` = ?',
+            ['userGet']
+        )->fetchAllAssociative();
+
+        $this->assertEquals(0, count($result));
+    }
+
+    public function testGetUserKeys(): void {
+        $config = $this->getConfig();
+
+        // preparation - add something to the database
+        $data = [
+            ['userFetch', 'appFetch1', 'keyFetch1', 'value1'],
+            ['userFetch', 'appFetch1', 'keyFetch2', 'value2'],
+            ['userFetch', 'appFetch2', 'keyFetch3', 'value3'],
+            ['userFetch', 'appFetch1', 'keyFetch4', 'value4'],
+            ['userFetch', 'appFetch4', 'keyFetch1', 'value5'],
+            ['userFetch', 'appFetch5', 'keyFetch1', 'value6'],
+            ['userFetch2', 'appFetch', 'keyFetch1', 'value7']
+        ];
+        foreach ($data as $entry) {
+            $this->connection->executeUpdate(
+                'INSERT INTO `*PREFIX*preferences` (`userid`, `appid`, '
+                . '`configkey`, `configvalue`) VALUES (?, ?, ?, ?)',
+                $entry
+            );
+        }
+
+        $value = $config->getUserKeys('userFetch', 'appFetch1');
+        $this->assertEquals(['keyFetch1', 'keyFetch2', 'keyFetch4'], $value);
+
+        $value = $config->getUserKeys('userFetch2', 'appFetch');
+        $this->assertEquals(['keyFetch1'], $value);
+
+        // cleanup
+        $this->connection->executeUpdate('DELETE FROM `*PREFIX*preferences`');
+    }
+
+    public function testGetUserKeysAllInts(): void {
+        $config = $this->getConfig();
+
+        // preparation - add something to the database
+        $data = [
+            ['userFetch8', 'appFetch1', '123', 'value'],
+            ['userFetch8', 'appFetch1', '456', 'value'],
+        ];
+        foreach ($data as $entry) {
+            $this->connection->executeUpdate(
+                'INSERT INTO `*PREFIX*preferences` (`userid`, `appid`, '
+                . '`configkey`, `configvalue`) VALUES (?, ?, ?, ?)',
+                $entry
+            );
+        }
+
+        $value = $config->getUserKeys('userFetch8', 'appFetch1');
+        $this->assertEquals(['123', '456'], $value);
+        $this->assertIsString($value[0]);
+        $this->assertIsString($value[1]);
+
+        // cleanup
+        $this->connection->executeUpdate('DELETE FROM `*PREFIX*preferences`');
+    }
+
+    public function testGetUserValueDefault(): void {
+        $config = $this->getConfig();
+
+        $this->assertEquals('', $config->getUserValue('userGetUnset', 'appGetUnset', 'keyGetUnset'));
+        $this->assertEquals(null, $config->getUserValue('userGetUnset', 'appGetUnset', 'keyGetUnset', null));
+        $this->assertEquals('foobar', $config->getUserValue('userGetUnset', 'appGetUnset', 'keyGetUnset', 'foobar'));
+    }
+
+    public function testGetUserValueForUsers(): void {
+        $config = $this->getConfig();
+
+        // preparation - add something to the database
+        $data = [
+            ['userFetch1', 'appFetch2', 'keyFetch1', 'value1'],
+            ['userFetch2', 'appFetch2', 'keyFetch1', 'value2'],
+            ['userFetch3', 'appFetch2', 'keyFetch1', 3],
+            ['userFetch4', 'appFetch2', 'keyFetch1', 'value4'],
+            ['userFetch5', 'appFetch2', 'keyFetch1', 'value5'],
+            ['userFetch6', 'appFetch2', 'keyFetch1', 'value6'],
+            ['userFetch7', 'appFetch2', 'keyFetch1', 'value7']
+        ];
+        foreach ($data as $entry) {
+            $this->connection->executeUpdate(
+                'INSERT INTO `*PREFIX*preferences` (`userid`, `appid`, '
+                . '`configkey`, `configvalue`) VALUES (?, ?, ?, ?)',
+                $entry
+            );
+        }
+
+        $value = $config->getUserValueForUsers('appFetch2', 'keyFetch1',
+            ['userFetch1', 'userFetch2', 'userFetch3', 'userFetch5']);
+        $this->assertEquals([
+            'userFetch1' => 'value1',
+            'userFetch2' => 'value2',
+            'userFetch3' => 3,
+            'userFetch5' => 'value5'
+        ], $value);
+
+        $value = $config->getUserValueForUsers('appFetch2', 'keyFetch1',
+            ['userFetch1', 'userFetch4', 'userFetch9']);
+        $this->assertEquals([
+            'userFetch1' => 'value1',
+            'userFetch4' => 'value4'
+        ], $value, 'userFetch9 is an non-existent user and should not be shown.');
+
+        // cleanup
+        $this->connection->executeUpdate('DELETE FROM `*PREFIX*preferences`');
+    }
+
+    public function testDeleteAllUserValues(): void {
+        $config = $this->getConfig();
+
+        // preparation - add something to the database
+        $data = [
+            ['userFetch3', 'appFetch1', 'keyFetch1', 'value1'],
+            ['userFetch3', 'appFetch1', 'keyFetch2', 'value2'],
+            ['userFetch3', 'appFetch2', 'keyFetch3', 'value3'],
+            ['userFetch3', 'appFetch1', 'keyFetch4', 'value4'],
+            ['userFetch3', 'appFetch4', 'keyFetch1', 'value5'],
+            ['userFetch3', 'appFetch5', 'keyFetch1', 'value6'],
+            ['userFetch4', 'appFetch2', 'keyFetch1', 'value7']
+        ];
+        foreach ($data as $entry) {
+            $this->connection->executeUpdate(
+                'INSERT INTO `*PREFIX*preferences` (`userid`, `appid`, '
+                . '`configkey`, `configvalue`) VALUES (?, ?, ?, ?)',
+                $entry
+            );
+        }
+
+        $config->deleteAllUserValues('userFetch3');
+
+        $result = $this->connection->executeQuery(
+            'SELECT COUNT(*) AS `count` FROM `*PREFIX*preferences`'
+        )->fetchAssociative();
+        $actualCount = $result['count'];
+
+        $this->assertEquals(1, $actualCount, 'After removing `userFetch3` there should be exactly 1 entry left.');
+
+        // cleanup
+        $this->connection->executeUpdate('DELETE FROM `*PREFIX*preferences`');
+    }
+
+    public function testDeleteAppFromAllUsers(): void {
+        $config = $this->getConfig();
+
+        // preparation - add something to the database
+        $data = [
+            ['userFetch5', 'appFetch1', 'keyFetch1', 'value1'],
+            ['userFetch5', 'appFetch1', 'keyFetch2', 'value2'],
+            ['userFetch5', 'appFetch2', 'keyFetch3', 'value3'],
+            ['userFetch5', 'appFetch1', 'keyFetch4', 'value4'],
+            ['userFetch5', 'appFetch4', 'keyFetch1', 'value5'],
+            ['userFetch5', 'appFetch5', 'keyFetch1', 'value6'],
+            ['userFetch6', 'appFetch2', 'keyFetch1', 'value7']
+        ];
+        foreach ($data as $entry) {
+            $this->connection->executeUpdate(
+                'INSERT INTO `*PREFIX*preferences` (`userid`, `appid`, '
+                . '`configkey`, `configvalue`) VALUES (?, ?, ?, ?)',
+                $entry
+            );
+        }
+
+        $config->deleteAppFromAllUsers('appFetch1');
+
+        $result = $this->connection->executeQuery(
+            'SELECT COUNT(*) AS `count` FROM `*PREFIX*preferences`'
+        )->fetchAssociative();
+        $actualCount = $result['count'];
+
+        $this->assertEquals(4, $actualCount, 'After removing `appFetch1` there should be exactly 4 entries left.');
+
+        $config->deleteAppFromAllUsers('appFetch2');
+
+        $result = $this->connection->executeQuery(
+            'SELECT COUNT(*) AS `count` FROM `*PREFIX*preferences`'
+        )->fetchAssociative();
+        $actualCount = $result['count'];
+
+        $this->assertEquals(2, $actualCount, 'After removing `appFetch2` there should be exactly 2 entries left.');
+
+        // cleanup
+        $this->connection->executeUpdate('DELETE FROM `*PREFIX*preferences`');
+    }
+
+    public function testGetUsersForUserValue(): void {
+        // mock the check for the database to run the correct SQL statements for each database type
+        $systemConfig = $this->getMockBuilder('\OC\SystemConfig')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $config = $this->getConfig($systemConfig);
+
+        // preparation - add something to the database
+        $data = [
+            ['user1', 'appFetch9', 'keyFetch9', 'value9'],
+            ['user2', 'appFetch9', 'keyFetch9', 'value9'],
+            ['user3', 'appFetch9', 'keyFetch9', 'value8'],
+            ['user4', 'appFetch9', 'keyFetch8', 'value9'],
+            ['user5', 'appFetch8', 'keyFetch9', 'value9'],
+            ['user6', 'appFetch9', 'keyFetch9', 'value9'],
+        ];
+        foreach ($data as $entry) {
+            $this->connection->executeUpdate(
+                'INSERT INTO `*PREFIX*preferences` (`userid`, `appid`, '
+                . '`configkey`, `configvalue`) VALUES (?, ?, ?, ?)',
+                $entry
+            );
+        }
+
+        $value = $config->getUsersForUserValue('appFetch9', 'keyFetch9', 'value9');
+        $this->assertEquals(['user1', 'user2', 'user6'], $value);
+
+        // cleanup
+        $this->connection->executeUpdate('DELETE FROM `*PREFIX*preferences`');
+    }
+
+    public function testGetUsersForUserValueCaseInsensitive(): void {
+        // mock the check for the database to run the correct SQL statements for each database type
+        $systemConfig = $this->createMock(SystemConfig::class);
+        $config = $this->getConfig($systemConfig);
+
+        $config->setUserValue('user1', 'myApp', 'myKey', 'test123');
+        $config->setUserValue('user2', 'myApp', 'myKey', 'TEST123');
+        $config->setUserValue('user3', 'myApp', 'myKey', 'test12345');
+
+        $users = $config->getUsersForUserValueCaseInsensitive('myApp', 'myKey', 'test123');
+        $this->assertSame(2, count($users));
+        $this->assertSame(['user1', 'user2'], $users);
+    }
 }

tests/lib/SubAdminTest.php

Indentation +270 added lines, -270 removed lines

@@ -21,278 +21,278 @@
 
 #[\PHPUnit\Framework\Attributes\Group('DB')]
 class SubAdminTest extends \Test\TestCase {
-	/** @var IUserManager */
-	private $userManager;
-
-	/** @var IGroupManager */
-	private $groupManager;
-
-	/** @var IDBConnection */
-	private $dbConn;
-
-	/** @var IEventDispatcher */
-	private $eventDispatcher;
-
-	/** @var IUser[] */
-	private $users;
-
-	/** @var IGroup[] */
-	private $groups;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->users = [];
-		$this->groups = [];
-
-		$this->userManager = Server::get(IUserManager::class);
-		$this->groupManager = Server::get(IGroupManager::class);
-		$this->dbConn = Server::get(IDBConnection::class);
-		$this->eventDispatcher = Server::get(IEventDispatcher::class);
-
-		// Create 3 users and 3 groups
-		for ($i = 0; $i < 3; $i++) {
-			$this->users[] = $this->userManager->createUser('user' . $i, 'user');
-			$this->groups[] = $this->groupManager->createGroup('group' . $i);
-		}
-
-		// Create admin group
-		if (!$this->groupManager->groupExists('admin')) {
-			$this->groupManager->createGroup('admin');
-		}
-
-		// Create "orphaned" users and groups (scenario: temporarily disabled
-		// backend)
-		$qb = $this->dbConn->getQueryBuilder();
-		$qb->insert('group_admin')
-			->values([
-				'gid' => $qb->createNamedParameter($this->groups[0]->getGID()),
-				'uid' => $qb->createNamedParameter('orphanedUser')
-			])
-			->executeStatement();
-		$qb->insert('group_admin')
-			->values([
-				'gid' => $qb->createNamedParameter('orphanedGroup'),
-				'uid' => $qb->createNamedParameter('orphanedUser')
-			])
-			->executeStatement();
-		$qb->insert('group_admin')
-			->values([
-				'gid' => $qb->createNamedParameter('orphanedGroup'),
-				'uid' => $qb->createNamedParameter($this->users[0]->getUID())
-			])
-			->executeStatement();
-	}
-
-	protected function tearDown(): void {
-		foreach ($this->users as $user) {
-			$user->delete();
-		}
-
-		foreach ($this->groups as $group) {
-			$group->delete();
-		}
-
-		$qb = $this->dbConn->getQueryBuilder();
-		$qb->delete('group_admin')
-			->where($qb->expr()->eq('uid', $qb->createNamedParameter('orphanedUser')))
-			->orWhere($qb->expr()->eq('gid', $qb->createNamedParameter('orphanedGroup')))
-			->executeStatement();
-	}
-
-	public function testCreateSubAdmin(): void {
-		$subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
-		$subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
-
-		// Look for subadmin in the database
-		$qb = $this->dbConn->getQueryBuilder();
-		$result = $qb->select(['gid', 'uid'])
-			->from('group_admin')
-			->where($qb->expr()->eq('gid', $qb->createNamedParameter($this->groups[0]->getGID())))
-			->andWHere($qb->expr()->eq('uid', $qb->createNamedParameter($this->users[0]->getUID())))
-			->executeQuery()
-			->fetchAssociative();
-		$this->assertEquals(
-			[
-				'gid' => $this->groups[0]->getGID(),
-				'uid' => $this->users[0]->getUID()
-			], $result);
-
-		// Delete subadmin
-		$qb->delete('group_admin')
-			->where($qb->expr()->eq('gid', $qb->createNamedParameter($this->groups[0]->getGID())))
-			->andWHere($qb->expr()->eq('uid', $qb->createNamedParameter($this->users[0]->getUID())))
-			->executeStatement();
-	}
-
-	public function testDeleteSubAdmin(): void {
-		$subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
-		$subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
-		$subAdmin->deleteSubAdmin($this->users[0], $this->groups[0]);
-
-		// DB query should be empty
-		$qb = $this->dbConn->getQueryBuilder();
-		$result = $qb->select(['gid', 'uid'])
-			->from('group_admin')
-			->where($qb->expr()->eq('gid', $qb->createNamedParameter($this->groups[0]->getGID())))
-			->andWHere($qb->expr()->eq('uid', $qb->createNamedParameter($this->users[0]->getUID())))
-			->executeQuery()
-			->fetchAssociative();
-		$this->assertEmpty($result);
-	}
-
-	public function testGetSubAdminsGroups(): void {
-		$subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
-		$subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
-		$subAdmin->createSubAdmin($this->users[0], $this->groups[1]);
-
-		$result = $subAdmin->getSubAdminsGroups($this->users[0]);
-
-		$this->assertContains($this->groups[0], $result);
-		$this->assertContains($this->groups[1], $result);
-		$this->assertNotContains($this->groups[2], $result);
-		$this->assertNotContains(null, $result);
-
-		$subAdmin->deleteSubAdmin($this->users[0], $this->groups[0]);
-		$subAdmin->deleteSubAdmin($this->users[0], $this->groups[1]);
-	}
-
-	public function testGetGroupsSubAdmins(): void {
-		$subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
-		$subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
-		$subAdmin->createSubAdmin($this->users[1], $this->groups[0]);
-
-		$result = $subAdmin->getGroupsSubAdmins($this->groups[0]);
-
-		$this->assertContains($this->users[0], $result);
-		$this->assertContains($this->users[1], $result);
-		$this->assertNotContains($this->users[2], $result);
-		$this->assertNotContains(null, $result);
-
-		$subAdmin->deleteSubAdmin($this->users[0], $this->groups[0]);
-		$subAdmin->deleteSubAdmin($this->users[1], $this->groups[0]);
-	}
-
-	public function testGetAllSubAdmin(): void {
-		$subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
-
-		$subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
-		$subAdmin->createSubAdmin($this->users[1], $this->groups[1]);
-		$subAdmin->createSubAdmin($this->users[2], $this->groups[1]);
-
-		$result = $subAdmin->getAllSubAdmins();
-
-		$this->assertContains(['user' => $this->users[0], 'group' => $this->groups[0]], $result);
-		$this->assertContains(['user' => $this->users[1], 'group' => $this->groups[1]], $result);
-		$this->assertContains(['user' => $this->users[2], 'group' => $this->groups[1]], $result);
-		$this->assertNotContains(['user' => null, 'group' => null], $result);
-	}
-
-	public function testIsSubAdminofGroup(): void {
-		$subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
-		$subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
-
-		$this->assertTrue($subAdmin->isSubAdminOfGroup($this->users[0], $this->groups[0]));
-		$this->assertFalse($subAdmin->isSubAdminOfGroup($this->users[0], $this->groups[1]));
-		$this->assertFalse($subAdmin->isSubAdminOfGroup($this->users[1], $this->groups[0]));
-
-		$subAdmin->deleteSubAdmin($this->users[0], $this->groups[0]);
-	}
-
-	public function testIsSubAdmin(): void {
-		$subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
-		$subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
-
-		$this->assertTrue($subAdmin->isSubAdmin($this->users[0]));
-		$this->assertFalse($subAdmin->isSubAdmin($this->users[1]));
-
-		$subAdmin->deleteSubAdmin($this->users[0], $this->groups[0]);
-	}
-
-	public function testIsSubAdminAsAdmin(): void {
-		$subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
-		$this->groupManager->get('admin')->addUser($this->users[0]);
-
-		$this->assertTrue($subAdmin->isSubAdmin($this->users[0]));
-	}
-
-	public function testIsUserAccessible(): void {
-		$subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
-		$this->groups[0]->addUser($this->users[1]);
-		$this->groups[1]->addUser($this->users[1]);
-		$this->groups[1]->addUser($this->users[2]);
-		$subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
-		$subAdmin->createSubAdmin($this->users[2], $this->groups[2]);
-
-		$this->assertTrue($subAdmin->isUserAccessible($this->users[0], $this->users[1]));
-		$this->assertFalse($subAdmin->isUserAccessible($this->users[0], $this->users[2]));
-		$this->assertFalse($subAdmin->isUserAccessible($this->users[2], $this->users[0]));
-
-		$subAdmin->deleteSubAdmin($this->users[0], $this->groups[0]);
-		$subAdmin->deleteSubAdmin($this->users[2], $this->groups[2]);
-	}
-
-	public function testIsUserAccessibleAsUser(): void {
-		$subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
-		$this->assertFalse($subAdmin->isUserAccessible($this->users[0], $this->users[1]));
-	}
-
-	public function testIsUserAccessibleAdmin(): void {
-		$subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
-		$subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
-		$this->groupManager->get('admin')->addUser($this->users[1]);
-
-		$this->assertFalse($subAdmin->isUserAccessible($this->users[0], $this->users[1]));
-	}
+    /** @var IUserManager */
+    private $userManager;
+
+    /** @var IGroupManager */
+    private $groupManager;
+
+    /** @var IDBConnection */
+    private $dbConn;
+
+    /** @var IEventDispatcher */
+    private $eventDispatcher;
+
+    /** @var IUser[] */
+    private $users;
+
+    /** @var IGroup[] */
+    private $groups;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->users = [];
+        $this->groups = [];
+
+        $this->userManager = Server::get(IUserManager::class);
+        $this->groupManager = Server::get(IGroupManager::class);
+        $this->dbConn = Server::get(IDBConnection::class);
+        $this->eventDispatcher = Server::get(IEventDispatcher::class);
+
+        // Create 3 users and 3 groups
+        for ($i = 0; $i < 3; $i++) {
+            $this->users[] = $this->userManager->createUser('user' . $i, 'user');
+            $this->groups[] = $this->groupManager->createGroup('group' . $i);
+        }
+
+        // Create admin group
+        if (!$this->groupManager->groupExists('admin')) {
+            $this->groupManager->createGroup('admin');
+        }
+
+        // Create "orphaned" users and groups (scenario: temporarily disabled
+        // backend)
+        $qb = $this->dbConn->getQueryBuilder();
+        $qb->insert('group_admin')
+            ->values([
+                'gid' => $qb->createNamedParameter($this->groups[0]->getGID()),
+                'uid' => $qb->createNamedParameter('orphanedUser')
+            ])
+            ->executeStatement();
+        $qb->insert('group_admin')
+            ->values([
+                'gid' => $qb->createNamedParameter('orphanedGroup'),
+                'uid' => $qb->createNamedParameter('orphanedUser')
+            ])
+            ->executeStatement();
+        $qb->insert('group_admin')
+            ->values([
+                'gid' => $qb->createNamedParameter('orphanedGroup'),
+                'uid' => $qb->createNamedParameter($this->users[0]->getUID())
+            ])
+            ->executeStatement();
+    }
+
+    protected function tearDown(): void {
+        foreach ($this->users as $user) {
+            $user->delete();
+        }
+
+        foreach ($this->groups as $group) {
+            $group->delete();
+        }
+
+        $qb = $this->dbConn->getQueryBuilder();
+        $qb->delete('group_admin')
+            ->where($qb->expr()->eq('uid', $qb->createNamedParameter('orphanedUser')))
+            ->orWhere($qb->expr()->eq('gid', $qb->createNamedParameter('orphanedGroup')))
+            ->executeStatement();
+    }
+
+    public function testCreateSubAdmin(): void {
+        $subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
+        $subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
+
+        // Look for subadmin in the database
+        $qb = $this->dbConn->getQueryBuilder();
+        $result = $qb->select(['gid', 'uid'])
+            ->from('group_admin')
+            ->where($qb->expr()->eq('gid', $qb->createNamedParameter($this->groups[0]->getGID())))
+            ->andWHere($qb->expr()->eq('uid', $qb->createNamedParameter($this->users[0]->getUID())))
+            ->executeQuery()
+            ->fetchAssociative();
+        $this->assertEquals(
+            [
+                'gid' => $this->groups[0]->getGID(),
+                'uid' => $this->users[0]->getUID()
+            ], $result);
+
+        // Delete subadmin
+        $qb->delete('group_admin')
+            ->where($qb->expr()->eq('gid', $qb->createNamedParameter($this->groups[0]->getGID())))
+            ->andWHere($qb->expr()->eq('uid', $qb->createNamedParameter($this->users[0]->getUID())))
+            ->executeStatement();
+    }
+
+    public function testDeleteSubAdmin(): void {
+        $subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
+        $subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
+        $subAdmin->deleteSubAdmin($this->users[0], $this->groups[0]);
+
+        // DB query should be empty
+        $qb = $this->dbConn->getQueryBuilder();
+        $result = $qb->select(['gid', 'uid'])
+            ->from('group_admin')
+            ->where($qb->expr()->eq('gid', $qb->createNamedParameter($this->groups[0]->getGID())))
+            ->andWHere($qb->expr()->eq('uid', $qb->createNamedParameter($this->users[0]->getUID())))
+            ->executeQuery()
+            ->fetchAssociative();
+        $this->assertEmpty($result);
+    }
+
+    public function testGetSubAdminsGroups(): void {
+        $subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
+        $subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
+        $subAdmin->createSubAdmin($this->users[0], $this->groups[1]);
+
+        $result = $subAdmin->getSubAdminsGroups($this->users[0]);
+
+        $this->assertContains($this->groups[0], $result);
+        $this->assertContains($this->groups[1], $result);
+        $this->assertNotContains($this->groups[2], $result);
+        $this->assertNotContains(null, $result);
+
+        $subAdmin->deleteSubAdmin($this->users[0], $this->groups[0]);
+        $subAdmin->deleteSubAdmin($this->users[0], $this->groups[1]);
+    }
+
+    public function testGetGroupsSubAdmins(): void {
+        $subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
+        $subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
+        $subAdmin->createSubAdmin($this->users[1], $this->groups[0]);
+
+        $result = $subAdmin->getGroupsSubAdmins($this->groups[0]);
+
+        $this->assertContains($this->users[0], $result);
+        $this->assertContains($this->users[1], $result);
+        $this->assertNotContains($this->users[2], $result);
+        $this->assertNotContains(null, $result);
+
+        $subAdmin->deleteSubAdmin($this->users[0], $this->groups[0]);
+        $subAdmin->deleteSubAdmin($this->users[1], $this->groups[0]);
+    }
+
+    public function testGetAllSubAdmin(): void {
+        $subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
+
+        $subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
+        $subAdmin->createSubAdmin($this->users[1], $this->groups[1]);
+        $subAdmin->createSubAdmin($this->users[2], $this->groups[1]);
+
+        $result = $subAdmin->getAllSubAdmins();
+
+        $this->assertContains(['user' => $this->users[0], 'group' => $this->groups[0]], $result);
+        $this->assertContains(['user' => $this->users[1], 'group' => $this->groups[1]], $result);
+        $this->assertContains(['user' => $this->users[2], 'group' => $this->groups[1]], $result);
+        $this->assertNotContains(['user' => null, 'group' => null], $result);
+    }
+
+    public function testIsSubAdminofGroup(): void {
+        $subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
+        $subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
+
+        $this->assertTrue($subAdmin->isSubAdminOfGroup($this->users[0], $this->groups[0]));
+        $this->assertFalse($subAdmin->isSubAdminOfGroup($this->users[0], $this->groups[1]));
+        $this->assertFalse($subAdmin->isSubAdminOfGroup($this->users[1], $this->groups[0]));
+
+        $subAdmin->deleteSubAdmin($this->users[0], $this->groups[0]);
+    }
+
+    public function testIsSubAdmin(): void {
+        $subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
+        $subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
+
+        $this->assertTrue($subAdmin->isSubAdmin($this->users[0]));
+        $this->assertFalse($subAdmin->isSubAdmin($this->users[1]));
+
+        $subAdmin->deleteSubAdmin($this->users[0], $this->groups[0]);
+    }
+
+    public function testIsSubAdminAsAdmin(): void {
+        $subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
+        $this->groupManager->get('admin')->addUser($this->users[0]);
+
+        $this->assertTrue($subAdmin->isSubAdmin($this->users[0]));
+    }
+
+    public function testIsUserAccessible(): void {
+        $subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
+        $this->groups[0]->addUser($this->users[1]);
+        $this->groups[1]->addUser($this->users[1]);
+        $this->groups[1]->addUser($this->users[2]);
+        $subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
+        $subAdmin->createSubAdmin($this->users[2], $this->groups[2]);
+
+        $this->assertTrue($subAdmin->isUserAccessible($this->users[0], $this->users[1]));
+        $this->assertFalse($subAdmin->isUserAccessible($this->users[0], $this->users[2]));
+        $this->assertFalse($subAdmin->isUserAccessible($this->users[2], $this->users[0]));
+
+        $subAdmin->deleteSubAdmin($this->users[0], $this->groups[0]);
+        $subAdmin->deleteSubAdmin($this->users[2], $this->groups[2]);
+    }
+
+    public function testIsUserAccessibleAsUser(): void {
+        $subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
+        $this->assertFalse($subAdmin->isUserAccessible($this->users[0], $this->users[1]));
+    }
+
+    public function testIsUserAccessibleAdmin(): void {
+        $subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
+        $subAdmin->createSubAdmin($this->users[0], $this->groups[0]);
+        $this->groupManager->get('admin')->addUser($this->users[1]);
+
+        $this->assertFalse($subAdmin->isUserAccessible($this->users[0], $this->users[1]));
+    }
 
-	public function testPostDeleteUser(): void {
-		$subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
-
-		$user = array_shift($this->users);
-		foreach ($this->groups as $group) {
-			$subAdmin->createSubAdmin($user, $group);
-		}
+    public function testPostDeleteUser(): void {
+        $subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
+
+        $user = array_shift($this->users);
+        foreach ($this->groups as $group) {
+            $subAdmin->createSubAdmin($user, $group);
+        }
 
-		$user->delete();
-		$this->assertEmpty($subAdmin->getAllSubAdmins());
-	}
+        $user->delete();
+        $this->assertEmpty($subAdmin->getAllSubAdmins());
+    }
 
-	public function testPostDeleteGroup(): void {
-		$subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
-
-		$group = array_shift($this->groups);
-		foreach ($this->users as $user) {
-			$subAdmin->createSubAdmin($user, $group);
-		}
-
-		$group->delete();
-		$this->assertEmpty($subAdmin->getAllSubAdmins());
-	}
+    public function testPostDeleteGroup(): void {
+        $subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
+
+        $group = array_shift($this->groups);
+        foreach ($this->users as $user) {
+            $subAdmin->createSubAdmin($user, $group);
+        }
+
+        $group->delete();
+        $this->assertEmpty($subAdmin->getAllSubAdmins());
+    }
 
-	public function testHooks(): void {
-		$subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
-
-		$test = $this;
-		$u = $this->users[0];
-		$g = $this->groups[0];
-		$count = 0;
-
-		$this->eventDispatcher->addListener(SubAdminAddedEvent::class, function (SubAdminAddedEvent $event) use ($test, $u, $g, &$count): void {
-			$test->assertEquals($u->getUID(), $event->getUser()->getUID());
-			$test->assertEquals($g->getGID(), $event->getGroup()->getGID());
-			$count++;
-		});
-
-		$this->eventDispatcher->addListener(SubAdminRemovedEvent::class, function ($event) use ($test, $u, $g, &$count): void {
-			$test->assertEquals($u->getUID(), $event->getUser()->getUID());
-			$test->assertEquals($g->getGID(), $event->getGroup()->getGID());
-			$count++;
-		});
-
-		$subAdmin->createSubAdmin($u, $g);
-		$this->assertEquals(1, $count);
-
-		$subAdmin->deleteSubAdmin($u, $g);
-		$this->assertEquals(2, $count);
-	}
+    public function testHooks(): void {
+        $subAdmin = new SubAdmin($this->userManager, $this->groupManager, $this->dbConn, $this->eventDispatcher);
+
+        $test = $this;
+        $u = $this->users[0];
+        $g = $this->groups[0];
+        $count = 0;
+
+        $this->eventDispatcher->addListener(SubAdminAddedEvent::class, function (SubAdminAddedEvent $event) use ($test, $u, $g, &$count): void {
+            $test->assertEquals($u->getUID(), $event->getUser()->getUID());
+            $test->assertEquals($g->getGID(), $event->getGroup()->getGID());
+            $count++;
+        });
+
+        $this->eventDispatcher->addListener(SubAdminRemovedEvent::class, function ($event) use ($test, $u, $g, &$count): void {
+            $test->assertEquals($u->getUID(), $event->getUser()->getUID());
+            $test->assertEquals($g->getGID(), $event->getGroup()->getGID());
+            $count++;
+        });
+
+        $subAdmin->createSubAdmin($u, $g);
+        $this->assertEquals(1, $count);
+
+        $subAdmin->deleteSubAdmin($u, $g);
+        $this->assertEquals(2, $count);
+    }
 }