Completed
Pull Request — master (#7195)
by Jan-Christoph
17:09 queued 02:45
created
apps/files_external/lib/Lib/Auth/PublicKey/RSA.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
 	/**
70 70
 	 * Generate a keypair
71 71
 	 *
72
-	 * @param int $keyLenth
72
+	 * @param integer $keyLength
73 73
 	 * @return array ['privatekey' => $privateKey, 'publickey' => $publicKey]
74 74
 	 */
75 75
 	public function createKey($keyLength) {
Please login to merge, or discard this patch.
apps/dav/lib/Upload/AssemblyStream.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -126,7 +126,7 @@
 block discarded – undo
126 126
 
127 127
 	/**
128 128
 	 * @param string $data
129
-	 * @return int
129
+	 * @return boolean
130 130
 	 */
131 131
 	public function stream_write($data) {
132 132
 		return false;
Please login to merge, or discard this patch.
lib/private/Share20/ProviderFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -176,7 +176,7 @@
 block discarded – undo
176 176
 	/**
177 177
 	 * Create the circle share provider
178 178
 	 *
179
-	 * @return FederatedShareProvider
179
+	 * @return null|\OCA\Circles\ShareByCircleProvider
180 180
 	 *
181 181
 	 * @suppress PhanUndeclaredClassMethod
182 182
 	 */
Please login to merge, or discard this patch.
lib/private/DB/MigrationService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -271,7 +271,7 @@
 block discarded – undo
271 271
 	 * Return the explicit version for the aliases; current, next, prev, latest
272 272
 	 *
273 273
 	 * @param string $alias
274
-	 * @return mixed|null|string
274
+	 * @return string
275 275
 	 */
276 276
 	public function getMigration($alias) {
277 277
 		switch($alias) {
Please login to merge, or discard this patch.
lib/private/Repair/NC13/RepairInvalidPaths.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -83,6 +83,9 @@
 block discarded – undo
83 83
 		} while (count($rows) > 0);
84 84
 	}
85 85
 
86
+	/**
87
+	 * @param string $path
88
+	 */
86 89
 	private function getId($storage, $path) {
87 90
 		if (!$this->getIdQuery) {
88 91
 			$builder = $this->connection->getQueryBuilder();
Please login to merge, or discard this patch.
lib/public/Files.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,6 +47,7 @@  discard block
 block discarded – undo
47 47
 class Files {
48 48
 	/**
49 49
 	 * Recusive deletion of folders
50
+	 * @param string $dir
50 51
 	 * @return bool
51 52
 	 * @since 5.0.0
52 53
 	 */
@@ -68,7 +69,7 @@  discard block
 block discarded – undo
68 69
 	/**
69 70
 	 * Search for files by mimetype
70 71
 	 * @param string $mimetype
71
-	 * @return array
72
+	 * @return \OC\Files\FileInfo[]
72 73
 	 * @since 6.0.0
73 74
 	 */
74 75
 	static public function searchByMime($mimetype) {
Please login to merge, or discard this patch.
lib/private/Archive/TAR.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -370,6 +370,7 @@
 block discarded – undo
370 370
 
371 371
 	/**
372 372
 	 * write back temporary files
373
+	 * @param string $path
373 374
 	 */
374 375
 	public function writeBack($tmpFile, $path) {
375 376
 		$this->addFile($path, $tmpFile);
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/CalDavBackend.php 1 patch
Doc Comments   +10 added lines, -4 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 	 *
183 183
 	 * By default this excludes the automatically generated birthday calendar
184 184
 	 *
185
-	 * @param $principalUri
185
+	 * @param string $principalUri
186 186
 	 * @param bool $excludeBirthday
187 187
 	 * @return int
188 188
 	 */
@@ -351,6 +351,9 @@  discard block
 block discarded – undo
351 351
 		return array_values($calendars);
352 352
 	}
353 353
 
354
+	/**
355
+	 * @param string $principalUri
356
+	 */
354 357
 	public function getUsersOwnCalendars($principalUri) {
355 358
 		$principalUri = $this->convertPrincipal($principalUri, true);
356 359
 		$fields = array_values($this->propertyMap);
@@ -946,7 +949,7 @@  discard block
 block discarded – undo
946 949
 	 * calendar-data. If the result of a subsequent GET to this object is not
947 950
 	 * the exact same as this request body, you should omit the ETag.
948 951
 	 *
949
-	 * @param mixed $calendarId
952
+	 * @param integer $calendarId
950 953
 	 * @param string $objectUri
951 954
 	 * @param string $calendarData
952 955
 	 * @return string
@@ -1000,7 +1003,7 @@  discard block
 block discarded – undo
1000 1003
 	 * calendar-data. If the result of a subsequent GET to this object is not
1001 1004
 	 * the exact same as this request body, you should omit the ETag.
1002 1005
 	 *
1003
-	 * @param mixed $calendarId
1006
+	 * @param integer $calendarId
1004 1007
 	 * @param string $objectUri
1005 1008
 	 * @param string $calendarData
1006 1009
 	 * @return string
@@ -1563,7 +1566,7 @@  discard block
 block discarded – undo
1563 1566
 	 * @param string $principalUri
1564 1567
 	 * @param string $uri
1565 1568
 	 * @param array $properties
1566
-	 * @return mixed
1569
+	 * @return integer
1567 1570
 	 */
1568 1571
 	function createSubscription($principalUri, $uri, array $properties) {
1569 1572
 
@@ -2103,6 +2106,9 @@  discard block
 block discarded – undo
2103 2106
 		return (int)$objectIds['id'];
2104 2107
 	}
2105 2108
 
2109
+	/**
2110
+	 * @param boolean $toV2
2111
+	 */
2106 2112
 	private function convertPrincipal($principalUri, $toV2) {
2107 2113
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
2108 2114
 			list(, $name) = Uri\split($principalUri);
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/CardDavBackend.php 1 patch
Doc Comments   +11 added lines, -3 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 	/**
105 105
 	 * Return the number of address books for a principal
106 106
 	 *
107
-	 * @param $principalUri
107
+	 * @param string $principalUri
108 108
 	 * @return int
109 109
 	 */
110 110
 	public function getAddressBooksForUserCount($principalUri) {
@@ -219,6 +219,9 @@  discard block
 block discarded – undo
219 219
 		return array_values($addressBooks);
220 220
 	}
221 221
 
222
+	/**
223
+	 * @param string $principalUri
224
+	 */
222 225
 	public function getUsersOwnAddressBooks($principalUri) {
223 226
 		$principalUri = $this->convertPrincipal($principalUri, true);
224 227
 		$query = $this->db->getQueryBuilder();
@@ -293,7 +296,8 @@  discard block
 block discarded – undo
293 296
 	}
294 297
 
295 298
 	/**
296
-	 * @param $addressBookUri
299
+	 * @param string $addressBookUri
300
+	 * @param string $principal
297 301
 	 * @return array|null
298 302
 	 */
299 303
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -982,6 +986,7 @@  discard block
 block discarded – undo
982 986
 	 *   * readOnly - boolean
983 987
 	 *   * summary - Optional, a description for the share
984 988
 	 *
989
+	 * @param integer $addressBookId
985 990
 	 * @return array
986 991
 	 */
987 992
 	public function getShares($addressBookId) {
@@ -1081,7 +1086,7 @@  discard block
 block discarded – undo
1081 1086
 
1082 1087
 	/**
1083 1088
 	 * For shared address books the sharee is set in the ACL of the address book
1084
-	 * @param $addressBookId
1089
+	 * @param integer $addressBookId
1085 1090
 	 * @param $acl
1086 1091
 	 * @return array
1087 1092
 	 */
@@ -1089,6 +1094,9 @@  discard block
 block discarded – undo
1089 1094
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
1090 1095
 	}
1091 1096
 
1097
+	/**
1098
+	 * @param boolean $toV2
1099
+	 */
1092 1100
 	private function convertPrincipal($principalUri, $toV2) {
1093 1101
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1094 1102
 			list(, $name) = \Sabre\Uri\split($principalUri);
Please login to merge, or discard this patch.