Completed
Pull Request — master (#7195)
by Jan-Christoph
17:09 queued 02:45
created
lib/private/Updater.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -431,7 +431,7 @@
 block discarded – undo
431 431
 	}
432 432
 
433 433
 	/**
434
-	 * @param array $disabledApps
434
+	 * @param string[] $disabledApps
435 435
 	 * @throws \Exception
436 436
 	 */
437 437
 	private function upgradeAppStoreApps(array $disabledApps) {
Please login to merge, or discard this patch.
lib/private/Diagnostics/Query.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,6 +48,9 @@  discard block
 block discarded – undo
48 48
 		$this->stack = $stack;
49 49
 	}
50 50
 
51
+	/**
52
+	 * @param double $time
53
+	 */
51 54
 	public function end($time) {
52 55
 		$this->end = $time;
53 56
 	}
@@ -67,7 +70,7 @@  discard block
 block discarded – undo
67 70
 	}
68 71
 
69 72
 	/**
70
-	 * @return float
73
+	 * @return integer
71 74
 	 */
72 75
 	public function getStart() {
73 76
 		return $this->start;
Please login to merge, or discard this patch.
apps/dav/lib/Connector/Sabre/FilesPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -448,7 +448,7 @@
 block discarded – undo
448 448
 	 *
449 449
 	 * @param string $path source path
450 450
 	 * @param string $destination destination path
451
-	 * @return bool|void false to stop handling, void to skip this handler
451
+	 * @return null|false false to stop handling, void to skip this handler
452 452
 	 */
453 453
 	public function beforeMoveFutureFile($path, $destination) {
454 454
 		$sourceNode = $this->tree->getNodeForPath($path);
Please login to merge, or discard this patch.
apps/theming/lib/Util.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 	/**
72 72
 	 * get color for on-page elements:
73 73
 	 * theme color by default, grey if theme color is to bright
74
-	 * @param $color
74
+	 * @param string $color
75 75
 	 * @return string
76 76
 	 */
77 77
 	public function elementColor($color) {
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 
115 115
 	/**
116 116
 	 * @param $app string app name
117
-	 * @return string|ISimpleFile path to app icon / file of logo
117
+	 * @return string path to app icon / file of logo
118 118
 	 */
119 119
 	public function getAppIcon($app) {
120 120
 		$app = str_replace(array('\0', '/', '\\', '..'), '', $app);
@@ -190,8 +190,8 @@  discard block
 block discarded – undo
190 190
 	/**
191 191
 	 * replace default color with a custom one
192 192
 	 *
193
-	 * @param $svg string content of a svg file
194
-	 * @param $color string color to match
193
+	 * @param string $svg string content of a svg file
194
+	 * @param string $color string color to match
195 195
 	 * @return string
196 196
 	 */
197 197
 	public function colorizeSvg($svg, $color) {
Please login to merge, or discard this patch.
lib/private/Settings/Manager.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -265,6 +265,9 @@  discard block
 block discarded – undo
265 265
 		return $this->mapper->has($table, $className);
266 266
 	}
267 267
 
268
+	/**
269
+	 * @param string $type
270
+	 */
268 271
 	private function setupSettingsEntry($settingsClassName, $type) {
269 272
 		if (!class_exists($settingsClassName)) {
270 273
 			$this->log->debug('Could not find ' . $type . ' section class ' . $settingsClassName);
@@ -294,6 +297,9 @@  discard block
 block discarded – undo
294 297
 		}
295 298
 	}
296 299
 
300
+	/**
301
+	 * @param string $type
302
+	 */
297 303
 	private function getSectionTableForType($type) {
298 304
 		if($type === 'admin') {
299 305
 			return Mapper::TABLE_ADMIN_SECTIONS;
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Storage/AmazonS3.php 1 patch
Doc Comments   +10 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,6 +86,9 @@  discard block
 block discarded – undo
86 86
 		return $path === '.';
87 87
 	}
88 88
 
89
+	/**
90
+	 * @param string $path
91
+	 */
89 92
 	private function cleanKey($path) {
90 93
 		if ($this->isRoot($path)) {
91 94
 			return '/';
@@ -109,7 +112,7 @@  discard block
 block discarded – undo
109 112
 	}
110 113
 
111 114
 	/**
112
-	 * @param $key
115
+	 * @param string $key
113 116
 	 * @return Result|boolean
114 117
 	 */
115 118
 	private function headObject($key) {
@@ -236,6 +239,9 @@  discard block
 block discarded – undo
236 239
 		return false;
237 240
 	}
238 241
 
242
+	/**
243
+	 * @param string $path
244
+	 */
239 245
 	private function batchDelete($path = null) {
240 246
 		$params = array(
241 247
 			'Bucket' => $this->bucket
@@ -581,6 +587,9 @@  discard block
 block discarded – undo
581 587
 		return $this->id;
582 588
 	}
583 589
 
590
+	/**
591
+	 * @param string $path
592
+	 */
584 593
 	public function writeBack($tmpFile, $path) {
585 594
 		try {
586 595
 			$source = fopen($tmpFile, 'r');
Please login to merge, or discard this patch.
lib/private/Session/Internal.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -164,7 +164,7 @@
 block discarded – undo
164 164
 	 * @param array $parameters
165 165
 	 * @param bool $silence whether to suppress warnings
166 166
 	 * @throws \ErrorException via trapError
167
-	 * @return mixed
167
+	 * @return string
168 168
 	 */
169 169
 	private function invoke($functionName, array $parameters = [], $silence = false) {
170 170
 		try {
Please login to merge, or discard this patch.
settings/Controller/CommonSettingsTrait.php 1 patch
Doc Comments   +13 added lines patch added patch discarded remove patch
@@ -51,6 +51,9 @@  discard block
 block discarded – undo
51 51
 		];
52 52
 	}
53 53
 
54
+	/**
55
+	 * @param string $type
56
+	 */
54 57
 	protected function formatSections($sections, $currentSection, $type, $currentType) {
55 58
 		$templateParameters = [];
56 59
 		/** @var \OCP\Settings\ISection[] $prioritizedSections */
@@ -84,6 +87,9 @@  discard block
 block discarded – undo
84 87
 		return $templateParameters;
85 88
 	}
86 89
 
90
+	/**
91
+	 * @param string $currentSections
92
+	 */
87 93
 	protected function formatPersonalSections($currentType, $currentSections) {
88 94
 		$sections = $this->settingsManager->getPersonalSections();
89 95
 		$templateParameters = $this->formatSections($sections, $currentSections, 'personal', $currentType);
@@ -91,6 +97,9 @@  discard block
 block discarded – undo
91 97
 		return $templateParameters;
92 98
 	}
93 99
 
100
+	/**
101
+	 * @param string $currentSections
102
+	 */
94 103
 	protected function formatAdminSections($currentType, $currentSections) {
95 104
 		$sections = $this->settingsManager->getAdminSections();
96 105
 		$templateParameters = $this->formatSections($sections, $currentSections, 'admin', $currentType);
@@ -114,6 +123,10 @@  discard block
 block discarded – undo
114 123
 		return ['content' => $html];
115 124
 	}
116 125
 
126
+	/**
127
+	 * @param string $type
128
+	 * @param string $section
129
+	 */
117 130
 	private function getIndexResponse($type, $section) {
118 131
 		$templateParams = [];
119 132
 		$templateParams = array_merge($templateParams, $this->getNavigationParameters($type, $section));
Please login to merge, or discard this patch.
apps/user_ldap/lib/LogWrapper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
 
33 33
 	/**
34 34
 	 * @brief states whether the filesystem was loaded
35
-	 * @return bool
35
+	 * @return boolean|null
36 36
 	 */
37 37
 	public function log($msg, $level) {
38 38
 		\OCP\Util::writeLog($this->app, $msg, $level);
Please login to merge, or discard this patch.