Server - Code Metrics - Inspection of "Merge pull request #9029 from nextcloud/settings-r..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 94010e...d161d4 )

by Morris

created 2018-05-07 10:29 UTC

Server A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	65
Duplicated Lines	16.92 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
dl	11
loc	65
rs	10
c	0
b	0
f	0
wmc	5
lcom	1
cbo	3

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	11	11	1
A	getForm()	0	12	2
A	getSection()	0	3	1
A	getPriority()	0	3	1

How to fix Duplicated Code

<?php
/**
 * @copyright Copyright (c) 2016 Arthur Schiwon <[email protected]>
 *
 * @author Arthur Schiwon <[email protected]>
 * @author Joas Schilling <[email protected]>
 * @author Lukas Reschke <[email protected]>
 * @author Morris Jobke <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OC\Settings\Admin;

use Doctrine\DBAL\Connection;
use Doctrine\DBAL\DBALException;
use Doctrine\DBAL\Platforms\SqlitePlatform;
use OC\Lock\DBLockingProvider;
use OC\Lock\NoopLockingProvider;
use OCP\AppFramework\Http\TemplateResponse;
use OCP\IConfig;
use OCP\IDBConnection;
use OCP\IL10N;
use OCP\IRequest;
use OCP\Lock\ILockingProvider;
use OCP\Settings\ISettings;

class Server implements ISettings {
	/** @var IDBConnection|Connection */
	private $db;
	/** @var IRequest */
	private $request;
	/** @var IConfig */
	private $config;
	/** @var ILockingProvider */
	private $lockingProvider;
	/** @var IL10N */
	private $l;

	/**
	 * @param IDBConnection $db
	 * @param IRequest $request
	 * @param IConfig $config
	 * @param ILockingProvider $lockingProvider
	 * @param IL10N $l
	 */
	public function __construct(IDBConnection $db,
								IRequest $request,
								IConfig $config,
								ILockingProvider $lockingProvider,
								IL10N $l) {
		$this->db = $db;
		$this->request = $request;
		$this->config = $config;
		$this->lockingProvider = $lockingProvider;
		$this->l = $l;
	}

	/**
	 * @return TemplateResponse
	 */
	public function getForm() {
		$parameters = [
			// Background jobs
			'backgroundjobs_mode' => $this->config->getAppValue('core', 'backgroundjobs_mode', 'ajax'),
			'lastcron'            => $this->config->getAppValue('core', 'lastcron', false),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			'cronErrors'		  => $this->config->getAppValue('core', 'cronErrors'),
			'cli_based_cron_possible' => function_exists('posix_getpwuid'),
			'cli_based_cron_user' => function_exists('posix_getpwuid') ? posix_getpwuid(fileowner(\OC::$configDir . 'config.php'))['name'] : '',
		];

		return new TemplateResponse('settings', 'settings/admin/server', $parameters, '');
	}

	/**
	 * @return string the section ID, e.g. 'sharing'
	 */
	public function getSection() {
		return 'server';
	}

	/**
	 * @return int whether the form should be rather on the top or bottom of
	 * the admin section. The forms are arranged in ascending order of the
	 * priority values. It is required to return a value between 0 and 100.
	 *
	 * E.g.: 70
	 */
	public function getPriority() {
		return 0;
	}
}


1		<?php
2		/**
3		* @copyright Copyright (c) 2016 Arthur Schiwon <[email protected]>
4		*
5		* @author Arthur Schiwon <[email protected]>
6		* @author Joas Schilling <[email protected]>
7		* @author Lukas Reschke <[email protected]>
8		* @author Morris Jobke <[email protected]>
9		*
10		* @license GNU AGPL version 3 or any later version
11		*
12		* This program is free software: you can redistribute it and/or modify
13		* it under the terms of the GNU Affero General Public License as
14		* published by the Free Software Foundation, either version 3 of the
15		* License, or (at your option) any later version.
16		*
17		* This program is distributed in the hope that it will be useful,
18		* but WITHOUT ANY WARRANTY; without even the implied warranty of
19		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
20		* GNU Affero General Public License for more details.
21		*
22		* You should have received a copy of the GNU Affero General Public License
23		* along with this program. If not, see <http://www.gnu.org/licenses/>.
24		*
25		*/
26
27		namespace OC\Settings\Admin;
28
29		use Doctrine\DBAL\Connection;
30		use Doctrine\DBAL\DBALException;
31		use Doctrine\DBAL\Platforms\SqlitePlatform;
32		use OC\Lock\DBLockingProvider;
33		use OC\Lock\NoopLockingProvider;
34		use OCP\AppFramework\Http\TemplateResponse;
35		use OCP\IConfig;
36		use OCP\IDBConnection;
37		use OCP\IL10N;
38		use OCP\IRequest;
39		use OCP\Lock\ILockingProvider;
40		use OCP\Settings\ISettings;
41
42		class Server implements ISettings {
43		/** @var IDBConnection\|Connection */
44		private $db;
45		/** @var IRequest */
46		private $request;
47		/** @var IConfig */
48		private $config;
49		/** @var ILockingProvider */
50		private $lockingProvider;
51		/** @var IL10N */
52		private $l;
53
54		/**
55		* @param IDBConnection $db
56		* @param IRequest $request
57		* @param IConfig $config
58		* @param ILockingProvider $lockingProvider
59		* @param IL10N $l
60		*/
61	View Code Duplication	public function __construct(IDBConnection $db,
62		IRequest $request,
63		IConfig $config,
64		ILockingProvider $lockingProvider,
65		IL10N $l) {
66		$this->db = $db;
67		$this->request = $request;
68		$this->config = $config;
69		$this->lockingProvider = $lockingProvider;
70		$this->l = $l;
71		}
72
73		/**
74		* @return TemplateResponse
75		*/
76		public function getForm() {
77		$parameters = [
78		// Background jobs
79		'backgroundjobs_mode' => $this->config->getAppValue('core', 'backgroundjobs_mode', 'ajax'),
80		'lastcron' => $this->config->getAppValue('core', 'lastcron', false),
		0 ignored issues – show Documentation introduced 2017-04-18 10:59 UTC by Report Bug Copy Issue Report `false` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
81		'cronErrors' => $this->config->getAppValue('core', 'cronErrors'),
82		'cli_based_cron_possible' => function_exists('posix_getpwuid'),
83		'cli_based_cron_user' => function_exists('posix_getpwuid') ? posix_getpwuid(fileowner(\OC::$configDir . 'config.php'))['name'] : '',
84		];
85
86		return new TemplateResponse('settings', 'settings/admin/server', $parameters, '');
87		}
88
89		/**
90		* @return string the section ID, e.g. 'sharing'
91		*/
92		public function getSection() {
93		return 'server';
94		}
95
96		/**
97		* @return int whether the form should be rather on the top or bottom of
98		* the admin section. The forms are arranged in ascending order of the
99		* priority values. It is required to return a value between 0 and 100.
100		*
101		* E.g.: 70
102		*/
103		public function getPriority() {
104		return 0;
105		}
106		}
107

nextcloud / server

Push — master ( 94010e...d161d4 )

Server A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like