nextcloud / server

lib/private/Share20/ProviderFactory.php

Unused Use Statements -1 removed lines

@@ -32,7 +32,6 @@
 use OCA\FederatedFileSharing\AddressHandler;
 use OCA\FederatedFileSharing\FederatedShareProvider;
 use OCA\FederatedFileSharing\Notifications;
-use OCA\FederatedFileSharing\OCM\CloudFederationProvider;
 use OCA\FederatedFileSharing\TokenHandler;
 use OCA\ShareByMail\Settings\SettingsManager;
 use OCA\ShareByMail\ShareByMailProvider;

apps/cloud_federation_api/lib/Controller/RequestHandlerController.php

Doc Comments -1 removed lines

@@ -106,7 +106,6 @@
 	 * @param string $ownerDisplayName display name of the user who shared the item
 	 * @param string $sharedBy provider specific UID of the user who shared the resource
 	 * @param string $sharedByDisplayName display name of the user who shared the resource
-	 * @param string $sharedSecret use to authenticate accross servers
 	 * @param array $protocol (e,.g. ['name' => 'webdav', 'options' => ['username' => 'john', 'permissions' => 31]])
 	 * @param string $shareType ('group' or 'user' share)
 	 * @param $resourceType ('file', 'calendar',...)

lib/public/Federation/Exceptions/AuthenticationFailedException.php

Doc Comments -1 removed lines

@@ -28,7 +28,6 @@
 	/**
 	 * BadRequestException constructor.
 	 *
-	 * @param array $missingParameters
 	 */
 	public function __construct() {
 		$l = \OC::$server->getL10N('federation');

apps/files_sharing/lib/External/Manager.php

Doc Comments +4 added lines, -1 removed lines

@@ -324,7 +324,7 @@ 
 	 *
 	 * @param string $remoteDomain
 	 * @param string $token
-	 * @param $remoteId id of the share
+	 * @param integer $remoteId id of the share
 	 * @param string $feedback
 	 * @return bool
 	 */
@@ -421,6 +421,9 @@ 
 		return $result;
 	}
 
+	/**
+	 * @param string $mountPoint
+	 */
 	public function removeShare($mountPoint) {
 
 		$mountPointObj = $this->mountManager->find($mountPoint);

apps/federatedfilesharing/lib/ocm/CloudFederationProviderFiles.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use OCA\FederatedFileSharing\AddressHandler;
 use OCA\FederatedFileSharing\FederatedShareProvider;
 use OCP\Activity\IManager as IActivityManager;
-use OCP\Activity\IManager;
 use OCP\App\IAppManager;
 use OCP\Constants;
 use OCP\Federation\Exceptions\ActionNotSupportedException;

Doc Comments +5 added lines, -2 removed lines

@@ -144,7 +144,7 @@ 
 	 * share received from another server
 	 *
 	 * @param ICloudFederationShare $share
-	 * @return string provider specific unique ID of the share
+	 * @return integer provider specific unique ID of the share
 	 *
 	 * @throws ProviderCouldNotAddShareException
 	 * @throws \OCP\AppFramework\QueryException
@@ -468,6 +468,9 @@ 
 		return [];
 	}
 
+	/**
+	 * @param string $id
+	 */
 	private function unshare($id, $notification) {
 
 		if (!$this->isS2SEnabled(true)) {
@@ -545,7 +548,7 @@ 
 	/**
 	 * recipient of a share request to re-share the file with another user
 	 *
-	 * @param $id
+	 * @param string $id
 	 * @param $notification
 	 * @return array
 	 * @throws AuthenticationFailedException

apps/federatedfilesharing/lib/Controller/RequestHandlerController.php

Doc Comments +1 added lines, -1 removed lines

@@ -450,7 +450,7 @@
 	/**
 	 * translate Nextcloud permissions to OCM Permissions
 	 *
-	 * @param $ncPermissions
+	 * @param integer $ncPermissions
 	 * @return array
 	 */
 	protected function ncPermissions2ocmPermissions($ncPermissions) {

Unused Use Statements -5 removed lines

@@ -29,7 +29,6 @@ 
 
 namespace OCA\FederatedFileSharing\Controller;
 
-use OCA\Files_Sharing\Activity\Providers\RemoteShares;
 use OCA\FederatedFileSharing\AddressHandler;
 use OCA\FederatedFileSharing\FederatedShareProvider;
 use OCA\FederatedFileSharing\Notifications;
@@ -40,21 +39,17 @@ 
 use OCP\AppFramework\OCS\OCSNotFoundException;
 use OCP\AppFramework\OCSController;
 use OCP\Constants;
-use OCP\Federation\Exceptions\AuthenticationFailedException;
-use OCP\Federation\Exceptions\BadRequestException;
 use OCP\Federation\Exceptions\ProviderCouldNotAddShareException;
 use OCP\Federation\Exceptions\ProviderDoesNotExistsException;
 use OCP\Federation\Exceptions\ShareNotFoundException;
 use OCP\Federation\ICloudFederationFactory;
 use OCP\Federation\ICloudFederationProviderManager;
 use OCP\Federation\ICloudIdManager;
-use OCP\Files\NotFoundException;
 use OCP\IDBConnection;
 use OCP\ILogger;
 use OCP\IRequest;
 use OCP\IUserManager;
 use OCP\Share;
-use OCP\Share\IShare;
 
 class RequestHandlerController extends OCSController {