Completed
Pull Request — master (#9345)
by Björn
21:23
created
apps/cloud_federation_api/lib/Controller/RequestHandlerController.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,6 @@
 block discarded – undo
106 106
 	 * @param string $ownerDisplayName display name of the user who shared the item
107 107
 	 * @param string $sharedBy provider specific UID of the user who shared the resource
108 108
 	 * @param string $sharedByDisplayName display name of the user who shared the resource
109
-	 * @param string $sharedSecret use to authenticate accross servers
110 109
 	 * @param array $protocol (e,.g. ['name' => 'webdav', 'options' => ['username' => 'john', 'permissions' => 31]])
111 110
 	 * @param string $shareType ('group' or 'user' share)
112 111
 	 * @param $resourceType ('file', 'calendar',...)
Please login to merge, or discard this patch.
lib/public/Federation/Exceptions/AuthenticationFailedException.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,6 @@
 block discarded – undo
28 28
 	/**
29 29
 	 * BadRequestException constructor.
30 30
 	 *
31
-	 * @param array $missingParameters
32 31
 	 */
33 32
 	public function __construct() {
34 33
 		$l = \OC::$server->getL10N('federation');
Please login to merge, or discard this patch.
apps/files_sharing/lib/External/Manager.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
 	 *
325 325
 	 * @param string $remoteDomain
326 326
 	 * @param string $token
327
-	 * @param $remoteId id of the share
327
+	 * @param integer $remoteId id of the share
328 328
 	 * @param string $feedback
329 329
 	 * @return bool
330 330
 	 */
@@ -421,6 +421,9 @@  discard block
 block discarded – undo
421 421
 		return $result;
422 422
 	}
423 423
 
424
+	/**
425
+	 * @param string $mountPoint
426
+	 */
424 427
 	public function removeShare($mountPoint) {
425 428
 
426 429
 		$mountPointObj = $this->mountManager->find($mountPoint);
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/ocm/CloudFederationProviderFiles.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 	 * share received from another server
145 145
 	 *
146 146
 	 * @param ICloudFederationShare $share
147
-	 * @return string provider specific unique ID of the share
147
+	 * @return integer provider specific unique ID of the share
148 148
 	 *
149 149
 	 * @throws ProviderCouldNotAddShareException
150 150
 	 * @throws \OCP\AppFramework\QueryException
@@ -468,6 +468,9 @@  discard block
 block discarded – undo
468 468
 		return [];
469 469
 	}
470 470
 
471
+	/**
472
+	 * @param string $id
473
+	 */
471 474
 	private function unshare($id, $notification) {
472 475
 
473 476
 		if (!$this->isS2SEnabled(true)) {
@@ -545,7 +548,7 @@  discard block
 block discarded – undo
545 548
 	/**
546 549
 	 * recipient of a share request to re-share the file with another user
547 550
 	 *
548
-	 * @param $id
551
+	 * @param string $id
549 552
 	 * @param $notification
550 553
 	 * @return array
551 554
 	 * @throws AuthenticationFailedException
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/Controller/RequestHandlerController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -450,7 +450,7 @@
 block discarded – undo
450 450
 	/**
451 451
 	 * translate Nextcloud permissions to OCM Permissions
452 452
 	 *
453
-	 * @param $ncPermissions
453
+	 * @param integer $ncPermissions
454 454
 	 * @return array
455 455
 	 */
456 456
 	protected function ncPermissions2ocmPermissions($ncPermissions) {
Please login to merge, or discard this patch.