nextcloud / server

lib/private/IntegrityCheck/Helpers/EnvironmentHelper.php

Indentation +16 added lines, -16 removed lines

@@ -30,21 +30,21 @@
  * @package OC\IntegrityCheck\Helpers
  */
 class EnvironmentHelper {
-	/**
-	 * Provides \OC::$SERVERROOT
-	 *
-	 * @return string
-	 */
-	public function getServerRoot(): string {
-		return rtrim(\OC::$SERVERROOT, '/');
-	}
+    /**
+     * Provides \OC::$SERVERROOT
+     *
+     * @return string
+     */
+    public function getServerRoot(): string {
+        return rtrim(\OC::$SERVERROOT, '/');
+    }
 
-	/**
-	 * Provides \OC_Util::getChannel()
-	 *
-	 * @return string
-	 */
-	public function getChannel(): string {
-		return \OC_Util::getChannel();
-	}
+    /**
+     * Provides \OC_Util::getChannel()
+     *
+     * @return string
+     */
+    public function getChannel(): string {
+        return \OC_Util::getChannel();
+    }
 }

lib/private/AppFramework/Middleware/Security/Exceptions/NotAdminException.php

Indentation +3 added lines, -3 removed lines

@@ -36,7 +36,7 @@
  * @package OC\AppFramework\Middleware\Security\Exceptions
  */
 class NotAdminException extends SecurityException {
-	public function __construct(string $message) {
-		parent::__construct($message, Http::STATUS_FORBIDDEN);
-	}
+    public function __construct(string $message) {
+        parent::__construct($message, Http::STATUS_FORBIDDEN);
+    }
 }

apps/files_sharing/lib/Helper.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
 		$dir = $pathinfo['dirname'];
 		$i = 2;
 		while ($view->file_exists($path) || in_array($path, $excludeList)) {
-			$path = Filesystem::normalizePath($dir . '/' . $name . ' ('.$i.')' . $ext);
+			$path = Filesystem::normalizePath($dir.'/'.$name.' ('.$i.')'.$ext);
 			$i++;
 		}
 
@@ -82,7 +82,7 @@ 
 			$dir = '';
 			$subdirs = explode('/', $shareFolder);
 			foreach ($subdirs as $subdir) {
-				$dir = $dir . '/' . $subdir;
+				$dir = $dir.'/'.$subdir;
 				if (!$view->is_dir($dir)) {
 					$view->mkdir($dir);
 				}

Indentation +67 added lines, -67 removed lines

@@ -32,81 +32,81 @@
 use OCA\Files_Sharing\AppInfo\Application;
 
 class Helper {
-	public static function registerHooks() {
-		\OCP\Util::connectHook('OC_Filesystem', 'post_rename', '\OCA\Files_Sharing\Updater', 'renameHook');
-		\OCP\Util::connectHook('OC_Filesystem', 'post_delete', '\OCA\Files_Sharing\Hooks', 'unshareChildren');
+    public static function registerHooks() {
+        \OCP\Util::connectHook('OC_Filesystem', 'post_rename', '\OCA\Files_Sharing\Updater', 'renameHook');
+        \OCP\Util::connectHook('OC_Filesystem', 'post_delete', '\OCA\Files_Sharing\Hooks', 'unshareChildren');
 
-		\OCP\Util::connectHook('OC_User', 'post_deleteUser', '\OCA\Files_Sharing\Hooks', 'deleteUser');
-	}
+        \OCP\Util::connectHook('OC_User', 'post_deleteUser', '\OCA\Files_Sharing\Hooks', 'deleteUser');
+    }
 
-	/**
-	 * check if file name already exists and generate unique target
-	 *
-	 * @param string $path
-	 * @param array $excludeList
-	 * @param View $view
-	 * @return string $path
-	 */
-	public static function generateUniqueTarget($path, $excludeList, $view) {
-		$pathinfo = pathinfo($path);
-		$ext = isset($pathinfo['extension']) ? '.'.$pathinfo['extension'] : '';
-		$name = $pathinfo['filename'];
-		$dir = $pathinfo['dirname'];
-		$i = 2;
-		while ($view->file_exists($path) || in_array($path, $excludeList)) {
-			$path = Filesystem::normalizePath($dir . '/' . $name . ' ('.$i.')' . $ext);
-			$i++;
-		}
+    /**
+     * check if file name already exists and generate unique target
+     *
+     * @param string $path
+     * @param array $excludeList
+     * @param View $view
+     * @return string $path
+     */
+    public static function generateUniqueTarget($path, $excludeList, $view) {
+        $pathinfo = pathinfo($path);
+        $ext = isset($pathinfo['extension']) ? '.'.$pathinfo['extension'] : '';
+        $name = $pathinfo['filename'];
+        $dir = $pathinfo['dirname'];
+        $i = 2;
+        while ($view->file_exists($path) || in_array($path, $excludeList)) {
+            $path = Filesystem::normalizePath($dir . '/' . $name . ' ('.$i.')' . $ext);
+            $i++;
+        }
 
-		return $path;
-	}
+        return $path;
+    }
 
-	/**
-	 * get default share folder
-	 *
-	 * @param \OC\Files\View|null $view
-	 * @param string|null $userId
-	 * @return string
-	 */
-	public static function getShareFolder(View $view = null, string $userId = null): string {
-		if ($view === null) {
-			$view = Filesystem::getView();
-		}
+    /**
+     * get default share folder
+     *
+     * @param \OC\Files\View|null $view
+     * @param string|null $userId
+     * @return string
+     */
+    public static function getShareFolder(View $view = null, string $userId = null): string {
+        if ($view === null) {
+            $view = Filesystem::getView();
+        }
 
-		$config = \OC::$server->getConfig();
-		$systemDefault = $config->getSystemValue('share_folder', '/');
-		$allowCustomShareFolder = $config->getSystemValueBool('sharing.allow_custom_share_folder', true);
+        $config = \OC::$server->getConfig();
+        $systemDefault = $config->getSystemValue('share_folder', '/');
+        $allowCustomShareFolder = $config->getSystemValueBool('sharing.allow_custom_share_folder', true);
 
-		// Init custom shareFolder
-		$shareFolder = $systemDefault;
-		if ($userId !== null && $allowCustomShareFolder) {
-			$shareFolder = $config->getUserValue($userId, Application::APP_ID, 'share_folder', $systemDefault);
-		}
+        // Init custom shareFolder
+        $shareFolder = $systemDefault;
+        if ($userId !== null && $allowCustomShareFolder) {
+            $shareFolder = $config->getUserValue($userId, Application::APP_ID, 'share_folder', $systemDefault);
+        }
 
-		// Verify and sanitize path
-		$shareFolder = Filesystem::normalizePath($shareFolder);
+        // Verify and sanitize path
+        $shareFolder = Filesystem::normalizePath($shareFolder);
 
-		// Init path if folder doesn't exists
-		if (!$view->file_exists($shareFolder)) {
-			$dir = '';
-			$subdirs = explode('/', $shareFolder);
-			foreach ($subdirs as $subdir) {
-				$dir = $dir . '/' . $subdir;
-				if (!$view->is_dir($dir)) {
-					$view->mkdir($dir);
-				}
-			}
-		}
+        // Init path if folder doesn't exists
+        if (!$view->file_exists($shareFolder)) {
+            $dir = '';
+            $subdirs = explode('/', $shareFolder);
+            foreach ($subdirs as $subdir) {
+                $dir = $dir . '/' . $subdir;
+                if (!$view->is_dir($dir)) {
+                    $view->mkdir($dir);
+                }
+            }
+        }
 
-		return $shareFolder;
-	}
+        return $shareFolder;
+    }
 
-	/**
-	 * set default share folder
-	 *
-	 * @param string $shareFolder
-	 */
-	public static function setShareFolder($shareFolder) {
-		\OC::$server->getConfig()->setSystemValue('share_folder', $shareFolder);
-	}
+    /**
+     * set default share folder
+     *
+     * @param string $shareFolder
+     */
+    public static function setShareFolder($shareFolder) {
+        \OC::$server->getConfig()->setSystemValue('share_folder', $shareFolder);
+    }
 }

lib/private/Security/CSRF/CsrfTokenGenerator.php

Indentation +17 added lines, -17 removed lines

@@ -32,23 +32,23 @@
  * @package OC\Security\CSRF
  */
 class CsrfTokenGenerator {
-	/** @var ISecureRandom  */
-	private $random;
+    /** @var ISecureRandom  */
+    private $random;
 
-	/**
-	 * @param ISecureRandom $random
-	 */
-	public function __construct(ISecureRandom $random) {
-		$this->random = $random;
-	}
+    /**
+     * @param ISecureRandom $random
+     */
+    public function __construct(ISecureRandom $random) {
+        $this->random = $random;
+    }
 
-	/**
-	 * Generate a new CSRF token.
-	 *
-	 * @param int $length Length of the token in characters.
-	 * @return string
-	 */
-	public function generateToken(int $length = 32): string {
-		return $this->random->generate($length);
-	}
+    /**
+     * Generate a new CSRF token.
+     *
+     * @param int $length Length of the token in characters.
+     * @return string
+     */
+    public function generateToken(int $length = 32): string {
+        return $this->random->generate($length);
+    }
 }

lib/private/Security/IdentityProof/Key.php

Indentation +18 added lines, -18 removed lines

@@ -25,25 +25,25 @@
 namespace OC\Security\IdentityProof;
 
 class Key {
-	/** @var string */
-	private $publicKey;
-	/** @var string */
-	private $privateKey;
+    /** @var string */
+    private $publicKey;
+    /** @var string */
+    private $privateKey;
 
-	/**
-	 * @param string $publicKey
-	 * @param string $privateKey
-	 */
-	public function __construct(string $publicKey, string $privateKey) {
-		$this->publicKey = $publicKey;
-		$this->privateKey = $privateKey;
-	}
+    /**
+     * @param string $publicKey
+     * @param string $privateKey
+     */
+    public function __construct(string $publicKey, string $privateKey) {
+        $this->publicKey = $publicKey;
+        $this->privateKey = $privateKey;
+    }
 
-	public function getPrivate(): string {
-		return $this->privateKey;
-	}
+    public function getPrivate(): string {
+        return $this->privateKey;
+    }
 
-	public function getPublic(): string {
-		return $this->publicKey;
-	}
+    public function getPublic(): string {
+        return $this->publicKey;
+    }
 }

apps/dav/lib/Upload/ChunkingPlugin.php

Spacing +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
 
 		// casted to string because cast to float cause equality for non equal numbers
 		// and integer has the problem of limited size on 32 bit systems
-		if ((string)$expectedSize !== (string)$actualSize) {
+		if ((string) $expectedSize !== (string) $actualSize) {
 			throw new BadRequest("Chunks on server do not sum up to $expectedSize but to $actualSize bytes");
 		}
 	}

Indentation +83 added lines, -83 removed lines

@@ -35,97 +35,97 @@
 
 class ChunkingPlugin extends ServerPlugin {
 
-	/** @var Server */
-	private $server;
-	/** @var FutureFile */
-	private $sourceNode;
+    /** @var Server */
+    private $server;
+    /** @var FutureFile */
+    private $sourceNode;
 
-	/**
-	 * @inheritdoc
-	 */
-	public function initialize(Server $server) {
-		$server->on('beforeMove', [$this, 'beforeMove']);
-		$this->server = $server;
-	}
+    /**
+     * @inheritdoc
+     */
+    public function initialize(Server $server) {
+        $server->on('beforeMove', [$this, 'beforeMove']);
+        $this->server = $server;
+    }
 
-	/**
-	 * @param string $sourcePath source path
-	 * @param string $destination destination path
-	 * @return bool|void
-	 * @throws BadRequest
-	 * @throws NotFound
-	 */
-	public function beforeMove($sourcePath, $destination) {
-		$this->sourceNode = $this->server->tree->getNodeForPath($sourcePath);
-		if (!$this->sourceNode instanceof FutureFile) {
-			// skip handling as the source is not a chunked FutureFile
-			return;
-		}
+    /**
+     * @param string $sourcePath source path
+     * @param string $destination destination path
+     * @return bool|void
+     * @throws BadRequest
+     * @throws NotFound
+     */
+    public function beforeMove($sourcePath, $destination) {
+        $this->sourceNode = $this->server->tree->getNodeForPath($sourcePath);
+        if (!$this->sourceNode instanceof FutureFile) {
+            // skip handling as the source is not a chunked FutureFile
+            return;
+        }
 
-		try {
-			/** @var INode $destinationNode */
-			$destinationNode = $this->server->tree->getNodeForPath($destination);
-			if ($destinationNode instanceof Directory) {
-				throw new BadRequest("The given destination $destination is a directory.");
-			}
-		} catch (NotFound $e) {
-			// If the destination does not exist yet it's not a directory either ;)
-		}
+        try {
+            /** @var INode $destinationNode */
+            $destinationNode = $this->server->tree->getNodeForPath($destination);
+            if ($destinationNode instanceof Directory) {
+                throw new BadRequest("The given destination $destination is a directory.");
+            }
+        } catch (NotFound $e) {
+            // If the destination does not exist yet it's not a directory either ;)
+        }
 
-		$this->verifySize();
-		return $this->performMove($sourcePath, $destination);
-	}
+        $this->verifySize();
+        return $this->performMove($sourcePath, $destination);
+    }
 
-	/**
-	 * Move handler for future file.
-	 *
-	 * This overrides the default move behavior to prevent Sabre
-	 * to delete the target file before moving. Because deleting would
-	 * lose the file id and metadata.
-	 *
-	 * @param string $path source path
-	 * @param string $destination destination path
-	 * @return bool|void false to stop handling, void to skip this handler
-	 */
-	public function performMove($path, $destination) {
-		$fileExists = $this->server->tree->nodeExists($destination);
-		// do a move manually, skipping Sabre's default "delete" for existing nodes
-		try {
-			$this->server->tree->move($path, $destination);
-		} catch (Forbidden $e) {
-			$sourceNode = $this->server->tree->getNodeForPath($path);
-			if ($sourceNode instanceof FutureFile) {
-				$sourceNode->delete();
-			}
-			throw $e;
-		}
+    /**
+     * Move handler for future file.
+     *
+     * This overrides the default move behavior to prevent Sabre
+     * to delete the target file before moving. Because deleting would
+     * lose the file id and metadata.
+     *
+     * @param string $path source path
+     * @param string $destination destination path
+     * @return bool|void false to stop handling, void to skip this handler
+     */
+    public function performMove($path, $destination) {
+        $fileExists = $this->server->tree->nodeExists($destination);
+        // do a move manually, skipping Sabre's default "delete" for existing nodes
+        try {
+            $this->server->tree->move($path, $destination);
+        } catch (Forbidden $e) {
+            $sourceNode = $this->server->tree->getNodeForPath($path);
+            if ($sourceNode instanceof FutureFile) {
+                $sourceNode->delete();
+            }
+            throw $e;
+        }
 
-		// trigger all default events (copied from CorePlugin::move)
-		$this->server->emit('afterMove', [$path, $destination]);
-		$this->server->emit('afterUnbind', [$path]);
-		$this->server->emit('afterBind', [$destination]);
+        // trigger all default events (copied from CorePlugin::move)
+        $this->server->emit('afterMove', [$path, $destination]);
+        $this->server->emit('afterUnbind', [$path]);
+        $this->server->emit('afterBind', [$destination]);
 
-		$response = $this->server->httpResponse;
-		$response->setHeader('Content-Length', '0');
-		$response->setStatus($fileExists ? 204 : 201);
+        $response = $this->server->httpResponse;
+        $response->setHeader('Content-Length', '0');
+        $response->setStatus($fileExists ? 204 : 201);
 
-		return false;
-	}
+        return false;
+    }
 
-	/**
-	 * @throws BadRequest
-	 */
-	private function verifySize() {
-		$expectedSize = $this->server->httpRequest->getHeader('OC-Total-Length');
-		if ($expectedSize === null) {
-			return;
-		}
-		$actualSize = $this->sourceNode->getSize();
+    /**
+     * @throws BadRequest
+     */
+    private function verifySize() {
+        $expectedSize = $this->server->httpRequest->getHeader('OC-Total-Length');
+        if ($expectedSize === null) {
+            return;
+        }
+        $actualSize = $this->sourceNode->getSize();
 
-		// casted to string because cast to float cause equality for non equal numbers
-		// and integer has the problem of limited size on 32 bit systems
-		if ((string)$expectedSize !== (string)$actualSize) {
-			throw new BadRequest("Chunks on server do not sum up to $expectedSize but to $actualSize bytes");
-		}
-	}
+        // casted to string because cast to float cause equality for non equal numbers
+        // and integer has the problem of limited size on 32 bit systems
+        if ((string)$expectedSize !== (string)$actualSize) {
+            throw new BadRequest("Chunks on server do not sum up to $expectedSize but to $actualSize bytes");
+        }
+    }
 }

apps/user_ldap/ajax/getConfiguration.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
 \OC_JSON::checkAppEnabled('user_ldap');
 \OC_JSON::callCheck();
 
-$prefix = (string)$_POST['ldap_serverconfig_chooser'];
+$prefix = (string) $_POST['ldap_serverconfig_chooser'];
 $ldapWrapper = new OCA\User_LDAP\LDAP();
 $connection = new \OCA\User_LDAP\Connection($ldapWrapper, $prefix);
 $configuration = $connection->getConfiguration();

Indentation +2 added lines, -2 removed lines

@@ -35,7 +35,7 @@
 $connection = new \OCA\User_LDAP\Connection($ldapWrapper, $prefix);
 $configuration = $connection->getConfiguration();
 if (isset($configuration['ldap_agent_password']) && $configuration['ldap_agent_password'] !== '') {
-	// hide password
-	$configuration['ldap_agent_password'] = '**PASSWORD SET**';
+    // hide password
+    $configuration['ldap_agent_password'] = '**PASSWORD SET**';
 }
 \OC_JSON::success(['configuration' => $configuration]);

lib/public/AppFramework/Http/Template/LinkMenuAction.php

Spacing +10 added lines, -10 removed lines

@@ -51,16 +51,16 @@
 	 * @since 14.0.0
 	 */
 	public function render(): string {
-		return '<li>' .
-			'<a id="directLink-container">' .
-			'<span class="icon ' . Util::sanitizeHTML($this->getIcon()) . '"></span>' .
-			'<label for="directLink">' . Util::sanitizeHTML($this->getLabel()) . '</label>' .
-			'</a>' .
-			'</li>' .
-			'<li>' .
-			'<span class="menuitem">' .
-			'<input id="directLink" type="text" readonly="" value="' . Util::sanitizeHTML($this->getLink()) . '">' .
-			'</span>' .
+		return '<li>'.
+			'<a id="directLink-container">'.
+			'<span class="icon '.Util::sanitizeHTML($this->getIcon()).'"></span>'.
+			'<label for="directLink">'.Util::sanitizeHTML($this->getLabel()).'</label>'.
+			'</a>'.
+			'</li>'.
+			'<li>'.
+			'<span class="menuitem">'.
+			'<input id="directLink" type="text" readonly="" value="'.Util::sanitizeHTML($this->getLink()).'">'.
+			'</span>'.
 			'</li>';
 	}
 }

Indentation +28 added lines, -28 removed lines

@@ -31,33 +31,33 @@
  * @since 14.0.0
  */
 class LinkMenuAction extends SimpleMenuAction {
-	/**
-	 * LinkMenuAction constructor.
-	 *
-	 * @param string $label
-	 * @param string $icon
-	 * @param string $link
-	 * @since 14.0.0
-	 */
-	public function __construct(string $label, string $icon, string $link) {
-		parent::__construct('directLink-container', $label, $icon, $link);
-	}
+    /**
+     * LinkMenuAction constructor.
+     *
+     * @param string $label
+     * @param string $icon
+     * @param string $link
+     * @since 14.0.0
+     */
+    public function __construct(string $label, string $icon, string $link) {
+        parent::__construct('directLink-container', $label, $icon, $link);
+    }
 
-	/**
-	 * @return string
-	 * @since 14.0.0
-	 */
-	public function render(): string {
-		return '<li>' .
-			'<a id="directLink-container">' .
-			'<span class="icon ' . Util::sanitizeHTML($this->getIcon()) . '"></span>' .
-			'<label for="directLink">' . Util::sanitizeHTML($this->getLabel()) . '</label>' .
-			'</a>' .
-			'</li>' .
-			'<li>' .
-			'<span class="menuitem">' .
-			'<input id="directLink" type="text" readonly="" value="' . Util::sanitizeHTML($this->getLink()) . '">' .
-			'</span>' .
-			'</li>';
-	}
+    /**
+     * @return string
+     * @since 14.0.0
+     */
+    public function render(): string {
+        return '<li>' .
+            '<a id="directLink-container">' .
+            '<span class="icon ' . Util::sanitizeHTML($this->getIcon()) . '"></span>' .
+            '<label for="directLink">' . Util::sanitizeHTML($this->getLabel()) . '</label>' .
+            '</a>' .
+            '</li>' .
+            '<li>' .
+            '<span class="menuitem">' .
+            '<input id="directLink" type="text" readonly="" value="' . Util::sanitizeHTML($this->getLink()) . '">' .
+            '</span>' .
+            '</li>';
+    }
 }

core/Migrations/Version14000Date20180129121024.php

Indentation +22 added lines, -22 removed lines

@@ -30,30 +30,30 @@
  * Delete the admin|personal sections and settings tables
  */
 class Version14000Date20180129121024 extends SimpleMigrationStep {
-	public function name(): string {
-		return 'Drop obsolete settings tables';
-	}
+    public function name(): string {
+        return 'Drop obsolete settings tables';
+    }
 
-	public function description(): string {
-		return 'Drops the following obsolete tables: "admin_sections", "admin_settings", "personal_sections" and "personal_settings"';
-	}
+    public function description(): string {
+        return 'Drops the following obsolete tables: "admin_sections", "admin_settings", "personal_sections" and "personal_settings"';
+    }
 
-	/**
-	 * @param IOutput $output
-	 * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
-	 * @param array $options
-	 * @return null|ISchemaWrapper
-	 * @since 13.0.0
-	 */
-	public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
-		/** @var ISchemaWrapper $schema */
-		$schema = $schemaClosure();
+    /**
+     * @param IOutput $output
+     * @param \Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+     * @param array $options
+     * @return null|ISchemaWrapper
+     * @since 13.0.0
+     */
+    public function changeSchema(IOutput $output, \Closure $schemaClosure, array $options) {
+        /** @var ISchemaWrapper $schema */
+        $schema = $schemaClosure();
 
-		$schema->dropTable('admin_sections');
-		$schema->dropTable('admin_settings');
-		$schema->dropTable('personal_sections');
-		$schema->dropTable('personal_settings');
+        $schema->dropTable('admin_sections');
+        $schema->dropTable('admin_settings');
+        $schema->dropTable('personal_sections');
+        $schema->dropTable('personal_settings');
 
-		return $schema;
-	}
+        return $schema;
+    }
 }