Completed
Pull Request — stable10 (#6492)
by Morris
11:41
created
apps/files_external/lib/AppInfo/Application.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 
47 47
 		$container = $this->getContainer();
48 48
 
49
-		$container->registerService('OCP\Files\Config\IUserMountCache', function (IAppContainer $c) {
49
+		$container->registerService('OCP\Files\Config\IUserMountCache', function(IAppContainer $c) {
50 50
 			return $c->getServer()->query('UserMountCache');
51 51
 		});
52 52
 
Please login to merge, or discard this patch.
apps/files_external/lib/config.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -255,11 +255,11 @@  discard block
 block discarded – undo
255 255
 	 */
256 256
 	public static function readData($user = null) {
257 257
 		if (isset($user)) {
258
-			$jsonFile = \OC::$server->getUserManager()->get($user)->getHome() . '/mount.json';
258
+			$jsonFile = \OC::$server->getUserManager()->get($user)->getHome().'/mount.json';
259 259
 		} else {
260 260
 			$config = \OC::$server->getConfig();
261
-			$datadir = $config->getSystemValue('datadirectory', \OC::$SERVERROOT . '/data/');
262
-			$jsonFile = $config->getSystemValue('mount_file', $datadir . '/mount.json');
261
+			$datadir = $config->getSystemValue('datadirectory', \OC::$SERVERROOT.'/data/');
262
+			$jsonFile = $config->getSystemValue('mount_file', $datadir.'/mount.json');
263 263
 		}
264 264
 		if (is_file($jsonFile)) {
265 265
 			$mountPoints = json_decode(file_get_contents($jsonFile), true);
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
 		foreach ($backends as $backend) {
286 286
 			foreach ($backend->checkDependencies() as $dependency) {
287 287
 				if ($message = $dependency->getMessage()) {
288
-					$message .= '<p>' . $message . '</p>';
288
+					$message .= '<p>'.$message.'</p>';
289 289
 				} else {
290 290
 					$dependencyGroups[$dependency->getDependency()][] = $backend;
291 291
 				}
@@ -294,9 +294,9 @@  discard block
 block discarded – undo
294 294
 
295 295
 		foreach ($dependencyGroups as $module => $dependants) {
296 296
 			$backends = implode(', ', array_map(function($backend) {
297
-				return '"' . $backend->getText() . '"';
297
+				return '"'.$backend->getText().'"';
298 298
 			}, $dependants));
299
-			$message .= '<p>' . OC_Mount_Config::getSingleDependencyMessage($l, $module, $backends) . '</p>';
299
+			$message .= '<p>'.OC_Mount_Config::getSingleDependencyMessage($l, $module, $backends).'</p>';
300 300
 		}
301 301
 
302 302
 		return $message;
@@ -313,11 +313,11 @@  discard block
 block discarded – undo
313 313
 	private static function getSingleDependencyMessage(\OCP\IL10N $l, $module, $backend) {
314 314
 		switch (strtolower($module)) {
315 315
 			case 'curl':
316
-				return (string)$l->t('The cURL support in PHP is not enabled or installed. Mounting of %s is not possible. Please ask your system administrator to install it.', $backend);
316
+				return (string) $l->t('The cURL support in PHP is not enabled or installed. Mounting of %s is not possible. Please ask your system administrator to install it.', $backend);
317 317
 			case 'ftp':
318
-				return (string)$l->t('The FTP support in PHP is not enabled or installed. Mounting of %s is not possible. Please ask your system administrator to install it.', $backend);
318
+				return (string) $l->t('The FTP support in PHP is not enabled or installed. Mounting of %s is not possible. Please ask your system administrator to install it.', $backend);
319 319
 			default:
320
-				return (string)$l->t('"%s" is not installed. Mounting of %s is not possible. Please ask your system administrator to install it.', array($module, $backend));
320
+				return (string) $l->t('"%s" is not installed. Mounting of %s is not possible. Please ask your system administrator to install it.', array($module, $backend));
321 321
 		}
322 322
 	}
323 323
 
@@ -362,7 +362,7 @@  discard block
 block discarded – undo
362 362
 		$cipher = self::getCipher();
363 363
 		$iv = \OCP\Util::generateRandomBytes(16);
364 364
 		$cipher->setIV($iv);
365
-		return base64_encode($iv . $cipher->encrypt($password));
365
+		return base64_encode($iv.$cipher->encrypt($password));
366 366
 	}
367 367
 
368 368
 	/**
Please login to merge, or discard this patch.
apps/files_external/lib/Command/Applicable.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
 		try {
104 104
 			$mount = $this->globalService->getStorage($mountId);
105 105
 		} catch (NotFoundException $e) {
106
-			$output->writeln('<error>Mount with id "' . $mountId . ' not found, check "occ files_external:list" to get available mounts</error>');
106
+			$output->writeln('<error>Mount with id "'.$mountId.' not found, check "occ files_external:list" to get available mounts</error>');
107 107
 			return 404;
108 108
 		}
109 109
 
@@ -123,13 +123,13 @@  discard block
 block discarded – undo
123 123
 		if ((count($addUsers) + count($removeUsers) + count($addGroups) + count($removeGroups) > 0) || $input->getOption('remove-all')) {
124 124
 			foreach ($addUsers as $addUser) {
125 125
 				if (!$this->userManager->userExists($addUser)) {
126
-					$output->writeln('<error>User "' . $addUser . '" not found</error>');
126
+					$output->writeln('<error>User "'.$addUser.'" not found</error>');
127 127
 					return 404;
128 128
 				}
129 129
 			}
130 130
 			foreach ($addGroups as $addGroup) {
131 131
 				if (!$this->groupManager->groupExists($addGroup)) {
132
-					$output->writeln('<error>Group "' . $addGroup . '" not found</error>');
132
+					$output->writeln('<error>Group "'.$addGroup.'" not found</error>');
133 133
 					return 404;
134 134
 				}
135 135
 			}
Please login to merge, or discard this patch.
apps/files_external/lib/Command/ListCommand.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -156,11 +156,11 @@  discard block
 block discarded – undo
156 156
 		}
157 157
 
158 158
 		if ($outputType === self::OUTPUT_FORMAT_JSON || $outputType === self::OUTPUT_FORMAT_JSON_PRETTY) {
159
-			$keys = array_map(function ($header) {
159
+			$keys = array_map(function($header) {
160 160
 				return strtolower(str_replace(' ', '_', $header));
161 161
 			}, $headers);
162 162
 
163
-			$pairs = array_map(function (StorageConfig $config) use ($keys, $userId) {
163
+			$pairs = array_map(function(StorageConfig $config) use ($keys, $userId) {
164 164
 				$values = [
165 165
 					$config->getId(),
166 166
 					$config->getMountPoint(),
@@ -193,23 +193,23 @@  discard block
 block discarded – undo
193 193
 				'enable_sharing' => false,
194 194
 				'encoding_compatibility' => false
195 195
 			];
196
-			$rows = array_map(function (StorageConfig $config) use ($userId, $defaultMountOptions, $full) {
196
+			$rows = array_map(function(StorageConfig $config) use ($userId, $defaultMountOptions, $full) {
197 197
 				$storageConfig = $config->getBackendOptions();
198 198
 				$keys = array_keys($storageConfig);
199 199
 				$values = array_values($storageConfig);
200 200
 
201 201
 				if (!$full) {
202
-					$values = array_map(function ($value) {
202
+					$values = array_map(function($value) {
203 203
 						if (is_string($value) && strlen($value) > 32) {
204
-							return substr($value, 0, 6) . '...' . substr($value, -6, 6);
204
+							return substr($value, 0, 6).'...'.substr($value, -6, 6);
205 205
 						} else {
206 206
 							return $value;
207 207
 						}
208 208
 					}, $values);
209 209
 				}
210 210
 
211
-				$configStrings = array_map(function ($key, $value) {
212
-					return $key . ': ' . json_encode($value);
211
+				$configStrings = array_map(function($key, $value) {
212
+					return $key.': '.json_encode($value);
213 213
 				}, $keys, $values);
214 214
 				$configString = implode(', ', $configStrings);
215 215
 
@@ -223,8 +223,8 @@  discard block
 block discarded – undo
223 223
 				$keys = array_keys($mountOptions);
224 224
 				$values = array_values($mountOptions);
225 225
 
226
-				$optionsStrings = array_map(function ($key, $value) {
227
-					return $key . ': ' . json_encode($value);
226
+				$optionsStrings = array_map(function($key, $value) {
227
+					return $key.': '.json_encode($value);
228 228
 				}, $keys, $values);
229 229
 				$optionsString = implode(', ', $optionsStrings);
230 230
 
Please login to merge, or discard this patch.
apps/files_external/lib/Command/Config.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
 		try {
69 69
 			$mount = $this->globalService->getStorage($mountId);
70 70
 		} catch (NotFoundException $e) {
71
-			$output->writeln('<error>Mount with id "' . $mountId . ' not found, check "occ files_external:list" to get available mounts"</error>');
71
+			$output->writeln('<error>Mount with id "'.$mountId.' not found, check "occ files_external:list" to get available mounts"</error>');
72 72
 			return 404;
73 73
 		}
74 74
 
Please login to merge, or discard this patch.
apps/files_external/lib/Command/Verify.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 		try {
72 72
 			$mount = $this->globalService->getStorage($mountId);
73 73
 		} catch (NotFoundException $e) {
74
-			$output->writeln('<error>Mount with id "' . $mountId . ' not found, check "occ files_external:list" to get available mounts"</error>');
74
+			$output->writeln('<error>Mount with id "'.$mountId.' not found, check "occ files_external:list" to get available mounts"</error>');
75 75
 			return 404;
76 76
 		}
77 77
 
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 		$backend->manipulateStorageConfig($storage);
94 94
 	}
95 95
 
96
-	private function updateStorageStatus(StorageConfig &$storage, $configInput, OutputInterface $output) {
96
+	private function updateStorageStatus(StorageConfig & $storage, $configInput, OutputInterface $output) {
97 97
 		try {
98 98
 			try {
99 99
 				$this->manipulateStorageConfig($storage);
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 
106 106
 			foreach ($configInput as $configOption) {
107 107
 				if (!strpos($configOption, '=')) {
108
-					$output->writeln('<error>Invalid mount configuration option "' . $configOption . '"</error>');
108
+					$output->writeln('<error>Invalid mount configuration option "'.$configOption.'"</error>');
109 109
 					return;
110 110
 				}
111 111
 				list($key, $value) = explode('=', $configOption, 2);
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
 			// FIXME: convert storage exceptions to StorageNotAvailableException
138 138
 			$storage->setStatus(
139 139
 				StorageNotAvailableException::STATUS_ERROR,
140
-				get_class($e) . ': ' . $e->getMessage()
140
+				get_class($e).': '.$e->getMessage()
141 141
 			);
142 142
 		}
143 143
 	}
Please login to merge, or discard this patch.
apps/files_external/lib/Command/Create.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -128,32 +128,32 @@  discard block
 block discarded – undo
128 128
 		$authBackend = $this->backendService->getAuthMechanism($authIdentifier);
129 129
 
130 130
 		if (!Filesystem::isValidPath($mountPoint)) {
131
-			$output->writeln('<error>Invalid mountpoint "' . $mountPoint . '"</error>');
131
+			$output->writeln('<error>Invalid mountpoint "'.$mountPoint.'"</error>');
132 132
 			return 1;
133 133
 		}
134 134
 		if (is_null($storageBackend)) {
135
-			$output->writeln('<error>Storage backend with identifier "' . $storageIdentifier . '" not found (see `occ files_external:backends` for possible values)</error>');
135
+			$output->writeln('<error>Storage backend with identifier "'.$storageIdentifier.'" not found (see `occ files_external:backends` for possible values)</error>');
136 136
 			return 404;
137 137
 		}
138 138
 		if (is_null($authBackend)) {
139
-			$output->writeln('<error>Authentication backend with identifier "' . $authIdentifier . '" not found (see `occ files_external:backends` for possible values)</error>');
139
+			$output->writeln('<error>Authentication backend with identifier "'.$authIdentifier.'" not found (see `occ files_external:backends` for possible values)</error>');
140 140
 			return 404;
141 141
 		}
142 142
 		$supportedSchemes = array_keys($storageBackend->getAuthSchemes());
143 143
 		if (!in_array($authBackend->getScheme(), $supportedSchemes)) {
144
-			$output->writeln('<error>Authentication backend "' . $authIdentifier . '" not valid for storage backend "' . $storageIdentifier . '" (see `occ files_external:backends storage ' . $storageIdentifier . '` for possible values)</error>');
144
+			$output->writeln('<error>Authentication backend "'.$authIdentifier.'" not valid for storage backend "'.$storageIdentifier.'" (see `occ files_external:backends storage '.$storageIdentifier.'` for possible values)</error>');
145 145
 			return 1;
146 146
 		}
147 147
 
148 148
 		$config = [];
149 149
 		foreach ($configInput as $configOption) {
150 150
 			if (!strpos($configOption, '=')) {
151
-				$output->writeln('<error>Invalid mount configuration option "' . $configOption . '"</error>');
151
+				$output->writeln('<error>Invalid mount configuration option "'.$configOption.'"</error>');
152 152
 				return 1;
153 153
 			}
154 154
 			list($key, $value) = explode('=', $configOption, 2);
155 155
 			if (!$this->validateParam($key, $value, $storageBackend, $authBackend)) {
156
-				$output->writeln('<error>Unknown configuration for backends "' . $key . '"</error>');
156
+				$output->writeln('<error>Unknown configuration for backends "'.$key.'"</error>');
157 157
 				return 1;
158 158
 			}
159 159
 			$config[$key] = $value;
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 
168 168
 		if ($user) {
169 169
 			if (!$this->userManager->userExists($user)) {
170
-				$output->writeln('<error>User "' . $user . '" not found</error>');
170
+				$output->writeln('<error>User "'.$user.'" not found</error>');
171 171
 				return 1;
172 172
 			}
173 173
 			$mount->setApplicableUsers([$user]);
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
 		} else {
179 179
 			$this->getStorageService($user)->addStorage($mount);
180 180
 			if ($input->getOption('output') === self::OUTPUT_FORMAT_PLAIN) {
181
-				$output->writeln('<info>Storage created with id ' . $mount->getId() . '</info>');
181
+				$output->writeln('<info>Storage created with id '.$mount->getId().'</info>');
182 182
 			} else {
183 183
 				$output->writeln($mount->getId());
184 184
 			}
Please login to merge, or discard this patch.
apps/files_external/lib/Command/Backends.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -71,14 +71,14 @@  discard block
 block discarded – undo
71 71
 		$backend = $input->getArgument('backend');
72 72
 		if ($type) {
73 73
 			if (!isset($data[$type])) {
74
-				$output->writeln('<error>Invalid type "' . $type . '". Possible values are "authentication" or "storage"</error>');
74
+				$output->writeln('<error>Invalid type "'.$type.'". Possible values are "authentication" or "storage"</error>');
75 75
 				return 1;
76 76
 			}
77 77
 			$data = $data[$type];
78 78
 
79 79
 			if ($backend) {
80 80
 				if (!isset($data[$backend])) {
81
-					$output->writeln('<error>Unknown backend "' . $backend . '" of type  "' . $type . '"</error>');
81
+					$output->writeln('<error>Unknown backend "'.$backend.'" of type  "'.$type.'"</error>');
82 82
 					return 1;
83 83
 				}
84 84
 				$data = $data[$backend];
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 			$result['storage_class'] = $backend->getStorageClass();
100 100
 			$authBackends = $this->backendService->getAuthMechanismsByScheme(array_keys($backend->getAuthSchemes()));
101 101
 			$result['supported_authentication_backends'] = array_keys($authBackends);
102
-			$authConfig = array_map(function (AuthMechanism $auth) {
102
+			$authConfig = array_map(function(AuthMechanism $auth) {
103 103
 				return $this->serializeAuthBackend($auth)['configuration'];
104 104
 			}, $authBackends);
105 105
 			$result['authentication_configuration'] = array_combine(array_keys($authBackends), $authConfig);
@@ -112,10 +112,10 @@  discard block
 block discarded – undo
112 112
 	 * @return string[]
113 113
 	 */
114 114
 	private function formatConfiguration(array $parameters) {
115
-		$configuration = array_filter($parameters, function (DefinitionParameter $parameter) {
115
+		$configuration = array_filter($parameters, function(DefinitionParameter $parameter) {
116 116
 			return $parameter->getType() !== DefinitionParameter::VALUE_HIDDEN;
117 117
 		});
118
-		return array_map(function (DefinitionParameter $parameter) {
118
+		return array_map(function(DefinitionParameter $parameter) {
119 119
 			return $parameter->getTypeName();
120 120
 		}, $configuration);
121 121
 	}
Please login to merge, or discard this patch.
apps/files_external/lib/Command/Import.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 			$json = file_get_contents('php://stdin');
113 113
 		} else {
114 114
 			if (!file_exists($path)) {
115
-				$output->writeln('<error>File not found: ' . $path . '</error>');
115
+				$output->writeln('<error>File not found: '.$path.'</error>');
116 116
 				return 1;
117 117
 			}
118 118
 			$json = file_get_contents($path);
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 					$existingMount->getApplicableUsers() == $mount->getApplicableUsers() &&
165 165
 					$existingMount->getBackendOptions() == $mount->getBackendOptions()
166 166
 				) {
167
-					$output->writeln("<error>Duplicate mount (" . $mount->getMountPoint() . ")</error>");
167
+					$output->writeln("<error>Duplicate mount (".$mount->getMountPoint().")</error>");
168 168
 					return 1;
169 169
 				}
170 170
 			}
Please login to merge, or discard this patch.