Passed
Push — master ( 630edd...09718c )
by Morris
14:42 queued 10s
created
lib/public/Remote/IInstance.php 1 patch
Indentation   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -27,40 +27,40 @@
 block discarded – undo
27 27
  * @since 13.0.0
28 28
  */
29 29
 interface IInstance {
30
-	/**
31
-	 * @return string The url of the remote server without protocol
32
-	 *
33
-	 * @since 13.0.0
34
-	 */
35
-	public function getUrl();
30
+    /**
31
+     * @return string The url of the remote server without protocol
32
+     *
33
+     * @since 13.0.0
34
+     */
35
+    public function getUrl();
36 36
 
37
-	/**
38
-	 * @return string The of of the remote server with protocol
39
-	 *
40
-	 * @since 13.0.0
41
-	 */
42
-	public function getFullUrl();
37
+    /**
38
+     * @return string The of of the remote server with protocol
39
+     *
40
+     * @since 13.0.0
41
+     */
42
+    public function getFullUrl();
43 43
 
44
-	/**
45
-	 * @return string The full version string in '13.1.2.3' format
46
-	 *
47
-	 * @since 13.0.0
48
-	 */
49
-	public function getVersion();
44
+    /**
45
+     * @return string The full version string in '13.1.2.3' format
46
+     *
47
+     * @since 13.0.0
48
+     */
49
+    public function getVersion();
50 50
 
51
-	/**
52
-	 * @return string 'http' or 'https'
53
-	 *
54
-	 * @since 13.0.0
55
-	 */
56
-	public function getProtocol();
51
+    /**
52
+     * @return string 'http' or 'https'
53
+     *
54
+     * @since 13.0.0
55
+     */
56
+    public function getProtocol();
57 57
 
58
-	/**
59
-	 * Check that the remote server is installed and not in maintenance mode
60
-	 *
61
-	 * @since 13.0.0
62
-	 *
63
-	 * @return bool
64
-	 */
65
-	public function isActive();
58
+    /**
59
+     * Check that the remote server is installed and not in maintenance mode
60
+     *
61
+     * @since 13.0.0
62
+     *
63
+     * @return bool
64
+     */
65
+    public function isActive();
66 66
 }
Please login to merge, or discard this patch.
lib/public/Collaboration/AutoComplete/IManager.php 1 patch
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -30,17 +30,17 @@
 block discarded – undo
30 30
  * @since 13.0.0
31 31
  */
32 32
 interface IManager {
33
-	/**
34
-	 * @param string $className – class name of the ISorter implementation
35
-	 * @since 13.0.0
36
-	 */
37
-	public function registerSorter($className);
33
+    /**
34
+     * @param string $className – class name of the ISorter implementation
35
+     * @since 13.0.0
36
+     */
37
+    public function registerSorter($className);
38 38
 
39
-	/**
40
-	 * @param array $sorters	list of sorter IDs, seperated by "|"
41
-	 * @param array $sortArray	array representation of OCP\Collaboration\Collaborators\ISearchResult
42
-	 * @param array $context	context info of the search, keys: itemType, itemId
43
-	 * @since 13.0.0
44
-	 */
45
-	public function runSorters(array $sorters, array &$sortArray, array $context);
39
+    /**
40
+     * @param array $sorters	list of sorter IDs, seperated by "|"
41
+     * @param array $sortArray	array representation of OCP\Collaboration\Collaborators\ISearchResult
42
+     * @param array $context	context info of the search, keys: itemType, itemId
43
+     * @since 13.0.0
44
+     */
45
+    public function runSorters(array $sorters, array &$sortArray, array $context);
46 46
 }
Please login to merge, or discard this patch.
core/templates/layout.noscript.warning.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -2,10 +2,10 @@
 block discarded – undo
2 2
 	<div id="nojavascript">
3 3
 		<div>
4 4
 			<?php print_unescaped(str_replace(
5
-					['{linkstart}', '{linkend}'],
6
-					['<a href="https://www.enable-javascript.com/" target="_blank" rel="noreferrer noopener">', '</a>'],
7
-					$l->t('This application requires JavaScript for correct operation. Please {linkstart}enable JavaScript{linkend} and reload the page.')
8
-				)); ?>
5
+                    ['{linkstart}', '{linkend}'],
6
+                    ['<a href="https://www.enable-javascript.com/" target="_blank" rel="noreferrer noopener">', '</a>'],
7
+                    $l->t('This application requires JavaScript for correct operation. Please {linkstart}enable JavaScript{linkend} and reload the page.')
8
+                )); ?>
9 9
 		</div>
10 10
 	</div>
11 11
 </noscript>
Please login to merge, or discard this patch.
lib/public/Collaboration/AutoComplete/ISorter.php 1 patch
Indentation   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -33,18 +33,18 @@
 block discarded – undo
33 33
  */
34 34
 interface ISorter {
35 35
 
36
-	/**
37
-	 * @return string The ID of the sorter, e.g. commenters
38
-	 * @since 13.0.0
39
-	 */
40
-	public function getId();
36
+    /**
37
+     * @return string The ID of the sorter, e.g. commenters
38
+     * @since 13.0.0
39
+     */
40
+    public function getId();
41 41
 
42
-	/**
43
-	 * executes the sort action
44
-	 *
45
-	 * @param array $sortArray the array to be sorted, provided as reference
46
-	 * @param array $context carries key 'itemType' and 'itemId' of the source object (e.g. a file)
47
-	 * @since 13.0.0
48
-	 */
49
-	public function sort(array &$sortArray, array $context);
42
+    /**
43
+     * executes the sort action
44
+     *
45
+     * @param array $sortArray the array to be sorted, provided as reference
46
+     * @param array $context carries key 'itemType' and 'itemId' of the source object (e.g. a file)
47
+     * @since 13.0.0
48
+     */
49
+    public function sort(array &$sortArray, array $context);
50 50
 }
Please login to merge, or discard this patch.
lib/private/Files/Mount/CacheMountProvider.php 1 patch
Indentation   +35 added lines, -35 removed lines patch added patch discarded remove patch
@@ -31,42 +31,42 @@
 block discarded – undo
31 31
  * Mount provider for custom cache storages
32 32
  */
33 33
 class CacheMountProvider implements IMountProvider {
34
-	/**
35
-	 * @var IConfig
36
-	 */
37
-	private $config;
34
+    /**
35
+     * @var IConfig
36
+     */
37
+    private $config;
38 38
 
39
-	/**
40
-	 * ObjectStoreHomeMountProvider constructor.
41
-	 *
42
-	 * @param IConfig $config
43
-	 */
44
-	public function __construct(IConfig $config) {
45
-		$this->config = $config;
46
-	}
39
+    /**
40
+     * ObjectStoreHomeMountProvider constructor.
41
+     *
42
+     * @param IConfig $config
43
+     */
44
+    public function __construct(IConfig $config) {
45
+        $this->config = $config;
46
+    }
47 47
 
48
-	/**
49
-	 * Get the cache mount for a user
50
-	 *
51
-	 * @param IUser $user
52
-	 * @param IStorageFactory $loader
53
-	 * @return \OCP\Files\Mount\IMountPoint[]
54
-	 */
55
-	public function getMountsForUser(IUser $user, IStorageFactory $loader) {
56
-		$cacheBaseDir = $this->config->getSystemValue('cache_path', '');
57
-		if ($cacheBaseDir !== '') {
58
-			$cacheDir = rtrim($cacheBaseDir, '/') . '/' . $user->getUID();
59
-			if (!file_exists($cacheDir)) {
60
-				mkdir($cacheDir, 0770, true);
61
-				mkdir($cacheDir . '/uploads', 0770, true);
62
-			}
48
+    /**
49
+     * Get the cache mount for a user
50
+     *
51
+     * @param IUser $user
52
+     * @param IStorageFactory $loader
53
+     * @return \OCP\Files\Mount\IMountPoint[]
54
+     */
55
+    public function getMountsForUser(IUser $user, IStorageFactory $loader) {
56
+        $cacheBaseDir = $this->config->getSystemValue('cache_path', '');
57
+        if ($cacheBaseDir !== '') {
58
+            $cacheDir = rtrim($cacheBaseDir, '/') . '/' . $user->getUID();
59
+            if (!file_exists($cacheDir)) {
60
+                mkdir($cacheDir, 0770, true);
61
+                mkdir($cacheDir . '/uploads', 0770, true);
62
+            }
63 63
 
64
-			return [
65
-				new MountPoint('\OC\Files\Storage\Local', '/' . $user->getUID() . '/cache', ['datadir' => $cacheDir, $loader]),
66
-				new MountPoint('\OC\Files\Storage\Local', '/' . $user->getUID() . '/uploads', ['datadir' => $cacheDir . '/uploads', $loader])
67
-			];
68
-		} else {
69
-			return [];
70
-		}
71
-	}
64
+            return [
65
+                new MountPoint('\OC\Files\Storage\Local', '/' . $user->getUID() . '/cache', ['datadir' => $cacheDir, $loader]),
66
+                new MountPoint('\OC\Files\Storage\Local', '/' . $user->getUID() . '/uploads', ['datadir' => $cacheDir . '/uploads', $loader])
67
+            ];
68
+        } else {
69
+            return [];
70
+        }
71
+    }
72 72
 }
Please login to merge, or discard this patch.
core/Migrations/Version13000Date20170926101637.php 1 patch
Indentation   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -11,32 +11,32 @@
 block discarded – undo
11 11
  */
12 12
 class Version13000Date20170926101637 extends BigIntMigration {
13 13
 
14
-	/**
15
-	 * @return array Returns an array with the following structure
16
-	 * ['table1' => ['column1', 'column2'], ...]
17
-	 * @since 13.0.0
18
-	 */
19
-	protected function getColumnsByTable() {
20
-		return [
21
-			'admin_settings' => ['id'],
22
-			'authtoken' => ['id'],
23
-			'bruteforce_attempts' => ['id'],
24
-			'comments' => ['id', 'parent_id', 'topmost_parent_id'],
25
-			// Disabled for now 'filecache' => ['fileid', 'storage', 'parent', 'mimetype', 'mimepart'],
26
-			'file_locks' => ['id'],
27
-			'jobs' => ['id'],
28
-			// Disabled for now 'mimetypes' => ['id'],
29
-			'mounts' => ['id'],
30
-			'personal_settings' => ['id'],
31
-			'properties' => ['id'],
32
-			'share' => ['id', 'parent', 'file_source'],
33
-			// Disabled for now 'storages' => ['numeric_id'],
34
-			'systemtag' => ['id'],
35
-			'systemtag_group' => ['systemtagid'],
36
-			'systemtag_object_mapping' => ['systemtagid'],
37
-			'vcategory' => ['id'],
38
-			'vcategory_to_object' => ['objid', 'categoryid'],
39
-		];
40
-	}
14
+    /**
15
+     * @return array Returns an array with the following structure
16
+     * ['table1' => ['column1', 'column2'], ...]
17
+     * @since 13.0.0
18
+     */
19
+    protected function getColumnsByTable() {
20
+        return [
21
+            'admin_settings' => ['id'],
22
+            'authtoken' => ['id'],
23
+            'bruteforce_attempts' => ['id'],
24
+            'comments' => ['id', 'parent_id', 'topmost_parent_id'],
25
+            // Disabled for now 'filecache' => ['fileid', 'storage', 'parent', 'mimetype', 'mimepart'],
26
+            'file_locks' => ['id'],
27
+            'jobs' => ['id'],
28
+            // Disabled for now 'mimetypes' => ['id'],
29
+            'mounts' => ['id'],
30
+            'personal_settings' => ['id'],
31
+            'properties' => ['id'],
32
+            'share' => ['id', 'parent', 'file_source'],
33
+            // Disabled for now 'storages' => ['numeric_id'],
34
+            'systemtag' => ['id'],
35
+            'systemtag_group' => ['systemtagid'],
36
+            'systemtag_object_mapping' => ['systemtagid'],
37
+            'vcategory' => ['id'],
38
+            'vcategory_to_object' => ['objid', 'categoryid'],
39
+        ];
40
+    }
41 41
 
42 42
 }
Please login to merge, or discard this patch.
lib/public/Remote/IInstanceFactory.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -25,11 +25,11 @@
 block discarded – undo
25 25
  * @since 13.0.0
26 26
  */
27 27
 interface IInstanceFactory {
28
-	/**
29
-	 * @param string $url
30
-	 * @return IInstance
31
-	 *
32
-	 * @since 13.0.0
33
-	 */
34
-	public function getInstance($url);
28
+    /**
29
+     * @param string $url
30
+     * @return IInstance
31
+     *
32
+     * @since 13.0.0
33
+     */
34
+    public function getInstance($url);
35 35
 }
Please login to merge, or discard this patch.
lib/private/Remote/Instance.php 1 patch
Indentation   +103 added lines, -103 removed lines patch added patch discarded remove patch
@@ -30,118 +30,118 @@
 block discarded – undo
30 30
  * Provides some basic info about a remote Nextcloud instance
31 31
  */
32 32
 class Instance implements IInstance {
33
-	/** @var string */
34
-	private $url;
33
+    /** @var string */
34
+    private $url;
35 35
 
36
-	/** @var ICache */
37
-	private $cache;
36
+    /** @var ICache */
37
+    private $cache;
38 38
 
39
-	/** @var IClientService */
40
-	private $clientService;
39
+    /** @var IClientService */
40
+    private $clientService;
41 41
 
42
-	/** @var array|null */
43
-	private $status;
42
+    /** @var array|null */
43
+    private $status;
44 44
 
45
-	/**
46
-	 * @param string $url
47
-	 * @param ICache $cache
48
-	 * @param IClientService $clientService
49
-	 */
50
-	public function __construct($url, ICache $cache, IClientService $clientService) {
51
-		$url = str_replace('https://', '', $url);
52
-		$this->url = str_replace('http://', '', $url);
53
-		$this->cache = $cache;
54
-		$this->clientService = $clientService;
55
-	}
45
+    /**
46
+     * @param string $url
47
+     * @param ICache $cache
48
+     * @param IClientService $clientService
49
+     */
50
+    public function __construct($url, ICache $cache, IClientService $clientService) {
51
+        $url = str_replace('https://', '', $url);
52
+        $this->url = str_replace('http://', '', $url);
53
+        $this->cache = $cache;
54
+        $this->clientService = $clientService;
55
+    }
56 56
 
57
-	/**
58
-	 * @return string The url of the remote server without protocol
59
-	 */
60
-	public function getUrl() {
61
-		return $this->url;
62
-	}
57
+    /**
58
+     * @return string The url of the remote server without protocol
59
+     */
60
+    public function getUrl() {
61
+        return $this->url;
62
+    }
63 63
 
64
-	/**
65
-	 * @return string The of of the remote server with protocol
66
-	 */
67
-	public function getFullUrl() {
68
-		return $this->getProtocol() . '://' . $this->getUrl();
69
-	}
64
+    /**
65
+     * @return string The of of the remote server with protocol
66
+     */
67
+    public function getFullUrl() {
68
+        return $this->getProtocol() . '://' . $this->getUrl();
69
+    }
70 70
 
71
-	/**
72
-	 * @return string The full version string in '13.1.2.3' format
73
-	 */
74
-	public function getVersion() {
75
-		$status = $this->getStatus();
76
-		return $status['version'];
77
-	}
71
+    /**
72
+     * @return string The full version string in '13.1.2.3' format
73
+     */
74
+    public function getVersion() {
75
+        $status = $this->getStatus();
76
+        return $status['version'];
77
+    }
78 78
 
79
-	/**
80
-	 * @return string 'http' or 'https'
81
-	 */
82
-	public function getProtocol() {
83
-		$status = $this->getStatus();
84
-		return $status['protocol'];
85
-	}
79
+    /**
80
+     * @return string 'http' or 'https'
81
+     */
82
+    public function getProtocol() {
83
+        $status = $this->getStatus();
84
+        return $status['protocol'];
85
+    }
86 86
 
87
-	/**
88
-	 * Check that the remote server is installed and not in maintenance mode
89
-	 *
90
-	 * @return bool
91
-	 */
92
-	public function isActive() {
93
-		$status = $this->getStatus();
94
-		return $status['installed'] && !$status['maintenance'];
95
-	}
87
+    /**
88
+     * Check that the remote server is installed and not in maintenance mode
89
+     *
90
+     * @return bool
91
+     */
92
+    public function isActive() {
93
+        $status = $this->getStatus();
94
+        return $status['installed'] && !$status['maintenance'];
95
+    }
96 96
 
97
-	/**
98
-	 * @return array
99
-	 * @throws NotFoundException
100
-	 * @throws \Exception
101
-	 */
102
-	private function getStatus() {
103
-		if ($this->status) {
104
-			return $this->status;
105
-		}
106
-		$key = 'remote/' . $this->url . '/status';
107
-		$httpsKey = 'remote/' . $this->url . '/https';
108
-		$status = $this->cache->get($key);
109
-		if (!$status) {
110
-			$response = $this->downloadStatus('https://' . $this->getUrl() . '/status.php');
111
-			$protocol = 'https';
112
-			if (!$response) {
113
-				if ($status = $this->cache->get($httpsKey)) {
114
-					throw new \Exception('refusing to connect to remote instance(' . $this->url . ') over http that was previously accessible over https');
115
-				}
116
-				$response = $this->downloadStatus('http://' . $this->getUrl() . '/status.php');
117
-				$protocol = 'http';
118
-			} else {
119
-				$this->cache->set($httpsKey, true, 60 * 60 * 24 * 365);
120
-			}
121
-			$status = json_decode($response, true);
122
-			if ($status) {
123
-				$status['protocol'] = $protocol;
124
-			}
125
-			if ($status) {
126
-				$this->cache->set($key, $status, 5 * 60);
127
-				$this->status = $status;
128
-			} else {
129
-				throw new NotFoundException('Remote server not found at address ' . $this->url);
130
-			}
131
-		}
132
-		return $status;
133
-	}
97
+    /**
98
+     * @return array
99
+     * @throws NotFoundException
100
+     * @throws \Exception
101
+     */
102
+    private function getStatus() {
103
+        if ($this->status) {
104
+            return $this->status;
105
+        }
106
+        $key = 'remote/' . $this->url . '/status';
107
+        $httpsKey = 'remote/' . $this->url . '/https';
108
+        $status = $this->cache->get($key);
109
+        if (!$status) {
110
+            $response = $this->downloadStatus('https://' . $this->getUrl() . '/status.php');
111
+            $protocol = 'https';
112
+            if (!$response) {
113
+                if ($status = $this->cache->get($httpsKey)) {
114
+                    throw new \Exception('refusing to connect to remote instance(' . $this->url . ') over http that was previously accessible over https');
115
+                }
116
+                $response = $this->downloadStatus('http://' . $this->getUrl() . '/status.php');
117
+                $protocol = 'http';
118
+            } else {
119
+                $this->cache->set($httpsKey, true, 60 * 60 * 24 * 365);
120
+            }
121
+            $status = json_decode($response, true);
122
+            if ($status) {
123
+                $status['protocol'] = $protocol;
124
+            }
125
+            if ($status) {
126
+                $this->cache->set($key, $status, 5 * 60);
127
+                $this->status = $status;
128
+            } else {
129
+                throw new NotFoundException('Remote server not found at address ' . $this->url);
130
+            }
131
+        }
132
+        return $status;
133
+    }
134 134
 
135
-	/**
136
-	 * @param string $url
137
-	 * @return bool|string
138
-	 */
139
-	private function downloadStatus($url) {
140
-		try {
141
-			$request = $this->clientService->newClient()->get($url);
142
-			return $request->getBody();
143
-		} catch (\Exception $e) {
144
-			return false;
145
-		}
146
-	}
135
+    /**
136
+     * @param string $url
137
+     * @return bool|string
138
+     */
139
+    private function downloadStatus($url) {
140
+        try {
141
+            $request = $this->clientService->newClient()->get($url);
142
+            return $request->getBody();
143
+        } catch (\Exception $e) {
144
+            return false;
145
+        }
146
+    }
147 147
 }
Please login to merge, or discard this patch.
lib/private/Remote/Api/ApiFactory.php 1 patch
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -28,14 +28,14 @@
 block discarded – undo
28 28
 use OCP\Remote\IInstance;
29 29
 
30 30
 class ApiFactory implements IApiFactory {
31
-	/** @var IClientService */
32
-	private $clientService;
31
+    /** @var IClientService */
32
+    private $clientService;
33 33
 
34
-	public function __construct(IClientService $clientService) {
35
-		$this->clientService = $clientService;
36
-	}
34
+    public function __construct(IClientService $clientService) {
35
+        $this->clientService = $clientService;
36
+    }
37 37
 
38
-	public function getApiCollection(IInstance $instance, ICredentials $credentials) {
39
-		return new ApiCollection($instance, $credentials, $this->clientService);
40
-	}
38
+    public function getApiCollection(IInstance $instance, ICredentials $credentials) {
39
+        return new ApiCollection($instance, $credentials, $this->clientService);
40
+    }
41 41
 }
Please login to merge, or discard this patch.