Completed
Push — master ( 176f57...2c53d3 )
by Daniel
32:12
created
apps/settings/lib/AppInfo/Application.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -131,18 +131,18 @@
 block discarded – undo
131 131
 		/**
132 132
 		 * Core class wrappers
133 133
 		 */
134
-		$context->registerService(IProvider::class, function (IAppContainer $appContainer) {
134
+		$context->registerService(IProvider::class, function(IAppContainer $appContainer) {
135 135
 			/** @var IServerContainer $serverContainer */
136 136
 			$serverContainer = $appContainer->query(IServerContainer::class);
137 137
 			return $serverContainer->query(IProvider::class);
138 138
 		});
139
-		$context->registerService(IManager::class, function (IAppContainer $appContainer) {
139
+		$context->registerService(IManager::class, function(IAppContainer $appContainer) {
140 140
 			/** @var IServerContainer $serverContainer */
141 141
 			$serverContainer = $appContainer->query(IServerContainer::class);
142 142
 			return $serverContainer->getSettingsManager();
143 143
 		});
144 144
 
145
-		$context->registerService(NewUserMailHelper::class, function (IAppContainer $appContainer) {
145
+		$context->registerService(NewUserMailHelper::class, function(IAppContainer $appContainer) {
146 146
 			/** @var Server $server */
147 147
 			$server = $appContainer->query(IServerContainer::class);
148 148
 			/** @var Defaults $defaults */
Please login to merge, or discard this patch.
apps/settings/lib/SetupChecks/CronErrors.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
 			return SetupResult::error(
36 36
 				$this->l10n->t(
37 37
 					"It was not possible to execute the cron job via CLI. The following technical errors have appeared:\n%s",
38
-					implode("\n", array_map(fn (array $error) => '- ' . $error['error'] . ' ' . $error['hint'], $errors))
38
+					implode("\n", array_map(fn (array $error) => '- '.$error['error'].' '.$error['hint'], $errors))
39 39
 				)
40 40
 			);
41 41
 		} else {
Please login to merge, or discard this patch.
apps/settings/lib/SetupChecks/AppDirsWithDifferentOwner.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
 
62 62
 		foreach ($appsDir as $fileInfo) {
63 63
 			if ($fileInfo->isDir() && !$fileInfo->isDot()) {
64
-				$absAppPath = $appsPath . DIRECTORY_SEPARATOR . $fileInfo->getFilename();
64
+				$absAppPath = $appsPath.DIRECTORY_SEPARATOR.$fileInfo->getFilename();
65 65
 				$appDirUser = fileowner($absAppPath);
66 66
 				if ($appDirUser !== $currentUser) {
67 67
 					$appDirsWithDifferentOwner[] = $absAppPath;
Please login to merge, or discard this patch.
apps/settings/lib/SetupChecks/PhpModules.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
 			$moduleList = implode(
76 76
 				"\n",
77 77
 				array_map(
78
-					fn (string $module) => '- ' . $module . ' ' . $this->getRecommendedModuleDescription($module),
78
+					fn (string $module) => '- '.$module.' '.$this->getRecommendedModuleDescription($module),
79 79
 					$missingRecommendedModules
80 80
 				)
81 81
 			);
Please login to merge, or discard this patch.
apps/settings/lib/SetupChecks/SupportedDatabase.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
 			$versionlc = strtolower($version);
54 54
 			// we only care about X.Y not X.Y.Z differences
55 55
 			[$major, $minor, ] = explode('.', $versionlc);
56
-			$versionConcern = $major . '.' . $minor;
56
+			$versionConcern = $major.'.'.$minor;
57 57
 			if (str_contains($versionlc, 'mariadb')) {
58 58
 				if (version_compare($versionConcern, '10.3', '=')) {
59 59
 					return SetupResult::info(
Please login to merge, or discard this patch.
apps/settings/lib/SetupChecks/WellKnownUrls.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 		];
53 53
 
54 54
 		$requestOptions = ['httpErrors' => false, 'options' => ['allow_redirects' => ['track_redirects' => true]]];
55
-		foreach ($urls as [$verb,$url,$validStatuses,$checkCustomHeader]) {
55
+		foreach ($urls as [$verb, $url, $validStatuses, $checkCustomHeader]) {
56 56
 			$works = null;
57 57
 			foreach ($this->runRequest($verb, $url, $requestOptions, isRootRequest: true) as $response) {
58 58
 				// Check that the response status matches
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 			// If 'works' is null then we could not connect to the server
77 77
 			if ($works === null) {
78 78
 				return SetupResult::info(
79
-					$this->l10n->t('Could not check that your web server serves `.well-known` correctly. Please check manually.') . "\n" . $this->serverConfigHelp(),
79
+					$this->l10n->t('Could not check that your web server serves `.well-known` correctly. Please check manually.')."\n".$this->serverConfigHelp(),
80 80
 					$this->urlGenerator->linkToDocs('admin-setup-well-known-URL'),
81 81
 				);
82 82
 			}
Please login to merge, or discard this patch.
apps/settings/lib/SetupChecks/DatabaseHasMissingColumns.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -62,10 +62,10 @@
 block discarded – undo
62 62
 		} else {
63 63
 			$list = '';
64 64
 			foreach ($missingColumns as $missingColumn) {
65
-				$list .= "\n" . $this->l10n->t('Missing optional column "%s" in table "%s".', [$missingColumn['columnName'], $missingColumn['tableName']]);
65
+				$list .= "\n".$this->l10n->t('Missing optional column "%s" in table "%s".', [$missingColumn['columnName'], $missingColumn['tableName']]);
66 66
 			}
67 67
 			return SetupResult::warning(
68
-				$this->l10n->t('The database is missing some optional columns. Due to the fact that adding columns on big tables could take some time they were not added automatically when they can be optional. By running "occ db:add-missing-columns" those missing columns could be added manually while the instance keeps running. Once the columns are added some features might improve responsiveness or usability.') . $list
68
+				$this->l10n->t('The database is missing some optional columns. Due to the fact that adding columns on big tables could take some time they were not added automatically when they can be optional. By running "occ db:add-missing-columns" those missing columns could be added manually while the instance keeps running. Once the columns are added some features might improve responsiveness or usability.').$list
69 69
 			);
70 70
 		}
71 71
 	}
Please login to merge, or discard this patch.
apps/settings/lib/SetupChecks/CronInfo.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
 						'type' => 'highlight',
51 51
 						'id' => 'backgroundjobs',
52 52
 						'name' => 'Check the background job settings',
53
-						'link' => $this->urlGenerator->linkToRoute('settings.AdminSettings.index', ['section' => 'server']) . '#backgroundjobs',
53
+						'link' => $this->urlGenerator->linkToRoute('settings.AdminSettings.index', ['section' => 'server']).'#backgroundjobs',
54 54
 					],
55 55
 				],
56 56
 			);
Please login to merge, or discard this patch.
apps/settings/lib/SetupChecks/DatabaseHasMissingIndices.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,13 +79,13 @@
 block discarded – undo
79 79
 			$list = $this->l10n->t('Missing indices:');
80 80
 			foreach ($missingIndices as $missingIndex) {
81 81
 				$processed++;
82
-				$list .= "\n " . $this->l10n->t('"%s" in table "%s"', [$missingIndex['indexName'], $missingIndex['tableName']]);
82
+				$list .= "\n ".$this->l10n->t('"%s" in table "%s"', [$missingIndex['indexName'], $missingIndex['tableName']]);
83 83
 				if (count($missingIndices) > $processed) {
84 84
 					$list .= ', ';
85 85
 				}
86 86
 			}
87 87
 			return SetupResult::warning(
88
-				$this->l10n->t('Detected some missing optional indices. Occasionally new indices are added (by Nextcloud or installed applications) to improve database performance. Adding indices can sometimes take awhile and temporarily hurt performance so this is not done automatically during upgrades. Once the indices are added, queries to those tables should be faster. Use the command `occ db:add-missing-indices` to add them.') . "\n" . $list,
88
+				$this->l10n->t('Detected some missing optional indices. Occasionally new indices are added (by Nextcloud or installed applications) to improve database performance. Adding indices can sometimes take awhile and temporarily hurt performance so this is not done automatically during upgrades. Once the indices are added, queries to those tables should be faster. Use the command `occ db:add-missing-indices` to add them.')."\n".$list,
89 89
 				$this->urlGenerator->linkToDocs('admin-long-running-migration-steps')
90 90
 			);
91 91
 		}
Please login to merge, or discard this patch.