nextcloud / server

apps/dav/lib/Connector/Sabre/SharesPlugin.php

Spacing +2 added lines, -2 removed lines

@@ -148,7 +148,7 @@ 
 
 		$shareTypesByFileId = [];
 
-		foreach($shares as $fileId => $sharesForFile) {
+		foreach ($shares as $fileId => $sharesForFile) {
 			$types = array_map(function(IShare $share) {
 				return $share->getShareType();
 			}, $sharesForFile);
@@ -189,7 +189,7 @@ 
 			}
 		}
 
-		$propFind->handle(self::SHARETYPES_PROPERTYNAME, function () use ($sabreNode) {
+		$propFind->handle(self::SHARETYPES_PROPERTYNAME, function() use ($sabreNode) {
 			if (isset($this->cachedShareTypes[$sabreNode->getId()])) {
 				$shareTypes = $this->cachedShareTypes[$sabreNode->getId()];
 			} else {

Indentation +177 added lines, -177 removed lines

@@ -32,181 +32,181 @@
  */
 class SharesPlugin extends \Sabre\DAV\ServerPlugin {
 
-	const NS_OWNCLOUD = 'http://owncloud.org/ns';
-	const SHARETYPES_PROPERTYNAME = '{http://owncloud.org/ns}share-types';
-
-	/**
-	 * Reference to main server object
-	 *
-	 * @var \Sabre\DAV\Server
-	 */
-	private $server;
-
-	/**
-	 * @var \OCP\Share\IManager
-	 */
-	private $shareManager;
-
-	/**
-	 * @var \Sabre\DAV\Tree
-	 */
-	private $tree;
-
-	/**
-	 * @var string
-	 */
-	private $userId;
-
-	/**
-	 * @var \OCP\Files\Folder
-	 */
-	private $userFolder;
-
-	/**
-	 * @var IShare[]
-	 */
-	private $cachedShareTypes;
-
-	private $cachedFolders = [];
-
-	/**
-	 * @param \Sabre\DAV\Tree $tree tree
-	 * @param IUserSession $userSession user session
-	 * @param \OCP\Files\Folder $userFolder user home folder
-	 * @param \OCP\Share\IManager $shareManager share manager
-	 */
-	public function __construct(
-		\Sabre\DAV\Tree $tree,
-		IUserSession $userSession,
-		\OCP\Files\Folder $userFolder,
-		\OCP\Share\IManager $shareManager
-	) {
-		$this->tree = $tree;
-		$this->shareManager = $shareManager;
-		$this->userFolder = $userFolder;
-		$this->userId = $userSession->getUser()->getUID();
-		$this->cachedShareTypes = [];
-	}
-
-	/**
-	 * This initializes the plugin.
-	 *
-	 * This function is called by \Sabre\DAV\Server, after
-	 * addPlugin is called.
-	 *
-	 * This method should set up the required event subscriptions.
-	 *
-	 * @param \Sabre\DAV\Server $server
-	 */
-	public function initialize(\Sabre\DAV\Server $server) {
-		$server->xml->namespacesMap[self::NS_OWNCLOUD] = 'oc';
-		$server->xml->elementMap[self::SHARETYPES_PROPERTYNAME] = 'OCA\\DAV\\Connector\\Sabre\\ShareTypeList';
-		$server->protectedProperties[] = self::SHARETYPES_PROPERTYNAME;
-
-		$this->server = $server;
-		$this->server->on('propFind', array($this, 'handleGetProperties'));
-	}
-
-	/**
-	 * Return a list of share types for outgoing shares
-	 *
-	 * @param \OCP\Files\Node $node file node
-	 *
-	 * @return int[] array of share types
-	 */
-	private function getShareTypes(\OCP\Files\Node $node) {
-		$shareTypes = [];
-		$requestedShareTypes = [
-			\OCP\Share::SHARE_TYPE_USER,
-			\OCP\Share::SHARE_TYPE_GROUP,
-			\OCP\Share::SHARE_TYPE_LINK,
-			\OCP\Share::SHARE_TYPE_REMOTE,
-			\OCP\Share::SHARE_TYPE_EMAIL,
-		];
-		foreach ($requestedShareTypes as $requestedShareType) {
-			// one of each type is enough to find out about the types
-			$shares = $this->shareManager->getSharesBy(
-				$this->userId,
-				$requestedShareType,
-				$node,
-				false,
-				1
-			);
-			if (!empty($shares)) {
-				$shareTypes[] = $requestedShareType;
-			}
-		}
-		return $shareTypes;
-	}
-
-	private function getSharesTypesInFolder(\OCP\Files\Folder $node) {
-		$shares = $this->shareManager->getSharesInFolder(
-			$this->userId,
-			$node,
-			true
-		);
-
-		$shareTypesByFileId = [];
-
-		foreach($shares as $fileId => $sharesForFile) {
-			$types = array_map(function(IShare $share) {
-				return $share->getShareType();
-			}, $sharesForFile);
-			$types = array_unique($types);
-			sort($types);
-			$shareTypesByFileId[$fileId] = $types;
-		}
-
-		return $shareTypesByFileId;
-	}
-
-	/**
-	 * Adds shares to propfind response
-	 *
-	 * @param PropFind $propFind propfind object
-	 * @param \Sabre\DAV\INode $sabreNode sabre node
-	 */
-	public function handleGetProperties(
-		PropFind $propFind,
-		\Sabre\DAV\INode $sabreNode
-	) {
-		if (!($sabreNode instanceof \OCA\DAV\Connector\Sabre\Node)) {
-			return;
-		}
-
-		// need prefetch ?
-		if ($sabreNode instanceof \OCA\DAV\Connector\Sabre\Directory
-			&& $propFind->getDepth() !== 0
-			&& !is_null($propFind->getStatus(self::SHARETYPES_PROPERTYNAME))
-		) {
-			$folderNode = $this->userFolder->get($sabreNode->getPath());
-
-			$childShares = $this->getSharesTypesInFolder($folderNode);
-			$this->cachedFolders[] = $sabreNode->getPath();
-			$this->cachedShareTypes[$folderNode->getId()] = $this->getShareTypes($folderNode);
-			foreach ($childShares as $id => $shares) {
-				$this->cachedShareTypes[$id] = $shares;
-			}
-		}
-
-		$propFind->handle(self::SHARETYPES_PROPERTYNAME, function () use ($sabreNode) {
-			if (isset($this->cachedShareTypes[$sabreNode->getId()])) {
-				$shareTypes = $this->cachedShareTypes[$sabreNode->getId()];
-			} else {
-				list($parentPath,) = \Sabre\Uri\split($sabreNode->getPath());
-				if ($parentPath === '') {
-					$parentPath = '/';
-				}
-				// if we already cached the folder this file is in we know there are no shares for this file
-				if (array_search($parentPath, $this->cachedFolders) === false) {
-					$node = $this->userFolder->get($sabreNode->getPath());
-					$shareTypes = $this->getShareTypes($node);
-				} else {
-					return [];
-				}
-			}
-
-			return new ShareTypeList($shareTypes);
-		});
-	}
+    const NS_OWNCLOUD = 'http://owncloud.org/ns';
+    const SHARETYPES_PROPERTYNAME = '{http://owncloud.org/ns}share-types';
+
+    /**
+     * Reference to main server object
+     *
+     * @var \Sabre\DAV\Server
+     */
+    private $server;
+
+    /**
+     * @var \OCP\Share\IManager
+     */
+    private $shareManager;
+
+    /**
+     * @var \Sabre\DAV\Tree
+     */
+    private $tree;
+
+    /**
+     * @var string
+     */
+    private $userId;
+
+    /**
+     * @var \OCP\Files\Folder
+     */
+    private $userFolder;
+
+    /**
+     * @var IShare[]
+     */
+    private $cachedShareTypes;
+
+    private $cachedFolders = [];
+
+    /**
+     * @param \Sabre\DAV\Tree $tree tree
+     * @param IUserSession $userSession user session
+     * @param \OCP\Files\Folder $userFolder user home folder
+     * @param \OCP\Share\IManager $shareManager share manager
+     */
+    public function __construct(
+        \Sabre\DAV\Tree $tree,
+        IUserSession $userSession,
+        \OCP\Files\Folder $userFolder,
+        \OCP\Share\IManager $shareManager
+    ) {
+        $this->tree = $tree;
+        $this->shareManager = $shareManager;
+        $this->userFolder = $userFolder;
+        $this->userId = $userSession->getUser()->getUID();
+        $this->cachedShareTypes = [];
+    }
+
+    /**
+     * This initializes the plugin.
+     *
+     * This function is called by \Sabre\DAV\Server, after
+     * addPlugin is called.
+     *
+     * This method should set up the required event subscriptions.
+     *
+     * @param \Sabre\DAV\Server $server
+     */
+    public function initialize(\Sabre\DAV\Server $server) {
+        $server->xml->namespacesMap[self::NS_OWNCLOUD] = 'oc';
+        $server->xml->elementMap[self::SHARETYPES_PROPERTYNAME] = 'OCA\\DAV\\Connector\\Sabre\\ShareTypeList';
+        $server->protectedProperties[] = self::SHARETYPES_PROPERTYNAME;
+
+        $this->server = $server;
+        $this->server->on('propFind', array($this, 'handleGetProperties'));
+    }
+
+    /**
+     * Return a list of share types for outgoing shares
+     *
+     * @param \OCP\Files\Node $node file node
+     *
+     * @return int[] array of share types
+     */
+    private function getShareTypes(\OCP\Files\Node $node) {
+        $shareTypes = [];
+        $requestedShareTypes = [
+            \OCP\Share::SHARE_TYPE_USER,
+            \OCP\Share::SHARE_TYPE_GROUP,
+            \OCP\Share::SHARE_TYPE_LINK,
+            \OCP\Share::SHARE_TYPE_REMOTE,
+            \OCP\Share::SHARE_TYPE_EMAIL,
+        ];
+        foreach ($requestedShareTypes as $requestedShareType) {
+            // one of each type is enough to find out about the types
+            $shares = $this->shareManager->getSharesBy(
+                $this->userId,
+                $requestedShareType,
+                $node,
+                false,
+                1
+            );
+            if (!empty($shares)) {
+                $shareTypes[] = $requestedShareType;
+            }
+        }
+        return $shareTypes;
+    }
+
+    private function getSharesTypesInFolder(\OCP\Files\Folder $node) {
+        $shares = $this->shareManager->getSharesInFolder(
+            $this->userId,
+            $node,
+            true
+        );
+
+        $shareTypesByFileId = [];
+
+        foreach($shares as $fileId => $sharesForFile) {
+            $types = array_map(function(IShare $share) {
+                return $share->getShareType();
+            }, $sharesForFile);
+            $types = array_unique($types);
+            sort($types);
+            $shareTypesByFileId[$fileId] = $types;
+        }
+
+        return $shareTypesByFileId;
+    }
+
+    /**
+     * Adds shares to propfind response
+     *
+     * @param PropFind $propFind propfind object
+     * @param \Sabre\DAV\INode $sabreNode sabre node
+     */
+    public function handleGetProperties(
+        PropFind $propFind,
+        \Sabre\DAV\INode $sabreNode
+    ) {
+        if (!($sabreNode instanceof \OCA\DAV\Connector\Sabre\Node)) {
+            return;
+        }
+
+        // need prefetch ?
+        if ($sabreNode instanceof \OCA\DAV\Connector\Sabre\Directory
+            && $propFind->getDepth() !== 0
+            && !is_null($propFind->getStatus(self::SHARETYPES_PROPERTYNAME))
+        ) {
+            $folderNode = $this->userFolder->get($sabreNode->getPath());
+
+            $childShares = $this->getSharesTypesInFolder($folderNode);
+            $this->cachedFolders[] = $sabreNode->getPath();
+            $this->cachedShareTypes[$folderNode->getId()] = $this->getShareTypes($folderNode);
+            foreach ($childShares as $id => $shares) {
+                $this->cachedShareTypes[$id] = $shares;
+            }
+        }
+
+        $propFind->handle(self::SHARETYPES_PROPERTYNAME, function () use ($sabreNode) {
+            if (isset($this->cachedShareTypes[$sabreNode->getId()])) {
+                $shareTypes = $this->cachedShareTypes[$sabreNode->getId()];
+            } else {
+                list($parentPath,) = \Sabre\Uri\split($sabreNode->getPath());
+                if ($parentPath === '') {
+                    $parentPath = '/';
+                }
+                // if we already cached the folder this file is in we know there are no shares for this file
+                if (array_search($parentPath, $this->cachedFolders) === false) {
+                    $node = $this->userFolder->get($sabreNode->getPath());
+                    $shareTypes = $this->getShareTypes($node);
+                } else {
+                    return [];
+                }
+            }
+
+            return new ShareTypeList($shareTypes);
+        });
+    }
 }

apps/dav/lib/Connector/LegacyDAVACL.php

Indentation +33 added lines, -33 removed lines

@@ -32,42 +32,42 @@
 
 class LegacyDAVACL extends DavAclPlugin {
 
-	/**
-	 * @inheritdoc
-	 */
-	public function getCurrentUserPrincipals() {
-		$principalV2 = $this->getCurrentUserPrincipal();
+    /**
+     * @inheritdoc
+     */
+    public function getCurrentUserPrincipals() {
+        $principalV2 = $this->getCurrentUserPrincipal();
 
-		if (is_null($principalV2)) return [];
+        if (is_null($principalV2)) return [];
 
-		$principalV1 = $this->convertPrincipal($principalV2, false);
-		return array_merge(
-			[
-				$principalV2,
-				$principalV1
-			],
-			$this->getPrincipalMembership($principalV1)
-		);
-	}
+        $principalV1 = $this->convertPrincipal($principalV2, false);
+        return array_merge(
+            [
+                $principalV2,
+                $principalV1
+            ],
+            $this->getPrincipalMembership($principalV1)
+        );
+    }
 
-	private function convertPrincipal($principal, $toV2) {
-		list(, $name) = URLUtil::splitPath($principal);
-		if ($toV2) {
-			return "principals/users/$name";
-		}
-		return "principals/$name";
-	}
+    private function convertPrincipal($principal, $toV2) {
+        list(, $name) = URLUtil::splitPath($principal);
+        if ($toV2) {
+            return "principals/users/$name";
+        }
+        return "principals/$name";
+    }
 
-	public function propFind(PropFind $propFind, INode $node) {
-		/* Overload current-user-principal */
-		$propFind->handle('{DAV:}current-user-principal', function () {
-			if ($url = parent::getCurrentUserPrincipal()) {
-				return new Principal(Principal::HREF, $url . '/');
-			} else {
-				return new Principal(Principal::UNAUTHENTICATED);
-			}
-		});
+    public function propFind(PropFind $propFind, INode $node) {
+        /* Overload current-user-principal */
+        $propFind->handle('{DAV:}current-user-principal', function () {
+            if ($url = parent::getCurrentUserPrincipal()) {
+                return new Principal(Principal::HREF, $url . '/');
+            } else {
+                return new Principal(Principal::UNAUTHENTICATED);
+            }
+        });
 
-		return parent::propFind($propFind, $node);
-	}
+        return parent::propFind($propFind, $node);
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -60,9 +60,9 @@
 
 	public function propFind(PropFind $propFind, INode $node) {
 		/* Overload current-user-principal */
-		$propFind->handle('{DAV:}current-user-principal', function () {
+		$propFind->handle('{DAV:}current-user-principal', function() {
 			if ($url = parent::getCurrentUserPrincipal()) {
-				return new Principal(Principal::HREF, $url . '/');
+				return new Principal(Principal::HREF, $url.'/');
 			} else {
 				return new Principal(Principal::UNAUTHENTICATED);
 			}

Braces +3 added lines, -1 removed lines

@@ -38,7 +38,9 @@
 	public function getCurrentUserPrincipals() {
 		$principalV2 = $this->getCurrentUserPrincipal();
 
-		if (is_null($principalV2)) return [];
+		if (is_null($principalV2)) {
+		    return [];
+		}
 
 		$principalV1 = $this->convertPrincipal($principalV2, false);
 		return array_merge(

apps/dav/lib/Migration/ValueFix.php

Indentation +34 added lines, -34 removed lines

@@ -29,43 +29,43 @@
 
 class ValueFix extends QueuedJob {
 
-	/** @var CalDavBackend */
-	private $calDavBackend;
+    /** @var CalDavBackend */
+    private $calDavBackend;
 
-	/** @var ILogger */
-	private $logger;
+    /** @var ILogger */
+    private $logger;
 
-	public function __construct(CalDavBackend $calDavBackend, ILogger $logger) {
-		$this->calDavBackend = $calDavBackend;
-		$this->logger = $logger;
-	}
+    public function __construct(CalDavBackend $calDavBackend, ILogger $logger) {
+        $this->calDavBackend = $calDavBackend;
+        $this->logger = $logger;
+    }
 
-	public function run($argument) {
-		$user = $argument['user'];
+    public function run($argument) {
+        $user = $argument['user'];
 
-		$pattern = '/;VALUE=:/';
- 		$principal = 'principals/users/' . $user;
-		$calendars = $this->calDavBackend->getCalendarsForUser($principal);
-		foreach ($calendars as $calendar) {
-			$objects = $this->calDavBackend->getCalendarObjects($calendar['id']);
-			foreach ($objects as $object) {
-				$calObject = $this->calDavBackend->getCalendarObject($calendar['id'], $object['uri']);
-				$data = preg_replace($pattern, ':', $calObject['calendardata']);
-				if ($data !== $calObject['calendardata']) {
-					try {
-						$this->calDavBackend->getDenormalizedData($data);
-					} catch (InvalidDataException $e) {
-						$this->logger->info('Calendar object for calendar {cal} with uri {uri} still invalid', [
-							'app'=> 'dav',
-							'cal' => $calendar['id'],
-							'uri' => $object['uri'],
-						]);
-						continue;
-					}
-					$this->calDavBackend->updateCalendarObject($calendar['id'], $object['uri'], $data);
-				}
-			}
-		}
-	}
+        $pattern = '/;VALUE=:/';
+            $principal = 'principals/users/' . $user;
+        $calendars = $this->calDavBackend->getCalendarsForUser($principal);
+        foreach ($calendars as $calendar) {
+            $objects = $this->calDavBackend->getCalendarObjects($calendar['id']);
+            foreach ($objects as $object) {
+                $calObject = $this->calDavBackend->getCalendarObject($calendar['id'], $object['uri']);
+                $data = preg_replace($pattern, ':', $calObject['calendardata']);
+                if ($data !== $calObject['calendardata']) {
+                    try {
+                        $this->calDavBackend->getDenormalizedData($data);
+                    } catch (InvalidDataException $e) {
+                        $this->logger->info('Calendar object for calendar {cal} with uri {uri} still invalid', [
+                            'app'=> 'dav',
+                            'cal' => $calendar['id'],
+                            'uri' => $object['uri'],
+                        ]);
+                        continue;
+                    }
+                    $this->calDavBackend->updateCalendarObject($calendar['id'], $object['uri'], $data);
+                }
+            }
+        }
+    }
 
 }

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
 		$user = $argument['user'];
 
 		$pattern = '/;VALUE=:/';
- 		$principal = 'principals/users/' . $user;
+ 		$principal = 'principals/users/'.$user;
 		$calendars = $this->calDavBackend->getCalendarsForUser($principal);
 		foreach ($calendars as $calendar) {
 			$objects = $this->calDavBackend->getCalendarObjects($calendar['id']);

apps/dav/lib/Migration/ValueFixInsert.php

Indentation +29 added lines, -29 removed lines

@@ -31,33 +31,33 @@
 
 class ValueFixInsert implements IRepairStep {
 
-	/** @var IUserManager */
-	private $userManager;
-
-	/** @var IJobList */
-	private $jobList;
-
-	/** @var IConfig */
-	private $config;
-
-	public function __construct(IUserManager $userManager,
-								IJobList $jobList,
-								IConfig $config) {
-		$this->userManager = $userManager;
-		$this->jobList = $jobList;
-		$this->config = $config;
-	}
-
-	public function getName() {
-		return 'Insert ValueFix background job for each user';
-	}
-
-	public function run(IOutput $output) {
-		if ($this->config->getAppValue('dav', self::class . '_ran', 'false') !== 'true') {
-			$this->userManager->callForSeenUsers(function (IUser $user) {
-				$this->jobList->add(ValueFix::class, ['user' => $user->getUID()]);
-			});
-			$this->config->setAppValue('dav', self::class . '_ran', 'true');
-		}
-	}
+    /** @var IUserManager */
+    private $userManager;
+
+    /** @var IJobList */
+    private $jobList;
+
+    /** @var IConfig */
+    private $config;
+
+    public function __construct(IUserManager $userManager,
+                                IJobList $jobList,
+                                IConfig $config) {
+        $this->userManager = $userManager;
+        $this->jobList = $jobList;
+        $this->config = $config;
+    }
+
+    public function getName() {
+        return 'Insert ValueFix background job for each user';
+    }
+
+    public function run(IOutput $output) {
+        if ($this->config->getAppValue('dav', self::class . '_ran', 'false') !== 'true') {
+            $this->userManager->callForSeenUsers(function (IUser $user) {
+                $this->jobList->add(ValueFix::class, ['user' => $user->getUID()]);
+            });
+            $this->config->setAppValue('dav', self::class . '_ran', 'true');
+        }
+    }
 }

Spacing +3 added lines, -3 removed lines

@@ -53,11 +53,11 @@
 	}
 
 	public function run(IOutput $output) {
-		if ($this->config->getAppValue('dav', self::class . '_ran', 'false') !== 'true') {
-			$this->userManager->callForSeenUsers(function (IUser $user) {
+		if ($this->config->getAppValue('dav', self::class.'_ran', 'false') !== 'true') {
+			$this->userManager->callForSeenUsers(function(IUser $user) {
 				$this->jobList->add(ValueFix::class, ['user' => $user->getUID()]);
 			});
-			$this->config->setAppValue('dav', self::class . '_ran', 'true');
+			$this->config->setAppValue('dav', self::class.'_ran', 'true');
 		}
 	}
 }

apps/dav/lib/Migration/FixBirthdayCalendarComponent.php

Indentation +31 added lines, -31 removed lines

@@ -28,35 +28,35 @@
 
 class FixBirthdayCalendarComponent implements IRepairStep {
 
-	/** @var IDBConnection */
-	private $connection;
-
-	/**
-	 * FixBirthdayCalendarComponent constructor.
-	 *
-	 * @param IDBConnection $connection
-	 */
-	public function __construct(IDBConnection $connection) {
-		$this->connection = $connection;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getName() {
-		return 'Fix component of birthday calendars';
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function run(IOutput $output) {
-		$query = $this->connection->getQueryBuilder();
-		$updated = $query->update('calendars')
-			->set('components', $query->createNamedParameter('VEVENT'))
-			->where($query->expr()->eq('uri', $query->createNamedParameter(BirthdayService::BIRTHDAY_CALENDAR_URI)))
-			->execute();
-
-		$output->info("$updated birthday calendars updated.");
-	}
+    /** @var IDBConnection */
+    private $connection;
+
+    /**
+     * FixBirthdayCalendarComponent constructor.
+     *
+     * @param IDBConnection $connection
+     */
+    public function __construct(IDBConnection $connection) {
+        $this->connection = $connection;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getName() {
+        return 'Fix component of birthday calendars';
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function run(IOutput $output) {
+        $query = $this->connection->getQueryBuilder();
+        $updated = $query->update('calendars')
+            ->set('components', $query->createNamedParameter('VEVENT'))
+            ->where($query->expr()->eq('uri', $query->createNamedParameter(BirthdayService::BIRTHDAY_CALENDAR_URI)))
+            ->execute();
+
+        $output->info("$updated birthday calendars updated.");
+    }
 }

apps/dav/lib/Command/SyncBirthdayCalendar.php

Indentation +46 added lines, -46 removed lines

@@ -33,55 +33,55 @@
 
 class SyncBirthdayCalendar extends Command {
 
-	/** @var BirthdayService */
-	private $birthdayService;
+    /** @var BirthdayService */
+    private $birthdayService;
 
-	/** @var IUserManager */
-	private $userManager;
+    /** @var IUserManager */
+    private $userManager;
 
-	/**
-	 * @param IUserManager $userManager
-	 * @param BirthdayService $birthdayService
-	 */
-	function __construct(IUserManager $userManager, BirthdayService $birthdayService) {
-		parent::__construct();
-		$this->birthdayService = $birthdayService;
-		$this->userManager = $userManager;
-	}
+    /**
+     * @param IUserManager $userManager
+     * @param BirthdayService $birthdayService
+     */
+    function __construct(IUserManager $userManager, BirthdayService $birthdayService) {
+        parent::__construct();
+        $this->birthdayService = $birthdayService;
+        $this->userManager = $userManager;
+    }
 
-	protected function configure() {
-		$this
-			->setName('dav:sync-birthday-calendar')
-			->setDescription('Synchronizes the birthday calendar')
-			->addArgument('user',
-				InputArgument::OPTIONAL,
-				'User for whom the birthday calendar will be synchronized');
-	}
+    protected function configure() {
+        $this
+            ->setName('dav:sync-birthday-calendar')
+            ->setDescription('Synchronizes the birthday calendar')
+            ->addArgument('user',
+                InputArgument::OPTIONAL,
+                'User for whom the birthday calendar will be synchronized');
+    }
 
-	/**
-	 * @param InputInterface $input
-	 * @param OutputInterface $output
-	 */
-	protected function execute(InputInterface $input, OutputInterface $output) {
-		$user = $input->getArgument('user');
-		if (!is_null($user)) {
-			if (!$this->userManager->userExists($user)) {
-				throw new \InvalidArgumentException("User <$user> in unknown.");
-			}
-			$output->writeln("Start birthday calendar sync for $user");
-			$this->birthdayService->syncUser($user);
-			return;
-		}
-		$output->writeln("Start birthday calendar sync for all users ...");
-		$p = new ProgressBar($output);
-		$p->start();
-		$this->userManager->callForAllUsers(function($user) use ($p)  {
-			$p->advance();
-			/** @var IUser $user */
-			$this->birthdayService->syncUser($user->getUID());
-		});
+    /**
+     * @param InputInterface $input
+     * @param OutputInterface $output
+     */
+    protected function execute(InputInterface $input, OutputInterface $output) {
+        $user = $input->getArgument('user');
+        if (!is_null($user)) {
+            if (!$this->userManager->userExists($user)) {
+                throw new \InvalidArgumentException("User <$user> in unknown.");
+            }
+            $output->writeln("Start birthday calendar sync for $user");
+            $this->birthdayService->syncUser($user);
+            return;
+        }
+        $output->writeln("Start birthday calendar sync for all users ...");
+        $p = new ProgressBar($output);
+        $p->start();
+        $this->userManager->callForAllUsers(function($user) use ($p)  {
+            $p->advance();
+            /** @var IUser $user */
+            $this->birthdayService->syncUser($user->getUID());
+        });
 
-		$p->finish();
-		$output->writeln('');
-	}
+        $p->finish();
+        $output->writeln('');
+    }
 }

apps/dav/lib/Command/CreateCalendar.php

Indentation +43 added lines, -43 removed lines

@@ -33,53 +33,53 @@
 
 class CreateCalendar extends Command {
 
-	/** @var IUserManager */
-	protected $userManager;
+    /** @var IUserManager */
+    protected $userManager;
 
-	/** @var IGroupManager $groupManager */
-	private $groupManager;
+    /** @var IGroupManager $groupManager */
+    private $groupManager;
 
-	/** @var \OCP\IDBConnection */
-	protected $dbConnection;
+    /** @var \OCP\IDBConnection */
+    protected $dbConnection;
 
-	/**
-	 * @param IUserManager $userManager
-	 * @param IGroupManager $groupManager
-	 * @param IDBConnection $dbConnection
-	 */
-	function __construct(IUserManager $userManager, IGroupManager $groupManager, IDBConnection $dbConnection) {
-		parent::__construct();
-		$this->userManager = $userManager;
-		$this->groupManager = $groupManager;
-		$this->dbConnection = $dbConnection;
-	}
+    /**
+     * @param IUserManager $userManager
+     * @param IGroupManager $groupManager
+     * @param IDBConnection $dbConnection
+     */
+    function __construct(IUserManager $userManager, IGroupManager $groupManager, IDBConnection $dbConnection) {
+        parent::__construct();
+        $this->userManager = $userManager;
+        $this->groupManager = $groupManager;
+        $this->dbConnection = $dbConnection;
+    }
 
-	protected function configure() {
-		$this
-			->setName('dav:create-calendar')
-			->setDescription('Create a dav calendar')
-			->addArgument('user',
-				InputArgument::REQUIRED,
-				'User for whom the calendar will be created')
-			->addArgument('name',
-				InputArgument::REQUIRED,
-				'Name of the calendar');
-	}
+    protected function configure() {
+        $this
+            ->setName('dav:create-calendar')
+            ->setDescription('Create a dav calendar')
+            ->addArgument('user',
+                InputArgument::REQUIRED,
+                'User for whom the calendar will be created')
+            ->addArgument('name',
+                InputArgument::REQUIRED,
+                'Name of the calendar');
+    }
 
-	protected function execute(InputInterface $input, OutputInterface $output) {
-		$user = $input->getArgument('user');
-		if (!$this->userManager->userExists($user)) {
-			throw new \InvalidArgumentException("User <$user> in unknown.");
-		}
-		$principalBackend = new Principal(
-			$this->userManager,
-			$this->groupManager
-		);
-		$random = \OC::$server->getSecureRandom();
-		$dispatcher = \OC::$server->getEventDispatcher();
+    protected function execute(InputInterface $input, OutputInterface $output) {
+        $user = $input->getArgument('user');
+        if (!$this->userManager->userExists($user)) {
+            throw new \InvalidArgumentException("User <$user> in unknown.");
+        }
+        $principalBackend = new Principal(
+            $this->userManager,
+            $this->groupManager
+        );
+        $random = \OC::$server->getSecureRandom();
+        $dispatcher = \OC::$server->getEventDispatcher();
 
-		$name = $input->getArgument('name');
-		$caldav = new CalDavBackend($this->dbConnection, $principalBackend, $this->userManager, $random, $dispatcher);
-		$caldav->createCalendar("principals/users/$user", $name, []);
-	}
+        $name = $input->getArgument('name');
+        $caldav = new CalDavBackend($this->dbConnection, $principalBackend, $this->userManager, $random, $dispatcher);
+        $caldav->createCalendar("principals/users/$user", $name, []);
+    }
 }

apps/dav/lib/Capabilities.php

Indentation +7 added lines, -7 removed lines

@@ -26,11 +26,11 @@
 
 class Capabilities implements ICapability {
 
-	public function getCapabilities() {
-		return [
-			'dav' => [
-				'chunking' => '1.0',
-			]
-		];
-	}
+    public function getCapabilities() {
+        return [
+            'dav' => [
+                'chunking' => '1.0',
+            ]
+        ];
+    }
 }

apps/dav/lib/RootCollection.php

Indentation +74 added lines, -74 removed lines

@@ -37,86 +37,86 @@
 
 class RootCollection extends SimpleCollection {
 
-	public function __construct() {
-		$config = \OC::$server->getConfig();
-		$random = \OC::$server->getSecureRandom();
-		$userManager = \OC::$server->getUserManager();
-		$db = \OC::$server->getDatabaseConnection();
-		$dispatcher = \OC::$server->getEventDispatcher();
-		$userPrincipalBackend = new Principal(
-			$userManager,
-			\OC::$server->getGroupManager()
-		);
-		$groupPrincipalBackend = new GroupPrincipalBackend(
-			\OC::$server->getGroupManager()
-		);
-		// as soon as debug mode is enabled we allow listing of principals
-		$disableListing = !$config->getSystemValue('debug', false);
+    public function __construct() {
+        $config = \OC::$server->getConfig();
+        $random = \OC::$server->getSecureRandom();
+        $userManager = \OC::$server->getUserManager();
+        $db = \OC::$server->getDatabaseConnection();
+        $dispatcher = \OC::$server->getEventDispatcher();
+        $userPrincipalBackend = new Principal(
+            $userManager,
+            \OC::$server->getGroupManager()
+        );
+        $groupPrincipalBackend = new GroupPrincipalBackend(
+            \OC::$server->getGroupManager()
+        );
+        // as soon as debug mode is enabled we allow listing of principals
+        $disableListing = !$config->getSystemValue('debug', false);
 
-		// setup the first level of the dav tree
-		$userPrincipals = new Collection($userPrincipalBackend, 'principals/users');
-		$userPrincipals->disableListing = $disableListing;
-		$groupPrincipals = new Collection($groupPrincipalBackend, 'principals/groups');
-		$groupPrincipals->disableListing = $disableListing;
-		$systemPrincipals = new Collection(new SystemPrincipalBackend(), 'principals/system');
-		$systemPrincipals->disableListing = $disableListing;
-		$filesCollection = new Files\RootCollection($userPrincipalBackend, 'principals/users');
-		$filesCollection->disableListing = $disableListing;
-		$caldavBackend = new CalDavBackend($db, $userPrincipalBackend, $userManager, $random, $dispatcher);
-		$calendarRoot = new CalendarRoot($userPrincipalBackend, $caldavBackend, 'principals/users');
-		$calendarRoot->disableListing = $disableListing;
-		$publicCalendarRoot = new PublicCalendarRoot($caldavBackend);
-		$publicCalendarRoot->disableListing = $disableListing;
+        // setup the first level of the dav tree
+        $userPrincipals = new Collection($userPrincipalBackend, 'principals/users');
+        $userPrincipals->disableListing = $disableListing;
+        $groupPrincipals = new Collection($groupPrincipalBackend, 'principals/groups');
+        $groupPrincipals->disableListing = $disableListing;
+        $systemPrincipals = new Collection(new SystemPrincipalBackend(), 'principals/system');
+        $systemPrincipals->disableListing = $disableListing;
+        $filesCollection = new Files\RootCollection($userPrincipalBackend, 'principals/users');
+        $filesCollection->disableListing = $disableListing;
+        $caldavBackend = new CalDavBackend($db, $userPrincipalBackend, $userManager, $random, $dispatcher);
+        $calendarRoot = new CalendarRoot($userPrincipalBackend, $caldavBackend, 'principals/users');
+        $calendarRoot->disableListing = $disableListing;
+        $publicCalendarRoot = new PublicCalendarRoot($caldavBackend);
+        $publicCalendarRoot->disableListing = $disableListing;
 
-		$systemTagCollection = new SystemTag\SystemTagsByIdCollection(
-			\OC::$server->getSystemTagManager(),
-			\OC::$server->getUserSession(),
-			\OC::$server->getGroupManager()
-		);
-		$systemTagRelationsCollection = new SystemTag\SystemTagsRelationsCollection(
-			\OC::$server->getSystemTagManager(),
-			\OC::$server->getSystemTagObjectMapper(),
-			\OC::$server->getUserSession(),
-			\OC::$server->getGroupManager(),
-			\OC::$server->getEventDispatcher()
-		);
-		$commentsCollection = new Comments\RootCollection(
-			\OC::$server->getCommentsManager(),
-			\OC::$server->getUserManager(),
-			\OC::$server->getUserSession(),
-			\OC::$server->getEventDispatcher(),
-			\OC::$server->getLogger()
-		);
+        $systemTagCollection = new SystemTag\SystemTagsByIdCollection(
+            \OC::$server->getSystemTagManager(),
+            \OC::$server->getUserSession(),
+            \OC::$server->getGroupManager()
+        );
+        $systemTagRelationsCollection = new SystemTag\SystemTagsRelationsCollection(
+            \OC::$server->getSystemTagManager(),
+            \OC::$server->getSystemTagObjectMapper(),
+            \OC::$server->getUserSession(),
+            \OC::$server->getGroupManager(),
+            \OC::$server->getEventDispatcher()
+        );
+        $commentsCollection = new Comments\RootCollection(
+            \OC::$server->getCommentsManager(),
+            \OC::$server->getUserManager(),
+            \OC::$server->getUserSession(),
+            \OC::$server->getEventDispatcher(),
+            \OC::$server->getLogger()
+        );
 
-		$usersCardDavBackend = new CardDavBackend($db, $userPrincipalBackend, \OC::$server->getUserManager(), $dispatcher);
-		$usersAddressBookRoot = new AddressBookRoot($userPrincipalBackend, $usersCardDavBackend, 'principals/users');
-		$usersAddressBookRoot->disableListing = $disableListing;
+        $usersCardDavBackend = new CardDavBackend($db, $userPrincipalBackend, \OC::$server->getUserManager(), $dispatcher);
+        $usersAddressBookRoot = new AddressBookRoot($userPrincipalBackend, $usersCardDavBackend, 'principals/users');
+        $usersAddressBookRoot->disableListing = $disableListing;
 
-		$systemCardDavBackend = new CardDavBackend($db, $userPrincipalBackend, \OC::$server->getUserManager(), $dispatcher);
-		$systemAddressBookRoot = new AddressBookRoot(new SystemPrincipalBackend(), $systemCardDavBackend, 'principals/system');
-		$systemAddressBookRoot->disableListing = $disableListing;
+        $systemCardDavBackend = new CardDavBackend($db, $userPrincipalBackend, \OC::$server->getUserManager(), $dispatcher);
+        $systemAddressBookRoot = new AddressBookRoot(new SystemPrincipalBackend(), $systemCardDavBackend, 'principals/system');
+        $systemAddressBookRoot->disableListing = $disableListing;
 
-		$uploadCollection = new Upload\RootCollection($userPrincipalBackend, 'principals/users');
-		$uploadCollection->disableListing = $disableListing;
+        $uploadCollection = new Upload\RootCollection($userPrincipalBackend, 'principals/users');
+        $uploadCollection->disableListing = $disableListing;
 
-		$children = [
-				new SimpleCollection('principals', [
-						$userPrincipals,
-						$groupPrincipals,
-						$systemPrincipals]),
-				$filesCollection,
-				$calendarRoot,
-				$publicCalendarRoot,
-				new SimpleCollection('addressbooks', [
-						$usersAddressBookRoot,
-						$systemAddressBookRoot]),
-				$systemTagCollection,
-				$systemTagRelationsCollection,
-				$commentsCollection,
-				$uploadCollection,
-		];
+        $children = [
+                new SimpleCollection('principals', [
+                        $userPrincipals,
+                        $groupPrincipals,
+                        $systemPrincipals]),
+                $filesCollection,
+                $calendarRoot,
+                $publicCalendarRoot,
+                new SimpleCollection('addressbooks', [
+                        $usersAddressBookRoot,
+                        $systemAddressBookRoot]),
+                $systemTagCollection,
+                $systemTagRelationsCollection,
+                $commentsCollection,
+                $uploadCollection,
+        ];
 
-		parent::__construct('root', $children);
-	}
+        parent::__construct('root', $children);
+    }
 
 }