IconBuilder::renderAppIcon() - Code Metrics - Inspection of "Merge pull request #6460 from nextcloud/theming-fa..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ed37dc...26bcf4 )

by Morris

created 2017-11-13 11:15 UTC

IconBuilder::renderAppIcon() D

↳ Parent: IconBuilder

Complexity

Conditions	13
Paths	39

Size

Total Lines	96
Code Lines	69

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	13
eloc	69
nc	39
nop	2
dl	0
loc	96
rs	4.9922
c	0
b	0
f	0

How to fix Long Method Complexity

<?php
/**
 * @copyright Copyright (c) 2016 Julius Härtl <[email protected]>
 *
 * @author Jan-Christoph Borchardt <[email protected]>
 * @author Julius Haertl <[email protected]>
 * @author Julius Härtl <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\Theming;

use Imagick;
use ImagickPixel;
use OCP\App\AppPathNotFoundException;
use OCP\Files\SimpleFS\ISimpleFile;

class IconBuilder {
	/** @var ThemingDefaults */
	private $themingDefaults;
	/** @var Util */
	private $util;

	/**
	 * IconBuilder constructor.
	 *
	 * @param ThemingDefaults $themingDefaults
	 * @param Util $util
	 */
	public function __construct(
		ThemingDefaults $themingDefaults,
		Util $util
	) {
		$this->themingDefaults = $themingDefaults;
		$this->util = $util;
	}

	/**
	 * @param $app string app name
	 * @return string|false image blob
	 */
	public function getFavicon($app) {
		if (!$this->themingDefaults->shouldReplaceIcons()) {
			return false;
		}
		try {
			$favicon = new Imagick();
			$favicon->setFormat("ico");
			$icon = $this->renderAppIcon($app, 128);
			if ($icon === false) {
				return false;
			}
			$icon->setImageFormat("png32");

			$clone = clone $icon;
			$clone->scaleImage(16,0);
			$favicon->addImage($clone);

			$clone = clone $icon;
			$clone->scaleImage(32,0);
			$favicon->addImage($clone);

			$clone = clone $icon;
			$clone->scaleImage(64,0);
			$favicon->addImage($clone);

			$clone = clone $icon;
			$clone->scaleImage(128,0);
			$favicon->addImage($clone);

			$data = $favicon->getImagesBlob();
			$favicon->destroy();
			$icon->destroy();
			$clone->destroy();
			return $data;
		} catch (\ImagickException $e) {
			return false;
		}
	}

	/**
	 * @param $app string app name
	 * @return string|false image blob
	 */
	public function getTouchIcon($app) {
		try {
			$icon = $this->renderAppIcon($app, 512);
			if ($icon === false) {
				return false;
			}
			$icon->setImageFormat("png32");
			$data = $icon->getImageBlob();
			$icon->destroy();
			return $data;
		} catch (\ImagickException $e) {
			return false;
		}
	}

	/**
	 * Render app icon on themed background color
	 * fallback to logo
	 *
	 * @param $app string app name
	 * @param $size int size of the icon in px
	 * @return Imagick|false
	 */
	public function renderAppIcon($app, $size) {
		$appIcon = $this->util->getAppIcon($app);
		if($appIcon === false) {
			return false;
		}
		if ($appIcon instanceof ISimpleFile) {
			$appIconContent = $appIcon->getContent();
			$mime = $appIcon->getMimeType();
		} else {
			$appIconContent = file_get_contents($appIcon);
			$mime = mime_content_type($appIcon);
		}

		if($appIconContent === false || $appIconContent === "") {
			return false;
		}

		$color = $this->themingDefaults->getColorPrimary();

		// generate background image with rounded corners
		$background = '<?xml version="1.0" encoding="UTF-8"?>' .
			'<svg xmlns="http://www.w3.org/2000/svg" version="1.1" xmlns:cc="http://creativecommons.org/ns#" width="512" height="512" xmlns:xlink="http://www.w3.org/1999/xlink">' .
			'<rect x="0" y="0" rx="100" ry="100" width="512" height="512" style="fill:' . $color . ';" />' .
			'</svg>';
		// resize svg magic as this seems broken in Imagemagick
		if($mime === "image/svg+xml" || substr($appIconContent, 0, 4) === "<svg") {
			if(substr($appIconContent, 0, 5) !== "<?xml") {
				$svg = "<?xml version=\"1.0\"?>".$appIconContent;
			} else {
				$svg = $appIconContent;
			}
			$tmp = new Imagick();
			$tmp->readImageBlob($svg);
			$x = $tmp->getImageWidth();
			$y = $tmp->getImageHeight();
			$res = $tmp->getImageResolution();
			$tmp->destroy();

			if($x>$y) {
				$max = $x;
			} else {
				$max = $y;
			}

			// convert svg to resized image
			$appIconFile = new Imagick();
			$resX = (int)(512 * $res['x'] / $max * 2.53);
			$resY = (int)(512 * $res['y'] / $max * 2.53);
			$appIconFile->setResolution($resX, $resY);
			$appIconFile->setBackgroundColor(new ImagickPixel('transparent'));
			$appIconFile->readImageBlob($svg);

			/**
			 * invert app icons for bright primary colors
			 * the default nextcloud logo will not be inverted to black
			 */
			if ($this->util->invertTextColor($color)
				&& !$appIcon instanceof ISimpleFile
				&& $app !== "core"
			) {
				$appIconFile->negateImage(false);
			}
			$appIconFile->scaleImage(512, 512, true);
		} else {
			$appIconFile = new Imagick();
			$appIconFile->setBackgroundColor(new ImagickPixel('transparent'));
			$appIconFile->readImageBlob($appIconContent);
			$appIconFile->scaleImage(512, 512, true);
		}
		// offset for icon positioning
		$border_w = (int)($appIconFile->getImageWidth() * 0.05);
		$border_h = (int)($appIconFile->getImageHeight() * 0.05);
		$innerWidth = (int)($appIconFile->getImageWidth() - $border_w * 2);
		$innerHeight = (int)($appIconFile->getImageHeight() - $border_h * 2);
		$appIconFile->adaptiveResizeImage($innerWidth, $innerHeight);
		// center icon
		$offset_w = 512 / 2 - $innerWidth / 2;
		$offset_h = 512 / 2 - $innerHeight / 2;

		$finalIconFile = new Imagick();
		$finalIconFile->setBackgroundColor(new ImagickPixel('transparent'));
		$finalIconFile->readImageBlob($background);
		$finalIconFile->setImageVirtualPixelMethod(Imagick::VIRTUALPIXELMETHOD_TRANSPARENT);
		$finalIconFile->setImageArtifact('compose:args', "1,0,-0.5,0.5");
		$finalIconFile->compositeImage($appIconFile, Imagick::COMPOSITE_ATOP, $offset_w, $offset_h);
		$finalIconFile->setImageFormat('png24');
		if (defined("Imagick::INTERPOLATE_BICUBIC") === true) {
			$filter = Imagick::INTERPOLATE_BICUBIC;
		} else {
			$filter = Imagick::FILTER_LANCZOS;
		}
		$finalIconFile->resizeImage($size, $size, $filter, 1, false);

		$appIconFile->destroy();
		return $finalIconFile;
	}

	public function colorSvg($app, $image) {
		try {
			$imageFile = $this->util->getAppImage($app, $image);
		} catch (AppPathNotFoundException $e) {
			return false;
		}
		$svg = file_get_contents($imageFile);
		if ($svg !== false && $svg !== "") {
			$color = $this->util->elementColor($this->themingDefaults->getColorPrimary());
			$svg = $this->util->colorizeSvg($svg, $color);
			return $svg;
		} else {
			return false;
		}
	}

}


1			<?php
2			/**
3			* @copyright Copyright (c) 2016 Julius Härtl <[email protected]>
4			*
5			* @author Jan-Christoph Borchardt <[email protected]>
6			* @author Julius Haertl <[email protected]>
7			* @author Julius Härtl <[email protected]>
8			*
9			* @license GNU AGPL version 3 or any later version
10			*
11			* This program is free software: you can redistribute it and/or modify
12			* it under the terms of the GNU Affero General Public License as
13			* published by the Free Software Foundation, either version 3 of the
14			* License, or (at your option) any later version.
15			*
16			* This program is distributed in the hope that it will be useful,
17			* but WITHOUT ANY WARRANTY; without even the implied warranty of
18			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
19			* GNU Affero General Public License for more details.
20			*
21			* You should have received a copy of the GNU Affero General Public License
22			* along with this program. If not, see <http://www.gnu.org/licenses/>.
23			*
24			*/
25
26			namespace OCA\Theming;
27
28			use Imagick;
29			use ImagickPixel;
30			use OCP\App\AppPathNotFoundException;
31			use OCP\Files\SimpleFS\ISimpleFile;
32
33			class IconBuilder {
34			/** @var ThemingDefaults */
35			private $themingDefaults;
36			/** @var Util */
37			private $util;
38
39			/**
40			* IconBuilder constructor.
41			*
42			* @param ThemingDefaults $themingDefaults
43			* @param Util $util
44			*/
45			public function __construct(
46			ThemingDefaults $themingDefaults,
47			Util $util
48			) {
49			$this->themingDefaults = $themingDefaults;
50			$this->util = $util;
51			}
52
53			/**
54			* @param $app string app name
55			* @return string\|false image blob
56			*/
57			public function getFavicon($app) {
58			if (!$this->themingDefaults->shouldReplaceIcons()) {
59			return false;
60			}
61			try {
62			$favicon = new Imagick();
63			$favicon->setFormat("ico");
64			$icon = $this->renderAppIcon($app, 128);
65			if ($icon === false) {
66			return false;
67			}
68			$icon->setImageFormat("png32");
69
70			$clone = clone $icon;
71			$clone->scaleImage(16,0);
72			$favicon->addImage($clone);
73
74			$clone = clone $icon;
75			$clone->scaleImage(32,0);
76			$favicon->addImage($clone);
77
78			$clone = clone $icon;
79			$clone->scaleImage(64,0);
80			$favicon->addImage($clone);
81
82			$clone = clone $icon;
83			$clone->scaleImage(128,0);
84			$favicon->addImage($clone);
85
86			$data = $favicon->getImagesBlob();
87			$favicon->destroy();
88			$icon->destroy();
89			$clone->destroy();
90			return $data;
91			} catch (\ImagickException $e) {
92			return false;
93			}
94			}
95
96			/**
97			* @param $app string app name
98			* @return string\|false image blob
99			*/
100			public function getTouchIcon($app) {
101			try {
102			$icon = $this->renderAppIcon($app, 512);
103			if ($icon === false) {
104			return false;
105			}
106			$icon->setImageFormat("png32");
107			$data = $icon->getImageBlob();
108			$icon->destroy();
109			return $data;
110			} catch (\ImagickException $e) {
111			return false;
112			}
113			}
114
115			/**
116			* Render app icon on themed background color
117			* fallback to logo
118			*
119			* @param $app string app name
120			* @param $size int size of the icon in px
121			* @return Imagick\|false
122			*/
123			public function renderAppIcon($app, $size) {
124			$appIcon = $this->util->getAppIcon($app);
125			if($appIcon === false) {
126			return false;
127			}
128			if ($appIcon instanceof ISimpleFile) {
129			$appIconContent = $appIcon->getContent();
130			$mime = $appIcon->getMimeType();
131			} else {
132			$appIconContent = file_get_contents($appIcon);
133			$mime = mime_content_type($appIcon);
134			}
135
136			if($appIconContent === false \|\| $appIconContent === "") {
137			return false;
138			}
139
140			$color = $this->themingDefaults->getColorPrimary();
141
142			// generate background image with rounded corners
143			$background = '<?xml version="1.0" encoding="UTF-8"?>' .
144			'<svg xmlns="http://www.w3.org/2000/svg" version="1.1" xmlns:cc="http://creativecommons.org/ns#" width="512" height="512" xmlns:xlink="http://www.w3.org/1999/xlink">' .
145			'<rect x="0" y="0" rx="100" ry="100" width="512" height="512" style="fill:' . $color . ';" />' .
146			'</svg>';
147			// resize svg magic as this seems broken in Imagemagick
148			if($mime === "image/svg+xml" \|\| substr($appIconContent, 0, 4) === "<svg") {
149			if(substr($appIconContent, 0, 5) !== "<?xml") {
150			$svg = "<?xml version=\"1.0\"?>".$appIconContent;
151			} else {
152			$svg = $appIconContent;
153			}
154			$tmp = new Imagick();
155			$tmp->readImageBlob($svg);
156			$x = $tmp->getImageWidth();
157			$y = $tmp->getImageHeight();
158			$res = $tmp->getImageResolution();
159			$tmp->destroy();
160
161			if($x>$y) {
162			$max = $x;
163			} else {
164			$max = $y;
165			}
166
167			// convert svg to resized image
168			$appIconFile = new Imagick();
169			$resX = (int)(512 * $res['x'] / $max * 2.53);
170			$resY = (int)(512 * $res['y'] / $max * 2.53);
171			$appIconFile->setResolution($resX, $resY);
172			$appIconFile->setBackgroundColor(new ImagickPixel('transparent'));
173			$appIconFile->readImageBlob($svg);
174
175			/**
176			* invert app icons for bright primary colors
177			* the default nextcloud logo will not be inverted to black
178			*/
179			if ($this->util->invertTextColor($color)
180			&& !$appIcon instanceof ISimpleFile
181			&& $app !== "core"
182			) {
183			$appIconFile->negateImage(false);
184			}
185			$appIconFile->scaleImage(512, 512, true);
186			} else {
187			$appIconFile = new Imagick();
188			$appIconFile->setBackgroundColor(new ImagickPixel('transparent'));
189			$appIconFile->readImageBlob($appIconContent);
190			$appIconFile->scaleImage(512, 512, true);
191			}
192			// offset for icon positioning
193			$border_w = (int)($appIconFile->getImageWidth() * 0.05);
194			$border_h = (int)($appIconFile->getImageHeight() * 0.05);
195			$innerWidth = (int)($appIconFile->getImageWidth() - $border_w * 2);
196			$innerHeight = (int)($appIconFile->getImageHeight() - $border_h * 2);
197			$appIconFile->adaptiveResizeImage($innerWidth, $innerHeight);
198			// center icon
199			$offset_w = 512 / 2 - $innerWidth / 2;
200			$offset_h = 512 / 2 - $innerHeight / 2;
201
202			$finalIconFile = new Imagick();
203			$finalIconFile->setBackgroundColor(new ImagickPixel('transparent'));
204			$finalIconFile->readImageBlob($background);
205			$finalIconFile->setImageVirtualPixelMethod(Imagick::VIRTUALPIXELMETHOD_TRANSPARENT);
206			$finalIconFile->setImageArtifact('compose:args', "1,0,-0.5,0.5");
207			$finalIconFile->compositeImage($appIconFile, Imagick::COMPOSITE_ATOP, $offset_w, $offset_h);
208			$finalIconFile->setImageFormat('png24');
209			if (defined("Imagick::INTERPOLATE_BICUBIC") === true) {
210			$filter = Imagick::INTERPOLATE_BICUBIC;
211			} else {
212			$filter = Imagick::FILTER_LANCZOS;
213			}
214			$finalIconFile->resizeImage($size, $size, $filter, 1, false);
215
216			$appIconFile->destroy();
217			return $finalIconFile;
218			}
219
220			public function colorSvg($app, $image) {
221			try {
222			$imageFile = $this->util->getAppImage($app, $image);
223			} catch (AppPathNotFoundException $e) {
224			return false;
225			}
226			$svg = file_get_contents($imageFile);
227			if ($svg !== false && $svg !== "") {
228			$color = $this->util->elementColor($this->themingDefaults->getColorPrimary());
229			$svg = $this->util->colorizeSvg($svg, $color);
230			return $svg;
231			} else {
232			return false;
233			}
234			}
235
236			}
237

nextcloud / server

Push — master ( ed37dc...26bcf4 )

IconBuilder::renderAppIcon() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like