nextcloud / server

apps/dav/lib/Comments/CommentsPlugin.php

Spacing +7 added lines, -7 removed lines

@@ -91,7 +91,7 @@ 
 
 		$this->server->xml->namespaceMap[self::NS_OWNCLOUD] = 'oc';
 
-		$this->server->xml->classMap['DateTime'] = function (Writer $writer, \DateTime $value) {
+		$this->server->xml->classMap['DateTime'] = function(Writer $writer, \DateTime $value) {
 			$writer->write(\Sabre\HTTP\toDate($value));
 		};
 
@@ -125,7 +125,7 @@ 
 		// having their own comments marked as unread
 		$node->setReadMarker(null);
 
-		$url = rtrim($request->getUrl(), '/') . '/' . urlencode($comment->getId());
+		$url = rtrim($request->getUrl(), '/').'/'.urlencode($comment->getId());
 
 		$response->setHeader('Content-Location', $url);
 
@@ -167,7 +167,7 @@ 
 			$this::REPORT_PARAM_OFFSET,
 			$this::REPORT_PARAM_TIMESTAMP
 		];
-		$ns = '{' . $this::NS_OWNCLOUD . '}';
+		$ns = '{'.$this::NS_OWNCLOUD.'}';
 		foreach ($report as $parameter) {
 			if (!in_array($parameter['name'], $acceptableParameters) || empty($parameter['value'])) {
 				continue;
@@ -183,11 +183,11 @@ 
 
 		$responses = [];
 		foreach ($results as $node) {
-			$nodePath = $this->server->getRequestUri() . '/' . $node->comment->getId();
+			$nodePath = $this->server->getRequestUri().'/'.$node->comment->getId();
 			$resultSet = $this->server->getPropertiesForPath($nodePath, CommentNode::getPropertyNames());
 			if (isset($resultSet[0]) && isset($resultSet[0][200])) {
 				$responses[] = new Response(
-					$this->server->getBaseUri() . $nodePath,
+					$this->server->getBaseUri().$nodePath,
 					[200 => $resultSet[0][200]],
 					200
 				);
@@ -234,7 +234,7 @@ 
 			}
 		}
 		if (is_null($actorId)) {
-			throw new BadRequest('Invalid actor "' .  $actorType .'"');
+			throw new BadRequest('Invalid actor "'.$actorType.'"');
 		}
 
 		try {
@@ -247,7 +247,7 @@ 
 			throw new BadRequest('Invalid input values', 0, $e);
 		} catch (\OCP\Comments\MessageTooLongException $e) {
 			$msg = 'Message exceeds allowed character limit of ';
-			throw new BadRequest($msg . \OCP\Comments\IComment::MAX_MESSAGE_LENGTH, 0,	$e);
+			throw new BadRequest($msg.\OCP\Comments\IComment::MAX_MESSAGE_LENGTH, 0, $e);
 		}
 	}
 }

Indentation +206 added lines, -206 removed lines

@@ -44,210 +44,210 @@
  * Sabre plugin to handle comments:
  */
 class CommentsPlugin extends ServerPlugin {
-	// namespace
-	public const NS_OWNCLOUD = 'http://owncloud.org/ns';
-
-	public const REPORT_NAME = '{http://owncloud.org/ns}filter-comments';
-	public const REPORT_PARAM_LIMIT = '{http://owncloud.org/ns}limit';
-	public const REPORT_PARAM_OFFSET = '{http://owncloud.org/ns}offset';
-	public const REPORT_PARAM_TIMESTAMP = '{http://owncloud.org/ns}datetime';
-
-	/** @var ICommentsManager  */
-	protected $commentsManager;
-
-	/** @var \Sabre\DAV\Server $server */
-	private $server;
-
-	/** @var  \OCP\IUserSession */
-	protected $userSession;
-
-	/**
-	 * Comments plugin
-	 *
-	 * @param ICommentsManager $commentsManager
-	 * @param IUserSession $userSession
-	 */
-	public function __construct(ICommentsManager $commentsManager, IUserSession $userSession) {
-		$this->commentsManager = $commentsManager;
-		$this->userSession = $userSession;
-	}
-
-	/**
-	 * This initializes the plugin.
-	 *
-	 * This function is called by Sabre\DAV\Server, after
-	 * addPlugin is called.
-	 *
-	 * This method should set up the required event subscriptions.
-	 *
-	 * @param Server $server
-	 * @return void
-	 */
-	public function initialize(Server $server) {
-		$this->server = $server;
-		if (strpos($this->server->getRequestUri(), 'comments/') !== 0) {
-			return;
-		}
-
-		$this->server->xml->namespaceMap[self::NS_OWNCLOUD] = 'oc';
-
-		$this->server->xml->classMap['DateTime'] = function (Writer $writer, \DateTime $value) {
-			$writer->write(\Sabre\HTTP\toDate($value));
-		};
-
-		$this->server->on('report', [$this, 'onReport']);
-		$this->server->on('method:POST', [$this, 'httpPost']);
-	}
-
-	/**
-	 * POST operation on Comments collections
-	 *
-	 * @param RequestInterface $request request object
-	 * @param ResponseInterface $response response object
-	 * @return null|false
-	 */
-	public function httpPost(RequestInterface $request, ResponseInterface $response) {
-		$path = $request->getPath();
-		$node = $this->server->tree->getNodeForPath($path);
-		if (!$node instanceof EntityCollection) {
-			return null;
-		}
-
-		$data = $request->getBodyAsString();
-		$comment = $this->createComment(
-			$node->getName(),
-			$node->getId(),
-			$data,
-			$request->getHeader('Content-Type')
-		);
-
-		// update read marker for the current user/poster to avoid
-		// having their own comments marked as unread
-		$node->setReadMarker(null);
-
-		$url = rtrim($request->getUrl(), '/') . '/' . urlencode($comment->getId());
-
-		$response->setHeader('Content-Location', $url);
-
-		// created
-		$response->setStatus(201);
-		return false;
-	}
-
-	/**
-	 * Returns a list of reports this plugin supports.
-	 *
-	 * This will be used in the {DAV:}supported-report-set property.
-	 *
-	 * @param string $uri
-	 * @return array
-	 */
-	public function getSupportedReportSet($uri) {
-		return [self::REPORT_NAME];
-	}
-
-	/**
-	 * REPORT operations to look for comments
-	 *
-	 * @param string $reportName
-	 * @param array $report
-	 * @param string $uri
-	 * @return bool
-	 * @throws NotFound
-	 * @throws ReportNotSupported
-	 */
-	public function onReport($reportName, $report, $uri) {
-		$node = $this->server->tree->getNodeForPath($uri);
-		if (!$node instanceof EntityCollection || $reportName !== self::REPORT_NAME) {
-			throw new ReportNotSupported();
-		}
-		$args = ['limit' => 0, 'offset' => 0, 'datetime' => null];
-		$acceptableParameters = [
-			$this::REPORT_PARAM_LIMIT,
-			$this::REPORT_PARAM_OFFSET,
-			$this::REPORT_PARAM_TIMESTAMP
-		];
-		$ns = '{' . $this::NS_OWNCLOUD . '}';
-		foreach ($report as $parameter) {
-			if (!in_array($parameter['name'], $acceptableParameters) || empty($parameter['value'])) {
-				continue;
-			}
-			$args[str_replace($ns, '', $parameter['name'])] = $parameter['value'];
-		}
-
-		if (!is_null($args['datetime'])) {
-			$args['datetime'] = new \DateTime($args['datetime']);
-		}
-
-		$results = $node->findChildren($args['limit'], $args['offset'], $args['datetime']);
-
-		$responses = [];
-		foreach ($results as $node) {
-			$nodePath = $this->server->getRequestUri() . '/' . $node->comment->getId();
-			$resultSet = $this->server->getPropertiesForPath($nodePath, CommentNode::getPropertyNames());
-			if (isset($resultSet[0]) && isset($resultSet[0][200])) {
-				$responses[] = new Response(
-					$this->server->getBaseUri() . $nodePath,
-					[200 => $resultSet[0][200]],
-					200
-				);
-			}
-		}
-
-		$xml = $this->server->xml->write(
-			'{DAV:}multistatus',
-			new MultiStatus($responses)
-		);
-
-		$this->server->httpResponse->setStatus(207);
-		$this->server->httpResponse->setHeader('Content-Type', 'application/xml; charset=utf-8');
-		$this->server->httpResponse->setBody($xml);
-
-		return false;
-	}
-
-	/**
-	 * Creates a new comment
-	 *
-	 * @param string $objectType e.g. "files"
-	 * @param string $objectId e.g. the file id
-	 * @param string $data JSON encoded string containing the properties of the tag to create
-	 * @param string $contentType content type of the data
-	 * @return IComment newly created comment
-	 *
-	 * @throws BadRequest if a field was missing
-	 * @throws UnsupportedMediaType if the content type is not supported
-	 */
-	private function createComment($objectType, $objectId, $data, $contentType = 'application/json') {
-		if (explode(';', $contentType)[0] === 'application/json') {
-			$data = json_decode($data, true, 512, JSON_THROW_ON_ERROR);
-		} else {
-			throw new UnsupportedMediaType();
-		}
-
-		$actorType = $data['actorType'];
-		$actorId = null;
-		if ($actorType === 'users') {
-			$user = $this->userSession->getUser();
-			if (!is_null($user)) {
-				$actorId = $user->getUID();
-			}
-		}
-		if (is_null($actorId)) {
-			throw new BadRequest('Invalid actor "' .  $actorType .'"');
-		}
-
-		try {
-			$comment = $this->commentsManager->create($actorType, $actorId, $objectType, $objectId);
-			$comment->setMessage($data['message']);
-			$comment->setVerb($data['verb']);
-			$this->commentsManager->save($comment);
-			return $comment;
-		} catch (\InvalidArgumentException $e) {
-			throw new BadRequest('Invalid input values', 0, $e);
-		} catch (\OCP\Comments\MessageTooLongException $e) {
-			$msg = 'Message exceeds allowed character limit of ';
-			throw new BadRequest($msg . \OCP\Comments\IComment::MAX_MESSAGE_LENGTH, 0,	$e);
-		}
-	}
+    // namespace
+    public const NS_OWNCLOUD = 'http://owncloud.org/ns';
+
+    public const REPORT_NAME = '{http://owncloud.org/ns}filter-comments';
+    public const REPORT_PARAM_LIMIT = '{http://owncloud.org/ns}limit';
+    public const REPORT_PARAM_OFFSET = '{http://owncloud.org/ns}offset';
+    public const REPORT_PARAM_TIMESTAMP = '{http://owncloud.org/ns}datetime';
+
+    /** @var ICommentsManager  */
+    protected $commentsManager;
+
+    /** @var \Sabre\DAV\Server $server */
+    private $server;
+
+    /** @var  \OCP\IUserSession */
+    protected $userSession;
+
+    /**
+     * Comments plugin
+     *
+     * @param ICommentsManager $commentsManager
+     * @param IUserSession $userSession
+     */
+    public function __construct(ICommentsManager $commentsManager, IUserSession $userSession) {
+        $this->commentsManager = $commentsManager;
+        $this->userSession = $userSession;
+    }
+
+    /**
+     * This initializes the plugin.
+     *
+     * This function is called by Sabre\DAV\Server, after
+     * addPlugin is called.
+     *
+     * This method should set up the required event subscriptions.
+     *
+     * @param Server $server
+     * @return void
+     */
+    public function initialize(Server $server) {
+        $this->server = $server;
+        if (strpos($this->server->getRequestUri(), 'comments/') !== 0) {
+            return;
+        }
+
+        $this->server->xml->namespaceMap[self::NS_OWNCLOUD] = 'oc';
+
+        $this->server->xml->classMap['DateTime'] = function (Writer $writer, \DateTime $value) {
+            $writer->write(\Sabre\HTTP\toDate($value));
+        };
+
+        $this->server->on('report', [$this, 'onReport']);
+        $this->server->on('method:POST', [$this, 'httpPost']);
+    }
+
+    /**
+     * POST operation on Comments collections
+     *
+     * @param RequestInterface $request request object
+     * @param ResponseInterface $response response object
+     * @return null|false
+     */
+    public function httpPost(RequestInterface $request, ResponseInterface $response) {
+        $path = $request->getPath();
+        $node = $this->server->tree->getNodeForPath($path);
+        if (!$node instanceof EntityCollection) {
+            return null;
+        }
+
+        $data = $request->getBodyAsString();
+        $comment = $this->createComment(
+            $node->getName(),
+            $node->getId(),
+            $data,
+            $request->getHeader('Content-Type')
+        );
+
+        // update read marker for the current user/poster to avoid
+        // having their own comments marked as unread
+        $node->setReadMarker(null);
+
+        $url = rtrim($request->getUrl(), '/') . '/' . urlencode($comment->getId());
+
+        $response->setHeader('Content-Location', $url);
+
+        // created
+        $response->setStatus(201);
+        return false;
+    }
+
+    /**
+     * Returns a list of reports this plugin supports.
+     *
+     * This will be used in the {DAV:}supported-report-set property.
+     *
+     * @param string $uri
+     * @return array
+     */
+    public function getSupportedReportSet($uri) {
+        return [self::REPORT_NAME];
+    }
+
+    /**
+     * REPORT operations to look for comments
+     *
+     * @param string $reportName
+     * @param array $report
+     * @param string $uri
+     * @return bool
+     * @throws NotFound
+     * @throws ReportNotSupported
+     */
+    public function onReport($reportName, $report, $uri) {
+        $node = $this->server->tree->getNodeForPath($uri);
+        if (!$node instanceof EntityCollection || $reportName !== self::REPORT_NAME) {
+            throw new ReportNotSupported();
+        }
+        $args = ['limit' => 0, 'offset' => 0, 'datetime' => null];
+        $acceptableParameters = [
+            $this::REPORT_PARAM_LIMIT,
+            $this::REPORT_PARAM_OFFSET,
+            $this::REPORT_PARAM_TIMESTAMP
+        ];
+        $ns = '{' . $this::NS_OWNCLOUD . '}';
+        foreach ($report as $parameter) {
+            if (!in_array($parameter['name'], $acceptableParameters) || empty($parameter['value'])) {
+                continue;
+            }
+            $args[str_replace($ns, '', $parameter['name'])] = $parameter['value'];
+        }
+
+        if (!is_null($args['datetime'])) {
+            $args['datetime'] = new \DateTime($args['datetime']);
+        }
+
+        $results = $node->findChildren($args['limit'], $args['offset'], $args['datetime']);
+
+        $responses = [];
+        foreach ($results as $node) {
+            $nodePath = $this->server->getRequestUri() . '/' . $node->comment->getId();
+            $resultSet = $this->server->getPropertiesForPath($nodePath, CommentNode::getPropertyNames());
+            if (isset($resultSet[0]) && isset($resultSet[0][200])) {
+                $responses[] = new Response(
+                    $this->server->getBaseUri() . $nodePath,
+                    [200 => $resultSet[0][200]],
+                    200
+                );
+            }
+        }
+
+        $xml = $this->server->xml->write(
+            '{DAV:}multistatus',
+            new MultiStatus($responses)
+        );
+
+        $this->server->httpResponse->setStatus(207);
+        $this->server->httpResponse->setHeader('Content-Type', 'application/xml; charset=utf-8');
+        $this->server->httpResponse->setBody($xml);
+
+        return false;
+    }
+
+    /**
+     * Creates a new comment
+     *
+     * @param string $objectType e.g. "files"
+     * @param string $objectId e.g. the file id
+     * @param string $data JSON encoded string containing the properties of the tag to create
+     * @param string $contentType content type of the data
+     * @return IComment newly created comment
+     *
+     * @throws BadRequest if a field was missing
+     * @throws UnsupportedMediaType if the content type is not supported
+     */
+    private function createComment($objectType, $objectId, $data, $contentType = 'application/json') {
+        if (explode(';', $contentType)[0] === 'application/json') {
+            $data = json_decode($data, true, 512, JSON_THROW_ON_ERROR);
+        } else {
+            throw new UnsupportedMediaType();
+        }
+
+        $actorType = $data['actorType'];
+        $actorId = null;
+        if ($actorType === 'users') {
+            $user = $this->userSession->getUser();
+            if (!is_null($user)) {
+                $actorId = $user->getUID();
+            }
+        }
+        if (is_null($actorId)) {
+            throw new BadRequest('Invalid actor "' .  $actorType .'"');
+        }
+
+        try {
+            $comment = $this->commentsManager->create($actorType, $actorId, $objectType, $objectId);
+            $comment->setMessage($data['message']);
+            $comment->setVerb($data['verb']);
+            $this->commentsManager->save($comment);
+            return $comment;
+        } catch (\InvalidArgumentException $e) {
+            throw new BadRequest('Invalid input values', 0, $e);
+        } catch (\OCP\Comments\MessageTooLongException $e) {
+            $msg = 'Message exceeds allowed character limit of ';
+            throw new BadRequest($msg . \OCP\Comments\IComment::MAX_MESSAGE_LENGTH, 0,	$e);
+        }
+    }
 }

apps/dav/lib/Files/BrowserErrorPagePlugin.php

Spacing +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
 
 		$templateName = 'exception';
 		if ($httpCode === 403 || $httpCode === 404) {
-			$templateName = (string)$httpCode;
+			$templateName = (string) $httpCode;
 		}
 
 		$content = new OC_Template('core', $templateName, 'guest');

Indentation +75 added lines, -75 removed lines

@@ -34,86 +34,86 @@
 use Sabre\DAV\ServerPlugin;
 
 class BrowserErrorPagePlugin extends ServerPlugin {
-	/** @var Server */
-	private $server;
+    /** @var Server */
+    private $server;
 
-	/**
-	 * This initializes the plugin.
-	 *
-	 * This function is called by Sabre\DAV\Server, after
-	 * addPlugin is called.
-	 *
-	 * This method should set up the required event subscriptions.
-	 *
-	 * @param Server $server
-	 * @return void
-	 */
-	public function initialize(Server $server) {
-		$this->server = $server;
-		$server->on('exception', [$this, 'logException'], 1000);
-	}
+    /**
+     * This initializes the plugin.
+     *
+     * This function is called by Sabre\DAV\Server, after
+     * addPlugin is called.
+     *
+     * This method should set up the required event subscriptions.
+     *
+     * @param Server $server
+     * @return void
+     */
+    public function initialize(Server $server) {
+        $this->server = $server;
+        $server->on('exception', [$this, 'logException'], 1000);
+    }
 
-	/**
-	 * @param IRequest $request
-	 * @return bool
-	 */
-	public static function isBrowserRequest(IRequest $request) {
-		if ($request->getMethod() !== 'GET') {
-			return false;
-		}
-		return $request->isUserAgent([
-			Request::USER_AGENT_IE,
-			Request::USER_AGENT_MS_EDGE,
-			Request::USER_AGENT_CHROME,
-			Request::USER_AGENT_FIREFOX,
-			Request::USER_AGENT_SAFARI,
-		]);
-	}
+    /**
+     * @param IRequest $request
+     * @return bool
+     */
+    public static function isBrowserRequest(IRequest $request) {
+        if ($request->getMethod() !== 'GET') {
+            return false;
+        }
+        return $request->isUserAgent([
+            Request::USER_AGENT_IE,
+            Request::USER_AGENT_MS_EDGE,
+            Request::USER_AGENT_CHROME,
+            Request::USER_AGENT_FIREFOX,
+            Request::USER_AGENT_SAFARI,
+        ]);
+    }
 
-	/**
-	 * @param \Exception $ex
-	 */
-	public function logException(\Exception $ex) {
-		if ($ex instanceof Exception) {
-			$httpCode = $ex->getHTTPCode();
-			$headers = $ex->getHTTPHeaders($this->server);
-		} else {
-			$httpCode = 500;
-			$headers = [];
-		}
-		$this->server->httpResponse->addHeaders($headers);
-		$this->server->httpResponse->setStatus($httpCode);
-		$body = $this->generateBody($httpCode);
-		$this->server->httpResponse->setBody($body);
-		$csp = new ContentSecurityPolicy();
-		$this->server->httpResponse->addHeader('Content-Security-Policy', $csp->buildPolicy());
-		$this->sendResponse();
-	}
+    /**
+     * @param \Exception $ex
+     */
+    public function logException(\Exception $ex) {
+        if ($ex instanceof Exception) {
+            $httpCode = $ex->getHTTPCode();
+            $headers = $ex->getHTTPHeaders($this->server);
+        } else {
+            $httpCode = 500;
+            $headers = [];
+        }
+        $this->server->httpResponse->addHeaders($headers);
+        $this->server->httpResponse->setStatus($httpCode);
+        $body = $this->generateBody($httpCode);
+        $this->server->httpResponse->setBody($body);
+        $csp = new ContentSecurityPolicy();
+        $this->server->httpResponse->addHeader('Content-Security-Policy', $csp->buildPolicy());
+        $this->sendResponse();
+    }
 
-	/**
-	 * @codeCoverageIgnore
-	 * @return bool|string
-	 */
-	public function generateBody(int $httpCode) {
-		$request = \OC::$server->getRequest();
+    /**
+     * @codeCoverageIgnore
+     * @return bool|string
+     */
+    public function generateBody(int $httpCode) {
+        $request = \OC::$server->getRequest();
 
-		$templateName = 'exception';
-		if ($httpCode === 403 || $httpCode === 404) {
-			$templateName = (string)$httpCode;
-		}
+        $templateName = 'exception';
+        if ($httpCode === 403 || $httpCode === 404) {
+            $templateName = (string)$httpCode;
+        }
 
-		$content = new OC_Template('core', $templateName, 'guest');
-		$content->assign('title', $this->server->httpResponse->getStatusText());
-		$content->assign('remoteAddr', $request->getRemoteAddress());
-		$content->assign('requestID', $request->getId());
-		return $content->fetchPage();
-	}
+        $content = new OC_Template('core', $templateName, 'guest');
+        $content->assign('title', $this->server->httpResponse->getStatusText());
+        $content->assign('remoteAddr', $request->getRemoteAddress());
+        $content->assign('requestID', $request->getId());
+        return $content->fetchPage();
+    }
 
-	/**
-	 * @codeCoverageIgnore
-	 */
-	public function sendResponse() {
-		$this->server->sapi->sendResponse($this->server->httpResponse);
-		exit();
-	}
+    /**
+     * @codeCoverageIgnore
+     */
+    public function sendResponse() {
+        $this->server->sapi->sendResponse($this->server->httpResponse);
+        exit();
+    }
 }

apps/dav/lib/Migration/RefreshWebcalJobRegistrar.php

Indentation +41 added lines, -41 removed lines

@@ -34,52 +34,52 @@
 
 class RefreshWebcalJobRegistrar implements IRepairStep {
 
-	/** @var IDBConnection */
-	private $connection;
+    /** @var IDBConnection */
+    private $connection;
 
-	/** @var IJobList */
-	private $jobList;
+    /** @var IJobList */
+    private $jobList;
 
-	/**
-	 * FixBirthdayCalendarComponent constructor.
-	 *
-	 * @param IDBConnection $connection
-	 * @param IJobList $jobList
-	 */
-	public function __construct(IDBConnection $connection, IJobList $jobList) {
-		$this->connection = $connection;
-		$this->jobList = $jobList;
-	}
+    /**
+     * FixBirthdayCalendarComponent constructor.
+     *
+     * @param IDBConnection $connection
+     * @param IJobList $jobList
+     */
+    public function __construct(IDBConnection $connection, IJobList $jobList) {
+        $this->connection = $connection;
+        $this->jobList = $jobList;
+    }
 
-	/**
-	 * @inheritdoc
-	 */
-	public function getName() {
-		return 'Registering background jobs to update cache for webcal calendars';
-	}
+    /**
+     * @inheritdoc
+     */
+    public function getName() {
+        return 'Registering background jobs to update cache for webcal calendars';
+    }
 
-	/**
-	 * @inheritdoc
-	 */
-	public function run(IOutput $output) {
-		$query = $this->connection->getQueryBuilder();
-		$query->select(['principaluri', 'uri'])
-			->from('calendarsubscriptions');
-		$stmt = $query->execute();
+    /**
+     * @inheritdoc
+     */
+    public function run(IOutput $output) {
+        $query = $this->connection->getQueryBuilder();
+        $query->select(['principaluri', 'uri'])
+            ->from('calendarsubscriptions');
+        $stmt = $query->execute();
 
-		$count = 0;
-		while ($row = $stmt->fetch(\PDO::FETCH_ASSOC)) {
-			$args = [
-				'principaluri' => $row['principaluri'],
-				'uri' => $row['uri'],
-			];
+        $count = 0;
+        while ($row = $stmt->fetch(\PDO::FETCH_ASSOC)) {
+            $args = [
+                'principaluri' => $row['principaluri'],
+                'uri' => $row['uri'],
+            ];
 
-			if (!$this->jobList->has(RefreshWebcalJob::class, $args)) {
-				$this->jobList->add(RefreshWebcalJob::class, $args);
-				$count++;
-			}
-		}
+            if (!$this->jobList->has(RefreshWebcalJob::class, $args)) {
+                $this->jobList->add(RefreshWebcalJob::class, $args);
+                $count++;
+            }
+        }
 
-		$output->info("Added $count background jobs to update webcal calendars");
-	}
+        $output->info("Added $count background jobs to update webcal calendars");
+    }
 }

apps/workflowengine/lib/Helper/ScopeContext.php

Indentation +41 added lines, -41 removed lines

@@ -28,51 +28,51 @@
 use OCP\WorkflowEngine\IManager;
 
 class ScopeContext {
-	/** @var int */
-	private $scope;
-	/** @var string */
-	private $scopeId;
-	/** @var string */
-	private $hash;
+    /** @var int */
+    private $scope;
+    /** @var string */
+    private $scopeId;
+    /** @var string */
+    private $hash;
 
-	public function __construct(int $scope, string $scopeId = null) {
-		$this->scope = $this->evaluateScope($scope);
-		$this->scopeId = $this->evaluateScopeId($scopeId);
-	}
+    public function __construct(int $scope, string $scopeId = null) {
+        $this->scope = $this->evaluateScope($scope);
+        $this->scopeId = $this->evaluateScopeId($scopeId);
+    }
 
-	private function evaluateScope(int $scope): int {
-		if (in_array($scope, [IManager::SCOPE_ADMIN, IManager::SCOPE_USER], true)) {
-			return $scope;
-		}
-		throw new \InvalidArgumentException('Invalid scope');
-	}
+    private function evaluateScope(int $scope): int {
+        if (in_array($scope, [IManager::SCOPE_ADMIN, IManager::SCOPE_USER], true)) {
+            return $scope;
+        }
+        throw new \InvalidArgumentException('Invalid scope');
+    }
 
-	private function evaluateScopeId(string $scopeId = null): string {
-		if ($this->scope === IManager::SCOPE_USER
-			&& trim((string)$scopeId) === '') {
-			throw new \InvalidArgumentException('user scope requires a user id');
-		}
-		return trim((string)$scopeId);
-	}
+    private function evaluateScopeId(string $scopeId = null): string {
+        if ($this->scope === IManager::SCOPE_USER
+            && trim((string)$scopeId) === '') {
+            throw new \InvalidArgumentException('user scope requires a user id');
+        }
+        return trim((string)$scopeId);
+    }
 
-	/**
-	 * @return int
-	 */
-	public function getScope(): int {
-		return $this->scope;
-	}
+    /**
+     * @return int
+     */
+    public function getScope(): int {
+        return $this->scope;
+    }
 
-	/**
-	 * @return string
-	 */
-	public function getScopeId(): string {
-		return $this->scopeId;
-	}
+    /**
+     * @return string
+     */
+    public function getScopeId(): string {
+        return $this->scopeId;
+    }
 
-	public function getHash(): string {
-		if ($this->hash === null) {
-			$this->hash = \hash('sha256', $this->getScope() . '::' . $this->getScopeId());
-		}
-		return $this->hash;
-	}
+    public function getHash(): string {
+        if ($this->hash === null) {
+            $this->hash = \hash('sha256', $this->getScope() . '::' . $this->getScopeId());
+        }
+        return $this->hash;
+    }
 }

Spacing +3 added lines, -3 removed lines

@@ -49,10 +49,10 @@ 
 
 	private function evaluateScopeId(string $scopeId = null): string {
 		if ($this->scope === IManager::SCOPE_USER
-			&& trim((string)$scopeId) === '') {
+			&& trim((string) $scopeId) === '') {
 			throw new \InvalidArgumentException('user scope requires a user id');
 		}
-		return trim((string)$scopeId);
+		return trim((string) $scopeId);
 	}
 
 	/**
@@ -71,7 +71,7 @@ 
 
 	public function getHash(): string {
 		if ($this->hash === null) {
-			$this->hash = \hash('sha256', $this->getScope() . '::' . $this->getScopeId());
+			$this->hash = \hash('sha256', $this->getScope().'::'.$this->getScopeId());
 		}
 		return $this->hash;
 	}

apps/workflowengine/lib/Helper/LogContext.php

Indentation +56 added lines, -56 removed lines

@@ -30,67 +30,67 @@
 use OCP\WorkflowEngine\IOperation;
 
 class LogContext {
-	/** @var array */
-	protected $details;
+    /** @var array */
+    protected $details;
 
-	public function setDescription(string $description): LogContext {
-		$this->details['message'] = $description;
-		return $this;
-	}
+    public function setDescription(string $description): LogContext {
+        $this->details['message'] = $description;
+        return $this;
+    }
 
-	public function setScopes(array $scopes): LogContext {
-		$this->details['scopes'] = [];
-		foreach ($scopes as $scope) {
-			if ($scope instanceof ScopeContext) {
-				switch ($scope->getScope()) {
-					case IManager::SCOPE_ADMIN:
-						$this->details['scopes'][] = ['scope' => 'admin'];
-						break;
-					case IManager::SCOPE_USER:
-						$this->details['scopes'][] = [
-							'scope' => 'user',
-							'uid' => $scope->getScopeId(),
-						];
-						break;
-					default:
-						continue 2;
-				}
-			}
-		}
-		return $this;
-	}
+    public function setScopes(array $scopes): LogContext {
+        $this->details['scopes'] = [];
+        foreach ($scopes as $scope) {
+            if ($scope instanceof ScopeContext) {
+                switch ($scope->getScope()) {
+                    case IManager::SCOPE_ADMIN:
+                        $this->details['scopes'][] = ['scope' => 'admin'];
+                        break;
+                    case IManager::SCOPE_USER:
+                        $this->details['scopes'][] = [
+                            'scope' => 'user',
+                            'uid' => $scope->getScopeId(),
+                        ];
+                        break;
+                    default:
+                        continue 2;
+                }
+            }
+        }
+        return $this;
+    }
 
-	public function setOperation(?IOperation $operation): LogContext {
-		if ($operation instanceof IOperation) {
-			$this->details['operation'] = [
-				'class' => get_class($operation),
-				'name' => $operation->getDisplayName(),
-			];
-		}
-		return $this;
-	}
+    public function setOperation(?IOperation $operation): LogContext {
+        if ($operation instanceof IOperation) {
+            $this->details['operation'] = [
+                'class' => get_class($operation),
+                'name' => $operation->getDisplayName(),
+            ];
+        }
+        return $this;
+    }
 
-	public function setEntity(?IEntity $entity): LogContext {
-		if ($entity instanceof IEntity) {
-			$this->details['entity'] = [
-				'class' => get_class($entity),
-				'name' => $entity->getName(),
-			];
-		}
-		return $this;
-	}
+    public function setEntity(?IEntity $entity): LogContext {
+        if ($entity instanceof IEntity) {
+            $this->details['entity'] = [
+                'class' => get_class($entity),
+                'name' => $entity->getName(),
+            ];
+        }
+        return $this;
+    }
 
-	public function setConfiguration(array $configuration): LogContext {
-		$this->details['configuration'] = $configuration;
-		return $this;
-	}
+    public function setConfiguration(array $configuration): LogContext {
+        $this->details['configuration'] = $configuration;
+        return $this;
+    }
 
-	public function setEventName(string $eventName): LogContext {
-		$this->details['eventName'] = $eventName;
-		return $this;
-	}
+    public function setEventName(string $eventName): LogContext {
+        $this->details['eventName'] = $eventName;
+        return $this;
+    }
 
-	public function getDetails(): array {
-		return $this->details;
-	}
+    public function getDetails(): array {
+        return $this->details;
+    }
 }

apps/workflowengine/lib/Controller/GlobalWorkflowsController.php

Indentation +8 added lines, -8 removed lines

@@ -30,13 +30,13 @@
 
 class GlobalWorkflowsController extends AWorkflowController {
 
-	/** @var ScopeContext */
-	private $scopeContext;
+    /** @var ScopeContext */
+    private $scopeContext;
 
-	protected function getScopeContext(): ScopeContext {
-		if ($this->scopeContext === null) {
-			$this->scopeContext = new ScopeContext(IManager::SCOPE_ADMIN);
-		}
-		return $this->scopeContext;
-	}
+    protected function getScopeContext(): ScopeContext {
+        if ($this->scopeContext === null) {
+            $this->scopeContext = new ScopeContext(IManager::SCOPE_ADMIN);
+        }
+        return $this->scopeContext;
+    }
 }

apps/files_sharing/lib/ShareBackend/Folder.php

Spacing +1 added lines, -1 removed lines

@@ -111,7 +111,7 @@
 		while (!empty($parents)) {
 			$qb = \OC::$server->getDatabaseConnection()->getQueryBuilder();
 
-			$parents = array_map(function ($parent) use ($qb) {
+			$parents = array_map(function($parent) use ($qb) {
 				return $qb->createNamedParameter($parent);
 			}, $parents);
 

Indentation +91 added lines, -91 removed lines

@@ -30,108 +30,108 @@
 
 class Folder extends File implements \OCP\Share_Backend_Collection {
 
-	/**
-	 * get shared parents
-	 *
-	 * @param int $itemSource item source ID
-	 * @param string $shareWith with whom should the item be shared
-	 * @param string $owner owner of the item
-	 * @return array with shares
-	 */
-	public function getParents($itemSource, $shareWith = null, $owner = null) {
-		$result = [];
-		$parent = $this->getParentId($itemSource);
+    /**
+     * get shared parents
+     *
+     * @param int $itemSource item source ID
+     * @param string $shareWith with whom should the item be shared
+     * @param string $owner owner of the item
+     * @return array with shares
+     */
+    public function getParents($itemSource, $shareWith = null, $owner = null) {
+        $result = [];
+        $parent = $this->getParentId($itemSource);
 
-		$userManager = \OC::$server->getUserManager();
+        $userManager = \OC::$server->getUserManager();
 
-		while ($parent) {
-			$shares = \OCP\Share::getItemSharedWithUser('folder', $parent, $shareWith, $owner);
-			if ($shares) {
-				foreach ($shares as $share) {
-					$name = basename($share['path']);
-					$share['collection']['path'] = $name;
-					$share['collection']['item_type'] = 'folder';
-					$share['file_path'] = $name;
+        while ($parent) {
+            $shares = \OCP\Share::getItemSharedWithUser('folder', $parent, $shareWith, $owner);
+            if ($shares) {
+                foreach ($shares as $share) {
+                    $name = basename($share['path']);
+                    $share['collection']['path'] = $name;
+                    $share['collection']['item_type'] = 'folder';
+                    $share['file_path'] = $name;
 
-					$ownerUser = $userManager->get($share['uid_owner']);
-					$displayNameOwner = $ownerUser === null ? $share['uid_owner'] : $ownerUser->getDisplayName();
-					$shareWithUser = $userManager->get($share['share_with']);
-					$displayNameShareWith = $shareWithUser === null ? $share['share_with'] : $shareWithUser->getDisplayName();
-					$share['displayname_owner'] = $displayNameOwner ? $displayNameOwner : $share['uid_owner'];
-					$share['share_with_displayname'] = $displayNameShareWith ? $displayNameShareWith : $share['uid_owner'];
+                    $ownerUser = $userManager->get($share['uid_owner']);
+                    $displayNameOwner = $ownerUser === null ? $share['uid_owner'] : $ownerUser->getDisplayName();
+                    $shareWithUser = $userManager->get($share['share_with']);
+                    $displayNameShareWith = $shareWithUser === null ? $share['share_with'] : $shareWithUser->getDisplayName();
+                    $share['displayname_owner'] = $displayNameOwner ? $displayNameOwner : $share['uid_owner'];
+                    $share['share_with_displayname'] = $displayNameShareWith ? $displayNameShareWith : $share['uid_owner'];
 
-					$result[] = $share;
-				}
-			}
-			$parent = $this->getParentId($parent);
-		}
+                    $result[] = $share;
+                }
+            }
+            $parent = $this->getParentId($parent);
+        }
 
-		return $result;
-	}
+        return $result;
+    }
 
-	/**
-	 * get file cache ID of parent
-	 *
-	 * @param int $child file cache ID of child
-	 * @return mixed parent ID or null
-	 */
-	private function getParentId($child) {
-		$qb = \OC::$server->getDatabaseConnection()->getQueryBuilder();
-		$qb->select('parent')
-			->from('filecache')
-			->where(
-				$qb->expr()->eq('fileid', $qb->createNamedParameter($child))
-			);
-		$result = $qb->execute();
-		$row = $result->fetch();
-		$result->closeCursor();
-		return $row ? $row['parent'] : null;
-	}
+    /**
+     * get file cache ID of parent
+     *
+     * @param int $child file cache ID of child
+     * @return mixed parent ID or null
+     */
+    private function getParentId($child) {
+        $qb = \OC::$server->getDatabaseConnection()->getQueryBuilder();
+        $qb->select('parent')
+            ->from('filecache')
+            ->where(
+                $qb->expr()->eq('fileid', $qb->createNamedParameter($child))
+            );
+        $result = $qb->execute();
+        $row = $result->fetch();
+        $result->closeCursor();
+        return $row ? $row['parent'] : null;
+    }
 
-	public function getChildren($itemSource) {
-		$children = [];
-		$parents = [$itemSource];
+    public function getChildren($itemSource) {
+        $children = [];
+        $parents = [$itemSource];
 
-		$qb = \OC::$server->getDatabaseConnection()->getQueryBuilder();
-		$qb->select('id')
-			->from('mimetypes')
-			->where(
-				$qb->expr()->eq('mimetype', $qb->createNamedParameter('httpd/unix-directory'))
-			);
-		$result = $qb->execute();
-		$row = $result->fetch();
-		$result->closeCursor();
+        $qb = \OC::$server->getDatabaseConnection()->getQueryBuilder();
+        $qb->select('id')
+            ->from('mimetypes')
+            ->where(
+                $qb->expr()->eq('mimetype', $qb->createNamedParameter('httpd/unix-directory'))
+            );
+        $result = $qb->execute();
+        $row = $result->fetch();
+        $result->closeCursor();
 
-		if ($row = $result->fetchRow()) {
-			$mimetype = (int) $row['id'];
-		} else {
-			$mimetype = -1;
-		}
-		while (!empty($parents)) {
-			$qb = \OC::$server->getDatabaseConnection()->getQueryBuilder();
+        if ($row = $result->fetchRow()) {
+            $mimetype = (int) $row['id'];
+        } else {
+            $mimetype = -1;
+        }
+        while (!empty($parents)) {
+            $qb = \OC::$server->getDatabaseConnection()->getQueryBuilder();
 
-			$parents = array_map(function ($parent) use ($qb) {
-				return $qb->createNamedParameter($parent);
-			}, $parents);
+            $parents = array_map(function ($parent) use ($qb) {
+                return $qb->createNamedParameter($parent);
+            }, $parents);
 
-			$qb->select('`fileid', 'name', '`mimetype')
-				->from('filecache')
-				->where(
-					$qb->expr()->in('parent', $parents)
-				);
+            $qb->select('`fileid', 'name', '`mimetype')
+                ->from('filecache')
+                ->where(
+                    $qb->expr()->in('parent', $parents)
+                );
 
-			$result = $qb->execute();
+            $result = $qb->execute();
 
-			$parents = [];
-			while ($file = $result->fetch()) {
-				$children[] = ['source' => $file['fileid'], 'file_path' => $file['name']];
-				// If a child folder is found look inside it
-				if ((int) $file['mimetype'] === $mimetype) {
-					$parents[] = $file['fileid'];
-				}
-			}
-			$result->closeCursor();
-		}
-		return $children;
-	}
+            $parents = [];
+            while ($file = $result->fetch()) {
+                $children[] = ['source' => $file['fileid'], 'file_path' => $file['name']];
+                // If a child folder is found look inside it
+                if ((int) $file['mimetype'] === $mimetype) {
+                    $parents[] = $file['fileid'];
+                }
+            }
+            $result->closeCursor();
+        }
+        return $children;
+    }
 }

apps/files_sharing/lib/Collaboration/ShareRecipientSorter.php

Spacing +5 added lines, -5 removed lines

@@ -60,7 +60,7 @@ 
 		}
 		$userFolder = $this->rootFolder->getUserFolder($user->getUID());
 		/** @var Node[] $nodes */
-		$nodes = $userFolder->getById((int)$context['itemId']);
+		$nodes = $userFolder->getById((int) $context['itemId']);
 		if (count($nodes) === 0) {
 			return;
 		}
@@ -74,11 +74,11 @@ 
 			// at least on PHP 5.6 usort turned out to be not stable. So we add
 			// the current index to the value and compare it on a draw
 			$i = 0;
-			$workArray = array_map(function ($element) use (&$i) {
+			$workArray = array_map(function($element) use (&$i) {
 				return [$i++, $element];
 			}, $byType);
 
-			usort($workArray, function ($a, $b) use ($al, $type) {
+			usort($workArray, function($a, $b) use ($al, $type) {
 				$result = $this->compare($a[1], $b[1], $al[$type]);
 				if ($result === 0) {
 					$result = $a[0] - $b[0];
@@ -101,8 +101,8 @@ 
 		$a = $a['value']['shareWith'];
 		$b = $b['value']['shareWith'];
 
-		$valueA = (int)in_array($a, $al, true);
-		$valueB = (int)in_array($b, $al, true);
+		$valueA = (int) in_array($a, $al, true);
+		$valueB = (int) in_array($b, $al, true);
 
 		return $valueB - $valueA;
 	}

Indentation +61 added lines, -61 removed lines

@@ -32,75 +32,75 @@
 
 class ShareRecipientSorter implements ISorter {
 
-	private IManager $shareManager;
-	private IRootFolder $rootFolder;
-	private IUserSession $userSession;
+    private IManager $shareManager;
+    private IRootFolder $rootFolder;
+    private IUserSession $userSession;
 
-	public function __construct(IManager $shareManager, IRootFolder $rootFolder, IUserSession $userSession) {
-		$this->shareManager = $shareManager;
-		$this->rootFolder = $rootFolder;
-		$this->userSession = $userSession;
-	}
+    public function __construct(IManager $shareManager, IRootFolder $rootFolder, IUserSession $userSession) {
+        $this->shareManager = $shareManager;
+        $this->rootFolder = $rootFolder;
+        $this->userSession = $userSession;
+    }
 
-	public function getId(): string {
-		return 'share-recipients';
-	}
+    public function getId(): string {
+        return 'share-recipients';
+    }
 
-	public function sort(array &$sortArray, array $context) {
-		// let's be tolerant. Comments  uses "files" by default, other usages are often singular
-		if ($context['itemType'] !== 'files' && $context['itemType'] !== 'file') {
-			return;
-		}
-		$user = $this->userSession->getUser();
-		if ($user === null) {
-			return;
-		}
-		$userFolder = $this->rootFolder->getUserFolder($user->getUID());
-		/** @var Node[] $nodes */
-		$nodes = $userFolder->getById((int)$context['itemId']);
-		if (count($nodes) === 0) {
-			return;
-		}
-		$al = $this->shareManager->getAccessList($nodes[0]);
+    public function sort(array &$sortArray, array $context) {
+        // let's be tolerant. Comments  uses "files" by default, other usages are often singular
+        if ($context['itemType'] !== 'files' && $context['itemType'] !== 'file') {
+            return;
+        }
+        $user = $this->userSession->getUser();
+        if ($user === null) {
+            return;
+        }
+        $userFolder = $this->rootFolder->getUserFolder($user->getUID());
+        /** @var Node[] $nodes */
+        $nodes = $userFolder->getById((int)$context['itemId']);
+        if (count($nodes) === 0) {
+            return;
+        }
+        $al = $this->shareManager->getAccessList($nodes[0]);
 
-		foreach ($sortArray as $type => &$byType) {
-			if (!isset($al[$type]) || !is_array($al[$type])) {
-				continue;
-			}
+        foreach ($sortArray as $type => &$byType) {
+            if (!isset($al[$type]) || !is_array($al[$type])) {
+                continue;
+            }
 
-			// at least on PHP 5.6 usort turned out to be not stable. So we add
-			// the current index to the value and compare it on a draw
-			$i = 0;
-			$workArray = array_map(function ($element) use (&$i) {
-				return [$i++, $element];
-			}, $byType);
+            // at least on PHP 5.6 usort turned out to be not stable. So we add
+            // the current index to the value and compare it on a draw
+            $i = 0;
+            $workArray = array_map(function ($element) use (&$i) {
+                return [$i++, $element];
+            }, $byType);
 
-			usort($workArray, function ($a, $b) use ($al, $type) {
-				$result = $this->compare($a[1], $b[1], $al[$type]);
-				if ($result === 0) {
-					$result = $a[0] - $b[0];
-				}
-				return $result;
-			});
+            usort($workArray, function ($a, $b) use ($al, $type) {
+                $result = $this->compare($a[1], $b[1], $al[$type]);
+                if ($result === 0) {
+                    $result = $a[0] - $b[0];
+                }
+                return $result;
+            });
 
-			// and remove the index values again
-			$byType = array_column($workArray, 1);
-		}
-	}
+            // and remove the index values again
+            $byType = array_column($workArray, 1);
+        }
+    }
 
-	/**
-	 * @param array $a
-	 * @param array $b
-	 * @param array $al
-	 * @return int
-	 */
-	protected function compare(array $a, array $b, array $al) {
-		$a = $a['value']['shareWith'];
-		$b = $b['value']['shareWith'];
+    /**
+     * @param array $a
+     * @param array $b
+     * @param array $al
+     * @return int
+     */
+    protected function compare(array $a, array $b, array $al) {
+        $a = $a['value']['shareWith'];
+        $b = $b['value']['shareWith'];
 
-		$valueA = (int)in_array($a, $al, true);
-		$valueB = (int)in_array($b, $al, true);
+        $valueA = (int)in_array($a, $al, true);
+        $valueB = (int)in_array($b, $al, true);
 
-		return $valueB - $valueA;
-	}
+        return $valueB - $valueA;
+    }
 }

apps/files_sharing/lib/Listener/UserShareAcceptanceListener.php

Indentation +36 added lines, -36 removed lines

@@ -38,47 +38,47 @@
 
 class UserShareAcceptanceListener implements IEventListener {
 
-	/** @var IConfig */
-	private $config;
-	/** @var IManager */
-	private $shareManager;
-	/** @var IGroupManager */
-	private $groupManager;
+    /** @var IConfig */
+    private $config;
+    /** @var IManager */
+    private $shareManager;
+    /** @var IGroupManager */
+    private $groupManager;
 
-	public function __construct(IConfig $config, IManager $shareManager, IGroupManager $groupManager) {
-		$this->config = $config;
-		$this->shareManager = $shareManager;
-		$this->groupManager = $groupManager;
-	}
+    public function __construct(IConfig $config, IManager $shareManager, IGroupManager $groupManager) {
+        $this->config = $config;
+        $this->shareManager = $shareManager;
+        $this->groupManager = $groupManager;
+    }
 
-	public function handle(Event $event): void {
-		if (!($event instanceof ShareCreatedEvent)) {
-			return;
-		}
+    public function handle(Event $event): void {
+        if (!($event instanceof ShareCreatedEvent)) {
+            return;
+        }
 
-		$share = $event->getShare();
+        $share = $event->getShare();
 
-		if ($share->getShareType() === IShare::TYPE_USER) {
-			$this->handleAutoAccept($share, $share->getSharedWith());
-		} elseif ($share->getShareType() === IShare::TYPE_GROUP) {
-			$group = $this->groupManager->get($share->getSharedWith());
+        if ($share->getShareType() === IShare::TYPE_USER) {
+            $this->handleAutoAccept($share, $share->getSharedWith());
+        } elseif ($share->getShareType() === IShare::TYPE_GROUP) {
+            $group = $this->groupManager->get($share->getSharedWith());
 
-			if ($group === null) {
-				return;
-			}
+            if ($group === null) {
+                return;
+            }
 
-			$users = $group->getUsers();
-			foreach ($users as $user) {
-				$this->handleAutoAccept($share, $user->getUID());
-			}
-		}
-	}
+            $users = $group->getUsers();
+            foreach ($users as $user) {
+                $this->handleAutoAccept($share, $user->getUID());
+            }
+        }
+    }
 
-	private function handleAutoAccept(IShare $share, string $userId) {
-		$defaultAcceptSystemConfig = $this->config->getSystemValueBool('sharing.enable_share_accept', false) ? 'no' : 'yes';
-		$acceptDefault = $this->config->getUserValue($userId, Application::APP_ID, 'default_accept', $defaultAcceptSystemConfig) === 'yes';
-		if (!$this->config->getSystemValueBool('sharing.force_share_accept', false) && $acceptDefault) {
-			$this->shareManager->acceptShare($share, $userId);
-		}
-	}
+    private function handleAutoAccept(IShare $share, string $userId) {
+        $defaultAcceptSystemConfig = $this->config->getSystemValueBool('sharing.enable_share_accept', false) ? 'no' : 'yes';
+        $acceptDefault = $this->config->getUserValue($userId, Application::APP_ID, 'default_accept', $defaultAcceptSystemConfig) === 'yes';
+        if (!$this->config->getSystemValueBool('sharing.force_share_accept', false) && $acceptDefault) {
+            $this->shareManager->acceptShare($share, $userId);
+        }
+    }
 }