Version16000Date20190207141427::changeSchema() - Code Metrics - Inspection of "Merge pull request #11871 from nextcloud/feature/1..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 346770...2398d1 )

by Roeland

created 2019-03-01 20:22 UTC

Version16000Date20190207141427::changeSchema() A

↳ Parent: Version16000Date20190207141427

Complexity

Conditions	4
Paths	8

Size

Total Lines	69
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	44
nc	8
nop	3
dl	0
loc	69
rs	9.216
c	0
b	0
f	0

How to fix Long Method

<?php
declare(strict_types=1);
/**
 * @copyright Copyright (c) 2018 Joas Schilling <[email protected]>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OC\Core\Migrations;

use Closure;
use Doctrine\DBAL\Types\Type;
use OCP\DB\ISchemaWrapper;
use OCP\Migration\SimpleMigrationStep;
use OCP\Migration\IOutput;

class Version16000Date20190207141427 extends SimpleMigrationStep {


	/**
	 * @param IOutput $output
	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
	 * @param array $options
	 * @return null|ISchemaWrapper
	 */
	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
		/** @var ISchemaWrapper $schema */
		$schema = $schemaClosure();

		if (!$schema->hasTable('collres_collections')) {
			$table = $schema->createTable('collres_collections');

			$table->addColumn('id', Type::BIGINT, [
				'autoincrement' => true,
				'notnull' => true,
			]);
			$table->addColumn('name', Type::STRING, [
				'notnull' => true,
				'length' => 64,
			]);

			$table->setPrimaryKey(['id']);
		}

		if (!$schema->hasTable('collres_resources')) {
			$table = $schema->createTable('collres_resources');

			$table->addColumn('collection_id', Type::BIGINT, [
				'notnull' => true,
			]);
			$table->addColumn('resource_type', Type::STRING, [
				'notnull' => true,
				'length' => 64,
			]);
			$table->addColumn('resource_id', Type::STRING, [
				'notnull' => true,
				'length' => 64,
			]);

			$table->addUniqueIndex(['collection_id', 'resource_type', 'resource_id'], 'collres_unique_res');
		}

		if (!$schema->hasTable('collres_accesscache')) {
			$table = $schema->createTable('collres_accesscache');

			$table->addColumn('user_id', Type::STRING, [
				'notnull' => true,
				'length' => 64,
			]);
			$table->addColumn('collection_id', Type::BIGINT, [
				'notnull' => false,
				'default' => 0,
			]);
			$table->addColumn('resource_type', Type::STRING, [
				'notnull' => false,
				'length' => 64,
				'default' => '',
			]);
			$table->addColumn('resource_id', Type::STRING, [
				'notnull' => false,
				'length' => 64,
				'default' => '',
			]);
			$table->addColumn('access', Type::SMALLINT, [
				'notnull' => true,
				'default' => 0,
			]);

			$table->addUniqueIndex(['user_id', 'collection_id', 'resource_type', 'resource_id'], 'collres_unique_user');
			$table->addIndex(['user_id', 'resource_type', 'resource_id'], 'collres_user_res');
			$table->addIndex(['user_id', 'collection_id'], 'collres_user_coll');
		}

		return $schema;
	}

}


1			<?php
2			declare(strict_types=1);
3			/**
4			* @copyright Copyright (c) 2018 Joas Schilling <[email protected]>
5			*
6			* @license GNU AGPL version 3 or any later version
7			*
8			* This program is free software: you can redistribute it and/or modify
9			* it under the terms of the GNU Affero General Public License as
10			* published by the Free Software Foundation, either version 3 of the
11			* License, or (at your option) any later version.
12			*
13			* This program is distributed in the hope that it will be useful,
14			* but WITHOUT ANY WARRANTY; without even the implied warranty of
15			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16			* GNU Affero General Public License for more details.
17			*
18			* You should have received a copy of the GNU Affero General Public License
19			* along with this program. If not, see <http://www.gnu.org/licenses/>.
20			*
21			*/
22
23			namespace OC\Core\Migrations;
24
25			use Closure;
26			use Doctrine\DBAL\Types\Type;
27			use OCP\DB\ISchemaWrapper;
28			use OCP\Migration\SimpleMigrationStep;
29			use OCP\Migration\IOutput;
30
31			class Version16000Date20190207141427 extends SimpleMigrationStep {
32
33
34			/**
35			* @param IOutput $output
36			* @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
37			* @param array $options
38			* @return null\|ISchemaWrapper
39			*/
40			public function changeSchema(IOutput $output, Closure $schemaClosure, array $options) {
41			/** @var ISchemaWrapper $schema */
42			$schema = $schemaClosure();
43
44			if (!$schema->hasTable('collres_collections')) {
45			$table = $schema->createTable('collres_collections');
46
47			$table->addColumn('id', Type::BIGINT, [
48			'autoincrement' => true,
49			'notnull' => true,
50			]);
51			$table->addColumn('name', Type::STRING, [
52			'notnull' => true,
53			'length' => 64,
54			]);
55
56			$table->setPrimaryKey(['id']);
57			}
58
59			if (!$schema->hasTable('collres_resources')) {
60			$table = $schema->createTable('collres_resources');
61
62			$table->addColumn('collection_id', Type::BIGINT, [
63			'notnull' => true,
64			]);
65			$table->addColumn('resource_type', Type::STRING, [
66			'notnull' => true,
67			'length' => 64,
68			]);
69			$table->addColumn('resource_id', Type::STRING, [
70			'notnull' => true,
71			'length' => 64,
72			]);
73
74			$table->addUniqueIndex(['collection_id', 'resource_type', 'resource_id'], 'collres_unique_res');
75			}
76
77			if (!$schema->hasTable('collres_accesscache')) {
78			$table = $schema->createTable('collres_accesscache');
79
80			$table->addColumn('user_id', Type::STRING, [
81			'notnull' => true,
82			'length' => 64,
83			]);
84			$table->addColumn('collection_id', Type::BIGINT, [
85			'notnull' => false,
86			'default' => 0,
87			]);
88			$table->addColumn('resource_type', Type::STRING, [
89			'notnull' => false,
90			'length' => 64,
91			'default' => '',
92			]);
93			$table->addColumn('resource_id', Type::STRING, [
94			'notnull' => false,
95			'length' => 64,
96			'default' => '',
97			]);
98			$table->addColumn('access', Type::SMALLINT, [
99			'notnull' => true,
100			'default' => 0,
101			]);
102
103			$table->addUniqueIndex(['user_id', 'collection_id', 'resource_type', 'resource_id'], 'collres_unique_user');
104			$table->addIndex(['user_id', 'resource_type', 'resource_id'], 'collres_user_res');
105			$table->addIndex(['user_id', 'collection_id'], 'collres_user_coll');
106			}
107
108			return $schema;
109			}
110
111			}
112

nextcloud / server

Push — master ( 346770...2398d1 )

Version16000Date20190207141427::changeSchema() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like