Notifier::prepare() - Code Metrics - Inspection of "Merge pull request #12349 from nextcloud/feature/n..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( fe261c...bd7e98 )

by Morris

created 2018-11-08 21:48 UTC

Notifier::prepare() B

↳ Parent: Notifier

Complexity

Conditions	10
Paths	23

Size

Total Lines	75
Code Lines	55

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	10
eloc	55
nc	23
nop	2
dl	0
loc	75
rs	7.1151
c	0
b	0
f	0

How to fix Long Method Complexity

<?php
/**
 * @copyright Copyright (c) 2016, ownCloud, Inc.
 *
 * @author Arthur Schiwon <[email protected]>
 * @author Joas Schilling <[email protected]>
 * @author Roeland Jago Douma <[email protected]>
 *
 * @license AGPL-3.0
 *
 * This code is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License, version 3,
 * as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License, version 3,
 * along with this program.  If not, see <http://www.gnu.org/licenses/>
 *
 */

namespace OCA\Comments\Notification;

use OCP\Comments\IComment;
use OCP\Comments\ICommentsManager;
use OCP\Comments\NotFoundException;
use OCP\Files\IRootFolder;
use OCP\IURLGenerator;
use OCP\IUser;
use OCP\IUserManager;
use OCP\L10N\IFactory;
use OCP\Notification\INotification;
use OCP\Notification\INotifier;

class Notifier implements INotifier {

	/** @var IFactory */
	protected $l10nFactory;

	/** @var IRootFolder  */
	protected $rootFolder;

	/** @var ICommentsManager  */
	protected $commentsManager;

	/** @var IURLGenerator */
	protected $url;

	/** @var IUserManager */
	protected $userManager;

	public function __construct(
		IFactory $l10nFactory,
		IRootFolder $rootFolder,
		ICommentsManager $commentsManager,
		IURLGenerator $url,
		IUserManager $userManager
	) {
		$this->l10nFactory = $l10nFactory;
		$this->rootFolder = $rootFolder;
		$this->commentsManager = $commentsManager;
		$this->url = $url;
		$this->userManager = $userManager;
	}

	/**
	 * @param INotification $notification
	 * @param string $languageCode The code of the language that should be used to prepare the notification
	 * @return INotification
	 * @throws \InvalidArgumentException When the notification was not prepared by a notifier
	 */
	public function prepare(INotification $notification, $languageCode) {
		if($notification->getApp() !== 'comments') {
			throw new \InvalidArgumentException();
		}
		try {
			$comment = $this->commentsManager->get($notification->getObjectId());
		} catch(NotFoundException $e) {
			// needs to be converted to InvalidArgumentException, otherwise none Notifications will be shown at all
			throw new \InvalidArgumentException('Comment not found', 0, $e);
		}
		$l = $this->l10nFactory->get('comments', $languageCode);
		$displayName = $comment->getActorId();
		$isDeletedActor = $comment->getActorType() === ICommentsManager::DELETED_USER;
		if ($comment->getActorType() === 'users') {
			$commenter = $this->userManager->get($comment->getActorId());
			if ($commenter instanceof IUser) {
				$displayName = $commenter->getDisplayName();
			}
		}

		switch ($notification->getSubject()) {
			case 'mention':
				$parameters = $notification->getSubjectParameters();
				if($parameters[0] !== 'files') {
					throw new \InvalidArgumentException('Unsupported comment object');
				}
				$userFolder = $this->rootFolder->getUserFolder($notification->getUser());
				$nodes = $userFolder->getById((int)$parameters[1]);
				if(empty($nodes)) {
					throw new \InvalidArgumentException('Cannot resolve file ID to node instance');
				}
				$node = $nodes[0];

				$path = rtrim($node->getPath(), '/');
				if (strpos($path, '/' . $notification->getUser() . '/files/') === 0) {
					// Remove /user/files/...
					$fullPath = $path;
					list(,,, $path) = explode('/', $fullPath, 4);
				}
				$subjectParameters = [
					'file' => [
						'type' => 'file',
						'id' => $comment->getObjectId(),
						'name' => $node->getName(),
						'path' => $path,
						'link' => $this->url->linkToRouteAbsolute('files.viewcontroller.showFile', ['fileid' => $comment->getObjectId()]),
					],
				];

				if ($isDeletedActor) {
					$subject = $l->t('You were mentioned on “{file}”, in a comment by a user that has since been deleted');
				} else {
					$subject = $l->t('{user} mentioned you in a comment on “{file}”');
					$subjectParameters['user'] = [
						'type' => 'user',
						'id' => $comment->getActorId(),
						'name' => $displayName,
					];
				}
				list($message, $messageParameters) = $this->commentToRichMessage($comment);
				$notification->setRichSubject($subject, $subjectParameters)
					->setParsedSubject($this->richToParsed($subject, $subjectParameters))
					->setRichMessage($message, $messageParameters)
					->setParsedMessage($this->richToParsed($message, $messageParameters))
					->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/comment.svg')))
					->setLink($this->url->linkToRouteAbsolute(
						'comments.Notifications.view',
						['id' => $comment->getId()])
					);

				return $notification;
				break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

			default:
				throw new \InvalidArgumentException('Invalid subject');
		}
	}

	public function commentToRichMessage(IComment $comment): array {
		$message = $comment->getMessage();
		$messageParameters = [];
		$mentionTypeCount = [];
		$mentions = $comment->getMentions();
		foreach ($mentions as $mention) {
			if ($mention['type'] === 'user') {
				$user = $this->userManager->get($mention['id']);
				if (!$user instanceof IUser) {
					continue;
				}
			}
			if (!array_key_exists($mention['type'], $mentionTypeCount)) {
				$mentionTypeCount[$mention['type']] = 0;
			}
			$mentionTypeCount[$mention['type']]++;
			// To keep a limited character set in parameter IDs ([a-zA-Z0-9-])
			// the mention parameter ID does not include the mention ID (which
			// could contain characters like '@' for user IDs) but a one-based
			// index of the mentions of that type.
			$mentionParameterId = 'mention-' . $mention['type'] . $mentionTypeCount[$mention['type']];
			$message = str_replace('@' . $mention['id'], '{' . $mentionParameterId . '}', $message);
			try {
				$displayName = $this->commentsManager->resolveDisplayName($mention['type'], $mention['id']);
			} catch (\OutOfBoundsException $e) {
				// There is no registered display name resolver for the mention
				// type, so the client decides what to display.
				$displayName = '';
			}
			$messageParameters[$mentionParameterId] = [
				'type' => $mention['type'],
				'id' => $mention['id'],
				'name' => $displayName
			];
		}
		return [$message, $messageParameters];
	}

	public function richToParsed(string $message, array $parameters): string {
		$placeholders = $replacements = [];
		foreach ($parameters as $placeholder => $parameter) {
			$placeholders[] = '{' . $placeholder . '}';
			if ($parameter['type'] === 'user') {
				$replacements[] = '@' . $parameter['name'];
			} else if ($parameter['type'] === 'file') {
				$replacements[] = $parameter['path'];
			} else {
				$replacements[] = $parameter['name'];
			}
		}
		return str_replace($placeholders, $replacements, $message);
	}
}


1			<?php
2			/**
3			* @copyright Copyright (c) 2016, ownCloud, Inc.
4			*
5			* @author Arthur Schiwon <[email protected]>
6			* @author Joas Schilling <[email protected]>
7			* @author Roeland Jago Douma <[email protected]>
8			*
9			* @license AGPL-3.0
10			*
11			* This code is free software: you can redistribute it and/or modify
12			* it under the terms of the GNU Affero General Public License, version 3,
13			* as published by the Free Software Foundation.
14			*
15			* This program is distributed in the hope that it will be useful,
16			* but WITHOUT ANY WARRANTY; without even the implied warranty of
17			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18			* GNU Affero General Public License for more details.
19			*
20			* You should have received a copy of the GNU Affero General Public License, version 3,
21			* along with this program. If not, see <http://www.gnu.org/licenses/>
22			*
23			*/
24
25			namespace OCA\Comments\Notification;
26
27			use OCP\Comments\IComment;
28			use OCP\Comments\ICommentsManager;
29			use OCP\Comments\NotFoundException;
30			use OCP\Files\IRootFolder;
31			use OCP\IURLGenerator;
32			use OCP\IUser;
33			use OCP\IUserManager;
34			use OCP\L10N\IFactory;
35			use OCP\Notification\INotification;
36			use OCP\Notification\INotifier;
37
38			class Notifier implements INotifier {
39
40			/** @var IFactory */
41			protected $l10nFactory;
42
43			/** @var IRootFolder */
44			protected $rootFolder;
45
46			/** @var ICommentsManager */
47			protected $commentsManager;
48
49			/** @var IURLGenerator */
50			protected $url;
51
52			/** @var IUserManager */
53			protected $userManager;
54
55			public function __construct(
56			IFactory $l10nFactory,
57			IRootFolder $rootFolder,
58			ICommentsManager $commentsManager,
59			IURLGenerator $url,
60			IUserManager $userManager
61			) {
62			$this->l10nFactory = $l10nFactory;
63			$this->rootFolder = $rootFolder;
64			$this->commentsManager = $commentsManager;
65			$this->url = $url;
66			$this->userManager = $userManager;
67			}
68
69			/**
70			* @param INotification $notification
71			* @param string $languageCode The code of the language that should be used to prepare the notification
72			* @return INotification
73			* @throws \InvalidArgumentException When the notification was not prepared by a notifier
74			*/
75			public function prepare(INotification $notification, $languageCode) {
76			if($notification->getApp() !== 'comments') {
77			throw new \InvalidArgumentException();
78			}
79			try {
80			$comment = $this->commentsManager->get($notification->getObjectId());
81			} catch(NotFoundException $e) {
82			// needs to be converted to InvalidArgumentException, otherwise none Notifications will be shown at all
83			throw new \InvalidArgumentException('Comment not found', 0, $e);
84			}
85			$l = $this->l10nFactory->get('comments', $languageCode);
86			$displayName = $comment->getActorId();
87			$isDeletedActor = $comment->getActorType() === ICommentsManager::DELETED_USER;
88			if ($comment->getActorType() === 'users') {
89			$commenter = $this->userManager->get($comment->getActorId());
90			if ($commenter instanceof IUser) {
91			$displayName = $commenter->getDisplayName();
92			}
93			}
94
95			switch ($notification->getSubject()) {
96			case 'mention':
97			$parameters = $notification->getSubjectParameters();
98			if($parameters[0] !== 'files') {
99			throw new \InvalidArgumentException('Unsupported comment object');
100			}
101			$userFolder = $this->rootFolder->getUserFolder($notification->getUser());
102			$nodes = $userFolder->getById((int)$parameters[1]);
103			if(empty($nodes)) {
104			throw new \InvalidArgumentException('Cannot resolve file ID to node instance');
105			}
106			$node = $nodes[0];
107
108			$path = rtrim($node->getPath(), '/');
109			if (strpos($path, '/' . $notification->getUser() . '/files/') === 0) {
110			// Remove /user/files/...
111			$fullPath = $path;
112			list(,,, $path) = explode('/', $fullPath, 4);
113			}
114			$subjectParameters = [
115			'file' => [
116			'type' => 'file',
117			'id' => $comment->getObjectId(),
118			'name' => $node->getName(),
119			'path' => $path,
120			'link' => $this->url->linkToRouteAbsolute('files.viewcontroller.showFile', ['fileid' => $comment->getObjectId()]),
121			],
122			];
123
124			if ($isDeletedActor) {
125			$subject = $l->t('You were mentioned on “{file}”, in a comment by a user that has since been deleted');
126			} else {
127			$subject = $l->t('{user} mentioned you in a comment on “{file}”');
128			$subjectParameters['user'] = [
129			'type' => 'user',
130			'id' => $comment->getActorId(),
131			'name' => $displayName,
132			];
133			}
134			list($message, $messageParameters) = $this->commentToRichMessage($comment);
135			$notification->setRichSubject($subject, $subjectParameters)
136			->setParsedSubject($this->richToParsed($subject, $subjectParameters))
137			->setRichMessage($message, $messageParameters)
138			->setParsedMessage($this->richToParsed($message, $messageParameters))
139			->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/comment.svg')))
140			->setLink($this->url->linkToRouteAbsolute(
141			'comments.Notifications.view',
142			['id' => $comment->getId()])
143			);
144
145			return $notification;
146			break;
			0 ignored issues – show Unused Code introduced 2018-10-24 12:40 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
147
148			default:
149			throw new \InvalidArgumentException('Invalid subject');
150			}
151			}
152
153			public function commentToRichMessage(IComment $comment): array {
154			$message = $comment->getMessage();
155			$messageParameters = [];
156			$mentionTypeCount = [];
157			$mentions = $comment->getMentions();
158			foreach ($mentions as $mention) {
159			if ($mention['type'] === 'user') {
160			$user = $this->userManager->get($mention['id']);
161			if (!$user instanceof IUser) {
162			continue;
163			}
164			}
165			if (!array_key_exists($mention['type'], $mentionTypeCount)) {
166			$mentionTypeCount[$mention['type']] = 0;
167			}
168			$mentionTypeCount[$mention['type']]++;
169			// To keep a limited character set in parameter IDs ([a-zA-Z0-9-])
170			// the mention parameter ID does not include the mention ID (which
171			// could contain characters like '@' for user IDs) but a one-based
172			// index of the mentions of that type.
173			$mentionParameterId = 'mention-' . $mention['type'] . $mentionTypeCount[$mention['type']];
174			$message = str_replace('@' . $mention['id'], '{' . $mentionParameterId . '}', $message);
175			try {
176			$displayName = $this->commentsManager->resolveDisplayName($mention['type'], $mention['id']);
177			} catch (\OutOfBoundsException $e) {
178			// There is no registered display name resolver for the mention
179			// type, so the client decides what to display.
180			$displayName = '';
181			}
182			$messageParameters[$mentionParameterId] = [
183			'type' => $mention['type'],
184			'id' => $mention['id'],
185			'name' => $displayName
186			];
187			}
188			return [$message, $messageParameters];
189			}
190
191			public function richToParsed(string $message, array $parameters): string {
192			$placeholders = $replacements = [];
193			foreach ($parameters as $placeholder => $parameter) {
194			$placeholders[] = '{' . $placeholder . '}';
195			if ($parameter['type'] === 'user') {
196			$replacements[] = '@' . $parameter['name'];
197			} else if ($parameter['type'] === 'file') {
198			$replacements[] = $parameter['path'];
199			} else {
200			$replacements[] = $parameter['name'];
201			}
202			}
203			return str_replace($placeholders, $replacements, $message);
204			}
205			}
206

nextcloud / server

Push — master ( fe261c...bd7e98 )

Notifier::prepare() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like