Inspection of "Merge pull request #26553 from nextcloud/enh/boots..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 403388...874eff )

by Roeland

created 2021-04-16 12:27 UTC

Status

Indentation +69 added lines, -69 removed lines patch added patch discarded remove patch

@@ -53,83 +53,83 @@
 block discarded – undo
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 
 class Application extends App implements IBootstrap {
-	public function __construct() {
-		parent::__construct('user_ldap');
-		$container = $this->getContainer();
+    public function __construct() {
+        parent::__construct('user_ldap');
+        $container = $this->getContainer();
 
-		/**
-		 * Controller
-		 */
-		$container->registerService('RenewPasswordController', function (IAppContainer $appContainer) {
-			/** @var IServerContainer $server */
-			$server = $appContainer->get(IServerContainer::class);
+        /**
+         * Controller
+         */
+        $container->registerService('RenewPasswordController', function (IAppContainer $appContainer) {
+            /** @var IServerContainer $server */
+            $server = $appContainer->get(IServerContainer::class);
 
-			return new RenewPasswordController(
-				$appContainer->get('AppName'),
-				$server->getRequest(),
-				$appContainer->get('UserManager'),
-				$server->getConfig(),
-				$appContainer->get(IL10N::class),
-				$appContainer->get('Session'),
-				$server->getURLGenerator()
-			);
-		});
+            return new RenewPasswordController(
+                $appContainer->get('AppName'),
+                $server->getRequest(),
+                $appContainer->get('UserManager'),
+                $server->getConfig(),
+                $appContainer->get(IL10N::class),
+                $appContainer->get('Session'),
+                $server->getURLGenerator()
+            );
+        });
 
-		$container->registerService(ILDAPWrapper::class, function () {
-			return new LDAP();
-		});
-	}
+        $container->registerService(ILDAPWrapper::class, function () {
+            return new LDAP();
+        });
+    }
 
-	public function register(IRegistrationContext $context): void {
-		$context->registerNotifierService(Notifier::class);
-	}
+    public function register(IRegistrationContext $context): void {
+        $context->registerNotifierService(Notifier::class);
+    }
 
-	public function boot(IBootContext $context): void {
-		$context->injectFn(function (
-			INotificationManager $notificationManager,
-			IAppContainer $appContainer,
-			EventDispatcherInterface $legacyDispatcher,
-			IEventDispatcher $dispatcher,
-			IGroupManager $groupManager,
-			User_Proxy $userBackend,
-			Group_Proxy $groupBackend,
-			Helper $helper
-		) {
-			$configPrefixes = $helper->getServerConfigurationPrefixes(true);
-			if (count($configPrefixes) > 0) {
-				$userPluginManager = $appContainer->get(UserPluginManager::class);
-				$groupPluginManager = $appContainer->get(GroupPluginManager::class);
+    public function boot(IBootContext $context): void {
+        $context->injectFn(function (
+            INotificationManager $notificationManager,
+            IAppContainer $appContainer,
+            EventDispatcherInterface $legacyDispatcher,
+            IEventDispatcher $dispatcher,
+            IGroupManager $groupManager,
+            User_Proxy $userBackend,
+            Group_Proxy $groupBackend,
+            Helper $helper
+        ) {
+            $configPrefixes = $helper->getServerConfigurationPrefixes(true);
+            if (count($configPrefixes) > 0) {
+                $userPluginManager = $appContainer->get(UserPluginManager::class);
+                $groupPluginManager = $appContainer->get(GroupPluginManager::class);
 
-				\OC_User::useBackend($userBackend);
-				$groupManager->addBackend($groupBackend);
+                \OC_User::useBackend($userBackend);
+                $groupManager->addBackend($groupBackend);
 
-				$userBackendRegisteredEvent = new UserBackendRegistered($userBackend, $userPluginManager);
-				$legacyDispatcher->dispatch('OCA\\User_LDAP\\User\\User::postLDAPBackendAdded', $userBackendRegisteredEvent);
-				$dispatcher->dispatchTyped($userBackendRegisteredEvent);
-				$groupBackendRegisteredEvent = new GroupBackendRegistered($groupBackend, $groupPluginManager);
-				$dispatcher->dispatchTyped($groupBackendRegisteredEvent);
-			}
-		});
+                $userBackendRegisteredEvent = new UserBackendRegistered($userBackend, $userPluginManager);
+                $legacyDispatcher->dispatch('OCA\\User_LDAP\\User\\User::postLDAPBackendAdded', $userBackendRegisteredEvent);
+                $dispatcher->dispatchTyped($userBackendRegisteredEvent);
+                $groupBackendRegisteredEvent = new GroupBackendRegistered($groupBackend, $groupPluginManager);
+                $dispatcher->dispatchTyped($groupBackendRegisteredEvent);
+            }
+        });
 
-		$context->injectFn(Closure::fromCallable([$this, 'registerBackendDependents']));
+        $context->injectFn(Closure::fromCallable([$this, 'registerBackendDependents']));
 
-		\OCP\Util::connectHook(
-			'\OCA\Files_Sharing\API\Server2Server',
-			'preLoginNameUsedAsUserName',
-			'\OCA\User_LDAP\Helper',
-			'loginName2UserName'
-		);
-	}
+        \OCP\Util::connectHook(
+            '\OCA\Files_Sharing\API\Server2Server',
+            'preLoginNameUsedAsUserName',
+            '\OCA\User_LDAP\Helper',
+            'loginName2UserName'
+        );
+    }
 
-	private function registerBackendDependents(IAppContainer $appContainer, EventDispatcherInterface $dispatcher) {
-		$dispatcher->addListener(
-			'OCA\\Files_External::loadAdditionalBackends',
-			function () use ($appContainer) {
-				$storagesBackendService = $appContainer->get(BackendService::class);
-				$storagesBackendService->registerConfigHandler('home', function () use ($appContainer) {
-					return $appContainer->get(ExtStorageConfigHandler::class);
-				});
-			}
-		);
-	}
+    private function registerBackendDependents(IAppContainer $appContainer, EventDispatcherInterface $dispatcher) {
+        $dispatcher->addListener(
+            'OCA\\Files_External::loadAdditionalBackends',
+            function () use ($appContainer) {
+                $storagesBackendService = $appContainer->get(BackendService::class);
+                $storagesBackendService->registerConfigHandler('home', function () use ($appContainer) {
+                    return $appContainer->get(ExtStorageConfigHandler::class);
+                });
+            }
+        );
+    }
 }

Please login to merge, or discard this patch.

		@@ -53,83 +53,83 @@
		block discarded – undo
53	53	use Symfony\Component\EventDispatcher\EventDispatcherInterface;
54	54
55	55	class Application extends App implements IBootstrap {
56		- public function __construct() {
57		- parent::__construct('user_ldap');
58		- $container = $this->getContainer();
	56	+ public function __construct() {
	57	+ parent::__construct('user_ldap');
	58	+ $container = $this->getContainer();
59	59
60		- /**
61		- * Controller
62		- */
63		- $container->registerService('RenewPasswordController', function (IAppContainer $appContainer) {
64		- /** @var IServerContainer $server */
65		- $server = $appContainer->get(IServerContainer::class);
	60	+ /**
	61	+ * Controller
	62	+ */
	63	+ $container->registerService('RenewPasswordController', function (IAppContainer $appContainer) {
	64	+ /** @var IServerContainer $server */
	65	+ $server = $appContainer->get(IServerContainer::class);
66	66
67		- return new RenewPasswordController(
68		- $appContainer->get('AppName'),
69		- $server->getRequest(),
70		- $appContainer->get('UserManager'),
71		- $server->getConfig(),
72		- $appContainer->get(IL10N::class),
73		- $appContainer->get('Session'),
74		- $server->getURLGenerator()
75		- );
76		- });
	67	+ return new RenewPasswordController(
	68	+ $appContainer->get('AppName'),
	69	+ $server->getRequest(),
	70	+ $appContainer->get('UserManager'),
	71	+ $server->getConfig(),
	72	+ $appContainer->get(IL10N::class),
	73	+ $appContainer->get('Session'),
	74	+ $server->getURLGenerator()
	75	+ );
	76	+ });
77	77
78		- $container->registerService(ILDAPWrapper::class, function () {
79		- return new LDAP();
80		- });
81		- }
	78	+ $container->registerService(ILDAPWrapper::class, function () {
	79	+ return new LDAP();
	80	+ });
	81	+ }
82	82
83		- public function register(IRegistrationContext $context): void {
84		- $context->registerNotifierService(Notifier::class);
85		- }
	83	+ public function register(IRegistrationContext $context): void {
	84	+ $context->registerNotifierService(Notifier::class);
	85	+ }
86	86
87		- public function boot(IBootContext $context): void {
88		- $context->injectFn(function (
89		- INotificationManager $notificationManager,
90		- IAppContainer $appContainer,
91		- EventDispatcherInterface $legacyDispatcher,
92		- IEventDispatcher $dispatcher,
93		- IGroupManager $groupManager,
94		- User_Proxy $userBackend,
95		- Group_Proxy $groupBackend,
96		- Helper $helper
97		- ) {
98		- $configPrefixes = $helper->getServerConfigurationPrefixes(true);
99		- if (count($configPrefixes) > 0) {
100		- $userPluginManager = $appContainer->get(UserPluginManager::class);
101		- $groupPluginManager = $appContainer->get(GroupPluginManager::class);
	87	+ public function boot(IBootContext $context): void {
	88	+ $context->injectFn(function (
	89	+ INotificationManager $notificationManager,
	90	+ IAppContainer $appContainer,
	91	+ EventDispatcherInterface $legacyDispatcher,
	92	+ IEventDispatcher $dispatcher,
	93	+ IGroupManager $groupManager,
	94	+ User_Proxy $userBackend,
	95	+ Group_Proxy $groupBackend,
	96	+ Helper $helper
	97	+ ) {
	98	+ $configPrefixes = $helper->getServerConfigurationPrefixes(true);
	99	+ if (count($configPrefixes) > 0) {
	100	+ $userPluginManager = $appContainer->get(UserPluginManager::class);
	101	+ $groupPluginManager = $appContainer->get(GroupPluginManager::class);
102	102
103		- \OC_User::useBackend($userBackend);
104		- $groupManager->addBackend($groupBackend);
	103	+ \OC_User::useBackend($userBackend);
	104	+ $groupManager->addBackend($groupBackend);
105	105
106		- $userBackendRegisteredEvent = new UserBackendRegistered($userBackend, $userPluginManager);
107		- $legacyDispatcher->dispatch('OCA\\User_LDAP\\User\\User::postLDAPBackendAdded', $userBackendRegisteredEvent);
108		- $dispatcher->dispatchTyped($userBackendRegisteredEvent);
109		- $groupBackendRegisteredEvent = new GroupBackendRegistered($groupBackend, $groupPluginManager);
110		- $dispatcher->dispatchTyped($groupBackendRegisteredEvent);
111		- }
112		- });
	106	+ $userBackendRegisteredEvent = new UserBackendRegistered($userBackend, $userPluginManager);
	107	+ $legacyDispatcher->dispatch('OCA\\User_LDAP\\User\\User::postLDAPBackendAdded', $userBackendRegisteredEvent);
	108	+ $dispatcher->dispatchTyped($userBackendRegisteredEvent);
	109	+ $groupBackendRegisteredEvent = new GroupBackendRegistered($groupBackend, $groupPluginManager);
	110	+ $dispatcher->dispatchTyped($groupBackendRegisteredEvent);
	111	+ }
	112	+ });
113	113
114		- $context->injectFn(Closure::fromCallable([$this, 'registerBackendDependents']));
	114	+ $context->injectFn(Closure::fromCallable([$this, 'registerBackendDependents']));
115	115
116		- \OCP\Util::connectHook(
117		- '\OCA\Files_Sharing\API\Server2Server',
118		- 'preLoginNameUsedAsUserName',
119		- '\OCA\User_LDAP\Helper',
120		- 'loginName2UserName'
121		- );
122		- }
	116	+ \OCP\Util::connectHook(
	117	+ '\OCA\Files_Sharing\API\Server2Server',
	118	+ 'preLoginNameUsedAsUserName',
	119	+ '\OCA\User_LDAP\Helper',
	120	+ 'loginName2UserName'
	121	+ );
	122	+ }
123	123
124		- private function registerBackendDependents(IAppContainer $appContainer, EventDispatcherInterface $dispatcher) {
125		- $dispatcher->addListener(
126		- 'OCA\\Files_External::loadAdditionalBackends',
127		- function () use ($appContainer) {
128		- $storagesBackendService = $appContainer->get(BackendService::class);
129		- $storagesBackendService->registerConfigHandler('home', function () use ($appContainer) {
130		- return $appContainer->get(ExtStorageConfigHandler::class);
131		- });
132		- }
133		- );
134		- }
	124	+ private function registerBackendDependents(IAppContainer $appContainer, EventDispatcherInterface $dispatcher) {
	125	+ $dispatcher->addListener(
	126	+ 'OCA\\Files_External::loadAdditionalBackends',
	127	+ function () use ($appContainer) {
	128	+ $storagesBackendService = $appContainer->get(BackendService::class);
	129	+ $storagesBackendService->registerConfigHandler('home', function () use ($appContainer) {
	130	+ return $appContainer->get(ExtStorageConfigHandler::class);
	131	+ });
	132	+ }
	133	+ );
	134	+ }
135	135	}

nextcloud / server

Push — master ( 403388...874eff )

Status

Category

Indentation +69 added lines, -69 removed lines patch added patch discarded remove patch