Completed
Pull Request — master (#19)
by Lukas
08:58
created
apps/files_external/lib/Command/Backends.php 1 patch
Unused Use Statements   -6 removed lines patch added patch discarded remove patch
@@ -22,18 +22,12 @@
 block discarded – undo
22 22
 namespace OCA\Files_External\Command;
23 23
 
24 24
 use OC\Core\Command\Base;
25
-use OCA\Files_External\Lib\Auth\AuthMechanism;
26 25
 use OCA\Files_External\Lib\Backend\Backend;
27 26
 use OCA\Files_External\Lib\DefinitionParameter;
28 27
 use OCA\Files_External\Service\BackendService;
29 28
 use Symfony\Component\Console\Command\Command;
30
-use Symfony\Component\Console\Helper\Table;
31
-use Symfony\Component\Console\Helper\TableHelper;
32
-use Symfony\Component\Console\Input\ArrayInput;
33 29
 use Symfony\Component\Console\Input\InputArgument;
34 30
 use Symfony\Component\Console\Input\InputInterface;
35
-use Symfony\Component\Console\Input\InputOption;
36
-use Symfony\Component\Console\Input\Input;
37 31
 use Symfony\Component\Console\Output\OutputInterface;
38 32
 
39 33
 class Backends extends Base {
Please login to merge, or discard this patch.
apps/files_external/lib/Command/Config.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -27,11 +27,8 @@
 block discarded – undo
27 27
 use OCA\Files_External\NotFoundException;
28 28
 use OCA\Files_External\Service\GlobalStoragesService;
29 29
 use Symfony\Component\Console\Command\Command;
30
-use Symfony\Component\Console\Helper\Table;
31
-use Symfony\Component\Console\Helper\TableHelper;
32 30
 use Symfony\Component\Console\Input\InputArgument;
33 31
 use Symfony\Component\Console\Input\InputInterface;
34
-use Symfony\Component\Console\Input\InputOption;
35 32
 use Symfony\Component\Console\Output\OutputInterface;
36 33
 
37 34
 class Config extends Base {
Please login to merge, or discard this patch.
apps/files_sharing/lib/API/Sharees.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -335,7 +335,7 @@
 block discarded – undo
335 335
 	 * split user and remote from federated cloud id
336 336
 	 *
337 337
 	 * @param string $address federated share address
338
-	 * @return array [user, remoteURL]
338
+	 * @return string[] [user, remoteURL]
339 339
 	 * @throws \Exception
340 340
 	 */
341 341
 	public function splitUserRemote($address) {
Please login to merge, or discard this patch.
apps/files_sharing/lib/External/Manager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -325,6 +325,9 @@
 block discarded – undo
325 325
 		return $result;
326 326
 	}
327 327
 
328
+	/**
329
+	 * @param string $mountPoint
330
+	 */
328 331
 	public function removeShare($mountPoint) {
329 332
 
330 333
 		$mountPointObj = $this->mountManager->find($mountPoint);
Please login to merge, or discard this patch.
apps/files_sharing/lib/Migration.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -130,7 +130,6 @@
 block discarded – undo
130 130
 	/**
131 131
 	 * Get $n re-shares from the database
132 132
 	 *
133
-	 * @param int $n The max number of shares to fetch
134 133
 	 * @return \Doctrine\DBAL\Driver\Statement
135 134
 	 */
136 135
 	private function getReShares() {
Please login to merge, or discard this patch.
apps/files_sharing/lib/sharedstorage.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -279,7 +279,7 @@
 block discarded – undo
279 279
 	/**
280 280
 	 * get share ID
281 281
 	 *
282
-	 * @return integer unique share ID
282
+	 * @return string unique share ID
283 283
 	 */
284 284
 	public function getShareId() {
285 285
 		return $this->newShare->getId();
Please login to merge, or discard this patch.
apps/files_trashbin/lib/Trashbin.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -671,7 +671,7 @@  discard block
 block discarded – undo
671 671
 	 * if the size limit for the trash bin is reached, we delete the oldest
672 672
 	 * files in the trash bin until we meet the limit again
673 673
 	 *
674
-	 * @param array $files
674
+	 * @param \OCP\Files\FileInfo[] $files
675 675
 	 * @param string $user
676 676
 	 * @param int $availableSpace available disc space
677 677
 	 * @return int size of deleted files
@@ -699,7 +699,7 @@  discard block
 block discarded – undo
699 699
 	/**
700 700
 	 * delete files older then max storage time
701 701
 	 *
702
-	 * @param array $files list of files sorted by mtime
702
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
703 703
 	 * @param string $user
704 704
 	 * @return integer[] size of deleted files and number of deleted files
705 705
 	 */
Please login to merge, or discard this patch.
apps/testing/locking/provisioning.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,6 @@
 block discarded – undo
22 22
 namespace OCA\Testing\Locking;
23 23
 
24 24
 use OC\Lock\DBLockingProvider;
25
-use OC\Lock\MemcacheLockingProvider;
26 25
 use OC\User\NoUserException;
27 26
 use OCP\AppFramework\Http;
28 27
 use OCP\Files\NotFoundException;
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@
 block discarded – undo
77 77
 	}
78 78
 
79 79
 	/**
80
-	 * @return int
80
+	 * @return string
81 81
 	 */
82 82
 	static private function getRefreshInterval() {
83 83
 		//defaults to every hour
Please login to merge, or discard this patch.
apps/updatenotification/lib/Notification/Notifier.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -102,6 +102,9 @@
 block discarded – undo
102 102
 		return \OC_App::getAppVersions();
103 103
 	}
104 104
 
105
+	/**
106
+	 * @param string $appId
107
+	 */
105 108
 	protected function getAppInfo($appId) {
106 109
 		return \OC_App::getAppInfo($appId);
107 110
 	}
Please login to merge, or discard this patch.