Completed
Pull Request — master (#19)
by Lukas
08:58
created
apps/dav/lib/Upload/AssemblyStream.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 
119 119
 	/**
120 120
 	 * @param string $data
121
-	 * @return int
121
+	 * @return boolean
122 122
 	 */
123 123
 	public function stream_write($data) {
124 124
 		return false;
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 	}
225 225
 
226 226
 	/**
227
-	 * @param $pos
227
+	 * @param integer $pos
228 228
 	 * @return IFile | null
229 229
 	 */
230 230
 	private function getNodeForPosition($pos) {
Please login to merge, or discard this patch.
apps/encryption/lib/Crypto/Encryption.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -369,7 +369,7 @@
 block discarded – undo
369 369
 	 * @param string $path path to the file which should be updated
370 370
 	 * @param string $uid of the user who performs the operation
371 371
 	 * @param array $accessList who has access to the file contains the key 'users' and 'public'
372
-	 * @return boolean
372
+	 * @return null|boolean
373 373
 	 */
374 374
 	public function update($path, $uid, array $accessList) {
375 375
 
Please login to merge, or discard this patch.
apps/encryption/lib/KeyManager.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,6 @@
 block discarded – undo
32 32
 use OCA\Encryption\Crypto\Crypt;
33 33
 use OCP\Encryption\Keys\IStorage;
34 34
 use OCP\IConfig;
35
-use OCP\IDBConnection;
36 35
 use OCP\ILogger;
37 36
 use OCP\IUserSession;
38 37
 
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -982,7 +982,7 @@
 block discarded – undo
982 982
 	/**
983 983
 	 * check if path points to a files version
984 984
 	 *
985
-	 * @param $path
985
+	 * @param string $path
986 986
 	 * @return bool
987 987
 	 */
988 988
 	protected function isVersion($path) {
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/FederatedShareProvider.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -391,7 +391,7 @@  discard block
 block discarded – undo
391 391
 	/**
392 392
 	 * store remote ID in federated reShare table
393 393
 	 *
394
-	 * @param $shareId
394
+	 * @param integer $shareId
395 395
 	 * @param $remoteId
396 396
 	 */
397 397
 	public function storeRemoteId($shareId, $remoteId) {
@@ -729,7 +729,7 @@  discard block
 block discarded – undo
729 729
 	/**
730 730
 	 * get database row of a give share
731 731
 	 *
732
-	 * @param $id
732
+	 * @param integer $id
733 733
 	 * @return array
734 734
 	 * @throws ShareNotFound
735 735
 	 */
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/RequestHandler.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -566,7 +566,7 @@
 block discarded – undo
566 566
 	/**
567 567
 	 * update permissions in database
568 568
 	 *
569
-	 * @param IShare $share
569
+	 * @param \OC\Share20\Share $share
570 570
 	 * @param int $permissions
571 571
 	 */
572 572
 	protected function updatePermissionsInDatabase(IShare $share, $permissions) {
Please login to merge, or discard this patch.
apps/federation/lib/AppInfo/Application.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,6 @@
 block discarded – undo
30 30
 use OCA\Federation\Hooks;
31 31
 use OCA\Federation\Middleware\AddServerMiddleware;
32 32
 use OCA\Federation\SyncFederationAddressBooks;
33
-use OCA\Federation\SyncJob;
34 33
 use OCA\Federation\TrustedServers;
35 34
 use OCP\API;
36 35
 use OCP\App;
Please login to merge, or discard this patch.
apps/federation/lib/Command/SyncFederationAddressBooks.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,6 @@
 block discarded – undo
22 22
  */
23 23
 namespace OCA\Federation\Command;
24 24
 
25
-use OCA\Federation\DbHandler;
26 25
 use Symfony\Component\Console\Command\Command;
27 26
 use Symfony\Component\Console\Helper\ProgressBar;
28 27
 use Symfony\Component\Console\Input\InputInterface;
Please login to merge, or discard this patch.
apps/federation/lib/DbHandler.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -299,8 +299,8 @@
 block discarded – undo
299 299
 	}
300 300
 
301 301
 	/**
302
-	 * @param $username
303
-	 * @param $password
302
+	 * @param string $username
303
+	 * @param string $password
304 304
 	 * @return bool
305 305
 	 */
306 306
 	public function auth($username, $password) {
Please login to merge, or discard this patch.
apps/federation/lib/SyncFederationAddressBooks.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -24,10 +24,6 @@
 block discarded – undo
24 24
 
25 25
 use OCA\DAV\CardDAV\SyncService;
26 26
 use OCP\AppFramework\Http;
27
-use Symfony\Component\Console\Command\Command;
28
-use Symfony\Component\Console\Helper\ProgressBar;
29
-use Symfony\Component\Console\Input\InputInterface;
30
-use Symfony\Component\Console\Output\OutputInterface;
31 27
 
32 28
 class SyncFederationAddressBooks {
33 29
 
Please login to merge, or discard this patch.