Passed
Push — master ( 2cfb9e...6fa55d )
by John
18:21 queued 17s
created
lib/public/AppFramework/Http/Template/ExternalShareMenuAction.php 2 patches
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -66,16 +66,16 @@
 block discarded – undo
66 66
 	 * @since 14.0.0
67 67
 	 */
68 68
 	public function render(): string {
69
-		return '<li>' .
70
-			'    <button id="save-external-share" class="icon ' . Util::sanitizeHTML($this->getIcon()) . '" data-protected="false" data-owner-display-name="' . Util::sanitizeHTML($this->displayname) . '" data-owner="' . Util::sanitizeHTML($this->owner) . '" data-name="' . Util::sanitizeHTML($this->shareName) . '">' . Util::sanitizeHTML($this->getLabel()) . '</button>' .
71
-			'</li>' .
72
-			'<li id="external-share-menu-item" class="hidden">' .
73
-			'    <span class="menuitem">' .
74
-			'        <form class="save-form" action="#">' .
75
-			'            <input type="text" id="remote_address" placeholder="[email protected]">' .
76
-			'            <input type="submit" value=" " id="save-button-confirm" class="icon-confirm" disabled="disabled"></button>' .
77
-			'        </form>' .
78
-			'    </span>' .
69
+		return '<li>'.
70
+			'    <button id="save-external-share" class="icon '.Util::sanitizeHTML($this->getIcon()).'" data-protected="false" data-owner-display-name="'.Util::sanitizeHTML($this->displayname).'" data-owner="'.Util::sanitizeHTML($this->owner).'" data-name="'.Util::sanitizeHTML($this->shareName).'">'.Util::sanitizeHTML($this->getLabel()).'</button>'.
71
+			'</li>'.
72
+			'<li id="external-share-menu-item" class="hidden">'.
73
+			'    <span class="menuitem">'.
74
+			'        <form class="save-form" action="#">'.
75
+			'            <input type="text" id="remote_address" placeholder="[email protected]">'.
76
+			'            <input type="submit" value=" " id="save-button-confirm" class="icon-confirm" disabled="disabled"></button>'.
77
+			'        </form>'.
78
+			'    </span>'.
79 79
 			'</li>';
80 80
 	}
81 81
 }
Please login to merge, or discard this patch.
Indentation   +38 added lines, -38 removed lines patch added patch discarded remove patch
@@ -33,46 +33,46 @@
 block discarded – undo
33 33
  * @since 14.0.0
34 34
  */
35 35
 class ExternalShareMenuAction extends SimpleMenuAction {
36
-	/** @var string */
37
-	private $owner;
36
+    /** @var string */
37
+    private $owner;
38 38
 
39
-	/** @var string */
40
-	private $displayname;
39
+    /** @var string */
40
+    private $displayname;
41 41
 
42
-	/** @var string */
43
-	private $shareName;
42
+    /** @var string */
43
+    private $shareName;
44 44
 
45
-	/**
46
-	 * ExternalShareMenuAction constructor.
47
-	 *
48
-	 * @param string $label
49
-	 * @param string $icon
50
-	 * @param string $owner
51
-	 * @param string $displayname
52
-	 * @param string $shareName
53
-	 * @since 14.0.0
54
-	 */
55
-	public function __construct(string $label, string $icon, string $owner, string $displayname, string $shareName) {
56
-		parent::__construct('save', $label, $icon);
57
-		$this->owner = $owner;
58
-		$this->displayname = $displayname;
59
-		$this->shareName = $shareName;
60
-	}
45
+    /**
46
+     * ExternalShareMenuAction constructor.
47
+     *
48
+     * @param string $label
49
+     * @param string $icon
50
+     * @param string $owner
51
+     * @param string $displayname
52
+     * @param string $shareName
53
+     * @since 14.0.0
54
+     */
55
+    public function __construct(string $label, string $icon, string $owner, string $displayname, string $shareName) {
56
+        parent::__construct('save', $label, $icon);
57
+        $this->owner = $owner;
58
+        $this->displayname = $displayname;
59
+        $this->shareName = $shareName;
60
+    }
61 61
 
62
-	/**
63
-	 * @since 14.0.0
64
-	 */
65
-	public function render(): string {
66
-		return '<li>' .
67
-			'    <button id="save-external-share" class="icon ' . Util::sanitizeHTML($this->getIcon()) . '" data-protected="false" data-owner-display-name="' . Util::sanitizeHTML($this->displayname) . '" data-owner="' . Util::sanitizeHTML($this->owner) . '" data-name="' . Util::sanitizeHTML($this->shareName) . '">' . Util::sanitizeHTML($this->getLabel()) . '</button>' .
68
-			'</li>' .
69
-			'<li id="external-share-menu-item" class="hidden">' .
70
-			'    <span class="menuitem">' .
71
-			'        <form class="save-form" action="#">' .
72
-			'            <input type="text" id="remote_address" placeholder="[email protected]">' .
73
-			'            <input type="submit" value=" " id="save-button-confirm" class="icon-confirm" disabled="disabled"></button>' .
74
-			'        </form>' .
75
-			'    </span>' .
76
-			'</li>';
77
-	}
62
+    /**
63
+     * @since 14.0.0
64
+     */
65
+    public function render(): string {
66
+        return '<li>' .
67
+            '    <button id="save-external-share" class="icon ' . Util::sanitizeHTML($this->getIcon()) . '" data-protected="false" data-owner-display-name="' . Util::sanitizeHTML($this->displayname) . '" data-owner="' . Util::sanitizeHTML($this->owner) . '" data-name="' . Util::sanitizeHTML($this->shareName) . '">' . Util::sanitizeHTML($this->getLabel()) . '</button>' .
68
+            '</li>' .
69
+            '<li id="external-share-menu-item" class="hidden">' .
70
+            '    <span class="menuitem">' .
71
+            '        <form class="save-form" action="#">' .
72
+            '            <input type="text" id="remote_address" placeholder="[email protected]">' .
73
+            '            <input type="submit" value=" " id="save-button-confirm" class="icon-confirm" disabled="disabled"></button>' .
74
+            '        </form>' .
75
+            '    </span>' .
76
+            '</li>';
77
+    }
78 78
 }
Please login to merge, or discard this patch.
apps/workflowengine/lib/Check/FileMimeType.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -155,7 +155,7 @@
 block discarded – undo
155 155
 	}
156 156
 
157 157
 	public function supportedEntities(): array {
158
-		return [ File::class ];
158
+		return [File::class];
159 159
 	}
160 160
 
161 161
 	public function isAvailableForScope(int $scope): bool {
Please login to merge, or discard this patch.
Indentation   +147 added lines, -147 removed lines patch added patch discarded remove patch
@@ -35,151 +35,151 @@
 block discarded – undo
35 35
 use OCP\WorkflowEngine\IFileCheck;
36 36
 
37 37
 class FileMimeType extends AbstractStringCheck implements IFileCheck {
38
-	use TFileCheck {
39
-		setFileInfo as _setFileInfo;
40
-	}
41
-
42
-	/** @var array */
43
-	protected $mimeType;
44
-
45
-	/** @var IRequest */
46
-	protected $request;
47
-
48
-	/** @var IMimeTypeDetector */
49
-	protected $mimeTypeDetector;
50
-
51
-	/**
52
-	 * @param IL10N $l
53
-	 * @param IRequest $request
54
-	 * @param IMimeTypeDetector $mimeTypeDetector
55
-	 */
56
-	public function __construct(IL10N $l, IRequest $request, IMimeTypeDetector $mimeTypeDetector) {
57
-		parent::__construct($l);
58
-		$this->request = $request;
59
-		$this->mimeTypeDetector = $mimeTypeDetector;
60
-	}
61
-
62
-	/**
63
-	 * @param IStorage $storage
64
-	 * @param string $path
65
-	 * @param bool $isDir
66
-	 */
67
-	public function setFileInfo(IStorage $storage, string $path, bool $isDir = false): void {
68
-		$this->_setFileInfo($storage, $path, $isDir);
69
-		if (!isset($this->mimeType[$this->storage->getId()][$this->path])
70
-			|| $this->mimeType[$this->storage->getId()][$this->path] === '') {
71
-			if ($isDir) {
72
-				$this->mimeType[$this->storage->getId()][$this->path] = 'httpd/unix-directory';
73
-			} else {
74
-				$this->mimeType[$this->storage->getId()][$this->path] = null;
75
-			}
76
-		}
77
-	}
78
-
79
-	/**
80
-	 * The mimetype is only cached if the file has a valid mimetype. Otherwise files access
81
-	 * control will cache "application/octet-stream" for all the target node on:
82
-	 * rename, move, copy and all other methods which create a new item
83
-	 *
84
-	 * To check this:
85
-	 * 1. Add an automated tagging rule which tags on mimetype NOT "httpd/unix-directory"
86
-	 * 2. Add an access control rule which checks for any mimetype
87
-	 * 3. Create a folder and rename it, the folder should not be tagged, but it is
88
-	 *
89
-	 * @param string $storageId
90
-	 * @param string|null $path
91
-	 * @param string $mimeType
92
-	 * @return string
93
-	 */
94
-	protected function cacheAndReturnMimeType(string $storageId, ?string $path, string $mimeType): string {
95
-		if ($path !== null && $mimeType !== 'application/octet-stream') {
96
-			$this->mimeType[$storageId][$path] = $mimeType;
97
-		}
98
-
99
-		return $mimeType;
100
-	}
101
-
102
-	/**
103
-	 * Make sure that even though the content based check returns an application/octet-stream can still be checked based on mimetypemappings of their extension
104
-	 *
105
-	 * @param string $operator
106
-	 * @param string $value
107
-	 * @return bool
108
-	 */
109
-	public function executeCheck($operator, $value) {
110
-		$actualValue = $this->getActualValue();
111
-		$plainMimetypeResult = $this->executeStringCheck($operator, $value, $actualValue);
112
-		if ($actualValue === 'httpd/unix-directory') {
113
-			return $plainMimetypeResult;
114
-		}
115
-		$detectMimetypeBasedOnFilenameResult = $this->executeStringCheck($operator, $value, $this->mimeTypeDetector->detectPath($this->path));
116
-		return $plainMimetypeResult || $detectMimetypeBasedOnFilenameResult;
117
-	}
118
-
119
-	/**
120
-	 * @return string
121
-	 */
122
-	protected function getActualValue() {
123
-		if ($this->mimeType[$this->storage->getId()][$this->path] !== null) {
124
-			return $this->mimeType[$this->storage->getId()][$this->path];
125
-		}
126
-		$cacheEntry = $this->storage->getCache()->get($this->path);
127
-		if ($cacheEntry && $cacheEntry->getMimeType() !== 'application/octet-stream') {
128
-			return $this->cacheAndReturnMimeType($this->storage->getId(), $this->path, $cacheEntry->getMimeType());
129
-		}
130
-
131
-		if ($this->storage->file_exists($this->path) &&
132
-			$this->storage->filesize($this->path) &&
133
-			$this->storage->instanceOfStorage(Local::class)
134
-		) {
135
-			$path = $this->storage->getLocalFile($this->path);
136
-			$mimeType = $this->mimeTypeDetector->detectContent($path);
137
-			return $this->cacheAndReturnMimeType($this->storage->getId(), $this->path, $mimeType);
138
-		}
139
-
140
-		if ($this->isWebDAVRequest() || $this->isPublicWebDAVRequest()) {
141
-			// Creating a folder
142
-			if ($this->request->getMethod() === 'MKCOL') {
143
-				return 'httpd/unix-directory';
144
-			}
145
-		}
146
-
147
-		// We do not cache this, as the file did not exist yet.
148
-		// In case it does in the future, we will check with detectContent()
149
-		// again to get the real mimetype of the content, rather than
150
-		// guessing it from the path.
151
-		return $this->mimeTypeDetector->detectPath($this->path);
152
-	}
153
-
154
-	/**
155
-	 * @return bool
156
-	 */
157
-	protected function isWebDAVRequest() {
158
-		return substr($this->request->getScriptName(), 0 - strlen('/remote.php')) === '/remote.php' && (
159
-			$this->request->getPathInfo() === '/webdav' ||
160
-			strpos($this->request->getPathInfo(), '/webdav/') === 0 ||
161
-			$this->request->getPathInfo() === '/dav/files' ||
162
-			strpos($this->request->getPathInfo(), '/dav/files/') === 0 ||
163
-			$this->request->getPathInfo() === '/dav/uploads' ||
164
-			strpos($this->request->getPathInfo(), '/dav/uploads/') === 0
165
-		);
166
-	}
167
-
168
-	/**
169
-	 * @return bool
170
-	 */
171
-	protected function isPublicWebDAVRequest() {
172
-		return substr($this->request->getScriptName(), 0 - strlen('/public.php')) === '/public.php' && (
173
-			$this->request->getPathInfo() === '/webdav' ||
174
-			strpos($this->request->getPathInfo(), '/webdav/') === 0
175
-		);
176
-	}
177
-
178
-	public function supportedEntities(): array {
179
-		return [ File::class ];
180
-	}
181
-
182
-	public function isAvailableForScope(int $scope): bool {
183
-		return true;
184
-	}
38
+    use TFileCheck {
39
+        setFileInfo as _setFileInfo;
40
+    }
41
+
42
+    /** @var array */
43
+    protected $mimeType;
44
+
45
+    /** @var IRequest */
46
+    protected $request;
47
+
48
+    /** @var IMimeTypeDetector */
49
+    protected $mimeTypeDetector;
50
+
51
+    /**
52
+     * @param IL10N $l
53
+     * @param IRequest $request
54
+     * @param IMimeTypeDetector $mimeTypeDetector
55
+     */
56
+    public function __construct(IL10N $l, IRequest $request, IMimeTypeDetector $mimeTypeDetector) {
57
+        parent::__construct($l);
58
+        $this->request = $request;
59
+        $this->mimeTypeDetector = $mimeTypeDetector;
60
+    }
61
+
62
+    /**
63
+     * @param IStorage $storage
64
+     * @param string $path
65
+     * @param bool $isDir
66
+     */
67
+    public function setFileInfo(IStorage $storage, string $path, bool $isDir = false): void {
68
+        $this->_setFileInfo($storage, $path, $isDir);
69
+        if (!isset($this->mimeType[$this->storage->getId()][$this->path])
70
+            || $this->mimeType[$this->storage->getId()][$this->path] === '') {
71
+            if ($isDir) {
72
+                $this->mimeType[$this->storage->getId()][$this->path] = 'httpd/unix-directory';
73
+            } else {
74
+                $this->mimeType[$this->storage->getId()][$this->path] = null;
75
+            }
76
+        }
77
+    }
78
+
79
+    /**
80
+     * The mimetype is only cached if the file has a valid mimetype. Otherwise files access
81
+     * control will cache "application/octet-stream" for all the target node on:
82
+     * rename, move, copy and all other methods which create a new item
83
+     *
84
+     * To check this:
85
+     * 1. Add an automated tagging rule which tags on mimetype NOT "httpd/unix-directory"
86
+     * 2. Add an access control rule which checks for any mimetype
87
+     * 3. Create a folder and rename it, the folder should not be tagged, but it is
88
+     *
89
+     * @param string $storageId
90
+     * @param string|null $path
91
+     * @param string $mimeType
92
+     * @return string
93
+     */
94
+    protected function cacheAndReturnMimeType(string $storageId, ?string $path, string $mimeType): string {
95
+        if ($path !== null && $mimeType !== 'application/octet-stream') {
96
+            $this->mimeType[$storageId][$path] = $mimeType;
97
+        }
98
+
99
+        return $mimeType;
100
+    }
101
+
102
+    /**
103
+     * Make sure that even though the content based check returns an application/octet-stream can still be checked based on mimetypemappings of their extension
104
+     *
105
+     * @param string $operator
106
+     * @param string $value
107
+     * @return bool
108
+     */
109
+    public function executeCheck($operator, $value) {
110
+        $actualValue = $this->getActualValue();
111
+        $plainMimetypeResult = $this->executeStringCheck($operator, $value, $actualValue);
112
+        if ($actualValue === 'httpd/unix-directory') {
113
+            return $plainMimetypeResult;
114
+        }
115
+        $detectMimetypeBasedOnFilenameResult = $this->executeStringCheck($operator, $value, $this->mimeTypeDetector->detectPath($this->path));
116
+        return $plainMimetypeResult || $detectMimetypeBasedOnFilenameResult;
117
+    }
118
+
119
+    /**
120
+     * @return string
121
+     */
122
+    protected function getActualValue() {
123
+        if ($this->mimeType[$this->storage->getId()][$this->path] !== null) {
124
+            return $this->mimeType[$this->storage->getId()][$this->path];
125
+        }
126
+        $cacheEntry = $this->storage->getCache()->get($this->path);
127
+        if ($cacheEntry && $cacheEntry->getMimeType() !== 'application/octet-stream') {
128
+            return $this->cacheAndReturnMimeType($this->storage->getId(), $this->path, $cacheEntry->getMimeType());
129
+        }
130
+
131
+        if ($this->storage->file_exists($this->path) &&
132
+            $this->storage->filesize($this->path) &&
133
+            $this->storage->instanceOfStorage(Local::class)
134
+        ) {
135
+            $path = $this->storage->getLocalFile($this->path);
136
+            $mimeType = $this->mimeTypeDetector->detectContent($path);
137
+            return $this->cacheAndReturnMimeType($this->storage->getId(), $this->path, $mimeType);
138
+        }
139
+
140
+        if ($this->isWebDAVRequest() || $this->isPublicWebDAVRequest()) {
141
+            // Creating a folder
142
+            if ($this->request->getMethod() === 'MKCOL') {
143
+                return 'httpd/unix-directory';
144
+            }
145
+        }
146
+
147
+        // We do not cache this, as the file did not exist yet.
148
+        // In case it does in the future, we will check with detectContent()
149
+        // again to get the real mimetype of the content, rather than
150
+        // guessing it from the path.
151
+        return $this->mimeTypeDetector->detectPath($this->path);
152
+    }
153
+
154
+    /**
155
+     * @return bool
156
+     */
157
+    protected function isWebDAVRequest() {
158
+        return substr($this->request->getScriptName(), 0 - strlen('/remote.php')) === '/remote.php' && (
159
+            $this->request->getPathInfo() === '/webdav' ||
160
+            strpos($this->request->getPathInfo(), '/webdav/') === 0 ||
161
+            $this->request->getPathInfo() === '/dav/files' ||
162
+            strpos($this->request->getPathInfo(), '/dav/files/') === 0 ||
163
+            $this->request->getPathInfo() === '/dav/uploads' ||
164
+            strpos($this->request->getPathInfo(), '/dav/uploads/') === 0
165
+        );
166
+    }
167
+
168
+    /**
169
+     * @return bool
170
+     */
171
+    protected function isPublicWebDAVRequest() {
172
+        return substr($this->request->getScriptName(), 0 - strlen('/public.php')) === '/public.php' && (
173
+            $this->request->getPathInfo() === '/webdav' ||
174
+            strpos($this->request->getPathInfo(), '/webdav/') === 0
175
+        );
176
+    }
177
+
178
+    public function supportedEntities(): array {
179
+        return [ File::class ];
180
+    }
181
+
182
+    public function isAvailableForScope(int $scope): bool {
183
+        return true;
184
+    }
185 185
 }
Please login to merge, or discard this patch.
apps/settings/lib/Sections/Admin/Groupware.php 1 patch
Indentation   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -30,30 +30,30 @@
 block discarded – undo
30 30
 
31 31
 class Groupware implements IIconSection {
32 32
 
33
-	/** @var IL10N */
34
-	private $l;
33
+    /** @var IL10N */
34
+    private $l;
35 35
 
36
-	/** @var IURLGenerator */
37
-	private $urlGenerator;
36
+    /** @var IURLGenerator */
37
+    private $urlGenerator;
38 38
 
39
-	public function __construct(IL10N $l, IURLGenerator $urlGenerator) {
40
-		$this->l = $l;
41
-		$this->urlGenerator = $urlGenerator;
42
-	}
39
+    public function __construct(IL10N $l, IURLGenerator $urlGenerator) {
40
+        $this->l = $l;
41
+        $this->urlGenerator = $urlGenerator;
42
+    }
43 43
 
44
-	public function getIcon(): string {
45
-		return $this->urlGenerator->imagePath('core', 'places/contacts.svg');
46
-	}
44
+    public function getIcon(): string {
45
+        return $this->urlGenerator->imagePath('core', 'places/contacts.svg');
46
+    }
47 47
 
48
-	public function getID(): string {
49
-		return 'groupware';
50
-	}
48
+    public function getID(): string {
49
+        return 'groupware';
50
+    }
51 51
 
52
-	public function getName(): string {
53
-		return $this->l->t('Groupware');
54
-	}
52
+    public function getName(): string {
53
+        return $this->l->t('Groupware');
54
+    }
55 55
 
56
-	public function getPriority(): int {
57
-		return 50;
58
-	}
56
+    public function getPriority(): int {
57
+        return 50;
58
+    }
59 59
 }
Please login to merge, or discard this patch.
apps/settings/lib/Sections/Admin/Additional.php 1 patch
Indentation   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -30,30 +30,30 @@
 block discarded – undo
30 30
 
31 31
 class Additional implements IIconSection {
32 32
 
33
-	/** @var IL10N */
34
-	private $l;
33
+    /** @var IL10N */
34
+    private $l;
35 35
 
36
-	/** @var IURLGenerator */
37
-	private $urlGenerator;
36
+    /** @var IURLGenerator */
37
+    private $urlGenerator;
38 38
 
39
-	public function __construct(IL10N $l, IURLGenerator $urlGenerator) {
40
-		$this->l = $l;
41
-		$this->urlGenerator = $urlGenerator;
42
-	}
39
+    public function __construct(IL10N $l, IURLGenerator $urlGenerator) {
40
+        $this->l = $l;
41
+        $this->urlGenerator = $urlGenerator;
42
+    }
43 43
 
44
-	public function getIcon(): string {
45
-		return $this->urlGenerator->imagePath('core', 'actions/settings-dark.svg');
46
-	}
44
+    public function getIcon(): string {
45
+        return $this->urlGenerator->imagePath('core', 'actions/settings-dark.svg');
46
+    }
47 47
 
48
-	public function getID(): string {
49
-		return 'additional';
50
-	}
48
+    public function getID(): string {
49
+        return 'additional';
50
+    }
51 51
 
52
-	public function getName(): string {
53
-		return $this->l->t('Additional settings');
54
-	}
52
+    public function getName(): string {
53
+        return $this->l->t('Additional settings');
54
+    }
55 55
 
56
-	public function getPriority(): int {
57
-		return 98;
58
-	}
56
+    public function getPriority(): int {
57
+        return 98;
58
+    }
59 59
 }
Please login to merge, or discard this patch.
apps/settings/lib/Sections/Admin/Sharing.php 1 patch
Indentation   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -30,30 +30,30 @@
 block discarded – undo
30 30
 
31 31
 class Sharing implements IIconSection {
32 32
 
33
-	/** @var IL10N */
34
-	private $l;
33
+    /** @var IL10N */
34
+    private $l;
35 35
 
36
-	/** @var IURLGenerator */
37
-	private $urlGenerator;
36
+    /** @var IURLGenerator */
37
+    private $urlGenerator;
38 38
 
39
-	public function __construct(IL10N $l, IURLGenerator $urlGenerator) {
40
-		$this->l = $l;
41
-		$this->urlGenerator = $urlGenerator;
42
-	}
39
+    public function __construct(IL10N $l, IURLGenerator $urlGenerator) {
40
+        $this->l = $l;
41
+        $this->urlGenerator = $urlGenerator;
42
+    }
43 43
 
44
-	public function getIcon(): string {
45
-		return $this->urlGenerator->imagePath('core', 'actions/share.svg');
46
-	}
44
+    public function getIcon(): string {
45
+        return $this->urlGenerator->imagePath('core', 'actions/share.svg');
46
+    }
47 47
 
48
-	public function getID(): string {
49
-		return 'sharing';
50
-	}
48
+    public function getID(): string {
49
+        return 'sharing';
50
+    }
51 51
 
52
-	public function getName(): string {
53
-		return $this->l->t('Sharing');
54
-	}
52
+    public function getName(): string {
53
+        return $this->l->t('Sharing');
54
+    }
55 55
 
56
-	public function getPriority(): int {
57
-		return 5;
58
-	}
56
+    public function getPriority(): int {
57
+        return 5;
58
+    }
59 59
 }
Please login to merge, or discard this patch.
apps/settings/lib/Sections/Admin/Security.php 1 patch
Indentation   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -30,30 +30,30 @@
 block discarded – undo
30 30
 
31 31
 class Security implements IIconSection {
32 32
 
33
-	/** @var IL10N */
34
-	private $l;
33
+    /** @var IL10N */
34
+    private $l;
35 35
 
36
-	/** @var IURLGenerator */
37
-	private $urlGenerator;
36
+    /** @var IURLGenerator */
37
+    private $urlGenerator;
38 38
 
39
-	public function __construct(IL10N $l, IURLGenerator $urlGenerator) {
40
-		$this->l = $l;
41
-		$this->urlGenerator = $urlGenerator;
42
-	}
39
+    public function __construct(IL10N $l, IURLGenerator $urlGenerator) {
40
+        $this->l = $l;
41
+        $this->urlGenerator = $urlGenerator;
42
+    }
43 43
 
44
-	public function getIcon(): string {
45
-		return $this->urlGenerator->imagePath('core', 'actions/password.svg');
46
-	}
44
+    public function getIcon(): string {
45
+        return $this->urlGenerator->imagePath('core', 'actions/password.svg');
46
+    }
47 47
 
48
-	public function getID(): string {
49
-		return 'security';
50
-	}
48
+    public function getID(): string {
49
+        return 'security';
50
+    }
51 51
 
52
-	public function getName(): string {
53
-		return $this->l->t('Security');
54
-	}
52
+    public function getName(): string {
53
+        return $this->l->t('Security');
54
+    }
55 55
 
56
-	public function getPriority(): int {
57
-		return 10;
58
-	}
56
+    public function getPriority(): int {
57
+        return 10;
58
+    }
59 59
 }
Please login to merge, or discard this patch.
apps/settings/lib/Sections/Admin/Server.php 1 patch
Indentation   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -30,30 +30,30 @@
 block discarded – undo
30 30
 
31 31
 class Server implements IIconSection {
32 32
 
33
-	/** @var IL10N */
34
-	private $l;
33
+    /** @var IL10N */
34
+    private $l;
35 35
 
36
-	/** @var IURLGenerator */
37
-	private $urlGenerator;
36
+    /** @var IURLGenerator */
37
+    private $urlGenerator;
38 38
 
39
-	public function __construct(IL10N $l, IURLGenerator $urlGenerator) {
40
-		$this->l = $l;
41
-		$this->urlGenerator = $urlGenerator;
42
-	}
39
+    public function __construct(IL10N $l, IURLGenerator $urlGenerator) {
40
+        $this->l = $l;
41
+        $this->urlGenerator = $urlGenerator;
42
+    }
43 43
 
44
-	public function getIcon(): string {
45
-		return $this->urlGenerator->imagePath('core', 'actions/settings-dark.svg');
46
-	}
44
+    public function getIcon(): string {
45
+        return $this->urlGenerator->imagePath('core', 'actions/settings-dark.svg');
46
+    }
47 47
 
48
-	public function getID(): string {
49
-		return 'server';
50
-	}
48
+    public function getID(): string {
49
+        return 'server';
50
+    }
51 51
 
52
-	public function getName(): string {
53
-		return $this->l->t('Basic settings');
54
-	}
52
+    public function getName(): string {
53
+        return $this->l->t('Basic settings');
54
+    }
55 55
 
56
-	public function getPriority(): int {
57
-		return 1;
58
-	}
56
+    public function getPriority(): int {
57
+        return 1;
58
+    }
59 59
 }
Please login to merge, or discard this patch.
apps/settings/lib/Sections/Admin/Overview.php 1 patch
Indentation   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -30,30 +30,30 @@
 block discarded – undo
30 30
 
31 31
 class Overview implements IIconSection {
32 32
 
33
-	/** @var IL10N */
34
-	private $l;
33
+    /** @var IL10N */
34
+    private $l;
35 35
 
36
-	/** @var IURLGenerator */
37
-	private $urlGenerator;
36
+    /** @var IURLGenerator */
37
+    private $urlGenerator;
38 38
 
39
-	public function __construct(IL10N $l, IURLGenerator $urlGenerator) {
40
-		$this->l = $l;
41
-		$this->urlGenerator = $urlGenerator;
42
-	}
39
+    public function __construct(IL10N $l, IURLGenerator $urlGenerator) {
40
+        $this->l = $l;
41
+        $this->urlGenerator = $urlGenerator;
42
+    }
43 43
 
44
-	public function getIcon(): string {
45
-		return $this->urlGenerator->imagePath('settings', 'admin.svg');
46
-	}
44
+    public function getIcon(): string {
45
+        return $this->urlGenerator->imagePath('settings', 'admin.svg');
46
+    }
47 47
 
48
-	public function getID(): string {
49
-		return 'overview';
50
-	}
48
+    public function getID(): string {
49
+        return 'overview';
50
+    }
51 51
 
52
-	public function getName(): string {
53
-		return $this->l->t('Overview');
54
-	}
52
+    public function getName(): string {
53
+        return $this->l->t('Overview');
54
+    }
55 55
 
56
-	public function getPriority(): int {
57
-		return 0;
58
-	}
56
+    public function getPriority(): int {
57
+        return 0;
58
+    }
59 59
 }
Please login to merge, or discard this patch.
apps/settings/lib/Sections/Personal/SyncClients.php 1 patch
Indentation   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -30,30 +30,30 @@
 block discarded – undo
30 30
 
31 31
 class SyncClients implements IIconSection {
32 32
 
33
-	/** @var IL10N */
34
-	private $l;
33
+    /** @var IL10N */
34
+    private $l;
35 35
 
36
-	/** @var IURLGenerator */
37
-	private $urlGenerator;
36
+    /** @var IURLGenerator */
37
+    private $urlGenerator;
38 38
 
39
-	public function __construct(IL10N $l, IURLGenerator $urlGenerator) {
40
-		$this->l = $l;
41
-		$this->urlGenerator = $urlGenerator;
42
-	}
39
+    public function __construct(IL10N $l, IURLGenerator $urlGenerator) {
40
+        $this->l = $l;
41
+        $this->urlGenerator = $urlGenerator;
42
+    }
43 43
 
44
-	public function getIcon() {
45
-		return $this->urlGenerator->imagePath('core', 'clients/phone.svg');
46
-	}
44
+    public function getIcon() {
45
+        return $this->urlGenerator->imagePath('core', 'clients/phone.svg');
46
+    }
47 47
 
48
-	public function getID(): string {
49
-		return 'sync-clients';
50
-	}
48
+    public function getID(): string {
49
+        return 'sync-clients';
50
+    }
51 51
 
52
-	public function getName(): string {
53
-		return $this->l->t('Mobile & desktop');
54
-	}
52
+    public function getName(): string {
53
+        return $this->l->t('Mobile & desktop');
54
+    }
55 55
 
56
-	public function getPriority(): int {
57
-		return 15;
58
-	}
56
+    public function getPriority(): int {
57
+        return 15;
58
+    }
59 59
 }
Please login to merge, or discard this patch.