Passed
Push — master ( 24e25a...d3efd4 )
by Joas
29:31 queued 13:57
created
lib/public/AppFramework/Db/Entity.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 		$instance = new static();
52 52
 
53 53
 		foreach ($params as $key => $value) {
54
-			$method = 'set' . ucfirst($key);
54
+			$method = 'set'.ucfirst($key);
55 55
 			$instance->$method($value);
56 56
 		}
57 57
 
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 
70 70
 		foreach ($row as $key => $value) {
71 71
 			$prop = ucfirst($instance->columnToProperty($key));
72
-			$setter = 'set' . $prop;
72
+			$setter = 'set'.$prop;
73 73
 			$instance->$setter($value);
74 74
 		}
75 75
 
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 			}
115 115
 			$this->$name = $args[0];
116 116
 		} else {
117
-			throw new \BadFunctionCallException($name .
117
+			throw new \BadFunctionCallException($name.
118 118
 				' is not a valid attribute');
119 119
 		}
120 120
 	}
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 		if (property_exists($this, $name)) {
129 129
 			return $this->$name;
130 130
 		} else {
131
-			throw new \BadFunctionCallException($name .
131
+			throw new \BadFunctionCallException($name.
132 132
 				' is not a valid attribute');
133 133
 		}
134 134
 	}
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 		} elseif ($this->isGetterForBoolProperty($methodName)) {
150 150
 			return $this->getter(lcfirst(substr($methodName, 2)));
151 151
 		} else {
152
-			throw new \BadFunctionCallException($methodName .
152
+			throw new \BadFunctionCallException($methodName.
153 153
 				' does not exist');
154 154
 		}
155 155
 	}
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
 			if ($column === null) {
214 214
 				$column = $part;
215 215
 			} else {
216
-				$column .= '_' . lcfirst($part);
216
+				$column .= '_'.lcfirst($part);
217 217
 			}
218 218
 		}
219 219
 
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 			// trim '-'
260 260
 			return trim($value, '-');
261 261
 		} else {
262
-			throw new \BadFunctionCallException($attributeName .
262
+			throw new \BadFunctionCallException($attributeName.
263 263
 				' is not a valid attribute');
264 264
 		}
265 265
 	}
Please login to merge, or discard this patch.
lib/private/IntegrityCheck/Helpers/FileAccessHelper.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 	public function file_put_contents(string $filename, string $data): int {
66 66
 		$bytesWritten = @file_put_contents($filename, $data);
67 67
 		if ($bytesWritten === false || $bytesWritten !== \strlen($data)) {
68
-			throw new \Exception('Failed to write into ' . $filename);
68
+			throw new \Exception('Failed to write into '.$filename);
69 69
 		}
70 70
 		return $bytesWritten;
71 71
 	}
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 	 */
85 85
 	public function assertDirectoryExists(string $path) {
86 86
 		if (!is_dir($path)) {
87
-			throw new \Exception('Directory ' . $path . ' does not exist.');
87
+			throw new \Exception('Directory '.$path.' does not exist.');
88 88
 		}
89 89
 	}
90 90
 }
Please login to merge, or discard this patch.
lib/private/Encryption/DecryptAll.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 		$this->output = $output;
88 88
 
89 89
 		if ($user !== '' && $this->userManager->userExists($user) === false) {
90
-			$this->output->writeln('User "' . $user . '" does not exist. Please check the username and try again');
90
+			$this->output->writeln('User "'.$user.'" does not exist. Please check the username and try again');
91 91
 			return false;
92 92
 		}
93 93
 
@@ -105,9 +105,9 @@  discard block
 block discarded – undo
105 105
 			$this->output->writeln('Files for following users couldn\'t be decrypted, ');
106 106
 			$this->output->writeln('maybe the user is not set up in a way that supports this operation: ');
107 107
 			foreach ($this->failed as $uid => $paths) {
108
-				$this->output->writeln('    ' . $uid);
108
+				$this->output->writeln('    '.$uid);
109 109
 				foreach ($paths as $path) {
110
-					$this->output->writeln('        ' . $path);
110
+					$this->output->writeln('        '.$path);
111 111
 				}
112 112
 			}
113 113
 			$this->output->writeln('');
@@ -129,10 +129,10 @@  discard block
 block discarded – undo
129 129
 			/** @var IEncryptionModule $module */
130 130
 			$module = call_user_func($moduleDesc['callback']);
131 131
 			$this->output->writeln('');
132
-			$this->output->writeln('Prepare "' . $module->getDisplayName() . '"');
132
+			$this->output->writeln('Prepare "'.$module->getDisplayName().'"');
133 133
 			$this->output->writeln('');
134 134
 			if ($module->prepareDecryptAll($this->input, $this->output, $user) === false) {
135
-				$this->output->writeln('Module "' . $moduleDesc['displayName'] . '" does not support the functionality to decrypt all files again or the initialization of the module failed!');
135
+				$this->output->writeln('Module "'.$moduleDesc['displayName'].'" does not support the functionality to decrypt all files again or the initialization of the module failed!');
136 136
 				return false;
137 137
 			}
138 138
 		}
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 	protected function decryptUsersFiles($uid, ProgressBar $progress, $userCount) {
207 207
 		$this->setupUserFS($uid);
208 208
 		$directories = [];
209
-		$directories[] = '/' . $uid . '/files';
209
+		$directories[] = '/'.$uid.'/files';
210 210
 
211 211
 		while ($root = array_pop($directories)) {
212 212
 			$content = $this->rootView->getDirectoryContent($root);
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
 				if ($file->getStorage()->instanceOfStorage('OCA\Files_Sharing\SharedStorage')) {
216 216
 					continue;
217 217
 				}
218
-				$path = $root . '/' . $file['name'];
218
+				$path = $root.'/'.$file['name'];
219 219
 				if ($this->rootView->is_dir($path)) {
220 220
 					$directories[] = $path;
221 221
 					continue;
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 		}
260 260
 
261 261
 		$source = $path;
262
-		$target = $path . '.decrypted.' . $this->getTimestamp();
262
+		$target = $path.'.decrypted.'.$this->getTimestamp();
263 263
 
264 264
 		try {
265 265
 			$this->rootView->copy($source, $target);
Please login to merge, or discard this patch.
lib/private/MemoryInfo.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 		if ($iniValue === '-1') {
53 53
 			return -1;
54 54
 		} elseif (is_numeric($iniValue) === true) {
55
-			return (int)$iniValue;
55
+			return (int) $iniValue;
56 56
 		} else {
57 57
 			return $this->memoryLimitToBytes($iniValue);
58 58
 		}
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	 */
67 67
 	private function memoryLimitToBytes(string $memoryLimit): int {
68 68
 		$last = strtolower(substr($memoryLimit, -1));
69
-		$memoryLimit = (int)substr($memoryLimit, 0, -1);
69
+		$memoryLimit = (int) substr($memoryLimit, 0, -1);
70 70
 
71 71
 		// intended fall trough
72 72
 		switch ($last) {
Please login to merge, or discard this patch.
lib/private/Log/Rotate.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
 
39 39
 	public function run($dummy) {
40 40
 		$systemConfig = \OC::$server->getSystemConfig();
41
-		$this->filePath = $systemConfig->getValue('logfile', $systemConfig->getValue('datadirectory', \OC::$SERVERROOT . '/data') . '/nextcloud.log');
41
+		$this->filePath = $systemConfig->getValue('logfile', $systemConfig->getValue('datadirectory', \OC::$SERVERROOT.'/data').'/nextcloud.log');
42 42
 
43 43
 		$this->maxSize = \OC::$server->getConfig()->getSystemValue('log_rotate_size', 100 * 1024 * 1024);
44 44
 		if ($this->shouldRotateBySize()) {
Please login to merge, or discard this patch.
lib/private/Log/Systemdlog.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,6 +76,6 @@
 block discarded – undo
76 76
 		$journal_level = $this->levels[$level];
77 77
 		sd_journal_send('PRIORITY='.$journal_level,
78 78
 				'SYSLOG_IDENTIFIER='.$this->syslogId,
79
-				'MESSAGE=' . $this->logDetailsAsJSON($app, $message, $level));
79
+				'MESSAGE='.$this->logDetailsAsJSON($app, $message, $level));
80 80
 	}
81 81
 }
Please login to merge, or discard this patch.
lib/private/Avatar/UserAvatar.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 
105 105
 		$this->remove(true);
106 106
 		$type = $this->getAvatarImageType($img);
107
-		$file = $this->folder->newFile('avatar.' . $type);
107
+		$file = $this->folder->newFile('avatar.'.$type);
108 108
 		$file->putContent($data);
109 109
 
110 110
 		try {
@@ -257,9 +257,9 @@  discard block
 block discarded – undo
257 257
 		}
258 258
 
259 259
 		if ($size === -1) {
260
-			$path = 'avatar.' . $ext;
260
+			$path = 'avatar.'.$ext;
261 261
 		} else {
262
-			$path = 'avatar.' . $size . '.' . $ext;
262
+			$path = 'avatar.'.$size.'.'.$ext;
263 263
 		}
264 264
 
265 265
 		try {
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
 				}
276 276
 			} else {
277 277
 				$avatar = new OC_Image();
278
-				$file = $this->folder->getFile('avatar.' . $ext);
278
+				$file = $this->folder->getFile('avatar.'.$ext);
279 279
 				$avatar->loadFromData($file->getContent());
280 280
 				$avatar->resize($size);
281 281
 				$data = $avatar->data();
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
 				$file = $this->folder->newFile($path);
286 286
 				$file->putContent($data);
287 287
 			} catch (NotPermittedException $e) {
288
-				$this->logger->error('Failed to save avatar for ' . $this->user->getUID());
288
+				$this->logger->error('Failed to save avatar for '.$this->user->getUID());
289 289
 				throw new NotFoundException();
290 290
 			}
291 291
 		}
Please login to merge, or discard this patch.
lib/private/Security/IdentityProof/Manager.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 	 */
145 145
 	public function getKey(IUser $user): Key {
146 146
 		$uid = $user->getUID();
147
-		return $this->retrieveKey('user-' . $uid);
147
+		return $this->retrieveKey('user-'.$uid);
148 148
 	}
149 149
 
150 150
 	/**
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 		if ($instanceId === null) {
159 159
 			throw new \RuntimeException('no instance id!');
160 160
 		}
161
-		return $this->retrieveKey('system-' . $instanceId);
161
+		return $this->retrieveKey('system-'.$instanceId);
162 162
 	}
163 163
 
164 164
 	private function logOpensslError(): void {
@@ -166,6 +166,6 @@  discard block
 block discarded – undo
166 166
 		while ($error = openssl_error_string()) {
167 167
 			$errors[] = $error;
168 168
 		}
169
-		$this->logger->critical('Something is wrong with your openssl setup: ' . implode(', ', $errors));
169
+		$this->logger->critical('Something is wrong with your openssl setup: '.implode(', ', $errors));
170 170
 	}
171 171
 }
Please login to merge, or discard this patch.
lib/private/Security/CSRF/CsrfToken.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
 	public function getEncryptedValue(): string {
58 58
 		if ($this->encryptedValue === '') {
59 59
 			$sharedSecret = random_bytes(\strlen($this->value));
60
-			$this->encryptedValue = base64_encode($this->value ^ $sharedSecret) . ':' . base64_encode($sharedSecret);
60
+			$this->encryptedValue = base64_encode($this->value ^ $sharedSecret).':'.base64_encode($sharedSecret);
61 61
 		}
62 62
 
63 63
 		return $this->encryptedValue;
Please login to merge, or discard this patch.