Completed
Pull Request — master (#5231)
by Morris
16:38
created
apps/files_external/lib/Command/Import.php 1 patch
Indentation   +183 added lines, -183 removed lines patch added patch discarded remove patch
@@ -39,187 +39,187 @@
 block discarded – undo
39 39
 use Symfony\Component\Console\Output\OutputInterface;
40 40
 
41 41
 class Import extends Base {
42
-	/**
43
-	 * @var GlobalStoragesService
44
-	 */
45
-	private $globalService;
46
-
47
-	/**
48
-	 * @var UserStoragesService
49
-	 */
50
-	private $userService;
51
-
52
-	/**
53
-	 * @var IUserSession
54
-	 */
55
-	private $userSession;
56
-
57
-	/**
58
-	 * @var IUserManager
59
-	 */
60
-	private $userManager;
61
-
62
-	/** @var ImportLegacyStoragesService */
63
-	private $importLegacyStorageService;
64
-
65
-	/** @var BackendService */
66
-	private $backendService;
67
-
68
-	function __construct(GlobalStoragesService $globalService,
69
-						 UserStoragesService $userService,
70
-						 IUserSession $userSession,
71
-						 IUserManager $userManager,
72
-						 ImportLegacyStoragesService $importLegacyStorageService,
73
-						 BackendService $backendService
74
-	) {
75
-		parent::__construct();
76
-		$this->globalService = $globalService;
77
-		$this->userService = $userService;
78
-		$this->userSession = $userSession;
79
-		$this->userManager = $userManager;
80
-		$this->importLegacyStorageService = $importLegacyStorageService;
81
-		$this->backendService = $backendService;
82
-	}
83
-
84
-	protected function configure() {
85
-		$this
86
-			->setName('files_external:import')
87
-			->setDescription('Import mount configurations')
88
-			->addOption(
89
-				'user',
90
-				null,
91
-				InputOption::VALUE_OPTIONAL,
92
-				'user to add the mount configurations for, if not set the mount will be added as system mount'
93
-			)
94
-			->addArgument(
95
-				'path',
96
-				InputArgument::REQUIRED,
97
-				'path to a json file containing the mounts to import, use "-" to read from stdin'
98
-			)
99
-			->addOption(
100
-				'dry',
101
-				null,
102
-				InputOption::VALUE_NONE,
103
-				'Don\'t save the imported mounts, only list the new mounts'
104
-			);
105
-		parent::configure();
106
-	}
107
-
108
-	protected function execute(InputInterface $input, OutputInterface $output) {
109
-		$user = $input->getOption('user');
110
-		$path = $input->getArgument('path');
111
-		if ($path === '-') {
112
-			$json = file_get_contents('php://stdin');
113
-		} else {
114
-			if (!file_exists($path)) {
115
-				$output->writeln('<error>File not found: ' . $path . '</error>');
116
-				return 1;
117
-			}
118
-			$json = file_get_contents($path);
119
-		}
120
-		if (!is_string($json) || strlen($json) < 2) {
121
-			$output->writeln('<error>Error while reading json</error>');
122
-			return 1;
123
-		}
124
-		$data = json_decode($json, true);
125
-		if (!is_array($data)) {
126
-			$output->writeln('<error>Error while parsing json</error>');
127
-			return 1;
128
-		}
129
-
130
-		$isLegacy = isset($data['user']) || isset($data['group']);
131
-		if ($isLegacy) {
132
-			$this->importLegacyStorageService->setData($data);
133
-			$mounts = $this->importLegacyStorageService->getAllStorages();
134
-			foreach ($mounts as $mount) {
135
-				if ($mount->getBackendOption('password') === false) {
136
-					$output->writeln('<error>Failed to decrypt password</error>');
137
-					return 1;
138
-				}
139
-			}
140
-		} else {
141
-			if (!isset($data[0])) { //normalize to an array of mounts
142
-				$data = [$data];
143
-			}
144
-			$mounts = array_map([$this, 'parseData'], $data);
145
-		}
146
-
147
-		if ($user) {
148
-			// ensure applicables are correct for personal mounts
149
-			foreach ($mounts as $mount) {
150
-				$mount->setApplicableGroups([]);
151
-				$mount->setApplicableUsers([$user]);
152
-			}
153
-		}
154
-
155
-		$storageService = $this->getStorageService($user);
156
-
157
-		$existingMounts = $storageService->getAllStorages();
158
-
159
-		foreach ($mounts as $mount) {
160
-			foreach ($existingMounts as $existingMount) {
161
-				if (
162
-					$existingMount->getMountPoint() === $mount->getMountPoint() &&
163
-					$existingMount->getApplicableGroups() === $mount->getApplicableGroups() &&
164
-					$existingMount->getApplicableUsers() == $mount->getApplicableUsers() &&
165
-					$existingMount->getBackendOptions() == $mount->getBackendOptions()
166
-				) {
167
-					$output->writeln("<error>Duplicate mount (" . $mount->getMountPoint() . ")</error>");
168
-					return 1;
169
-				}
170
-			}
171
-		}
172
-
173
-		if ($input->getOption('dry')) {
174
-			if (count($mounts) === 0) {
175
-				$output->writeln('<error>No mounts to be imported</error>');
176
-				return 1;
177
-			}
178
-			$listCommand = new ListCommand($this->globalService, $this->userService, $this->userSession, $this->userManager);
179
-			$listInput = new ArrayInput([], $listCommand->getDefinition());
180
-			$listInput->setOption('output', $input->getOption('output'));
181
-			$listInput->setOption('show-password', true);
182
-			$listCommand->listMounts($user, $mounts, $listInput, $output);
183
-		} else {
184
-			foreach ($mounts as $mount) {
185
-				$storageService->addStorage($mount);
186
-			}
187
-		}
188
-		return 0;
189
-	}
190
-
191
-	private function parseData(array $data) {
192
-		$mount = new StorageConfig($data['mount_id']);
193
-		$mount->setMountPoint($data['mount_point']);
194
-		$mount->setBackend($this->getBackendByClass($data['storage']));
195
-		$authBackend = $this->backendService->getAuthMechanism($data['authentication_type']);
196
-		$mount->setAuthMechanism($authBackend);
197
-		$mount->setBackendOptions($data['configuration']);
198
-		$mount->setMountOptions($data['options']);
199
-		$mount->setApplicableUsers(isset($data['applicable_users']) ? $data['applicable_users'] : []);
200
-		$mount->setApplicableGroups(isset($data['applicable_groups']) ? $data['applicable_groups'] : []);
201
-		return $mount;
202
-	}
203
-
204
-	private function getBackendByClass($className) {
205
-		$backends = $this->backendService->getBackends();
206
-		foreach ($backends as $backend) {
207
-			if ($backend->getStorageClass() === $className) {
208
-				return $backend;
209
-			}
210
-		}
211
-	}
212
-
213
-	protected function getStorageService($userId) {
214
-		if (!empty($userId)) {
215
-			$user = $this->userManager->get($userId);
216
-			if (is_null($user)) {
217
-				throw new NoUserException("user $userId not found");
218
-			}
219
-			$this->userSession->setUser($user);
220
-			return $this->userService;
221
-		} else {
222
-			return $this->globalService;
223
-		}
224
-	}
42
+    /**
43
+     * @var GlobalStoragesService
44
+     */
45
+    private $globalService;
46
+
47
+    /**
48
+     * @var UserStoragesService
49
+     */
50
+    private $userService;
51
+
52
+    /**
53
+     * @var IUserSession
54
+     */
55
+    private $userSession;
56
+
57
+    /**
58
+     * @var IUserManager
59
+     */
60
+    private $userManager;
61
+
62
+    /** @var ImportLegacyStoragesService */
63
+    private $importLegacyStorageService;
64
+
65
+    /** @var BackendService */
66
+    private $backendService;
67
+
68
+    function __construct(GlobalStoragesService $globalService,
69
+                            UserStoragesService $userService,
70
+                            IUserSession $userSession,
71
+                            IUserManager $userManager,
72
+                            ImportLegacyStoragesService $importLegacyStorageService,
73
+                            BackendService $backendService
74
+    ) {
75
+        parent::__construct();
76
+        $this->globalService = $globalService;
77
+        $this->userService = $userService;
78
+        $this->userSession = $userSession;
79
+        $this->userManager = $userManager;
80
+        $this->importLegacyStorageService = $importLegacyStorageService;
81
+        $this->backendService = $backendService;
82
+    }
83
+
84
+    protected function configure() {
85
+        $this
86
+            ->setName('files_external:import')
87
+            ->setDescription('Import mount configurations')
88
+            ->addOption(
89
+                'user',
90
+                null,
91
+                InputOption::VALUE_OPTIONAL,
92
+                'user to add the mount configurations for, if not set the mount will be added as system mount'
93
+            )
94
+            ->addArgument(
95
+                'path',
96
+                InputArgument::REQUIRED,
97
+                'path to a json file containing the mounts to import, use "-" to read from stdin'
98
+            )
99
+            ->addOption(
100
+                'dry',
101
+                null,
102
+                InputOption::VALUE_NONE,
103
+                'Don\'t save the imported mounts, only list the new mounts'
104
+            );
105
+        parent::configure();
106
+    }
107
+
108
+    protected function execute(InputInterface $input, OutputInterface $output) {
109
+        $user = $input->getOption('user');
110
+        $path = $input->getArgument('path');
111
+        if ($path === '-') {
112
+            $json = file_get_contents('php://stdin');
113
+        } else {
114
+            if (!file_exists($path)) {
115
+                $output->writeln('<error>File not found: ' . $path . '</error>');
116
+                return 1;
117
+            }
118
+            $json = file_get_contents($path);
119
+        }
120
+        if (!is_string($json) || strlen($json) < 2) {
121
+            $output->writeln('<error>Error while reading json</error>');
122
+            return 1;
123
+        }
124
+        $data = json_decode($json, true);
125
+        if (!is_array($data)) {
126
+            $output->writeln('<error>Error while parsing json</error>');
127
+            return 1;
128
+        }
129
+
130
+        $isLegacy = isset($data['user']) || isset($data['group']);
131
+        if ($isLegacy) {
132
+            $this->importLegacyStorageService->setData($data);
133
+            $mounts = $this->importLegacyStorageService->getAllStorages();
134
+            foreach ($mounts as $mount) {
135
+                if ($mount->getBackendOption('password') === false) {
136
+                    $output->writeln('<error>Failed to decrypt password</error>');
137
+                    return 1;
138
+                }
139
+            }
140
+        } else {
141
+            if (!isset($data[0])) { //normalize to an array of mounts
142
+                $data = [$data];
143
+            }
144
+            $mounts = array_map([$this, 'parseData'], $data);
145
+        }
146
+
147
+        if ($user) {
148
+            // ensure applicables are correct for personal mounts
149
+            foreach ($mounts as $mount) {
150
+                $mount->setApplicableGroups([]);
151
+                $mount->setApplicableUsers([$user]);
152
+            }
153
+        }
154
+
155
+        $storageService = $this->getStorageService($user);
156
+
157
+        $existingMounts = $storageService->getAllStorages();
158
+
159
+        foreach ($mounts as $mount) {
160
+            foreach ($existingMounts as $existingMount) {
161
+                if (
162
+                    $existingMount->getMountPoint() === $mount->getMountPoint() &&
163
+                    $existingMount->getApplicableGroups() === $mount->getApplicableGroups() &&
164
+                    $existingMount->getApplicableUsers() == $mount->getApplicableUsers() &&
165
+                    $existingMount->getBackendOptions() == $mount->getBackendOptions()
166
+                ) {
167
+                    $output->writeln("<error>Duplicate mount (" . $mount->getMountPoint() . ")</error>");
168
+                    return 1;
169
+                }
170
+            }
171
+        }
172
+
173
+        if ($input->getOption('dry')) {
174
+            if (count($mounts) === 0) {
175
+                $output->writeln('<error>No mounts to be imported</error>');
176
+                return 1;
177
+            }
178
+            $listCommand = new ListCommand($this->globalService, $this->userService, $this->userSession, $this->userManager);
179
+            $listInput = new ArrayInput([], $listCommand->getDefinition());
180
+            $listInput->setOption('output', $input->getOption('output'));
181
+            $listInput->setOption('show-password', true);
182
+            $listCommand->listMounts($user, $mounts, $listInput, $output);
183
+        } else {
184
+            foreach ($mounts as $mount) {
185
+                $storageService->addStorage($mount);
186
+            }
187
+        }
188
+        return 0;
189
+    }
190
+
191
+    private function parseData(array $data) {
192
+        $mount = new StorageConfig($data['mount_id']);
193
+        $mount->setMountPoint($data['mount_point']);
194
+        $mount->setBackend($this->getBackendByClass($data['storage']));
195
+        $authBackend = $this->backendService->getAuthMechanism($data['authentication_type']);
196
+        $mount->setAuthMechanism($authBackend);
197
+        $mount->setBackendOptions($data['configuration']);
198
+        $mount->setMountOptions($data['options']);
199
+        $mount->setApplicableUsers(isset($data['applicable_users']) ? $data['applicable_users'] : []);
200
+        $mount->setApplicableGroups(isset($data['applicable_groups']) ? $data['applicable_groups'] : []);
201
+        return $mount;
202
+    }
203
+
204
+    private function getBackendByClass($className) {
205
+        $backends = $this->backendService->getBackends();
206
+        foreach ($backends as $backend) {
207
+            if ($backend->getStorageClass() === $className) {
208
+                return $backend;
209
+            }
210
+        }
211
+    }
212
+
213
+    protected function getStorageService($userId) {
214
+        if (!empty($userId)) {
215
+            $user = $this->userManager->get($userId);
216
+            if (is_null($user)) {
217
+                throw new NoUserException("user $userId not found");
218
+            }
219
+            $this->userSession->setUser($user);
220
+            return $this->userService;
221
+        } else {
222
+            return $this->globalService;
223
+        }
224
+    }
225 225
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Settings/Section.php 1 patch
Indentation   +46 added lines, -46 removed lines patch added patch discarded remove patch
@@ -28,55 +28,55 @@
 block discarded – undo
28 28
 use OCP\Settings\IIconSection;
29 29
 
30 30
 class Section implements IIconSection {
31
-	/** @var IL10N */
32
-	private $l;
33
-	/** @var IURLGenerator */
34
-	private $url;
31
+    /** @var IL10N */
32
+    private $l;
33
+    /** @var IURLGenerator */
34
+    private $url;
35 35
 
36
-	/**
37
-	 * @param IURLGenerator $url
38
-	 * @param IL10N $l
39
-	 */
40
-	public function __construct(IURLGenerator $url, IL10N $l) {
41
-		$this->url = $url;
42
-		$this->l = $l;
43
-	}
36
+    /**
37
+     * @param IURLGenerator $url
38
+     * @param IL10N $l
39
+     */
40
+    public function __construct(IURLGenerator $url, IL10N $l) {
41
+        $this->url = $url;
42
+        $this->l = $l;
43
+    }
44 44
 
45
-	/**
46
-	 * returns the ID of the section. It is supposed to be a lower case string,
47
-	 * e.g. 'ldap'
48
-	 *
49
-	 * @returns string
50
-	 */
51
-	public function getID() {
52
-		return 'externalstorages';
53
-	}
45
+    /**
46
+     * returns the ID of the section. It is supposed to be a lower case string,
47
+     * e.g. 'ldap'
48
+     *
49
+     * @returns string
50
+     */
51
+    public function getID() {
52
+        return 'externalstorages';
53
+    }
54 54
 
55
-	/**
56
-	 * returns the translated name as it should be displayed, e.g. 'LDAP / AD
57
-	 * integration'. Use the L10N service to translate it.
58
-	 *
59
-	 * @return string
60
-	 */
61
-	public function getName() {
62
-		return $this->l->t('External storages');
63
-	}
55
+    /**
56
+     * returns the translated name as it should be displayed, e.g. 'LDAP / AD
57
+     * integration'. Use the L10N service to translate it.
58
+     *
59
+     * @return string
60
+     */
61
+    public function getName() {
62
+        return $this->l->t('External storages');
63
+    }
64 64
 
65
-	/**
66
-	 * @return int whether the form should be rather on the top or bottom of
67
-	 * the settings navigation. The sections are arranged in ascending order of
68
-	 * the priority values. It is required to return a value between 0 and 99.
69
-	 *
70
-	 * E.g.: 70
71
-	 */
72
-	public function getPriority() {
73
-		return 10;
74
-	}
65
+    /**
66
+     * @return int whether the form should be rather on the top or bottom of
67
+     * the settings navigation. The sections are arranged in ascending order of
68
+     * the priority values. It is required to return a value between 0 and 99.
69
+     *
70
+     * E.g.: 70
71
+     */
72
+    public function getPriority() {
73
+        return 10;
74
+    }
75 75
 
76
-	/**
77
-	 * {@inheritdoc}
78
-	 */
79
-	public function getIcon() {
80
-		return $this->url->imagePath('files_external', 'app-dark.svg');
81
-	}
76
+    /**
77
+     * {@inheritdoc}
78
+     */
79
+    public function getIcon() {
80
+        return $this->url->imagePath('files_external', 'app-dark.svg');
81
+    }
82 82
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Settings/Admin.php 1 patch
Indentation   +52 added lines, -52 removed lines patch added patch discarded remove patch
@@ -32,65 +32,65 @@
 block discarded – undo
32 32
 
33 33
 class Admin implements ISettings {
34 34
 
35
-	/** @var IManager */
36
-	private $encryptionManager;
35
+    /** @var IManager */
36
+    private $encryptionManager;
37 37
 
38
-	/** @var GlobalStoragesService */
39
-	private $globalStoragesService;
38
+    /** @var GlobalStoragesService */
39
+    private $globalStoragesService;
40 40
 
41
-	/** @var BackendService */
42
-	private $backendService;
41
+    /** @var BackendService */
42
+    private $backendService;
43 43
 
44
-	/** @var GlobalAuth	 */
45
-	private $globalAuth;
44
+    /** @var GlobalAuth	 */
45
+    private $globalAuth;
46 46
 
47
-	public function __construct(
48
-		IManager $encryptionManager,
49
-		GlobalStoragesService $globalStoragesService,
50
-		BackendService $backendService,
51
-		GlobalAuth $globalAuth
52
-	) {
53
-		$this->encryptionManager = $encryptionManager;
54
-		$this->globalStoragesService = $globalStoragesService;
55
-		$this->backendService = $backendService;
56
-		$this->globalAuth = $globalAuth;
57
-	}
47
+    public function __construct(
48
+        IManager $encryptionManager,
49
+        GlobalStoragesService $globalStoragesService,
50
+        BackendService $backendService,
51
+        GlobalAuth $globalAuth
52
+    ) {
53
+        $this->encryptionManager = $encryptionManager;
54
+        $this->globalStoragesService = $globalStoragesService;
55
+        $this->backendService = $backendService;
56
+        $this->globalAuth = $globalAuth;
57
+    }
58 58
 
59
-	/**
60
-	 * @return TemplateResponse
61
-	 */
62
-	public function getForm() {
63
-		$parameters = [
64
-			'encryptionEnabled'    => $this->encryptionManager->isEnabled(),
65
-			'visibilityType'       => BackendService::VISIBILITY_ADMIN,
66
-			'storages'             => $this->globalStoragesService->getStorages(),
67
-			'backends'             => $this->backendService->getAvailableBackends(),
68
-			'authMechanisms'       => $this->backendService->getAuthMechanisms(),
69
-			'dependencies'         => \OC_Mount_Config::dependencyMessage($this->backendService->getBackends()),
70
-			'allowUserMounting'    => $this->backendService->isUserMountingAllowed(),
71
-			'globalCredentials'    => $this->globalAuth->getAuth(''),
72
-			'globalCredentialsUid' => '',
73
-		];
59
+    /**
60
+     * @return TemplateResponse
61
+     */
62
+    public function getForm() {
63
+        $parameters = [
64
+            'encryptionEnabled'    => $this->encryptionManager->isEnabled(),
65
+            'visibilityType'       => BackendService::VISIBILITY_ADMIN,
66
+            'storages'             => $this->globalStoragesService->getStorages(),
67
+            'backends'             => $this->backendService->getAvailableBackends(),
68
+            'authMechanisms'       => $this->backendService->getAuthMechanisms(),
69
+            'dependencies'         => \OC_Mount_Config::dependencyMessage($this->backendService->getBackends()),
70
+            'allowUserMounting'    => $this->backendService->isUserMountingAllowed(),
71
+            'globalCredentials'    => $this->globalAuth->getAuth(''),
72
+            'globalCredentialsUid' => '',
73
+        ];
74 74
 
75
-		return new TemplateResponse('files_external', 'settings', $parameters, '');
76
-	}
75
+        return new TemplateResponse('files_external', 'settings', $parameters, '');
76
+    }
77 77
 
78
-	/**
79
-	 * @return string the section ID, e.g. 'sharing'
80
-	 */
81
-	public function getSection() {
82
-		return 'externalstorages';
83
-	}
78
+    /**
79
+     * @return string the section ID, e.g. 'sharing'
80
+     */
81
+    public function getSection() {
82
+        return 'externalstorages';
83
+    }
84 84
 
85
-	/**
86
-	 * @return int whether the form should be rather on the top or bottom of
87
-	 * the admin section. The forms are arranged in ascending order of the
88
-	 * priority values. It is required to return a value between 0 and 100.
89
-	 *
90
-	 * E.g.: 70
91
-	 */
92
-	public function getPriority() {
93
-		return 40;
94
-	}
85
+    /**
86
+     * @return int whether the form should be rather on the top or bottom of
87
+     * the admin section. The forms are arranged in ascending order of the
88
+     * priority values. It is required to return a value between 0 and 100.
89
+     *
90
+     * E.g.: 70
91
+     */
92
+    public function getPriority() {
93
+        return 40;
94
+    }
95 95
 
96 96
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/LegacyDependencyCheckPolyfill.php 1 patch
Indentation   +34 added lines, -34 removed lines patch added patch discarded remove patch
@@ -29,43 +29,43 @@
 block discarded – undo
29 29
  */
30 30
 trait LegacyDependencyCheckPolyfill {
31 31
 
32
-	/**
33
-	 * @return string
34
-	 */
35
-	abstract public function getStorageClass();
32
+    /**
33
+     * @return string
34
+     */
35
+    abstract public function getStorageClass();
36 36
 
37
-	/**
38
-	 * Check if object is valid for use
39
-	 *
40
-	 * @return MissingDependency[] Unsatisfied dependencies
41
-	 */
42
-	public function checkDependencies() {
43
-		$ret = [];
37
+    /**
38
+     * Check if object is valid for use
39
+     *
40
+     * @return MissingDependency[] Unsatisfied dependencies
41
+     */
42
+    public function checkDependencies() {
43
+        $ret = [];
44 44
 
45
-		$result = call_user_func([$this->getStorageClass(), 'checkDependencies']);
46
-		if ($result !== true) {
47
-			if (!is_array($result)) {
48
-				$result = [$result];
49
-			}
50
-			foreach ($result as $key => $value) {
51
-				if (!($value instanceof MissingDependency)) {
52
-					$module = null;
53
-					$message = null;
54
-					if (is_numeric($key)) {
55
-						$module = $value;
56
-					} else {
57
-						$module = $key;
58
-						$message = $value;
59
-					}
60
-					$value = new MissingDependency($module, $this);
61
-					$value->setMessage($message);
62
-				}
63
-				$ret[] = $value;
64
-			}
65
-		}
45
+        $result = call_user_func([$this->getStorageClass(), 'checkDependencies']);
46
+        if ($result !== true) {
47
+            if (!is_array($result)) {
48
+                $result = [$result];
49
+            }
50
+            foreach ($result as $key => $value) {
51
+                if (!($value instanceof MissingDependency)) {
52
+                    $module = null;
53
+                    $message = null;
54
+                    if (is_numeric($key)) {
55
+                        $module = $value;
56
+                    } else {
57
+                        $module = $key;
58
+                        $message = $value;
59
+                    }
60
+                    $value = new MissingDependency($module, $this);
61
+                    $value->setMessage($message);
62
+                }
63
+                $ret[] = $value;
64
+            }
65
+        }
66 66
 
67
-		return $ret;
68
-	}
67
+        return $ret;
68
+    }
69 69
 
70 70
 }
71 71
 
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/VisibilityTrait.php 1 patch
Indentation   +97 added lines, -97 removed lines patch added patch discarded remove patch
@@ -36,102 +36,102 @@
 block discarded – undo
36 36
  */
37 37
 trait VisibilityTrait {
38 38
 
39
-	/** @var int visibility */
40
-	protected $visibility = BackendService::VISIBILITY_DEFAULT;
41
-
42
-	/** @var int allowed visibilities */
43
-	protected $allowedVisibility = BackendService::VISIBILITY_DEFAULT;
44
-
45
-	/**
46
-	 * @return int
47
-	 */
48
-	public function getVisibility() {
49
-		return $this->visibility;
50
-	}
51
-
52
-	/**
53
-	 * Check if the backend is visible for a user type
54
-	 *
55
-	 * @param int $visibility
56
-	 * @return bool
57
-	 */
58
-	public function isVisibleFor($visibility) {
59
-		if ($this->visibility & $visibility) {
60
-			return true;
61
-		}
62
-		return false;
63
-	}
64
-
65
-	/**
66
-	 * @param int $visibility
67
-	 * @return self
68
-	 */
69
-	public function setVisibility($visibility) {
70
-		$this->visibility = $visibility;
71
-		$this->allowedVisibility |= $visibility;
72
-		return $this;
73
-	}
74
-
75
-	/**
76
-	 * @param int $visibility
77
-	 * @return self
78
-	 */
79
-	public function addVisibility($visibility) {
80
-		return $this->setVisibility($this->visibility | $visibility);
81
-	}
82
-
83
-	/**
84
-	 * @param int $visibility
85
-	 * @return self
86
-	 */
87
-	public function removeVisibility($visibility) {
88
-		return $this->setVisibility($this->visibility & ~$visibility);
89
-	}
90
-
91
-	/**
92
-	 * @return int
93
-	 */
94
-	public function getAllowedVisibility() {
95
-		return $this->allowedVisibility;
96
-	}
97
-
98
-	/**
99
-	 * Check if the backend is allowed to be visible for a user type
100
-	 *
101
-	 * @param int $allowedVisibility
102
-	 * @return bool
103
-	 */
104
-	public function isAllowedVisibleFor($allowedVisibility) {
105
-		if ($this->allowedVisibility & $allowedVisibility) {
106
-			return true;
107
-		}
108
-		return false;
109
-	}
110
-
111
-	/**
112
-	 * @param int $allowedVisibility
113
-	 * @return self
114
-	 */
115
-	public function setAllowedVisibility($allowedVisibility) {
116
-		$this->allowedVisibility = $allowedVisibility;
117
-		$this->visibility &= $allowedVisibility;
118
-		return $this;
119
-	}
120
-
121
-	/**
122
-	 * @param int $allowedVisibility
123
-	 * @return self
124
-	 */
125
-	public function addAllowedVisibility($allowedVisibility) {
126
-		return $this->setAllowedVisibility($this->allowedVisibility | $allowedVisibility);
127
-	}
128
-
129
-	/**
130
-	 * @param int $allowedVisibility
131
-	 * @return self
132
-	 */
133
-	public function removeAllowedVisibility($allowedVisibility) {
134
-		return $this->setAllowedVisibility($this->allowedVisibility & ~$allowedVisibility);
135
-	}
39
+    /** @var int visibility */
40
+    protected $visibility = BackendService::VISIBILITY_DEFAULT;
41
+
42
+    /** @var int allowed visibilities */
43
+    protected $allowedVisibility = BackendService::VISIBILITY_DEFAULT;
44
+
45
+    /**
46
+     * @return int
47
+     */
48
+    public function getVisibility() {
49
+        return $this->visibility;
50
+    }
51
+
52
+    /**
53
+     * Check if the backend is visible for a user type
54
+     *
55
+     * @param int $visibility
56
+     * @return bool
57
+     */
58
+    public function isVisibleFor($visibility) {
59
+        if ($this->visibility & $visibility) {
60
+            return true;
61
+        }
62
+        return false;
63
+    }
64
+
65
+    /**
66
+     * @param int $visibility
67
+     * @return self
68
+     */
69
+    public function setVisibility($visibility) {
70
+        $this->visibility = $visibility;
71
+        $this->allowedVisibility |= $visibility;
72
+        return $this;
73
+    }
74
+
75
+    /**
76
+     * @param int $visibility
77
+     * @return self
78
+     */
79
+    public function addVisibility($visibility) {
80
+        return $this->setVisibility($this->visibility | $visibility);
81
+    }
82
+
83
+    /**
84
+     * @param int $visibility
85
+     * @return self
86
+     */
87
+    public function removeVisibility($visibility) {
88
+        return $this->setVisibility($this->visibility & ~$visibility);
89
+    }
90
+
91
+    /**
92
+     * @return int
93
+     */
94
+    public function getAllowedVisibility() {
95
+        return $this->allowedVisibility;
96
+    }
97
+
98
+    /**
99
+     * Check if the backend is allowed to be visible for a user type
100
+     *
101
+     * @param int $allowedVisibility
102
+     * @return bool
103
+     */
104
+    public function isAllowedVisibleFor($allowedVisibility) {
105
+        if ($this->allowedVisibility & $allowedVisibility) {
106
+            return true;
107
+        }
108
+        return false;
109
+    }
110
+
111
+    /**
112
+     * @param int $allowedVisibility
113
+     * @return self
114
+     */
115
+    public function setAllowedVisibility($allowedVisibility) {
116
+        $this->allowedVisibility = $allowedVisibility;
117
+        $this->visibility &= $allowedVisibility;
118
+        return $this;
119
+    }
120
+
121
+    /**
122
+     * @param int $allowedVisibility
123
+     * @return self
124
+     */
125
+    public function addAllowedVisibility($allowedVisibility) {
126
+        return $this->setAllowedVisibility($this->allowedVisibility | $allowedVisibility);
127
+    }
128
+
129
+    /**
130
+     * @param int $allowedVisibility
131
+     * @return self
132
+     */
133
+    public function removeAllowedVisibility($allowedVisibility) {
134
+        return $this->setAllowedVisibility($this->allowedVisibility & ~$allowedVisibility);
135
+    }
136 136
 
137 137
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/DefinitionParameter.php 1 patch
Indentation   +163 added lines, -163 removed lines patch added patch discarded remove patch
@@ -28,167 +28,167 @@
 block discarded – undo
28 28
  */
29 29
 class DefinitionParameter implements \JsonSerializable {
30 30
 
31
-	/** Value constants */
32
-	const VALUE_TEXT = 0;
33
-	const VALUE_BOOLEAN = 1;
34
-	const VALUE_PASSWORD = 2;
35
-	const VALUE_HIDDEN = 3;
36
-
37
-	/** Flag constants */
38
-	const FLAG_NONE = 0;
39
-	const FLAG_OPTIONAL = 1;
40
-	const FLAG_USER_PROVIDED = 2;
41
-
42
-	/** @var string name of parameter */
43
-	private $name;
44
-
45
-	/** @var string human-readable parameter text */
46
-	private $text;
47
-
48
-	/** @var int value type, see self::VALUE_* constants */
49
-	private $type = self::VALUE_TEXT;
50
-
51
-	/** @var int flags, see self::FLAG_* constants */
52
-	private $flags = self::FLAG_NONE;
53
-
54
-	/**
55
-	 * @param string $name
56
-	 * @param string $text
57
-	 */
58
-	public function __construct($name, $text) {
59
-		$this->name = $name;
60
-		$this->text = $text;
61
-	}
62
-
63
-	/**
64
-	 * @return string
65
-	 */
66
-	public function getName() {
67
-		return $this->name;
68
-	}
69
-
70
-	/**
71
-	 * @return string
72
-	 */
73
-	public function getText() {
74
-		return $this->text;
75
-	}
76
-
77
-	/**
78
-	 * Get value type
79
-	 *
80
-	 * @return int
81
-	 */
82
-	public function getType() {
83
-		return $this->type;
84
-	}
85
-
86
-	/**
87
-	 * Set value type
88
-	 *
89
-	 * @param int $type
90
-	 * @return self
91
-	 */
92
-	public function setType($type) {
93
-		$this->type = $type;
94
-		return $this;
95
-	}
96
-
97
-	/**
98
-	 * @return string
99
-	 */
100
-	public function getTypeName() {
101
-		switch ($this->type) {
102
-			case self::VALUE_BOOLEAN:
103
-				return 'boolean';
104
-			case self::VALUE_TEXT:
105
-				return 'text';
106
-			case self::VALUE_PASSWORD:
107
-				return 'password';
108
-			default:
109
-				return 'unknown';
110
-		}
111
-	}
112
-
113
-	/**
114
-	 * @return int
115
-	 */
116
-	public function getFlags() {
117
-		return $this->flags;
118
-	}
119
-
120
-	/**
121
-	 * @param int $flags
122
-	 * @return self
123
-	 */
124
-	public function setFlags($flags) {
125
-		$this->flags = $flags;
126
-		return $this;
127
-	}
128
-
129
-	/**
130
-	 * @param int $flag
131
-	 * @return self
132
-	 */
133
-	public function setFlag($flag) {
134
-		$this->flags |= $flag;
135
-		return $this;
136
-	}
137
-
138
-	/**
139
-	 * @param int $flag
140
-	 * @return bool
141
-	 */
142
-	public function isFlagSet($flag) {
143
-		return (bool)($this->flags & $flag);
144
-	}
145
-
146
-	/**
147
-	 * Serialize into JSON for client-side JS
148
-	 *
149
-	 * @return string
150
-	 */
151
-	public function jsonSerialize() {
152
-		return [
153
-			'value' => $this->getText(),
154
-			'flags' => $this->getFlags(),
155
-			'type' => $this->getType()
156
-		];
157
-	}
158
-
159
-	public function isOptional() {
160
-		return $this->isFlagSet(self::FLAG_OPTIONAL) || $this->isFlagSet(self::FLAG_USER_PROVIDED);
161
-	}
162
-
163
-	/**
164
-	 * Validate a parameter value against this
165
-	 * Convert type as necessary
166
-	 *
167
-	 * @param mixed $value Value to check
168
-	 * @return bool success
169
-	 */
170
-	public function validateValue(&$value) {
171
-		switch ($this->getType()) {
172
-			case self::VALUE_BOOLEAN:
173
-				if (!is_bool($value)) {
174
-					switch ($value) {
175
-						case 'true':
176
-							$value = true;
177
-							break;
178
-						case 'false':
179
-							$value = false;
180
-							break;
181
-						default:
182
-							return false;
183
-					}
184
-				}
185
-				break;
186
-			default:
187
-				if (!$value && !$this->isOptional()) {
188
-					return false;
189
-				}
190
-				break;
191
-		}
192
-		return true;
193
-	}
31
+    /** Value constants */
32
+    const VALUE_TEXT = 0;
33
+    const VALUE_BOOLEAN = 1;
34
+    const VALUE_PASSWORD = 2;
35
+    const VALUE_HIDDEN = 3;
36
+
37
+    /** Flag constants */
38
+    const FLAG_NONE = 0;
39
+    const FLAG_OPTIONAL = 1;
40
+    const FLAG_USER_PROVIDED = 2;
41
+
42
+    /** @var string name of parameter */
43
+    private $name;
44
+
45
+    /** @var string human-readable parameter text */
46
+    private $text;
47
+
48
+    /** @var int value type, see self::VALUE_* constants */
49
+    private $type = self::VALUE_TEXT;
50
+
51
+    /** @var int flags, see self::FLAG_* constants */
52
+    private $flags = self::FLAG_NONE;
53
+
54
+    /**
55
+     * @param string $name
56
+     * @param string $text
57
+     */
58
+    public function __construct($name, $text) {
59
+        $this->name = $name;
60
+        $this->text = $text;
61
+    }
62
+
63
+    /**
64
+     * @return string
65
+     */
66
+    public function getName() {
67
+        return $this->name;
68
+    }
69
+
70
+    /**
71
+     * @return string
72
+     */
73
+    public function getText() {
74
+        return $this->text;
75
+    }
76
+
77
+    /**
78
+     * Get value type
79
+     *
80
+     * @return int
81
+     */
82
+    public function getType() {
83
+        return $this->type;
84
+    }
85
+
86
+    /**
87
+     * Set value type
88
+     *
89
+     * @param int $type
90
+     * @return self
91
+     */
92
+    public function setType($type) {
93
+        $this->type = $type;
94
+        return $this;
95
+    }
96
+
97
+    /**
98
+     * @return string
99
+     */
100
+    public function getTypeName() {
101
+        switch ($this->type) {
102
+            case self::VALUE_BOOLEAN:
103
+                return 'boolean';
104
+            case self::VALUE_TEXT:
105
+                return 'text';
106
+            case self::VALUE_PASSWORD:
107
+                return 'password';
108
+            default:
109
+                return 'unknown';
110
+        }
111
+    }
112
+
113
+    /**
114
+     * @return int
115
+     */
116
+    public function getFlags() {
117
+        return $this->flags;
118
+    }
119
+
120
+    /**
121
+     * @param int $flags
122
+     * @return self
123
+     */
124
+    public function setFlags($flags) {
125
+        $this->flags = $flags;
126
+        return $this;
127
+    }
128
+
129
+    /**
130
+     * @param int $flag
131
+     * @return self
132
+     */
133
+    public function setFlag($flag) {
134
+        $this->flags |= $flag;
135
+        return $this;
136
+    }
137
+
138
+    /**
139
+     * @param int $flag
140
+     * @return bool
141
+     */
142
+    public function isFlagSet($flag) {
143
+        return (bool)($this->flags & $flag);
144
+    }
145
+
146
+    /**
147
+     * Serialize into JSON for client-side JS
148
+     *
149
+     * @return string
150
+     */
151
+    public function jsonSerialize() {
152
+        return [
153
+            'value' => $this->getText(),
154
+            'flags' => $this->getFlags(),
155
+            'type' => $this->getType()
156
+        ];
157
+    }
158
+
159
+    public function isOptional() {
160
+        return $this->isFlagSet(self::FLAG_OPTIONAL) || $this->isFlagSet(self::FLAG_USER_PROVIDED);
161
+    }
162
+
163
+    /**
164
+     * Validate a parameter value against this
165
+     * Convert type as necessary
166
+     *
167
+     * @param mixed $value Value to check
168
+     * @return bool success
169
+     */
170
+    public function validateValue(&$value) {
171
+        switch ($this->getType()) {
172
+            case self::VALUE_BOOLEAN:
173
+                if (!is_bool($value)) {
174
+                    switch ($value) {
175
+                        case 'true':
176
+                            $value = true;
177
+                            break;
178
+                        case 'false':
179
+                            $value = false;
180
+                            break;
181
+                        default:
182
+                            return false;
183
+                    }
184
+                }
185
+                break;
186
+            default:
187
+                if (!$value && !$this->isOptional()) {
188
+                    return false;
189
+                }
190
+                break;
191
+        }
192
+        return true;
193
+    }
194 194
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Auth/AmazonS3/AccessKey.php 1 patch
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -31,18 +31,18 @@
 block discarded – undo
31 31
  */
32 32
 class AccessKey extends AuthMechanism {
33 33
 
34
-	const SCHEME_AMAZONS3_ACCESSKEY = 'amazons3_accesskey';
34
+    const SCHEME_AMAZONS3_ACCESSKEY = 'amazons3_accesskey';
35 35
 
36
-	public function __construct(IL10N $l) {
37
-		$this
38
-			->setIdentifier('amazons3::accesskey')
39
-			->setScheme(self::SCHEME_AMAZONS3_ACCESSKEY)
40
-			->setText($l->t('Access key'))
41
-			->addParameters([
42
-				(new DefinitionParameter('key', $l->t('Access key'))),
43
-				(new DefinitionParameter('secret', $l->t('Secret key')))
44
-					->setType(DefinitionParameter::VALUE_PASSWORD),
45
-			]);
46
-	}
36
+    public function __construct(IL10N $l) {
37
+        $this
38
+            ->setIdentifier('amazons3::accesskey')
39
+            ->setScheme(self::SCHEME_AMAZONS3_ACCESSKEY)
40
+            ->setText($l->t('Access key'))
41
+            ->addParameters([
42
+                (new DefinitionParameter('key', $l->t('Access key'))),
43
+                (new DefinitionParameter('secret', $l->t('Secret key')))
44
+                    ->setType(DefinitionParameter::VALUE_PASSWORD),
45
+            ]);
46
+    }
47 47
 
48 48
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Auth/Password/SessionCredentials.php 1 patch
Indentation   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -39,31 +39,31 @@
 block discarded – undo
39 39
  */
40 40
 class SessionCredentials extends AuthMechanism {
41 41
 
42
-	/** @var CredentialsStore */
43
-	private $credentialsStore;
42
+    /** @var CredentialsStore */
43
+    private $credentialsStore;
44 44
 
45
-	public function __construct(IL10N $l, CredentialsStore $credentialsStore) {
46
-		$this->credentialsStore = $credentialsStore;
45
+    public function __construct(IL10N $l, CredentialsStore $credentialsStore) {
46
+        $this->credentialsStore = $credentialsStore;
47 47
 
48
-		$this->setIdentifier('password::sessioncredentials')
49
-			->setScheme(self::SCHEME_PASSWORD)
50
-			->setText($l->t('Log-in credentials, save in session'))
51
-			->addParameters([]);
52
-	}
48
+        $this->setIdentifier('password::sessioncredentials')
49
+            ->setScheme(self::SCHEME_PASSWORD)
50
+            ->setText($l->t('Log-in credentials, save in session'))
51
+            ->addParameters([]);
52
+    }
53 53
 
54
-	public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
55
-		try {
56
-			$credentials = $this->credentialsStore->getLoginCredentials();
57
-		} catch (CredentialsUnavailableException $e) {
58
-			throw new InsufficientDataForMeaningfulAnswerException('No session credentials saved');
59
-		}
54
+    public function manipulateStorageConfig(StorageConfig &$storage, IUser $user = null) {
55
+        try {
56
+            $credentials = $this->credentialsStore->getLoginCredentials();
57
+        } catch (CredentialsUnavailableException $e) {
58
+            throw new InsufficientDataForMeaningfulAnswerException('No session credentials saved');
59
+        }
60 60
 
61
-		$storage->setBackendOption('user', $credentials->getLoginName());
62
-		$storage->setBackendOption('password', $credentials->getPassword());
63
-	}
61
+        $storage->setBackendOption('user', $credentials->getLoginName());
62
+        $storage->setBackendOption('password', $credentials->getPassword());
63
+    }
64 64
 
65
-	public function wrapStorage(Storage $storage) {
66
-		return new SessionStorageWrapper(['storage' => $storage]);
67
-	}
65
+    public function wrapStorage(Storage $storage) {
66
+        return new SessionStorageWrapper(['storage' => $storage]);
67
+    }
68 68
 
69 69
 }
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Auth/Password/Password.php 1 patch
Indentation   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -31,16 +31,16 @@
 block discarded – undo
31 31
  */
32 32
 class Password extends AuthMechanism {
33 33
 
34
-	public function __construct(IL10N $l) {
35
-		$this
36
-			->setIdentifier('password::password')
37
-			->setScheme(self::SCHEME_PASSWORD)
38
-			->setText($l->t('Username and password'))
39
-			->addParameters([
40
-				(new DefinitionParameter('user', $l->t('Username'))),
41
-				(new DefinitionParameter('password', $l->t('Password')))
42
-					->setType(DefinitionParameter::VALUE_PASSWORD),
43
-			]);
44
-	}
34
+    public function __construct(IL10N $l) {
35
+        $this
36
+            ->setIdentifier('password::password')
37
+            ->setScheme(self::SCHEME_PASSWORD)
38
+            ->setText($l->t('Username and password'))
39
+            ->addParameters([
40
+                (new DefinitionParameter('user', $l->t('Username'))),
41
+                (new DefinitionParameter('password', $l->t('Password')))
42
+                    ->setType(DefinitionParameter::VALUE_PASSWORD),
43
+            ]);
44
+    }
45 45
 
46 46
 }
Please login to merge, or discard this patch.