Completed
Pull Request — master (#5231)
by Morris
16:38
created
apps/encryption/lib/Exceptions/PrivateKeyMissingException.php 2 patches
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -28,14 +28,14 @@
 block discarded – undo
28 28
 
29 29
 class PrivateKeyMissingException extends GenericEncryptionException {
30 30
 
31
-	/**
32
-	 * @param string $userId
33
-	 */
34
-	public function __construct($userId) {
35
-		if(empty($userId)) {
36
-			$userId = "<no-user-id-given>";
37
-		}
38
-		parent::__construct("Private Key missing for user: $userId");
39
-	}
31
+    /**
32
+     * @param string $userId
33
+     */
34
+    public function __construct($userId) {
35
+        if(empty($userId)) {
36
+            $userId = "<no-user-id-given>";
37
+        }
38
+        parent::__construct("Private Key missing for user: $userId");
39
+    }
40 40
 
41 41
 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
 	 * @param string $userId
33 33
 	 */
34 34
 	public function __construct($userId) {
35
-		if(empty($userId)) {
35
+		if (empty($userId)) {
36 36
 			$userId = "<no-user-id-given>";
37 37
 		}
38 38
 		parent::__construct("Private Key missing for user: $userId");
Please login to merge, or discard this patch.
apps/encryption/lib/AppInfo/Application.php 2 patches
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 		$this->encryptionManager = \OC::$server->getEncryptionManager();
63 63
 		$this->config = \OC::$server->getConfig();
64 64
 		$this->registerServices();
65
-		if($encryptionSystemReady === false) {
65
+		if ($encryptionSystemReady === false) {
66 66
 			/** @var Session $session */
67 67
 			$session = $this->getContainer()->query('Session');
68 68
 			$session->setStatus(Session::RUN_MIGRATION);
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 		$container = $this->getContainer();
134 134
 
135 135
 		$container->registerService('Crypt',
136
-			function (IAppContainer $c) {
136
+			function(IAppContainer $c) {
137 137
 				$server = $c->getServer();
138 138
 				return new Crypt($server->getLogger(),
139 139
 					$server->getUserSession(),
@@ -142,14 +142,14 @@  discard block
 block discarded – undo
142 142
 			});
143 143
 
144 144
 		$container->registerService('Session',
145
-			function (IAppContainer $c) {
145
+			function(IAppContainer $c) {
146 146
 				$server = $c->getServer();
147 147
 				return new Session($server->getSession());
148 148
 			}
149 149
 		);
150 150
 
151 151
 		$container->registerService('KeyManager',
152
-			function (IAppContainer $c) {
152
+			function(IAppContainer $c) {
153 153
 				$server = $c->getServer();
154 154
 
155 155
 				return new KeyManager($server->getEncryptionKeyStorage(),
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 			});
164 164
 
165 165
 		$container->registerService('Recovery',
166
-			function (IAppContainer $c) {
166
+			function(IAppContainer $c) {
167 167
 				$server = $c->getServer();
168 168
 
169 169
 				return new Recovery(
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
 					new View());
178 178
 			});
179 179
 
180
-		$container->registerService('RecoveryController', function (IAppContainer $c) {
180
+		$container->registerService('RecoveryController', function(IAppContainer $c) {
181 181
 			$server = $c->getServer();
182 182
 			return new RecoveryController(
183 183
 				$c->getAppName(),
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
 				$c->query('Recovery'));
188 188
 		});
189 189
 
190
-		$container->registerService('StatusController', function (IAppContainer $c) {
190
+		$container->registerService('StatusController', function(IAppContainer $c) {
191 191
 			$server = $c->getServer();
192 192
 			return new StatusController(
193 193
 				$c->getAppName(),
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
 			);
198 198
 		});
199 199
 
200
-		$container->registerService('SettingsController', function (IAppContainer $c) {
200
+		$container->registerService('SettingsController', function(IAppContainer $c) {
201 201
 			$server = $c->getServer();
202 202
 			return new SettingsController(
203 203
 				$c->getAppName(),
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
 		});
215 215
 
216 216
 		$container->registerService('UserSetup',
217
-			function (IAppContainer $c) {
217
+			function(IAppContainer $c) {
218 218
 				$server = $c->getServer();
219 219
 				return new Setup($server->getLogger(),
220 220
 					$server->getUserSession(),
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
 			});
224 224
 
225 225
 		$container->registerService('Util',
226
-			function (IAppContainer $c) {
226
+			function(IAppContainer $c) {
227 227
 				$server = $c->getServer();
228 228
 
229 229
 				return new Util(
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
 			});
237 237
 
238 238
 		$container->registerService('EncryptAll',
239
-			function (IAppContainer $c) {
239
+			function(IAppContainer $c) {
240 240
 				$server = $c->getServer();
241 241
 				return new EncryptAll(
242 242
 					$c->query('UserSetup'),
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 		);
255 255
 
256 256
 		$container->registerService('DecryptAll',
257
-			function (IAppContainer $c) {
257
+			function(IAppContainer $c) {
258 258
 				return new DecryptAll(
259 259
 					$c->query('Util'),
260 260
 					$c->query('KeyManager'),
Please login to merge, or discard this patch.
Indentation   +218 added lines, -218 removed lines patch added patch discarded remove patch
@@ -48,222 +48,222 @@
 block discarded – undo
48 48
 
49 49
 class Application extends \OCP\AppFramework\App {
50 50
 
51
-	/** @var IManager */
52
-	private $encryptionManager;
53
-	/** @var IConfig */
54
-	private $config;
55
-
56
-	/**
57
-	 * @param array $urlParams
58
-	 * @param bool $encryptionSystemReady
59
-	 */
60
-	public function __construct($urlParams = array(), $encryptionSystemReady = true) {
61
-		parent::__construct('encryption', $urlParams);
62
-		$this->encryptionManager = \OC::$server->getEncryptionManager();
63
-		$this->config = \OC::$server->getConfig();
64
-		$this->registerServices();
65
-		if($encryptionSystemReady === false) {
66
-			/** @var Session $session */
67
-			$session = $this->getContainer()->query('Session');
68
-			$session->setStatus(Session::RUN_MIGRATION);
69
-		}
70
-		if ($this->encryptionManager->isEnabled() && $encryptionSystemReady) {
71
-			/** @var Setup $setup */
72
-			$setup = $this->getContainer()->query('UserSetup');
73
-			$setup->setupSystem();
74
-		}
75
-	}
76
-
77
-	/**
78
-	 * register hooks
79
-	 */
80
-
81
-	public function registerHooks() {
82
-		if (!$this->config->getSystemValue('maintenance', false)) {
83
-
84
-			$container = $this->getContainer();
85
-			$server = $container->getServer();
86
-			// Register our hooks and fire them.
87
-			$hookManager = new HookManager();
88
-
89
-			$hookManager->registerHook([
90
-				new UserHooks($container->query('KeyManager'),
91
-					$server->getUserManager(),
92
-					$server->getLogger(),
93
-					$container->query('UserSetup'),
94
-					$server->getUserSession(),
95
-					$container->query('Util'),
96
-					$container->query('Session'),
97
-					$container->query('Crypt'),
98
-					$container->query('Recovery'))
99
-			]);
100
-
101
-			$hookManager->fireHooks();
102
-
103
-		} else {
104
-			// Logout user if we are in maintenance to force re-login
105
-			$this->getContainer()->getServer()->getUserSession()->logout();
106
-		}
107
-	}
108
-
109
-	public function registerEncryptionModule() {
110
-		$container = $this->getContainer();
111
-
112
-
113
-		$this->encryptionManager->registerEncryptionModule(
114
-			Encryption::ID,
115
-			Encryption::DISPLAY_NAME,
116
-			function() use ($container) {
117
-
118
-			return new Encryption(
119
-				$container->query('Crypt'),
120
-				$container->query('KeyManager'),
121
-				$container->query('Util'),
122
-				$container->query('Session'),
123
-				$container->query('EncryptAll'),
124
-				$container->query('DecryptAll'),
125
-				$container->getServer()->getLogger(),
126
-				$container->getServer()->getL10N($container->getAppName())
127
-			);
128
-		});
129
-
130
-	}
131
-
132
-	public function registerServices() {
133
-		$container = $this->getContainer();
134
-
135
-		$container->registerService('Crypt',
136
-			function (IAppContainer $c) {
137
-				$server = $c->getServer();
138
-				return new Crypt($server->getLogger(),
139
-					$server->getUserSession(),
140
-					$server->getConfig(),
141
-					$server->getL10N($c->getAppName()));
142
-			});
143
-
144
-		$container->registerService('Session',
145
-			function (IAppContainer $c) {
146
-				$server = $c->getServer();
147
-				return new Session($server->getSession());
148
-			}
149
-		);
150
-
151
-		$container->registerService('KeyManager',
152
-			function (IAppContainer $c) {
153
-				$server = $c->getServer();
154
-
155
-				return new KeyManager($server->getEncryptionKeyStorage(),
156
-					$c->query('Crypt'),
157
-					$server->getConfig(),
158
-					$server->getUserSession(),
159
-					new Session($server->getSession()),
160
-					$server->getLogger(),
161
-					$c->query('Util')
162
-				);
163
-			});
164
-
165
-		$container->registerService('Recovery',
166
-			function (IAppContainer $c) {
167
-				$server = $c->getServer();
168
-
169
-				return new Recovery(
170
-					$server->getUserSession(),
171
-					$c->query('Crypt'),
172
-					$server->getSecureRandom(),
173
-					$c->query('KeyManager'),
174
-					$server->getConfig(),
175
-					$server->getEncryptionKeyStorage(),
176
-					$server->getEncryptionFilesHelper(),
177
-					new View());
178
-			});
179
-
180
-		$container->registerService('RecoveryController', function (IAppContainer $c) {
181
-			$server = $c->getServer();
182
-			return new RecoveryController(
183
-				$c->getAppName(),
184
-				$server->getRequest(),
185
-				$server->getConfig(),
186
-				$server->getL10N($c->getAppName()),
187
-				$c->query('Recovery'));
188
-		});
189
-
190
-		$container->registerService('StatusController', function (IAppContainer $c) {
191
-			$server = $c->getServer();
192
-			return new StatusController(
193
-				$c->getAppName(),
194
-				$server->getRequest(),
195
-				$server->getL10N($c->getAppName()),
196
-				$c->query('Session')
197
-			);
198
-		});
199
-
200
-		$container->registerService('SettingsController', function (IAppContainer $c) {
201
-			$server = $c->getServer();
202
-			return new SettingsController(
203
-				$c->getAppName(),
204
-				$server->getRequest(),
205
-				$server->getL10N($c->getAppName()),
206
-				$server->getUserManager(),
207
-				$server->getUserSession(),
208
-				$c->query('KeyManager'),
209
-				$c->query('Crypt'),
210
-				$c->query('Session'),
211
-				$server->getSession(),
212
-				$c->query('Util')
213
-			);
214
-		});
215
-
216
-		$container->registerService('UserSetup',
217
-			function (IAppContainer $c) {
218
-				$server = $c->getServer();
219
-				return new Setup($server->getLogger(),
220
-					$server->getUserSession(),
221
-					$c->query('Crypt'),
222
-					$c->query('KeyManager'));
223
-			});
224
-
225
-		$container->registerService('Util',
226
-			function (IAppContainer $c) {
227
-				$server = $c->getServer();
228
-
229
-				return new Util(
230
-					new View(),
231
-					$c->query('Crypt'),
232
-					$server->getLogger(),
233
-					$server->getUserSession(),
234
-					$server->getConfig(),
235
-					$server->getUserManager());
236
-			});
237
-
238
-		$container->registerService('EncryptAll',
239
-			function (IAppContainer $c) {
240
-				$server = $c->getServer();
241
-				return new EncryptAll(
242
-					$c->query('UserSetup'),
243
-					$c->getServer()->getUserManager(),
244
-					new View(),
245
-					$c->query('KeyManager'),
246
-					$c->query('Util'),
247
-					$server->getConfig(),
248
-					$server->getMailer(),
249
-					$server->getL10N('encryption'),
250
-					new QuestionHelper(),
251
-					$server->getSecureRandom()
252
-				);
253
-			}
254
-		);
255
-
256
-		$container->registerService('DecryptAll',
257
-			function (IAppContainer $c) {
258
-				return new DecryptAll(
259
-					$c->query('Util'),
260
-					$c->query('KeyManager'),
261
-					$c->query('Crypt'),
262
-					$c->query('Session'),
263
-					new QuestionHelper()
264
-				);
265
-			}
266
-		);
267
-
268
-	}
51
+    /** @var IManager */
52
+    private $encryptionManager;
53
+    /** @var IConfig */
54
+    private $config;
55
+
56
+    /**
57
+     * @param array $urlParams
58
+     * @param bool $encryptionSystemReady
59
+     */
60
+    public function __construct($urlParams = array(), $encryptionSystemReady = true) {
61
+        parent::__construct('encryption', $urlParams);
62
+        $this->encryptionManager = \OC::$server->getEncryptionManager();
63
+        $this->config = \OC::$server->getConfig();
64
+        $this->registerServices();
65
+        if($encryptionSystemReady === false) {
66
+            /** @var Session $session */
67
+            $session = $this->getContainer()->query('Session');
68
+            $session->setStatus(Session::RUN_MIGRATION);
69
+        }
70
+        if ($this->encryptionManager->isEnabled() && $encryptionSystemReady) {
71
+            /** @var Setup $setup */
72
+            $setup = $this->getContainer()->query('UserSetup');
73
+            $setup->setupSystem();
74
+        }
75
+    }
76
+
77
+    /**
78
+     * register hooks
79
+     */
80
+
81
+    public function registerHooks() {
82
+        if (!$this->config->getSystemValue('maintenance', false)) {
83
+
84
+            $container = $this->getContainer();
85
+            $server = $container->getServer();
86
+            // Register our hooks and fire them.
87
+            $hookManager = new HookManager();
88
+
89
+            $hookManager->registerHook([
90
+                new UserHooks($container->query('KeyManager'),
91
+                    $server->getUserManager(),
92
+                    $server->getLogger(),
93
+                    $container->query('UserSetup'),
94
+                    $server->getUserSession(),
95
+                    $container->query('Util'),
96
+                    $container->query('Session'),
97
+                    $container->query('Crypt'),
98
+                    $container->query('Recovery'))
99
+            ]);
100
+
101
+            $hookManager->fireHooks();
102
+
103
+        } else {
104
+            // Logout user if we are in maintenance to force re-login
105
+            $this->getContainer()->getServer()->getUserSession()->logout();
106
+        }
107
+    }
108
+
109
+    public function registerEncryptionModule() {
110
+        $container = $this->getContainer();
111
+
112
+
113
+        $this->encryptionManager->registerEncryptionModule(
114
+            Encryption::ID,
115
+            Encryption::DISPLAY_NAME,
116
+            function() use ($container) {
117
+
118
+            return new Encryption(
119
+                $container->query('Crypt'),
120
+                $container->query('KeyManager'),
121
+                $container->query('Util'),
122
+                $container->query('Session'),
123
+                $container->query('EncryptAll'),
124
+                $container->query('DecryptAll'),
125
+                $container->getServer()->getLogger(),
126
+                $container->getServer()->getL10N($container->getAppName())
127
+            );
128
+        });
129
+
130
+    }
131
+
132
+    public function registerServices() {
133
+        $container = $this->getContainer();
134
+
135
+        $container->registerService('Crypt',
136
+            function (IAppContainer $c) {
137
+                $server = $c->getServer();
138
+                return new Crypt($server->getLogger(),
139
+                    $server->getUserSession(),
140
+                    $server->getConfig(),
141
+                    $server->getL10N($c->getAppName()));
142
+            });
143
+
144
+        $container->registerService('Session',
145
+            function (IAppContainer $c) {
146
+                $server = $c->getServer();
147
+                return new Session($server->getSession());
148
+            }
149
+        );
150
+
151
+        $container->registerService('KeyManager',
152
+            function (IAppContainer $c) {
153
+                $server = $c->getServer();
154
+
155
+                return new KeyManager($server->getEncryptionKeyStorage(),
156
+                    $c->query('Crypt'),
157
+                    $server->getConfig(),
158
+                    $server->getUserSession(),
159
+                    new Session($server->getSession()),
160
+                    $server->getLogger(),
161
+                    $c->query('Util')
162
+                );
163
+            });
164
+
165
+        $container->registerService('Recovery',
166
+            function (IAppContainer $c) {
167
+                $server = $c->getServer();
168
+
169
+                return new Recovery(
170
+                    $server->getUserSession(),
171
+                    $c->query('Crypt'),
172
+                    $server->getSecureRandom(),
173
+                    $c->query('KeyManager'),
174
+                    $server->getConfig(),
175
+                    $server->getEncryptionKeyStorage(),
176
+                    $server->getEncryptionFilesHelper(),
177
+                    new View());
178
+            });
179
+
180
+        $container->registerService('RecoveryController', function (IAppContainer $c) {
181
+            $server = $c->getServer();
182
+            return new RecoveryController(
183
+                $c->getAppName(),
184
+                $server->getRequest(),
185
+                $server->getConfig(),
186
+                $server->getL10N($c->getAppName()),
187
+                $c->query('Recovery'));
188
+        });
189
+
190
+        $container->registerService('StatusController', function (IAppContainer $c) {
191
+            $server = $c->getServer();
192
+            return new StatusController(
193
+                $c->getAppName(),
194
+                $server->getRequest(),
195
+                $server->getL10N($c->getAppName()),
196
+                $c->query('Session')
197
+            );
198
+        });
199
+
200
+        $container->registerService('SettingsController', function (IAppContainer $c) {
201
+            $server = $c->getServer();
202
+            return new SettingsController(
203
+                $c->getAppName(),
204
+                $server->getRequest(),
205
+                $server->getL10N($c->getAppName()),
206
+                $server->getUserManager(),
207
+                $server->getUserSession(),
208
+                $c->query('KeyManager'),
209
+                $c->query('Crypt'),
210
+                $c->query('Session'),
211
+                $server->getSession(),
212
+                $c->query('Util')
213
+            );
214
+        });
215
+
216
+        $container->registerService('UserSetup',
217
+            function (IAppContainer $c) {
218
+                $server = $c->getServer();
219
+                return new Setup($server->getLogger(),
220
+                    $server->getUserSession(),
221
+                    $c->query('Crypt'),
222
+                    $c->query('KeyManager'));
223
+            });
224
+
225
+        $container->registerService('Util',
226
+            function (IAppContainer $c) {
227
+                $server = $c->getServer();
228
+
229
+                return new Util(
230
+                    new View(),
231
+                    $c->query('Crypt'),
232
+                    $server->getLogger(),
233
+                    $server->getUserSession(),
234
+                    $server->getConfig(),
235
+                    $server->getUserManager());
236
+            });
237
+
238
+        $container->registerService('EncryptAll',
239
+            function (IAppContainer $c) {
240
+                $server = $c->getServer();
241
+                return new EncryptAll(
242
+                    $c->query('UserSetup'),
243
+                    $c->getServer()->getUserManager(),
244
+                    new View(),
245
+                    $c->query('KeyManager'),
246
+                    $c->query('Util'),
247
+                    $server->getConfig(),
248
+                    $server->getMailer(),
249
+                    $server->getL10N('encryption'),
250
+                    new QuestionHelper(),
251
+                    $server->getSecureRandom()
252
+                );
253
+            }
254
+        );
255
+
256
+        $container->registerService('DecryptAll',
257
+            function (IAppContainer $c) {
258
+                return new DecryptAll(
259
+                    $c->query('Util'),
260
+                    $c->query('KeyManager'),
261
+                    $c->query('Crypt'),
262
+                    $c->query('Session'),
263
+                    new QuestionHelper()
264
+                );
265
+            }
266
+        );
267
+
268
+    }
269 269
 }
Please login to merge, or discard this patch.
apps/encryption/lib/Recovery.php 2 patches
Indentation   +287 added lines, -287 removed lines patch added patch discarded remove patch
@@ -38,293 +38,293 @@
 block discarded – undo
38 38
 class Recovery {
39 39
 
40 40
 
41
-	/**
42
-	 * @var null|IUser
43
-	 */
44
-	protected $user;
45
-	/**
46
-	 * @var Crypt
47
-	 */
48
-	protected $crypt;
49
-	/**
50
-	 * @var ISecureRandom
51
-	 */
52
-	private $random;
53
-	/**
54
-	 * @var KeyManager
55
-	 */
56
-	private $keyManager;
57
-	/**
58
-	 * @var IConfig
59
-	 */
60
-	private $config;
61
-	/**
62
-	 * @var IStorage
63
-	 */
64
-	private $keyStorage;
65
-	/**
66
-	 * @var View
67
-	 */
68
-	private $view;
69
-	/**
70
-	 * @var IFile
71
-	 */
72
-	private $file;
73
-
74
-	/**
75
-	 * @param IUserSession $user
76
-	 * @param Crypt $crypt
77
-	 * @param ISecureRandom $random
78
-	 * @param KeyManager $keyManager
79
-	 * @param IConfig $config
80
-	 * @param IStorage $keyStorage
81
-	 * @param IFile $file
82
-	 * @param View $view
83
-	 */
84
-	public function __construct(IUserSession $user,
85
-								Crypt $crypt,
86
-								ISecureRandom $random,
87
-								KeyManager $keyManager,
88
-								IConfig $config,
89
-								IStorage $keyStorage,
90
-								IFile $file,
91
-								View $view) {
92
-		$this->user = ($user && $user->isLoggedIn()) ? $user->getUser() : false;
93
-		$this->crypt = $crypt;
94
-		$this->random = $random;
95
-		$this->keyManager = $keyManager;
96
-		$this->config = $config;
97
-		$this->keyStorage = $keyStorage;
98
-		$this->view = $view;
99
-		$this->file = $file;
100
-	}
101
-
102
-	/**
103
-	 * @param string $password
104
-	 * @return bool
105
-	 */
106
-	public function enableAdminRecovery($password) {
107
-		$appConfig = $this->config;
108
-		$keyManager = $this->keyManager;
109
-
110
-		if (!$keyManager->recoveryKeyExists()) {
111
-			$keyPair = $this->crypt->createKeyPair();
112
-			if(!is_array($keyPair)) {
113
-				return false;
114
-			}
115
-
116
-			$this->keyManager->setRecoveryKey($password, $keyPair);
117
-		}
118
-
119
-		if ($keyManager->checkRecoveryPassword($password)) {
120
-			$appConfig->setAppValue('encryption', 'recoveryAdminEnabled', 1);
121
-			return true;
122
-		}
123
-
124
-		return false;
125
-	}
126
-
127
-	/**
128
-	 * change recovery key id
129
-	 *
130
-	 * @param string $newPassword
131
-	 * @param string $oldPassword
132
-	 * @return bool
133
-	 */
134
-	public function changeRecoveryKeyPassword($newPassword, $oldPassword) {
135
-		$recoveryKey = $this->keyManager->getSystemPrivateKey($this->keyManager->getRecoveryKeyId());
136
-		$decryptedRecoveryKey = $this->crypt->decryptPrivateKey($recoveryKey, $oldPassword);
137
-		if($decryptedRecoveryKey === false) {
138
-			return false;
139
-		}
140
-		$encryptedRecoveryKey = $this->crypt->encryptPrivateKey($decryptedRecoveryKey, $newPassword);
141
-		$header = $this->crypt->generateHeader();
142
-		if ($encryptedRecoveryKey) {
143
-			$this->keyManager->setSystemPrivateKey($this->keyManager->getRecoveryKeyId(), $header . $encryptedRecoveryKey);
144
-			return true;
145
-		}
146
-		return false;
147
-	}
148
-
149
-	/**
150
-	 * @param string $recoveryPassword
151
-	 * @return bool
152
-	 */
153
-	public function disableAdminRecovery($recoveryPassword) {
154
-		$keyManager = $this->keyManager;
155
-
156
-		if ($keyManager->checkRecoveryPassword($recoveryPassword)) {
157
-			// Set recoveryAdmin as disabled
158
-			$this->config->setAppValue('encryption', 'recoveryAdminEnabled', 0);
159
-			return true;
160
-		}
161
-		return false;
162
-	}
163
-
164
-	/**
165
-	 * check if recovery is enabled for user
166
-	 *
167
-	 * @param string $user if no user is given we check the current logged-in user
168
-	 *
169
-	 * @return bool
170
-	 */
171
-	public function isRecoveryEnabledForUser($user = '') {
172
-		$uid = empty($user) ? $this->user->getUID() : $user;
173
-		$recoveryMode = $this->config->getUserValue($uid,
174
-			'encryption',
175
-			'recoveryEnabled',
176
-			0);
177
-
178
-		return ($recoveryMode === '1');
179
-	}
180
-
181
-	/**
182
-	 * check if recovery is key is enabled by the administrator
183
-	 *
184
-	 * @return bool
185
-	 */
186
-	public function isRecoveryKeyEnabled() {
187
-		$enabled = $this->config->getAppValue('encryption', 'recoveryAdminEnabled', 0);
188
-
189
-		return ($enabled === '1');
190
-	}
191
-
192
-	/**
193
-	 * @param string $value
194
-	 * @return bool
195
-	 */
196
-	public function setRecoveryForUser($value) {
197
-
198
-		try {
199
-			$this->config->setUserValue($this->user->getUID(),
200
-				'encryption',
201
-				'recoveryEnabled',
202
-				$value);
203
-
204
-			if ($value === '1') {
205
-				$this->addRecoveryKeys('/' . $this->user->getUID() . '/files/');
206
-			} else {
207
-				$this->removeRecoveryKeys('/' . $this->user->getUID() . '/files/');
208
-			}
209
-
210
-			return true;
211
-		} catch (PreConditionNotMetException $e) {
212
-			return false;
213
-		}
214
-	}
215
-
216
-	/**
217
-	 * add recovery key to all encrypted files
218
-	 * @param string $path
219
-	 */
220
-	private function addRecoveryKeys($path) {
221
-		$dirContent = $this->view->getDirectoryContent($path);
222
-		foreach ($dirContent as $item) {
223
-			$filePath = $item->getPath();
224
-			if ($item['type'] === 'dir') {
225
-				$this->addRecoveryKeys($filePath . '/');
226
-			} else {
227
-				$fileKey = $this->keyManager->getFileKey($filePath, $this->user->getUID());
228
-				if (!empty($fileKey)) {
229
-					$accessList = $this->file->getAccessList($filePath);
230
-					$publicKeys = array();
231
-					foreach ($accessList['users'] as $uid) {
232
-						$publicKeys[$uid] = $this->keyManager->getPublicKey($uid);
233
-					}
234
-
235
-					$publicKeys = $this->keyManager->addSystemKeys($accessList, $publicKeys, $this->user->getUID());
236
-
237
-					$encryptedKeyfiles = $this->crypt->multiKeyEncrypt($fileKey, $publicKeys);
238
-					$this->keyManager->setAllFileKeys($filePath, $encryptedKeyfiles);
239
-				}
240
-			}
241
-		}
242
-	}
243
-
244
-	/**
245
-	 * remove recovery key to all encrypted files
246
-	 * @param string $path
247
-	 */
248
-	private function removeRecoveryKeys($path) {
249
-		$dirContent = $this->view->getDirectoryContent($path);
250
-		foreach ($dirContent as $item) {
251
-			$filePath = $item->getPath();
252
-			if ($item['type'] === 'dir') {
253
-				$this->removeRecoveryKeys($filePath . '/');
254
-			} else {
255
-				$this->keyManager->deleteShareKey($filePath, $this->keyManager->getRecoveryKeyId());
256
-			}
257
-		}
258
-	}
259
-
260
-	/**
261
-	 * recover users files with the recovery key
262
-	 *
263
-	 * @param string $recoveryPassword
264
-	 * @param string $user
265
-	 */
266
-	public function recoverUsersFiles($recoveryPassword, $user) {
267
-		$encryptedKey = $this->keyManager->getSystemPrivateKey($this->keyManager->getRecoveryKeyId());
268
-
269
-		$privateKey = $this->crypt->decryptPrivateKey($encryptedKey, $recoveryPassword);
270
-		if($privateKey !== false) {
271
-			$this->recoverAllFiles('/' . $user . '/files/', $privateKey, $user);
272
-		}
273
-	}
274
-
275
-	/**
276
-	 * recover users files
277
-	 *
278
-	 * @param string $path
279
-	 * @param string $privateKey
280
-	 * @param string $uid
281
-	 */
282
-	private function recoverAllFiles($path, $privateKey, $uid) {
283
-		$dirContent = $this->view->getDirectoryContent($path);
284
-
285
-		foreach ($dirContent as $item) {
286
-			// Get relative path from encryption/keyfiles
287
-			$filePath = $item->getPath();
288
-			if ($this->view->is_dir($filePath)) {
289
-				$this->recoverAllFiles($filePath . '/', $privateKey, $uid);
290
-			} else {
291
-				$this->recoverFile($filePath, $privateKey, $uid);
292
-			}
293
-		}
294
-
295
-	}
296
-
297
-	/**
298
-	 * recover file
299
-	 *
300
-	 * @param string $path
301
-	 * @param string $privateKey
302
-	 * @param string $uid
303
-	 */
304
-	private function recoverFile($path, $privateKey, $uid) {
305
-		$encryptedFileKey = $this->keyManager->getEncryptedFileKey($path);
306
-		$shareKey = $this->keyManager->getShareKey($path, $this->keyManager->getRecoveryKeyId());
307
-
308
-		if ($encryptedFileKey && $shareKey && $privateKey) {
309
-			$fileKey = $this->crypt->multiKeyDecrypt($encryptedFileKey,
310
-				$shareKey,
311
-				$privateKey);
312
-		}
313
-
314
-		if (!empty($fileKey)) {
315
-			$accessList = $this->file->getAccessList($path);
316
-			$publicKeys = array();
317
-			foreach ($accessList['users'] as $user) {
318
-				$publicKeys[$user] = $this->keyManager->getPublicKey($user);
319
-			}
320
-
321
-			$publicKeys = $this->keyManager->addSystemKeys($accessList, $publicKeys, $uid);
322
-
323
-			$encryptedKeyfiles = $this->crypt->multiKeyEncrypt($fileKey, $publicKeys);
324
-			$this->keyManager->setAllFileKeys($path, $encryptedKeyfiles);
325
-		}
326
-
327
-	}
41
+    /**
42
+     * @var null|IUser
43
+     */
44
+    protected $user;
45
+    /**
46
+     * @var Crypt
47
+     */
48
+    protected $crypt;
49
+    /**
50
+     * @var ISecureRandom
51
+     */
52
+    private $random;
53
+    /**
54
+     * @var KeyManager
55
+     */
56
+    private $keyManager;
57
+    /**
58
+     * @var IConfig
59
+     */
60
+    private $config;
61
+    /**
62
+     * @var IStorage
63
+     */
64
+    private $keyStorage;
65
+    /**
66
+     * @var View
67
+     */
68
+    private $view;
69
+    /**
70
+     * @var IFile
71
+     */
72
+    private $file;
73
+
74
+    /**
75
+     * @param IUserSession $user
76
+     * @param Crypt $crypt
77
+     * @param ISecureRandom $random
78
+     * @param KeyManager $keyManager
79
+     * @param IConfig $config
80
+     * @param IStorage $keyStorage
81
+     * @param IFile $file
82
+     * @param View $view
83
+     */
84
+    public function __construct(IUserSession $user,
85
+                                Crypt $crypt,
86
+                                ISecureRandom $random,
87
+                                KeyManager $keyManager,
88
+                                IConfig $config,
89
+                                IStorage $keyStorage,
90
+                                IFile $file,
91
+                                View $view) {
92
+        $this->user = ($user && $user->isLoggedIn()) ? $user->getUser() : false;
93
+        $this->crypt = $crypt;
94
+        $this->random = $random;
95
+        $this->keyManager = $keyManager;
96
+        $this->config = $config;
97
+        $this->keyStorage = $keyStorage;
98
+        $this->view = $view;
99
+        $this->file = $file;
100
+    }
101
+
102
+    /**
103
+     * @param string $password
104
+     * @return bool
105
+     */
106
+    public function enableAdminRecovery($password) {
107
+        $appConfig = $this->config;
108
+        $keyManager = $this->keyManager;
109
+
110
+        if (!$keyManager->recoveryKeyExists()) {
111
+            $keyPair = $this->crypt->createKeyPair();
112
+            if(!is_array($keyPair)) {
113
+                return false;
114
+            }
115
+
116
+            $this->keyManager->setRecoveryKey($password, $keyPair);
117
+        }
118
+
119
+        if ($keyManager->checkRecoveryPassword($password)) {
120
+            $appConfig->setAppValue('encryption', 'recoveryAdminEnabled', 1);
121
+            return true;
122
+        }
123
+
124
+        return false;
125
+    }
126
+
127
+    /**
128
+     * change recovery key id
129
+     *
130
+     * @param string $newPassword
131
+     * @param string $oldPassword
132
+     * @return bool
133
+     */
134
+    public function changeRecoveryKeyPassword($newPassword, $oldPassword) {
135
+        $recoveryKey = $this->keyManager->getSystemPrivateKey($this->keyManager->getRecoveryKeyId());
136
+        $decryptedRecoveryKey = $this->crypt->decryptPrivateKey($recoveryKey, $oldPassword);
137
+        if($decryptedRecoveryKey === false) {
138
+            return false;
139
+        }
140
+        $encryptedRecoveryKey = $this->crypt->encryptPrivateKey($decryptedRecoveryKey, $newPassword);
141
+        $header = $this->crypt->generateHeader();
142
+        if ($encryptedRecoveryKey) {
143
+            $this->keyManager->setSystemPrivateKey($this->keyManager->getRecoveryKeyId(), $header . $encryptedRecoveryKey);
144
+            return true;
145
+        }
146
+        return false;
147
+    }
148
+
149
+    /**
150
+     * @param string $recoveryPassword
151
+     * @return bool
152
+     */
153
+    public function disableAdminRecovery($recoveryPassword) {
154
+        $keyManager = $this->keyManager;
155
+
156
+        if ($keyManager->checkRecoveryPassword($recoveryPassword)) {
157
+            // Set recoveryAdmin as disabled
158
+            $this->config->setAppValue('encryption', 'recoveryAdminEnabled', 0);
159
+            return true;
160
+        }
161
+        return false;
162
+    }
163
+
164
+    /**
165
+     * check if recovery is enabled for user
166
+     *
167
+     * @param string $user if no user is given we check the current logged-in user
168
+     *
169
+     * @return bool
170
+     */
171
+    public function isRecoveryEnabledForUser($user = '') {
172
+        $uid = empty($user) ? $this->user->getUID() : $user;
173
+        $recoveryMode = $this->config->getUserValue($uid,
174
+            'encryption',
175
+            'recoveryEnabled',
176
+            0);
177
+
178
+        return ($recoveryMode === '1');
179
+    }
180
+
181
+    /**
182
+     * check if recovery is key is enabled by the administrator
183
+     *
184
+     * @return bool
185
+     */
186
+    public function isRecoveryKeyEnabled() {
187
+        $enabled = $this->config->getAppValue('encryption', 'recoveryAdminEnabled', 0);
188
+
189
+        return ($enabled === '1');
190
+    }
191
+
192
+    /**
193
+     * @param string $value
194
+     * @return bool
195
+     */
196
+    public function setRecoveryForUser($value) {
197
+
198
+        try {
199
+            $this->config->setUserValue($this->user->getUID(),
200
+                'encryption',
201
+                'recoveryEnabled',
202
+                $value);
203
+
204
+            if ($value === '1') {
205
+                $this->addRecoveryKeys('/' . $this->user->getUID() . '/files/');
206
+            } else {
207
+                $this->removeRecoveryKeys('/' . $this->user->getUID() . '/files/');
208
+            }
209
+
210
+            return true;
211
+        } catch (PreConditionNotMetException $e) {
212
+            return false;
213
+        }
214
+    }
215
+
216
+    /**
217
+     * add recovery key to all encrypted files
218
+     * @param string $path
219
+     */
220
+    private function addRecoveryKeys($path) {
221
+        $dirContent = $this->view->getDirectoryContent($path);
222
+        foreach ($dirContent as $item) {
223
+            $filePath = $item->getPath();
224
+            if ($item['type'] === 'dir') {
225
+                $this->addRecoveryKeys($filePath . '/');
226
+            } else {
227
+                $fileKey = $this->keyManager->getFileKey($filePath, $this->user->getUID());
228
+                if (!empty($fileKey)) {
229
+                    $accessList = $this->file->getAccessList($filePath);
230
+                    $publicKeys = array();
231
+                    foreach ($accessList['users'] as $uid) {
232
+                        $publicKeys[$uid] = $this->keyManager->getPublicKey($uid);
233
+                    }
234
+
235
+                    $publicKeys = $this->keyManager->addSystemKeys($accessList, $publicKeys, $this->user->getUID());
236
+
237
+                    $encryptedKeyfiles = $this->crypt->multiKeyEncrypt($fileKey, $publicKeys);
238
+                    $this->keyManager->setAllFileKeys($filePath, $encryptedKeyfiles);
239
+                }
240
+            }
241
+        }
242
+    }
243
+
244
+    /**
245
+     * remove recovery key to all encrypted files
246
+     * @param string $path
247
+     */
248
+    private function removeRecoveryKeys($path) {
249
+        $dirContent = $this->view->getDirectoryContent($path);
250
+        foreach ($dirContent as $item) {
251
+            $filePath = $item->getPath();
252
+            if ($item['type'] === 'dir') {
253
+                $this->removeRecoveryKeys($filePath . '/');
254
+            } else {
255
+                $this->keyManager->deleteShareKey($filePath, $this->keyManager->getRecoveryKeyId());
256
+            }
257
+        }
258
+    }
259
+
260
+    /**
261
+     * recover users files with the recovery key
262
+     *
263
+     * @param string $recoveryPassword
264
+     * @param string $user
265
+     */
266
+    public function recoverUsersFiles($recoveryPassword, $user) {
267
+        $encryptedKey = $this->keyManager->getSystemPrivateKey($this->keyManager->getRecoveryKeyId());
268
+
269
+        $privateKey = $this->crypt->decryptPrivateKey($encryptedKey, $recoveryPassword);
270
+        if($privateKey !== false) {
271
+            $this->recoverAllFiles('/' . $user . '/files/', $privateKey, $user);
272
+        }
273
+    }
274
+
275
+    /**
276
+     * recover users files
277
+     *
278
+     * @param string $path
279
+     * @param string $privateKey
280
+     * @param string $uid
281
+     */
282
+    private function recoverAllFiles($path, $privateKey, $uid) {
283
+        $dirContent = $this->view->getDirectoryContent($path);
284
+
285
+        foreach ($dirContent as $item) {
286
+            // Get relative path from encryption/keyfiles
287
+            $filePath = $item->getPath();
288
+            if ($this->view->is_dir($filePath)) {
289
+                $this->recoverAllFiles($filePath . '/', $privateKey, $uid);
290
+            } else {
291
+                $this->recoverFile($filePath, $privateKey, $uid);
292
+            }
293
+        }
294
+
295
+    }
296
+
297
+    /**
298
+     * recover file
299
+     *
300
+     * @param string $path
301
+     * @param string $privateKey
302
+     * @param string $uid
303
+     */
304
+    private function recoverFile($path, $privateKey, $uid) {
305
+        $encryptedFileKey = $this->keyManager->getEncryptedFileKey($path);
306
+        $shareKey = $this->keyManager->getShareKey($path, $this->keyManager->getRecoveryKeyId());
307
+
308
+        if ($encryptedFileKey && $shareKey && $privateKey) {
309
+            $fileKey = $this->crypt->multiKeyDecrypt($encryptedFileKey,
310
+                $shareKey,
311
+                $privateKey);
312
+        }
313
+
314
+        if (!empty($fileKey)) {
315
+            $accessList = $this->file->getAccessList($path);
316
+            $publicKeys = array();
317
+            foreach ($accessList['users'] as $user) {
318
+                $publicKeys[$user] = $this->keyManager->getPublicKey($user);
319
+            }
320
+
321
+            $publicKeys = $this->keyManager->addSystemKeys($accessList, $publicKeys, $uid);
322
+
323
+            $encryptedKeyfiles = $this->crypt->multiKeyEncrypt($fileKey, $publicKeys);
324
+            $this->keyManager->setAllFileKeys($path, $encryptedKeyfiles);
325
+        }
326
+
327
+    }
328 328
 
329 329
 
330 330
 }
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 
110 110
 		if (!$keyManager->recoveryKeyExists()) {
111 111
 			$keyPair = $this->crypt->createKeyPair();
112
-			if(!is_array($keyPair)) {
112
+			if (!is_array($keyPair)) {
113 113
 				return false;
114 114
 			}
115 115
 
@@ -134,13 +134,13 @@  discard block
 block discarded – undo
134 134
 	public function changeRecoveryKeyPassword($newPassword, $oldPassword) {
135 135
 		$recoveryKey = $this->keyManager->getSystemPrivateKey($this->keyManager->getRecoveryKeyId());
136 136
 		$decryptedRecoveryKey = $this->crypt->decryptPrivateKey($recoveryKey, $oldPassword);
137
-		if($decryptedRecoveryKey === false) {
137
+		if ($decryptedRecoveryKey === false) {
138 138
 			return false;
139 139
 		}
140 140
 		$encryptedRecoveryKey = $this->crypt->encryptPrivateKey($decryptedRecoveryKey, $newPassword);
141 141
 		$header = $this->crypt->generateHeader();
142 142
 		if ($encryptedRecoveryKey) {
143
-			$this->keyManager->setSystemPrivateKey($this->keyManager->getRecoveryKeyId(), $header . $encryptedRecoveryKey);
143
+			$this->keyManager->setSystemPrivateKey($this->keyManager->getRecoveryKeyId(), $header.$encryptedRecoveryKey);
144 144
 			return true;
145 145
 		}
146 146
 		return false;
@@ -202,9 +202,9 @@  discard block
 block discarded – undo
202 202
 				$value);
203 203
 
204 204
 			if ($value === '1') {
205
-				$this->addRecoveryKeys('/' . $this->user->getUID() . '/files/');
205
+				$this->addRecoveryKeys('/'.$this->user->getUID().'/files/');
206 206
 			} else {
207
-				$this->removeRecoveryKeys('/' . $this->user->getUID() . '/files/');
207
+				$this->removeRecoveryKeys('/'.$this->user->getUID().'/files/');
208 208
 			}
209 209
 
210 210
 			return true;
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 		foreach ($dirContent as $item) {
223 223
 			$filePath = $item->getPath();
224 224
 			if ($item['type'] === 'dir') {
225
-				$this->addRecoveryKeys($filePath . '/');
225
+				$this->addRecoveryKeys($filePath.'/');
226 226
 			} else {
227 227
 				$fileKey = $this->keyManager->getFileKey($filePath, $this->user->getUID());
228 228
 				if (!empty($fileKey)) {
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
 		foreach ($dirContent as $item) {
251 251
 			$filePath = $item->getPath();
252 252
 			if ($item['type'] === 'dir') {
253
-				$this->removeRecoveryKeys($filePath . '/');
253
+				$this->removeRecoveryKeys($filePath.'/');
254 254
 			} else {
255 255
 				$this->keyManager->deleteShareKey($filePath, $this->keyManager->getRecoveryKeyId());
256 256
 			}
@@ -267,8 +267,8 @@  discard block
 block discarded – undo
267 267
 		$encryptedKey = $this->keyManager->getSystemPrivateKey($this->keyManager->getRecoveryKeyId());
268 268
 
269 269
 		$privateKey = $this->crypt->decryptPrivateKey($encryptedKey, $recoveryPassword);
270
-		if($privateKey !== false) {
271
-			$this->recoverAllFiles('/' . $user . '/files/', $privateKey, $user);
270
+		if ($privateKey !== false) {
271
+			$this->recoverAllFiles('/'.$user.'/files/', $privateKey, $user);
272 272
 		}
273 273
 	}
274 274
 
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
 			// Get relative path from encryption/keyfiles
287 287
 			$filePath = $item->getPath();
288 288
 			if ($this->view->is_dir($filePath)) {
289
-				$this->recoverAllFiles($filePath . '/', $privateKey, $uid);
289
+				$this->recoverAllFiles($filePath.'/', $privateKey, $uid);
290 290
 			} else {
291 291
 				$this->recoverFile($filePath, $privateKey, $uid);
292 292
 			}
Please login to merge, or discard this patch.
apps/encryption/lib/Command/MigrateKeys.php 2 patches
Indentation   +76 added lines, -76 removed lines patch added patch discarded remove patch
@@ -36,91 +36,91 @@
 block discarded – undo
36 36
 
37 37
 class MigrateKeys extends Command {
38 38
 
39
-	/** @var IUserManager */
40
-	private $userManager;
41
-	/** @var View */
42
-	private $view;
43
-	/** @var IDBConnection */
44
-	private $connection;
45
-	/** @var IConfig */
46
-	private $config;
47
-	/** @var  ILogger */
48
-	private $logger;
39
+    /** @var IUserManager */
40
+    private $userManager;
41
+    /** @var View */
42
+    private $view;
43
+    /** @var IDBConnection */
44
+    private $connection;
45
+    /** @var IConfig */
46
+    private $config;
47
+    /** @var  ILogger */
48
+    private $logger;
49 49
 
50
-	/**
51
-	 * @param IUserManager $userManager
52
-	 * @param View $view
53
-	 * @param IDBConnection $connection
54
-	 * @param IConfig $config
55
-	 * @param ILogger $logger
56
-	 */
57
-	public function __construct(IUserManager $userManager,
58
-								View $view,
59
-								IDBConnection $connection,
60
-								IConfig $config,
61
-								ILogger $logger) {
50
+    /**
51
+     * @param IUserManager $userManager
52
+     * @param View $view
53
+     * @param IDBConnection $connection
54
+     * @param IConfig $config
55
+     * @param ILogger $logger
56
+     */
57
+    public function __construct(IUserManager $userManager,
58
+                                View $view,
59
+                                IDBConnection $connection,
60
+                                IConfig $config,
61
+                                ILogger $logger) {
62 62
 
63
-		$this->userManager = $userManager;
64
-		$this->view = $view;
65
-		$this->connection = $connection;
66
-		$this->config = $config;
67
-		$this->logger = $logger;
68
-		parent::__construct();
69
-	}
63
+        $this->userManager = $userManager;
64
+        $this->view = $view;
65
+        $this->connection = $connection;
66
+        $this->config = $config;
67
+        $this->logger = $logger;
68
+        parent::__construct();
69
+    }
70 70
 
71
-	protected function configure() {
72
-		$this
73
-			->setName('encryption:migrate')
74
-			->setDescription('initial migration to encryption 2.0')
75
-			->addArgument(
76
-				'user_id',
77
-				InputArgument::OPTIONAL | InputArgument::IS_ARRAY,
78
-				'will migrate keys of the given user(s)'
79
-			);
80
-	}
71
+    protected function configure() {
72
+        $this
73
+            ->setName('encryption:migrate')
74
+            ->setDescription('initial migration to encryption 2.0')
75
+            ->addArgument(
76
+                'user_id',
77
+                InputArgument::OPTIONAL | InputArgument::IS_ARRAY,
78
+                'will migrate keys of the given user(s)'
79
+            );
80
+    }
81 81
 
82
-	protected function execute(InputInterface $input, OutputInterface $output) {
82
+    protected function execute(InputInterface $input, OutputInterface $output) {
83 83
 
84
-		// perform system reorganization
85
-		$migration = new Migration($this->config, $this->view, $this->connection, $this->logger);
84
+        // perform system reorganization
85
+        $migration = new Migration($this->config, $this->view, $this->connection, $this->logger);
86 86
 
87
-		$users = $input->getArgument('user_id');
88
-		if (!empty($users)) {
89
-			foreach ($users as $user) {
90
-				if ($this->userManager->userExists($user)) {
91
-					$output->writeln("Migrating keys   <info>$user</info>");
92
-					$migration->reorganizeFolderStructureForUser($user);
93
-				} else {
94
-					$output->writeln("<error>Unknown user $user</error>");
95
-				}
96
-			}
97
-		} else {
98
-			$output->writeln("Reorganize system folder structure");
99
-			$migration->reorganizeSystemFolderStructure();
100
-			$migration->updateDB();
101
-			foreach($this->userManager->getBackends() as $backend) {
102
-				$name = get_class($backend);
87
+        $users = $input->getArgument('user_id');
88
+        if (!empty($users)) {
89
+            foreach ($users as $user) {
90
+                if ($this->userManager->userExists($user)) {
91
+                    $output->writeln("Migrating keys   <info>$user</info>");
92
+                    $migration->reorganizeFolderStructureForUser($user);
93
+                } else {
94
+                    $output->writeln("<error>Unknown user $user</error>");
95
+                }
96
+            }
97
+        } else {
98
+            $output->writeln("Reorganize system folder structure");
99
+            $migration->reorganizeSystemFolderStructure();
100
+            $migration->updateDB();
101
+            foreach($this->userManager->getBackends() as $backend) {
102
+                $name = get_class($backend);
103 103
 
104
-				if ($backend instanceof IUserBackend) {
105
-					$name = $backend->getBackendName();
106
-				}
104
+                if ($backend instanceof IUserBackend) {
105
+                    $name = $backend->getBackendName();
106
+                }
107 107
 
108
-				$output->writeln("Migrating keys for users on backend <info>$name</info>");
108
+                $output->writeln("Migrating keys for users on backend <info>$name</info>");
109 109
 
110
-				$limit = 500;
111
-				$offset = 0;
112
-				do {
113
-					$users = $backend->getUsers('', $limit, $offset);
114
-					foreach ($users as $user) {
115
-						$output->writeln("   <info>$user</info>");
116
-						$migration->reorganizeFolderStructureForUser($user);
117
-					}
118
-					$offset += $limit;
119
-				} while(count($users) >= $limit);
120
-			}
121
-		}
110
+                $limit = 500;
111
+                $offset = 0;
112
+                do {
113
+                    $users = $backend->getUsers('', $limit, $offset);
114
+                    foreach ($users as $user) {
115
+                        $output->writeln("   <info>$user</info>");
116
+                        $migration->reorganizeFolderStructureForUser($user);
117
+                    }
118
+                    $offset += $limit;
119
+                } while(count($users) >= $limit);
120
+            }
121
+        }
122 122
 
123
-		$migration->finalCleanUp();
123
+        $migration->finalCleanUp();
124 124
 
125
-	}
125
+    }
126 126
 }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 			$output->writeln("Reorganize system folder structure");
99 99
 			$migration->reorganizeSystemFolderStructure();
100 100
 			$migration->updateDB();
101
-			foreach($this->userManager->getBackends() as $backend) {
101
+			foreach ($this->userManager->getBackends() as $backend) {
102 102
 				$name = get_class($backend);
103 103
 
104 104
 				if ($backend instanceof IUserBackend) {
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 						$migration->reorganizeFolderStructureForUser($user);
117 117
 					}
118 118
 					$offset += $limit;
119
-				} while(count($users) >= $limit);
119
+				} while (count($users) >= $limit);
120 120
 			}
121 121
 		}
122 122
 
Please login to merge, or discard this patch.
apps/encryption/lib/Command/EnableMasterKey.php 2 patches
Indentation   +49 added lines, -49 removed lines patch added patch discarded remove patch
@@ -34,54 +34,54 @@
 block discarded – undo
34 34
 
35 35
 class EnableMasterKey extends Command {
36 36
 
37
-	/** @var Util */
38
-	protected $util;
39
-
40
-	/** @var IConfig */
41
-	protected $config;
42
-
43
-	/** @var  QuestionHelper */
44
-	protected $questionHelper;
45
-
46
-	/**
47
-	 * @param Util $util
48
-	 * @param IConfig $config
49
-	 * @param QuestionHelper $questionHelper
50
-	 */
51
-	public function __construct(Util $util,
52
-								IConfig $config,
53
-								QuestionHelper $questionHelper) {
54
-
55
-		$this->util = $util;
56
-		$this->config = $config;
57
-		$this->questionHelper = $questionHelper;
58
-		parent::__construct();
59
-	}
60
-
61
-	protected function configure() {
62
-		$this
63
-			->setName('encryption:enable-master-key')
64
-			->setDescription('Enable the master key. Only available for fresh installations with no existing encrypted data! There is also no way to disable it again.');
65
-	}
66
-
67
-	protected function execute(InputInterface $input, OutputInterface $output) {
68
-
69
-		$isAlreadyEnabled = $this->util->isMasterKeyEnabled();
70
-
71
-		if($isAlreadyEnabled) {
72
-			$output->writeln('Master key already enabled');
73
-		} else {
74
-			$question = new ConfirmationQuestion(
75
-				'Warning: Only available for fresh installations with no existing encrypted data! '
76
-			. 'There is also no way to disable it again. Do you want to continue? (y/n) ', false);
77
-			if ($this->questionHelper->ask($input, $output, $question)) {
78
-				$this->config->setAppValue('encryption', 'useMasterKey', '1');
79
-				$output->writeln('Master key successfully enabled.');
80
-			} else {
81
-				$output->writeln('aborted.');
82
-			}
83
-		}
84
-
85
-	}
37
+    /** @var Util */
38
+    protected $util;
39
+
40
+    /** @var IConfig */
41
+    protected $config;
42
+
43
+    /** @var  QuestionHelper */
44
+    protected $questionHelper;
45
+
46
+    /**
47
+     * @param Util $util
48
+     * @param IConfig $config
49
+     * @param QuestionHelper $questionHelper
50
+     */
51
+    public function __construct(Util $util,
52
+                                IConfig $config,
53
+                                QuestionHelper $questionHelper) {
54
+
55
+        $this->util = $util;
56
+        $this->config = $config;
57
+        $this->questionHelper = $questionHelper;
58
+        parent::__construct();
59
+    }
60
+
61
+    protected function configure() {
62
+        $this
63
+            ->setName('encryption:enable-master-key')
64
+            ->setDescription('Enable the master key. Only available for fresh installations with no existing encrypted data! There is also no way to disable it again.');
65
+    }
66
+
67
+    protected function execute(InputInterface $input, OutputInterface $output) {
68
+
69
+        $isAlreadyEnabled = $this->util->isMasterKeyEnabled();
70
+
71
+        if($isAlreadyEnabled) {
72
+            $output->writeln('Master key already enabled');
73
+        } else {
74
+            $question = new ConfirmationQuestion(
75
+                'Warning: Only available for fresh installations with no existing encrypted data! '
76
+            . 'There is also no way to disable it again. Do you want to continue? (y/n) ', false);
77
+            if ($this->questionHelper->ask($input, $output, $question)) {
78
+                $this->config->setAppValue('encryption', 'useMasterKey', '1');
79
+                $output->writeln('Master key successfully enabled.');
80
+            } else {
81
+                $output->writeln('aborted.');
82
+            }
83
+        }
84
+
85
+    }
86 86
 
87 87
 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
 
69 69
 		$isAlreadyEnabled = $this->util->isMasterKeyEnabled();
70 70
 
71
-		if($isAlreadyEnabled) {
71
+		if ($isAlreadyEnabled) {
72 72
 			$output->writeln('Master key already enabled');
73 73
 		} else {
74 74
 			$question = new ConfirmationQuestion(
Please login to merge, or discard this patch.
apps/encryption/lib/Hooks/UserHooks.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
 			// Save private key
277 277
 			if ($encryptedPrivateKey) {
278 278
 				$this->keyManager->setPrivateKey($this->user->getUser()->getUID(),
279
-					$this->crypt->generateHeader() . $encryptedPrivateKey);
279
+					$this->crypt->generateHeader().$encryptedPrivateKey);
280 280
 			} else {
281 281
 				$this->logger->error('Encryption could not update users encryption password');
282 282
 			}
@@ -313,7 +313,7 @@  discard block
 block discarded – undo
313 313
 				$encryptedKey = $this->crypt->encryptPrivateKey($keyPair['privateKey'], $newUserPassword, $user);
314 314
 
315 315
 				if ($encryptedKey) {
316
-					$this->keyManager->setPrivateKey($user, $this->crypt->generateHeader() . $encryptedKey);
316
+					$this->keyManager->setPrivateKey($user, $this->crypt->generateHeader().$encryptedKey);
317 317
 
318 318
 					if ($recoveryPassword) { // if recovery key is set we can re-encrypt the key files
319 319
 						$this->recovery->recoverUsersFiles($recoveryPassword, $user);
Please login to merge, or discard this patch.
Indentation   +302 added lines, -302 removed lines patch added patch discarded remove patch
@@ -41,306 +41,306 @@
 block discarded – undo
41 41
 
42 42
 class UserHooks implements IHook {
43 43
 
44
-	/**
45
-	 * list of user for which we perform a password reset
46
-	 * @var array
47
-	 */
48
-	protected static $passwordResetUsers = [];
49
-
50
-	/**
51
-	 * @var KeyManager
52
-	 */
53
-	private $keyManager;
54
-	/**
55
-	 * @var IUserManager
56
-	 */
57
-	private $userManager;
58
-	/**
59
-	 * @var ILogger
60
-	 */
61
-	private $logger;
62
-	/**
63
-	 * @var Setup
64
-	 */
65
-	private $userSetup;
66
-	/**
67
-	 * @var IUserSession
68
-	 */
69
-	private $user;
70
-	/**
71
-	 * @var Util
72
-	 */
73
-	private $util;
74
-	/**
75
-	 * @var Session
76
-	 */
77
-	private $session;
78
-	/**
79
-	 * @var Recovery
80
-	 */
81
-	private $recovery;
82
-	/**
83
-	 * @var Crypt
84
-	 */
85
-	private $crypt;
86
-
87
-	/**
88
-	 * UserHooks constructor.
89
-	 *
90
-	 * @param KeyManager $keyManager
91
-	 * @param IUserManager $userManager
92
-	 * @param ILogger $logger
93
-	 * @param Setup $userSetup
94
-	 * @param IUserSession $user
95
-	 * @param Util $util
96
-	 * @param Session $session
97
-	 * @param Crypt $crypt
98
-	 * @param Recovery $recovery
99
-	 */
100
-	public function __construct(KeyManager $keyManager,
101
-								IUserManager $userManager,
102
-								ILogger $logger,
103
-								Setup $userSetup,
104
-								IUserSession $user,
105
-								Util $util,
106
-								Session $session,
107
-								Crypt $crypt,
108
-								Recovery $recovery) {
109
-
110
-		$this->keyManager = $keyManager;
111
-		$this->userManager = $userManager;
112
-		$this->logger = $logger;
113
-		$this->userSetup = $userSetup;
114
-		$this->user = $user;
115
-		$this->util = $util;
116
-		$this->session = $session;
117
-		$this->recovery = $recovery;
118
-		$this->crypt = $crypt;
119
-	}
120
-
121
-	/**
122
-	 * Connects Hooks
123
-	 *
124
-	 * @return null
125
-	 */
126
-	public function addHooks() {
127
-		OCUtil::connectHook('OC_User', 'post_login', $this, 'login');
128
-		OCUtil::connectHook('OC_User', 'logout', $this, 'logout');
129
-
130
-		// this hooks only make sense if no master key is used
131
-		if ($this->util->isMasterKeyEnabled() === false) {
132
-			OCUtil::connectHook('OC_User',
133
-				'post_setPassword',
134
-				$this,
135
-				'setPassphrase');
136
-
137
-			OCUtil::connectHook('OC_User',
138
-				'pre_setPassword',
139
-				$this,
140
-				'preSetPassphrase');
141
-
142
-			OCUtil::connectHook('\OC\Core\LostPassword\Controller\LostController',
143
-				'post_passwordReset',
144
-				$this,
145
-				'postPasswordReset');
146
-
147
-			OCUtil::connectHook('\OC\Core\LostPassword\Controller\LostController',
148
-				'pre_passwordReset',
149
-				$this,
150
-				'prePasswordReset');
151
-
152
-			OCUtil::connectHook('OC_User',
153
-				'post_createUser',
154
-				$this,
155
-				'postCreateUser');
156
-
157
-			OCUtil::connectHook('OC_User',
158
-				'post_deleteUser',
159
-				$this,
160
-				'postDeleteUser');
161
-		}
162
-	}
163
-
164
-
165
-	/**
166
-	 * Startup encryption backend upon user login
167
-	 *
168
-	 * @note This method should never be called for users using client side encryption
169
-	 * @param array $params
170
-	 * @return boolean|null
171
-	 */
172
-	public function login($params) {
173
-
174
-		if (!App::isEnabled('encryption')) {
175
-			return true;
176
-		}
177
-
178
-		// ensure filesystem is loaded
179
-		if (!\OC\Files\Filesystem::$loaded) {
180
-			$this->setupFS($params['uid']);
181
-		}
182
-		if ($this->util->isMasterKeyEnabled() === false) {
183
-			$this->userSetup->setupUser($params['uid'], $params['password']);
184
-		}
185
-
186
-		$this->keyManager->init($params['uid'], $params['password']);
187
-	}
188
-
189
-	/**
190
-	 * remove keys from session during logout
191
-	 */
192
-	public function logout() {
193
-		$this->session->clear();
194
-	}
195
-
196
-	/**
197
-	 * setup encryption backend upon user created
198
-	 *
199
-	 * @note This method should never be called for users using client side encryption
200
-	 * @param array $params
201
-	 */
202
-	public function postCreateUser($params) {
203
-
204
-		if (App::isEnabled('encryption')) {
205
-			$this->userSetup->setupUser($params['uid'], $params['password']);
206
-		}
207
-	}
208
-
209
-	/**
210
-	 * cleanup encryption backend upon user deleted
211
-	 *
212
-	 * @param array $params : uid, password
213
-	 * @note This method should never be called for users using client side encryption
214
-	 */
215
-	public function postDeleteUser($params) {
216
-
217
-		if (App::isEnabled('encryption')) {
218
-			$this->keyManager->deletePublicKey($params['uid']);
219
-		}
220
-	}
221
-
222
-	public function prePasswordReset($params) {
223
-		if (App::isEnabled('encryption')) {
224
-			$user = $params['uid'];
225
-			self::$passwordResetUsers[$user] = true;
226
-		}
227
-	}
228
-
229
-	public function postPasswordReset($params) {
230
-		$uid = $params['uid'];
231
-		$password = $params['password'];
232
-		$this->keyManager->backupUserKeys('passwordReset', $uid);
233
-		$this->keyManager->deleteUserKeys($uid);
234
-		$this->userSetup->setupUser($uid, $password);
235
-		unset(self::$passwordResetUsers[$uid]);
236
-	}
237
-
238
-	/**
239
-	 * If the password can't be changed within Nextcloud, than update the key password in advance.
240
-	 *
241
-	 * @param array $params : uid, password
242
-	 * @return boolean|null
243
-	 */
244
-	public function preSetPassphrase($params) {
245
-		$user = $this->userManager->get($params['uid']);
246
-
247
-		if ($user && !$user->canChangePassword()) {
248
-			$this->setPassphrase($params);
249
-		}
250
-	}
251
-
252
-	/**
253
-	 * Change a user's encryption passphrase
254
-	 *
255
-	 * @param array $params keys: uid, password
256
-	 * @return boolean|null
257
-	 */
258
-	public function setPassphrase($params) {
259
-
260
-		// if we are in the process to resetting a user password, we have nothing
261
-		// to do here
262
-		if (isset(self::$passwordResetUsers[$params['uid']])) {
263
-			return true;
264
-		}
265
-
266
-		// Get existing decrypted private key
267
-		$privateKey = $this->session->getPrivateKey();
268
-		$user = $this->user->getUser();
269
-
270
-		// current logged in user changes his own password
271
-		if ($user && $params['uid'] === $user->getUID() && $privateKey) {
272
-
273
-			// Encrypt private key with new user pwd as passphrase
274
-			$encryptedPrivateKey = $this->crypt->encryptPrivateKey($privateKey, $params['password'], $params['uid']);
275
-
276
-			// Save private key
277
-			if ($encryptedPrivateKey) {
278
-				$this->keyManager->setPrivateKey($this->user->getUser()->getUID(),
279
-					$this->crypt->generateHeader() . $encryptedPrivateKey);
280
-			} else {
281
-				$this->logger->error('Encryption could not update users encryption password');
282
-			}
283
-
284
-			// NOTE: Session does not need to be updated as the
285
-			// private key has not changed, only the passphrase
286
-			// used to decrypt it has changed
287
-		} else { // admin changed the password for a different user, create new keys and re-encrypt file keys
288
-			$user = $params['uid'];
289
-			$this->initMountPoints($user);
290
-			$recoveryPassword = isset($params['recoveryPassword']) ? $params['recoveryPassword'] : null;
291
-
292
-			// we generate new keys if...
293
-			// ...we have a recovery password and the user enabled the recovery key
294
-			// ...encryption was activated for the first time (no keys exists)
295
-			// ...the user doesn't have any files
296
-			if (
297
-				($this->recovery->isRecoveryEnabledForUser($user) && $recoveryPassword)
298
-				|| !$this->keyManager->userHasKeys($user)
299
-				|| !$this->util->userHasFiles($user)
300
-			) {
301
-
302
-				// backup old keys
303
-				//$this->backupAllKeys('recovery');
304
-
305
-				$newUserPassword = $params['password'];
306
-
307
-				$keyPair = $this->crypt->createKeyPair();
308
-
309
-				// Save public key
310
-				$this->keyManager->setPublicKey($user, $keyPair['publicKey']);
311
-
312
-				// Encrypt private key with new password
313
-				$encryptedKey = $this->crypt->encryptPrivateKey($keyPair['privateKey'], $newUserPassword, $user);
314
-
315
-				if ($encryptedKey) {
316
-					$this->keyManager->setPrivateKey($user, $this->crypt->generateHeader() . $encryptedKey);
317
-
318
-					if ($recoveryPassword) { // if recovery key is set we can re-encrypt the key files
319
-						$this->recovery->recoverUsersFiles($recoveryPassword, $user);
320
-					}
321
-				} else {
322
-					$this->logger->error('Encryption Could not update users encryption password');
323
-				}
324
-			}
325
-		}
326
-	}
327
-
328
-	/**
329
-	 * init mount points for given user
330
-	 *
331
-	 * @param string $user
332
-	 * @throws \OC\User\NoUserException
333
-	 */
334
-	protected function initMountPoints($user) {
335
-		Filesystem::initMountPoints($user);
336
-	}
337
-
338
-	/**
339
-	 * setup file system for user
340
-	 *
341
-	 * @param string $uid user id
342
-	 */
343
-	protected function setupFS($uid) {
344
-		\OC_Util::setupFS($uid);
345
-	}
44
+    /**
45
+     * list of user for which we perform a password reset
46
+     * @var array
47
+     */
48
+    protected static $passwordResetUsers = [];
49
+
50
+    /**
51
+     * @var KeyManager
52
+     */
53
+    private $keyManager;
54
+    /**
55
+     * @var IUserManager
56
+     */
57
+    private $userManager;
58
+    /**
59
+     * @var ILogger
60
+     */
61
+    private $logger;
62
+    /**
63
+     * @var Setup
64
+     */
65
+    private $userSetup;
66
+    /**
67
+     * @var IUserSession
68
+     */
69
+    private $user;
70
+    /**
71
+     * @var Util
72
+     */
73
+    private $util;
74
+    /**
75
+     * @var Session
76
+     */
77
+    private $session;
78
+    /**
79
+     * @var Recovery
80
+     */
81
+    private $recovery;
82
+    /**
83
+     * @var Crypt
84
+     */
85
+    private $crypt;
86
+
87
+    /**
88
+     * UserHooks constructor.
89
+     *
90
+     * @param KeyManager $keyManager
91
+     * @param IUserManager $userManager
92
+     * @param ILogger $logger
93
+     * @param Setup $userSetup
94
+     * @param IUserSession $user
95
+     * @param Util $util
96
+     * @param Session $session
97
+     * @param Crypt $crypt
98
+     * @param Recovery $recovery
99
+     */
100
+    public function __construct(KeyManager $keyManager,
101
+                                IUserManager $userManager,
102
+                                ILogger $logger,
103
+                                Setup $userSetup,
104
+                                IUserSession $user,
105
+                                Util $util,
106
+                                Session $session,
107
+                                Crypt $crypt,
108
+                                Recovery $recovery) {
109
+
110
+        $this->keyManager = $keyManager;
111
+        $this->userManager = $userManager;
112
+        $this->logger = $logger;
113
+        $this->userSetup = $userSetup;
114
+        $this->user = $user;
115
+        $this->util = $util;
116
+        $this->session = $session;
117
+        $this->recovery = $recovery;
118
+        $this->crypt = $crypt;
119
+    }
120
+
121
+    /**
122
+     * Connects Hooks
123
+     *
124
+     * @return null
125
+     */
126
+    public function addHooks() {
127
+        OCUtil::connectHook('OC_User', 'post_login', $this, 'login');
128
+        OCUtil::connectHook('OC_User', 'logout', $this, 'logout');
129
+
130
+        // this hooks only make sense if no master key is used
131
+        if ($this->util->isMasterKeyEnabled() === false) {
132
+            OCUtil::connectHook('OC_User',
133
+                'post_setPassword',
134
+                $this,
135
+                'setPassphrase');
136
+
137
+            OCUtil::connectHook('OC_User',
138
+                'pre_setPassword',
139
+                $this,
140
+                'preSetPassphrase');
141
+
142
+            OCUtil::connectHook('\OC\Core\LostPassword\Controller\LostController',
143
+                'post_passwordReset',
144
+                $this,
145
+                'postPasswordReset');
146
+
147
+            OCUtil::connectHook('\OC\Core\LostPassword\Controller\LostController',
148
+                'pre_passwordReset',
149
+                $this,
150
+                'prePasswordReset');
151
+
152
+            OCUtil::connectHook('OC_User',
153
+                'post_createUser',
154
+                $this,
155
+                'postCreateUser');
156
+
157
+            OCUtil::connectHook('OC_User',
158
+                'post_deleteUser',
159
+                $this,
160
+                'postDeleteUser');
161
+        }
162
+    }
163
+
164
+
165
+    /**
166
+     * Startup encryption backend upon user login
167
+     *
168
+     * @note This method should never be called for users using client side encryption
169
+     * @param array $params
170
+     * @return boolean|null
171
+     */
172
+    public function login($params) {
173
+
174
+        if (!App::isEnabled('encryption')) {
175
+            return true;
176
+        }
177
+
178
+        // ensure filesystem is loaded
179
+        if (!\OC\Files\Filesystem::$loaded) {
180
+            $this->setupFS($params['uid']);
181
+        }
182
+        if ($this->util->isMasterKeyEnabled() === false) {
183
+            $this->userSetup->setupUser($params['uid'], $params['password']);
184
+        }
185
+
186
+        $this->keyManager->init($params['uid'], $params['password']);
187
+    }
188
+
189
+    /**
190
+     * remove keys from session during logout
191
+     */
192
+    public function logout() {
193
+        $this->session->clear();
194
+    }
195
+
196
+    /**
197
+     * setup encryption backend upon user created
198
+     *
199
+     * @note This method should never be called for users using client side encryption
200
+     * @param array $params
201
+     */
202
+    public function postCreateUser($params) {
203
+
204
+        if (App::isEnabled('encryption')) {
205
+            $this->userSetup->setupUser($params['uid'], $params['password']);
206
+        }
207
+    }
208
+
209
+    /**
210
+     * cleanup encryption backend upon user deleted
211
+     *
212
+     * @param array $params : uid, password
213
+     * @note This method should never be called for users using client side encryption
214
+     */
215
+    public function postDeleteUser($params) {
216
+
217
+        if (App::isEnabled('encryption')) {
218
+            $this->keyManager->deletePublicKey($params['uid']);
219
+        }
220
+    }
221
+
222
+    public function prePasswordReset($params) {
223
+        if (App::isEnabled('encryption')) {
224
+            $user = $params['uid'];
225
+            self::$passwordResetUsers[$user] = true;
226
+        }
227
+    }
228
+
229
+    public function postPasswordReset($params) {
230
+        $uid = $params['uid'];
231
+        $password = $params['password'];
232
+        $this->keyManager->backupUserKeys('passwordReset', $uid);
233
+        $this->keyManager->deleteUserKeys($uid);
234
+        $this->userSetup->setupUser($uid, $password);
235
+        unset(self::$passwordResetUsers[$uid]);
236
+    }
237
+
238
+    /**
239
+     * If the password can't be changed within Nextcloud, than update the key password in advance.
240
+     *
241
+     * @param array $params : uid, password
242
+     * @return boolean|null
243
+     */
244
+    public function preSetPassphrase($params) {
245
+        $user = $this->userManager->get($params['uid']);
246
+
247
+        if ($user && !$user->canChangePassword()) {
248
+            $this->setPassphrase($params);
249
+        }
250
+    }
251
+
252
+    /**
253
+     * Change a user's encryption passphrase
254
+     *
255
+     * @param array $params keys: uid, password
256
+     * @return boolean|null
257
+     */
258
+    public function setPassphrase($params) {
259
+
260
+        // if we are in the process to resetting a user password, we have nothing
261
+        // to do here
262
+        if (isset(self::$passwordResetUsers[$params['uid']])) {
263
+            return true;
264
+        }
265
+
266
+        // Get existing decrypted private key
267
+        $privateKey = $this->session->getPrivateKey();
268
+        $user = $this->user->getUser();
269
+
270
+        // current logged in user changes his own password
271
+        if ($user && $params['uid'] === $user->getUID() && $privateKey) {
272
+
273
+            // Encrypt private key with new user pwd as passphrase
274
+            $encryptedPrivateKey = $this->crypt->encryptPrivateKey($privateKey, $params['password'], $params['uid']);
275
+
276
+            // Save private key
277
+            if ($encryptedPrivateKey) {
278
+                $this->keyManager->setPrivateKey($this->user->getUser()->getUID(),
279
+                    $this->crypt->generateHeader() . $encryptedPrivateKey);
280
+            } else {
281
+                $this->logger->error('Encryption could not update users encryption password');
282
+            }
283
+
284
+            // NOTE: Session does not need to be updated as the
285
+            // private key has not changed, only the passphrase
286
+            // used to decrypt it has changed
287
+        } else { // admin changed the password for a different user, create new keys and re-encrypt file keys
288
+            $user = $params['uid'];
289
+            $this->initMountPoints($user);
290
+            $recoveryPassword = isset($params['recoveryPassword']) ? $params['recoveryPassword'] : null;
291
+
292
+            // we generate new keys if...
293
+            // ...we have a recovery password and the user enabled the recovery key
294
+            // ...encryption was activated for the first time (no keys exists)
295
+            // ...the user doesn't have any files
296
+            if (
297
+                ($this->recovery->isRecoveryEnabledForUser($user) && $recoveryPassword)
298
+                || !$this->keyManager->userHasKeys($user)
299
+                || !$this->util->userHasFiles($user)
300
+            ) {
301
+
302
+                // backup old keys
303
+                //$this->backupAllKeys('recovery');
304
+
305
+                $newUserPassword = $params['password'];
306
+
307
+                $keyPair = $this->crypt->createKeyPair();
308
+
309
+                // Save public key
310
+                $this->keyManager->setPublicKey($user, $keyPair['publicKey']);
311
+
312
+                // Encrypt private key with new password
313
+                $encryptedKey = $this->crypt->encryptPrivateKey($keyPair['privateKey'], $newUserPassword, $user);
314
+
315
+                if ($encryptedKey) {
316
+                    $this->keyManager->setPrivateKey($user, $this->crypt->generateHeader() . $encryptedKey);
317
+
318
+                    if ($recoveryPassword) { // if recovery key is set we can re-encrypt the key files
319
+                        $this->recovery->recoverUsersFiles($recoveryPassword, $user);
320
+                    }
321
+                } else {
322
+                    $this->logger->error('Encryption Could not update users encryption password');
323
+                }
324
+            }
325
+        }
326
+    }
327
+
328
+    /**
329
+     * init mount points for given user
330
+     *
331
+     * @param string $user
332
+     * @throws \OC\User\NoUserException
333
+     */
334
+    protected function initMountPoints($user) {
335
+        Filesystem::initMountPoints($user);
336
+    }
337
+
338
+    /**
339
+     * setup file system for user
340
+     *
341
+     * @param string $uid user id
342
+     */
343
+    protected function setupFS($uid) {
344
+        \OC_Util::setupFS($uid);
345
+    }
346 346
 }
Please login to merge, or discard this patch.
apps/encryption/lib/Hooks/Contracts/IHook.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -24,10 +24,10 @@
 block discarded – undo
24 24
 
25 25
 
26 26
 interface IHook {
27
-	/**
28
-	 * Connects Hooks
29
-	 *
30
-	 * @return null
31
-	 */
32
-	public function addHooks();
27
+    /**
28
+     * Connects Hooks
29
+     *
30
+     * @return null
31
+     */
32
+    public function addHooks();
33 33
 }
Please login to merge, or discard this patch.
apps/encryption/lib/Settings/Admin.php 1 patch
Indentation   +85 added lines, -85 removed lines patch added patch discarded remove patch
@@ -38,90 +38,90 @@
 block discarded – undo
38 38
 
39 39
 class Admin implements ISettings {
40 40
 
41
-	/** @var IL10N */
42
-	private $l;
43
-
44
-	/** @var ILogger */
45
-	private $logger;
46
-
47
-	/** @var IUserSession */
48
-	private $userSession;
49
-
50
-	/** @var IConfig */
51
-	private $config;
52
-
53
-	/** @var IUserManager */
54
-	private $userManager;
55
-
56
-	/** @var ISession */
57
-	private $session;
58
-
59
-	public function __construct(
60
-		IL10N $l,
61
-		ILogger $logger,
62
-		IUserSession $userSession,
63
-		IConfig $config,
64
-		IUserManager $userManager,
65
-		ISession $session
66
-	) {
67
-		$this->l = $l;
68
-		$this->logger = $logger;
69
-		$this->userSession = $userSession;
70
-		$this->config = $config;
71
-		$this->userManager = $userManager;
72
-		$this->session = $session;
73
-	}
74
-
75
-	/**
76
-	 * @return TemplateResponse
77
-	 */
78
-	public function getForm() {
79
-		$crypt = new Crypt(
80
-			$this->logger,
81
-			$this->userSession,
82
-			$this->config,
83
-			$this->l);
84
-
85
-		$util = new Util(
86
-			new View(),
87
-			$crypt,
88
-			$this->logger,
89
-			$this->userSession,
90
-			$this->config,
91
-			$this->userManager);
92
-
93
-		// Check if an adminRecovery account is enabled for recovering files after lost pwd
94
-		$recoveryAdminEnabled = $this->config->getAppValue('encryption', 'recoveryAdminEnabled', '0');
95
-		$session = new Session($this->session);
96
-
97
-		$encryptHomeStorage = $util->shouldEncryptHomeStorage();
98
-
99
-		$parameters = [
100
-			'recoveryEnabled'    => $recoveryAdminEnabled,
101
-			'initStatus'         => $session->getStatus(),
102
-			'encryptHomeStorage' => $encryptHomeStorage,
103
-			'masterKeyEnabled'   => $util->isMasterKeyEnabled(),
104
-		];
105
-
106
-		return new TemplateResponse('encryption', 'settings-admin', $parameters, '');
107
-	}
108
-
109
-	/**
110
-	 * @return string the section ID, e.g. 'sharing'
111
-	 */
112
-	public function getSection() {
113
-		return 'encryption';
114
-	}
115
-
116
-	/**
117
-	 * @return int whether the form should be rather on the top or bottom of
118
-	 * the admin section. The forms are arranged in ascending order of the
119
-	 * priority values. It is required to return a value between 0 and 100.
120
-	 *
121
-	 * E.g.: 70
122
-	 */
123
-	public function getPriority() {
124
-		return 5;
125
-	}
41
+    /** @var IL10N */
42
+    private $l;
43
+
44
+    /** @var ILogger */
45
+    private $logger;
46
+
47
+    /** @var IUserSession */
48
+    private $userSession;
49
+
50
+    /** @var IConfig */
51
+    private $config;
52
+
53
+    /** @var IUserManager */
54
+    private $userManager;
55
+
56
+    /** @var ISession */
57
+    private $session;
58
+
59
+    public function __construct(
60
+        IL10N $l,
61
+        ILogger $logger,
62
+        IUserSession $userSession,
63
+        IConfig $config,
64
+        IUserManager $userManager,
65
+        ISession $session
66
+    ) {
67
+        $this->l = $l;
68
+        $this->logger = $logger;
69
+        $this->userSession = $userSession;
70
+        $this->config = $config;
71
+        $this->userManager = $userManager;
72
+        $this->session = $session;
73
+    }
74
+
75
+    /**
76
+     * @return TemplateResponse
77
+     */
78
+    public function getForm() {
79
+        $crypt = new Crypt(
80
+            $this->logger,
81
+            $this->userSession,
82
+            $this->config,
83
+            $this->l);
84
+
85
+        $util = new Util(
86
+            new View(),
87
+            $crypt,
88
+            $this->logger,
89
+            $this->userSession,
90
+            $this->config,
91
+            $this->userManager);
92
+
93
+        // Check if an adminRecovery account is enabled for recovering files after lost pwd
94
+        $recoveryAdminEnabled = $this->config->getAppValue('encryption', 'recoveryAdminEnabled', '0');
95
+        $session = new Session($this->session);
96
+
97
+        $encryptHomeStorage = $util->shouldEncryptHomeStorage();
98
+
99
+        $parameters = [
100
+            'recoveryEnabled'    => $recoveryAdminEnabled,
101
+            'initStatus'         => $session->getStatus(),
102
+            'encryptHomeStorage' => $encryptHomeStorage,
103
+            'masterKeyEnabled'   => $util->isMasterKeyEnabled(),
104
+        ];
105
+
106
+        return new TemplateResponse('encryption', 'settings-admin', $parameters, '');
107
+    }
108
+
109
+    /**
110
+     * @return string the section ID, e.g. 'sharing'
111
+     */
112
+    public function getSection() {
113
+        return 'encryption';
114
+    }
115
+
116
+    /**
117
+     * @return int whether the form should be rather on the top or bottom of
118
+     * the admin section. The forms are arranged in ascending order of the
119
+     * priority values. It is required to return a value between 0 and 100.
120
+     *
121
+     * E.g.: 70
122
+     */
123
+    public function getPriority() {
124
+        return 5;
125
+    }
126 126
 
127 127
 }
Please login to merge, or discard this patch.
apps/encryption/lib/Session.php 1 patch
Indentation   +154 added lines, -154 removed lines patch added patch discarded remove patch
@@ -29,159 +29,159 @@
 block discarded – undo
29 29
 
30 30
 class Session {
31 31
 
32
-	/** @var ISession */
33
-	protected $session;
34
-
35
-	const NOT_INITIALIZED = '0';
36
-	const INIT_EXECUTED = '1';
37
-	const INIT_SUCCESSFUL = '2';
38
-	const RUN_MIGRATION = '3';
39
-
40
-	/**
41
-	 * @param ISession $session
42
-	 */
43
-	public function __construct(ISession $session) {
44
-		$this->session = $session;
45
-	}
46
-
47
-	/**
48
-	 * Sets status of encryption app
49
-	 *
50
-	 * @param string $status INIT_SUCCESSFUL, INIT_EXECUTED, NOT_INITIALIZED
51
-	 */
52
-	public function setStatus($status) {
53
-		$this->session->set('encryptionInitialized', $status);
54
-	}
55
-
56
-	/**
57
-	 * Gets status if we already tried to initialize the encryption app
58
-	 *
59
-	 * @return string init status INIT_SUCCESSFUL, INIT_EXECUTED, NOT_INITIALIZED
60
-	 */
61
-	public function getStatus() {
62
-		$status = $this->session->get('encryptionInitialized');
63
-		if (is_null($status)) {
64
-			$status = self::NOT_INITIALIZED;
65
-		}
66
-
67
-		return $status;
68
-	}
69
-
70
-	/**
71
-	 * check if encryption was initialized successfully
72
-	 *
73
-	 * @return bool
74
-	 */
75
-	public function isReady() {
76
-		$status = $this->getStatus();
77
-		return $status === self::INIT_SUCCESSFUL;
78
-	}
79
-
80
-	/**
81
-	 * Gets user or public share private key from session
82
-	 *
83
-	 * @return string $privateKey The user's plaintext private key
84
-	 * @throws Exceptions\PrivateKeyMissingException
85
-	 */
86
-	public function getPrivateKey() {
87
-		$key = $this->session->get('privateKey');
88
-		if (is_null($key)) {
89
-			throw new Exceptions\PrivateKeyMissingException('please try to log-out and log-in again', 0);
90
-		}
91
-		return $key;
92
-	}
93
-
94
-	/**
95
-	 * check if private key is set
96
-	 *
97
-	 * @return boolean
98
-	 */
99
-	public function isPrivateKeySet() {
100
-		$key = $this->session->get('privateKey');
101
-		if (is_null($key)) {
102
-			return false;
103
-		}
104
-
105
-		return true;
106
-	}
107
-
108
-	/**
109
-	 * Sets user private key to session
110
-	 *
111
-	 * @param string $key users private key
112
-	 *
113
-	 * @note this should only be set on login
114
-	 */
115
-	public function setPrivateKey($key) {
116
-		$this->session->set('privateKey', $key);
117
-	}
118
-
119
-	/**
120
-	 * store data needed for the decrypt all operation in the session
121
-	 *
122
-	 * @param string $user
123
-	 * @param string $key
124
-	 */
125
-	public function prepareDecryptAll($user, $key) {
126
-		$this->session->set('decryptAll', true);
127
-		$this->session->set('decryptAllKey', $key);
128
-		$this->session->set('decryptAllUid', $user);
129
-	}
130
-
131
-	/**
132
-	 * check if we are in decrypt all mode
133
-	 *
134
-	 * @return bool
135
-	 */
136
-	public function decryptAllModeActivated() {
137
-		$decryptAll = $this->session->get('decryptAll');
138
-		return ($decryptAll === true);
139
-	}
140
-
141
-	/**
142
-	 * get uid used for decrypt all operation
143
-	 *
144
-	 * @return string
145
-	 * @throws \Exception
146
-	 */
147
-	public function getDecryptAllUid() {
148
-		$uid = $this->session->get('decryptAllUid');
149
-		if (is_null($uid) && $this->decryptAllModeActivated()) {
150
-			throw new \Exception('No uid found while in decrypt all mode');
151
-		} elseif (is_null($uid)) {
152
-			throw new \Exception('Please activate decrypt all mode first');
153
-		}
154
-
155
-		return $uid;
156
-	}
157
-
158
-	/**
159
-	 * get private key for decrypt all operation
160
-	 *
161
-	 * @return string
162
-	 * @throws PrivateKeyMissingException
163
-	 */
164
-	public function getDecryptAllKey() {
165
-		$privateKey = $this->session->get('decryptAllKey');
166
-		if (is_null($privateKey) && $this->decryptAllModeActivated()) {
167
-			throw new PrivateKeyMissingException('No private key found while in decrypt all mode');
168
-		} elseif (is_null($privateKey)) {
169
-			throw new PrivateKeyMissingException('Please activate decrypt all mode first');
170
-		}
171
-
172
-		return $privateKey;
173
-	}
174
-
175
-	/**
176
-	 * remove keys from session
177
-	 */
178
-	public function clear() {
179
-		$this->session->remove('publicSharePrivateKey');
180
-		$this->session->remove('privateKey');
181
-		$this->session->remove('encryptionInitialized');
182
-		$this->session->remove('decryptAll');
183
-		$this->session->remove('decryptAllKey');
184
-		$this->session->remove('decryptAllUid');
185
-	}
32
+    /** @var ISession */
33
+    protected $session;
34
+
35
+    const NOT_INITIALIZED = '0';
36
+    const INIT_EXECUTED = '1';
37
+    const INIT_SUCCESSFUL = '2';
38
+    const RUN_MIGRATION = '3';
39
+
40
+    /**
41
+     * @param ISession $session
42
+     */
43
+    public function __construct(ISession $session) {
44
+        $this->session = $session;
45
+    }
46
+
47
+    /**
48
+     * Sets status of encryption app
49
+     *
50
+     * @param string $status INIT_SUCCESSFUL, INIT_EXECUTED, NOT_INITIALIZED
51
+     */
52
+    public function setStatus($status) {
53
+        $this->session->set('encryptionInitialized', $status);
54
+    }
55
+
56
+    /**
57
+     * Gets status if we already tried to initialize the encryption app
58
+     *
59
+     * @return string init status INIT_SUCCESSFUL, INIT_EXECUTED, NOT_INITIALIZED
60
+     */
61
+    public function getStatus() {
62
+        $status = $this->session->get('encryptionInitialized');
63
+        if (is_null($status)) {
64
+            $status = self::NOT_INITIALIZED;
65
+        }
66
+
67
+        return $status;
68
+    }
69
+
70
+    /**
71
+     * check if encryption was initialized successfully
72
+     *
73
+     * @return bool
74
+     */
75
+    public function isReady() {
76
+        $status = $this->getStatus();
77
+        return $status === self::INIT_SUCCESSFUL;
78
+    }
79
+
80
+    /**
81
+     * Gets user or public share private key from session
82
+     *
83
+     * @return string $privateKey The user's plaintext private key
84
+     * @throws Exceptions\PrivateKeyMissingException
85
+     */
86
+    public function getPrivateKey() {
87
+        $key = $this->session->get('privateKey');
88
+        if (is_null($key)) {
89
+            throw new Exceptions\PrivateKeyMissingException('please try to log-out and log-in again', 0);
90
+        }
91
+        return $key;
92
+    }
93
+
94
+    /**
95
+     * check if private key is set
96
+     *
97
+     * @return boolean
98
+     */
99
+    public function isPrivateKeySet() {
100
+        $key = $this->session->get('privateKey');
101
+        if (is_null($key)) {
102
+            return false;
103
+        }
104
+
105
+        return true;
106
+    }
107
+
108
+    /**
109
+     * Sets user private key to session
110
+     *
111
+     * @param string $key users private key
112
+     *
113
+     * @note this should only be set on login
114
+     */
115
+    public function setPrivateKey($key) {
116
+        $this->session->set('privateKey', $key);
117
+    }
118
+
119
+    /**
120
+     * store data needed for the decrypt all operation in the session
121
+     *
122
+     * @param string $user
123
+     * @param string $key
124
+     */
125
+    public function prepareDecryptAll($user, $key) {
126
+        $this->session->set('decryptAll', true);
127
+        $this->session->set('decryptAllKey', $key);
128
+        $this->session->set('decryptAllUid', $user);
129
+    }
130
+
131
+    /**
132
+     * check if we are in decrypt all mode
133
+     *
134
+     * @return bool
135
+     */
136
+    public function decryptAllModeActivated() {
137
+        $decryptAll = $this->session->get('decryptAll');
138
+        return ($decryptAll === true);
139
+    }
140
+
141
+    /**
142
+     * get uid used for decrypt all operation
143
+     *
144
+     * @return string
145
+     * @throws \Exception
146
+     */
147
+    public function getDecryptAllUid() {
148
+        $uid = $this->session->get('decryptAllUid');
149
+        if (is_null($uid) && $this->decryptAllModeActivated()) {
150
+            throw new \Exception('No uid found while in decrypt all mode');
151
+        } elseif (is_null($uid)) {
152
+            throw new \Exception('Please activate decrypt all mode first');
153
+        }
154
+
155
+        return $uid;
156
+    }
157
+
158
+    /**
159
+     * get private key for decrypt all operation
160
+     *
161
+     * @return string
162
+     * @throws PrivateKeyMissingException
163
+     */
164
+    public function getDecryptAllKey() {
165
+        $privateKey = $this->session->get('decryptAllKey');
166
+        if (is_null($privateKey) && $this->decryptAllModeActivated()) {
167
+            throw new PrivateKeyMissingException('No private key found while in decrypt all mode');
168
+        } elseif (is_null($privateKey)) {
169
+            throw new PrivateKeyMissingException('Please activate decrypt all mode first');
170
+        }
171
+
172
+        return $privateKey;
173
+    }
174
+
175
+    /**
176
+     * remove keys from session
177
+     */
178
+    public function clear() {
179
+        $this->session->remove('publicSharePrivateKey');
180
+        $this->session->remove('privateKey');
181
+        $this->session->remove('encryptionInitialized');
182
+        $this->session->remove('decryptAll');
183
+        $this->session->remove('decryptAllKey');
184
+        $this->session->remove('decryptAllUid');
185
+    }
186 186
 
187 187
 }
Please login to merge, or discard this patch.