Completed
Pull Request — master (#5231)
by Morris
16:38
created
lib/private/Template/JSResourceLocator.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -30,6 +30,9 @@  discard block
 block discarded – undo
30 30
 	/** @var JSCombiner */
31 31
 	protected $jsCombiner;
32 32
 
33
+	/**
34
+	 * @param string $theme
35
+	 */
33 36
 	public function __construct(\OCP\ILogger $logger, $theme, array $core_map, array $party_map, JSCombiner $JSCombiner) {
34 37
 		parent::__construct($logger, $theme, $core_map, $party_map);
35 38
 
@@ -91,6 +94,9 @@  discard block
 block discarded – undo
91 94
 	public function doFindTheme($script) {
92 95
 	}
93 96
 
97
+	/**
98
+	 * @param string $file
99
+	 */
94 100
 	protected function cacheAndAppendCombineJsonIfExist($root, $file, $app = 'core') {
95 101
 		if (is_file($root.'/'.$file)) {
96 102
 			if ($this->jsCombiner->process($root, $file, $app)) {
Please login to merge, or discard this patch.
lib/private/Template/SCSSCacher.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -114,8 +114,8 @@
 block discarded – undo
114 114
 	}
115 115
 
116 116
 	/**
117
-	 * @param $appName
118
-	 * @param $fileName
117
+	 * @param string $appName
118
+	 * @param string $fileName
119 119
 	 * @return ISimpleFile
120 120
 	 */
121 121
 	public function getCachedCSS($appName, $fileName) {
Please login to merge, or discard this patch.
apps/dav/lib/Avatars/AvatarHome.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -98,6 +98,9 @@
 block discarded – undo
98 98
 		throw new Forbidden('Permission denied to delete this folder');
99 99
 	}
100 100
 
101
+	/**
102
+	 * @return string
103
+	 */
101 104
 	public function getName() {
102 105
 		list(,$name) = Uri\split($this->principalInfo['uri']);
103 106
 		return $name;
Please login to merge, or discard this patch.
apps/dav/lib/Migration/CalDAVRemoveEmptyValue.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -97,6 +97,9 @@
 block discarded – undo
97 97
 		}
98 98
 	}
99 99
 
100
+	/**
101
+	 * @param string $pattern
102
+	 */
100 103
 	protected function getInvalidObjects($pattern) {
101 104
 		$query = $this->db->getQueryBuilder();
102 105
 		$query->select(['calendarid', 'uri'])
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Search/Xml/Request/CalendarSearchReport.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
 	 * the next element.
80 80
 	 *
81 81
 	 * @param Reader $reader
82
-	 * @return mixed
82
+	 * @return CalendarSearchReport
83 83
 	 */
84 84
 	static function xmlDeserialize(Reader $reader) {
85 85
 		$elems = $reader->parseInnerTree([
Please login to merge, or discard this patch.
lib/private/Share20/Manager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -1100,6 +1100,9 @@
 block discarded – undo
1100 1100
 		return $share;
1101 1101
 	}
1102 1102
 
1103
+	/**
1104
+	 * @param \OCP\Share\IShare $share
1105
+	 */
1103 1106
 	protected function checkExpireDate($share) {
1104 1107
 		if ($share->getExpirationDate() !== null &&
1105 1108
 			$share->getExpirationDate() <= new \DateTime()) {
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/SyncService.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -163,7 +163,6 @@  discard block
 block discarded – undo
163 163
 	/**
164 164
 	 * @param string $url
165 165
 	 * @param string $userName
166
-	 * @param string $addressBookUrl
167 166
 	 * @param string $sharedSecret
168 167
 	 * @return Client
169 168
 	 */
@@ -301,7 +300,7 @@  discard block
 block discarded – undo
301 300
 	}
302 301
 
303 302
 	/**
304
-	 * @return array|null
303
+	 * @return string
305 304
 	 */
306 305
 	public function getLocalSystemAddressBook() {
307 306
 		if (is_null($this->localSystemAddressBook)) {
Please login to merge, or discard this patch.
lib/private/Mail/EMailTemplate.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -335,7 +335,7 @@
 block discarded – undo
335 335
 	 * Adds a heading to the email
336 336
 	 *
337 337
 	 * @param string $title
338
-	 * @param string $plainTitle|bool Title that is used in the plain text email
338
+	 * @param string $plainTitle Title that is used in the plain text email
339 339
 	 *   if empty the $title is used, if false none will be used
340 340
 	 */
341 341
 	public function addHeading($title, $plainTitle = '') {
Please login to merge, or discard this patch.
lib/private/AppFramework/Utility/ControllerMethodReflector.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
 	private $parameters = [];
38 38
 
39 39
 	/**
40
-	 * @param object $object an object or classname
40
+	 * @param \OCP\AppFramework\Controller $object an object or classname
41 41
 	 * @param string $method the method which we want to inspect
42 42
 	 */
43 43
 	public function reflect($object, $method){
Please login to merge, or discard this patch.