nextcloud / server

core/Command/Encryption/Disable.php

Indentation +23 added lines, -23 removed lines

@@ -28,30 +28,30 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Disable extends Command {
-	/** @var IConfig */
-	protected $config;
+    /** @var IConfig */
+    protected $config;
 
-	/**
-	 * @param IConfig $config
-	 */
-	public function __construct(IConfig $config) {
-		parent::__construct();
-		$this->config = $config;
-	}
+    /**
+     * @param IConfig $config
+     */
+    public function __construct(IConfig $config) {
+        parent::__construct();
+        $this->config = $config;
+    }
 
-	protected function configure() {
-		$this
-			->setName('encryption:disable')
-			->setDescription('Disable encryption')
-		;
-	}
+    protected function configure() {
+        $this
+            ->setName('encryption:disable')
+            ->setDescription('Disable encryption')
+        ;
+    }
 
-	protected function execute(InputInterface $input, OutputInterface $output) {
-		if ($this->config->getAppValue('core', 'encryption_enabled', 'no') !== 'yes') {
-			$output->writeln('Encryption is already disabled');
-		} else {
-			$this->config->setAppValue('core', 'encryption_enabled', 'no');
-			$output->writeln('<info>Encryption disabled</info>');
-		}
-	}
+    protected function execute(InputInterface $input, OutputInterface $output) {
+        if ($this->config->getAppValue('core', 'encryption_enabled', 'no') !== 'yes') {
+            $output->writeln('Encryption is already disabled');
+        } else {
+            $this->config->setAppValue('core', 'encryption_enabled', 'no');
+            $output->writeln('<info>Encryption disabled</info>');
+        }
+    }
 }

core/Command/Encryption/Status.php

Indentation +22 added lines, -22 removed lines

@@ -28,30 +28,30 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Status extends Base {
-	/** @var IManager */
-	protected $encryptionManager;
+    /** @var IManager */
+    protected $encryptionManager;
 
-	/**
-	 * @param IManager $encryptionManager
-	 */
-	public function __construct(IManager $encryptionManager) {
-		parent::__construct();
-		$this->encryptionManager = $encryptionManager;
-	}
+    /**
+     * @param IManager $encryptionManager
+     */
+    public function __construct(IManager $encryptionManager) {
+        parent::__construct();
+        $this->encryptionManager = $encryptionManager;
+    }
 
-	protected function configure() {
-		parent::configure();
+    protected function configure() {
+        parent::configure();
 
-		$this
-			->setName('encryption:status')
-			->setDescription('Lists the current status of encryption')
-		;
-	}
+        $this
+            ->setName('encryption:status')
+            ->setDescription('Lists the current status of encryption')
+        ;
+    }
 
-	protected function execute(InputInterface $input, OutputInterface $output) {
-		$this->writeArrayInOutputFormat($input, $output, [
-			'enabled' => $this->encryptionManager->isEnabled(),
-			'defaultModule' => $this->encryptionManager->getDefaultEncryptionModuleId(),
-		]);
-	}
+    protected function execute(InputInterface $input, OutputInterface $output) {
+        $this->writeArrayInOutputFormat($input, $output, [
+            'enabled' => $this->encryptionManager->isEnabled(),
+            'defaultModule' => $this->encryptionManager->getDefaultEncryptionModuleId(),
+        ]);
+    }
 }

core/Command/Group/ListCommand.php

Indentation +50 added lines, -50 removed lines

@@ -34,58 +34,58 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class ListCommand extends Base {
-	/** @var IGroupManager */
-	protected $groupManager;
+    /** @var IGroupManager */
+    protected $groupManager;
 
-	/**
-	 * @param IGroupManager $groupManager
-	 */
-	public function __construct(IGroupManager $groupManager) {
-		$this->groupManager = $groupManager;
-		parent::__construct();
-	}
+    /**
+     * @param IGroupManager $groupManager
+     */
+    public function __construct(IGroupManager $groupManager) {
+        $this->groupManager = $groupManager;
+        parent::__construct();
+    }
 
-	protected function configure() {
-		$this
-			->setName('group:list')
-			->setDescription('list configured groups')
-			->addOption(
-				'limit',
-				'l',
-				InputOption::VALUE_OPTIONAL,
-				'Number of groups to retrieve',
-				500
-			)->addOption(
-				'offset',
-				'o',
-				InputOption::VALUE_OPTIONAL,
-				'Offset for retrieving groups',
-				0
-			)->addOption(
-				'output',
-				null,
-				InputOption::VALUE_OPTIONAL,
-				'Output format (plain, json or json_pretty, default is plain)',
-				$this->defaultOutputFormat
-			);
-	}
+    protected function configure() {
+        $this
+            ->setName('group:list')
+            ->setDescription('list configured groups')
+            ->addOption(
+                'limit',
+                'l',
+                InputOption::VALUE_OPTIONAL,
+                'Number of groups to retrieve',
+                500
+            )->addOption(
+                'offset',
+                'o',
+                InputOption::VALUE_OPTIONAL,
+                'Offset for retrieving groups',
+                0
+            )->addOption(
+                'output',
+                null,
+                InputOption::VALUE_OPTIONAL,
+                'Output format (plain, json or json_pretty, default is plain)',
+                $this->defaultOutputFormat
+            );
+    }
 
-	protected function execute(InputInterface $input, OutputInterface $output) {
-		$groups = $this->groupManager->search('', (int)$input->getOption('limit'), (int)$input->getOption('offset'));
-		$this->writeArrayInOutputFormat($input, $output, $this->formatGroups($groups));
-	}
+    protected function execute(InputInterface $input, OutputInterface $output) {
+        $groups = $this->groupManager->search('', (int)$input->getOption('limit'), (int)$input->getOption('offset'));
+        $this->writeArrayInOutputFormat($input, $output, $this->formatGroups($groups));
+    }
 
-	/**
-	 * @param IGroup[] $groups
-	 * @return array
-	 */
-	private function formatGroups(array $groups) {
-		$keys = array_map(function (IGroup $group) {
-			return $group->getGID();
-		}, $groups);
-		$values = array_map(function (IGroup $group) {
-			return array_keys($group->getUsers());
-		}, $groups);
-		return array_combine($keys, $values);
-	}
+    /**
+     * @param IGroup[] $groups
+     * @return array
+     */
+    private function formatGroups(array $groups) {
+        $keys = array_map(function (IGroup $group) {
+            return $group->getGID();
+        }, $groups);
+        $values = array_map(function (IGroup $group) {
+            return array_keys($group->getUsers());
+        }, $groups);
+        return array_combine($keys, $values);
+    }
 }

Spacing +3 added lines, -3 removed lines

@@ -71,7 +71,7 @@ 
 	}
 
 	protected function execute(InputInterface $input, OutputInterface $output) {
-		$groups = $this->groupManager->search('', (int)$input->getOption('limit'), (int)$input->getOption('offset'));
+		$groups = $this->groupManager->search('', (int) $input->getOption('limit'), (int) $input->getOption('offset'));
 		$this->writeArrayInOutputFormat($input, $output, $this->formatGroups($groups));
 	}
 
@@ -80,10 +80,10 @@ 
 	 * @return array
 	 */
 	private function formatGroups(array $groups) {
-		$keys = array_map(function (IGroup $group) {
+		$keys = array_map(function(IGroup $group) {
 			return $group->getGID();
 		}, $groups);
-		$values = array_map(function (IGroup $group) {
+		$values = array_map(function(IGroup $group) {
 			return array_keys($group->getUsers());
 		}, $groups);
 		return array_combine($keys, $values);

core/Command/Group/RemoveUser.php

Indentation +40 added lines, -40 removed lines

@@ -33,47 +33,47 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class RemoveUser extends Base {
-	/** @var IUserManager */
-	protected $userManager;
-	/** @var IGroupManager */
-	protected $groupManager;
+    /** @var IUserManager */
+    protected $userManager;
+    /** @var IGroupManager */
+    protected $groupManager;
 
-	/**
-	 * @param IUserManager $userManager
-	 * @param IGroupManager $groupManager
-	 */
-	public function __construct(IUserManager $userManager, IGroupManager $groupManager) {
-		$this->userManager = $userManager;
-		$this->groupManager = $groupManager;
-		parent::__construct();
-	}
+    /**
+     * @param IUserManager $userManager
+     * @param IGroupManager $groupManager
+     */
+    public function __construct(IUserManager $userManager, IGroupManager $groupManager) {
+        $this->userManager = $userManager;
+        $this->groupManager = $groupManager;
+        parent::__construct();
+    }
 
-	protected function configure() {
-		$this
-			->setName('group:removeuser')
-			->setDescription('remove a user from a group')
-			->addArgument(
-				'group',
-				InputArgument::REQUIRED,
-				'group to remove the user from'
-			)->addArgument(
-				'user',
-				InputArgument::REQUIRED,
-				'user to remove from the group'
-			);
-	}
+    protected function configure() {
+        $this
+            ->setName('group:removeuser')
+            ->setDescription('remove a user from a group')
+            ->addArgument(
+                'group',
+                InputArgument::REQUIRED,
+                'group to remove the user from'
+            )->addArgument(
+                'user',
+                InputArgument::REQUIRED,
+                'user to remove from the group'
+            );
+    }
 
-	protected function execute(InputInterface $input, OutputInterface $output) {
-		$group = $this->groupManager->get($input->getArgument('group'));
-		if (is_null($group)) {
-			$output->writeln('<error>group not found</error>');
-			return 1;
-		}
-		$user = $this->userManager->get($input->getArgument('user'));
-		if (is_null($user)) {
-			$output->writeln('<error>user not found</error>');
-			return 1;
-		}
-		$group->removeUser($user);
-	}
+    protected function execute(InputInterface $input, OutputInterface $output) {
+        $group = $this->groupManager->get($input->getArgument('group'));
+        if (is_null($group)) {
+            $output->writeln('<error>group not found</error>');
+            return 1;
+        }
+        $user = $this->userManager->get($input->getArgument('user'));
+        if (is_null($user)) {
+            $output->writeln('<error>user not found</error>');
+            return 1;
+        }
+        $group->removeUser($user);
+    }
 }

core/Command/Group/AddUser.php

Indentation +40 added lines, -40 removed lines

@@ -33,47 +33,47 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class AddUser extends Base {
-	/** @var IUserManager */
-	protected $userManager;
-	/** @var IGroupManager */
-	protected $groupManager;
+    /** @var IUserManager */
+    protected $userManager;
+    /** @var IGroupManager */
+    protected $groupManager;
 
-	/**
-	 * @param IUserManager $userManager
-	 * @param IGroupManager $groupManager
-	 */
-	public function __construct(IUserManager $userManager, IGroupManager $groupManager) {
-		$this->userManager = $userManager;
-		$this->groupManager = $groupManager;
-		parent::__construct();
-	}
+    /**
+     * @param IUserManager $userManager
+     * @param IGroupManager $groupManager
+     */
+    public function __construct(IUserManager $userManager, IGroupManager $groupManager) {
+        $this->userManager = $userManager;
+        $this->groupManager = $groupManager;
+        parent::__construct();
+    }
 
-	protected function configure() {
-		$this
-			->setName('group:adduser')
-			->setDescription('add a user to a group')
-			->addArgument(
-				'group',
-				InputArgument::REQUIRED,
-				'group to add the user to'
-			)->addArgument(
-				'user',
-				InputArgument::REQUIRED,
-				'user to add to the group'
-			);
-	}
+    protected function configure() {
+        $this
+            ->setName('group:adduser')
+            ->setDescription('add a user to a group')
+            ->addArgument(
+                'group',
+                InputArgument::REQUIRED,
+                'group to add the user to'
+            )->addArgument(
+                'user',
+                InputArgument::REQUIRED,
+                'user to add to the group'
+            );
+    }
 
-	protected function execute(InputInterface $input, OutputInterface $output) {
-		$group = $this->groupManager->get($input->getArgument('group'));
-		if (is_null($group)) {
-			$output->writeln('<error>group not found</error>');
-			return 1;
-		}
-		$user = $this->userManager->get($input->getArgument('user'));
-		if (is_null($user)) {
-			$output->writeln('<error>user not found</error>');
-			return 1;
-		}
-		$group->addUser($user);
-	}
+    protected function execute(InputInterface $input, OutputInterface $output) {
+        $group = $this->groupManager->get($input->getArgument('group'));
+        if (is_null($group)) {
+            $output->writeln('<error>group not found</error>');
+            return 1;
+        }
+        $user = $this->userManager->get($input->getArgument('user'));
+        if (is_null($user)) {
+            $output->writeln('<error>user not found</error>');
+            return 1;
+        }
+        $group->addUser($user);
+    }
 }

apps/files_external/lib/Command/Delete.php

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
 		try {
 			$mount = $this->globalService->getStorage($mountId);
 		} catch (NotFoundException $e) {
-			$output->writeln('<error>Mount with id "' . $mountId . ' not found, check "occ files_external:list" to get available mounts"</error>');
+			$output->writeln('<error>Mount with id "'.$mountId.' not found, check "occ files_external:list" to get available mounts"</error>');
 			return 404;
 		}
 

Indentation +61 added lines, -61 removed lines

@@ -38,76 +38,76 @@
 use Symfony\Component\Console\Question\ConfirmationQuestion;
 
 class Delete extends Base {
-	/**
-	 * @var GlobalStoragesService
-	 */
-	protected $globalService;
+    /**
+     * @var GlobalStoragesService
+     */
+    protected $globalService;
 
-	/**
-	 * @var UserStoragesService
-	 */
-	protected $userService;
+    /**
+     * @var UserStoragesService
+     */
+    protected $userService;
 
-	/**
-	 * @var IUserSession
-	 */
-	protected $userSession;
+    /**
+     * @var IUserSession
+     */
+    protected $userSession;
 
-	/**
-	 * @var IUserManager
-	 */
-	protected $userManager;
+    /**
+     * @var IUserManager
+     */
+    protected $userManager;
 
-	public function __construct(GlobalStoragesService $globalService, UserStoragesService $userService, IUserSession $userSession, IUserManager $userManager) {
-		parent::__construct();
-		$this->globalService = $globalService;
-		$this->userService = $userService;
-		$this->userSession = $userSession;
-		$this->userManager = $userManager;
-	}
+    public function __construct(GlobalStoragesService $globalService, UserStoragesService $userService, IUserSession $userSession, IUserManager $userManager) {
+        parent::__construct();
+        $this->globalService = $globalService;
+        $this->userService = $userService;
+        $this->userSession = $userSession;
+        $this->userManager = $userManager;
+    }
 
-	protected function configure() {
-		$this
-			->setName('files_external:delete')
-			->setDescription('Delete an external mount')
-			->addArgument(
-				'mount_id',
-				InputArgument::REQUIRED,
-				'The id of the mount to edit'
-			)->addOption(
-				'yes',
-				'y',
-				InputOption::VALUE_NONE,
-				'Skip confirmation'
-			);
-		parent::configure();
-	}
+    protected function configure() {
+        $this
+            ->setName('files_external:delete')
+            ->setDescription('Delete an external mount')
+            ->addArgument(
+                'mount_id',
+                InputArgument::REQUIRED,
+                'The id of the mount to edit'
+            )->addOption(
+                'yes',
+                'y',
+                InputOption::VALUE_NONE,
+                'Skip confirmation'
+            );
+        parent::configure();
+    }
 
-	protected function execute(InputInterface $input, OutputInterface $output) {
-		$mountId = $input->getArgument('mount_id');
-		try {
-			$mount = $this->globalService->getStorage($mountId);
-		} catch (NotFoundException $e) {
-			$output->writeln('<error>Mount with id "' . $mountId . ' not found, check "occ files_external:list" to get available mounts"</error>');
-			return 404;
-		}
+    protected function execute(InputInterface $input, OutputInterface $output) {
+        $mountId = $input->getArgument('mount_id');
+        try {
+            $mount = $this->globalService->getStorage($mountId);
+        } catch (NotFoundException $e) {
+            $output->writeln('<error>Mount with id "' . $mountId . ' not found, check "occ files_external:list" to get available mounts"</error>');
+            return 404;
+        }
 
-		$noConfirm = $input->getOption('yes');
+        $noConfirm = $input->getOption('yes');
 
-		if (!$noConfirm) {
-			$listCommand = new ListCommand($this->globalService, $this->userService, $this->userSession, $this->userManager);
-			$listInput = new ArrayInput([], $listCommand->getDefinition());
-			$listInput->setOption('output', $input->getOption('output'));
-			$listCommand->listMounts(null, [$mount], $listInput, $output);
+        if (!$noConfirm) {
+            $listCommand = new ListCommand($this->globalService, $this->userService, $this->userSession, $this->userManager);
+            $listInput = new ArrayInput([], $listCommand->getDefinition());
+            $listInput->setOption('output', $input->getOption('output'));
+            $listCommand->listMounts(null, [$mount], $listInput, $output);
 
-			$questionHelper = $this->getHelper('question');
-			$question = new ConfirmationQuestion('Delete this mount? [y/N] ', false);
+            $questionHelper = $this->getHelper('question');
+            $question = new ConfirmationQuestion('Delete this mount? [y/N] ', false);
 
-			if (!$questionHelper->ask($input, $output, $question)) {
-				return null;
-			}
-		}
+            if (!$questionHelper->ask($input, $output, $question)) {
+                return null;
+            }
+        }
 
-		$this->globalService->removeStorage($mountId);
-	}
+        $this->globalService->removeStorage($mountId);
+    }
 }

core/Command/Config/Import.php

Spacing +6 added lines, -6 removed lines

@@ -65,7 +65,7 @@ 
 		try {
 			$configs = $this->validateFileContent($content);
 		} catch (\UnexpectedValueException $e) {
-			$output->writeln('<error>' . $e->getMessage(). '</error>');
+			$output->writeln('<error>'.$e->getMessage().'</error>');
 			return;
 		}
 
@@ -85,7 +85,7 @@ 
 			}
 		}
 
-		$output->writeln('<info>Config successfully imported from: ' . $importFile . '</info>');
+		$output->writeln('<info>Config successfully imported from: '.$importFile.'</info>');
 	}
 
 	/**
@@ -139,10 +139,10 @@ 
 		$additionalKeys = array_diff($arrayKeys, $this->validRootKeys);
 		$commonKeys = array_intersect($arrayKeys, $this->validRootKeys);
 		if (!empty($additionalKeys)) {
-			throw new \UnexpectedValueException('Found invalid entries in root: ' . implode(', ', $additionalKeys));
+			throw new \UnexpectedValueException('Found invalid entries in root: '.implode(', ', $additionalKeys));
 		}
 		if (empty($commonKeys)) {
-			throw new \UnexpectedValueException('At least one key of the following is expected: ' . implode(', ', $this->validRootKeys));
+			throw new \UnexpectedValueException('At least one key of the following is expected: '.implode(', ', $this->validRootKeys));
 		}
 
 		if (isset($array['system'])) {
@@ -170,7 +170,7 @@ 
 	 */
 	protected function checkTypeRecursively($configValue, $configName) {
 		if (!is_array($configValue) && !is_bool($configValue) && !is_int($configValue) && !is_string($configValue) && !is_null($configValue)) {
-			throw new \UnexpectedValueException('Invalid system config value for "' . $configName . '". Only arrays, bools, integers, strings and null (delete) are allowed.');
+			throw new \UnexpectedValueException('Invalid system config value for "'.$configName.'". Only arrays, bools, integers, strings and null (delete) are allowed.');
 		}
 		if (is_array($configValue)) {
 			foreach ($configValue as $key => $value) {
@@ -188,7 +188,7 @@ 
 		foreach ($array as $app => $configs) {
 			foreach ($configs as $name => $value) {
 				if (!is_int($value) && !is_string($value) && !is_null($value)) {
-					throw new \UnexpectedValueException('Invalid app config value for "' . $app . '":"' . $name . '". Only integers, strings and null (delete) are allowed.');
+					throw new \UnexpectedValueException('Invalid app config value for "'.$app.'":"'.$name.'". Only integers, strings and null (delete) are allowed.');
 				}
 			}
 		}

Indentation +189 added lines, -189 removed lines

@@ -34,193 +34,193 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Import extends Command implements CompletionAwareInterface {
-	protected $validRootKeys = ['system', 'apps'];
-
-	/** @var IConfig */
-	protected $config;
-
-	/**
-	 * @param IConfig $config
-	 */
-	public function __construct(IConfig $config) {
-		parent::__construct();
-		$this->config = $config;
-	}
-
-	protected function configure() {
-		$this
-			->setName('config:import')
-			->setDescription('Import a list of configs')
-			->addArgument(
-				'file',
-				InputArgument::OPTIONAL,
-				'File with the json array to import'
-			)
-		;
-	}
-
-	protected function execute(InputInterface $input, OutputInterface $output) {
-		$importFile = $input->getArgument('file');
-		if ($importFile !== null) {
-			$content = $this->getArrayFromFile($importFile);
-		} else {
-			$content = $this->getArrayFromStdin();
-		}
-
-		try {
-			$configs = $this->validateFileContent($content);
-		} catch (\UnexpectedValueException $e) {
-			$output->writeln('<error>' . $e->getMessage(). '</error>');
-			return;
-		}
-
-		if (!empty($configs['system'])) {
-			$this->config->setSystemValues($configs['system']);
-		}
-
-		if (!empty($configs['apps'])) {
-			foreach ($configs['apps'] as $app => $appConfigs) {
-				foreach ($appConfigs as $key => $value) {
-					if ($value === null) {
-						$this->config->deleteAppValue($app, $key);
-					} else {
-						$this->config->setAppValue($app, $key, $value);
-					}
-				}
-			}
-		}
-
-		$output->writeln('<info>Config successfully imported from: ' . $importFile . '</info>');
-	}
-
-	/**
-	 * Get the content from stdin ("config:import < file.json")
-	 *
-	 * @return string
-	 */
-	protected function getArrayFromStdin() {
-		// Read from stdin. stream_set_blocking is used to prevent blocking
-		// when nothing is passed via stdin.
-		stream_set_blocking(STDIN, 0);
-		$content = file_get_contents('php://stdin');
-		stream_set_blocking(STDIN, 1);
-		return $content;
-	}
-
-	/**
-	 * Get the content of the specified file ("config:import file.json")
-	 *
-	 * @param string $importFile
-	 * @return string
-	 */
-	protected function getArrayFromFile($importFile) {
-		return file_get_contents($importFile);
-	}
-
-	/**
-	 * @param string $content
-	 * @return array
-	 * @throws \UnexpectedValueException when the array is invalid
-	 */
-	protected function validateFileContent($content) {
-		$decodedContent = json_decode($content, true);
-		if (!is_array($decodedContent) || empty($decodedContent)) {
-			throw new \UnexpectedValueException('The file must contain a valid json array');
-		}
-
-		$this->validateArray($decodedContent);
-
-		return $decodedContent;
-	}
-
-	/**
-	 * Validates that the array only contains `system` and `apps`
-	 *
-	 * @param array $array
-	 */
-	protected function validateArray($array) {
-		$arrayKeys = array_keys($array);
-		$additionalKeys = array_diff($arrayKeys, $this->validRootKeys);
-		$commonKeys = array_intersect($arrayKeys, $this->validRootKeys);
-		if (!empty($additionalKeys)) {
-			throw new \UnexpectedValueException('Found invalid entries in root: ' . implode(', ', $additionalKeys));
-		}
-		if (empty($commonKeys)) {
-			throw new \UnexpectedValueException('At least one key of the following is expected: ' . implode(', ', $this->validRootKeys));
-		}
-
-		if (isset($array['system'])) {
-			if (is_array($array['system'])) {
-				foreach ($array['system'] as $name => $value) {
-					$this->checkTypeRecursively($value, $name);
-				}
-			} else {
-				throw new \UnexpectedValueException('The system config array is not an array');
-			}
-		}
-
-		if (isset($array['apps'])) {
-			if (is_array($array['apps'])) {
-				$this->validateAppsArray($array['apps']);
-			} else {
-				throw new \UnexpectedValueException('The apps config array is not an array');
-			}
-		}
-	}
-
-	/**
-	 * @param mixed $configValue
-	 * @param string $configName
-	 */
-	protected function checkTypeRecursively($configValue, $configName) {
-		if (!is_array($configValue) && !is_bool($configValue) && !is_int($configValue) && !is_string($configValue) && !is_null($configValue)) {
-			throw new \UnexpectedValueException('Invalid system config value for "' . $configName . '". Only arrays, bools, integers, strings and null (delete) are allowed.');
-		}
-		if (is_array($configValue)) {
-			foreach ($configValue as $key => $value) {
-				$this->checkTypeRecursively($value, $configName);
-			}
-		}
-	}
-
-	/**
-	 * Validates that app configs are only integers and strings
-	 *
-	 * @param array $array
-	 */
-	protected function validateAppsArray($array) {
-		foreach ($array as $app => $configs) {
-			foreach ($configs as $name => $value) {
-				if (!is_int($value) && !is_string($value) && !is_null($value)) {
-					throw new \UnexpectedValueException('Invalid app config value for "' . $app . '":"' . $name . '". Only integers, strings and null (delete) are allowed.');
-				}
-			}
-		}
-	}
-
-	/**
-	 * @param string $optionName
-	 * @param CompletionContext $context
-	 * @return string[]
-	 */
-	public function completeOptionValues($optionName, CompletionContext $context) {
-		return [];
-	}
-
-	/**
-	 * @param string $argumentName
-	 * @param CompletionContext $context
-	 * @return string[]
-	 */
-	public function completeArgumentValues($argumentName, CompletionContext $context) {
-		if ($argumentName === 'file') {
-			$helper = new ShellPathCompletion(
-				$this->getName(),
-				'file',
-				Completion::TYPE_ARGUMENT
-			);
-			return $helper->run();
-		}
-		return [];
-	}
+    protected $validRootKeys = ['system', 'apps'];
+
+    /** @var IConfig */
+    protected $config;
+
+    /**
+     * @param IConfig $config
+     */
+    public function __construct(IConfig $config) {
+        parent::__construct();
+        $this->config = $config;
+    }
+
+    protected function configure() {
+        $this
+            ->setName('config:import')
+            ->setDescription('Import a list of configs')
+            ->addArgument(
+                'file',
+                InputArgument::OPTIONAL,
+                'File with the json array to import'
+            )
+        ;
+    }
+
+    protected function execute(InputInterface $input, OutputInterface $output) {
+        $importFile = $input->getArgument('file');
+        if ($importFile !== null) {
+            $content = $this->getArrayFromFile($importFile);
+        } else {
+            $content = $this->getArrayFromStdin();
+        }
+
+        try {
+            $configs = $this->validateFileContent($content);
+        } catch (\UnexpectedValueException $e) {
+            $output->writeln('<error>' . $e->getMessage(). '</error>');
+            return;
+        }
+
+        if (!empty($configs['system'])) {
+            $this->config->setSystemValues($configs['system']);
+        }
+
+        if (!empty($configs['apps'])) {
+            foreach ($configs['apps'] as $app => $appConfigs) {
+                foreach ($appConfigs as $key => $value) {
+                    if ($value === null) {
+                        $this->config->deleteAppValue($app, $key);
+                    } else {
+                        $this->config->setAppValue($app, $key, $value);
+                    }
+                }
+            }
+        }
+
+        $output->writeln('<info>Config successfully imported from: ' . $importFile . '</info>');
+    }
+
+    /**
+     * Get the content from stdin ("config:import < file.json")
+     *
+     * @return string
+     */
+    protected function getArrayFromStdin() {
+        // Read from stdin. stream_set_blocking is used to prevent blocking
+        // when nothing is passed via stdin.
+        stream_set_blocking(STDIN, 0);
+        $content = file_get_contents('php://stdin');
+        stream_set_blocking(STDIN, 1);
+        return $content;
+    }
+
+    /**
+     * Get the content of the specified file ("config:import file.json")
+     *
+     * @param string $importFile
+     * @return string
+     */
+    protected function getArrayFromFile($importFile) {
+        return file_get_contents($importFile);
+    }
+
+    /**
+     * @param string $content
+     * @return array
+     * @throws \UnexpectedValueException when the array is invalid
+     */
+    protected function validateFileContent($content) {
+        $decodedContent = json_decode($content, true);
+        if (!is_array($decodedContent) || empty($decodedContent)) {
+            throw new \UnexpectedValueException('The file must contain a valid json array');
+        }
+
+        $this->validateArray($decodedContent);
+
+        return $decodedContent;
+    }
+
+    /**
+     * Validates that the array only contains `system` and `apps`
+     *
+     * @param array $array
+     */
+    protected function validateArray($array) {
+        $arrayKeys = array_keys($array);
+        $additionalKeys = array_diff($arrayKeys, $this->validRootKeys);
+        $commonKeys = array_intersect($arrayKeys, $this->validRootKeys);
+        if (!empty($additionalKeys)) {
+            throw new \UnexpectedValueException('Found invalid entries in root: ' . implode(', ', $additionalKeys));
+        }
+        if (empty($commonKeys)) {
+            throw new \UnexpectedValueException('At least one key of the following is expected: ' . implode(', ', $this->validRootKeys));
+        }
+
+        if (isset($array['system'])) {
+            if (is_array($array['system'])) {
+                foreach ($array['system'] as $name => $value) {
+                    $this->checkTypeRecursively($value, $name);
+                }
+            } else {
+                throw new \UnexpectedValueException('The system config array is not an array');
+            }
+        }
+
+        if (isset($array['apps'])) {
+            if (is_array($array['apps'])) {
+                $this->validateAppsArray($array['apps']);
+            } else {
+                throw new \UnexpectedValueException('The apps config array is not an array');
+            }
+        }
+    }
+
+    /**
+     * @param mixed $configValue
+     * @param string $configName
+     */
+    protected function checkTypeRecursively($configValue, $configName) {
+        if (!is_array($configValue) && !is_bool($configValue) && !is_int($configValue) && !is_string($configValue) && !is_null($configValue)) {
+            throw new \UnexpectedValueException('Invalid system config value for "' . $configName . '". Only arrays, bools, integers, strings and null (delete) are allowed.');
+        }
+        if (is_array($configValue)) {
+            foreach ($configValue as $key => $value) {
+                $this->checkTypeRecursively($value, $configName);
+            }
+        }
+    }
+
+    /**
+     * Validates that app configs are only integers and strings
+     *
+     * @param array $array
+     */
+    protected function validateAppsArray($array) {
+        foreach ($array as $app => $configs) {
+            foreach ($configs as $name => $value) {
+                if (!is_int($value) && !is_string($value) && !is_null($value)) {
+                    throw new \UnexpectedValueException('Invalid app config value for "' . $app . '":"' . $name . '". Only integers, strings and null (delete) are allowed.');
+                }
+            }
+        }
+    }
+
+    /**
+     * @param string $optionName
+     * @param CompletionContext $context
+     * @return string[]
+     */
+    public function completeOptionValues($optionName, CompletionContext $context) {
+        return [];
+    }
+
+    /**
+     * @param string $argumentName
+     * @param CompletionContext $context
+     * @return string[]
+     */
+    public function completeArgumentValues($argumentName, CompletionContext $context) {
+        if ($argumentName === 'file') {
+            $helper = new ShellPathCompletion(
+                $this->getName(),
+                'file',
+                Completion::TYPE_ARGUMENT
+            );
+            return $helper->run();
+        }
+        return [];
+    }
 }

lib/public/Contacts/ContactsMenu/IAction.php

Indentation +25 added lines, -25 removed lines

@@ -33,33 +33,33 @@
  */
 interface IAction extends JsonSerializable {
 
-	/**
-	 * @param string $icon absolute URI to an icon
-	 * @since 12.0
-	 */
-	public function setIcon($icon);
+    /**
+     * @param string $icon absolute URI to an icon
+     * @since 12.0
+     */
+    public function setIcon($icon);
 
-	/**
-	 * @return string localized action name, e.g. 'Call'
-	 * @since 12.0
-	 */
-	public function getName();
+    /**
+     * @return string localized action name, e.g. 'Call'
+     * @since 12.0
+     */
+    public function getName();
 
-	/**
-	 * @param string $name localized action name, e.g. 'Call'
-	 * @since 12.0
-	 */
-	public function setName($name);
+    /**
+     * @param string $name localized action name, e.g. 'Call'
+     * @since 12.0
+     */
+    public function setName($name);
 
-	/**
-	 * @param int $priority priorize actions, high order ones are shown on top
-	 * @since 12.0
-	 */
-	public function setPriority($priority);
+    /**
+     * @param int $priority priorize actions, high order ones are shown on top
+     * @since 12.0
+     */
+    public function setPriority($priority);
 
-	/**
-	 * @return int priority to priorize actions, high order ones are shown on top
-	 * @since 12.0
-	 */
-	public function getPriority();
+    /**
+     * @return int priority to priorize actions, high order ones are shown on top
+     * @since 12.0
+     */
+    public function getPriority();
 }

lib/public/Contacts/ContactsMenu/IActionFactory.php

Indentation +22 added lines, -22 removed lines

@@ -28,27 +28,27 @@
  */
 interface IActionFactory {
 
-	/**
-	 * Construct and return a new link action for the contacts menu
-	 *
-	 * @since 12.0
-	 *
-	 * @param string $icon full path to the action's icon
-	 * @param string $name localized name of the action
-	 * @param string $href target URL
-	 * @return ILinkAction
-	 */
-	public function newLinkAction($icon, $name, $href);
+    /**
+     * Construct and return a new link action for the contacts menu
+     *
+     * @since 12.0
+     *
+     * @param string $icon full path to the action's icon
+     * @param string $name localized name of the action
+     * @param string $href target URL
+     * @return ILinkAction
+     */
+    public function newLinkAction($icon, $name, $href);
 
-	/**
-	 * Construct and return a new email action for the contacts menu
-	 *
-	 * @since 12.0
-	 *
-	 * @param string $icon full path to the action's icon
-	 * @param string $name localized name of the action
-	 * @param string $email target e-mail address
-	 * @return ILinkAction
-	 */
-	public function newEMailAction($icon, $name, $email);
+    /**
+     * Construct and return a new email action for the contacts menu
+     *
+     * @since 12.0
+     *
+     * @param string $icon full path to the action's icon
+     * @param string $name localized name of the action
+     * @param string $email target e-mail address
+     * @return ILinkAction
+     */
+    public function newEMailAction($icon, $name, $email);
 }