Completed
Pull Request — master (#1545)
by Thomas
21:48 queued 10:54
created
lib/private/AppFramework/OCS/BaseResponse.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 	/**
25 25
 	 * BaseResponse constructor.
26 26
 	 *
27
-	 * @param DataResponse|null $dataResponse
27
+	 * @param DataResponse $dataResponse
28 28
 	 * @param string $format
29 29
 	 * @param string|null $statusMessage
30 30
 	 * @param int|null $itemsCount
Please login to merge, or discard this patch.
lib/private/Settings/Manager.php 1 patch
Doc Comments   +14 added lines, -3 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 	/**
130 130
 	 * returns the registerd classes in the given table
131 131
 	 *
132
-	 * @param $table
132
+	 * @param string $table
133 133
 	 * @return string[]
134 134
 	 */
135 135
 	private function getClasses($table) {
@@ -225,6 +225,11 @@  discard block
 block discarded – undo
225 225
 		);
226 226
 	}
227 227
 
228
+	/**
229
+	 * @param string $table
230
+	 * @param string $idCol
231
+	 * @param string $id
232
+	 */
228 233
 	private function update($table, $idCol, $id, $values) {
229 234
 		$query = $this->dbc->getQueryBuilder();
230 235
 		$query->update($table);
@@ -275,8 +280,8 @@  discard block
 block discarded – undo
275 280
 	/**
276 281
 	 * deletes an settings or admin entry from the given table
277 282
 	 *
278
-	 * @param $table
279
-	 * @param $className
283
+	 * @param string $table
284
+	 * @param string $className
280 285
 	 */
281 286
 	private function remove($table, $className) {
282 287
 		$query = $this->dbc->getQueryBuilder();
@@ -362,6 +367,9 @@  discard block
 block discarded – undo
362 367
 		return $sections;
363 368
 	}
364 369
 
370
+	/**
371
+	 * @param string $section
372
+	 */
365 373
 	private function getBuiltInAdminSettings($section) {
366 374
 		$forms = [];
367 375
 		try {
@@ -401,6 +409,9 @@  discard block
 block discarded – undo
401 409
 		return $forms;
402 410
 	}
403 411
 
412
+	/**
413
+	 * @param string $section
414
+	 */
404 415
 	private function getAdminSettingsFromDB($section, &$settings) {
405 416
 		$query = $this->dbc->getQueryBuilder();
406 417
 		$query->select(['class', 'priority'])
Please login to merge, or discard this patch.
lib/public/AppFramework/Http/Response.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
 
227 227
 	/**
228 228
 	 * By default renders no output
229
-	 * @return null
229
+	 * @return string
230 230
 	 * @since 6.0.0
231 231
 	 */
232 232
 	public function render() {
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 
260 260
 	/**
261 261
 	 * Get the currently used Content-Security-Policy
262
-	 * @return EmptyContentSecurityPolicy|null Used Content-Security-Policy or null if
262
+	 * @return ContentSecurityPolicy|null Used Content-Security-Policy or null if
263 263
 	 *                                    none specified.
264 264
 	 * @since 8.1.0
265 265
 	 */
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Publishing/PublishPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@
 block discarded – undo
134 134
 	 * @param RequestInterface $request
135 135
 	 * @param ResponseInterface $response
136 136
 	 *
137
-	 * @return void|bool
137
+	 * @return null|false
138 138
 	 */
139 139
 	public function httpPost(RequestInterface $request, ResponseInterface $response) {
140 140
 		$path = $request->getPath();
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/CalDavBackend.php 1 patch
Doc Comments   +8 added lines, -2 removed lines patch added patch discarded remove patch
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
 	 *
138 138
 	 * By default this excludes the automatically generated birthday calendar
139 139
 	 *
140
-	 * @param $principalUri
140
+	 * @param string $principalUri
141 141
 	 * @param bool $excludeBirthday
142 142
 	 * @return int
143 143
 	 */
@@ -282,6 +282,9 @@  discard block
 block discarded – undo
282 282
 		return array_values($calendars);
283 283
 	}
284 284
 
285
+	/**
286
+	 * @param string $principalUri
287
+	 */
285 288
 	public function getUsersOwnCalendars($principalUri) {
286 289
 		$principalUri = $this->convertPrincipal($principalUri, true);
287 290
 		$fields = array_values($this->propertyMap);
@@ -1174,7 +1177,7 @@  discard block
 block discarded – undo
1174 1177
 	 * @param string $principalUri
1175 1178
 	 * @param string $uri
1176 1179
 	 * @param array $properties
1177
-	 * @return mixed
1180
+	 * @return integer
1178 1181
 	 */
1179 1182
 	function createSubscription($principalUri, $uri, array $properties) {
1180 1183
 
@@ -1533,6 +1536,9 @@  discard block
 block discarded – undo
1533 1536
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
1534 1537
 	}
1535 1538
 
1539
+	/**
1540
+	 * @param boolean $toV2
1541
+	 */
1536 1542
 	private function convertPrincipal($principalUri, $toV2) {
1537 1543
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1538 1544
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.