Passed
Push — master ( 634ee1...e32314 )
by John
19:14 queued 11s
created
apps/theming/lib/Controller/ThemingController.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
 
220 220
 		try {
221 221
 			$mime = $this->imageManager->updateImage($key, $image['tmp_name']);
222
-			$this->themingDefaults->set($key . 'Mime', $mime);
222
+			$this->themingDefaults->set($key.'Mime', $mime);
223 223
 		} catch (\Exception $e) {
224 224
 			return new DataResponse(
225 225
 				[
@@ -292,12 +292,12 @@  discard block
 block discarded – undo
292 292
 		$csp->allowInlineStyle();
293 293
 		$response->setContentSecurityPolicy($csp);
294 294
 		$response->cacheFor(3600);
295
-		$response->addHeader('Content-Type', $this->config->getAppValue($this->appName, $key . 'Mime', ''));
296
-		$response->addHeader('Content-Disposition', 'attachment; filename="' . $key . '"');
295
+		$response->addHeader('Content-Type', $this->config->getAppValue($this->appName, $key.'Mime', ''));
296
+		$response->addHeader('Content-Disposition', 'attachment; filename="'.$key.'"');
297 297
 		if (!$useSvg) {
298 298
 			$response->addHeader('Content-Type', 'image/png');
299 299
 		} else {
300
-			$response->addHeader('Content-Type', $this->config->getAppValue($this->appName, $key . 'Mime', ''));
300
+			$response->addHeader('Content-Type', $this->config->getAppValue($this->appName, $key.'Mime', ''));
301 301
 		}
302 302
 		return $response;
303 303
 	}
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
317 317
 		}
318 318
 
319 319
 		$theme = $themes[$themeId];
320
-		$customCss  = $theme->getCustomCss();
320
+		$customCss = $theme->getCustomCss();
321 321
 
322 322
 		// Generate variables
323 323
 		$variables = '';
@@ -327,12 +327,12 @@  discard block
 block discarded – undo
327 327
 
328 328
 		// If plain is set, the browser decides of the css priority
329 329
 		if ($plain) {
330
-			$css = ":root { $variables } " . $customCss;
330
+			$css = ":root { $variables } ".$customCss;
331 331
 		} else { 
332 332
 			// If not set, we'll rely on the body class
333 333
 			$compiler = new Compiler();
334 334
 			$compiledCss = $compiler->compileString("[data-theme-$themeId] { $variables $customCss }");
335
-			$css = $compiledCss->getCss();;
335
+			$css = $compiledCss->getCss(); ;
336 336
 		}
337 337
 
338 338
 		try {
@@ -359,12 +359,12 @@  discard block
 block discarded – undo
359 359
 			$description = $this->themingDefaults->getSlogan();
360 360
 		} else {
361 361
 			$info = $this->appManager->getAppInfo($app, false, $this->l10n->getLanguageCode());
362
-			$name = $info['name'] . ' - ' . $this->themingDefaults->getName();
362
+			$name = $info['name'].' - '.$this->themingDefaults->getName();
363 363
 			$shortName = $info['name'];
364 364
 			if (strpos($this->request->getRequestUri(), '/index.php/') !== false) {
365
-				$startUrl = $this->urlGenerator->getBaseUrl() . '/index.php/apps/' . $app . '/';
365
+				$startUrl = $this->urlGenerator->getBaseUrl().'/index.php/apps/'.$app.'/';
366 366
 			} else {
367
-				$startUrl = $this->urlGenerator->getBaseUrl() . '/apps/' . $app . '/';
367
+				$startUrl = $this->urlGenerator->getBaseUrl().'/apps/'.$app.'/';
368 368
 			}
369 369
 			$description = $info['summary'] ?? '';
370 370
 		}
@@ -379,13 +379,13 @@  discard block
 block discarded – undo
379 379
 				[
380 380
 					[
381 381
 						'src' => $this->urlGenerator->linkToRoute('theming.Icon.getTouchIcon',
382
-								['app' => $app]) . '?v=' . $cacheBusterValue,
382
+								['app' => $app]).'?v='.$cacheBusterValue,
383 383
 						'type' => 'image/png',
384 384
 						'sizes' => '512x512'
385 385
 					],
386 386
 					[
387 387
 						'src' => $this->urlGenerator->linkToRoute('theming.Icon.getFavicon',
388
-								['app' => $app]) . '?v=' . $cacheBusterValue,
388
+								['app' => $app]).'?v='.$cacheBusterValue,
389 389
 						'type' => 'image/svg+xml',
390 390
 						'sizes' => '16x16'
391 391
 					]
Please login to merge, or discard this patch.