Completed
Pull Request — master (#1893)
by Thomas
36:57 queued 28:26
created
lib/private/Files/Type/Loader.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 
24 24
 use OCP\Files\IMimeTypeLoader;
25 25
 use OCP\IDBConnection;
26
-
27 26
 use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
28 27
 
29 28
 /**
Please login to merge, or discard this patch.
lib/private/Group/Manager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -154,7 +154,7 @@
 block discarded – undo
154 154
 
155 155
 	/**
156 156
 	 * @param string $gid
157
-	 * @return \OCP\IGroup
157
+	 * @return null|Group
158 158
 	 */
159 159
 	protected function getGroupObject($gid) {
160 160
 		$backends = array();
Please login to merge, or discard this patch.
lib/private/Installer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -482,7 +482,7 @@
 block discarded – undo
482 482
 
483 483
 	/**
484 484
 	 * Removes an app
485
-	 * @param string $name name of the application to remove
485
+	 * @param string $appId
486 486
 	 * @return boolean
487 487
 	 *
488 488
 	 *
Please login to merge, or discard this patch.
lib/private/L10N/Factory.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -278,6 +278,11 @@
 block discarded – undo
278 278
 	 */
279 279
 	// FIXME This method is only public, until OC_L10N does not need it anymore,
280 280
 	// FIXME This is also the reason, why it is not in the public interface
281
+
282
+	/**
283
+	 * @param string|boolean $app
284
+	 * @param string|null $lang
285
+	 */
281 286
 	public function getL10nFilesForApp($app, $lang) {
282 287
 		$languageFiles = [];
283 288
 
Please login to merge, or discard this patch.
lib/private/L10N/L10N.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -176,7 +176,7 @@
 block discarded – undo
176 176
 	 * Returns an associative array with all translations
177 177
 	 *
178 178
 	 * Called by \OC_L10N_String
179
-	 * @return array
179
+	 * @return string[]
180 180
 	 */
181 181
 	public function getTranslations() {
182 182
 		return $this->translations;
Please login to merge, or discard this patch.
lib/private/legacy/api.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -331,7 +331,7 @@
 block discarded – undo
331 331
 
332 332
 	/**
333 333
 	 * http basic auth
334
-	 * @return string|false (username, or false on failure)
334
+	 * @return string (username, or false on failure)
335 335
 	 */
336 336
 	private static function loginUser() {
337 337
 		if(self::$isLoggedIn === true) {
Please login to merge, or discard this patch.
lib/private/legacy/eventsource.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
 	 * send a message to the client
89 89
 	 *
90 90
 	 * @param string $type
91
-	 * @param mixed $data
91
+	 * @param string $data
92 92
 	 *
93 93
 	 * @throws \BadMethodCallException
94 94
 	 * if only one parameter is given, a typeless message will be send with that parameter as data
Please login to merge, or discard this patch.
lib/private/legacy/l10n.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -323,7 +323,7 @@
 block discarded – undo
323 323
 	/**
324 324
 	 * find all available languages for an app
325 325
 	 * @param string $app App that needs to be translated
326
-	 * @return array an array of available languages
326
+	 * @return string[] an array of available languages
327 327
 	 * @deprecated 9.0.0 Use \OC::$server->getL10NFactory()->findAvailableLanguages() instead
328 328
 	 */
329 329
 	public static function findAvailableLanguages($app=null) {
Please login to merge, or discard this patch.
lib/private/legacy/template/functions.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
  * make preview_icon available as a simple function
183 183
  * Returns the path to the preview of the image.
184 184
  * @param string $path path of file
185
- * @return link to the preview
185
+ * @return string to the preview
186 186
  */
187 187
 function preview_icon( $path ) {
188 188
 	return \OC::$server->getURLGenerator()->linkToRoute('core_ajax_preview', ['x' => 32, 'y' => 32, 'file' => $path]);
@@ -190,6 +190,7 @@  discard block
 block discarded – undo
190 190
 
191 191
 /**
192 192
  * @param string $path
193
+ * @param string $token
193 194
  */
194 195
 function publicPreview_icon ( $path, $token ) {
195 196
 	return \OC::$server->getURLGenerator()->linkToRoute('core_ajax_public_preview', ['x' => 32, 'y' => 32, 'file' => $path, 't' => $token]);
Please login to merge, or discard this patch.