Completed
Pull Request — master (#1893)
by Thomas
36:57 queued 28:26
created
lib/private/Settings/Manager.php 1 patch
Doc Comments   +14 added lines, -3 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 	/**
130 130
 	 * returns the registerd classes in the given table
131 131
 	 *
132
-	 * @param $table
132
+	 * @param string $table
133 133
 	 * @return string[]
134 134
 	 */
135 135
 	private function getClasses($table) {
@@ -225,6 +225,11 @@  discard block
 block discarded – undo
225 225
 		);
226 226
 	}
227 227
 
228
+	/**
229
+	 * @param string $table
230
+	 * @param string $idCol
231
+	 * @param string $id
232
+	 */
228 233
 	private function update($table, $idCol, $id, $values) {
229 234
 		$query = $this->dbc->getQueryBuilder();
230 235
 		$query->update($table);
@@ -275,8 +280,8 @@  discard block
 block discarded – undo
275 280
 	/**
276 281
 	 * deletes an settings or admin entry from the given table
277 282
 	 *
278
-	 * @param $table
279
-	 * @param $className
283
+	 * @param string $table
284
+	 * @param string $className
280 285
 	 */
281 286
 	private function remove($table, $className) {
282 287
 		$query = $this->dbc->getQueryBuilder();
@@ -362,6 +367,9 @@  discard block
 block discarded – undo
362 367
 		return $sections;
363 368
 	}
364 369
 
370
+	/**
371
+	 * @param string $section
372
+	 */
365 373
 	private function getBuiltInAdminSettings($section) {
366 374
 		$forms = [];
367 375
 		try {
@@ -401,6 +409,9 @@  discard block
 block discarded – undo
401 409
 		return $forms;
402 410
 	}
403 411
 
412
+	/**
413
+	 * @param string $section
414
+	 */
404 415
 	private function getAdminSettingsFromDB($section, &$settings) {
405 416
 		$query = $this->dbc->getQueryBuilder();
406 417
 		$query->select(['class', 'priority'])
Please login to merge, or discard this patch.
lib/private/Server.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1143,7 +1143,7 @@  discard block
 block discarded – undo
1143 1143
 	 * Get the certificate manager for the user
1144 1144
 	 *
1145 1145
 	 * @param string $userId (optional) if not specified the current loggedin user is used, use null to get the system certificate manager
1146
-	 * @return \OCP\ICertificateManager | null if $uid is null and no user is logged in
1146
+	 * @return null|CertificateManager | null if $uid is null and no user is logged in
1147 1147
 	 */
1148 1148
 	public function getCertificateManager($userId = '') {
1149 1149
 		if ($userId === '') {
@@ -1464,6 +1464,7 @@  discard block
 block discarded – undo
1464 1464
 	}
1465 1465
 
1466 1466
 	/**
1467
+	 * @param string $app
1467 1468
 	 * @return \OCP\Files\IAppData
1468 1469
 	 */
1469 1470
 	public function getAppDataDir($app) {
Please login to merge, or discard this patch.
lib/public/AppFramework/Http/Response.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
 
227 227
 	/**
228 228
 	 * By default renders no output
229
-	 * @return null
229
+	 * @return string
230 230
 	 * @since 6.0.0
231 231
 	 */
232 232
 	public function render() {
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 
260 260
 	/**
261 261
 	 * Get the currently used Content-Security-Policy
262
-	 * @return EmptyContentSecurityPolicy|null Used Content-Security-Policy or null if
262
+	 * @return ContentSecurityPolicy|null Used Content-Security-Policy or null if
263 263
 	 *                                    none specified.
264 264
 	 * @since 8.1.0
265 265
 	 */
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/Publishing/PublishPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@
 block discarded – undo
134 134
 	 * @param RequestInterface $request
135 135
 	 * @param ResponseInterface $response
136 136
 	 *
137
-	 * @return void|bool
137
+	 * @return null|false
138 138
 	 */
139 139
 	public function httpPost(RequestInterface $request, ResponseInterface $response) {
140 140
 		$path = $request->getPath();
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/AddressBookRoot.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
 
31 31
 	/**
32 32
 	 * @param \Sabre\DAVACL\PrincipalBackend\BackendInterface $principalBackend
33
-	 * @param \Sabre\CardDAV\Backend\BackendInterface $carddavBackend
33
+	 * @param CardDavBackend $carddavBackend
34 34
 	 * @param string $principalPrefix
35 35
 	 */
36 36
 	public function __construct(\Sabre\DAVACL\PrincipalBackend\BackendInterface $principalBackend, \Sabre\CardDAV\Backend\BackendInterface $carddavBackend, $principalPrefix = 'principals') {
Please login to merge, or discard this patch.
lib/private/legacy/app.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -1331,6 +1331,9 @@
 block discarded – undo
1331 1331
 		}
1332 1332
 	}
1333 1333
 
1334
+	/**
1335
+	 * @param string $lang
1336
+	 */
1334 1337
 	protected static function findBestL10NOption($options, $lang) {
1335 1338
 		$fallback = $englishFallback = false;
1336 1339
 		foreach ($options as $option) {
Please login to merge, or discard this patch.
lib/private/Share20/DefaultShareProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -770,7 +770,7 @@
 block discarded – undo
770 770
 
771 771
 	/**
772 772
 	 * @param Share[] $shares
773
-	 * @param $userId
773
+	 * @param string $userId
774 774
 	 * @return Share[] The updates shares if no update is found for a share return the original
775 775
 	 */
776 776
 	private function resolveGroupShares($shares, $userId) {
Please login to merge, or discard this patch.
apps/user_ldap/lib/Helper.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -105,6 +105,9 @@
 block discarded – undo
105 105
 		return $result;
106 106
 	}
107 107
 
108
+	/**
109
+	 * @param string $value
110
+	 */
108 111
 	private function getServersConfig($value) {
109 112
 		$regex = '/' . $value . '$/S';
110 113
 
Please login to merge, or discard this patch.
apps/dav/lib/CalDAV/CalDavBackend.php 1 patch
Doc Comments   +10 added lines, -4 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 	 *
159 159
 	 * By default this excludes the automatically generated birthday calendar
160 160
 	 *
161
-	 * @param $principalUri
161
+	 * @param string $principalUri
162 162
 	 * @param bool $excludeBirthday
163 163
 	 * @return int
164 164
 	 */
@@ -303,6 +303,9 @@  discard block
 block discarded – undo
303 303
 		return array_values($calendars);
304 304
 	}
305 305
 
306
+	/**
307
+	 * @param string $principalUri
308
+	 */
306 309
 	public function getUsersOwnCalendars($principalUri) {
307 310
 		$principalUri = $this->convertPrincipal($principalUri, true);
308 311
 		$fields = array_values($this->propertyMap);
@@ -851,7 +854,7 @@  discard block
 block discarded – undo
851 854
 	 * calendar-data. If the result of a subsequent GET to this object is not
852 855
 	 * the exact same as this request body, you should omit the ETag.
853 856
 	 *
854
-	 * @param mixed $calendarId
857
+	 * @param integer $calendarId
855 858
 	 * @param string $objectUri
856 859
 	 * @param string $calendarData
857 860
 	 * @return string
@@ -894,7 +897,7 @@  discard block
 block discarded – undo
894 897
 	 * calendar-data. If the result of a subsequent GET to this object is not
895 898
 	 * the exact same as this request body, you should omit the ETag.
896 899
 	 *
897
-	 * @param mixed $calendarId
900
+	 * @param integer $calendarId
898 901
 	 * @param string $objectUri
899 902
 	 * @param string $calendarData
900 903
 	 * @return string
@@ -1309,7 +1312,7 @@  discard block
 block discarded – undo
1309 1312
 	 * @param string $principalUri
1310 1313
 	 * @param string $uri
1311 1314
 	 * @param array $properties
1312
-	 * @return mixed
1315
+	 * @return integer
1313 1316
 	 */
1314 1317
 	function createSubscription($principalUri, $uri, array $properties) {
1315 1318
 
@@ -1712,6 +1715,9 @@  discard block
 block discarded – undo
1712 1715
 		return $this->sharingBackend->applyShareAcl($resourceId, $acl);
1713 1716
 	}
1714 1717
 
1718
+	/**
1719
+	 * @param boolean $toV2
1720
+	 */
1715 1721
 	private function convertPrincipal($principalUri, $toV2) {
1716 1722
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1717 1723
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.