Completed
Push — master ( fab951...c2b1bd )
by Joas
102:02 queued 82:49
created
apps/user_ldap/lib/Access.php 1 patch
Doc Comments   +7 added lines, -6 removed lines patch added patch discarded remove patch
@@ -503,7 +503,7 @@  discard block
 block discarded – undo
503 503
 
504 504
 	/**
505 505
 	 * returns the internal Nextcloud name for the given LDAP DN of the user, false on DN outside of search DN or failure
506
-	 * @param string $dn the dn of the user object
506
+	 * @param string $fdn the dn of the user object
507 507
 	 * @param string $ldapName optional, the display name of the object
508 508
 	 * @return string|false with with the name to use in Nextcloud
509 509
 	 */
@@ -790,7 +790,7 @@  discard block
 block discarded – undo
790 790
 	 * the login filter.
791 791
 	 *
792 792
 	 * @param string $loginName
793
-	 * @param array $attributes optional, list of attributes to read
793
+	 * @param string[] $attributes optional, list of attributes to read
794 794
 	 * @return array
795 795
 	 */
796 796
 	public function fetchUsersByLoginName($loginName, $attributes = array('dn')) {
@@ -876,7 +876,7 @@  discard block
 block discarded – undo
876 876
 
877 877
 	/**
878 878
 	 * @param string $filter
879
-	 * @param string|string[] $attr
879
+	 * @param string[] $attr
880 880
 	 * @param int $limit
881 881
 	 * @param int $offset
882 882
 	 * @return array
@@ -924,7 +924,7 @@  discard block
 block discarded – undo
924 924
 
925 925
 	/**
926 926
 	 * @param string $filter
927
-	 * @param string|string[] $attr
927
+	 * @param string[] $attr
928 928
 	 * @param int $limit
929 929
 	 * @param int $offset
930 930
 	 * @return false|int
@@ -1023,7 +1023,7 @@  discard block
 block discarded – undo
1023 1023
 	/**
1024 1024
 	 * retrieved. Results will according to the order in the array.
1025 1025
 	 *
1026
-	 * @param $filter
1026
+	 * @param string $filter
1027 1027
 	 * @param $base
1028 1028
 	 * @param string[]|string|null $attr
1029 1029
 	 * @param int $limit optional, maximum results to be counted
@@ -1285,7 +1285,7 @@  discard block
 block discarded – undo
1285 1285
 
1286 1286
 	/**
1287 1287
 	 * @param string $name
1288
-	 * @return bool|mixed|string
1288
+	 * @return string
1289 1289
 	 */
1290 1290
 	public function sanitizeUsername($name) {
1291 1291
 		if($this->connection->ldapIgnoreNamingRules) {
@@ -1309,6 +1309,7 @@  discard block
 block discarded – undo
1309 1309
 	* escapes (user provided) parts for LDAP filter
1310 1310
 	* @param string $input, the provided value
1311 1311
 	* @param bool $allowAsterisk whether in * at the beginning should be preserved
1312
+	* @param string $input
1312 1313
 	* @return string the escaped string
1313 1314
 	*/
1314 1315
 	public function escapeFilterPart($input, $allowAsterisk = false) {
Please login to merge, or discard this patch.
apps/dav/lib/AppInfo/Application.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@
 block discarded – undo
76 76
 	}
77 77
 
78 78
 	/**
79
-	 * @param IManager $contactsManager
79
+	 * @param IContactsManager $contactsManager
80 80
 	 */
81 81
 	public function setupSystemContactsProvider(IContactsManager $contactsManager) {
82 82
 		/** @var ContactsManager $cm */
Please login to merge, or discard this patch.
lib/private/Installer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -420,7 +420,7 @@
 block discarded – undo
420 420
 
421 421
 	/**
422 422
 	 * Check if app has been installed from git
423
-	 * @param string $name name of the application to remove
423
+	 * @param string $appId
424 424
 	 * @return boolean
425 425
 	 *
426 426
 	 * The function will check if the path contains a .git folder
Please login to merge, or discard this patch.
apps/dav/lib/Upload/ChunkingPlugin.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
 	 *
68 68
 	 * @param string $path source path
69 69
 	 * @param string $destination destination path
70
-	 * @return bool|void false to stop handling, void to skip this handler
70
+	 * @return null|false false to stop handling, void to skip this handler
71 71
 	 */
72 72
 	public function performMove($path, $destination) {
73 73
 		if (!$this->server->tree->nodeExists($destination)) {
Please login to merge, or discard this patch.
lib/private/Files/ObjectStore/S3Signature.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -119,6 +119,9 @@
 block discarded – undo
119 119
 		return Psr7\modify_request($request, $modify);
120 120
 	}
121 121
 
122
+	/**
123
+	 * @param string $string
124
+	 */
122 125
 	private function signString($string, CredentialsInterface $credentials)
123 126
 	{
124 127
 		return base64_encode(
Please login to merge, or discard this patch.
lib/private/Files/Cache/QuerySearchHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@
 block discarded – undo
85 85
 
86 86
 	/**
87 87
 	 * @param IQueryBuilder $builder
88
-	 * @param ISearchOperator $operator
88
+	 * @param ISearchOperator $operators
89 89
 	 */
90 90
 	public function searchOperatorArrayToDBExprArray(IQueryBuilder $builder, array $operators) {
91 91
 		return array_map(function ($operator) use ($builder) {
Please login to merge, or discard this patch.
lib/private/legacy/image.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -299,7 +299,7 @@
 block discarded – undo
299 299
 	}
300 300
 
301 301
 	/**
302
-	 * @param resource Returns the image resource in any.
302
+	 * @param resource resource the image resource in any.
303 303
 	 * @throws \InvalidArgumentException in case the supplied resource does not have the type "gd"
304 304
 	 */
305 305
 	public function setResource($resource) {
Please login to merge, or discard this patch.
lib/private/AppConfig.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -160,7 +160,7 @@
 block discarded – undo
160 160
 	 *
161 161
 	 * @param string $app app
162 162
 	 * @param string $key key
163
-	 * @param string|float|int $value value
163
+	 * @param string $value value
164 164
 	 * @return bool True if the value was inserted or updated, false if the value was the same
165 165
 	 */
166 166
 	public function setValue($app, $key, $value) {
Please login to merge, or discard this patch.
lib/private/User/Manager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -193,7 +193,7 @@
 block discarded – undo
193 193
 	 * @internal
194 194
 	 * @param string $loginName
195 195
 	 * @param string $password
196
-	 * @return mixed the User object on success, false otherwise
196
+	 * @return IUser the User object on success, false otherwise
197 197
 	 */
198 198
 	public function checkPasswordNoLogging($loginName, $password) {
199 199
 		$loginName = str_replace("\0", '', $loginName);
Please login to merge, or discard this patch.