nextcloud /
server
| Conditions | 2 |
| Paths | 1 |
| Total Lines | 122 |
| Code Lines | 78 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 42 | public function __construct(array $urlParams = array()) { |
||
| 43 | parent::__construct('files_sharing', $urlParams); |
||
| 44 | |||
| 45 | $container = $this->getContainer(); |
||
| 46 | $server = $container->getServer(); |
||
| 47 | |||
| 48 | /** |
||
| 49 | * Controllers |
||
| 50 | */ |
||
| 51 | $container->registerService('ShareController', function (SimpleContainer $c) use ($server) { |
||
| 52 | $federatedSharingApp = new \OCA\FederatedFileSharing\AppInfo\Application(); |
||
| 53 | return new ShareController( |
||
| 54 | $c->query('AppName'), |
||
| 55 | $c->query('Request'), |
||
| 56 | $server->getConfig(), |
||
| 57 | $server->getURLGenerator(), |
||
| 58 | $server->getUserManager(), |
||
| 59 | $server->getLogger(), |
||
| 60 | $server->getActivityManager(), |
||
| 61 | $server->getShareManager(), |
||
| 62 | $server->getSession(), |
||
| 63 | $server->getPreviewManager(), |
||
| 64 | $server->getRootFolder(), |
||
| 65 | $federatedSharingApp->getFederatedShareProvider(), |
||
| 66 | $server->getEventDispatcher() |
||
| 67 | ); |
||
| 68 | }); |
||
| 69 | $container->registerService('ExternalSharesController', function (SimpleContainer $c) { |
||
| 70 | return new ExternalSharesController( |
||
| 71 | $c->query('AppName'), |
||
| 72 | $c->query('Request'), |
||
| 73 | $c->query('ExternalManager'), |
||
| 74 | $c->query('HttpClientService') |
||
| 75 | ); |
||
| 76 | }); |
||
| 77 | $container->registerService('ShareAPIController', function (SimpleContainer $c) use ($server) { |
||
| 78 | return new Share20OCS( |
||
| 79 | $c->query('AppName'), |
||
| 80 | $c->query('Request'), |
||
| 81 | $server->getShareManager(), |
||
| 82 | $server->getGroupManager(), |
||
| 83 | $server->getUserManager(), |
||
| 84 | $server->getRootFolder(), |
||
| 85 | $server->getURLGenerator(), |
||
| 86 | $server->getUserSession()->getUser(), |
||
| 87 | $server->getL10N($c->query('AppName')) |
||
| 88 | ); |
||
| 89 | }); |
||
| 90 | |||
| 91 | /** |
||
| 92 | * Core class wrappers |
||
| 93 | */ |
||
| 94 | $container->registerService('HttpClientService', function (SimpleContainer $c) use ($server) { |
||
|
|
|||
| 95 | return $server->getHTTPClientService(); |
||
| 96 | }); |
||
| 97 | $container->registerService('ExternalManager', function (SimpleContainer $c) use ($server) { |
||
| 98 | $user = $server->getUserSession()->getUser(); |
||
| 99 | $uid = $user ? $user->getUID() : null; |
||
| 100 | $discoveryManager = new DiscoveryManager( |
||
| 101 | \OC::$server->getMemCacheFactory(), |
||
| 102 | \OC::$server->getHTTPClientService() |
||
| 103 | ); |
||
| 104 | return new \OCA\Files_Sharing\External\Manager( |
||
| 105 | $server->getDatabaseConnection(), |
||
| 106 | \OC\Files\Filesystem::getMountManager(), |
||
| 107 | \OC\Files\Filesystem::getLoader(), |
||
| 108 | $server->getHTTPHelper(), |
||
| 109 | $server->getNotificationManager(), |
||
| 110 | $discoveryManager, |
||
| 111 | $uid |
||
| 112 | ); |
||
| 113 | }); |
||
| 114 | |||
| 115 | /** |
||
| 116 | * Middleware |
||
| 117 | */ |
||
| 118 | $container->registerService('SharingCheckMiddleware', function (SimpleContainer $c) use ($server) { |
||
| 119 | return new SharingCheckMiddleware( |
||
| 120 | $c->query('AppName'), |
||
| 121 | $server->getConfig(), |
||
| 122 | $server->getAppManager(), |
||
| 123 | $c['ControllerMethodReflector'] |
||
| 124 | ); |
||
| 125 | }); |
||
| 126 | |||
| 127 | $container->registerService('OCSShareAPIMiddleware', function (SimpleContainer $c) use ($server) { |
||
| 128 | return new OCSShareAPIMiddleware( |
||
| 129 | $server->getShareManager(), |
||
| 130 | $server->getL10N($c->query('AppName')) |
||
| 131 | ); |
||
| 132 | }); |
||
| 133 | |||
| 134 | // Execute middlewares |
||
| 135 | $container->registerMiddleware('SharingCheckMiddleware'); |
||
| 136 | $container->registerMiddleWare('OCSShareAPIMiddleware'); |
||
| 137 | |||
| 138 | $container->registerService('MountProvider', function (IContainer $c) { |
||
| 139 | /** @var \OCP\IServerContainer $server */ |
||
| 140 | $server = $c->query('ServerContainer'); |
||
| 141 | return new MountProvider( |
||
| 142 | $server->getConfig(), |
||
| 143 | $server->getShareManager(), |
||
| 144 | $server->getLogger() |
||
| 145 | ); |
||
| 146 | }); |
||
| 147 | |||
| 148 | $container->registerService('ExternalMountProvider', function (IContainer $c) { |
||
| 149 | /** @var \OCP\IServerContainer $server */ |
||
| 150 | $server = $c->query('ServerContainer'); |
||
| 151 | return new \OCA\Files_Sharing\External\MountProvider( |
||
| 152 | $server->getDatabaseConnection(), |
||
| 153 | function() use ($c) { |
||
| 154 | return $c->query('ExternalManager'); |
||
| 155 | } |
||
| 156 | ); |
||
| 157 | }); |
||
| 158 | |||
| 159 | /* |
||
| 160 | * Register capabilities |
||
| 161 | */ |
||
| 162 | $container->registerCapability('OCA\Files_Sharing\Capabilities'); |
||
| 163 | } |
||
| 164 | |||
| 173 |
Loading history...
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.