Completed
Pull Request — master (#4888)
by Julius
32:02 queued 15:08
created
apps/federatedfilesharing/lib/AddressHandler.php 1 patch
Indentation   +118 added lines, -118 removed lines patch added patch discarded remove patch
@@ -33,122 +33,122 @@
 block discarded – undo
33 33
  */
34 34
 class AddressHandler {
35 35
 
36
-	/** @var IL10N */
37
-	private $l;
38
-
39
-	/** @var IURLGenerator */
40
-	private $urlGenerator;
41
-
42
-	/** @var ICloudIdManager */
43
-	private $cloudIdManager;
44
-
45
-	/**
46
-	 * AddressHandler constructor.
47
-	 *
48
-	 * @param IURLGenerator $urlGenerator
49
-	 * @param IL10N $il10n
50
-	 * @param ICloudIdManager $cloudIdManager
51
-	 */
52
-	public function __construct(
53
-		IURLGenerator $urlGenerator,
54
-		IL10N $il10n,
55
-		ICloudIdManager $cloudIdManager
56
-	) {
57
-		$this->l = $il10n;
58
-		$this->urlGenerator = $urlGenerator;
59
-		$this->cloudIdManager = $cloudIdManager;
60
-	}
61
-
62
-	/**
63
-	 * split user and remote from federated cloud id
64
-	 *
65
-	 * @param string $address federated share address
66
-	 * @return array [user, remoteURL]
67
-	 * @throws HintException
68
-	 */
69
-	public function splitUserRemote($address) {
70
-		try {
71
-			$cloudId = $this->cloudIdManager->resolveCloudId($address);
72
-			return [$cloudId->getUser(), $cloudId->getRemote()];
73
-		} catch (\InvalidArgumentException $e) {
74
-			$hint = $this->l->t('Invalid Federated Cloud ID');
75
-			throw new HintException('Invalid Federated Cloud ID', $hint, 0, $e);
76
-		}
77
-	}
78
-
79
-	/**
80
-	 * generate remote URL part of federated ID
81
-	 *
82
-	 * @return string url of the current server
83
-	 */
84
-	public function generateRemoteURL() {
85
-		$url = $this->urlGenerator->getAbsoluteURL('/');
86
-		return $url;
87
-	}
88
-
89
-	/**
90
-	 * check if two federated cloud IDs refer to the same user
91
-	 *
92
-	 * @param string $user1
93
-	 * @param string $server1
94
-	 * @param string $user2
95
-	 * @param string $server2
96
-	 * @return bool true if both users and servers are the same
97
-	 */
98
-	public function compareAddresses($user1, $server1, $user2, $server2) {
99
-		$normalizedServer1 = strtolower($this->removeProtocolFromUrl($server1));
100
-		$normalizedServer2 = strtolower($this->removeProtocolFromUrl($server2));
101
-
102
-		if (rtrim($normalizedServer1, '/') === rtrim($normalizedServer2, '/')) {
103
-			// FIXME this should be a method in the user management instead
104
-			\OCP\Util::emitHook(
105
-				'\OCA\Files_Sharing\API\Server2Server',
106
-				'preLoginNameUsedAsUserName',
107
-				array('uid' => &$user1)
108
-			);
109
-			\OCP\Util::emitHook(
110
-				'\OCA\Files_Sharing\API\Server2Server',
111
-				'preLoginNameUsedAsUserName',
112
-				array('uid' => &$user2)
113
-			);
114
-
115
-			if ($user1 === $user2) {
116
-				return true;
117
-			}
118
-		}
119
-
120
-		return false;
121
-	}
122
-
123
-	/**
124
-	 * remove protocol from URL
125
-	 *
126
-	 * @param string $url
127
-	 * @return string
128
-	 */
129
-	public function removeProtocolFromUrl($url) {
130
-		if (strpos($url, 'https://') === 0) {
131
-			return substr($url, strlen('https://'));
132
-		} else if (strpos($url, 'http://') === 0) {
133
-			return substr($url, strlen('http://'));
134
-		}
135
-
136
-		return $url;
137
-	}
138
-
139
-	/**
140
-	 * check if the url contain the protocol (http or https)
141
-	 *
142
-	 * @param string $url
143
-	 * @return bool
144
-	 */
145
-	public function urlContainProtocol($url) {
146
-		if (strpos($url, 'https://') === 0 ||
147
-			strpos($url, 'http://') === 0) {
148
-
149
-			return true;
150
-		}
151
-
152
-		return false;
153
-	}
36
+    /** @var IL10N */
37
+    private $l;
38
+
39
+    /** @var IURLGenerator */
40
+    private $urlGenerator;
41
+
42
+    /** @var ICloudIdManager */
43
+    private $cloudIdManager;
44
+
45
+    /**
46
+     * AddressHandler constructor.
47
+     *
48
+     * @param IURLGenerator $urlGenerator
49
+     * @param IL10N $il10n
50
+     * @param ICloudIdManager $cloudIdManager
51
+     */
52
+    public function __construct(
53
+        IURLGenerator $urlGenerator,
54
+        IL10N $il10n,
55
+        ICloudIdManager $cloudIdManager
56
+    ) {
57
+        $this->l = $il10n;
58
+        $this->urlGenerator = $urlGenerator;
59
+        $this->cloudIdManager = $cloudIdManager;
60
+    }
61
+
62
+    /**
63
+     * split user and remote from federated cloud id
64
+     *
65
+     * @param string $address federated share address
66
+     * @return array [user, remoteURL]
67
+     * @throws HintException
68
+     */
69
+    public function splitUserRemote($address) {
70
+        try {
71
+            $cloudId = $this->cloudIdManager->resolveCloudId($address);
72
+            return [$cloudId->getUser(), $cloudId->getRemote()];
73
+        } catch (\InvalidArgumentException $e) {
74
+            $hint = $this->l->t('Invalid Federated Cloud ID');
75
+            throw new HintException('Invalid Federated Cloud ID', $hint, 0, $e);
76
+        }
77
+    }
78
+
79
+    /**
80
+     * generate remote URL part of federated ID
81
+     *
82
+     * @return string url of the current server
83
+     */
84
+    public function generateRemoteURL() {
85
+        $url = $this->urlGenerator->getAbsoluteURL('/');
86
+        return $url;
87
+    }
88
+
89
+    /**
90
+     * check if two federated cloud IDs refer to the same user
91
+     *
92
+     * @param string $user1
93
+     * @param string $server1
94
+     * @param string $user2
95
+     * @param string $server2
96
+     * @return bool true if both users and servers are the same
97
+     */
98
+    public function compareAddresses($user1, $server1, $user2, $server2) {
99
+        $normalizedServer1 = strtolower($this->removeProtocolFromUrl($server1));
100
+        $normalizedServer2 = strtolower($this->removeProtocolFromUrl($server2));
101
+
102
+        if (rtrim($normalizedServer1, '/') === rtrim($normalizedServer2, '/')) {
103
+            // FIXME this should be a method in the user management instead
104
+            \OCP\Util::emitHook(
105
+                '\OCA\Files_Sharing\API\Server2Server',
106
+                'preLoginNameUsedAsUserName',
107
+                array('uid' => &$user1)
108
+            );
109
+            \OCP\Util::emitHook(
110
+                '\OCA\Files_Sharing\API\Server2Server',
111
+                'preLoginNameUsedAsUserName',
112
+                array('uid' => &$user2)
113
+            );
114
+
115
+            if ($user1 === $user2) {
116
+                return true;
117
+            }
118
+        }
119
+
120
+        return false;
121
+    }
122
+
123
+    /**
124
+     * remove protocol from URL
125
+     *
126
+     * @param string $url
127
+     * @return string
128
+     */
129
+    public function removeProtocolFromUrl($url) {
130
+        if (strpos($url, 'https://') === 0) {
131
+            return substr($url, strlen('https://'));
132
+        } else if (strpos($url, 'http://') === 0) {
133
+            return substr($url, strlen('http://'));
134
+        }
135
+
136
+        return $url;
137
+    }
138
+
139
+    /**
140
+     * check if the url contain the protocol (http or https)
141
+     *
142
+     * @param string $url
143
+     * @return bool
144
+     */
145
+    public function urlContainProtocol($url) {
146
+        if (strpos($url, 'https://') === 0 ||
147
+            strpos($url, 'http://') === 0) {
148
+
149
+            return true;
150
+        }
151
+
152
+        return false;
153
+    }
154 154
 }
Please login to merge, or discard this patch.
apps/federation/templates/settings-admin.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -28,10 +28,10 @@
 block discarded – undo
28 28
 				<?php if((int)$trustedServer['status'] === TrustedServers::STATUS_OK) { ?>
29 29
 					<span class="status success"></span>
30 30
 				<?php
31
-				} elseif(
32
-					(int)$trustedServer['status'] === TrustedServers::STATUS_PENDING ||
33
-					(int)$trustedServer['status'] === TrustedServers::STATUS_ACCESS_REVOKED
34
-				) { ?>
31
+                } elseif(
32
+                    (int)$trustedServer['status'] === TrustedServers::STATUS_PENDING ||
33
+                    (int)$trustedServer['status'] === TrustedServers::STATUS_ACCESS_REVOKED
34
+                ) { ?>
35 35
 					<span class="status indeterminate"></span>
36 36
 				<?php } else {?>
37 37
 					<span class="status error"></span>
Please login to merge, or discard this patch.
apps/federation/lib/DAV/FedAuth.php 1 patch
Indentation   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -29,40 +29,40 @@
 block discarded – undo
29 29
 
30 30
 class FedAuth extends AbstractBasic {
31 31
 
32
-	/** @var DbHandler */
33
-	private $db;
32
+    /** @var DbHandler */
33
+    private $db;
34 34
 
35
-	/**
36
-	 * FedAuth constructor.
37
-	 *
38
-	 * @param DbHandler $db
39
-	 */
40
-	public function __construct(DbHandler $db) {
41
-		$this->db = $db;
42
-		$this->principalPrefix = 'principals/system/';
35
+    /**
36
+     * FedAuth constructor.
37
+     *
38
+     * @param DbHandler $db
39
+     */
40
+    public function __construct(DbHandler $db) {
41
+        $this->db = $db;
42
+        $this->principalPrefix = 'principals/system/';
43 43
 
44
-		// setup realm
45
-		$defaults = new \OCP\Defaults();
46
-		$this->realm = $defaults->getName();
47
-	}
44
+        // setup realm
45
+        $defaults = new \OCP\Defaults();
46
+        $this->realm = $defaults->getName();
47
+    }
48 48
 
49
-	/**
50
-	 * Validates a username and password
51
-	 *
52
-	 * This method should return true or false depending on if login
53
-	 * succeeded.
54
-	 *
55
-	 * @param string $username
56
-	 * @param string $password
57
-	 * @return bool
58
-	 */
59
-	protected function validateUserPass($username, $password) {
60
-		return $this->db->auth($username, $password);
61
-	}
49
+    /**
50
+     * Validates a username and password
51
+     *
52
+     * This method should return true or false depending on if login
53
+     * succeeded.
54
+     *
55
+     * @param string $username
56
+     * @param string $password
57
+     * @return bool
58
+     */
59
+    protected function validateUserPass($username, $password) {
60
+        return $this->db->auth($username, $password);
61
+    }
62 62
 
63
-	/**
64
-	 * @inheritdoc
65
-	 */
66
-	function challenge(RequestInterface $request, ResponseInterface $response) {
67
-	}
63
+    /**
64
+     * @inheritdoc
65
+     */
66
+    function challenge(RequestInterface $request, ResponseInterface $response) {
67
+    }
68 68
 }
Please login to merge, or discard this patch.
apps/federation/lib/Command/SyncFederationAddressBooks.php 1 patch
Indentation   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -31,45 +31,45 @@
 block discarded – undo
31 31
 
32 32
 class SyncFederationAddressBooks extends Command {
33 33
 
34
-	/** @var \OCA\Federation\SyncFederationAddressBooks */
35
-	private $syncService;
34
+    /** @var \OCA\Federation\SyncFederationAddressBooks */
35
+    private $syncService;
36 36
 
37
-	/**
38
-	 * @param \OCA\Federation\SyncFederationAddressBooks $syncService
39
-	 */
40
-	function __construct(\OCA\Federation\SyncFederationAddressBooks $syncService) {
41
-		parent::__construct();
37
+    /**
38
+     * @param \OCA\Federation\SyncFederationAddressBooks $syncService
39
+     */
40
+    function __construct(\OCA\Federation\SyncFederationAddressBooks $syncService) {
41
+        parent::__construct();
42 42
 
43
-		$this->syncService = $syncService;
44
-	}
43
+        $this->syncService = $syncService;
44
+    }
45 45
 
46
-	protected function configure() {
47
-		$this
48
-			->setName('federation:sync-addressbooks')
49
-			->setDescription('Synchronizes addressbooks of all federated clouds');
50
-	}
46
+    protected function configure() {
47
+        $this
48
+            ->setName('federation:sync-addressbooks')
49
+            ->setDescription('Synchronizes addressbooks of all federated clouds');
50
+    }
51 51
 
52
-	/**
53
-	 * @param InputInterface $input
54
-	 * @param OutputInterface $output
55
-	 * @return int
56
-	 */
57
-	protected function execute(InputInterface $input, OutputInterface $output) {
52
+    /**
53
+     * @param InputInterface $input
54
+     * @param OutputInterface $output
55
+     * @return int
56
+     */
57
+    protected function execute(InputInterface $input, OutputInterface $output) {
58 58
 
59
-		$progress = new ProgressBar($output);
60
-		$progress->start();
61
-		$this->syncService->syncThemAll(function($url, $ex) use ($progress, $output) {
62
-			if ($ex instanceof \Exception) {
63
-				$output->writeln("Error while syncing $url : " . $ex->getMessage());
59
+        $progress = new ProgressBar($output);
60
+        $progress->start();
61
+        $this->syncService->syncThemAll(function($url, $ex) use ($progress, $output) {
62
+            if ($ex instanceof \Exception) {
63
+                $output->writeln("Error while syncing $url : " . $ex->getMessage());
64 64
 
65
-			} else {
66
-				$progress->advance();
67
-			}
68
-		});
65
+            } else {
66
+                $progress->advance();
67
+            }
68
+        });
69 69
 
70
-		$progress->finish();
71
-		$output->writeln('');
70
+        $progress->finish();
71
+        $output->writeln('');
72 72
 
73
-		return 0;
74
-	}
73
+        return 0;
74
+    }
75 75
 }
Please login to merge, or discard this patch.
apps/federation/lib/Settings/Admin.php 1 patch
Indentation   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -29,41 +29,41 @@
 block discarded – undo
29 29
 
30 30
 class Admin implements ISettings {
31 31
 
32
-	/** @var TrustedServers */
33
-	private $trustedServers;
32
+    /** @var TrustedServers */
33
+    private $trustedServers;
34 34
 
35
-	public function __construct(TrustedServers $trustedServers) {
36
-		$this->trustedServers = $trustedServers;
37
-	}
35
+    public function __construct(TrustedServers $trustedServers) {
36
+        $this->trustedServers = $trustedServers;
37
+    }
38 38
 
39
-	/**
40
-	 * @return TemplateResponse
41
-	 */
42
-	public function getForm() {
43
-		$parameters = [
44
-			'trustedServers' => $this->trustedServers->getServers(),
45
-			'autoAddServers' => $this->trustedServers->getAutoAddServers(),
46
-		];
39
+    /**
40
+     * @return TemplateResponse
41
+     */
42
+    public function getForm() {
43
+        $parameters = [
44
+            'trustedServers' => $this->trustedServers->getServers(),
45
+            'autoAddServers' => $this->trustedServers->getAutoAddServers(),
46
+        ];
47 47
 
48
-		return new TemplateResponse('federation', 'settings-admin', $parameters, '');
49
-	}
48
+        return new TemplateResponse('federation', 'settings-admin', $parameters, '');
49
+    }
50 50
 
51
-	/**
52
-	 * @return string the section ID, e.g. 'sharing'
53
-	 */
54
-	public function getSection() {
55
-		return 'sharing';
56
-	}
51
+    /**
52
+     * @return string the section ID, e.g. 'sharing'
53
+     */
54
+    public function getSection() {
55
+        return 'sharing';
56
+    }
57 57
 
58
-	/**
59
-	 * @return int whether the form should be rather on the top or bottom of
60
-	 * the admin section. The forms are arranged in ascending order of the
61
-	 * priority values. It is required to return a value between 0 and 100.
62
-	 *
63
-	 * E.g.: 70
64
-	 */
65
-	public function getPriority() {
66
-		return 30;
67
-	}
58
+    /**
59
+     * @return int whether the form should be rather on the top or bottom of
60
+     * the admin section. The forms are arranged in ascending order of the
61
+     * priority values. It is required to return a value between 0 and 100.
62
+     *
63
+     * E.g.: 70
64
+     */
65
+    public function getPriority() {
66
+        return 30;
67
+    }
68 68
 
69 69
 }
Please login to merge, or discard this patch.
apps/federation/lib/Hooks.php 1 patch
Indentation   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -27,25 +27,25 @@
 block discarded – undo
27 27
 
28 28
 class Hooks {
29 29
 
30
-	/** @var TrustedServers */
31
-	private $trustedServers;
32
-
33
-	public function __construct(TrustedServers $trustedServers) {
34
-		$this->trustedServers = $trustedServers;
35
-	}
36
-
37
-	/**
38
-	 * add servers to the list of trusted servers once a federated share was established
39
-	 *
40
-	 * @param array $params
41
-	 */
42
-	public function addServerHook($params) {
43
-		if (
44
-			$this->trustedServers->getAutoAddServers() === true &&
45
-			$this->trustedServers->isTrustedServer($params['server']) === false
46
-		) {
47
-			$this->trustedServers->addServer($params['server']);
48
-		}
49
-	}
30
+    /** @var TrustedServers */
31
+    private $trustedServers;
32
+
33
+    public function __construct(TrustedServers $trustedServers) {
34
+        $this->trustedServers = $trustedServers;
35
+    }
36
+
37
+    /**
38
+     * add servers to the list of trusted servers once a federated share was established
39
+     *
40
+     * @param array $params
41
+     */
42
+    public function addServerHook($params) {
43
+        if (
44
+            $this->trustedServers->getAutoAddServers() === true &&
45
+            $this->trustedServers->isTrustedServer($params['server']) === false
46
+        ) {
47
+            $this->trustedServers->addServer($params['server']);
48
+        }
49
+    }
50 50
 
51 51
 }
Please login to merge, or discard this patch.
apps/federation/lib/DbHandler.php 1 patch
Indentation   +275 added lines, -275 removed lines patch added patch discarded remove patch
@@ -42,280 +42,280 @@
 block discarded – undo
42 42
  */
43 43
 class DbHandler {
44 44
 
45
-	/** @var  IDBConnection */
46
-	private $connection;
47
-
48
-	/** @var  IL10N */
49
-	private $IL10N;
50
-
51
-	/** @var string  */
52
-	private $dbTable = 'trusted_servers';
53
-
54
-	/**
55
-	 * @param IDBConnection $connection
56
-	 * @param IL10N $il10n
57
-	 */
58
-	public function __construct(
59
-		IDBConnection $connection,
60
-		IL10N $il10n
61
-	) {
62
-		$this->connection = $connection;
63
-		$this->IL10N = $il10n;
64
-	}
65
-
66
-	/**
67
-	 * add server to the list of trusted servers
68
-	 *
69
-	 * @param string $url
70
-	 * @return int
71
-	 * @throws HintException
72
-	 */
73
-	public function addServer($url) {
74
-		$hash = $this->hash($url);
75
-		$url = rtrim($url, '/');
76
-		$query = $this->connection->getQueryBuilder();
77
-		$query->insert($this->dbTable)
78
-			->values(
79
-				[
80
-					'url' =>  $query->createParameter('url'),
81
-					'url_hash' => $query->createParameter('url_hash'),
82
-				]
83
-			)
84
-			->setParameter('url', $url)
85
-			->setParameter('url_hash', $hash);
86
-
87
-		$result = $query->execute();
88
-
89
-		if ($result) {
90
-			return (int)$this->connection->lastInsertId('*PREFIX*'.$this->dbTable);
91
-		} else {
92
-			$message = 'Internal failure, Could not add trusted server: ' . $url;
93
-			$message_t = $this->IL10N->t('Could not add server');
94
-			throw new HintException($message, $message_t);
95
-		}
96
-	}
97
-
98
-	/**
99
-	 * remove server from the list of trusted servers
100
-	 *
101
-	 * @param int $id
102
-	 */
103
-	public function removeServer($id) {
104
-		$query = $this->connection->getQueryBuilder();
105
-		$query->delete($this->dbTable)
106
-			->where($query->expr()->eq('id', $query->createParameter('id')))
107
-			->setParameter('id', $id);
108
-		$query->execute();
109
-	}
110
-
111
-	/**
112
-	 * get trusted server with given ID
113
-	 *
114
-	 * @param int $id
115
-	 * @return array
116
-	 * @throws \Exception
117
-	 */
118
-	public function getServerById($id) {
119
-		$query = $this->connection->getQueryBuilder();
120
-		$query->select('*')->from($this->dbTable)
121
-			->where($query->expr()->eq('id', $query->createParameter('id')))
122
-			->setParameter('id', $id);
123
-		$query->execute();
124
-		$result = $query->execute()->fetchAll();
125
-
126
-		if (empty($result)) {
127
-			throw new \Exception('No Server found with ID: ' . $id);
128
-		}
129
-
130
-		return $result[0];
131
-	}
132
-
133
-	/**
134
-	 * get all trusted servers
135
-	 *
136
-	 * @return array
137
-	 */
138
-	public function getAllServer() {
139
-		$query = $this->connection->getQueryBuilder();
140
-		$query->select(['url', 'url_hash', 'id', 'status', 'shared_secret', 'sync_token'])->from($this->dbTable);
141
-		$result = $query->execute()->fetchAll();
142
-		return $result;
143
-	}
144
-
145
-	/**
146
-	 * check if server already exists in the database table
147
-	 *
148
-	 * @param string $url
149
-	 * @return bool
150
-	 */
151
-	public function serverExists($url) {
152
-		$hash = $this->hash($url);
153
-		$query = $this->connection->getQueryBuilder();
154
-		$query->select('url')->from($this->dbTable)
155
-			->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
156
-			->setParameter('url_hash', $hash);
157
-		$result = $query->execute()->fetchAll();
158
-
159
-		return !empty($result);
160
-	}
161
-
162
-	/**
163
-	 * write token to database. Token is used to exchange the secret
164
-	 *
165
-	 * @param string $url
166
-	 * @param string $token
167
-	 */
168
-	public function addToken($url, $token) {
169
-		$hash = $this->hash($url);
170
-		$query = $this->connection->getQueryBuilder();
171
-		$query->update($this->dbTable)
172
-			->set('token', $query->createParameter('token'))
173
-			->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
174
-			->setParameter('url_hash', $hash)
175
-			->setParameter('token', $token);
176
-		$query->execute();
177
-	}
178
-
179
-	/**
180
-	 * get token stored in database
181
-	 *
182
-	 * @param string $url
183
-	 * @return string
184
-	 * @throws \Exception
185
-	 */
186
-	public function getToken($url) {
187
-		$hash = $this->hash($url);
188
-		$query = $this->connection->getQueryBuilder();
189
-		$query->select('token')->from($this->dbTable)
190
-			->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
191
-			->setParameter('url_hash', $hash);
192
-
193
-		$result = $query->execute()->fetch();
194
-
195
-		if (!isset($result['token'])) {
196
-			throw new \Exception('No token found for: ' . $url);
197
-		}
198
-
199
-		return $result['token'];
200
-	}
201
-
202
-	/**
203
-	 * add shared Secret to database
204
-	 *
205
-	 * @param string $url
206
-	 * @param string $sharedSecret
207
-	 */
208
-	public function addSharedSecret($url, $sharedSecret) {
209
-		$hash = $this->hash($url);
210
-		$query = $this->connection->getQueryBuilder();
211
-		$query->update($this->dbTable)
212
-			->set('shared_secret', $query->createParameter('sharedSecret'))
213
-			->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
214
-			->setParameter('url_hash', $hash)
215
-			->setParameter('sharedSecret', $sharedSecret);
216
-		$query->execute();
217
-	}
218
-
219
-	/**
220
-	 * get shared secret from database
221
-	 *
222
-	 * @param string $url
223
-	 * @return string
224
-	 */
225
-	public function getSharedSecret($url) {
226
-		$hash = $this->hash($url);
227
-		$query = $this->connection->getQueryBuilder();
228
-		$query->select('shared_secret')->from($this->dbTable)
229
-			->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
230
-			->setParameter('url_hash', $hash);
231
-
232
-		$result = $query->execute()->fetch();
233
-		return $result['shared_secret'];
234
-	}
235
-
236
-	/**
237
-	 * set server status
238
-	 *
239
-	 * @param string $url
240
-	 * @param int $status
241
-	 * @param string|null $token
242
-	 */
243
-	public function setServerStatus($url, $status, $token = null) {
244
-		$hash = $this->hash($url);
245
-		$query = $this->connection->getQueryBuilder();
246
-		$query->update($this->dbTable)
247
-				->set('status', $query->createNamedParameter($status))
248
-				->where($query->expr()->eq('url_hash', $query->createNamedParameter($hash)));
249
-		if (!is_null($token)) {
250
-			$query->set('sync_token', $query->createNamedParameter($token));
251
-		}
252
-		$query->execute();
253
-	}
254
-
255
-	/**
256
-	 * get server status
257
-	 *
258
-	 * @param string $url
259
-	 * @return int
260
-	 */
261
-	public function getServerStatus($url) {
262
-		$hash = $this->hash($url);
263
-		$query = $this->connection->getQueryBuilder();
264
-		$query->select('status')->from($this->dbTable)
265
-				->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
266
-				->setParameter('url_hash', $hash);
267
-
268
-		$result = $query->execute()->fetch();
269
-		return (int)$result['status'];
270
-	}
271
-
272
-	/**
273
-	 * create hash from URL
274
-	 *
275
-	 * @param string $url
276
-	 * @return string
277
-	 */
278
-	protected function hash($url) {
279
-		$normalized = $this->normalizeUrl($url);
280
-		return sha1($normalized);
281
-	}
282
-
283
-	/**
284
-	 * normalize URL, used to create the sha1 hash
285
-	 *
286
-	 * @param string $url
287
-	 * @return string
288
-	 */
289
-	protected function normalizeUrl($url) {
290
-		$normalized = $url;
291
-
292
-		if (strpos($url, 'https://') === 0) {
293
-			$normalized = substr($url, strlen('https://'));
294
-		} else if (strpos($url, 'http://') === 0) {
295
-			$normalized = substr($url, strlen('http://'));
296
-		}
297
-
298
-		$normalized = Filesystem::normalizePath($normalized);
299
-		$normalized = trim($normalized, '/');
300
-
301
-		return $normalized;
302
-	}
303
-
304
-	/**
305
-	 * @param $username
306
-	 * @param $password
307
-	 * @return bool
308
-	 */
309
-	public function auth($username, $password) {
310
-		if ($username !== 'system') {
311
-			return false;
312
-		}
313
-		$query = $this->connection->getQueryBuilder();
314
-		$query->select('url')->from($this->dbTable)
315
-				->where($query->expr()->eq('shared_secret', $query->createNamedParameter($password)));
316
-
317
-		$result = $query->execute()->fetch();
318
-		return !empty($result);
319
-	}
45
+    /** @var  IDBConnection */
46
+    private $connection;
47
+
48
+    /** @var  IL10N */
49
+    private $IL10N;
50
+
51
+    /** @var string  */
52
+    private $dbTable = 'trusted_servers';
53
+
54
+    /**
55
+     * @param IDBConnection $connection
56
+     * @param IL10N $il10n
57
+     */
58
+    public function __construct(
59
+        IDBConnection $connection,
60
+        IL10N $il10n
61
+    ) {
62
+        $this->connection = $connection;
63
+        $this->IL10N = $il10n;
64
+    }
65
+
66
+    /**
67
+     * add server to the list of trusted servers
68
+     *
69
+     * @param string $url
70
+     * @return int
71
+     * @throws HintException
72
+     */
73
+    public function addServer($url) {
74
+        $hash = $this->hash($url);
75
+        $url = rtrim($url, '/');
76
+        $query = $this->connection->getQueryBuilder();
77
+        $query->insert($this->dbTable)
78
+            ->values(
79
+                [
80
+                    'url' =>  $query->createParameter('url'),
81
+                    'url_hash' => $query->createParameter('url_hash'),
82
+                ]
83
+            )
84
+            ->setParameter('url', $url)
85
+            ->setParameter('url_hash', $hash);
86
+
87
+        $result = $query->execute();
88
+
89
+        if ($result) {
90
+            return (int)$this->connection->lastInsertId('*PREFIX*'.$this->dbTable);
91
+        } else {
92
+            $message = 'Internal failure, Could not add trusted server: ' . $url;
93
+            $message_t = $this->IL10N->t('Could not add server');
94
+            throw new HintException($message, $message_t);
95
+        }
96
+    }
97
+
98
+    /**
99
+     * remove server from the list of trusted servers
100
+     *
101
+     * @param int $id
102
+     */
103
+    public function removeServer($id) {
104
+        $query = $this->connection->getQueryBuilder();
105
+        $query->delete($this->dbTable)
106
+            ->where($query->expr()->eq('id', $query->createParameter('id')))
107
+            ->setParameter('id', $id);
108
+        $query->execute();
109
+    }
110
+
111
+    /**
112
+     * get trusted server with given ID
113
+     *
114
+     * @param int $id
115
+     * @return array
116
+     * @throws \Exception
117
+     */
118
+    public function getServerById($id) {
119
+        $query = $this->connection->getQueryBuilder();
120
+        $query->select('*')->from($this->dbTable)
121
+            ->where($query->expr()->eq('id', $query->createParameter('id')))
122
+            ->setParameter('id', $id);
123
+        $query->execute();
124
+        $result = $query->execute()->fetchAll();
125
+
126
+        if (empty($result)) {
127
+            throw new \Exception('No Server found with ID: ' . $id);
128
+        }
129
+
130
+        return $result[0];
131
+    }
132
+
133
+    /**
134
+     * get all trusted servers
135
+     *
136
+     * @return array
137
+     */
138
+    public function getAllServer() {
139
+        $query = $this->connection->getQueryBuilder();
140
+        $query->select(['url', 'url_hash', 'id', 'status', 'shared_secret', 'sync_token'])->from($this->dbTable);
141
+        $result = $query->execute()->fetchAll();
142
+        return $result;
143
+    }
144
+
145
+    /**
146
+     * check if server already exists in the database table
147
+     *
148
+     * @param string $url
149
+     * @return bool
150
+     */
151
+    public function serverExists($url) {
152
+        $hash = $this->hash($url);
153
+        $query = $this->connection->getQueryBuilder();
154
+        $query->select('url')->from($this->dbTable)
155
+            ->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
156
+            ->setParameter('url_hash', $hash);
157
+        $result = $query->execute()->fetchAll();
158
+
159
+        return !empty($result);
160
+    }
161
+
162
+    /**
163
+     * write token to database. Token is used to exchange the secret
164
+     *
165
+     * @param string $url
166
+     * @param string $token
167
+     */
168
+    public function addToken($url, $token) {
169
+        $hash = $this->hash($url);
170
+        $query = $this->connection->getQueryBuilder();
171
+        $query->update($this->dbTable)
172
+            ->set('token', $query->createParameter('token'))
173
+            ->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
174
+            ->setParameter('url_hash', $hash)
175
+            ->setParameter('token', $token);
176
+        $query->execute();
177
+    }
178
+
179
+    /**
180
+     * get token stored in database
181
+     *
182
+     * @param string $url
183
+     * @return string
184
+     * @throws \Exception
185
+     */
186
+    public function getToken($url) {
187
+        $hash = $this->hash($url);
188
+        $query = $this->connection->getQueryBuilder();
189
+        $query->select('token')->from($this->dbTable)
190
+            ->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
191
+            ->setParameter('url_hash', $hash);
192
+
193
+        $result = $query->execute()->fetch();
194
+
195
+        if (!isset($result['token'])) {
196
+            throw new \Exception('No token found for: ' . $url);
197
+        }
198
+
199
+        return $result['token'];
200
+    }
201
+
202
+    /**
203
+     * add shared Secret to database
204
+     *
205
+     * @param string $url
206
+     * @param string $sharedSecret
207
+     */
208
+    public function addSharedSecret($url, $sharedSecret) {
209
+        $hash = $this->hash($url);
210
+        $query = $this->connection->getQueryBuilder();
211
+        $query->update($this->dbTable)
212
+            ->set('shared_secret', $query->createParameter('sharedSecret'))
213
+            ->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
214
+            ->setParameter('url_hash', $hash)
215
+            ->setParameter('sharedSecret', $sharedSecret);
216
+        $query->execute();
217
+    }
218
+
219
+    /**
220
+     * get shared secret from database
221
+     *
222
+     * @param string $url
223
+     * @return string
224
+     */
225
+    public function getSharedSecret($url) {
226
+        $hash = $this->hash($url);
227
+        $query = $this->connection->getQueryBuilder();
228
+        $query->select('shared_secret')->from($this->dbTable)
229
+            ->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
230
+            ->setParameter('url_hash', $hash);
231
+
232
+        $result = $query->execute()->fetch();
233
+        return $result['shared_secret'];
234
+    }
235
+
236
+    /**
237
+     * set server status
238
+     *
239
+     * @param string $url
240
+     * @param int $status
241
+     * @param string|null $token
242
+     */
243
+    public function setServerStatus($url, $status, $token = null) {
244
+        $hash = $this->hash($url);
245
+        $query = $this->connection->getQueryBuilder();
246
+        $query->update($this->dbTable)
247
+                ->set('status', $query->createNamedParameter($status))
248
+                ->where($query->expr()->eq('url_hash', $query->createNamedParameter($hash)));
249
+        if (!is_null($token)) {
250
+            $query->set('sync_token', $query->createNamedParameter($token));
251
+        }
252
+        $query->execute();
253
+    }
254
+
255
+    /**
256
+     * get server status
257
+     *
258
+     * @param string $url
259
+     * @return int
260
+     */
261
+    public function getServerStatus($url) {
262
+        $hash = $this->hash($url);
263
+        $query = $this->connection->getQueryBuilder();
264
+        $query->select('status')->from($this->dbTable)
265
+                ->where($query->expr()->eq('url_hash', $query->createParameter('url_hash')))
266
+                ->setParameter('url_hash', $hash);
267
+
268
+        $result = $query->execute()->fetch();
269
+        return (int)$result['status'];
270
+    }
271
+
272
+    /**
273
+     * create hash from URL
274
+     *
275
+     * @param string $url
276
+     * @return string
277
+     */
278
+    protected function hash($url) {
279
+        $normalized = $this->normalizeUrl($url);
280
+        return sha1($normalized);
281
+    }
282
+
283
+    /**
284
+     * normalize URL, used to create the sha1 hash
285
+     *
286
+     * @param string $url
287
+     * @return string
288
+     */
289
+    protected function normalizeUrl($url) {
290
+        $normalized = $url;
291
+
292
+        if (strpos($url, 'https://') === 0) {
293
+            $normalized = substr($url, strlen('https://'));
294
+        } else if (strpos($url, 'http://') === 0) {
295
+            $normalized = substr($url, strlen('http://'));
296
+        }
297
+
298
+        $normalized = Filesystem::normalizePath($normalized);
299
+        $normalized = trim($normalized, '/');
300
+
301
+        return $normalized;
302
+    }
303
+
304
+    /**
305
+     * @param $username
306
+     * @param $password
307
+     * @return bool
308
+     */
309
+    public function auth($username, $password) {
310
+        if ($username !== 'system') {
311
+            return false;
312
+        }
313
+        $query = $this->connection->getQueryBuilder();
314
+        $query->select('url')->from($this->dbTable)
315
+                ->where($query->expr()->eq('shared_secret', $query->createNamedParameter($password)));
316
+
317
+        $result = $query->execute()->fetch();
318
+        return !empty($result);
319
+    }
320 320
 
321 321
 }
Please login to merge, or discard this patch.
apps/federation/lib/SyncJob.php 1 patch
Indentation   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -27,18 +27,18 @@
 block discarded – undo
27 27
 
28 28
 class SyncJob extends TimedJob {
29 29
 
30
-	public function __construct() {
31
-		// Run once a day
32
-		$this->setInterval(24 * 60 * 60);
33
-	}
30
+    public function __construct() {
31
+        // Run once a day
32
+        $this->setInterval(24 * 60 * 60);
33
+    }
34 34
 
35
-	protected function run($argument) {
36
-		$app = new Application();
37
-		$ss = $app->getSyncService();
38
-		$ss->syncThemAll(function($url, $ex) {
39
-			if ($ex instanceof \Exception) {
40
-				\OC::$server->getLogger()->error("Error while syncing $url : " . $ex->getMessage(), ['app' => 'fed-sync']);
41
-			}
42
-		});
43
-	}
35
+    protected function run($argument) {
36
+        $app = new Application();
37
+        $ss = $app->getSyncService();
38
+        $ss->syncThemAll(function($url, $ex) {
39
+            if ($ex instanceof \Exception) {
40
+                \OC::$server->getLogger()->error("Error while syncing $url : " . $ex->getMessage(), ['app' => 'fed-sync']);
41
+            }
42
+        });
43
+    }
44 44
 }
Please login to merge, or discard this patch.
apps/dav/lib/DAV/PublicAuth.php 1 patch
Indentation   +58 added lines, -58 removed lines patch added patch discarded remove patch
@@ -26,67 +26,67 @@
 block discarded – undo
26 26
 
27 27
 class PublicAuth implements BackendInterface {
28 28
 
29
-	/** @var string[] */
30
-	private $publicURLs;
29
+    /** @var string[] */
30
+    private $publicURLs;
31 31
 
32
-	public function __construct() {
33
-		$this->publicURLs = [
34
-			'public-calendars',
35
-			'principals/system/public'
36
-		];
37
-	}
32
+    public function __construct() {
33
+        $this->publicURLs = [
34
+            'public-calendars',
35
+            'principals/system/public'
36
+        ];
37
+    }
38 38
 
39
-	/**
40
-	 * When this method is called, the backend must check if authentication was
41
-	 * successful.
42
-	 *
43
-	 * The returned value must be one of the following
44
-	 *
45
-	 * [true, "principals/username"]
46
-	 * [false, "reason for failure"]
47
-	 *
48
-	 * If authentication was successful, it's expected that the authentication
49
-	 * backend returns a so-called principal url.
50
-	 *
51
-	 * Examples of a principal url:
52
-	 *
53
-	 * principals/admin
54
-	 * principals/user1
55
-	 * principals/users/joe
56
-	 * principals/uid/123457
57
-	 *
58
-	 * If you don't use WebDAV ACL (RFC3744) we recommend that you simply
59
-	 * return a string such as:
60
-	 *
61
-	 * principals/users/[username]
62
-	 *
63
-	 * @param RequestInterface $request
64
-	 * @param ResponseInterface $response
65
-	 * @return array
66
-	 */
67
-	function check(RequestInterface $request, ResponseInterface $response) {
39
+    /**
40
+     * When this method is called, the backend must check if authentication was
41
+     * successful.
42
+     *
43
+     * The returned value must be one of the following
44
+     *
45
+     * [true, "principals/username"]
46
+     * [false, "reason for failure"]
47
+     *
48
+     * If authentication was successful, it's expected that the authentication
49
+     * backend returns a so-called principal url.
50
+     *
51
+     * Examples of a principal url:
52
+     *
53
+     * principals/admin
54
+     * principals/user1
55
+     * principals/users/joe
56
+     * principals/uid/123457
57
+     *
58
+     * If you don't use WebDAV ACL (RFC3744) we recommend that you simply
59
+     * return a string such as:
60
+     *
61
+     * principals/users/[username]
62
+     *
63
+     * @param RequestInterface $request
64
+     * @param ResponseInterface $response
65
+     * @return array
66
+     */
67
+    function check(RequestInterface $request, ResponseInterface $response) {
68 68
 
69
-		if ($this->isRequestPublic($request)) {
70
-			return [true, "principals/system/public"];
71
-		}
72
-		return [false, "No public access to this resource."];
73
-	}
69
+        if ($this->isRequestPublic($request)) {
70
+            return [true, "principals/system/public"];
71
+        }
72
+        return [false, "No public access to this resource."];
73
+    }
74 74
 
75
-	/**
76
-	 * @inheritdoc
77
-	 */
78
-	function challenge(RequestInterface $request, ResponseInterface $response) {
79
-	}
75
+    /**
76
+     * @inheritdoc
77
+     */
78
+    function challenge(RequestInterface $request, ResponseInterface $response) {
79
+    }
80 80
 
81
-	/**
82
-	 * @param RequestInterface $request
83
-	 * @return bool
84
-	 */
85
-	private function isRequestPublic(RequestInterface $request) {
86
-		$url = $request->getPath();
87
-		$matchingUrls = array_filter($this->publicURLs, function ($publicUrl) use ($url) {
88
-			return strpos($url, $publicUrl, 0) === 0;
89
-		});
90
-		return !empty($matchingUrls);
91
-	}
81
+    /**
82
+     * @param RequestInterface $request
83
+     * @return bool
84
+     */
85
+    private function isRequestPublic(RequestInterface $request) {
86
+        $url = $request->getPath();
87
+        $matchingUrls = array_filter($this->publicURLs, function ($publicUrl) use ($url) {
88
+            return strpos($url, $publicUrl, 0) === 0;
89
+        });
90
+        return !empty($matchingUrls);
91
+    }
92 92
 }
Please login to merge, or discard this patch.