Completed
Pull Request — master (#2643)
by Jan-Christoph
85:17 queued 76:35
created
lib/private/Share20/ProviderFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -131,7 +131,7 @@
 block discarded – undo
131 131
 	/**
132 132
 	 * Create the federated share provider
133 133
 	 *
134
-	 * @return FederatedShareProvider
134
+	 * @return null|ShareByMailProvider
135 135
 	 */
136 136
 	protected function getShareByMailProvider() {
137 137
 		if ($this->shareByMailProvider === null) {
Please login to merge, or discard this patch.
apps/sharebymail/lib/ShareByMailProvider.php 1 patch
Doc Comments   +11 added lines, -4 removed lines patch added patch discarded remove patch
@@ -184,10 +184,10 @@  discard block
 block discarded – undo
184 184
 	 * publish activity if a file/folder was shared by mail
185 185
 	 *
186 186
 	 * @param $subject
187
-	 * @param $parameters
188
-	 * @param $affectedUser
187
+	 * @param string[] $parameters
188
+	 * @param string $affectedUser
189 189
 	 * @param $fileId
190
-	 * @param $filePath
190
+	 * @param string $filePath
191 191
 	 */
192 192
 	protected function publishActivity($subject, $parameters, $affectedUser, $fileId, $filePath) {
193 193
 		$event = $this->activityManager->generateEvent();
@@ -239,6 +239,12 @@  discard block
 block discarded – undo
239 239
 
240 240
 	}
241 241
 
242
+	/**
243
+	 * @param string $link
244
+	 * @param string $owner
245
+	 * @param string $initiator
246
+	 * @param string $shareWith
247
+	 */
242 248
 	protected function sendMailNotification($filename, $link, $owner, $initiator, $shareWith) {
243 249
 		if ($owner === $initiator) {
244 250
 			$subject = (string)$this->l->t('%s shared »%s« with you', array($owner, $filename));
@@ -264,6 +270,7 @@  discard block
 block discarded – undo
264 270
 	 * @param $link
265 271
 	 * @param $owner
266 272
 	 * @param $initiator
273
+	 * @param string $template
267 274
 	 * @return string plain text mail
268 275
 	 * @throws HintException
269 276
 	 */
@@ -703,7 +710,7 @@  discard block
 block discarded – undo
703 710
 	/**
704 711
 	 * get database row of a give share
705 712
 	 *
706
-	 * @param $id
713
+	 * @param integer $id
707 714
 	 * @return array
708 715
 	 * @throws ShareNotFound
709 716
 	 */
Please login to merge, or discard this patch.
apps/files_sharing/lib/Controller/ShareController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
 	/**
95 95
 	 * Performs a DELETE or UPDATE query to the database.
96 96
 	 * @param \Doctrine\DBAL\Driver\Statement $query
97
-	 * @param array $parameters
97
+	 * @param string[] $parameters
98 98
 	 * @return bool true if at least one row was modified, false otherwise
99 99
 	 */
100 100
 	protected function modify($query, $parameters) {
Please login to merge, or discard this patch.
lib/private/Files/FileInfo.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,6 @@
 block discarded – undo
36 36
 use OCA\Files_Sharing\ISharedStorage;
37 37
 use OCP\Constants;
38 38
 use OCP\Files\Cache\ICacheEntry;
39
-use OCP\Files\Storage\IStorage;
40 39
 use OCP\Lock\ILockingProvider;
41 40
 
42 41
 /**
Please login to merge, or discard this patch.
apps/dav/lib/HookManager.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,6 @@
 block discarded – undo
28 28
 use OCP\IUserManager;
29 29
 use OCP\Util;
30 30
 use Symfony\Component\EventDispatcher\EventDispatcher;
31
-use Symfony\Component\EventDispatcher\GenericEvent;
32 31
 
33 32
 class HookManager {
34 33
 
Please login to merge, or discard this patch.
apps/files_sharing/lib/Cache.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -110,6 +110,9 @@
 block discarded – undo
110 110
 		return parent::moveFromCache($sourceCache, $sourcePath, $targetPath);
111 111
 	}
112 112
 
113
+	/**
114
+	 * @param ICacheEntry $entry
115
+	 */
113 116
 	protected function formatCacheEntry($entry) {
114 117
 		$path = isset($entry['path']) ? $entry['path'] : '';
115 118
 		$entry = parent::formatCacheEntry($entry);
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,6 @@
 block discarded – undo
36 36
 use OCA\Files_Sharing\ISharedStorage;
37 37
 use OCP\Constants;
38 38
 use OCP\Files\Cache\ICacheEntry;
39
-use OCP\Files\Storage\IStorage;
40 39
 use OCP\Lock\ILockingProvider;
41 40
 
42 41
 /**
Please login to merge, or discard this patch.
lib/private/Files/Cache/Wrapper/CacheJail.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -194,6 +194,9 @@
 block discarded – undo
194 194
 		return $this->cache->getStatus($this->getSourcePath($file));
195 195
 	}
196 196
 
197
+	/**
198
+	 * @param ICacheEntry[] $results
199
+	 */
197 200
 	private function formatSearchResults($results) {
198 201
 		$results = array_filter($results, array($this, 'filterCacheEntry'));
199 202
 		$results = array_values($results);
Please login to merge, or discard this patch.
apps/files_sharing/lib/SharedStorage.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,6 @@
 block discarded – undo
32 32
 namespace OCA\Files_Sharing;
33 33
 
34 34
 use OC\Files\Filesystem;
35
-use OC\Files\Cache\FailedCache;
36 35
 use OC\Files\Storage\FailedStorage;
37 36
 use OCP\Constants;
38 37
 use OCP\Files\Cache\ICacheEntry;
Please login to merge, or discard this patch.
apps/files_sharing/lib/Controller/ShareesAPIController.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
 	 * split user and remote from federated cloud id
351 351
 	 *
352 352
 	 * @param string $address federated share address
353
-	 * @return array [user, remoteURL]
353
+	 * @return string[] [user, remoteURL]
354 354
 	 * @throws \Exception
355 355
 	 */
356 356
 	public function splitUserRemote($address) {
@@ -625,6 +625,9 @@  discard block
 block discarded – undo
625 625
 		return $result;
626 626
 	}
627 627
 
628
+	/**
629
+	 * @param string $search
630
+	 */
628 631
 	protected function getLookup($search) {
629 632
 		$client = $this->clientService->newClient();
630 633
 
Please login to merge, or discard this patch.