Completed
Pull Request — master (#2643)
by Jan-Christoph
85:17 queued 76:35
created
apps/files_sharing/lib/Helper.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -303,6 +303,7 @@
 block discarded – undo
303 303
 	 * get default share folder
304 304
 	 *
305 305
 	 * @param \OC\Files\View
306
+	 * @param View $view
306 307
 	 * @return string
307 308
 	 */
308 309
 	public static function getShareFolder($view = null) {
Please login to merge, or discard this patch.
lib/private/DB/Migrator.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -273,6 +273,10 @@  discard block
 block discarded – undo
273 273
 		return '/^' . preg_quote($this->config->getSystemValue('dbtableprefix', 'oc_')) . '/';
274 274
 	}
275 275
 
276
+	/**
277
+	 * @param integer $step
278
+	 * @param integer $max
279
+	 */
276 280
 	protected function emit($sql, $step, $max) {
277 281
 		if ($this->noEmit) {
278 282
 			return;
@@ -283,6 +287,10 @@  discard block
 block discarded – undo
283 287
 		$this->dispatcher->dispatch('\OC\DB\Migrator::executeSql', new GenericEvent($sql, [$step+1, $max]));
284 288
 	}
285 289
 
290
+	/**
291
+	 * @param integer $step
292
+	 * @param integer $max
293
+	 */
286 294
 	private function emitCheckStep($tableName, $step, $max) {
287 295
 		if(is_null($this->dispatcher)) {
288 296
 			return;
Please login to merge, or discard this patch.
lib/private/User/Session.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
 	 * @param IRequest $request
301 301
 	 * @throws LoginException
302 302
 	 * @throws PasswordLoginForbiddenException
303
-	 * @return boolean
303
+	 * @return boolean|null
304 304
 	 */
305 305
 	public function logClientIn($user, $password, IRequest $request) {
306 306
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -340,6 +340,9 @@  discard block
 block discarded – undo
340 340
 		return $this->config->getSystemValue('token_auth_enforced', false);
341 341
 	}
342 342
 
343
+	/**
344
+	 * @param string $username
345
+	 */
343 346
 	protected function isTwoFactorEnforced($username) {
344 347
 		Util::emitHook(
345 348
 			'\OCA\Files_Sharing\API\Server2Server',
Please login to merge, or discard this patch.
settings/Controller/CheckSetupController.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -103,6 +103,7 @@  discard block
 block discarded – undo
103 103
 
104 104
 	/**
105 105
 	* Chceks if the ownCloud server can connect to a specific URL using both HTTPS and HTTP
106
+	* @param string $sitename
106 107
 	* @return bool
107 108
 	*/
108 109
 	private function isSiteReachable($sitename) {
@@ -285,7 +286,7 @@  discard block
 block discarded – undo
285 286
 
286 287
 	/**
287 288
 	 * @NoCSRFRequired
288
-	 * @return DataResponse
289
+	 * @return DataDisplayResponse
289 290
 	 */
290 291
 	public function getFailedIntegrityCheckFiles() {
291 292
 		if(!$this->checker->isCodeCheckEnforced()) {
Please login to merge, or discard this patch.
lib/private/Repair/RepairUnmergedShares.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -219,7 +219,7 @@
 block discarded – undo
219 219
 	 * @param array $groupSharesById
220 220
 	 * @param array $subShares
221 221
 	 *
222
-	 * @return true if the share is valid, false if it needs repair
222
+	 * @return boolean if the share is valid, false if it needs repair
223 223
 	 */
224 224
 	private function isThisShareValid($groupSharesById, $subShares) {
225 225
 		$foundTargets = [];
Please login to merge, or discard this patch.
apps/user_ldap/lib/Wizard.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1104,7 +1104,7 @@
 block discarded – undo
1104 1104
 	}
1105 1105
 
1106 1106
 	/**
1107
-	 * @param array $reqs
1107
+	 * @param string[] $reqs
1108 1108
 	 * @return bool
1109 1109
 	 */
1110 1110
 	private function checkRequirements($reqs) {
Please login to merge, or discard this patch.
lib/private/legacy/db.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -151,7 +151,6 @@
 block discarded – undo
151 151
 	/**
152 152
 	 * saves database schema to xml file
153 153
 	 * @param string $file name of file
154
-	 * @param int $mode
155 154
 	 * @return bool
156 155
 	 *
157 156
 	 * TODO: write more documentation
Please login to merge, or discard this patch.
lib/private/User/User.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -413,6 +413,10 @@
 block discarded – undo
413 413
 		return $url;
414 414
 	}
415 415
 
416
+	/**
417
+	 * @param string $feature
418
+	 * @param string $value
419
+	 */
416 420
 	public function triggerChange($feature, $value = null) {
417 421
 		if ($this->emitter) {
418 422
 			$this->emitter->emit('\OC\User', 'changeUser', array($this, $feature, $value));
Please login to merge, or discard this patch.
lib/private/AllConfig.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -116,8 +116,8 @@
 block discarded – undo
116 116
 	 * Looks up a system wide defined value
117 117
 	 *
118 118
 	 * @param string $key the key of the value, under which it was saved
119
-	 * @param mixed $default the default value to be returned if the value isn't set
120
-	 * @return mixed the value or $default
119
+	 * @param string|false $default the default value to be returned if the value isn't set
120
+	 * @return string the value or $default
121 121
 	 */
122 122
 	public function getSystemValue($key, $default = '') {
123 123
 		return $this->systemConfig->getValue($key, $default);
Please login to merge, or discard this patch.